[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signed-zeros -freciprocal-math \

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a comment. @dexonsmith, thanks for sharing your idea. Overall, I like the simplicity. As you say, not every command line option has an associated `CodeGenOptions` or `LangOptions` field. For this patch only, we'd need to create the following fields: -

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 added a subscriber: Anastasia. jansvoboda11 added a comment. Using the records with `DefaultAnyOf<[...]>` to catch errors seems to work well, thanks for the suggestion. (I was initially thinking about using the keypaths to avoid errors and reorder the options in the TableGen

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 300979. jansvoboda11 added a comment. Fix typo & whitespace. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Driver/Options.td

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

jansvoboda11 updated this revision to Diff 300975. jansvoboda11 added a comment. Formalize the "implied by" relationship with `DefaultAnyOf<[...]>`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82756/new/ https://reviews.llvm.org/D82756 Files:

[PATCH] D94474: [WIP][clang][cli] Test manual header search argument generation with round-trip

jansvoboda11 planned changes to this revision. jansvoboda11 added a comment. Marking this as "Changes Planned" to not occupy reviewers' Ready to Review queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94474/new/

[PATCH] D93395: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ab803095ae5: [clang][cli] Remove -f[no-]trapping-math from -cc1 command line (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D94474: [WIP][clang][cli] Test manual header search argument generation with round-trip

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: hiraditya. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch tests the manual

[PATCH] D94472: [clang][cli] Manually generate header search arguments

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements generation of remaining header search arguments. It's done manually

[PATCH] D94488: [clang][cli] Port more CodeGenOptions to marshalling infrastructure

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Leveraging the recently added marshalling constructs.

[PATCH] D94488: [clang][cli] Port more CodeGenOptions to marshalling infrastructure

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1165 + ChangedBy, ResetBy>; +defm test_coverage : BoolFOption<"test-coverage", + "CodeGenOpts.EmitGcovNotes", DefaultsToFalse, The `profile_arcs` and `test_coverage` options

[PATCH] D84674: [clang][cli] Allow users to specify a conditional to prevent parsing options with MarshallingInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77db83ae9977: [clang][cli] Allow users to specify a conditional to prevent parsing options… (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93636: [clang][cli] Implement ContainsN Google Test matcher

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6ea4d5b2c00: [clang][cli] Implement ContainsN Google Test matcher (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93679: [clang][cli] Port getAllArgumentValues to the marshalling infrastructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6ba59830796: [clang][cli] Port getAllArgumentValues to the marshalling infrastructure (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93700: [clang][cli] Report the actual argument parsing result

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33f90f38e11c: [clang][cli] Report the actual argument parsing result (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93698: [clang][cli] Port a CommaJoined option to the marshalling infrastructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa828fb463ed9: [clang][cli] Port a CommaJoined option to the marshalling infrastructure (authored by jansvoboda11). Changed prior to commit:

[PATCH] D93701: [clang][cli] NFC: Ensure non-null DiagnosticsEngine in ParseDiagnosticArgs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe72cdc5ba1e6: [clang][cli] NFC: Ensure non-null DiagnosticsEngine in ParseDiagnosticArgs (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D93701?vs=314866=315108#toc

[PATCH] D94172: [clang][cli] NFC: Move parseSimpleArgs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75d63630ebb1: [clang][cli] NFC: Move parseSimpleArgs (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 315117. jansvoboda11 added a comment. Move the "DiagnosticOpts->" prefix from TableGen definitions to macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673

[PATCH] D93701: [clang][cli] NFC: Ensure non-null DiagnosticsEngine in ParseDiagnosticArgs

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1400-1402 bool clang::ParseDiagnosticArgs(DiagnosticOptions , ArgList , -DiagnosticsEngine *Diags, +DiagnosticsEngine ,

[PATCH] D93702: [clang][cli] NFC: Make parsing macro reusable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcd1e35e4cc6: [clang][cli] NFC: Make parsing macro reusable (authored by jansvoboda11). Changed prior to commit:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 315115. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files: clang/include/clang/Basic/DiagnosticOptions.h

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 315131. jansvoboda11 added a comment. Don't create diagnostics_fixit_info via BoolXxxOption to keep the distinstion of Group and Group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1193-1195 +defm caret_diagnostics : BoolFOption<"caret-diagnostics", + "DiagnosticOpts->ShowCarets", DefaultsToTrue, + ChangedBy, ResetBy>, IsDiag; dexonsmith wrote: > There

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308312. jansvoboda11 added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308064. jansvoboda11 added a comment. Rebase & revert move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83940/new/ https://reviews.llvm.org/D83940 Files:

[PATCH] D83940: Port HeaderSearch option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83940/new/

[PATCH] D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308074. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83940/new/ https://reviews.llvm.org/D83940 Files: clang/include/clang/Driver/Options.td

[PATCH] D83979: Port LangOpts option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308311. jansvoboda11 added a comment. Rebase, move options back, port new options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files:

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308322. jansvoboda11 added a comment. Revert accidental changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h

[PATCH] D90484: FileManager: Add FileEntryRef::getDir, returning DirectoryEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Left tiny question inline, but LGTM anyways. Comment at: clang/unittests/Basic/FileEntryTest.cpp:95 OptionalFileEntryRefDegradesToFileEntryPtr M0;

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90053/new/ https://reviews.llvm.org/D90053 ___ cfe-commits mailing list

[PATCH] D90485: Lex: Update Module::findHeader to return FileEntryRef, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90485/new/ https://reviews.llvm.org/D90485 ___ cfe-commits mailing list

[PATCH] D90497: Module: Use FileEntryRef and DirectoryEntryRef in Umbrella, Header, and DirectoryName, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90497/new/ https://reviews.llvm.org/D90497 ___ cfe-commits mailing list

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307577. jansvoboda11 added a comment. Introduce OptOutPositiveFFlag, simplify a couple of boolean options with multiclasses Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307578. jansvoboda11 added a comment. Add squashed commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files: clang/include/clang/Driver/Options.td

[PATCH] D83698: Port Target option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307308. jansvoboda11 added a comment. Undo moving of options (NFC) & rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698 Files:

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307771. jansvoboda11 added a comment. Port AAPCS flags, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files: clang/include/clang/Driver/Options.td

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307772. jansvoboda11 added a comment. Remove whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files: clang/include/clang/Driver/Options.td

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307780. jansvoboda11 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Revert accidental help change, do not AlwaysEmit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. This is now ready to be reviewed. If you see a deleted option in the diff, it's either because it was moved closer to its counterpart, or because it's now generated by a multiclass. I've added a bunch of TODOs I plan to address in a future patch, most of them aim

[PATCH] D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC)

jansvoboda11 updated this revision to Diff 307838. jansvoboda11 added a comment. Remove lifetime comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3258566868b: [clang][cli] Port Target option flags to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 307837. jansvoboda11 added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Implement review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/

[PATCH] D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC)

jansvoboda11 updated this revision to Diff 307839. jansvoboda11 added a comment. Undo whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D83698: [clang][cli] Port Target option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307855. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83698/new/ https://reviews.llvm.org/D83698 Files: clang/include/clang/Driver/Options.td

[PATCH] D92774: [clang][cli] Add command line marshalling tests

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add more tests of the command line marshalling infrastructure. The new tests now make a

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces more flexible

[PATCH] D92773: [clang][cli] Unify boolean marshalling

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Use lambdas with captures to replace

[PATCH] D92825: [clang][cli] CompilerInvocationTest: join two test fixtures into one

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2bb2239252: [clang][cli] CompilerInvocationTest: join two test fixtures into one (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D92827: [clang][cli] CompilerInvocationTest: split enum test into two

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5afff86d2616: [clang][cli] CompilerInvocationTest: split enum test into two (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D92826: [clang][cli] CompilerInvocationTest: rename member variable in fixture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf825ec86e14b: [clang][cli] CompilerInvocationTest: rename member variable in fixture (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D92829: [clang][cli] CompilerInvocationTest: check arg parsing does not produce diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03692bae1fc9: [clang][cli] CompilerInvocationTest: check arg parsing does not produce… (authored by jansvoboda11). Repository: rG LLVM Github

[PATCH] D92830: [clang][cli] CompilerInvocationTest: join and add test cases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG216d43053b4e: [clang][cli] CompilerInvocationTest: join and add test cases (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35621cc2e3b3: [clang][cli] CompilerInvocationTest: add tests for boolean options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D92828: [clang][cli] CompilerInvocationTest: remove unnecessary command line arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4894e423e7b4: [clang][cli] CompilerInvocationTest: remove unnecessary command line arguments (authored by jansvoboda11). Repository: rG LLVM

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 updated this revision to Diff 310135. jansvoboda11 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92775/new/ https://reviews.llvm.org/D92775 Files: clang/include/clang/Driver/Options.td

[PATCH] D92678: ARCMigrate: Migrate ObjCMT.cpp over to FileEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92678/new/ https://reviews.llvm.org/D92678

[PATCH] D92826: [clang][cli] CompilerInvocationTest: rename member variable in fixture

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added a reviewer: a.sidorin. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92825 .

[PATCH] D92827: [clang][cli] CompilerInvocationTest: split enum test into two

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92826 . Repository: rG LLVM Github Monorepo

[PATCH] D92774: [clang][cli] Add command line marshalling tests

jansvoboda11 added a comment. I'm sorry about that, I understand that was hard to review. This is now split this into multiple patches: D92825 , D92826 , D92827 , D92828

[PATCH] D92699: Frontend: Migrate to FileEntryRef in VerifyDiagnosticConsumer.cpp, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92699/new/ https://reviews.llvm.org/D92699

[PATCH] D92680: Frontend: Migrate to FileEntryRef in CompilerInstance::InitializeSourceManager, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92680/new/ https://reviews.llvm.org/D92680

[PATCH] D92825: [clang][cli] CompilerInvocationTest: join two test fixtures into one

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added a reviewer: a.sidorin. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 added a comment. That's great to hear, thanks. Comment at: clang/include/clang/Driver/Options.td:371 + // TODO: Assert that the flags have different value. + // TODO: Assert that only one of the flags can be implied. + Does TableGen support some

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 added a comment. Ready to be reviewed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92830: [clang][cli] CompilerInvocationTest: join and add test cases

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92829 . Repository: rG LLVM Github Monorepo

[PATCH] D92829: [clang][cli] CompilerInvocationTest: check arg parsing does not produce diagnostics

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92828 . Repository: rG LLVM Github Monorepo

[PATCH] D92828: [clang][cli] CompilerInvocationTest: remove unnecessary command line arguments

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D92827 . Repository: rG LLVM Github Monorepo

[PATCH] D92773: [clang][cli] Unify boolean marshalling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG083e035c47f6: [clang][cli] Unify boolean marshalling (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. Left a couple of nits and a question, but LGTM overall. Comment at: clang/include/clang/Basic/DirectoryEntry.h:104 + bool isSpecialDenseMapKey() const { +

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 added a comment. WIP, need to fix a typo in the test. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:141 + ASSERT_TRUE(Diags->hasErrorOccurred()); // Driver-only flag. + ASSERT_TRUE(Invocation.getCodeGenOpts().Autolink); +} This

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 updated this revision to Diff 310176. jansvoboda11 added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp

[PATCH] D92630: ARCMigrate: Use hash_combine in the DenseMapInfo for EditEntry

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92630/new/ https://reviews.llvm.org/D92630

[PATCH] D92774: [clang][cli] Add command line marshalling tests

jansvoboda11 updated this revision to Diff 310134. jansvoboda11 added a comment. Split into multiple patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 Files:

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91317/new/ https://reviews.llvm.org/D91317 ___ cfe-commits mailing list

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:226 ASSERT_THAT(GeneratedArgs, - Contains(StrEq("-fno-experimental-new-pass-manager"))); +

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 updated this revision to Diff 310249. jansvoboda11 added a comment. Split out change to "always emit" behavior of `-f[no-]experimental-new-pass-manager` and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92775/new/

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]experimental-new-pass-manager

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. We don't need to always generate

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 added a comment. This patch was reverted as it broke a build: http://lab.llvm.org:8011/#/builders/14/builds/2986 The assertions will need to take into account the actual value of `LLVM_ENABLE_NEW_PASS_MANAGER`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4062 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D83697: [clang][cli] Port Frontend option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307045. jansvoboda11 added a comment. Drop namespace specifier & names of unused args, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83697/new/ https://reviews.llvm.org/D83697 Files:

[PATCH] D83892: Port CodeGen option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 307535. jansvoboda11 added a comment. Herald added a subscriber: jfb. Rebase, undo unnecessary moves, port recently added options, add TODOs (WIP) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

jansvoboda11 updated this revision to Diff 310792. jansvoboda11 added a comment. Fix comment typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93008/new/ https://reviews.llvm.org/D93008 Files: clang/include/clang/Driver/Options.td

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. We cannot be sure whether a flag is

[PATCH] D92967: Tooling: Migrate some tests to FileEntryRef, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92967/new/ https://reviews.llvm.org/D92967 ___ cfe-commits mailing list

[PATCH] D92968: Frontend: Migrate to FileEntryRef in TextDiagnosticTest, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92968/new/ https://reviews.llvm.org/D92968

[PATCH] D92971: clang-import-test: Clean up error output for files that cannot be found

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92971/new/ https://reviews.llvm.org/D92971

[PATCH] D92975: Lex: Migrate HeaderSearch::LoadedModuleMaps to FileEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92975/new/ https://reviews.llvm.org/D92975 ___ cfe-commits mailing list

[PATCH] D92983: SourceManager: Migrate to FileEntryRef in getOrCreateContentCache, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. This LGTM, but it'd be nice to apply the formatting suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92983/new/

[PATCH] D92984: SourceManager: Change getOrCreateFileID API to take FileEntryRef, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. This LGTM, but it'd be nice to apply the formatting suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92984/new/

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 310870. jansvoboda11 added a comment. Rebase, use BoolOption Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files: clang/include/clang/Driver/Options.td

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. This is now ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 ___ cfe-commits mailing list

[PATCH] D90733: Frontend: Sink named pipe logic from CompilerInstance down to FileManager

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90733/new/ https://reviews.llvm.org/D90733 ___ cfe-commits mailing list

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108 bool CanReuse(const CompilerInvocation , -const llvm::MemoryBuffer

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 added a comment. @Bigcheese brought up that if you wanted to mimic the current logic in `OptInFFlag` that automatically creates the `-cc1` option with my current proposal, you'd need to remember to pass it to the right `Flags` (e.g.: use `NegativeFlag<[CC1Option]>` when using

[PATCH] D83211: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG973843681b9d: [clang][cli] Factor out call to EXTRACTOR in generateCC1CommandLine (NFC) (authored by jansvoboda11). Repository: rG LLVM Github

  1   2   3   4   5   6   7   8   9   10   >