[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

jvikstrom added a comment. Should we have different highlightings for declarations vs usages? (Although I guess in the end it will be up to the editor if they highlight them differently as the scope is just more specific for declarations) I guess I personally don't really see the reason as it sh

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

jvikstrom added a comment. Pinging about this @ilya-biryukov Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66516/new/ https://reviews.llvm.org/D66516 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D66928: [clangd] Collecting main file macro expansion locations in ParsedAST.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370452: [clangd] Collecting main file macro expansion locations in ParsedAST. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. https://github.com/clangd/clangd/issues/134 Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:443 +$Primitive[[int]] $Variable[[A]][2] = {1,2}; +auto [$Variable[[B1]], $Variable[[B2]]] = $Variable[[A]]; +

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom updated this revision to Diff 218061. jvikstrom added a comment. Removed SourceManager field from HighlightingTokenCollector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 Files: clang-tools-e

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom updated this revision to Diff 218087. jvikstrom marked 3 inline comments as done. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 Files: clang-tools-

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + case HighlightingKind::MacroExpansion: +return "entity.name.function.preprocessor.expansion.cpp"; case HighlightingKind::NumKinds: ilya-biryukov wrote: >

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

jvikstrom updated this revision to Diff 218089. jvikstrom added a comment. Renamed MacroExpansion to Macro. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66995/new/ https://reviews.llvm.org/D66995 Files: clang-tools-extra/clangd/SemanticHighligh

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370473: [clangd] Added highlighting for structured bindings. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D66995: [clangd] Add highlighting for macro expansions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370482: [clangd] Add highlighting for macro expansions. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

<    1   2   3   4