[clang] [clang] Support fixed point type mangling (PR #67750)

https://github.com/rjmccall commented: This patch is *primarily* adding support for fixed-point types to C++, which seems like it ought to be in the PR title. With that said, I don't have any objection to either the goal or the implementation. https://github.com/llvm/llvm-project/pull/67750 _

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -0,0 +1,167 @@ +/*=== ptrauth.h - Pointer authentication ---=== + * + * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + * See https://llvm.org/LICENSE.txt for license information. + * SPDX-License-Identifier: Apac

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/65996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][PAC] Support ptrauth builtins and -fptrauth-intrinsics. (PR #65996)

@@ -4869,6 +4869,73 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__iso_volatile_store64: return RValue::get(EmitISOVolatileStore(*this, E)); + case Builtin::BI__builtin_ptrauth_auth: + case Builtin::BI__builtin_pt

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rjmccall requested changes to this pull request. Functionally LGTM; just a minor request. https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

@@ -812,11 +815,13 @@ ABIArgInfo X86_32ABIInfo::classifyArgumentType(QualType Ty, CCState &State, } llvm::IntegerType *PaddingType = NeedsPadding ? Int32 : nullptr; -// Pass over-aligned aggregates on Windows indirectly. This behavior was -// added in MSVC 201

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

On Mon, Nov 22, 2021 at 2:28 PM John McCall wrote: > On Mon, Nov 22, 2021 at 1:08 PM David Goldblatt via Phabricator < > revi...@reviews.llvm.org> wrote: > >> and related projects avoid relying on alignment guarantees (e.g. >> libstdc++ at one point considered assuming that 8-byte allocs were 16-

Re: [PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

On Mon, Nov 22, 2021 at 1:08 PM David Goldblatt via Phabricator < revi...@reviews.llvm.org> wrote: > davidtgoldblatt added a comment. > > (For background: I'm a jemalloc maintainer and wrote N2293). > > In D100879#3145361 , @rjmccall > wrote: > > > Platfor

[clang] 5ab6ee7 - Fix a variety of bugs with nil-receiver checks when targeting

Author: John McCall Date: 2021-10-08T05:44:06-04:00 New Revision: 5ab6ee75994d645725264e757d67bbb1c96fb2b6 URL: https://github.com/llvm/llvm-project/commit/5ab6ee75994d645725264e757d67bbb1c96fb2b6 DIFF: https://github.com/llvm/llvm-project/commit/5ab6ee75994d645725264e757d67bbb1c96fb2b6.diff L

[clang] cec49a5 - Revert "[SYCL] Implement __builtin_unique_stable_name."

Author: John McCall Date: 2020-10-12T01:10:09-04:00 New Revision: cec49a583693752b3984e49f9c193de07c2a7698 URL: https://github.com/llvm/llvm-project/commit/cec49a583693752b3984e49f9c193de07c2a7698 DIFF: https://github.com/llvm/llvm-project/commit/cec49a583693752b3984e49f9c193de07c2a7698.diff L

[clang] 984744a - Fix a variety of minor issues with ObjC method mangling:

Author: John McCall Date: 2020-09-29T19:51:53-04:00 New Revision: 984744a1314ce165378e7945bc45995302a8cb80 URL: https://github.com/llvm/llvm-project/commit/984744a1314ce165378e7945bc45995302a8cb80 DIFF: https://github.com/llvm/llvm-project/commit/984744a1314ce165378e7945bc45995302a8cb80.diff L

[clang] 98ef7e2 - This reduces code duplication between CGObjCMac.cpp and Mangle.cpp

Author: Ellis Hoag Date: 2020-09-29T02:26:51-04:00 New Revision: 98ef7e29b0fe03da77fa6ef5c86bea9e31c178d0 URL: https://github.com/llvm/llvm-project/commit/98ef7e29b0fe03da77fa6ef5c86bea9e31c178d0 DIFF: https://github.com/llvm/llvm-project/commit/98ef7e29b0fe03da77fa6ef5c86bea9e31c178d0.diff LO

[clang] 7fac1ac - Set the LLVM FP optimization flags conservatively.

Author: John McCall Date: 2020-06-11T18:16:41-04:00 New Revision: 7fac1acc617113b7a3276ee0f0664bedca978292 URL: https://github.com/llvm/llvm-project/commit/7fac1acc617113b7a3276ee0f0664bedca978292 DIFF: https://github.com/llvm/llvm-project/commit/7fac1acc617113b7a3276ee0f0664bedca978292.diff L

[clang] 8a8d703 - Fix how cc1 command line options are mapped into FP options.

Author: John McCall Date: 2020-06-01T22:00:30-04:00 New Revision: 8a8d703be0986dd6785cba0b610c9c4708b83e89 URL: https://github.com/llvm/llvm-project/commit/8a8d703be0986dd6785cba0b610c9c4708b83e89 DIFF: https://github.com/llvm/llvm-project/commit/8a8d703be0986dd6785cba0b610c9c4708b83e89.diff L

[clang] 32870a8 - Expose IRGen API to add the default IR attributes to a function definition.

Author: John McCall Date: 2020-05-16T14:44:54-04:00 New Revision: 32870a84d9a40ea682e22a24b5f0d1a218c3b062 URL: https://github.com/llvm/llvm-project/commit/32870a84d9a40ea682e22a24b5f0d1a218c3b062 DIFF: https://github.com/llvm/llvm-project/commit/32870a84d9a40ea682e22a24b5f0d1a218c3b062.diff L

[clang] e4422ae - Rewrite the non-trivial structs section of the ARC spec.

Author: John McCall Date: 2020-03-06T02:51:45-05:00 New Revision: e4422ae0f6e4159a8560514ce221306c30a7f2c1 URL: https://github.com/llvm/llvm-project/commit/e4422ae0f6e4159a8560514ce221306c30a7f2c1 DIFF: https://github.com/llvm/llvm-project/commit/e4422ae0f6e4159a8560514ce221306c30a7f2c1.diff L

[clang] 7848a3c - Update the ARC docs for non-trivial ownership in structs.

Author: John McCall Date: 2020-02-26T16:42:08-05:00 New Revision: 7848a3c8ab54570f5875e63606ff75b5736750b4 URL: https://github.com/llvm/llvm-project/commit/7848a3c8ab54570f5875e63606ff75b5736750b4 DIFF: https://github.com/llvm/llvm-project/commit/7848a3c8ab54570f5875e63606ff75b5736750b4.diff L

[clang] 77b2ffc - Fix a reentrance bug with deserializing ObjC type parameters.

Author: John McCall Date: 2020-02-12T18:44:19-05:00 New Revision: 77b2ffc498e92cce7546d191f6712a3046300501 URL: https://github.com/llvm/llvm-project/commit/77b2ffc498e92cce7546d191f6712a3046300501 DIFF: https://github.com/llvm/llvm-project/commit/77b2ffc498e92cce7546d191f6712a3046300501.diff L

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:18 PM Aaron Ballman wrote: > It seems like GCC doesn't do good things when trying to link two > functions with empty asm labels but Clang does seem to do something > reasonable. I can't quite tell whether this is a case for a diagnostic > or not. Note the generated assembl

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 3:02 PM Aaron Ballman wrote: > On Tue, Jan 7, 2020 at 2:57 PM John McCall via cfe-commits > wrote: > > On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator > > wrote: > > > Sorry to dredge up an old review, but I recently ran into a bug

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator wrote: > aaron.ballman added inline comments. > > > > Comment at: cfe/trunk/lib/AST/Mangle.cpp:127 > +// do not add a "\01" prefix. > +if (!ALA->getIsLiteralLabel() || ALA->getLabel().startswith("llvm.")) { > +

[clang] 803403a - Fix a bug in the property-based serialization of

Author: John McCall Date: 2019-12-16T16:08:09-05:00 New Revision: 803403afc83f659be1c620eb1896dcf704b18b0a URL: https://github.com/llvm/llvm-project/commit/803403afc83f659be1c620eb1896dcf704b18b0a DIFF: https://github.com/llvm/llvm-project/commit/803403afc83f659be1c620eb1896dcf704b18b0a.diff L

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

On 16 Dec 2019, at 15:11, John McCall wrote: On 16 Dec 2019, at 15:07, Vedant Kumar wrote: Hi John, The lldb bot went red after your clang AST changes landed: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/4801/changes#detail0

Re: [clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

any issues with missing emails lately? On Dec 16, 2019, at 10:34 AM, John McCall via cfe-commits wrote: Author: John McCall Date: 2019-12-16T13:33:59-05:00 New Revision: 00bc76edddb5a6cd417610e96289a5dc15245867 URL: https://github.com/llvm/llvm-project/commit/00bc76edddb5a6cd417610e96289a5dc

[clang] c82e4ef - Always -I clang/include when tblgen'ing in Clang.

Author: John McCall Date: 2019-12-16T13:33:59-05:00 New Revision: c82e4ef6960b9f09fc77abc10f374417007f5f00 URL: https://github.com/llvm/llvm-project/commit/c82e4ef6960b9f09fc77abc10f374417007f5f00 DIFF: https://github.com/llvm/llvm-project/commit/c82e4ef6960b9f09fc77abc10f374417007f5f00.diff L

[clang] 00bc76e - Move Basic{Reader,Writer} emission into ASTPropsEmitter; NFC.

Author: John McCall Date: 2019-12-16T13:33:59-05:00 New Revision: 00bc76edddb5a6cd417610e96289a5dc15245867 URL: https://github.com/llvm/llvm-project/commit/00bc76edddb5a6cd417610e96289a5dc15245867 DIFF: https://github.com/llvm/llvm-project/commit/00bc76edddb5a6cd417610e96289a5dc15245867.diff L

Re: [clang] 5708f2d - [clang] Fix modules build after addition of TypeBitCodes.def

On 14 Dec 2019, at 12:25, Raphael Isemann via cfe-commits wrote: Author: Raphael Isemann Date: 2019-12-14T18:24:53+01:00 New Revision: 5708f2daf7386ef5f1ec54db4bda2b48bbcbe934 URL: https://github.com/llvm/llvm-project/commit/5708f2daf7386ef5f1ec54db4bda2b48bbcbe934 DIFF: https://github.com/llv

Re: [clang] c2f1831 - Move ASTRecordReader into its own header; NFC.

me/thakis/src/llvm-project/out/gn/obj/clang/test/Modules/Output/merge-lifetime-extended-temporary.cpp.tmp -x c++ -I/usr/local/google/home/thakis/src/llvm-project/clang/test/Modules/Inputs/merge-lifetime-extended-temporary -verify -std=c++11 /usr/local/google/home/thakis/src/llvm-project/clang/test

[clang] c2f1831 - Move ASTRecordReader into its own header; NFC.

Author: John McCall Date: 2019-12-14T03:28:23-05:00 New Revision: c2f18315ff53006e44afe065368019e41cb98053 URL: https://github.com/llvm/llvm-project/commit/c2f18315ff53006e44afe065368019e41cb98053 DIFF: https://github.com/llvm/llvm-project/commit/c2f18315ff53006e44afe065368019e41cb98053.diff L

[clang] d14a569 - MSVC build fix: forget some unneeded and incorrect friends.

Author: John McCall Date: 2019-12-14T01:02:09-05:00 New Revision: d14a5693c07f0fb1b82c75ed72f77a495751dcf7 URL: https://github.com/llvm/llvm-project/commit/d14a5693c07f0fb1b82c75ed72f77a495751dcf7 DIFF: https://github.com/llvm/llvm-project/commit/d14a5693c07f0fb1b82c75ed72f77a495751dcf7.diff L

[clang] a7950ff - [NFC] Correct accidental use of tabs.

Author: John McCall Date: 2019-12-14T00:16:47-05:00 New Revision: a7950ffd12caa2fb7ed4704128011bceeacd35e9 URL: https://github.com/llvm/llvm-project/commit/a7950ffd12caa2fb7ed4704128011bceeacd35e9 DIFF: https://github.com/llvm/llvm-project/commit/a7950ffd12caa2fb7ed4704128011bceeacd35e9.diff L

[clang] b6f03a5 - [NFC] Rename ClangASTEmitters.h -> ASTTableGen.h

Author: John McCall Date: 2019-12-14T00:16:47-05:00 New Revision: b6f03a5a6b57b7858098051e60c2ce2fd4058461 URL: https://github.com/llvm/llvm-project/commit/b6f03a5a6b57b7858098051e60c2ce2fd4058461 DIFF: https://github.com/llvm/llvm-project/commit/b6f03a5a6b57b7858098051e60c2ce2fd4058461.diff L

[clang] baf91d0 - [NFC] Add a tablegen node for the root of the AST node hierarchies.

Author: John McCall Date: 2019-10-25T16:39:21-07:00 New Revision: baf91d02da6e68c4ee6723ef68911fcd80ece6a5 URL: https://github.com/llvm/llvm-project/commit/baf91d02da6e68c4ee6723ef68911fcd80ece6a5 DIFF: https://github.com/llvm/llvm-project/commit/baf91d02da6e68c4ee6723ef68911fcd80ece6a5.diff L

Re: r373406 - Use scope qualifiers in Clang's tblgen backends to get useful

4:10 PM John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: Author: rjmccall Date: Tue Oct 1 16:12:57 2019 New Revision: 373406 URL: http://llvm.org/viewvc/llvm-project?rev=373406&view=rev Log: Use scope qualifiers in Clang's tblgen backends to get useful redeclar

Re: r373407 - Emit TypeNodes.def with tblgen.

just to re-establish that consistent naming convention. John. On Tue, Oct 1, 2019 at 7:10 PM John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: Author: rjmccall Date: Tue Oct 1 16:13:03 2019 New Revision: 373407 URL: http://llvm.org/viewvc/llvm-project?rev=373407&am

r373425 - Rename TypeNodes.def to TypeNodes.inc for consistency across all

Author: rjmccall Date: Tue Oct 1 23:35:23 2019 New Revision: 373425 URL: http://llvm.org/viewvc/llvm-project?rev=373425&view=rev Log: Rename TypeNodes.def to TypeNodes.inc for consistency across all our autogenerated files. NFC. As requested by Nico Weber. Modified: cfe/trunk/include/clang

Re: r373407 - Emit TypeNodes.def with tblgen.

sites. That said, I could certainly go rename it as a follow-up just to re-establish that consistent naming convention. John. On Tue, Oct 1, 2019 at 7:10 PM John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: Author: rjmccall Date: Tue Oct 1 16:13:03 2019 New Revision: 373407

r373416 - Remove TypeNodes.def from the modulemap.

Author: rjmccall Date: Tue Oct 1 18:02:27 2019 New Revision: 373416 URL: http://llvm.org/viewvc/llvm-project?rev=373416&view=rev Log: Remove TypeNodes.def from the modulemap. We currently just look for files named in the modulemap in its associated source directory. This means that we can't nam

r373407 - Emit TypeNodes.def with tblgen.

Author: rjmccall Date: Tue Oct 1 16:13:03 2019 New Revision: 373407 URL: http://llvm.org/viewvc/llvm-project?rev=373407&view=rev Log: Emit TypeNodes.def with tblgen. The primary goal here is to make the type node hierarchy available to other tblgen backends, although it should also make it easie

r373406 - Use scope qualifiers in Clang's tblgen backends to get useful

Author: rjmccall Date: Tue Oct 1 16:12:57 2019 New Revision: 373406 URL: http://llvm.org/viewvc/llvm-project?rev=373406&view=rev Log: Use scope qualifiers in Clang's tblgen backends to get useful redeclaration checking. NFC. Modified: cfe/trunk/utils/TableGen/ClangASTNodesEmitter.cpp cf

r368796 - Remove unreachable blocks before splitting a coroutine.

Author: rjmccall Date: Tue Aug 13 20:54:13 2019 New Revision: 368796 URL: http://llvm.org/viewvc/llvm-project?rev=368796&view=rev Log: Remove unreachable blocks before splitting a coroutine. The suspend-crossing algorithm is not correct in the presence of uses that cannot be reached on some succe

r362183 - Fix the predefined exponent limit macros for the 16-bit IEEE format.

Author: rjmccall Date: Thu May 30 18:21:36 2019 New Revision: 362183 URL: http://llvm.org/viewvc/llvm-project?rev=362183&view=rev Log: Fix the predefined exponent limit macros for the 16-bit IEEE format. The magnitude range of normalized _Float16 is 2^-14 (~6e-5) to (2-2^-10)*2^15 (65504). You m

r362054 - Add the `objc_class_stub` attribute.

Author: rjmccall Date: Wed May 29 21:09:01 2019 New Revision: 362054 URL: http://llvm.org/viewvc/llvm-project?rev=362054&view=rev Log: Add the `objc_class_stub` attribute. Swift requires certain classes to be not just initialized lazily on first use, but actually allocated lazily using informatio

Re: r358104 - Don't emit an unreachable return block.

al Message- From: cfe-commits On Behalf Of John McCall via cfe-commits Sent: Wednesday, April 10, 2019 10:03 AM To: cfe-commits@lists.llvm.org Subject: r358104 - Don't emit an unreachable return block. Author: rjmccall Date: Wed Apr 10 10:03:09 2019 New Revision: 358104 URL: http://llvm.

r358132 - Add IRGen APIs to fetch ctor/dtor helper functions for non-trivial structs.

Author: rjmccall Date: Wed Apr 10 12:57:20 2019 New Revision: 358132 URL: http://llvm.org/viewvc/llvm-project?rev=358132&view=rev Log: Add IRGen APIs to fetch ctor/dtor helper functions for non-trivial structs. Patch by Tony Allevato! Modified: cfe/trunk/include/clang/CodeGen/CodeGenABITypes

r358125 - Fix for different build configurations.

Author: rjmccall Date: Wed Apr 10 12:11:32 2019 New Revision: 358125 URL: http://llvm.org/viewvc/llvm-project?rev=358125&view=rev Log: Fix for different build configurations. Modified: cfe/trunk/test/CodeGen/unreachable-ret.c Modified: cfe/trunk/test/CodeGen/unreachable-ret.c URL: http://ll

r358115 - Fix an off-by-one mistake in IRGen's copy-construction

Author: rjmccall Date: Wed Apr 10 11:07:18 2019 New Revision: 358115 URL: http://llvm.org/viewvc/llvm-project?rev=358115&view=rev Log: Fix an off-by-one mistake in IRGen's copy-construction special cases in the presence of zero-length arrays. Patch by Joran Bigalet! Modified: cfe/trunk/lib/C

r358104 - Don't emit an unreachable return block.

Author: rjmccall Date: Wed Apr 10 10:03:09 2019 New Revision: 358104 URL: http://llvm.org/viewvc/llvm-project?rev=358104&view=rev Log: Don't emit an unreachable return block. Patch by Brad Moody. Added: cfe/trunk/test/CodeGen/unreachable-ret.c Modified: cfe/trunk/lib/CodeGen/CGCall.cpp

Re: r311065 - Further refactoring of the constant emitter. NFC.

On 18 Mar 2019, at 18:05, John McCall wrote: On 18 Mar 2019, at 15:38, Don Hinton wrote: Hi John: I found this investigating the cast assert noted here: http://lists.llvm.org/pipermail/cfe-dev/2019-March/061685.html I subsequently did quick grep and found a number of cases in clang+llvm (d

Re: r311065 - Further refactoring of the constant emitter. NFC.

On 18 Mar 2019, at 15:38, Don Hinton wrote: Hi John: I found this investigating the cast assert noted here: http://lists.llvm.org/pipermail/cfe-dev/2019-March/061685.html I subsequently did quick grep and found a number of cases in clang+llvm (didn't find any in other projects) . I'm happy t

Re: r311065 - Further refactoring of the constant emitter. NFC.

On 18 Mar 2019, at 14:39, Don Hinton wrote: It looks like this change introduced a small bug; Specifically, the following cast test: - if (auto PT = dyn_cast(DestTy)) { ... + // If we're producing a pointer, this is easy. + if (auto destPtrTy = cast(destTy)) { Since the cast can fail, s

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

's an important use-case. John. On Jan 16, 2019, at 8:37 PM, John McCall via cfe-commits wrote: On 16 Jan 2019, at 20:03, Richard Smith wrote: On Wed, 16 Jan 2019 at 16:20, John McCall via cfe-commits < cfe-commits@lists.llvm.org> wrote: On 16 Jan 2019, at 18:32, Richard Smith

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On 16 Jan 2019, at 20:03, Richard Smith wrote: > On Wed, 16 Jan 2019 at 16:20, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On 16 Jan 2019, at 18:32, Richard Smith wrote: >> >>> On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-comm

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On 16 Jan 2019, at 18:32, Richard Smith wrote: > On Wed, 16 Jan 2019 at 09:10, John McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On 16 Jan 2019, at 9:13, Aaron Ballman wrote: >> >>> On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka >&

Re: r350920 - [Sema] Make canPassInRegisters return true if the CXXRecordDecl passed

On 16 Jan 2019, at 9:13, Aaron Ballman wrote: On Wed, Jan 16, 2019 at 1:57 AM Akira Hatanaka wrote: Yes, the behavior of the compiler doesn’t match what’s explained in the documentation anymore. Please take a look at the attached patch, which updates the documentation. Patch mostly LG

r345536 - In swiftcall, don't merge FP/vector types within a chunk.

Author: rjmccall Date: Mon Oct 29 13:32:36 2018 New Revision: 345536 URL: http://llvm.org/viewvc/llvm-project?rev=345536&view=rev Log: In swiftcall, don't merge FP/vector types within a chunk. Modified: cfe/trunk/include/clang/CodeGen/SwiftCallingConv.h cfe/trunk/lib/CodeGen/SwiftCallingC

Re: [PATCH] D52344: [Clang][CodeGen][ObjC]: Fix non-bridged CoreFoundation builds on ELF targets that use `-fconstant-cfstrings`.

On Sun, Sep 23, 2018 at 5:39 AM David Chisnall via Phabricator < revi...@reviews.llvm.org> wrote: > theraven added a comment. > > In https://reviews.llvm.org/D52344#1242530, @rjmccall wrote: > > > In https://reviews.llvm.org/D52344#1242451, @kristina wrote: > > > > > Would you be okay with me rena

r341491 - Forbid address spaces on compound literals in local scope.

Author: rjmccall Date: Wed Sep 5 12:22:40 2018 New Revision: 341491 URL: http://llvm.org/viewvc/llvm-project?rev=341491&view=rev Log: Forbid address spaces on compound literals in local scope. Patch by Bevin Hansson! Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/tru

r341489 - Add -Wobjc-property-assign-on-object-type.

Author: rjmccall Date: Wed Sep 5 12:02:00 2018 New Revision: 341489 URL: http://llvm.org/viewvc/llvm-project?rev=341489&view=rev Log: Add -Wobjc-property-assign-on-object-type. This is a warning about using 'assign' instead of 'unsafe_unretained' in Objective-C property declarations. It's off b

r337525 - Document -fobjc-weak as an extension.

Author: rjmccall Date: Thu Jul 19 22:40:12 2018 New Revision: 337525 URL: http://llvm.org/viewvc/llvm-project?rev=337525&view=rev Log: Document -fobjc-weak as an extension. Fixes rdar://24091053. Modified: cfe/trunk/docs/LanguageExtensions.rst Modified: cfe/trunk/docs/LanguageExtensions.rst

r337524 - Fix and improve the ARC spec's wording about unmanaged objects.

Author: rjmccall Date: Thu Jul 19 22:40:09 2018 New Revision: 337524 URL: http://llvm.org/viewvc/llvm-project?rev=337524&view=rev Log: Fix and improve the ARC spec's wording about unmanaged objects. Modified: cfe/trunk/docs/AutomaticReferenceCounting.rst Modified: cfe/trunk/docs/AutomaticRef

r333791 - Cap "voluntary" vector alignment at 16 for all Darwin platforms.

Author: rjmccall Date: Fri Jun 1 14:34:26 2018 New Revision: 333791 URL: http://llvm.org/viewvc/llvm-project?rev=333791&view=rev Log: Cap "voluntary" vector alignment at 16 for all Darwin platforms. This fixes two major problems: - We were not capping vector alignment as desired on 32-bit ARM. -

Re: [PATCH] D45476: [C++2a] Implement operator<=> CodeGen and ExprConstant

I think you and Richard agreed that you weren’t going to synthesize a whole expression tree at every use of the operator, and I agree with that decision. That’s very different from what I’m asking you to do, which is to synthesize in isolation a call to the copy-constructor. There are several place

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 8:23 PM, Richard Smith wrote: > On 23 April 2018 at 16:23, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Mon, Apr 23, 2018 at 4:12 PM John McCall wrote: >> >>> On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie >>> wrote: >>> On Mon, Apr 2

Re: [PATCH] D45766: [Sema] Add -Wno-self-assign-overloaded

On Mon, Apr 23, 2018 at 6:32 PM, David Blaikie wrote: > On Mon, Apr 23, 2018 at 3:29 PM John McCall via Phabricator < > revi...@reviews.llvm.org> wrote: > >> rjmccall added a comment. >> >> In https://reviews.llvm.org/D45766#1076176, @dblaikie wrote: >> >> > Is there anything else in the "-w" nam

Re: [PATCH] D45685: [Sema] Add -wtest global flag that silences -Wself-assign for overloaded operators.

Let me try to summarize where I think we are. 1. I think it’s now generally agreed that this is a useful warning — certainly for field assignments, but we also have (at least?) one example with a local variable. 2. It’s also generally agreed that this warning has a problem with unit tests and tha

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 9, 2018, at 3:47 PM, Akira Hatanaka wrote: > > >> On Apr 5, 2018, at 1:25 PM, John McCall > > wrote: >> >> >> >>> On Apr 5, 2018, at 3:54 PM, Akira Hatanaka >> > wrote: >>> >>> On Apr 5, 2018, at 12:39 PM, John McCall >>>

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

(Sorry for the delay in responding — I'm actually on vacation.) On Tue, Apr 10, 2018 at 1:52 PM, David Blaikie wrote: > On Tue, Apr 10, 2018 at 10:20 AM John McCall wrote: > >> Do you think they’re bad precedent? > > > Somewhat, yes - though -Wparens is perhaps conflating a few cases too. I > t

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

Do you think they’re bad precedent? Do you have a replacement for that approach to warning about those problems? Because they certainly were precedent for -Wfallthrough, and they certainly catch a class of bugs at least as large and important as that warning, and they certainly have exactly the sam

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

Also, the standard for the static analyzer is not lower than it is for the compiler. The static analyzer tries to catch a much larger class of bugs, but it also tries very hard to make all the warnings it emits count. There’s a really common problem in the static analysis field where users try a s

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

Yeah, -Wself-assign in general is about catching a class of live-coding errors which is pretty unlikely to ever make it into committed code, since the code would need to be dead/redundant for the mistake to not be noticed. So it’s specifically a rather poor match for the static analyzer, and I woul

Re: [PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

If you have a concrete suggestion of how to suppress this warning for user-defined operators just in unit tests, great. I don’t think 8 easily-suppressed warnings is an unacceptably large false-positive problem, though. Most warnings have similar problems, and the standard cannot possibly be “must

r329513 - Generalize the swiftcall API since being passed indirectly isn't

Author: rjmccall Date: Sat Apr 7 13:16:47 2018 New Revision: 329513 URL: http://llvm.org/viewvc/llvm-project?rev=329513&view=rev Log: Generalize the swiftcall API since being passed indirectly isn't C++-specific anymore. Modified: cfe/trunk/include/clang/CodeGen/SwiftCallingConv.h cfe/tr

r329508 - Allow equality comparisons between block pointers and

Author: rjmccall Date: Sat Apr 7 10:42:06 2018 New Revision: 329508 URL: http://llvm.org/viewvc/llvm-project?rev=329508&view=rev Log: Allow equality comparisons between block pointers and block-pointer-compatible ObjC object pointer types. Patch by Dustin Howett! Added: cfe/trunk/test/SemaO

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 5, 2018, at 3:54 PM, Akira Hatanaka wrote: > > >> On Apr 5, 2018, at 12:39 PM, John McCall > > wrote: >> >> >> >>> On Apr 4, 2018, at 7:37 PM, Akira Hatanaka >> > wrote: >>> >>> >>> On Apr 4, 2018, at 4:24 PM, Akira Hat

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 4, 2018, at 7:37 PM, Akira Hatanaka wrote: > > > >> On Apr 4, 2018, at 4:24 PM, Akira Hatanaka via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >>> >>> On Apr 4, 2018, at 3:38 PM, Richard Smith >> > wrote: >>> >>> Hi Akira, >>> >>> T

r328942 - Fix a major swiftcall ABI bug with trivial C++ class types.

Author: rjmccall Date: Sun Apr 1 14:04:30 2018 New Revision: 328942 URL: http://llvm.org/viewvc/llvm-project?rev=328942&view=rev Log: Fix a major swiftcall ABI bug with trivial C++ class types. The problem with the previous logic was that there might not be any explicit copy/move constructor dec

Re: r326946 - CodeGen: Fix address space of indirect function argument

> On Mar 9, 2018, at 8:51 PM, Richard Smith wrote: > > Hi, > > This change increases the size of a CallArg, and thus that of a CallArgList, > dramatically (an LValue is *much* larger than an RValue, and unlike an > RValue, does not appear to be at all optimized for size). This results in > Ca

r324377 - Pass around function pointers as CGCallees, not bare llvm::Value*s.

Author: rjmccall Date: Tue Feb 6 10:52:44 2018 New Revision: 324377 URL: http://llvm.org/viewvc/llvm-project?rev=324377&view=rev Log: Pass around function pointers as CGCallees, not bare llvm::Value*s. The intention here is to make it easy to write frontend-assisted CFI systems by propagating ex

r322406 - Allocate and access NormalCleanupDest with the natural alignment of i32.

Author: rjmccall Date: Fri Jan 12 14:07:01 2018 New Revision: 322406 URL: http://llvm.org/viewvc/llvm-project?rev=322406&view=rev Log: Allocate and access NormalCleanupDest with the natural alignment of i32. This alignment can be less than 4 on certain embedded targets, which may not even be able

Re: trivial_abi

Jan 3, 2018 at 4:06 PM Richard Smith via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > On 3 January 2018 at 15:24, John McCall via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Jan 3, 2018, at 5:53 PM, Richard Smith > <mailto:rich...@metafoo.co

r321957 - Simplify the internal API for checking whether swiftcall passes a type indirectly and expose that API externally.

Author: rjmccall Date: Sat Jan 6 22:28:49 2018 New Revision: 321957 URL: http://llvm.org/viewvc/llvm-project?rev=321957&view=rev Log: Simplify the internal API for checking whether swiftcall passes a type indirectly and expose that API externally. Modified: cfe/trunk/include/clang/CodeGen/S

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

On Wed, Jan 3, 2018 at 2:07 PM, Akira Hatanaka wrote: > On Jan 3, 2018, at 10:25 AM, John McCall wrote: > > On Wed, Jan 3, 2018 at 12:24 PM, Akira Hatanaka > wrote: > >> On Jan 2, 2018, at 9:42 AM, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >> >> >> On Tue, Dec 19,

Re: trivial_abi

> On Jan 3, 2018, at 5:53 PM, Richard Smith wrote: > On 3 January 2018 at 14:29, John McCall via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Jan 3, 2018, at 5:12 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote: >> >

Re: trivial_abi

> On Jan 3, 2018, at 5:12 PM, Richard Smith wrote: > > On 2 January 2018 at 20:55, John McCall via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: >> On Jan 2, 2018, at 10:43 PM, Richard Smith > <mailto:rich...@metafoo.co.uk>> wrote: >> >

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

On Wed, Jan 3, 2018 at 12:24 PM, Akira Hatanaka wrote: > On Jan 2, 2018, at 9:42 AM, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > On Tue, Dec 19, 2017 at 9:43 PM Akira Hatanaka wrote: > >> On Tue, Dec 12, 2017 at 12:12 PM, John McCall wrote: >> >>> On Tue, Dec 12

Re: trivial_abi

> On Jan 2, 2018, at 10:43 PM, Richard Smith wrote: > > On 2 January 2018 at 19:02, John McCall via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Jan 2, 2018, at 9:15 PM, Akira Hatanaka > <mailto:ahatan...@apple.com>> wrote: >

Re: trivial_abi

> On Jan 2, 2018, at 9:15 PM, Akira Hatanaka wrote: > > > >> On Jan 2, 2018, at 4:56 PM, Richard Smith via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >> On 2 January 2018 at 15:33, John McCall via cfe-commits >> mailto:cfe

trivial_abi

Hey, Richard et al. Akira and I were talking about the right ABI rule for deciding can-pass-in-registers-ness for structs in the presence of trivial_abi, and I think I like Akira's approach but wanted to get your input. The current definition in Itanium is: non-trivial for the purposes of ca

r320721 - In an ARC lambda-to-block conversion thunk, reclaim the return value of

Author: rjmccall Date: Thu Dec 14 10:21:14 2017 New Revision: 320721 URL: http://llvm.org/viewvc/llvm-project?rev=320721&view=rev Log: In an ARC lambda-to-block conversion thunk, reclaim the return value of the lambda so that we don't over-release it. Patch by Dan Zimmerman! Added: cfe/trunk

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

On Tue, Dec 12, 2017 at 1:45 PM, David Blaikie wrote: > On Mon, Dec 11, 2017 at 5:38 PM John McCall wrote: > >> On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie >> wrote: >> >>> On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator < >>> revi...@reviews.llvm.org> wrote: >>> rjmccall ad

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie wrote: > On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator < > revi...@reviews.llvm.org> wrote: > >> rjmccall added a comment. >> >> In https://reviews.llvm.org/D41039#951648, @ahatanak wrote: >> >> > I had a discussion with Duncan today an

r317776 - Fix a bug with the use of __builtin_bzero in a conditional expression.

Author: rjmccall Date: Thu Nov 9 01:32:32 2017 New Revision: 317776 URL: http://llvm.org/viewvc/llvm-project?rev=317776&view=rev Log: Fix a bug with the use of __builtin_bzero in a conditional expression. Patch by Bharathi Seshadri! Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp cfe/trun

Re: [PATCH] D36501: add flag to undo ABI change in r310401

> On Aug 24, 2017, at 3:48 PM, Richard Smith wrote: > On 24 August 2017 at 12:24, Paul Robinson via Phabricator via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > probinson added a comment. > > Locally we have a couple different tactics for dealing with changes that we > can't suppo

r311065 - Further refactoring of the constant emitter. NFC.

Author: rjmccall Date: Wed Aug 16 22:03:55 2017 New Revision: 311065 URL: http://llvm.org/viewvc/llvm-project?rev=311065&view=rev Log: Further refactoring of the constant emitter. NFC. Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp URL:

r310962 - Allow StmtVisitor visitation to be parameterized. NFC.

Author: rjmccall Date: Tue Aug 15 14:42:42 2017 New Revision: 310962 URL: http://llvm.org/viewvc/llvm-project?rev=310962&view=rev Log: Allow StmtVisitor visitation to be parameterized. NFC. Modified: cfe/trunk/include/clang/AST/StmtVisitor.h Modified: cfe/trunk/include/clang/AST/StmtVisitor

r310963 - Allow the target field of a CK_ToUnion to be more easily recovered.

Author: rjmccall Date: Tue Aug 15 14:42:47 2017 New Revision: 310963 URL: http://llvm.org/viewvc/llvm-project?rev=310963&view=rev Log: Allow the target field of a CK_ToUnion to be more easily recovered. Modified: cfe/trunk/include/clang/AST/Expr.h cfe/trunk/lib/AST/Expr.cpp cfe/trunk/

r310964 - Extract IRGen's constant-emitter into its own helper class and clean up

Author: rjmccall Date: Tue Aug 15 14:42:52 2017 New Revision: 310964 URL: http://llvm.org/viewvc/llvm-project?rev=310964&view=rev Log: Extract IRGen's constant-emitter into its own helper class and clean up the interface. The ultimate goal here is to make it easier to do some more interesting thi

<    1   2   3   4   5   6   7   8   9   >