Re: [PATCH] [scan-build] Add an option to skip overriding CC and CXX make vars

Sorry, I forgot to commit this before heading off on vacation. I'll be back on monday. Jon On Fri, Jan 19, 2018 at 1:53 AM, Paul Fertser wrote: > Hello Jonathan, > > On Mon, Jan 15, 2018 at 08:36:03AM -0700, Jonathan Roelofs wrote: > > LGTM. Would you like me to commit it

Re: [PATCH] D43442: libunwind: when building without threads, pass this to libcxx as well

I’ll have a look this week. -jroelofs On Sun, Feb 18, 2018 at 9:27 AM Rink via Phabricator < revi...@reviews.llvm.org> wrote: > zhmu added a comment. > > I've added jroelofs to the reviewer list as we spoke about this in #llvm > quite some time ago. > > > Repository: > rUNW libunwind > >

Re: [PATCH] D49898: Make test/Driver/baremetal.cpp work with linkers other than lld

LGTM Jon On Thu, Jul 26, 2018 at 10:12 PM David Greene via Phabricator < revi...@reviews.llvm.org> wrote: > greened created this revision. > greened added reviewers: jroelofs, hans, probinson, ismail, rtrieu. > Herald added a subscriber: cfe-commits. > > This test fails if clang is configure

Re: [PATCH] D41316: [libcxx] Allow random_device to be built optionally

> the targets where you would want to use this can't run the libcxx testsuite anyway (because they don't have an operating system to run the test programs under). I used to run libcxx tests for an arm baremetal toolchain I was building via semihosted QEMU. It was awkward and slow (especially for

Re: [PATCH] D52151: Also manages clang-X as tool for scan-build

lgtm On Sun, Sep 16, 2018 at 12:47 PM Sylvestre Ledru via Phabricator < revi...@reviews.llvm.org> wrote: > sylvestre.ledru created this revision. > sylvestre.ledru added a reviewer: jroelofs. > > This will make > scan-build-7 clang-7 -c foo.c &> /dev/null > > > Repository: > rC Clang > >

Re: [PATCH] D60990: [Driver] Support priority for multilibs

LGTM On Mon, Apr 22, 2019 at 8:34 PM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek created this revision. > phosek added reviewers: jroelofs, bkramer. > Herald added subscribers: cfe-commits, mgrang. > Herald added a project: clang. > > When more than one multilib flag

Re: [PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

On Tue, Apr 23, 2019 at 11:36 PM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek added inline comments. > > > > Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122 > + > +/// \p Flag must be a flag accepted by the driver with its leading '-' > removed,

Re: [PATCH] D73904: [clang] stop baremetal driver to append .a to lib

> I'm also not sure if `-L` is a feature that is relied upon at the moment by anybody that uses the baremetal driver Unlikely, IMO. There aren’t that many users of this stuff yet, and it’s still quite rough around the edges in comparison to the GNU toolchain. Also, the compiler support libraries

[clang] 38b39c3 - [clang] Add missing FileCheck colons

Author: Jon Roelofs Date: 2020-04-14T12:32:48-06:00 New Revision: 38b39c34ab0c860410e4ac7dc1b033ef14200be8 URL: https://github.com/llvm/llvm-project/commit/38b39c34ab0c860410e4ac7dc1b033ef14200be8 DIFF: https://github.com/llvm/llvm-project/commit/38b39c34ab0c860410e4ac7dc1b033ef14200be8.diff

[clang] c145a1c - AArch64::ArchKind's underlying type is uint64_t

Author: Jon Roelofs Date: 2020-09-17T12:13:57-07:00 New Revision: c145a1ca2593e3b8b79687d5ba8c3230c41b5130 URL: https://github.com/llvm/llvm-project/commit/c145a1ca2593e3b8b79687d5ba8c3230c41b5130 DIFF: https://github.com/llvm/llvm-project/commit/c145a1ca2593e3b8b79687d5ba8c3230c41b5130.diff

[clang] 1e06b16 - [clang][docs] Document additional bits of libc that -ffreestanding envs must provide

Author: Jon Roelofs Date: 2020-05-26T15:42:32-06:00 New Revision: 1e06b169be3e59799b8dcaf16d1d03bd4c12da42 URL: https://github.com/llvm/llvm-project/commit/1e06b169be3e59799b8dcaf16d1d03bd4c12da42 DIFF: https://github.com/llvm/llvm-project/commit/1e06b169be3e59799b8dcaf16d1d03bd4c12da42.diff

[clang] 51c5add - Extending Baremetal toolchain's support for the rtlib option.

Author: Jon Roelofs Date: 2020-09-18T09:19:37-07:00 New Revision: 51c5add8547a66caa5fbc9a19a91cd7976944229 URL: https://github.com/llvm/llvm-project/commit/51c5add8547a66caa5fbc9a19a91cd7976944229 DIFF: https://github.com/llvm/llvm-project/commit/51c5add8547a66caa5fbc9a19a91cd7976944229.diff

Re: [PATCH] D81953: [clang-tidy] warnings-as-error no longer exits with ErrorCount

I didn’t have a specific use case in mind for it, so no preference either way. LGTM as well On Tue, Jun 16, 2020 at 1:05 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman accepted this revision. > aaron.ballman added a comment. > This revision is now accepted

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

Oh, yeah, that should probably be clamped. I didn’t have a specific use case in mind, but in general I find that tools that emit “richer” information can be used for more things, hence returning the count, and not some fixed value. On Sat, Jun 13, 2020 at 12:58 AM Nathan James via Phabricator <

[clang] 1deee5c - Fix crash when emitting NullReturn guards for functions returning BOOL

Author: Jon Roelofs Date: 2021-01-21T14:29:36-08:00 New Revision: 1deee5cacbb76578367186d7ff2937b6fa79b827 URL: https://github.com/llvm/llvm-project/commit/1deee5cacbb76578367186d7ff2937b6fa79b827 DIFF: https://github.com/llvm/llvm-project/commit/1deee5cacbb76578367186d7ff2937b6fa79b827.diff

[clang] 7f6e331 - Support `#pragma clang section` directives on MachO targets

Author: Jon Roelofs Date: 2021-02-25T09:30:10-08:00 New Revision: 7f6e3316456f939a062aad0eeaac983251a1747c URL: https://github.com/llvm/llvm-project/commit/7f6e3316456f939a062aad0eeaac983251a1747c DIFF: https://github.com/llvm/llvm-project/commit/7f6e3316456f939a062aad0eeaac983251a1747c.diff

[clang] a24644b - Revert "Run non-filechecked commands in update_cc_test_checks.py"

Author: Jon Roelofs Date: 2021-03-08T17:26:24-08:00 New Revision: a24644bb1ce09b40c2d751569dd5bb37ea9c995d URL: https://github.com/llvm/llvm-project/commit/a24644bb1ce09b40c2d751569dd5bb37ea9c995d DIFF: https://github.com/llvm/llvm-project/commit/a24644bb1ce09b40c2d751569dd5bb37ea9c995d.diff

[clang] b4c0307 - Fix clang-interpreter build after 2487db1f286222e2501c2fa8e8244eda13f6afc3

Author: Jon Roelofs Date: 2021-08-05T10:05:36-07:00 New Revision: b4c0307d598004cfd96c770d2a4a84a37c838ba9 URL: https://github.com/llvm/llvm-project/commit/b4c0307d598004cfd96c770d2a4a84a37c838ba9 DIFF: https://github.com/llvm/llvm-project/commit/b4c0307d598004cfd96c770d2a4a84a37c838ba9.diff

[clang] 8440ec6 - [docs] Document -ffinite-math-only, -fhonor-{infinities,infinites,nans}

Author: Jon Roelofs Date: 2022-02-08T18:10:17-08:00 New Revision: 8440ec66f4f0f2e4f49061262648809345952bf7 URL: https://github.com/llvm/llvm-project/commit/8440ec66f4f0f2e4f49061262648809345952bf7 DIFF: https://github.com/llvm/llvm-project/commit/8440ec66f4f0f2e4f49061262648809345952bf7.diff

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

@@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion = {VersionText.str(), -1, -1, -1, "", "", ""}; - if

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

@@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion = {VersionText.str(), -1, -1, -1, "", "", ""}; - if

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

Martin =?utf-8?q?Storsjö?= , Martin =?utf-8?q?Storsjö?= , Martin =?utf-8?q?Storsjö?= Message-ID: In-Reply-To: @@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

Martin =?utf-8?q?Storsjö?= Message-ID: In-Reply-To: @@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

Martin =?utf-8?q?Storsjö?= Message-ID: In-Reply-To: @@ -2007,45 +2007,71 @@ Generic_GCC::GCCVersion Generic_GCC::GCCVersion::Parse(StringRef VersionText) { std::pair First = VersionText.split('.'); std::pair Second = First.second.split('.'); - GCCVersion GoodVersion

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

Martin =?utf-8?q?Storsj=C3=B6?= , Martin =?utf-8?q?Storsj=C3=B6?= , Martin =?utf-8?q?Storsj=C3=B6?= Message-ID: In-Reply-To: https://github.com/jroelofs approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/69079 ___

[clang] [clang][NFC] Assert not llvm_unreachable (PR #70149)

https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/70149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [LLVM][AArch64] Add ASM constraints for reduced GPR register ranges. (PR #70970)

@@ -1306,6 +1306,12 @@ bool AArch64TargetInfo::validateAsmConstraint( Name += 2; return true; } +if (Name[1] == 'c' && (Name[2] == 'i' || Name[2] == 'j')) { + // Gpr registers ("Uci"=w8-11, "Upj"=w12-15) jroelofs wrote: `s/Upj/Ucj/` ?

[clang] [clang][driver] Add \/../include/c++/v1 to include path on Darwin (PR #70817)

jroelofs wrote: > In my use case, and probably in most use cases, the location where the link > comes from is a plain folder, not a hierarchy specific to a toolchain. I would have expected the opposite. Most non-windows clang toolchains that I know of typically ship `clang` and `clang++` as

[clang] [clang][driver] Add \/../include/c++/v1 to include path on Darwin (PR #70817)

jroelofs wrote: > changing the structure of the symlinks is not possible, it is done > automatically by a tool. To be fair: tools can be changed, and in fact you're proposing to change one ;) But that said, now I see what you're up against. https://github.com/llvm/llvm-project/pull/70817

[clang] [clang][driver] Add \/../include/c++/v1 to include path on Darwin (PR #70817)

jroelofs wrote: > Can you clearly state why you are against this PR? You don't consider the > current behaviour of silently using the wrong headers a bug, or the proposed > solution is not correct? >> Don't consider this an objection I am not against it; I just wanted to talk through all the

[clang] [llvm] [LLVM][AArch64] Add ASM constraints for reduced GPR register ranges. (PR #70970)

https://github.com/jroelofs approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/70970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 30414fc - Reland "[Intrinsics][ObjC] Mark objc_retain and friends as thisreturn."

Author: Jon Roelofs Date: 2023-11-06T08:47:05-08:00 New Revision: 30414fc614d80a45bad4c89763a353f50d3e04d6 URL: https://github.com/llvm/llvm-project/commit/30414fc614d80a45bad4c89763a353f50d3e04d6 DIFF: https://github.com/llvm/llvm-project/commit/30414fc614d80a45bad4c89763a353f50d3e04d6.diff

[clang] d9ccace - Revert "Reland "[Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.""

Author: Jon Roelofs Date: 2023-11-06T10:04:22-08:00 New Revision: d9ccacee13dbe12e2037c4694b6801a87411a1e7 URL: https://github.com/llvm/llvm-project/commit/d9ccacee13dbe12e2037c4694b6801a87411a1e7 DIFF: https://github.com/llvm/llvm-project/commit/d9ccacee13dbe12e2037c4694b6801a87411a1e7.diff

[clang] fa71f9e - Reland "[Intrinsics][ObjC] Mark objc_retain and friends as thisreturn."

Author: Jon Roelofs Date: 2023-11-06T11:10:59-08:00 New Revision: fa71f9e87aee87c899a6ed600c1748aeb1c1a05d URL: https://github.com/llvm/llvm-project/commit/fa71f9e87aee87c899a6ed600c1748aeb1c1a05d DIFF: https://github.com/llvm/llvm-project/commit/fa71f9e87aee87c899a6ed600c1748aeb1c1a05d.diff

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/69078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

@@ -3703,6 +3703,20 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Builder.CreateMemSet(Dest, Builder.getInt8(0), SizeVal, false); return RValue::get(nullptr); } + + case Builtin::BIbcopy: jroelofs wrote: Is

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

@@ -3703,6 +3703,20 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, Builder.CreateMemSet(Dest, Builder.getInt8(0), SizeVal, false); return RValue::get(nullptr); } + + case Builtin::BIbcopy: jroelofs wrote: never

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

https://github.com/jroelofs resolved https://github.com/llvm/llvm-project/pull/67130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

https://github.com/jroelofs resolved https://github.com/llvm/llvm-project/pull/67130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Add __builtin_bcopy (PR #67130)

https://github.com/jroelofs approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ObjC] Add optionality to property attribute strings. (PR #66507)

https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/66507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

jroelofs wrote: Perhaps this belongs in the ABI-breaking-checks build? https://github.com/llvm/llvm-project/pull/69078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cb62f67 - Revert "[Intrinsics][ObjC] Mark objc_retain and friends as thisreturn."

Author: Jon Roelofs Date: 2023-10-20T09:22:12-07:00 New Revision: cb62f67088aaf79493350547f74870318b71acc5 URL: https://github.com/llvm/llvm-project/commit/cb62f67088aaf79493350547f74870318b71acc5 DIFF: https://github.com/llvm/llvm-project/commit/cb62f67088aaf79493350547f74870318b71acc5.diff

[clang] 1e4d612 - [CMake] Add a few more missing dependencies on ClangDriverOptions

Author: Jon Roelofs Date: 2023-08-15T16:56:31-07:00 New Revision: 1e4d6122cda6529781ecf467c2ae84e5dd41acdf URL: https://github.com/llvm/llvm-project/commit/1e4d6122cda6529781ecf467c2ae84e5dd41acdf DIFF: https://github.com/llvm/llvm-project/commit/1e4d6122cda6529781ecf467c2ae84e5dd41acdf.diff

[clang] [clang][driver] Add \/../include/c++/v1 to include path on Darwin (PR #70817)

@@ -2494,6 +2494,19 @@ void DarwinClang::AddClangCXXStdlibIncludeArgs( << "\"\n"; } +// Check for the folder where the executable is located, if different. +if (getDriver().getInstalledDir() != getDriver().Dir) { + InstallBin =

[clang] f5326fb - clang: add a missing dependency on ClangDriverOptions

Author: Jon Roelofs Date: 2023-07-11T10:07:09-07:00 New Revision: f5326fbe12d7ed006262d35c90803d3dd3907f82 URL: https://github.com/llvm/llvm-project/commit/f5326fbe12d7ed006262d35c90803d3dd3907f82 DIFF: https://github.com/llvm/llvm-project/commit/f5326fbe12d7ed006262d35c90803d3dd3907f82.diff

[clang] 2fb1c10 - cmake: add missing dependencies on ClangDriverOptions tablegen

Author: Jon Roelofs Date: 2023-08-04T10:27:19-07:00 New Revision: 2fb1c1082c01ddf9b2531083196ff2dace1fdab7 URL: https://github.com/llvm/llvm-project/commit/2fb1c1082c01ddf9b2531083196ff2dace1fdab7 DIFF: https://github.com/llvm/llvm-project/commit/2fb1c1082c01ddf9b2531083196ff2dace1fdab7.diff

[clang] 3d756c3 - cmake: add missing dependencies on ClangDriverOptions tablegen

Author: Jon Roelofs Date: 2023-08-04T10:43:31-07:00 New Revision: 3d756c32cdf005d0f4c05f561fec4a37b64b7ddd URL: https://github.com/llvm/llvm-project/commit/3d756c32cdf005d0f4c05f561fec4a37b64b7ddd DIFF: https://github.com/llvm/llvm-project/commit/3d756c32cdf005d0f4c05f561fec4a37b64b7ddd.diff

[clang] ed83797 - [Intrinsics][ObjC] Mark objc_retain and friends as thisreturn.

Author: Jon Roelofs Date: 2023-08-01T18:02:00-07:00 New Revision: ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a URL: https://github.com/llvm/llvm-project/commit/ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a DIFF: https://github.com/llvm/llvm-project/commit/ed83797f3cbfc8fb2a1af63542f97d7ec1d5505a.diff

[clang-tools-extra] b857645 - [clangd] Fix missing dependency on clang/Driver/Options.inc's tblgen target

Author: Jon Roelofs Date: 2023-05-06T10:11:39-07:00 New Revision: b8576450c7c7469483fe01c3129071b307b7e6b5 URL: https://github.com/llvm/llvm-project/commit/b8576450c7c7469483fe01c3129071b307b7e6b5 DIFF: https://github.com/llvm/llvm-project/commit/b8576450c7c7469483fe01c3129071b307b7e6b5.diff

[clang] 1a135bc - [MachineOutliner][LTO] Enable outlining of linkonceodr functions on all targets.

Author: Jon Roelofs Date: 2023-08-14T16:22:48-07:00 New Revision: 1a135bceb66b2d448ba4363af2f8626b6e4110bd URL: https://github.com/llvm/llvm-project/commit/1a135bceb66b2d448ba4363af2f8626b6e4110bd DIFF: https://github.com/llvm/llvm-project/commit/1a135bceb66b2d448ba4363af2f8626b6e4110bd.diff

[clang] [AArch64][Clang] Fix linker error for function multiversioning (PR #74358)

https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/74358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][Clang] Fix linker error for function multiversioning (PR #74358)

@@ -1752,8 +1754,10 @@ static void AppendTargetClonesMangling(const CodeGenModule , const TargetInfo = CGM.getTarget(); if (TI.getTriple().isAArch64()) { jroelofs wrote: Right, it's too bad this incompatibility is baked into the spec. Are there other

[clang] [clang][sema] Fix -Wunused-function on target_version'd file-scope Fn's (PR #81167)

https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/81167 >From 96e3020eaa69f7f14b67617a250df3041cc1996b Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 8 Feb 2024 10:02:50 -0800 Subject: [PATCH 1/2] [clang][sema] Fix -Wunused-function on target_version'd

[clang] [clang][sema] Fix -Wunused-function on target_version'd file-scope Fn's (PR #81167)

https://github.com/jroelofs created https://github.com/llvm/llvm-project/pull/81167 We should only warn if the default version is the one that is unused. Fixes: https://github.com/llvm/llvm-project/issues/80227 >From 96e3020eaa69f7f14b67617a250df3041cc1996b Mon Sep 17 00:00:00 2001 From: Jon

[clang] [clang][fmv] Drop .ifunc from target_version's entrypoint's mangling (PR #81194)

https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/81194 >From 92aef5a078583f69cede47374e2b97de865c5c5d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 8 Feb 2024 13:56:50 -0800 Subject: [PATCH 1/3] [clang][fmv] Drop .ifunc from target_version's entrypoint's

[clang] [clang][fmv] Drop .ifunc from target_version's entrypoint's mangling (PR #81194)

@@ -4393,7 +4394,7 @@ llvm::Constant *CodeGenModule::GetOrCreateMultiVersionResolver(GlobalDecl GD) { // a separate resolver). std::string ResolverName = MangledName; if (getTarget().supportsIFunc()) { -if (!FD->isTargetClonesMultiVersion()) +if

[clang] [clang][fmv] Drop .ifunc from target_version's entrypoint's mangling (PR #81194)

https://github.com/jroelofs created https://github.com/llvm/llvm-project/pull/81194 Fixes: https://github.com/llvm/llvm-project/issues/81043 >From 92aef5a078583f69cede47374e2b97de865c5c5d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 8 Feb 2024 13:56:50 -0800 Subject: [PATCH]

[clang] [clang][sema] Fix -Wunused-function on target_version'd file-scope Fn's (PR #81167)

https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/81167 >From 96e3020eaa69f7f14b67617a250df3041cc1996b Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 8 Feb 2024 10:02:50 -0800 Subject: [PATCH 1/2] [clang][sema] Fix -Wunused-function on target_version'd

[clang] [clang][fmv] Drop .ifunc from target_version's entrypoint's mangling (PR #81194)

https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/81194 >From 92aef5a078583f69cede47374e2b97de865c5c5d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 8 Feb 2024 13:56:50 -0800 Subject: [PATCH 1/2] [clang][fmv] Drop .ifunc from target_version's entrypoint's

[clang] [clang][fmv] Drop .ifunc from target_version's entrypoint's mangling (PR #81194)

https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/81194 >From 92aef5a078583f69cede47374e2b97de865c5c5d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 8 Feb 2024 13:56:50 -0800 Subject: [PATCH 1/4] [clang][fmv] Drop .ifunc from target_version's entrypoint's

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

@@ -673,7 +673,7 @@ int hoo(void) { // // // CHECK: Function Attrs: noinline nounwind optnone -// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdm +// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdma jroelofs wrote: FWIW, I think it's okay to change this

[clang] bad error message on incorrect string literal #18079 (PR #81670)

jroelofs wrote: Feel free to keep it open and push more commits to the branch. https://github.com/llvm/llvm-project/pull/81670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -2270,9 +2270,11 @@ bool Lexer::LexRawStringLiteral(Token , const char *CurPtr, const char *PrefixEnd = [PrefixLen]; if (PrefixLen == 16) { Diag(PrefixEnd, diag::err_raw_delim_too_long); - } else { + } else if (*PrefixEnd != '\n') {

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -100,7 +100,10 @@ def err_raw_delim_too_long : Error< "raw string delimiter longer than 16 characters" "; use PREFIX( )PREFIX to delimit raw string">; def err_invalid_char_raw_delim : Error< - "invalid character '%0' character in raw string delimiter" + "invalid

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -102,6 +102,9 @@ def err_raw_delim_too_long : Error< def err_invalid_char_raw_delim : Error< "invalid newline character in raw string delimiter" "; use PREFIX( )PREFIX to delimit raw string">; +def err_invalid_nexline_raw_delim : Error< jroelofs wrote:

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -0,0 +1,5 @@ +// RUN: not %clang_cc1 -E %s 2>&1 | grep 'error: invalid newline character in raw string delimiter; use PREFIX( )PREFIX to delimit raw string' jroelofs wrote: Please use `-fsyntax-only -verify` instead of `grep` for checking diagnostics.

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -2270,10 +2270,12 @@ bool Lexer::LexRawStringLiteral(Token , const char *CurPtr, const char *PrefixEnd = [PrefixLen]; if (PrefixLen == 16) { Diag(PrefixEnd, diag::err_raw_delim_too_long); - } else { + } else if (*PrefixEnd != '\n') {

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -0,0 +1,5 @@ +// RUN: not %clang_cc1 -E %s 2>&1 | grep 'error: invalid newline character in raw string delimiter; use PREFIX( )PREFIX to delimit raw string' jroelofs wrote: mind also adding a test for the `err_invalid_char_raw_delim` case while you're

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -2270,9 +2270,11 @@ bool Lexer::LexRawStringLiteral(Token , const char *CurPtr, const char *PrefixEnd = [PrefixLen]; if (PrefixLen == 16) { Diag(PrefixEnd, diag::err_raw_delim_too_long); - } else { + } else if (*PrefixEnd != '\n') {

[clang] [clang][CodeGen] Add missing error check (PR #81777)

https://github.com/jroelofs approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/81777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -2270,9 +2270,11 @@ bool Lexer::LexRawStringLiteral(Token , const char *CurPtr, const char *PrefixEnd = [PrefixLen]; if (PrefixLen == 16) { Diag(PrefixEnd, diag::err_raw_delim_too_long); - } else { + } else if (*PrefixEnd != '\n') {

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -E -fsyntax-only -verify %s + +// expected-error@+2{{invalid character ')' character in raw string delimiter; use PREFIX( )PREFIX to delimit raw string}} jroelofs wrote: This has the old spelling of that diagnostic. Also,

[clang] bad error message on incorrect string literal #18079 (PR #81670)

@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -E -fsyntax-only -verify %s + +// expected-error@+2{{invalid character ')' character in raw string delimiter; use PREFIX( )PREFIX to delimit raw string}} jroelofs wrote: Before this change, the message used to say `character

[clang] bad error message on incorrect string literal #18079 (PR #81670)

https://github.com/jroelofs approved this pull request. LGTM. Let me know if you need me to press the "merge" button for you. https://github.com/llvm/llvm-project/pull/81670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

@@ -673,7 +673,7 @@ int hoo(void) { // // // CHECK: Function Attrs: noinline nounwind optnone -// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdm +// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdma jroelofs wrote: I think they are part of ABI, and

[clang] bad error message on incorrect string literal #18079 (PR #81670)

jroelofs wrote: > I am new to this project. Please let me know if any files need to be added. > > I don't believe any testing or test suite changes are required for this > change. This particular change will break this usage of that diagnostic, which expects that format argument:

[clang] [clang] Define SwiftInfo for RISCVTargetCodeGenInfo (PR #82152)

jroelofs wrote: > Can this be tested? I don't know what the affects are. Might be as simple as adding another `RUN:` line to `clang/test/CodeGenCXX/arm-swiftcall.{c,cpp}` with a riscv triple. https://github.com/llvm/llvm-project/pull/82152 ___

[clang] [compiler-rt] [AArch64] Implement __builtin_cpu_supports, compiler-rt tests. (PR #82378)

@@ -14025,6 +14028,19 @@ Value *CodeGenFunction::EmitX86CpuInit() { return Builder.CreateCall(Func); } +Value *CodeGenFunction::EmitAArch64CpuSupports(const CallExpr *E) { + const Expr *ArgExpr = E->getArg(0)->IgnoreParenCasts(); + StringRef ArgStr =

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

@@ -44,9 +43,8 @@ // CHECK-V6M-DEFAULTCXX: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK-V6M-DEFAULTCXX: ld{{(.exe)?}}" "{{.*}}.o" "-Bstatic" "-EL" // CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}Inputs{{[/\\]+}}baremetal_arm{{[/\\]+}}lib" -//

[clang] [compiler-rt] [AArch64] Implement __builtin_cpu_supports, compiler-rt tests. (PR #82378)

https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/82378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [AArch64] Implement __builtin_cpu_supports, compiler-rt tests. (PR #82378)

@@ -14025,6 +14028,19 @@ Value *CodeGenFunction::EmitX86CpuInit() { return Builder.CreateCall(Func); } +Value *CodeGenFunction::EmitAArch64CpuSupports(const CallExpr *E) { + const Expr *ArgExpr = E->getArg(0)->IgnoreParenCasts(); + StringRef ArgStr =

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

@@ -44,9 +43,8 @@ // CHECK-V6M-DEFAULTCXX: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK-V6M-DEFAULTCXX: ld{{(.exe)?}}" "{{.*}}.o" "-Bstatic" "-EL" // CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}Inputs{{[/\\]+}}baremetal_arm{{[/\\]+}}lib" -//

[clang] [Driver,BareMetal] Replace -lclang_rt.builtins{,-$arch}.a with an absolute path (PR #82424)

https://github.com/jroelofs approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/82424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][SME] Detect always_inline used with mismatched streaming attributes (PR #77936)

@@ -814,6 +820,43 @@ Address AArch64ABIInfo::EmitMSVAArg(CodeGenFunction , Address VAListAddr, /*allowHigherAlign*/ false); } +static bool isStreaming(const FunctionDecl *F) { + if (F->hasAttr()) +return true; + if (const auto *T =

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

@@ -39,7 +39,7 @@ inline int __attribute__((target_version("memtag3+rcpc3+mops"))) fmv_inline(void inline int __attribute__((target_version("aes+dotprod"))) fmv_inline(void) { return 13; } inline int __attribute__((target_version("simd+fp16fml"))) fmv_inline(void) { return

[clang] [clang][sema] Fix -Wunused-function on target_version'd file-scope Fn's (PR #81167)

https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/81167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema][FMV] Forbid multi-versioning arm_streaming functions. (PR #81268)

https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/81268 >From 82a631017a114a15a6ba3376c049b7a85707973a Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 8 Feb 2024 16:21:28 -0800 Subject: [PATCH 1/3] [clang][sema][FMV] Forbid multi-versioning arm_streaming

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

@@ -673,7 +673,7 @@ int hoo(void) { // // // CHECK: Function Attrs: noinline nounwind optnone -// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdm +// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdma jroelofs wrote: It seems potentially problematic that

[clang] [clang][fmv] Drop .ifunc from target_version's entrypoint's mangling (PR #81194)

https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/81194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema][FMV] Forbid multi-versioning arm_streaming functions. (PR #81268)

https://github.com/jroelofs created https://github.com/llvm/llvm-project/pull/81268 The streaming mode change is incompatible with the ifunc mechanism used to implement FMV: we can't conditionally change it based on the particular callee that is resolved at runtime. Fixes:

[clang] [clang][sema][FMV] Forbid multi-versioning arm_streaming functions. (PR #81268)

@@ -3501,9 +3501,18 @@ bool Sema::checkTargetAttr(SourceLocation LiteralLoc, StringRef AttrStr) { return false; } +static bool isArmStreaming(const FunctionDecl *FD) { + if (FD->hasAttr()) +return true; jroelofs wrote: Oh, you're right, we don't need

[clang] 9bb54b2 - Move the new test added in 2095655f to its own file

Author: Jon Roelofs Date: 2024-02-09T09:02:56-08:00 New Revision: 9bb54b2aa006e3bf5df5eb8672075dd589fb9ba5 URL: https://github.com/llvm/llvm-project/commit/9bb54b2aa006e3bf5df5eb8672075dd589fb9ba5 DIFF: https://github.com/llvm/llvm-project/commit/9bb54b2aa006e3bf5df5eb8672075dd589fb9ba5.diff

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

@@ -673,7 +673,7 @@ int hoo(void) { // // // CHECK: Function Attrs: noinline nounwind optnone -// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdm +// CHECK-LABEL: define {{[^@]+}}@fmv_inline._MlseMrdma jroelofs wrote: What does GCC do?

[clang] [clang][sema] Fix -Wunused-function on target_version'd file-scope Fn's (PR #81167)

jroelofs wrote: Moved the test to its own file to fix appease buildbots 9bb54b2aa006e3bf5df5eb8672075dd589fb9ba5 https://github.com/llvm/llvm-project/pull/81167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Sema] Warn unused functions for FMV based on the target attribute (PR #81302)

jroelofs wrote: Thanks! https://github.com/llvm/llvm-project/pull/81302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Warn unused functions for FMV based on the target attribute (PR #81302)

https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/81302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema][FMV] Forbid multi-versioning arm_streaming functions. (PR #81268)

https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/81268 >From 82a631017a114a15a6ba3376c049b7a85707973a Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 8 Feb 2024 16:21:28 -0800 Subject: [PATCH 1/4] [clang][sema][FMV] Forbid multi-versioning arm_streaming

[clang] [clang][sema][FMV] Forbid multi-versioning arm_streaming functions. (PR #81268)

https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/81268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [flang] [clang] [lld] [lldb] [mlir] [llvm] [builtins] Refactor cpu_model support to reduce #if nesting. NFCI (PR #75635)

https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/75635 >From 336d1629f38a8681038f026c599a256761b522dc Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Fri, 15 Dec 2023 11:13:30 -0700 Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=

  1   2   3   >