Re: [clang-tools-extra] r314808 - [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise

; > Thanks > > Cheers, > Juergen > > On Tue, Oct 3, 2017 at 9:25 AM, Jonas Toth via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > > Author: jonastoth > Date: Tue Oct  3 09:25:01 2017 > New Revision:

[clang-tools-extra] r314913 - [clang-tidy] Emit note for variable declaration that are later deleted

Author: jonastoth Date: Wed Oct 4 09:49:20 2017 New Revision: 314913 URL: http://llvm.org/viewvc/llvm-project?rev=314913=rev Log: [clang-tidy] Emit note for variable declaration that are later deleted This patch introduces a note for variable declaration that are later deleted. Adds FIXME notes

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

Hi, I am not sure if could follow correctly, but the test for nested namespaces comments does not work correctly and is therefore currently disabled by fileextension? When running the check from trunk i get the following issues: $ clang-check google-readability-namespace-comments-cxx17.cpp

Re: [clang-tools-extra] r315060 - Renaming a test to start with the name of the check based on post-commit review feedback; NFC.

Ok. I subscribe to r315057. I can look at debugging the change as well if you guys want. Should have time today evening and tomorrow. Am 12.10.2017 um 12:46 schrieb Alexander Kornienko: On Thu, Oct 12, 2017 at 11:12 AM, Jonas Toth > wrote:

[clang-tools-extra] r312102 - [clang-tidy] test commit for granted access

Author: jonastoth Date: Wed Aug 30 00:50:28 2017 New Revision: 312102 URL: http://llvm.org/viewvc/llvm-project?rev=312102=rev Log: [clang-tidy] test commit for granted access Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/NoMallocCheck.cpp Modified:

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

char' in your clang-tidy test to fix the bot failures" Please be more careful with the buildbots in the future. Thanks, Diana (*) My apologies if I missed it, but I really don't see anything in cfe-commits nor in the situation of the bots to reflect that. On 30 August 2017 at 17:59, Jona

[clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

Author: jonastoth Date: Wed Aug 30 08:59:01 2017 New Revision: 312134 URL: http://llvm.org/viewvc/llvm-project?rev=312134=rev Log: [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better Summary: This patch is a followup to the first revision D36583, that had problems with

[clang-tools-extra] r312141 - [clang-tidy] fix buildbot

Author: jonastoth Date: Wed Aug 30 10:21:41 2017 New Revision: 312141 URL: http://llvm.org/viewvc/llvm-project?rev=312141=rev Log: [clang-tidy] fix buildbot Use `signed char` instead of `char`. Modified: clang-tools-extra/trunk/test/clang-tidy/hicpp-signed-bitwise.cpp Modified:

Re: [clang-tools-extra] r312134 - [clang-tidy] Improve hicpp-exception-baseclass to handle generic code better

be more careful with the buildbots in the future. Thanks, Diana (*) My apologies if I missed it, but I really don't see anything in cfe-commits nor in the situation of the bots to reflect that. On 30 August 2017 at 17:59, Jonas Toth via cfe-commits <cfe-commits@lists.llvm.org> wrote: Author: j

[clang-tools-extra] r312901 - [clang-tidy] add more aliases for the hicpp module

Author: jonastoth Date: Mon Sep 11 02:20:07 2017 New Revision: 312901 URL: http://llvm.org/viewvc/llvm-project?rev=312901=rev Log: [clang-tidy] add more aliases for the hicpp module This patch will introduce even more aliases for the hicpp-module to already existing checks and is a follow up

[clang-tools-extra] r313059 - [clang-tidy] Revert Implement type-based check for gsl::owner

Author: jonastoth Date: Tue Sep 12 11:35:54 2017 New Revision: 313059 URL: http://llvm.org/viewvc/llvm-project?rev=313059=rev Log: [clang-tidy] Revert Implement type-based check for gsl::owner This should unbreak the buildbot for visual studio 2015 for now. Removed:

[clang-tools-extra] r313067 - [clang-tidy] Implement type-based check for `gsl::owner`

Author: jonastoth Date: Tue Sep 12 13:00:42 2017 New Revision: 313067 URL: http://llvm.org/viewvc/llvm-project?rev=313067=rev Log: [clang-tidy] Implement type-based check for `gsl::owner` This check implements the typebased semantic of `gsl::owner`. Meaning, that - only `gsl::owner` is allowed

[clang-tools-extra] r313043 - [clang-tidy] Implement type-based check for `gsl::owner`

Author: jonastoth Date: Tue Sep 12 09:20:51 2017 New Revision: 313043 URL: http://llvm.org/viewvc/llvm-project?rev=313043=rev Log: [clang-tidy] Implement type-based check for `gsl::owner` This check implements the typebased semantic of `gsl::owner`. Meaning, that - only `gsl::owner` is allowed

[clang-tools-extra] r314808 - [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise

Author: jonastoth Date: Tue Oct 3 09:25:01 2017 New Revision: 314808 URL: http://llvm.org/viewvc/llvm-project?rev=314808=rev Log: [clang-tidy] Fix bug 34747, streaming operators and hicpp-signed-bitwise The bug happened with stream operations, that were not recognized in all cases. Even there

[clang-tools-extra] r314811 - [clang-tidy] Remove target specification hicpp-signed-bitwise

Author: jonastoth Date: Tue Oct 3 09:27:41 2017 New Revision: 314811 URL: http://llvm.org/viewvc/llvm-project?rev=314811=rev Log: [clang-tidy] Remove target specification hicpp-signed-bitwise This patch removes the targetspecification of a testcase, that broke for ARM. The underlying problem

[clang-tools-extra] r314812 - [clang-tidy] potentially fix buildbot

Author: jonastoth Date: Tue Oct 3 09:53:56 2017 New Revision: 314812 URL: http://llvm.org/viewvc/llvm-project?rev=314812=rev Log: [clang-tidy] potentially fix buildbot I tried to silence lit with `| count 0`, which did not work. Other testcases did not have `-- --` but only `--` in the RUN

[clang-tools-extra] r314816 - [clang-tidy] fix buildbot hicpp-signed-bitwise

Author: jonastoth Date: Tue Oct 3 10:08:57 2017 New Revision: 314816 URL: http://llvm.org/viewvc/llvm-project?rev=314816=rev Log: [clang-tidy] fix buildbot hicpp-signed-bitwise To finally fix the buildbot I added one single warning testcase. Modified:

[clang-tools-extra] r312122 - [clang-tidy] hicpp bitwise operations on signed integers

Author: jonastoth Date: Wed Aug 30 06:32:05 2017 New Revision: 312122 URL: http://llvm.org/viewvc/llvm-project?rev=312122=rev Log: [clang-tidy] hicpp bitwise operations on signed integers Summary: This check implements the rule [[ http://www.codingstandard.com/section/5-6-shift-operators/ |

[clang-tools-extra] r316093 - [clang-tidy] Fix buildbot for msvc

Author: jonastoth Date: Wed Oct 18 09:28:06 2017 New Revision: 316093 URL: http://llvm.org/viewvc/llvm-project?rev=316093=rev Log: [clang-tidy] Fix buildbot for msvc The testcase defined `FILE` as `unsigned long`, but MSVC expect `unsigned long long`. Modified:

[clang-tools-extra] r316094 - [clang-tidy] Fix 32bit platform MSVC

Author: jonastoth Date: Wed Oct 18 09:40:19 2017 New Revision: 316094 URL: http://llvm.org/viewvc/llvm-project?rev=316094=rev Log: [clang-tidy] Fix 32bit platform MSVC The previous fix only worked for 64bit MSVC, this one should fix all different architectures. Modified:

[clang-tools-extra] r316092 - [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory'

Author: jonastoth Date: Wed Oct 18 09:14:15 2017 New Revision: 316092 URL: http://llvm.org/viewvc/llvm-project?rev=316092=rev Log: [clang-tidy] introduce legacy resource functions to 'cppcoreguidelines-owning-memory' Summary: This patch introduces support for legacy C-style resource functions

[clang-tools-extra] r318670 - [clang-tidy] revert hicpp-multiway-paths-covered

Author: jonastoth Date: Mon Nov 20 10:01:35 2017 New Revision: 318670 URL: http://llvm.org/viewvc/llvm-project?rev=318670=rev Log: [clang-tidy] revert hicpp-multiway-paths-covered The address sanitizer found a stackoverflow with this patch. There is no obvious fix. This patch will be reapplied

[clang-tools-extra] r318600 - [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

Author: jonastoth Date: Sat Nov 18 11:48:33 2017 New Revision: 318600 URL: http://llvm.org/viewvc/llvm-project?rev=318600=rev Log: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches Summary: This check searches for missing `else` branches in `if-else if`-chains and

[clang-tools-extra] r319785 - [clang-tidy] adjust cppcoreguidelines-owning-memory documentation

Author: jonastoth Date: Tue Dec 5 08:37:49 2017 New Revision: 319785 URL: http://llvm.org/viewvc/llvm-project?rev=319785=rev Log: [clang-tidy] adjust cppcoreguidelines-owning-memory documentation Summary: A user of the check opened a bugreport and reported that `std::exchange` triggers a false

Re: [PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

Hmm. SVN does not want  me to commit anything :/ I will retry later today, but maybe i cant commit. Best, Jonas Am 06.06.2018 um 10:47 schrieb Aaron Ballman: > On Wed, Jun 6, 2018 at 4:40 AM Jonas Toth via Phabricator > wrote: >> JonasToth added a comment. >> >> @shuaiwang I can commit it in

[clang-tools-extra] r316767 - [clang-tidy] Fix bug 34845, offending standard bitmask types

Author: jonastoth Date: Fri Oct 27 07:44:08 2017 New Revision: 316767 URL: http://llvm.org/viewvc/llvm-project?rev=316767=rev Log: [clang-tidy] Fix bug 34845, offending standard bitmask types Summary: The C++ standard allows implementations to choose the underlying type for bitmask types (e.g.

[clang-tools-extra] r322624 - [clang-tidy] fix minor formatting issue

Author: jonastoth Date: Wed Jan 17 02:23:50 2018 New Revision: 322624 URL: http://llvm.org/viewvc/llvm-project?rev=322624=rev Log: [clang-tidy] fix minor formatting issue Modified: clang-tools-extra/trunk/clang-tidy/hicpp/HICPPTidyModule.cpp Modified:

[clang-tools-extra] r322626 - [clang-tidy] implement check for goto

Author: jonastoth Date: Wed Jan 17 02:27:41 2018 New Revision: 322626 URL: http://llvm.org/viewvc/llvm-project?rev=322626=rev Log: [clang-tidy] implement check for goto The usage of `goto` is discourage in C++ since forever. This check implements a warning for every `goto`. Even though there are

[clang-tools-extra] r338393 - [clang-tidy] add all clang-tidy modules to plugin

Author: jonastoth Date: Tue Jul 31 08:23:49 2018 New Revision: 338393 URL: http://llvm.org/viewvc/llvm-project?rev=338393=rev Log: [clang-tidy] add all clang-tidy modules to plugin Summary: This patch addresses PR38359 and adds all existing clang-tidy modules to the plugin that can be used

r338022 - [ASTMatchers] fix the missing documentation for new decltypeType matcher

Author: jonastoth Date: Thu Jul 26 06:02:05 2018 New Revision: 338022 URL: http://llvm.org/viewvc/llvm-project?rev=338022=rev Log: [ASTMatchers] fix the missing documentation for new decltypeType matcher Summary: Regenerate the Matchers documentation, forgotten in the original patch. Reviewers:

Re: Fwd: patch file for bug 38557

Do you have a phabricator account? Otherwise I will create a revision for you (ofc mentioning your name in the commit message) for review. Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits: > Hi, > > Attached is the patch file for Bug 38557 > (https://bugs.llvm.org/show_bug.cgi?id=38557).

r338996 - [clang-rename] make clang-rename.py vim integration python3 compatible

Author: jonastoth Date: Mon Aug 6 02:08:06 2018 New Revision: 338996 URL: http://llvm.org/viewvc/llvm-project?rev=338996=rev Log: [clang-rename] make clang-rename.py vim integration python3 compatible Summary: This patch makes the clang-rename.py script useable for vim with only python3

Re: Fwd: patch file for bug 38557

Hi Owen, thank you for your patch. I created a revision for it to pass review: https://reviews.llvm.org/D50697 If you do have an phabricator account you can take over, otherwise we can get it into trunk for you :) All the best, Jonas Am 14.08.2018 um 12:30 schrieb Owen Pan via cfe-commits: >

r340624 - [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier

Author: jonastoth Date: Fri Aug 24 10:25:06 2018 New Revision: 340624 URL: http://llvm.org/viewvc/llvm-project?rev=340624=rev Log: [clang-format] fix PR38557 - comments between "default" and ':' causes the case label to be treated as an identifier Summary: The Bug was reported and fixed by Owen

r340623 - [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

Author: jonastoth Date: Fri Aug 24 10:14:31 2018 New Revision: 340623 URL: http://llvm.org/viewvc/llvm-project?rev=340623=rev Log: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All Summary: See bug report

[clang-tools-extra] r340928 - [clang-tidy] Add abseil-no-internal-dependencies check

Author: jonastoth Date: Wed Aug 29 07:23:15 2018 New Revision: 340928 URL: http://llvm.org/viewvc/llvm-project?rev=340928=rev Log: [clang-tidy] Add abseil-no-internal-dependencies check Finds instances where the user depends on internal details and warns them against doing so. Should not be run

r337703 - [ASTMatchers] add matcher for decltypeType and its underlyingType

Author: jonastoth Date: Mon Jul 23 08:59:27 2018 New Revision: 337703 URL: http://llvm.org/viewvc/llvm-project?rev=337703=rev Log: [ASTMatchers] add matcher for decltypeType and its underlyingType Summary: This patch introduces a new matcher for `DecltypeType` and its underlying type in order to

[clang-tools-extra] r337712 - Revert "[clang-tidy] fix PR36489 - respect deduced pointer types from auto as well"

Author: jonastoth Date: Mon Jul 23 10:34:25 2018 New Revision: 337712 URL: http://llvm.org/viewvc/llvm-project?rev=337712=rev Log: Revert "[clang-tidy] fix PR36489 - respect deduced pointer types from auto as well" I applied the wrong patch. Modified:

[clang-tools-extra] r337716 - [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

Author: jonastoth Date: Mon Jul 23 10:46:17 2018 New Revision: 337716 URL: http://llvm.org/viewvc/llvm-project?rev=337716=rev Log: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well Summary: The cppcoreguidelines-pro-bounds-pointer-arithmetic warns on all occassion where

[clang-tools-extra] r337707 - [clang-tidy] remove private decltypeType in TrailingReturnType

Author: jonastoth Date: Mon Jul 23 09:30:13 2018 New Revision: 337707 URL: http://llvm.org/viewvc/llvm-project?rev=337707=rev Log: [clang-tidy] remove private decltypeType in TrailingReturnType Summary: This patch removes a private matcher in fuchsia/TrailingReturnType check because the matcher

[clang-tools-extra] r337710 - [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well

Author: jonastoth Date: Mon Jul 23 10:13:06 2018 New Revision: 337710 URL: http://llvm.org/viewvc/llvm-project?rev=337710=rev Log: [clang-tidy] fix PR36489 - respect deduced pointer types from auto as well Summary: The cppcoreguidelines-pro-bounds-pointer-arithmetic warns on all occassion where

r341284 - Fix Bug 38713: clang-format mishandles a short block after "default:" in a switch statement

Author: jonastoth Date: Sun Sep 2 02:04:51 2018 New Revision: 341284 URL: http://llvm.org/viewvc/llvm-project?rev=341284=rev Log: Fix Bug 38713: clang-format mishandles a short block after "default:" in a switch statement Summary: See https://bugs.llvm.org/show_bug.cgi?id=38713 Patch by Owen

[clang-tools-extra] r341039 - [clang-tidy] fix check_clang_tidy to forbid mixing of CHECK-NOTES and CHECK-MESSAGES

Author: jonastoth Date: Thu Aug 30 01:44:27 2018 New Revision: 341039 URL: http://llvm.org/viewvc/llvm-project?rev=341039=rev Log: [clang-tidy] fix check_clang_tidy to forbid mixing of CHECK-NOTES and CHECK-MESSAGES Summary: The check_clang_tidy.py script would allow mixing of `CHECK-NOTES` and

[clang-tools-extra] r341933 - [NFC][clangd] fix warning for extra semicolon

Author: jonastoth Date: Tue Sep 11 06:01:49 2018 New Revision: 341933 URL: http://llvm.org/viewvc/llvm-project?rev=341933=rev Log: [NFC][clangd] fix warning for extra semicolon Modified: clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp Modified:

[clang-tools-extra] r329789 - [clang-tidy] add missing assignment operations in hicpp-signed-bitwise

Author: jonastoth Date: Wed Apr 11 02:53:08 2018 New Revision: 329789 URL: http://llvm.org/viewvc/llvm-project?rev=329789=rev Log: [clang-tidy] add missing assignment operations in hicpp-signed-bitwise This patch resolves the bug https://bugs.llvm.org/show_bug.cgi?id=36963. - implement missing

[clang-tools-extra] r329790 - [clang-tidy] fix buildbots from hicpp-signed-bitwise

Author: jonastoth Date: Wed Apr 11 03:22:25 2018 New Revision: 329790 URL: http://llvm.org/viewvc/llvm-project?rev=329790=rev Log: [clang-tidy] fix buildbots from hicpp-signed-bitwise The applied patch to diagnose assignment operators introduced breakage on some architectures. This patch tries

[clang-tools-extra] r328107 - [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

Author: jonastoth Date: Wed Mar 21 08:34:15 2018 New Revision: 328107 URL: http://llvm.org/viewvc/llvm-project?rev=328107=rev Log: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test The original check did break the green buildbot in the sanitizer build. It took a while to

[clang-tools-extra] r328108 - [Fix] fix type deduction on ARM and MSVC

Author: jonastoth Date: Wed Mar 21 08:50:15 2018 New Revision: 328108 URL: http://llvm.org/viewvc/llvm-project?rev=328108=rev Log: [Fix] fix type deduction on ARM and MSVC Modified: clang-tools-extra/trunk/clang-tidy/hicpp/MultiwayPathsCoveredCheck.cpp Modified:

[clang-tools-extra] r343198 - [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace

Author: jonastoth Date: Thu Sep 27 05:17:59 2018 New Revision: 343198 URL: http://llvm.org/viewvc/llvm-project?rev=343198=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-forward-declaration-namespace Reviewers: aaron.ballman, alexfh, hokein Subscribers: xazax.hun, cfe-commits

[clang-tools-extra] r343199 - [clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move

Author: jonastoth Date: Thu Sep 27 05:22:48 2018 New Revision: 343199 URL: http://llvm.org/viewvc/llvm-project?rev=343199=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-use-after-move Reviewers: alexfh, aaron.ballman, hokein Subscribers: xazax.hun, cfe-commits Differential

[clang-tools-extra] r343201 - [clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage

Author: jonastoth Date: Thu Sep 27 05:30:44 2018 New Revision: 343201 URL: http://llvm.org/viewvc/llvm-project?rev=343201=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone suspicious-enum-usage Reviewers: alexfh, aaron.ballman, hokein Subscribers: xazax.hun, cfe-commits Differential

[clang-tools-extra] r343850 - [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext

Author: jonastoth Date: Fri Oct 5 07:15:19 2018 New Revision: 343850 URL: http://llvm.org/viewvc/llvm-project?rev=343850=rev Log: [clang-tidy] NFC refactor lexer-utils to be usable without ASTContext Summary: This patch is a small refactoring necessary for 'readability-isolate-declaration' and

r344382 - [Doc] fix BB, add code-block type

Author: jonastoth Date: Fri Oct 12 10:44:01 2018 New Revision: 344382 URL: http://llvm.org/viewvc/llvm-project?rev=344382=rev Log: [Doc] fix BB, add code-block type Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

[clang-tools-extra] r344374 - [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length

Author: jonastoth Date: Fri Oct 12 10:22:36 2018 New Revision: 344374 URL: http://llvm.org/viewvc/llvm-project?rev=344374=rev Log: [clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length New checker called bugprone-not-null-terminated-result. This

r344388 - [Doc] fix second error in UsersManual

Author: jonastoth Date: Fri Oct 12 10:57:18 2018 New Revision: 344388 URL: http://llvm.org/viewvc/llvm-project?rev=344388=rev Log: [Doc] fix second error in UsersManual Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

[clang-tools-extra] r344379 - [doc] fix markup in clang-tidy bugprone-not-null-terminated-result

Author: jonastoth Date: Fri Oct 12 10:36:04 2018 New Revision: 344379 URL: http://llvm.org/viewvc/llvm-project?rev=344379=rev Log: [doc] fix markup in clang-tidy bugprone-not-null-terminated-result Modified:

[clang-tools-extra] r344384 - [clangd] NFC fix semicolon warning

Author: jonastoth Date: Fri Oct 12 10:47:43 2018 New Revision: 344384 URL: http://llvm.org/viewvc/llvm-project?rev=344384=rev Log: [clangd] NFC fix semicolon warning Modified: clang-tools-extra/trunk/clangd/index/IndexAction.cpp Modified: clang-tools-extra/trunk/clangd/index/IndexAction.cpp

[clang-tools-extra] r344442 - Revert "[clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length"

Author: jonastoth Date: Sat Oct 13 02:30:58 2018 New Revision: 32 URL: http://llvm.org/viewvc/llvm-project?rev=32=rev Log: Revert "[clang-tidy] New checker for not null-terminated result caused by strlen(), size() or equal length" This reverts commit r344374. Removed:

[clang-tools-extra] r344441 - Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result"

Author: jonastoth Date: Sat Oct 13 02:30:46 2018 New Revision: 31 URL: http://llvm.org/viewvc/llvm-project?rev=31=rev Log: Revert "[doc] fix markup in clang-tidy bugprone-not-null-terminated-result" This reverts commit r344379. Modified:

[clang-tools-extra] r344940 - [clang-tidy] implement cppcoreguidelines macro rules

Author: jonastoth Date: Mon Oct 22 12:20:01 2018 New Revision: 344940 URL: http://llvm.org/viewvc/llvm-project?rev=344940=rev Log: [clang-tidy] implement cppcoreguidelines macro rules Summary: In short macros are discouraged by multiple rules (and sometimes reference randomly). [Enum.1],

[clang-tools-extra] r344947 - [clang-tidy] tryfix windows build

Author: jonastoth Date: Mon Oct 22 13:29:15 2018 New Revision: 344947 URL: http://llvm.org/viewvc/llvm-project?rev=344947=rev Log: [clang-tidy] tryfix windows build Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp Modified:

[clang-tools-extra] r345167 - [clang-tidy] Add the abseil-duration-factory-float check

Author: jonastoth Date: Wed Oct 24 10:40:50 2018 New Revision: 345167 URL: http://llvm.org/viewvc/llvm-project?rev=345167=rev Log: [clang-tidy] Add the abseil-duration-factory-float check Summary: This check finds cases where calls to an absl::Duration factory could use the more efficient

[clang-tools-extra] r345735 - [clang-tidy] new check 'readability-isolate-declaration'

Author: jonastoth Date: Wed Oct 31 09:50:44 2018 New Revision: 345735 URL: http://llvm.org/viewvc/llvm-project?rev=345735=rev Log: [clang-tidy] new check 'readability-isolate-declaration' Summary: This patch introduces a new clang-tidy check that matches on all `declStmt` that declare more then

r345737 - [clang] try-fix broken documentation builder

Author: jonastoth Date: Wed Oct 31 10:00:50 2018 New Revision: 345737 URL: http://llvm.org/viewvc/llvm-project?rev=345737=rev Log: [clang] try-fix broken documentation builder Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[clang-tools-extra] r345736 - [clang-tools-extra] fix broken link in release notes

Author: jonastoth Date: Wed Oct 31 09:59:41 2018 New Revision: 345736 URL: http://llvm.org/viewvc/llvm-project?rev=345736=rev Log: [clang-tools-extra] fix broken link in release notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified:

[clang-tools-extra] r345738 - [clang-tidy] add -fexceptions to failing unit-test, unbreak buildbot

Author: jonastoth Date: Wed Oct 31 10:08:09 2018 New Revision: 345738 URL: http://llvm.org/viewvc/llvm-project?rev=345738=rev Log: [clang-tidy] add -fexceptions to failing unit-test, unbreak buildbot Modified: clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp

[clang-tools-extra] r345742 - [clang-tidy] add missing '--' in RUN-line, unbreak buildbot

Author: jonastoth Date: Wed Oct 31 10:26:10 2018 New Revision: 345742 URL: http://llvm.org/viewvc/llvm-project?rev=345742=rev Log: [clang-tidy] add missing '--' in RUN-line, unbreak buildbot Modified: clang-tools-extra/trunk/test/clang-tidy/readability-isolate-declaration.cpp Modified:

[clang-tools-extra] r345995 - [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds

Author: jonastoth Date: Fri Nov 2 09:36:21 2018 New Revision: 345995 URL: http://llvm.org/viewvc/llvm-project?rev=345995=rev Log: [fix][clang-tidy] fix for r345961 that introduced a test failure on Windows builds r345961 introduced a path check in

[clang-tools-extra] r346173 - [clang-tidy] doc removew hitespace in front of code-block-line

Author: jonastoth Date: Mon Nov 5 14:21:27 2018 New Revision: 346173 URL: http://llvm.org/viewvc/llvm-project?rev=346173=rev Log: [clang-tidy] doc removew hitespace in front of code-block-line Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/boost-use-to-string.rst

[clang-tools-extra] r346176 - [clang-tidy] fix example code-blocks indendation

Author: jonastoth Date: Mon Nov 5 14:30:17 2018 New Revision: 346176 URL: http://llvm.org/viewvc/llvm-project?rev=346176=rev Log: [clang-tidy] fix example code-blocks indendation Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst

[clang-tools-extra] r346555 - [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay

Author: jonastoth Date: Fri Nov 9 12:57:28 2018 New Revision: 346555 URL: http://llvm.org/viewvc/llvm-project?rev=346555=rev Log: [clang-tidy] fix PR39583 - ignoring ParenCast for string-literals in pro-bounds-array-to-pointer-decay Summary: The fix to the issue that `const char* p = ("foo")`

r346554 - [ASTMatchers] overload ignoringParens for Expr

Author: jonastoth Date: Fri Nov 9 12:54:06 2018 New Revision: 346554 URL: http://llvm.org/viewvc/llvm-project?rev=346554=rev Log: [ASTMatchers] overload ignoringParens for Expr Summary: This patch allows fixing PR39583. Reviewers: aaron.ballman, sbenza, klimek Reviewed By: aaron.ballman

[clang-tools-extra] r346665 - [clang-tidy] new check: bugprone-too-small-loop-variable

Author: jonastoth Date: Mon Nov 12 08:01:39 2018 New Revision: 346665 URL: http://llvm.org/viewvc/llvm-project?rev=346665=rev Log: [clang-tidy] new check: bugprone-too-small-loop-variable The new checker searches for those for loops which has a loop variable with a "too small" type which means

[clang-tools-extra] r346676 - [clang-tidy] fix ARM tests, because int and long have same width

Author: jonastoth Date: Mon Nov 12 09:02:05 2018 New Revision: 346676 URL: http://llvm.org/viewvc/llvm-project?rev=346676=rev Log: [clang-tidy] fix ARM tests, because int and long have same width Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone-too-small-loop-variable.cpp

[clang-tools-extra] r346678 - Revert "Add a test checking clang-tidy can find libc++ on Mac"

Author: jonastoth Date: Mon Nov 12 09:22:36 2018 New Revision: 346678 URL: http://llvm.org/viewvc/llvm-project?rev=346678=rev Log: Revert "Add a test checking clang-tidy can find libc++ on Mac" This reverts commit r346653. Removed:

[clang-tools-extra] r343791 - [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init

Author: jonastoth Date: Thu Oct 4 08:55:37 2018 New Revision: 343791 URL: http://llvm.org/viewvc/llvm-project?rev=343791=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for performance-move-constructor-init Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers:

[clang-tools-extra] r343788 - [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check.

Author: jonastoth Date: Thu Oct 4 08:47:57 2018 New Revision: 343788 URL: http://llvm.org/viewvc/llvm-project?rev=343788=rev Log: [clang-tidy] Added pointer types to clang-tidy readability-identifier-naming check. Summary: Option to check for different naming conventions on the following

[clang-tools-extra] r343797 - [clang-tidy] fix failing unit tests

Author: jonastoth Date: Thu Oct 4 09:39:41 2018 New Revision: 343797 URL: http://llvm.org/viewvc/llvm-project?rev=343797=rev Log: [clang-tidy] fix failing unit tests The removal from the FIX-IT notes through the check-clang-tidy script was done incorrect. I did not detect beforehand but

[clang-tools-extra] r343789 - [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up

Author: jonastoth Date: Thu Oct 4 08:49:25 2018 New Revision: 343789 URL: http://llvm.org/viewvc/llvm-project?rev=343789=rev Log: [clang-tidy] fix PR39167, bugprone-exception-escape hangs-up Summary: The check bugprone-exception-escape should not register if -fno-exceptions is set for the

[clang-tools-extra] r343792 - [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments

Author: jonastoth Date: Thu Oct 4 08:59:30 2018 New Revision: 343792 URL: http://llvm.org/viewvc/llvm-project?rev=343792=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: xazax.hun,

[clang-tools-extra] r343796 - [clangd] fix another ambigous constructor in DexTest

Author: jonastoth Date: Thu Oct 4 09:29:58 2018 New Revision: 343796 URL: http://llvm.org/viewvc/llvm-project?rev=343796=rev Log: [clangd] fix another ambigous constructor in DexTest Modified: clang-tools-extra/trunk/unittests/clangd/DexTests.cpp Modified:

[clang-tools-extra] r343673 - [clang-tidy] NFC reorder registering in CppCoreGuidelines module

Author: jonastoth Date: Wed Oct 3 03:37:19 2018 New Revision: 343673 URL: http://llvm.org/viewvc/llvm-project?rev=343673=rev Log: [clang-tidy] NFC reorder registering in CppCoreGuidelines module Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[clang-tools-extra] r343848 - [clang-tidy] Replace deprecated std::ios_base aliases

Author: jonastoth Date: Fri Oct 5 06:36:00 2018 New Revision: 343848 URL: http://llvm.org/viewvc/llvm-project?rev=343848=rev Log: [clang-tidy] Replace deprecated std::ios_base aliases This check warns the uses of the deprecated member types of std::ios_base and replaces those that have a

Re: [clang-tools-extra] r343848 - [clang-tidy] Replace deprecated std::ios_base aliases

alone seeing it. > This is still giving the warning with clang 3.6. > > Thanks, > Mikael > >> Regards, >> Mikael >> >> On 10/05/2018 03:36 PM, Jonas Toth via cfe-commits wrote: >>> Author: jonastoth >>> Date: Fri Oct 5 06:36:00 2018 >>&g

[clang-tools-extra] r344044 - [clangd] fix miscompiling lower_bound call

Author: jonastoth Date: Tue Oct 9 06:24:50 2018 New Revision: 344044 URL: http://llvm.org/viewvc/llvm-project?rev=344044=rev Log: [clangd] fix miscompiling lower_bound call Modified: clang-tools-extra/trunk/clangd/index/Index.cpp Modified: clang-tools-extra/trunk/clangd/index/Index.cpp

[clang-tools-extra] r344046 - [clang-tidy] NFC fix warnings from missing braces

Author: jonastoth Date: Tue Oct 9 06:29:31 2018 New Revision: 344046 URL: http://llvm.org/viewvc/llvm-project?rev=344046=rev Log: [clang-tidy] NFC fix warnings from missing braces The std::array create multiple StringRef but did not wrap them in braces. Some compilers warned for that. Adding

[clang-tools-extra] r343564 - [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory

Author: jonastoth Date: Tue Oct 2 02:38:20 2018 New Revision: 343564 URL: http://llvm.org/viewvc/llvm-project?rev=343564=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for cppcoreguidelines-owning-memory Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: nemanjai,

[clang-tools-extra] r343565 - [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto

Author: jonastoth Date: Tue Oct 2 02:38:26 2018 New Revision: 343565 URL: http://llvm.org/viewvc/llvm-project?rev=343565=rev Log: [clang-tidy] NFC use CHECK-NOTES in test for cppgoreguidelines-avoid-goto Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: nemanjai,

[clang-tools-extra] r343000 - [clang-tidy] Add modernize-concat-nested-namespaces check

Author: jonastoth Date: Tue Sep 25 11:12:28 2018 New Revision: 343000 URL: http://llvm.org/viewvc/llvm-project?rev=343000=rev Log: [clang-tidy] Add modernize-concat-nested-namespaces check Summary: Finds instances of namespaces concatenated using explicit syntax, such as `namespace a {

[clang-tools-extra] r343001 - [clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects

Author: jonastoth Date: Tue Sep 25 11:15:52 2018 New Revision: 343001 URL: http://llvm.org/viewvc/llvm-project?rev=343001=rev Log: [clang-tidy] use CHECK-NOTES in tests for bugprone-macro-repeated-side-effects Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: xazax.hun,

[clang-tools-extra] r350466 - [Documentation] fix order of checks in checks/list.rst

Author: jonastoth Date: Sat Jan 5 03:40:05 2019 New Revision: 350466 URL: http://llvm.org/viewvc/llvm-project?rev=350466=rev Log: [Documentation] fix order of checks in checks/list.rst Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/list.rst Modified:

[clang-tools-extra] r351569 - [clang-tidy] add reproducer for PR39949 into test-suite

Author: jonastoth Date: Fri Jan 18 10:03:11 2019 New Revision: 351569 URL: http://llvm.org/viewvc/llvm-project?rev=351569=rev Log: [clang-tidy] add reproducer for PR39949 into test-suite Summary: The underlying issue is fixed in https://reviews.llvm.org/D56444 and this test ensures the issue

r351743 - [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers

Author: jonastoth Date: Mon Jan 21 05:26:18 2019 New Revision: 351743 URL: http://llvm.org/viewvc/llvm-project?rev=351743=rev Log: [clang] add tests to ExprMutAnalyzer that reproduced a crash in ASTMatchers Summary: This patch adds two unit-tests that are the result of reducing a crashing TU

[clang-tools-extra] r348793 - [clang-tidy] insert release notes for new checkers alphabetically

Author: jonastoth Date: Mon Dec 10 11:41:53 2018 New Revision: 348793 URL: http://llvm.org/viewvc/llvm-project?rev=348793=rev Log: [clang-tidy] insert release notes for new checkers alphabetically Summary: Almost all code review comments on new checkers {D55433} {D48866} {D54349} seem to ask

[clang-tools-extra] r348840 - [clang-tidy] NFC Consolidate test absl::Time implementation

Author: jonastoth Date: Tue Dec 11 04:42:17 2018 New Revision: 348840 URL: http://llvm.org/viewvc/llvm-project?rev=348840=rev Log: [clang-tidy] NFC Consolidate test absl::Time implementation Summary: Several tests re-implement these same prototypes (differently), so we can put them in a common

[clang-tools-extra] r348842 - Use the standard Duration factory matcher

Author: jonastoth Date: Tue Dec 11 04:45:51 2018 New Revision: 348842 URL: http://llvm.org/viewvc/llvm-project?rev=348842=rev Log: Use the standard Duration factory matcher Summary: A new check came in over the weekend; it should use our existing infrastructure for matching `absl::Duration`

[clang-tools-extra] r348343 - [clang-tidy] new check: bugprone-branch-clone

Author: jonastoth Date: Wed Dec 5 01:16:25 2018 New Revision: 348343 URL: http://llvm.org/viewvc/llvm-project?rev=348343=rev Log: [clang-tidy] new check: bugprone-branch-clone Summary: Implement a check for detecting if/else if/else chains where two or more branches are Type I clones of each

[clang-tools-extra] r348341 - Fix a false positive in misplaced-widening-cast

Author: jonastoth Date: Wed Dec 5 00:29:56 2018 New Revision: 348341 URL: http://llvm.org/viewvc/llvm-project?rev=348341=rev Log: Fix a false positive in misplaced-widening-cast Summary: bugprone-misplaced-widening-cast check used to give a false warning to the following example. enum

[clang-tools-extra] r348344 - Revert "[clang-tidy] new check: bugprone-branch-clone"

Author: jonastoth Date: Wed Dec 5 01:34:18 2018 New Revision: 348344 URL: http://llvm.org/viewvc/llvm-project?rev=348344=rev Log: Revert "[clang-tidy] new check: bugprone-branch-clone" The patch broke on buildbot with assertion-failure. Revert until this is figured out. Removed:

[clang-tools-extra] r348165 - Revert "[clang-tidy] Add the abseil-duration-comparison check"

Author: jonastoth Date: Mon Dec 3 10:59:27 2018 New Revision: 348165 URL: http://llvm.org/viewvc/llvm-project?rev=348165=rev Log: Revert "[clang-tidy] Add the abseil-duration-comparison check" This commit broke buildbots and needs adjustments. Removed:

  1   2   >