[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

jroelofs added a comment. (i.e. you should delete that, since this is the last dependency on it AFAICT) Repository: rL LLVM https://reviews.llvm.org/D40816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

jroelofs added a comment. There's a: `set(TARGET_TRIPLE ...)` in each of these runtimes' CMakeLists.txt... Repository: rL LLVM https://reviews.llvm.org/D40816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D40816: [libunwind] Use the correct variable name for target triple in lit

jroelofs added a comment. I think just remove it from them. Repository: rL LLVM https://reviews.llvm.org/D40816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

jroelofs added a comment. I say that because there are contexts where it is **absolutely critical** that https://xkcd.com/221/ not be the implementation of an RNG. Repository: rCXX libc++ https://reviews.llvm.org/D41316 ___ cfe-commits mailing

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

jroelofs added a comment. I'd much rather provide no implementation than one that lies. Broken builds are much safer than problems at runtime. Repository: rCXX libc++ https://reviews.llvm.org/D41316 ___ cfe-commits mailing list

[PATCH] D40218: [Clang] Add __builtin_launder

jroelofs added inline comments. Comment at: include/clang/Basic/Builtins.def:480 BUILTIN(__builtin_thread_pointer, "v*", "nc") +BUILTIN(__builtin_launder, "v*v*", "nt") GCC's is type-generic: ``` #include bool is_type_generic() { int v; return

[PATCH] D40218: [Clang] Add __builtin_launder

jroelofs added inline comments. Comment at: include/clang/Basic/Builtins.def:480 BUILTIN(__builtin_thread_pointer, "v*", "nc") +BUILTIN(__builtin_launder, "v*v*", "nt") EricWF wrote: > jroelofs wrote: > > GCC's is type-generic: > > > > ``` > > #include > >

[PATCH] D39793: [asan] Remove semicolon after do {} while (0)

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D39793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM

jroelofs added a comment. In https://reviews.llvm.org/D39534#915920, @mstorsjo wrote: > In https://reviews.llvm.org/D39534#915916, @compnerd wrote: > > > Very well, if thats the current implementation in the AsmParser, thats > > reasonable. I don't think that the directive has anything to do

[PATCH] D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM

jroelofs added a comment. In https://reviews.llvm.org/D39534#915937, @mstorsjo wrote: > In https://reviews.llvm.org/D39534#915935, @jroelofs wrote: > > > In https://reviews.llvm.org/D39534#915920, @mstorsjo wrote: > > > > > In https://reviews.llvm.org/D39534#915916, @compnerd wrote: > > > > > >

[PATCH] D40775: [libcxx] Add underscores to win32 locale headers.

jroelofs added inline comments. Comment at: src/support/win32/locale_win32.cpp:90 +__libcpp_locale_guard __current(__loc); va_list ap; +va_start( ap, __format ); __ap Comment at: src/support/win32/locale_win32.cpp:99 {

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

jroelofs added a comment. In https://reviews.llvm.org/D28820#944365, @efriedma wrote: > > What is the best way to modify the code for this compiler change ? > > Currently, the "interrupt" attribute only has an effect on functions, not > function pointers, so your code won't work the way you

[PATCH] D41733: [Driver] Suggest correctly spelled driver options

jroelofs added inline comments. Comment at: lib/Driver/Driver.cpp:191 if (A->getOption().hasFlag(options::Unsupported)) { - Diag(diag::err_drv_unsupported_opt) << A->getAsString(Args); - ContainsError |= Diags.getDiagnosticLevel(diag::err_drv_unsupported_opt, -

[PATCH] D41733: [Driver] Suggest correctly spelled driver options

jroelofs added inline comments. Comment at: lib/Driver/Driver.cpp:191 if (A->getOption().hasFlag(options::Unsupported)) { - Diag(diag::err_drv_unsupported_opt) << A->getAsString(Args); - ContainsError |= Diags.getDiagnosticLevel(diag::err_drv_unsupported_opt, -

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

jroelofs added a comment. > Should we go with current patch? You'll need a bunch of `UNSUPPORTED: has-no-random-device` or something like it, but other than that, I'm happy with the patch as-is. Repository: rCXX libc++ https://reviews.llvm.org/D41316

[PATCH] D42645: New simple Checker for mmap calls

jroelofs added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/Checkers.td:399 + def MmapWriteExecChecker : Checker<"MmapWriteExec">, +HelpText<"Check if mmap() call is not both writable and executable">, +DescFile<"MmapWriteExecChecker.cpp">;

[PATCH] D42645: New simple Checker for mmap calls

jroelofs added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:1 +// MmapWriteExecChecker.cpp - Check for the prot argument +// Needs one of these at the top: ``` //===- MmapWriteExecChecker.cpp - Check the mmap prot argument

[PATCH] D42645: New simple Checker for mmap calls

jroelofs added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MmapWriteExecChecker.cpp:1 +// MmapWriteExecChecker.cpp - Check for the prot argument +// jroelofs wrote: > Needs one of these at the top: > > ``` > //===- MmapWriteExecChecker.cpp - Check

[PATCH] D43159: Modernize: Use nullptr more.

jroelofs added a comment. Is it worth adding `-Werror=zero-as-null-pointer-constant` to the build? Repository: rCXX libc++ https://reviews.llvm.org/D43159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51354: Fix the -print-multi-directory flag to print the selected multilib.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Repository: rC Clang https://reviews.llvm.org/D51354 ___ cfe-commits mailing list

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

jroelofs added a subscriber: efriedma. jroelofs added a comment. > the targets where you would want to use this can't run the libcxx testsuite anyway (because they don't have an operating system to run the test programs under). I used to run libcxx tests for an arm baremetal toolchain I was

[PATCH] D52530: [analyzer] scan-build: if --status-bugs is passed, don't forget about the exit status of the actual build

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D52530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52153: scan-build: Add support of the option --exclude like in scan-build-py

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D52153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52151: Also manages clang-X as tool for scan-build

jroelofs added a comment. `$triple-clang`, also Repository: rC Clang https://reviews.llvm.org/D52151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

jroelofs added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122 + +/// \p Flag must be a flag accepted by the driver with its leading '-' removed, +// otherwise '-print-multi-lib' will not emit them correctly. Can we enforce this

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 246604. jroelofs added a comment. Implement review feedback: - Re-purpose `HeaderFileExtensionsUtils.h` to support headers *and* sources. - Surround file extension in diagnostic with `''`s. I have these as two separate patches locally, but I don't know how

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs created this revision. jroelofs added reviewers: njames93, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. https://reviews.llvm.org/D74669#inline-685657 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75621 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 248203. jroelofs added a comment. Split out https://reviews.llvm.org/D75621 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 248246. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248245. jroelofs added a comment. Preserve backwards compatibility of ',' as a delimiter (for now). > The llvm::StringRef::split function can take multiple split characters, AFAIU, that's for multi-character delimiters, not multiple delimiters.

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 248208. jroelofs marked an inline comment as not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248206. jroelofs added a comment. Fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621 Files:

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248357. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621 Files: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp

[PATCH] D75489: [clang-tidy] Generalize HeaderFileExtensions.{h, cpp}. NFC

jroelofs created this revision. jroelofs added reviewers: njames93, aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. jroelofs added a child revision: D74669: [clang-tidy] New check: bugprone-suspicious-include. jroelofs marked an inline

[PATCH] D75489: [clang-tidy] Generalize HeaderFileExtensions.{h, cpp}. NFC

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:14 #include "clang/Basic/SourceManager.h" +#include "llvm/ADT/Optional.h" #include "llvm/ADT/SmallSet.h" this

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248757. jroelofs added a comment. - Drop dead include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621 Files:

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248755. jroelofs added a comment. - Don't spam the deprecation message. Move that to release notes. - Drop unnecessary `const`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs marked 2 inline comments as done. jroelofs added a comment. In D74669#1902107 , @njames93 wrote: > Adding the parent revision means you don't need to have those changes in this > patch. IIUC, that is what I've already done:

[PATCH] D75489: [clang-tidy] Generalize HeaderFileExtensions.{h, cpp}. NFC

jroelofs updated this revision to Diff 247762. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75489/new/ https://reviews.llvm.org/D75489 Files: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.cpp

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 247764. jroelofs added a comment. implement review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

jroelofs added a comment. +1, looks good with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73904/new/ https://reviews.llvm.org/D73904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 244994. jroelofs added a comment. Implement review feedback re: DiagLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp:59 +Optional File = PP->LookupFile( +HashLoc /* FIXME: lies */, (FileName + RE).str(), IsAngled, nullptr,

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 245031. jroelofs added a comment. Make the diagnostics more accurate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

jroelofs created this revision. jroelofs added reviewers: efriedma, weimingz, EricWF. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Fixes: https://bugs.llvm.org/show_bug.cgi?id=35527 https://bugs.llvm.org/show_bug.cgi?id=35528 Repository: rG LLVM

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5931 + if (Caller->hasAttr()) { +const Decl *CalleeDecl = FDecl; +if (const auto *UO = dyn_cast(Fn->IgnoreParens())) { This

[PATCH] D28820: Warn when calling a non interrupt function from an interrupt on ARM

jroelofs added a comment. Herald added a subscriber: kristof.beyls. In D28820#945118 , @kc.austin2017 wrote: > In D28820#944865 , @jroelofs wrote: > > > https://bugs.llvm.org/show_bug.cgi?id=35527 > > > >

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked an inline comment as done. jroelofs added a comment. In D74669#1878168 , @njames93 wrote: > I have a feeling this check should be called something along the lines of > bugprone-suspicous-include. That's a much better name, I like it.

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked 4 inline comments as done and an inline comment as not done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/NoIncludeCPPCheck.cpp:62 + Check.diag(HashLoc, "suspicious #include") + <<

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 244883. jroelofs marked an inline comment as done. jroelofs added a comment. - Renamed to bugprone-suspicious-include - Removed FixIts in favor of `note:` suggestions, iff the suggested file exists on the header search path. - Removed unnecessary unused

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp:59 +Optional File = PP->LookupFile( +HashLoc /* FIXME: lies */, (FileName + RE).str(), IsAngled, nullptr,

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 244884. jroelofs added a comment. git format-patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.h:26 +/// For the user-facing documentation see: +///

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs created this revision. jroelofs added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, kbarton, xazax.hun, mgorny, nemanjai. Herald added a project: clang. Detects and fixes suspicious code like: `#include "foo.cpp"`. Inspired by:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249224. jroelofs added a comment. Add missing release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs closed this revision. jroelofs marked 7 inline comments as done. jroelofs added a comment. Thanks for the review! https://github.com/llvm/llvm-project/commit/1e0669bfe05f0f48ee88152c4a1d581f484f8d67 Comment at:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249223. jroelofs added a comment. Implement review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs marked 6 inline comments as done. jroelofs added a comment. https://github.com/llvm/llvm-project/commit/52bbdad7d63fd060d102b3591b433d116a982255 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs added a comment. re-landed in https://github.com/llvm/llvm-project/commit/2c9cf9f4ddd01ae9eb47522266a6343104f9d0b5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:44-46 bool parseFileExtensions(StringRef AllFileExtensions, - FileExtensionsSet , char Delimiter); +

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:44-46 bool parseFileExtensions(StringRef AllFileExtensions, - FileExtensionsSet , char Delimiter); +

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249377. jroelofs added a comment. Don't fire on `#import`s. The error on Windows suggests it would normally do the "right" thing anyway: http://45.33.8.238/win/10088/step_8.txt

[PATCH] D75489: [clang-tidy] Generalize HeaderFileExtensions.{h, cpp}. NFC

jroelofs closed this revision. jroelofs added a comment. https://github.com/llvm/llvm-project/commit/3486cc014b208df3897cf5656db0d0fdeae26d6b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75489/new/ https://reviews.llvm.org/D75489

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs closed this revision. jroelofs added a comment. https://github.com/llvm/llvm-project/commit/47caa69120e582bf1b795ec646f069c83b0e9456 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs updated this revision to Diff 249164. jroelofs added a comment. Fix comment, add docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files:

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

jroelofs marked 3 inline comments as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.h:9 + +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_UTILS_HEADER_FILE_EXTENSIONS_UTILS_H +#define

<    1   2