Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added inline comments. Comment at: include/__config:19 @@ -18,1 +18,3 @@ +#include __config_site + #ifdef __GNUC__ jroelofs wrote: mclow.lists wrote: espositofulvio wrote: mclow.lists wrote: I'm reluctant to do this; because every include file

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs updated this revision to Diff 31878. jroelofs added a comment. fix typo http://reviews.llvm.org/D11963 Files: CMakeLists.txt include/CMakeLists.txt include/__config test/libcxx/test/config.py test/std/atomics/libcpp-has-no-threads.pass.cpp

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:744 @@ +743,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# ifndef _LIBCPP_THREAD_API +# error No thread API The reason to use `CMAKE_BINARY_DIR` over `CMAKE_CURRENT_SOURCE_DIR` as the location for this build

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#227444, @EricWF wrote: I also just realized that this change will currently likely play havoc with how libc++ and libc++abi build together. In order to build libc++ and libc++abi together we would need to 1. Configure libc++

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#228024, @EricWF wrote: Wouldn't it still be a mess if you build both libc++ and libc++abi out-of-tree? The user would have to be aware of these weird requirements. Oh, yeah, true. Do we have any out-of-tree builders to make sure

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Both styles look ok to me, with a slight preference toward matching clang's. Comment at: docs/BuildingLibcxx.rst:56 @@ +55,3 @@ +Mac users, remember to be careful when

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

jroelofs added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers I feel like a warning is not enough...

Re: [PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

jroelofs added a comment. I like it! http://reviews.llvm.org/D12209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ jroelofs wrote: espositofulvio wrote: theraven wrote: espositofulvio wrote:

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ @espositofulvio: @ed meant this: ``` #ifndef _WIN32 # include unistd.h # if

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ espositofulvio wrote: jroelofs wrote: jroelofs wrote: @espositofulvio: @ed meant

Re: [PATCH] D11781: Refactored pthread usage in libcxx

jroelofs added inline comments. Comment at: include/__config:742 @@ +741,3 @@ +#ifndef _LIBCPP_HAS_NO_THREADS +# if defined(__FreeBSD__) || \ +defined(__NetBSD__) || \ jroelofs wrote: @espositofulvio: @ed meant this: ``` #ifndef _WIN32 # include

[PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs created this revision. jroelofs added reviewers: mclow.lists, danalbert. jroelofs added subscribers: EricWF, ed, espositofulvio, cfe-commits, mclow.lists. This also means that we no longer have to teach lit how to define them when running tests. I have a corresponding patch for

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs updated this revision to Diff 31949. jroelofs added a comment. Add license text to the new file, and move the two has-no-threads tests to test/libcxx. http://reviews.llvm.org/D11963 Files: CMakeLists.txt include/CMakeLists.txt include/__config include/__config_site.in

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

jroelofs updated this revision to Diff 32996. jroelofs added a comment. The diff uploaded strangely... trying again. http://reviews.llvm.org/D12294 Files: CMakeLists.txt test/libcxx/atomics/libcpp-has-no-threads.fail.cpp test/libcxx/atomics/libcpp-has-no-threads.pass.cpp

[PATCH] D12294: Misc cleanups re-commandeered from D11963.

jroelofs created this revision. jroelofs added a reviewer: EricWF. jroelofs added a subscriber: cfe-commits. This separates out the bits of D11963 which were drive-by fixes, which aren't really relevant to the __config_site part of that change. http://reviews.llvm.org/D12294 Files:

Re: [PATCH] D12294: Misc cleanups re-commandeered from D11963.

jroelofs closed this revision. jroelofs added a comment. r245876 http://reviews.llvm.org/D12294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r245876 - Misc drive-by cleanups. NFC

Author: jroelofs Date: Mon Aug 24 16:20:07 2015 New Revision: 245876 URL: http://llvm.org/viewvc/llvm-project?rev=245876view=rev Log: Misc drive-by cleanups. NFC http://reviews.llvm.org/D12294 Added: libcxx/trunk/test/libcxx/atomics/

Re: [libcxx] r251062 - Disable linker scripts when the ABI library is not specified or is none.

On 10/22/15 2:50 PM, Eric Fiselier via cfe-commits wrote: Author: ericwf Date: Thu Oct 22 15:50:07 2015 New Revision: 251062 URL: http://llvm.org/viewvc/llvm-project?rev=251062=rev Log: Disable linker scripts when the ABI library is not specified or is none. Modified:

Re: [libcxx] r251062 - Disable linker scripts when the ABI library is not specified or is none.

On 10/22/15 2:59 PM, Eric Fiselier wrote: Yeah, that review hasn't landed yet. It should be called auto, but we need to make it actually "automatic". Currently "none" really means don't help me, not that we will automatically figure it out for you. I agree with your requested change, it's just

Re: [PATCH] D12382: Extend linux header search to find libc++ headers in c++/vN for any N.

jroelofs added a comment. LGTM Comment at: lib/Driver/ToolChains.cpp:3545 @@ +3544,3 @@ +!VersionText.slice(1, StringRef::npos).getAsInteger(10, Version)) { + if (Version > MaxVersion) { +MaxVersion = Version; Since you've got logic here to

Re: [PATCH] D12669: [libcxxabi] Fix alignment of pointers returned by fallback_malloc

jroelofs added inline comments. Comment at: src/fallback_malloc.ipp:69 @@ -59,1 +68,3 @@ +// Size: 4 +// Alignment: 2 struct heap_node { EricWF wrote: > compnerd wrote: > > Make this a set of static_asserts? > I was going to but I wasn't 100% sure this would be

[PATCH] D14130: Delete dead code in the LibcxxAndAbiBuilder

jroelofs created this revision. jroelofs added a reviewer: EricWF. jroelofs added a subscriber: cfe-commits. Now that we store this information in the __config file, these aren't needed. http://reviews.llvm.org/D14130 Files: zorg/buildbot/builders/LibcxxAndAbiBuilder.py Index:

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:880 @@ +879,3 @@ +# See: libcxxabi/test/lit.cfg +lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -lunwind -ldl -L/opt/llvm/lib/clang/3.6.0/lib/linux

Re: r252474 - Create install targets for scan-build and scan-view

On 11/10/15 12:48 PM, Tobias Grosser wrote: On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474=rev Log: Create install targets for scan-build and scan-view

r252641 - Fix missing CMake dependency introduced in r252474

Author: jroelofs Date: Tue Nov 10 14:01:22 2015 New Revision: 252641 URL: http://llvm.org/viewvc/llvm-project?rev=252641=rev Log: Fix missing CMake dependency introduced in r252474 Modified: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-view/CMakeLists.txt Modified:

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a subscriber: jroelofs. jroelofs added a comment. Would you mind re-uploading this patch as a diff against upstream trunk with full context? http://reviews.llvm.org/D9600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added a comment. In http://reviews.llvm.org/D14293#287174, @rmaprath wrote: > Would it be OK if I commit the x86 buildbot changes (Dmitri approved these > earlier) while the ARM buildbot changes are being reviewed? I suppose the > changes would only take effect once @gkistanova

Re: r252474 - Create install targets for scan-build and scan-view

On 11/10/2015 09:05 PM, Jonathan Roelofs wrote: On 11/10/15 12:48 PM, Tobias Grosser wrote: On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474=rev Log: Create i

Re: r252474 - Create install targets for scan-build and scan-view

On 11/10/15 1:35 PM, Tobias Grosser wrote: On 11/10/2015 09:05 PM, Jonathan Roelofs wrote: On 11/10/15 12:48 PM, Tobias Grosser wrote: On 11/09/2015 05:12 PM, Jonathan Roelofs via cfe-commits wrote: Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org

r252662 - Implement the fix that r252641 should have been

Author: jroelofs Date: Tue Nov 10 16:38:59 2015 New Revision: 252662 URL: http://llvm.org/viewvc/llvm-project?rev=252662=rev Log: Implement the fix that r252641 should have been Modified: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-view/CMakeLists.txt Modified:

r252664 - Implement post-commit review feedback on r252662

Author: jroelofs Date: Tue Nov 10 16:48:11 2015 New Revision: 252664 URL: http://llvm.org/viewvc/llvm-project?rev=252664=rev Log: Implement post-commit review feedback on r252662 Modified: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-view/CMakeLists.txt Modified:

r252667 - Fix build

Author: jroelofs Date: Tue Nov 10 16:59:18 2015 New Revision: 252667 URL: http://llvm.org/viewvc/llvm-project?rev=252667=rev Log: Fix build Modified: cfe/trunk/tools/scan-view/CMakeLists.txt Modified: cfe/trunk/tools/scan-view/CMakeLists.txt URL:

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

jroelofs updated this revision to Diff 39693. jroelofs added a comment. Add flags to turn the new targets off. http://reviews.llvm.org/D14403 Files: tools/CMakeLists.txt tools/Makefile tools/scan-build/CMakeLists.txt tools/scan-build/Makefile tools/scan-build/scan-build

r252489 - Fix the cmake build after r252474 broke it

Author: jroelofs Date: Mon Nov 9 10:47:09 2015 New Revision: 252489 URL: http://llvm.org/viewvc/llvm-project?rev=252489=rev Log: Fix the cmake build after r252474 broke it Modified: cfe/trunk/tools/scan-build/CMakeLists.txt cfe/trunk/tools/scan-view/CMakeLists.txt Modified:

r252474 - Create install targets for scan-build and scan-view

Author: jroelofs Date: Mon Nov 9 10:12:56 2015 New Revision: 252474 URL: http://llvm.org/viewvc/llvm-project?rev=252474=rev Log: Create install targets for scan-build and scan-view http://reviews.llvm.org/D14403 Added: cfe/trunk/tools/scan-build/CMakeLists.txt

Re: [PATCH] D14292: [libcxx] Make it possible to build a no-exceptions variant of libcxx.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D14292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. r252474 http://reviews.llvm.org/D14403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14471: [AArch64] Fix a crash in driver

On 11/11/15 5:01 PM, Akira Hatanaka via cfe-commits wrote: ahatanak added a comment. In http://reviews.llvm.org/D14471#287412, @rengolin wrote: In http://reviews.llvm.org/D14471#286380, @ahatanak wrote: I think I can use macro __aarch64__ to have getAArch64TargetCPU return "native" when

r252981 - [scan-build] Create share directory similar to scan-view's

Author: jroelofs Date: Thu Nov 12 18:32:54 2015 New Revision: 252981 URL: http://llvm.org/viewvc/llvm-project?rev=252981=rev Log: [scan-build] Create share directory similar to scan-view's Added: cfe/trunk/tools/scan-build/share/ cfe/trunk/tools/scan-build/share/scanview.css -

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a comment. If you you're familiar with git, I'm asking you to: squash, rebase, and `git diff -U999`, then upload the resulting patch. If you use svn, I'm asking you to: `svn diff -r$(FirstCommit):$(LastCommit) --diff-cmd=diff -x -U999`, and upload that. The reason to squash all

r253081 - Fix build... again

Author: jroelofs Date: Fri Nov 13 15:04:14 2015 New Revision: 253081 URL: http://llvm.org/viewvc/llvm-project?rev=253081=rev Log: Fix build... again Modified: cfe/trunk/tools/scan-build/Makefile Modified: cfe/trunk/tools/scan-build/Makefile URL:

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs added a comment. Thanks for re-uploading! Comment at: tools/scan-build-py/README.md:39 @@ +38,3 @@ + +$ python setup.py build +$ python setup.py install Mind adding a CMakeLists.txt to drive these from the clang build itself?

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

jroelofs added a comment. In http://reviews.llvm.org/D14403#284054, @beanz wrote: > I would prefer if installing these were optional and could be toggled on/off. I'll add flags for that. http://reviews.llvm.org/D14403 ___ cfe-commits mailing

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added a subscriber: jroelofs. Comment at: buildbot/osuosl/master/config/builders.py:771 @@ +770,3 @@ + # the -fno-exceptions library build. + additional_features={'no-libcxx-tests'}), + 'category': 'libcxx'}, How bad is

Re: [PATCH] D14293: [libcxx] Add -fno-exceptions libcxx builders to zorg

jroelofs added a comment. > Counter proposal, we mark all the currently failing (-fno-exceptions) test > cases with: > > // XFAIL: libcpp-no-exceptions > > > This has the following advantages: > > - No need to change buildbots to skip tests > - The bots will catch any regressions

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

jroelofs added inline comments. Comment at: www/analyzer/installation.html:103 @@ -102,3 +102,1 @@ -Currently these are not installed using make install, and -are located in $(SRCDIR)/tools/clang/tools/scan-build and @zaks.anna Do you know if there was a

Re: [PATCH] D14403: Create install targets for scan-build and scan-view

jroelofs updated this revision to Diff 39529. jroelofs added a comment. Forgot to `svn add` after rebasing the patch on top of upstream. http://reviews.llvm.org/D14403 Files: tools/CMakeLists.txt tools/Makefile tools/scan-build/CMakeLists.txt tools/scan-build/Makefile

Re: [PATCH] D13820: [libunwind] Add FreeBSD _Unwind_Ptr typedef

jroelofs added a subscriber: jroelofs. jroelofs added a comment. LGTM http://reviews.llvm.org/D13820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13714: [libcxx] Use __config_site to configure the test suite features.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

jroelofs added inline comments. Comment at: CMakeLists.txt:71 @@ -70,1 +70,3 @@ +# Use a static copy of the ABI library when linking libc++. This option +# cannot be used with LIBCXX_ENABLE_ABI_LINKER_SCRIPT. option(LIBCXX_ENABLE_STATIC_ABI_LIBRARY "Statically link the ABI

Re: [PATCH] D13739: [libcxx] Make libc++.so a linker script by default on most platforms.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13557: Make locale code compile on Linux without GLIBC.

jroelofs added a subscriber: jroelofs. jroelofs added a comment. I don't think it's correct to say that `!defined(__GLIBC__) && defined(__linux__) ==> Musl` (nor is the converse true). Unfortunately, Musl intentionally doesn't provide that sort of macro [1], so to provide support for Musl in

Re: [PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

jroelofs added inline comments. Comment at: test/libcxx/test/config.py:364 @@ +363,3 @@ +deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and +cxx_abi == 'none' and +not use_llvm_unwinder)

Re: [PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added a comment. LGTM, with one small nit (and once http://reviews.llvm.org/D13407 lands): Comment at: src/locale.cpp:1176 @@ -1171,3 +1175,3 @@ } -#endif // __GLIBC__ || __EMSCRIPTEN__ || __NETBSD__ +#endif // __GLIBC__ || __NETBSD__ || || __EMSCRIPTEN__ ||

Re: [libcxx] r249475 - Remove unnecessary inline functions capturing the contents of C library macros.

On 10/6/15 4:03 PM, Richard Smith via cfe-commits wrote: Author: rsmith Date: Tue Oct 6 17:03:22 2015 New Revision: 249475 URL: http://llvm.org/viewvc/llvm-project?rev=249475=rev Log: Remove unnecessary inline functions capturing the contents of C library macros. The C standard requires

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

jroelofs added a comment. Other than that, LGTM too. Comment at: lib/Driver/ToolChains.cpp:4081 @@ +4080,3 @@ + + std::string PS4SDKDir = (EnvValue ? EnvValue : getDriver().Dir + "/../.."); + Use `llvm::sys::path::append` instead of `std::string::operator+`

Re: [PATCH] D13673: Add initial support for the MUSL C library.

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. http://reviews.llvm.org/D13407 has landed. http://reviews.llvm.org/D13673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. One small suggestion. Otherwise, this still LGTM. Comment at: lib/Driver/ToolChains.cpp:4078 @@ +4077,3 @@ + // should be /host_tools/bin. + const char *EnvValue =

Re: [PATCH] D13673: Add initial support for the MUSL C library.

jroelofs added inline comments. Comment at: include/__config:370 @@ -369,2 +369,3 @@ #elif defined(__linux__) -#include +#if defined(__GLIBC__) +# include EricWF wrote: > Where does the `__GLIBC__` macro definition come from? I thought it came > from the C

Re: [PATCH] D11740: ABI versioning macros for libc++

jroelofs added a subscriber: jroelofs. Comment at: include/__config_site.in:13 @@ -12,1 +12,3 @@ +#cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@ +#cmakedefine _LIBCPP_ABI_UNSTABLE This doesn't look right to me. What do you want this to expand to when it

Re: [PATCH] D11740: ABI versioning macros for libc++

jroelofs added inline comments. Comment at: include/__config_site.in:13 @@ -12,1 +12,3 @@ +#cmakedefine _LIBCPP_ABI_VERSION @_LIBCPP_ABI_VERSION@ +#cmakedefine _LIBCPP_ABI_UNSTABLE jroelofs wrote: > This doesn't look right to me. What do you want this to expand

Re: [PATCH] D14130: Delete dead code in the LibcxxAndAbiBuilder

jroelofs closed this revision. jroelofs added a comment. r253480 http://reviews.llvm.org/D14130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14616: [libcxx] Replace TEST_HAS_NO_EXCEPTIONS with _LIBCPP_NO_EXCEPTIONS [NFC]

jroelofs requested changes to this revision. jroelofs added a comment. This revision now requires changes to proceed. This change is not the right thing to do. The reason this is a separate macro is that we don't want the tests in `test/std` to depend on implementation details of libcxx itself.

Re: r253486 - Removing the AST matcher test for thread_local storage duration. Not all platforms support TLS, and on platforms that do not support it, use of thread_local causes an error. Since there'

On 11/18/15 11:37 AM, Aaron Ballman via cfe-commits wrote: Author: aaronballman Date: Wed Nov 18 12:37:29 2015 New Revision: 253486 URL: http://llvm.org/viewvc/llvm-project?rev=253486=rev Log: Removing the AST matcher test for thread_local storage duration. Not all platforms support TLS, and

Re: [PATCH] D9600: Add scan-build python implementation

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. Sounds reasonable and I can help with setting up the CMake & LIT goop once you've got it committed. FWIW, I was able to get a simple example

r252991 - Fix build

Author: jroelofs Date: Thu Nov 12 19:23:40 2015 New Revision: 252991 URL: http://llvm.org/viewvc/llvm-project?rev=252991=rev Log: Fix build Modified: cfe/trunk/tools/scan-view/CMakeLists.txt Modified: cfe/trunk/tools/scan-view/CMakeLists.txt URL:

Re: [PATCH] D11333: [libcxx] Add special warning flag detection logic to compiler.py

jroelofs added a comment. the `addWarningFlagIfSupported` part of this patch LGTM. Comment at: test/libcxx/compiler.py:88 @@ -87,1 +87,3 @@ +def compileString(self, source, out=None, flags=[], env=None, cwd=None): +cmd = self.compileCmd('-', out, flags)

Re: [PATCH] D11333: [libcxx] Add special warning flag detection logic to compiler.py

jroelofs added inline comments. Comment at: test/libcxx/compiler.py:195 @@ +194,3 @@ +cmd.remove('-v') +out, err, rc = lit.util.executeCommand(cmd, input='#error\n') +assert rc != 0 ... you could at least use `compileString` here.

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

jroelofs added a comment. Ah, usually the process is that you get your patch through review, and when someone accepts it, then you can commit it. If you do not have commit rights, then you can get someone else to commit it for you. Accepted = ok to commit Closed = I've committed it Do you

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

jroelofs added a comment. @blastrock have you committed this yet? http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D9639: Do not include pthread.h and sched.h when threads are disabled

jroelofs accepted this revision. jroelofs added a comment. r246168 http://reviews.llvm.org/D9639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r246168 - Do not include pthread.h and sched.h when threads are disabled

Author: jroelofs Date: Thu Aug 27 12:47:34 2015 New Revision: 246168 URL: http://llvm.org/viewvc/llvm-project?rev=246168view=rev Log: Do not include pthread.h and sched.h when threads are disabled Patch by Philippe Daouadi! http://reviews.llvm.org/D9639 Modified:

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#234789, @EricWF wrote: Copy the headers to the build directory during every build instead of just during CMake configuration. Sounds like this would cause every build to effectively be a full build. I don't think we want that...

Re: [PATCH] D12209: [libcxx] Remove installation rules on Darwin when it would overwrite the system installation.

jroelofs accepted this revision. This revision is now accepted and ready to land. Comment at: CMakeLists.txt:105 @@ +104,3 @@ +if (${CMAKE_SYSTEM_NAME} MATCHES Darwin AND NOT LIBCXX_OVERRIDE_DARWIN_INSTALL) + if (${CMAKE_INSTALL_PREFIX} STREQUAL /usr) +message(WARNING

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. Without the context of this review, this strategy probably won't make any sense. So it's probably worth capturing these notes in a comment that describes why we're doing it that way. http://reviews.llvm.org/D11963 ___

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

jroelofs added inline comments. Comment at: utils/gen_link_script/gen_link_script.py:1 @@ +1,2 @@ +#!/usr/bin/env python +import os Do you foresee these linker scripts being significantly more complicated for other platforms? ISTM that it would be much simpler

Re: [PATCH][www] Mention that libcxx is necessary on OS X

On 9/4/15 2:45 PM, Yuri Gribov via cfe-commits wrote: Hi all, According to https://llvm.org/bugs/show_bug.cgi?id=17821 , when Clang gets built on OS X we need to build it with libcxx and libcxxabi (otherwise tests will fail to link with "can't find iostream". This patch adds a note to getting

Re: [PATCH] D12512: [libcxxabi] Manually align pointers in __cxa_allocate_exception - Fixes PR24604

jroelofs added a comment. In http://reviews.llvm.org/D12512#236988, @majnemer wrote: > In http://reviews.llvm.org/D12512#236987, @EricWF wrote: > > > In http://reviews.llvm.org/D12512#236984, @majnemer wrote: > > > > > Wouldn't this change be problematic if you threw to code which was > > >

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

jroelofs added a comment. I trust your judgement. http://reviews.llvm.org/D12508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

jroelofs added a subscriber: jroelofs. jroelofs added a comment. A testcase would be good, regardless of which of the proposed fixes ends up being chosen. http://reviews.llvm.org/D12689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs added a comment. Won't it break hf-only builds, if you don't do both commits at the same time? http://reviews.llvm.org/D12996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs added a comment. Oh, yeah, true. http://reviews.llvm.org/D12996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13051: Add placeholder __libcpp_relaxed_store() for when atomic builtins are not available.

jroelofs added a comment. In http://reviews.llvm.org/D13051#250910, @EricWF wrote: > @jroelofs @dim, could we fallback to the __sync_* builtins on arm? @dim would need armv4-flavored implementations of them in compiler-rt (if that's what he's using)... the existing ones use instructions that

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. Now that you've got http://reviews.llvm.org/D13155 squared away, LGTM. http://reviews.llvm.org/D12996

Re: [PATCH] D12996: Driver: support ARM/HF on a single toolchain

jroelofs added a subscriber: jroelofs. jroelofs added a comment. You'll also need a corresponding patch for compiler-rt to make it use the new name appropriately. http://reviews.llvm.org/D12996 ___ cfe-commits mailing list

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

jroelofs added a comment. Design doc looks good! I think it captures all the design constraints well, and the proposed solution satisfies those constraints as far as I am concerned. Thumbs up from me... but I'll still defer the final 'LGTM' to @mclow.lists. http://reviews.llvm.org/D13407

Re: [PATCH] D13465: Add SafeStack support for test-suite.

jroelofs added a subscriber: jroelofs. jroelofs accepted this revision. jroelofs added a reviewer: jroelofs. jroelofs added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13465 ___ cfe-commits mailing list

Re: [PATCH] D13465: Add SafeStack support for test-suite.

jroelofs added a comment. In http://reviews.llvm.org/D13465#260628, @tharvik wrote: > When running the test suite, it gives a bunch of `undefined reference to > '__safestack_unsafe_stack_ptr'`. > See regression results . Sounds like it's missing the safestack

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

jroelofs added inline comments. Comment at: test/support/noexcept.h:10 @@ +9,3 @@ +//===--===// +#ifdef _LIBCPP_NO_EXCEPTIONS + You should also add a header guard so that this doesn't get

Re: [PATCH] D15338: [Clang] Use autos in lib/AST/ASTContext.cpp

jroelofs added a subscriber: jroelofs. Comment at: lib/AST/ASTContext.cpp:429 @@ -432,2 +428,3 @@ + auto *CFC = new (*this) comments::FullComment(FC->getBlocks(), ThisDeclInfo); return CFC; } return new ... Repository: rL LLVM

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. In http://reviews.llvm.org/D15539#312332, @bcraig wrote: > In http://reviews.llvm.org/D15539#312319, @jroelofs wrote: > > > What does having them be `long double`s give over just multiplying the > > counts by 16 (or however big it is on your platform)? Alignment? > > >

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. In http://reviews.llvm.org/D15539#312336, @jroelofs wrote: > In http://reviews.llvm.org/D15539#312332, @bcraig wrote: > > > In http://reviews.llvm.org/D15539#312319, @jroelofs wrote: > > > > > What does having them be `long double`s give over just multiplying the > > >

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added a comment. What does having them be `long double`s give over just multiplying the counts by 16 (or however big it is on your platform)? Alignment? Seems like it'd be better to start with a prime that's ~16x larger, say 211, than to have that factor of 16 floating around

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added a comment. In http://reviews.llvm.org/D15528#311019, @alexfh wrote: > Jonathan, can you explain what specific use case does this patch address? Why > one severity level of native clang-tidy warnings (the current situation) is > not enough, and two levels are enough? I have

Re: [PATCH] D13796: [libcxx] Use "-stdlib=libc++" when possible instead of '-nodefaultlibs' in the test suite.

jroelofs added inline comments. Comment at: test/libcxx/test/config.py:364 @@ +363,3 @@ +deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and +cxx_abi == 'none' and +not use_llvm_unwinder)

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added a comment. Thanks for the review! I'll rework this a bit early next week. http://reviews.llvm.org/D15528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs added a comment. In http://reviews.llvm.org/D15528#311135, @alexfh wrote: > In http://reviews.llvm.org/D15528#311053, @jroelofs wrote: > > > In http://reviews.llvm.org/D15528#311019, @alexfh wrote: > > > > > Jonathan, can you explain what specific use case does this patch address? > >

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

jroelofs added subscribers: howard.hinnant, jroelofs. jroelofs added a comment. Could these large padding things be related to the fact that the test is used as a performance check for the implementation? That being said, I have no idea who is paying attention to the numbers that come out of

[PATCH] D15528: Teach clang-tidy how to -Werror checks.

jroelofs created this revision. jroelofs added a reviewer: aaron.ballman. jroelofs added a subscriber: cfe-commits. http://reviews.llvm.org/D15528 Files: tools/llvm-project/extra/clang-tidy/ClangTidy.cpp tools/llvm-project/extra/clang-tidy/ClangTidy.h

  1   2   3   >