Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

jordan_rose added a comment. I guess the regular pings didn't work, so it was worth trying the gentle one? Sorry! This seems mostly ready to me, but I still have a few comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:1646-1650 @@ -1644,2 +1645,7 @@

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Let's just go with your simple version that makes the common case better. There are a lot of problems with `throw`, so I wouldn't worry about that right now. (By the way, we don't

Re: [PATCH] D13973: CFG: Delay creating Dtors for CompoundStmts which end in ReturnStmt

jordan_rose added a subscriber: dcoughlin. jordan_rose added a comment. Hm. On the one hand, getting this right seems like a nice property, and even adding another loop wouldn't change the order of growth. On the other hand, not having the extra destructors seems like the same sort of property

Re: [PATCH] D14277: [Analyzer] Make referenced SymbolMetadata live even if its region is dead

jordan_rose added a comment. The intent here was that a metadata symbol represents //metadata about a region.// That means if the region is dead, and the symbol isn't directly referenceable, we won't be able to recreate it. The advantage of `&&` was that checkers didn't have to track when

Re: [PATCH] D13453: Always generate cmake config files

jordan_rose resigned from this revision. jordan_rose edited reviewers, added: beanz; removed: jordan_rose. jordan_rose added a comment. I just get things to build with CMake, and I'm not involved with Clang so much these days. This is more about controlling what gets installed, which should be

Re: [PATCH] D12652: [Static Analyzer] Lambda support.

jordan_rose added a comment. A few comments coming late… Comment at: include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:515-517 @@ -511,1 +514,5 @@ + /// Returns true if lambdas should be inlined. Otherwise a sink node will be + /// generated each time a LambdaExpr is

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

jordan_rose added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h:321 @@ +320,3 @@ +// sink, we assume that a client requesting a transition to a state that is +// the same as the predecessor state has made a mistake. We

Re: [PATCH] D12780: [analyzer] Add generateErrorNode() APIs to CheckerContext

jordan_rose added inline comments. Comment at: lib/StaticAnalyzer/Checkers/FixedAddressChecker.cpp:53 @@ -52,3 +52,3 @@ - if (ExplodedNode *N = C.addTransition()) { + if (ExplodedNode *N = C.generateNonFatalErrorNode()) { if (!BT) zaks.anna wrote: > Can

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

jordan_rose added a comment. Hm, interesting. I'm not sure this is even sufficient, though: what if I have a FieldRegion that's a sub-region of an ElementRegion with a symbolic index? RegionStore does everything by base regions, so we won't ever see that intermediate region with the symbolic

Re: [PATCH] D5102: [analyzer][Bugfix/improvement] Fix for PR16833

jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Thanks for all the changes. This looks good to me! (And good catch for the constant expression case.) http://reviews.llvm.org/D5102

Re: [cfe-commits] r171885 - in /cfe/trunk/www/analyzer: annotations.html available_checks.html dev_cxx.html index.html xcode.html

Thanks, updated these links in r247999. In the future Anna's probably the right person to ping. Jordan > On Sep 17, 2015, at 6:57 , Aaron Ballman wrote: > > Sorry to resurrect an ancient commit, but... > > On Tue, Jan 8, 2013 at 2:29 PM, Jordan Rose

r247999 - [analyzer] Update links to developer.apple.com.

Author: jrose Date: Fri Sep 18 11:12:16 2015 New Revision: 247999 URL: http://llvm.org/viewvc/llvm-project?rev=247999=rev Log: [analyzer] Update links to developer.apple.com. The content at the new links is /also/ a little dated, but that's our (Apple's) problem. Modified:

[PATCH] D21111: Avoid accessing an invalid PresumedLoc

jordan_rose created this revision. jordan_rose added a reviewer: rsmith. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. DiagnosticNoteRenderer asserts trying to emit its "while building module Foo imported from bar.h:5" note when the

Re: [PATCH] D21111: Avoid accessing an invalid PresumedLoc

jordan_rose added a comment. *ping* I'm happy to have someone else review this (or "LGTM" this), but it's so small that I'm not sure who else to ask. I'd rather not just commit it cause it's been a while since I've touched Clang. Repository: rL LLVM http://reviews.llvm.org/D2

r273976 - Avoid accessing an invalid PresumedLoc.

Author: jrose Date: Mon Jun 27 20:02:31 2016 New Revision: 273976 URL: http://llvm.org/viewvc/llvm-project?rev=273976=rev Log: Avoid accessing an invalid PresumedLoc. DiagnosticNoteRenderer asserts trying to emit its "while building module Foo imported from bar.h:5" note when the presumed

Re: [PATCH] D21111: Avoid accessing an invalid PresumedLoc

jordan_rose closed this revision. jordan_rose added a comment. Committed as r273976. Repository: rL LLVM http://reviews.llvm.org/D2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Ah, of course! Thanks for catching this, Akira. Can you add this case to the table in the doc comment for WeakObjectProfileTy? (That's how I convinced myself it was correct.)

r263295 - Fix ObjCMethodDecl::findPropertyDecl for class properties.

Author: jrose Date: Fri Mar 11 15:14:40 2016 New Revision: 263295 URL: http://llvm.org/viewvc/llvm-project?rev=263295=rev Log: Fix ObjCMethodDecl::findPropertyDecl for class properties. This affects code completion and a few other things; hopefully the code completion test is sufficient to

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

looks like the entry > MyClass.prop in the table already covers the case this patch fixed (in the > test case I added, Base is NSBundle and Property is the method “foo”)? > >> On Mar 18, 2016, at 9:55 AM, Jordan Rose via cfe-commits >> <cfe-commits@lists.llvm.org> wrot

Re: [PATCH] D18268: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo

s Jordan. I’ve committed the patch in r263818. >>> >>> I didn’t understand your comment on WeakObjectProfileTy’s table (I’m >>> assuming you are talking about the table in ScopeInfo.h:183). It looks like >>> the entry MyClass.prop in the table already covers

r292571 - [AST Printer] Print attributes on enum constants

Author: jrose Date: Thu Jan 19 21:33:42 2017 New Revision: 292571 URL: http://llvm.org/viewvc/llvm-project?rev=292571=rev Log: [AST Printer] Print attributes on enum constants The AST printer was dropping attributes on enumerators (enum constants). Now it's not. Modified:

[PATCH] D25850: Accept nullability annotations (_Nullable) on array parameters

jordan_rose retitled this revision from "[WIP] Accept nullability annotations (_Nullable) on array parameters" to "Accept nullability annotations (_Nullable) on array parameters". jordan_rose updated the summary for this revision. jordan_rose updated this revision to Diff 75820. jordan_rose

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

jordan_rose added a comment. > `_Nonnull` in this position seems very similar to `static` (which typically > also implies non-nullness). I wasn't actually sure if it was okay to assume this, but the standard does seem pretty clear: > If the keyword `static` also appears within the `[` and `]`

[PATCH] D25850: Accept nullability annotations (_Nullable) on array parameters

jordan_rose marked an inline comment as done. jordan_rose added a comment. Oops. Ignore the API notes file, which is only in Swift's branch of Clang right now. Repository: rL LLVM https://reviews.llvm.org/D25850 ___ cfe-commits mailing list

r286122 - Fix use-of-temporary with StringRef in code coverage

Author: jrose Date: Mon Nov 7 11:28:04 2016 New Revision: 286122 URL: http://llvm.org/viewvc/llvm-project?rev=286122=rev Log: Fix use-of-temporary with StringRef in code coverage The fixed code is basically identical to the same loop below, which might indicate an opportunity for refactoring. I

[PATCH] D26317: Fix use-of-temporary with StringRef in code coverage

jordan_rose closed this revision. jordan_rose added a comment. Committed as r286122. Repository: rL LLVM https://reviews.llvm.org/D26317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

jordan_rose added a comment. It works fine for me, though note the "depends on https://reviews.llvm.org/D25850;. The other patches in the series do seem to have been thrown off by https://reviews.llvm.org/D26226 landing first, though, so I'll update those. Repository: rL LLVM

[PATCH] D26109: Warn when 'assume_nonnull' infers nullability within an array.

jordan_rose added a dependency: D26108: Add -Wnullability-completeness-on-arrays.. jordan_rose added a comment. Depends on https://reviews.llvm.org/D26108 too, for the tests to apply cleanly. Repository: rL LLVM https://reviews.llvm.org/D26109

[PATCH] D26227: Don't require nullability on 'va_list'.

jordan_rose added a dependency: D26108: Add -Wnullability-completeness-on-arrays.. jordan_rose added a comment. Depends on https://reviews.llvm.org/D26108 too (for the tests to apply cleanly). Repository: rL LLVM https://reviews.llvm.org/D26227

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

jordan_rose added a comment. Ah, my apologies, @ahatanak. I was testing against the Swift branch of Clang. Repository: rL LLVM https://reviews.llvm.org/D26108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

jordan_rose added inline comments. Comment at: lib/Sema/SemaType.cpp:3988 // Allow arrays of auto if we are a generic lambda parameter. // i.e. [](auto ()[5]) { return array[0]; }; OK if (AT && D.getContext() != Declarator::LambdaExprParameterContext) {

r286542 - Don't require nullability on 'va_list', even when it's a pointer.

Author: jrose Date: Thu Nov 10 19:29:18 2016 New Revision: 286542 URL: http://llvm.org/viewvc/llvm-project?rev=286542=rev Log: Don't require nullability on 'va_list', even when it's a pointer. Take 3! This should finally fix the Hexagon, PPC, and Windows bots. rdar://problem/25846421 Modified:

r286519 - Accept nullability qualifiers on array parameters.

Author: jrose Date: Thu Nov 10 17:28:17 2016 New Revision: 286519 URL: http://llvm.org/viewvc/llvm-project?rev=286519=rev Log: Accept nullability qualifiers on array parameters. Since array parameters decay to pointers, '_Nullable' and friends should be available for use there as well. This is

[PATCH] D26109: Warn when 'assume_nonnull' infers nullability within an array.

jordan_rose closed this revision. jordan_rose added a comment. Committed as https://reviews.llvm.org/rL286521. Repository: rL LLVM https://reviews.llvm.org/D26109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26227: Don't require nullability on 'va_list'.

jordan_rose closed this revision. jordan_rose added a comment. Committed in https://reviews.llvm.org/rL286522, with a fix-up to make the check for va_lists more conservative in https://reviews.llvm.org/rL286531. Repository: rL LLVM https://reviews.llvm.org/D26227

[PATCH] D26227: Don't require nullability on 'va_list'.

jordan_rose added a comment. One more fix-up in https://reviews.llvm.org/rL286542. Hopefully the last one. Repository: rL LLVM https://reviews.llvm.org/D26227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r286521 - Warn when 'assume_nonnull' infers nullability within an array.

Author: jrose Date: Thu Nov 10 17:28:30 2016 New Revision: 286521 URL: http://llvm.org/viewvc/llvm-project?rev=286521=rev Log: Warn when 'assume_nonnull' infers nullability within an array. ...or within a reference. Both of these add an extra level of indirection that make us less certain that

r286520 - Add -Wnullability-completeness-on-arrays.

Author: jrose Date: Thu Nov 10 17:28:26 2016 New Revision: 286520 URL: http://llvm.org/viewvc/llvm-project?rev=286520=rev Log: Add -Wnullability-completeness-on-arrays. This is an addition to (and sub-warning of) -Wnullability-completeness that warns when an array parameter is missing

r286522 - Don't require nullability on 'va_list'.

Author: jrose Date: Thu Nov 10 17:28:34 2016 New Revision: 286522 URL: http://llvm.org/viewvc/llvm-project?rev=286522=rev Log: Don't require nullability on 'va_list'. There are many non-portable typedefs, but va_list is one that nobody ever thinks of as a pointer or an array. (When's the last

r286531 - Don't require nullability on 'va_list' harder.

Author: jrose Date: Thu Nov 10 18:23:59 2016 New Revision: 286531 URL: http://llvm.org/viewvc/llvm-project?rev=286531=rev Log: Don't require nullability on 'va_list' harder. Platform headers don't always define 'va_list' in terms of Clang's '__builtin_va_list', so in addition to checking for our

r286525 - [Sema] Fix-up for MSVC, which is stricter about template types.

Author: jrose Date: Thu Nov 10 17:41:18 2016 New Revision: 286525 URL: http://llvm.org/viewvc/llvm-project?rev=286525=rev Log: [Sema] Fix-up for MSVC, which is stricter about template types. Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified: cfe/trunk/lib/Sema/SemaType.cpp URL:

[PATCH] D25850: Accept nullability annotations (_Nullable) on array parameters

jordan_rose closed this revision. jordan_rose added a comment. Committed as https://reviews.llvm.org/rL286519. Repository: rL LLVM https://reviews.llvm.org/D25850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

jordan_rose closed this revision. jordan_rose added a comment. Committed as https://reviews.llvm.org/rL286520, with a slight fix-up for MSVC in https://reviews.llvm.org/rL286525. Repository: rL LLVM https://reviews.llvm.org/D26108 ___

[PATCH] D26317: Fix use-of-temporary with StringRef in code coverage

jordan_rose created this revision. jordan_rose added a reviewer: vsk. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. The fixed code is basically identical to the same loop below, which might indicate an opportunity for refactoring. I

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

jordan_rose added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:2493-2499 case Type::Adjusted: - case Type::Decayed: + case Type::Decayed: { // Decayed and adjusted types use the adjusted type in LLVM and DWARF. -return CreateType( -

[PATCH] D25850: [WIP] Accept nullability annotations (_Nullable) on array parameters

jordan_rose created this revision. jordan_rose added reviewers: aprantl, doug.gregor. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. Last year Apple added new qualifiers to pointer types: `_Nullable`, `_Nonnull`, and `_Null_unspecified`.

Re: r285856 - Don't require nullability on template parameters in typedefs.

> On Nov 2, 2016, at 15:48, Richard Smith <rich...@metafoo.co.uk> wrote: > > On Wed, Nov 2, 2016 at 2:34 PM, Jordan Rose via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Nov 2, 2016, at 14:3

[PATCH] D26226: Don't require nullability on template parameters in typedefs.

jordan_rose closed this revision. jordan_rose added a comment. Committed in r285856. Repository: rL LLVM https://reviews.llvm.org/D26226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r285856 - Don't require nullability on template parameters in typedefs.

Author: jrose Date: Wed Nov 2 15:44:07 2016 New Revision: 285856 URL: http://llvm.org/viewvc/llvm-project?rev=285856=rev Log: Don't require nullability on template parameters in typedefs. Previously the following code would warn on the use of "T": template struct X { typedef T *type;

Re: r285856 - Don't require nullability on template parameters in typedefs.

> On Nov 2, 2016, at 16:20, Richard Smith <rich...@metafoo.co.uk> wrote: > > On Wed, Nov 2, 2016 at 3:51 PM, Jordan Rose via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Nov 2, 2016, at 15:4

Re: r285856 - Don't require nullability on template parameters in typedefs.

> On Nov 2, 2016, at 14:31, Richard Smith <rich...@metafoo.co.uk> wrote: > > On 2 Nov 2016 1:53 pm, "Jordan Rose via cfe-commits" > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > Author: jrose > Date: Wed Nov 2 15:44

[PATCH] D26226: Don't require nullability on template parameters in typedefs.

jordan_rose created this revision. jordan_rose added reviewers: doug.gregor, rsmith. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. Previously the following code would warn on the use of `T`: template struct X { typedef T *type;

[PATCH] D26227: Don't require nullability on 'va_list'.

jordan_rose created this revision. jordan_rose added reviewers: doug.gregor, rsmith. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. jordan_rose added dependencies: D26226: Don't require nullability on template parameters in typedefs.,

[PATCH] D25993: [Objective-C] Add objc_subclassing_restricted attribute

jordan_rose added a comment. Looks good from my end. Repository: rL LLVM https://reviews.llvm.org/D25993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26108: Add -Wnullability-completeness-on-arrays.

jordan_rose created this revision. jordan_rose added a reviewer: doug.gregor. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. jordan_rose added a dependency: D25850: Accept nullability annotations (_Nullable) on array parameters. This is

[PATCH] D26109: Warn when 'assume_nonnull' infers nullability within an array.

jordan_rose created this revision. jordan_rose added a reviewer: doug.gregor. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. jordan_rose added a dependency: D25850: Accept nullability annotations (_Nullable) on array parameters. ...or

r290132 - Add fix-it notes to the nullability consistency warning.

Author: jrose Date: Mon Dec 19 14:58:20 2016 New Revision: 290132 URL: http://llvm.org/viewvc/llvm-project?rev=290132=rev Log: Add fix-it notes to the nullability consistency warning. This is especially important for arrays, since no one knows the proper syntax for putting qualifiers in arrays.

r290141 - Don't try to emit nullability fix-its within/around macros.

Author: jrose Date: Mon Dec 19 16:35:24 2016 New Revision: 290141 URL: http://llvm.org/viewvc/llvm-project?rev=290141=rev Log: Don't try to emit nullability fix-its within/around macros. The newly-added notes from r290132 are too noisy even when the fix-it is valid. For the existing warning from

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

Hi, Richard. Swift was using this information in order to put imported macros in a particular context. It wouldn't surprise me to hear that we were doing it wrong, and that there's a better way to go from a macro back to a module, but is there a recommended replacement? Thanks, Jordan > On

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

Thanks, this is helpful! > On May 16, 2017, at 12:26, Richard Smith <rich...@metafoo.co.uk> wrote: > > On 15 May 2017 at 10:28, Jordan Rose via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > Hi, Richard. Swift was using

r316408 - Unnamed bitfields don't block constant evaluation of constexpr ctors

Author: jrose Date: Mon Oct 23 19:17:07 2017 New Revision: 316408 URL: http://llvm.org/viewvc/llvm-project?rev=316408=rev Log: Unnamed bitfields don't block constant evaluation of constexpr ctors C++14 [dcl.constexpr]p4 states that in the body of a constexpr constructor, > every non-variant

r330452 - Record whether a module came from a private module map

Author: jrose Date: Fri Apr 20 10:16:04 2018 New Revision: 330452 URL: http://llvm.org/viewvc/llvm-project?rev=330452=rev Log: Record whether a module came from a private module map Right now we only use this information in one place, immediately after we calculate it, but it's still nice

r328276 - Sink PrettyDeclStackTrace down to the AST library

Author: jrose Date: Thu Mar 22 17:07:18 2018 New Revision: 328276 URL: http://llvm.org/viewvc/llvm-project?rev=328276=rev Log: Sink PrettyDeclStackTrace down to the AST library ...and add some very basic stack trace entries for module building. This would have helped track down

r328286 - Remove problematic PrettyStackTrace entry added in r328276

Author: jrose Date: Thu Mar 22 18:12:09 2018 New Revision: 328286 URL: http://llvm.org/viewvc/llvm-project?rev=328286=rev Log: Remove problematic PrettyStackTrace entry added in r328276 I'm not sure /why/ this is causing issues for libclang, but it is. Unbreak the buildbots since it's already

[clang-tools-extra] r328354 - Fix misuse of llvm::YAML in clangd test.

Author: jrose Date: Fri Mar 23 12:16:07 2018 New Revision: 328354 URL: http://llvm.org/viewvc/llvm-project?rev=328354=rev Log: Fix misuse of llvm::YAML in clangd test. Caught by LLVM r328345! Modified: clang-tools-extra/trunk/unittests/clangd/TraceTests.cpp Modified:

[clang-tools-extra] r374494 - Get ClangdXPC.framework building (barely) with CMake's Xcode generator

Author: jrose Date: Thu Oct 10 18:23:56 2019 New Revision: 374494 URL: http://llvm.org/viewvc/llvm-project?rev=374494=rev Log: Get ClangdXPC.framework building (barely) with CMake's Xcode generator The output directories for CMake's Xcode project generator are specific to the configuration, and

r373769 - [CMake] Clang: Don't use object libraries with Xcode

Author: jrose Date: Fri Oct 4 11:17:58 2019 New Revision: 373769 URL: http://llvm.org/viewvc/llvm-project?rev=373769=rev Log: [CMake] Clang: Don't use object libraries with Xcode Undoes some of the effects of r360946 when using the Xcode CMake generator---it doesn't handle object libraries