[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo added a comment. @PiotrZSL @carlosgalvezp can you please recheck? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo updated this revision to Diff 553062. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo added a comment. thanks for the review. can you please land it for me pls? Jorge Pinto Sousa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

sousajo added a comment. hey :( I will try to investigate it a bit sometime next week ^^ thanks for pointing it out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

sousajo added a comment. In D148276#4288236 , @aaron.ballman wrote: > In D148276#4288145 , @sousajo wrote: > >> hey :( I will try to investigate it a bit sometime next week ^^ thanks for >> pointing it out > >

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo created this revision. sousajo added a reviewer: MyDeveloperDay. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan. sousajo requested review of this revision. Fixes:

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513946. sousajo added a comment. - inline string to be checked CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513945. sousajo added a comment. - removed `FormatStyle Style = getLLVMStyle();` as llvm is the default style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files:

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo added a comment. As I dont have commit access if someone can land It for me: Jorge Pinto Sousa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 ___ cfe-commits mailing list

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo updated this revision to Diff 513969. sousajo added a comment. - rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D148437: [clang-format] Dont interpret variable named interface as keyword for C++

sousajo added a comment. cannot reproduce the build failure locally. if this looks fine can someone land it for me? or should we wait until we have a green build after rebase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148437/new/ https://reviews.llvm.org/D148437

[PATCH] D148354: [clang-tidy] Remove reference to Visual studio native plugin

sousajo created this revision. sousajo added a reviewer: PiotrZSL. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. sousajo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D148354: [clang-tidy][NFC] Remove reference to Visual studio native plugin

sousajo added a comment. In D148354#4269013 , @PiotrZSL wrote: > I see you uploaded this path without author attached, should I push this as > "Jorge Pinto Sousa " ? Yes please do thanks :) CHANGES SINCE LAST ACTION

[PATCH] D147874: [clang-tidy] Fix AST Library documentation link

sousajo added a comment. I dont have commit access, can someone land it for me? Name: Jorge Pinto Sousa Email: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147874/new/ https://reviews.llvm.org/D147874 ___ cfe-commits mailing list

[PATCH] D147874: [clang-tidy] Fix AST Library documentation link

sousajo created this revision. sousajo added reviewers: LegalizeAdulthood, vtjnash. Herald added subscribers: PiotrZSL, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. sousajo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

sousajo updated this revision to Diff 536622. sousajo added a comment. Thanks ^^ added the release note. Can someone please land it for me? Jorge Pinto Sousa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154297/new/ https://reviews.llvm.org/D154297 Files:

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

sousajo added a comment. while landing it, if someone feels that the release work can be reworded please feel free to do so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154297/new/ https://reviews.llvm.org/D154297 ___ cfe-commits mailing

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, arphaman, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. sousajo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo added a comment. In D156624#4545107 , @PiotrZSL wrote: > Good, just verify that documentation for this check is still proper, and add > entry in release notes about this change. I missed those, I will sure ^^ In D156624#4545117

[PATCH] D156624: [clang-tidy] Access checks not done classes derived of std::array

sousajo added a comment. hi @PiotrZSL, thanks for the review :) can you please land it for me? Jorge Pinto Sousa CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156624/new/ https://reviews.llvm.org/D156624 ___ cfe-commits mailing list

[PATCH] D154297: clang-tidy: accessing checks not done for aliases of `std::array`

sousajo created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, jeroen.dobbelaere, arphaman, kbarton, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. sousajo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D148276: [clang] trigger -Wcast-qual on functional casts

sousajo added a comment. have been sick, and could not advance much except I added the tests to replicate the issue. Any ideas on how to proceed here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148276/new/ https://reviews.llvm.org/D148276