[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 367739. jozefl added a comment. Here's an updated patch that stores the HWMult and CPU data for each MCU as strings instead of enums. This simplifies the patch as string conversions to and from enums are no longer required. Repository: rG LLVM Github

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl created this revision. jozefl added a reviewer: asl. jozefl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch updates MSP430 MCU data to the latest version distributed by TI, adding support for 451 additional MCUs. The

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

jozefl created this revision. jozefl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The -mmcu= option accepts a generic MCU named "msp430", which sets the CPU to msp430 and disables hardware multiply support. The current purpose of

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 367805. jozefl added a comment. Here's an updated patch to fix the win64 failure. MSVC can't handle the conversion from a ForwardIterator to a const pointer when the container being searched with std::lower_bound is a std::array. Meanwhile clang-tidy warns

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 368348. jozefl added a comment. Here's an updated patch that fixes some minor nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 Files:

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108299/new/ https://reviews.llvm.org/D108299 ___ cfe-commits mailing list

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 367458. jozefl added a comment. Fixed clang-tidy warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 Files: clang/include/clang/Basic/MSP430Target.def

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Now that I am in the process of implementing the processing of the "CPU" feature, I've realized the decision to store the CPU and HWMult information as enums instead of strings has some downsides that may outweigh the benefits: - All string values passed to options need

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl created this revision. jozefl added reviewers: asl, atrosinenko. Herald added a subscriber: hiraditya. jozefl requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. clang::driver::tools::getCPUName can now infer the CPU

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 370370. jozefl added a comment. Updated patch to use hasFeature() to check for msp430x support, instead of a new function. Fixed use of tools::getCPUName() after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 370350. jozefl added a comment. Rebased onto current upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 Files:

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 370507. jozefl added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 ___ cfe-commits mailing list

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list

[PATCH] D108299: [MSP430][Clang] Remove support for -mmcu=msp430

jozefl added a comment. Pinging for review. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108299/new/ https://reviews.llvm.org/D108299 ___ cfe-commits mailing list

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 370495. jozefl added a comment. Fix the msp430-toolchain.c test by adding some more Windows path separators to the match patterns. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 379011. jozefl added a comment. Rebase onto new base revision to fix pre-merge tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 Files:

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 379034. jozefl added a comment. Rebase onto new base revision to fix pre-merge tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 Files:

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 375666. jozefl marked 5 inline comments as done. jozefl added a comment. Thanks, good points, I have addressed them in this updated patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 375811. jozefl added a comment. Rebase after updates to parent revision D108301 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 374200. jozefl added a comment. Herald added subscribers: llvm-commits, ormris, hiraditya. Herald added a project: LLVM. Rebase to fix patch application failure for clang/test/Misc/target-invalid-cpu-note.c. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl updated this revision to Diff 374257. jozefl added a comment. Rebase to fix patch application failure for clang/test/Misc/target-invalid-cpu-note.c. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 374255. jozefl added a comment. Undo incorrect rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 Files: clang/include/clang/Basic/MSP430Target.def

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl updated this revision to Diff 392071. jozefl marked an inline comment as done. jozefl added a comment. Thanks, good point, fixed in the attached patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108301/new/ https://reviews.llvm.org/D108301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109174: [MSP430][Clang] Infer CPU type from -mcpu= or -mmcu=

jozefl added a comment. Ping. Thanks, Jozef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109174/new/ https://reviews.llvm.org/D109174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org