flowerhack wrote:
Opened this PR in error, sorry!
https://github.com/llvm/llvm-project/pull/152970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/flowerhack created
https://github.com/llvm/llvm-project/pull/152970
See documentation for purpose and further details.
>From d1e7774b62a71da39f050ddb256322245481eb42 Mon Sep 17 00:00:00 2001
From: Julia Hansbrough
Date: Sat, 2 Aug 2025 01:33:09 +
Subject: [PATCH] [clang-
https://github.com/flowerhack closed
https://github.com/llvm/llvm-project/pull/152970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/flowerhack updated
https://github.com/llvm/llvm-project/pull/157213
>From 84a477b27da2e833b6c4da2db7b2a10f00df8b6a Mon Sep 17 00:00:00 2001
From: Julia Hansbrough
Date: Fri, 5 Sep 2025 21:27:14 +
Subject: [PATCH] Add bugprone-loop-variable-copied-then-modified clang-tidy
flowerhack wrote:
Also, any chance I could get approval on the "build & test linux" + "build &
test windows" workflows (or is there something I need to do to get those
approved)? I've tested on my machine but would like to know things check out
against CI as well. Thanks!
https://github.com
@@ -0,0 +1,48 @@
+.. title:: clang-tidy - bugprone-loop-variable-copied-then-modified
+
+bugprone-loop-variable-copied-then-modified
+===
+
+Detects when a loop variable is copied and then subsequently modified and
+suggests replacing with a
https://github.com/flowerhack updated
https://github.com/llvm/llvm-project/pull/157213
>From 3d67815b44a3a9e9a521174c90b7bb9822a41ab2 Mon Sep 17 00:00:00 2001
From: Julia Hansbrough
Date: Fri, 5 Sep 2025 21:27:14 +
Subject: [PATCH] Add bugprone-loop-variable-copied-then-modified clang-tidy
https://github.com/flowerhack updated
https://github.com/llvm/llvm-project/pull/157213
>From ce57f8591dad2dae6812cd783c396b11da968152 Mon Sep 17 00:00:00 2001
From: Julia Hansbrough
Date: Fri, 5 Sep 2025 21:27:14 +
Subject: [PATCH] Add bugprone-loop-variable-copied-then-modified clang-tidy
flowerhack wrote:
Thanks for the feedback; I believe I've addressed all comments, save one
comment from @zwuis which I requested clarification on. Let me know if there's
anything else.
https://github.com/llvm/llvm-project/pull/157213
___
cfe-commits
https://github.com/flowerhack updated
https://github.com/llvm/llvm-project/pull/157213
>From af802c141faa33b1e743e9fb8710c96822d6e472 Mon Sep 17 00:00:00 2001
From: Julia Hansbrough
Date: Fri, 5 Sep 2025 21:27:14 +
Subject: [PATCH] Add bugprone-loop-variable-copied-then-modified clang-tidy
@@ -0,0 +1,100 @@
+
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: A
https://github.com/flowerhack closed
https://github.com/llvm/llvm-project/pull/155731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
flowerhack wrote:
Implementing this as a separate check rather than attacking it to
`performance-for-range-copy` sounds fine to me.
I'll go ahead and close this PR out. I've created an issue at
https://github.com/llvm/llvm-project/issues/155922 where I offer more
evidence/rationale for why t
https://github.com/flowerhack created
https://github.com/llvm/llvm-project/pull/155731
…opy.
Adds an option to performance-for-range-copy that alerts when a loop variable
is copied and modified.
This is a bugprone pattern because the programmer in this case often assumes
they are modifying t
flowerhack wrote:
@nicovank : Thanks for the thoughtful and detailed comments & review. Replying
to your toplevel comment here:
> Suggesting const when the variable is modified in the loop always produces
> invalid code (this is the case for the highlighted example in the
> documentation): s
15 matches
Mail list logo
