[PATCH] D61865: [clangd] improve help message for limit-results

kadircet added a comment. I can land it for you, you can learn more about commit access from https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61865/new/

[PATCH] D62238: [CodeComplete] Complete a lambda when preferred type is a function

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:4142 + // Handle other cases. + if (T->isPointerType()) +T

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

kadircet added inline comments. Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:48 + return llvm::None; +} else { + DirectoryWatcher::Event Front = Events.front(); nit: get rid of the else Comment at:

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. Clangd is already resolving symlinks on the server side, therefore there is no more need to handle it in client side. This

[PATCH] D62298: [CodeComplete] Filter override completions by function name

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3154 +/// The result contains only 'typed text' and 'text' chunks. +static void PrintOverrideString(const CodeCompletionString , +CodeCompletionBuilder ) {

[PATCH] D62303: [Index] Fix reported references in presence of template type aliases

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/lib/Index/IndexTypeSourceInfo.cpp:140 + bool IsTypeAlias) { +if (ResolvedClass) { + //

[PATCH] D62298: [CodeComplete] Filter override completions by function name

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Have one question though, does it improve behavior in vscode? Since label seems to be the same, it will most definitely improve clangd's ranking but vscode ignores it anyway.

[PATCH] D62298: [CodeComplete] Filter override completions by function name

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3172 +// Add a space after return type. +if (Chunk.Kind == CodeCompletionString::CK_ResultType) { + assert(!SeenTypedChunk); ilya-biryukov wrote: > kadircet wrote: > >

[PATCH] D62372: [clangd] Limit the size of synthesized fix message

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/Diagnostics.cpp:449 + + size_t FirstNewline = R.find('\n'); + if (FirstNewline != llvm::StringRef::npos)

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361475: [clangd-vscode] Do not customize uri converters in vscode (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D62288?vs=200909=200913#toc Repository:

[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

kadircet updated this revision to Diff 200909. kadircet marked an inline comment as done. kadircet added a comment. - Delete unusued import Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62288/new/ https://reviews.llvm.org/D62288 Files:

[PATCH] D62135: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clangd/CodeComplete.h:128 +/// Always use text-based completion. +NeverParse, + } RunParser = ParseIfReady; Do we really have

[PATCH] D61865: [clangd] improve help message for limit-results

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61865/new/ https://reviews.llvm.org/D61865

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

kadircet added inline comments. Comment at: clang/test/CodeCompletion/enum-preferred-type.cpp:19 + // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:12:16 %s -o - | FileCheck %s + // RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:12:21 %s -o - | FileCheck %s +

[PATCH] D62010: [CodeComplete] Complete enumerators when preferred type is an enum

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/CodeCompletion/enum-preferred-type.cpp:13 + if (color == N::Color::Red) {} + + // RUN: %clang_cc1 -fsyntax-only

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

This revision was automatically updated to reflect the committed changes. Closed by commit rL359432: [clangd] Surface diagnostics from headers inside main file (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 197077. kadircet added a comment. - Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files: clangd/Diagnostics.cpp clangd/Diagnostics.h

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 197068. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files:

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 197073. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files:

[PATCH] D61316: [clangd] Improvements to header mapping: more precise parsing of cppreference symbol pages.

kadircet added inline comments. Comment at: clangd/include-mapping/gen_std.py:90 +# Decl may not be for the symbol name we're looking for. +if not re.search("\\b%s\\b" % symbol_name, text): + continue does this also work with functions?

[PATCH] D61316: [clangd] Improvements to header mapping: more precise parsing of cppreference symbol pages.

kadircet added inline comments. Comment at: clangd/include-mapping/gen_std.py:60 + +def ParseSymbolPage(symbol_page_html, symbol_name): """Parse symbol page and retrieve the include header defined in this page. I think this requires some corresponding changes

[PATCH] D61316: [clangd] Improvements to header mapping: more precise parsing of cppreference symbol pages.

kadircet added inline comments. Comment at: clangd/include-mapping/gen_std.py:95 +if was_decl: + current_headers = [] +was_decl = False kadircet wrote: > why not perform clean-up unconditionally? ok I see the reason for that one,

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet updated this revision to Diff 197288. kadircet added a comment. - Change logic to count references from only main files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59481/new/ https://reviews.llvm.org/D59481 Files:

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet added a comment. I think it makes more sense to expose semantical information in HoverInfo(like Name, Scope, Definition, etc), rather than formatted strings, and let this be serialized by the users of ClangdServer (as in D61497 ). This is what I'll

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198420. kadircet marked an inline comment as done. kadircet added a comment. - Add comments for non-type params Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497 Files:

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:73 + llvm::Optional> Parameters; + llvm::Optional> TemplateParameters; + ilya-biryukov wrote: > What does `Type` mean for non-type and

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet added a comment. > I'm happy to restructure the `HoverInfo` to your liking if the current one > seems problematic for any reason. It will just cause more code move on my side, no problems apart from that Comment at: clang-tools-extra/clangd/Protocol.cpp:707 + else

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198457. kadircet marked 2 inline comments as done. kadircet added a comment. I will start adding test cases(and most likely change the way I populate the struct at some places) if everyone is happy with current representation for `HoverInfo`. Repository:

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:57 +// template class. +Type T; +std::string Name; ilya-biryukov wrote: > Same about type template parameters. > Probably just holds `class` or `typename`? Exactly, adding

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov. Herald added a project: clang. Include insertion in clangd was inserting absolute paths when the include directory was an absolute path with a

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet added a comment. We already have `CodeCompletion::Origin` which is (at least should be)set to `Identifier` in those cases. Is there a reason for not using it? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/

[PATCH] D61588: [clangd] Expose whether no-compile completion was used.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks for the info. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61588/new/ https://reviews.llvm.org/D61588

[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/ClangdServer.cpp:264 Callback> CB) { - auto Action = [Pos](Path File, std::string NewName, + auto Action =

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198295. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497 Files:

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:52 +struct HoverInfo { + LocatedSymbol Sym; + /// Name of the context containing the symbol. sammccall wrote: > I'm not sure about reuse of LocatedSymbol - do we want to commit to

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:186 void findHover(PathRef File, Position Pos, - Callback> CB); + Callback> CB); sammccall wrote: > Not sure about switching from `Hover` to

[PATCH] D61442: [clangd] Fix header-guard check for include insertion, and don't index header guards.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! mostly LGTM, only confused about changing symbolcollector to produce a unique header per symbol(where as it was(could) produce multiple headers before). What is the rationale

[PATCH] D61442: [clangd] Fix header-guard check for include insertion, and don't index header guards.

kadircet added inline comments. Comment at: clangd/index/SymbolCollector.h:130 + // The final spelling is calculated in finish(). + llvm::DenseMap IncludeFiles; + // Indexed macros, to be erased if they turned out to be include guards. sammccall wrote: >

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Change ClangdServer layer to output a structured response for Hover, which can be rendered by client according to

[PATCH] D61349: [clangd] Standard library mapping: prefer "primary" versions of functions over variants.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LG Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61349/new/ https://reviews.llvm.org/D61349

[PATCH] D61316: [clangd] Improvements to header mapping: more precise parsing of cppreference symbol pages.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61316/new/ https://reviews.llvm.org/D61316

[PATCH] D61126: [clangd] Also perform merging for symbol definitions

kadircet updated this revision to Diff 197725. kadircet added a comment. - Update diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61126/new/ https://reviews.llvm.org/D61126 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D61126: [clangd] Also perform merging for symbol definitions

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rL359874: [clangd] Also perform merging for symbol definitions (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet planned changes to this revision. kadircet added a comment. This is still WIP, just looking for feedbacks on `HoverInfo` struct and overall layering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497

[PATCH] D61519: [clangd] Support -fallback-style, similar to clang-format.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Putting http://lists.llvm.org/pipermail/clangd-dev/2019-May/000411.html here for context. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198630. kadircet marked 23 inline comments as done. kadircet added a comment. - Address comments - Make little modifications to existing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:574 - // We want to include the template in the Hover. - if (TemplateDecl *TD = D->getDescribedTemplate()) -D = TD; +llvm::raw_ostream <<(llvm::raw_ostream , +

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet marked 6 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:539 -/// Generate a \p Hover object given the declaration \p D. -static Hover getHoverContents(const Decl *D) { - Hover H; - llvm::Optional NamedScope =

[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

kadircet added a comment. Could you also revert changes in `LSPDiagnosticCompare` in `Protocol.h`, that were introduced by rL363889 ? (or bring back `fixits-duplication.test`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rL365005: [clang][HeaderSearch] Shorten paths for includes in mainfiles directory (authored by kadircet, committed by ). Herald added subscribers: llvm-commits,

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet updated this revision to Diff 207721. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64018/new/ https://reviews.llvm.org/D64018 Files:

[PATCH] D64133: [clangd] Add HadErrors field into shards

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64133 Files:

[PATCH] D64133: [clangd] Add HadErrors field into shards

kadircet updated this revision to Diff 207793. kadircet added a comment. - Delete leftover header swap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64133/new/ https://reviews.llvm.org/D64133 Files: clang-tools-extra/clangd/Headers.h

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This also turns off implicit discovery of additional compilation databases. Repository: rG LLVM Github

[PATCH] D64196: [clangd] Query driver reads stderr and passes driver as first argument

This revision was automatically updated to reflect the committed changes. Closed by commit rL365132: [clangd] Query driver reads stderr and passes driver as first argument (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D63330: [clangd] Add Value field to HoverInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rL364390: [clangd] Add Value field to HoverInfo (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:54 + +// RAV subclass to find all DeclRefs in a given Stmt +class FindDeclRefsVisitor I believe this class is rather used to check if any decl referenced in

[PATCH] D63760: [clangd] Address limitations in SelectionTree:

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clangd/Selection.cpp:45 + if (R.first > Begin) +return false; // [R.First, Begin) is not covered. + if (Begin < R.second)

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64489 Files:

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

This revision was automatically updated to reflect the committed changes. Closed by commit rL365634: [clangd] Filter out non-governed files from broadcast (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

This revision was automatically updated to reflect the committed changes. Closed by commit rL365776: [clangd][QueryDriver] Use language from underlying database if possible (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:252 -llvm::Optional toHalfOpenFileRange(const SourceManager , +// FIXME: Here we check whether the token at the location is a greatergreater +// (>>) token and consider it as a single greater

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:121 // Should we also preserve flags like "-sysroot", "-nostdinc" ? - const llvm::StringRef Args[] = { - Driver, "-E", "-x",

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1238 Optional Result = - getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet); + getTypeAncestors(*CXXRD, AST.getASTContext(), RPSet, ResolveParents); if (!Result)

[PATCH] D64391: [CodeComplete] an option to suppress endings for header completion

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1088 + + if (Trigger == "/") { // trigger only on '#include.../' +auto StartOfLine = Code->rfind('\n', *Offset); i think instead of regex, it would be better to just

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet updated this revision to Diff 208686. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64247/new/ https://reviews.llvm.org/D64247 Files:

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:653 +auto PI = CDB.getProjectInfo(File); +assert(PI && "Found CDB but no ProjectInfo!"); + sammccall wrote: > This looks like a bad assertion: it should be OK to

[PATCH] D64247: [clangd] Filter out non-governed files from broadcast

kadircet updated this revision to Diff 208697. kadircet added a comment. - Rearrange changes to get a better diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64247/new/ https://reviews.llvm.org/D64247 Files:

[PATCH] D64133: [clangd] Add HadErrors field into shards

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:65 struct IncludeGraphNode { - // True if current file is a main file rather than a header. - bool IsTU = false; + enum class SourceFlag : uint8_t { +

[PATCH] D64147: [clangd] Make HadErrors part of background index's internal state

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64147 Files:

[PATCH] D64133: [clangd] Add HadErrors field into shards

kadircet updated this revision to Diff 207832. kadircet added a comment. - Populate HadErrors in background index Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64133/new/ https://reviews.llvm.org/D64133 Files: clang-tools-extra/clangd/Headers.h

[PATCH] D64019: [clangd] Turn background-index on by default

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:191 "Index project code in the background and persist index on disk. " "Experimental"), +llvm::cl::init(true));

[PATCH] D64196: [clangd] Query driver reads stderr and passes driver as first argument

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. gcc invokes cc1 through a path deduced from argv[0] therefore it must be correctly set. Also it prints the search

[PATCH] D64147: [clangd] Make HadErrors part of background index's internal state

kadircet updated this revision to Diff 207986. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64147/new/ https://reviews.llvm.org/D64147 Files:

[PATCH] D64133: [clangd] Add HadErrors field into shards

This revision was automatically updated to reflect the committed changes. Closed by commit rL365122: [clangd] Add HadErrors field into shards (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64018: [clangd] Store hash of command line in index shards.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365121: [clangd] Store hash of command line in index shards. (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63986: [clangd] Also cache failures while indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rL365120: [clangd] Also cache failures while indexing (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64147: [clangd] Make HadErrors part of background index's internal state

This revision was automatically updated to reflect the committed changes. Closed by commit rL365123: [clangd] Make HadErrors part of background indexs internal state (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64019: [clangd] Turn background-index on by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL365124: [clangd] Turn background-index on by default (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63295/new/ https://reviews.llvm.org/D63295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63931: [clangd] Make PreambleStatusCache handle filenames more carefully

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63931/new/ https://reviews.llvm.org/D63931

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd currently doesn't cache any indexing failures, which results in retrying those failed files even if their

[PATCH] D63773: [clangd] dummy variable extraction on a function scope

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:34 +// class to store information about the Expr that is being extracted +class Extract { +public: most of the methods seem to be taking a SM, why not make

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet updated this revision to Diff 207296. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63986/new/ https://reviews.llvm.org/D63986 Files:

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

kadircet updated this revision to Diff 207308. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments. - Use TUs path as a fallback, rather than a search path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet updated this revision to Diff 207316. kadircet marked 5 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63986/new/ https://reviews.llvm.org/D63986 Files:

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:161 CI.getDiagnostics().hasUncompilableErrorOccurred()) { llvm::errs() << "Skipping TU due to uncompilable errors\n"; +} else { sammccall wrote: > I'm

[PATCH] D63295: [clang][HeaderSearch] Shorten paths for includes in mainfile's directory

kadircet updated this revision to Diff 207312. kadircet added a comment. - Add comments to the CheckDir lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63295/new/ https://reviews.llvm.org/D63295 Files:

[PATCH] D63986: [clangd] Also cache failures while indexing

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:313 +// we don't even know what absolute path they should fall in. +if (HadErrors && !IGN.IsTU) + continue; sammccall wrote: > Maybe add a FIXME that we should

[PATCH] D64019: [clangd] Turn background-index on by default

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64019 Files:

[PATCH] D64018: [clangd] Store hash of command line in index shards.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is to enable cache invalidation when command line flags changes. Repository: rG LLVM Github Monorepo

[PATCH] D64712: [clangd] Refactor background-index shard loading

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64712 Files:

[PATCH] D60995: [clangd] Make sure include path does not contain any backslashes on Windows

kadircet added a comment. I had just looked at the method name and thought it was the right place( `suggestPathToFileForDiagnostics` since it says "path to file".) But looking at the comments, /// Suggest a path by which the specified file could be found, for /// use in diagnostics to

[PATCH] D60995: [clangd] Make sure include path does not contain any backslashes on Windows

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a child revision: D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute

[PATCH] D60873: [clang][HeaderSuggestion] Handle the case of dotdot with an absolute path

kadircet added a comment. Sent out D60995 , hopefully it should fix the issue. Will wait until that lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60873/new/ https://reviews.llvm.org/D60873

[PATCH] D60995: [clang][HeaderSearch] Make sure there are no backslashes in suggestedPath

kadircet updated this revision to Diff 196192. kadircet added a comment. - Fix bug in HeaderSearch instead of clangd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60995/new/ https://reviews.llvm.org/D60995 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 194528. kadircet marked 10 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files:

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet added inline comments. Comment at: clangd/Diagnostics.cpp:396 + for (llvm::StringRef Inc : IncludeStack) +OS << "In file included from: " << Inc << ":\n"; +} ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: >

[PATCH] D60323: [clangd] Include compile command inference in fileStatus API

kadircet added a comment. What about surfacing compile command itself as well? IMO, it is an important information that we always extract from logs by digging currently. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60323/new/

[PATCH] D61077: [clangd] Query index in code completion no-compile mode.

kadircet added inline comments. Comment at: clangd/SourceCode.cpp:503 +case tok::l_brace: + if (State == NamespaceName) { +// Parsed: namespace { I believe it is safe to ignore(just mark the opening brace) anonymous namespaces here. Since

<    3   4   5   6   7   8   9   10   11   12   >