[PATCH] D49012: [clangd] Uprank delcarations when "using q::name" is present in the main file

omtcyfz updated this revision to Diff 154377. omtcyfz added a comment. Remove comments from TestTU.cpp, both functions are properly documented in the corresponding header. https://reviews.llvm.org/D49012 Files: clang-tools-extra/clangd/Quality.cpp clang-tools-extra/unittests/clangd/Quality

[PATCH] D49012: [clangd] Uprank delcarations when "using q::name" is present in the main file

omtcyfz updated this revision to Diff 154379. omtcyfz added a comment. Add const qualifier to UsingShadowDecl in unit tests. https://reviews.llvm.org/D49012 Files: clang-tools-extra/clangd/Quality.cpp clang-tools-extra/unittests/clangd/QualityTests.cpp clang/include/clang/Sema/CodeComplet

[PATCH] D49012: [clangd] Uprank delcarations when "using q::name" is present in the main file

omtcyfz updated this revision to Diff 154383. omtcyfz marked 10 inline comments as done. omtcyfz added a comment. Address the comments, add a couple of FIXMEs for the future. https://reviews.llvm.org/D49012 Files: clang-tools-extra/clangd/Quality.cpp clang-tools-extra/unittests/clangd/Quali

[PATCH] D49012: [clangd] Uprank delcarations when "using q::name" is present in the main file

omtcyfz updated this revision to Diff 154956. omtcyfz marked 3 inline comments as done. omtcyfz added a comment. Address few comments, add test for macro definition, slightly reformat `QualityTests.cpp` https://reviews.llvm.org/D49012 Files: clang-tools-extra/clangd/Quality.cpp clang-tools

[PATCH] D49012: [clangd] Uprank delcarations when "using q::name" is present in the main file

omtcyfz updated this revision to Diff 154969. omtcyfz added a comment. Slightly refactor code by making lambda only used once anonymous. https://reviews.llvm.org/D49012 Files: clang-tools-extra/clangd/Quality.cpp clang-tools-extra/unittests/clangd/QualityTests.cpp clang/include/clang/Sema

[PATCH] D49012: [clangd] Uprank delcarations when "using q::name" is present in the main file

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE336810: [clangd] Uprank delcarations when "using q::name" is present in the main file (authored by omtcyfz, committed by ). Changed prior to commit: https://reviews.llvm.org/D49012?vs=154969&id=155001

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

omtcyfz created this revision. omtcyfz added a reviewer: ioeric. omtcyfz added a project: clang-tools-extra. Herald added subscribers: jkorous, MaskRay, mgorny. This patch introduces trigram generation algorithm for the symbol index proposed in a recent design document. RFC in the mailing list:

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

omtcyfz updated this revision to Diff 155824. omtcyfz added a comment. Fix documentation indentation in SearchAtom description. https://reviews.llvm.org/D49417 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/noctem/SearchAtom.cpp clang-tools-extra/clangd/inde

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

omtcyfz updated this revision to Diff 155828. https://reviews.llvm.org/D49417 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/noctem/SearchAtom.cpp clang-tools-extra/clangd/index/noctem/SearchAtom.h clang-tools-extra/unittests/clangd/CMakeLists.txt clang-to

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

omtcyfz updated this revision to Diff 155827. omtcyfz added a comment. Wipe redundant FIXMEs. https://reviews.llvm.org/D49417 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/noctem/SearchAtom.cpp clang-tools-extra/clangd/index/noctem/SearchAtom.h clang-tool

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

omtcyfz updated this revision to Diff 155830. omtcyfz added a comment. Fix unittest file name in header. https://reviews.llvm.org/D49417 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/index/noctem/SearchAtom.cpp clang-tools-extra/clangd/index/noctem/SearchAtom.h

[PATCH] D49417: [clangd] Implement trigram generation algorithm for new symbol index

omtcyfz updated this revision to Diff 156073. omtcyfz marked 11 inline comments as done. omtcyfz added a comment. Addressed all comments by Eric. As discussed internally, I should also exercise my naming skills and come up with a better for the symbol index to substitute "Noctem" which doesn't p

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev updated this revision to Diff 278329. kbobyrev added a comment. Add some missing ranges. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 Files: clang-tools-extra/clangd/unittests/SemanticSelectio

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 278682. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Refactor marshalling into a class, log errors only on the high level. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 278683. kbobyrev added a comment. Remove (now empty) Marshalling.h file comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https://reviews.llvm.org/D83826 Files: clang-tools-extra/clangd/inde

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev planned changes to this revision. kbobyrev added a comment. Will resolve the comments and add some missing examples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 __

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev updated this revision to Diff 279132. kbobyrev marked 13 inline comments as done. kbobyrev added a comment. Resolve most comments, make sure everything builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.o

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:246 + + if ([[B && I > 42 || ~([[++I]])]]) {[[ +++I; sammccall wrote: > confused about [[++I]] - why is this foldable but not I > 42 etc

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 279447. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address post-LGTM comments, rebase on top of HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https://reviews.llvm.org

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

This revision was automatically updated to reflect the committed changes. Closed by commit rGeef162c330b0: [clangd] Don't send invalid messages from remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https:

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev updated this revision to Diff 279457. kbobyrev added a comment. Add flag description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev updated this revision to Diff 279472. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt clang-too

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev updated this revision to Diff 279497. kbobyrev added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Check gRPC version for system-installed APT package on Debian-like Linux distros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev added a comment. Aww, this might be problematic. Ubuntu has quite old gRPC versions (which are OK though). The newest is 1.26.0 and it's on Groovy (20.10, unreleased yet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https://r

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3975c3be8041: [clangd] Fix conversion from Windows UNC paths to file URI format. (authored by walrus, committed by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

kbobyrev added a comment. In D84172#2166448 , @ilya-golovenko wrote: > @kbobyrev Kirill, thank you for landing this for me! Unfortunately @walrus is > my not-used-anymore account... > By the way, do you know is it possible to delete my unused account @w

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

kbobyrev added a comment. In D84172#2166503 , @ilya-golovenko wrote: > In D84172#2166496 , @kbobyrev wrote: > > > In D84172#2166448 , > > @ilya-golovenko wrote: > > > > > @

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev planned changes to this revision. kbobyrev added a comment. Maybe wait for Debian packages to get updated and then whitelist 1.26.0-4 but fail with anything lower than that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https:/

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280365. kbobyrev added a comment. Rebase on top of master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files: clang-tools-extra/clangd/index/remote/Client.cpp clang-tools-extra/clangd/index/remote/se

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84499 Files: clang-tools-extra/clang

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev abandoned this revision. kbobyrev added a comment. In favor of D84499 with clean diffs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 ___ cfe-commits mail

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added a comment. The first iteration is D83831 but the diffs are clobbered and I can't change the history there :( So, creating a new one is maybe the best solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280381. kbobyrev added a comment. Abstract out the client request into a single function call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files: clang-tools-ext

[PATCH] D83831: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280383. kbobyrev added a comment. Reset D83831 to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83831/new/ https://reviews.llvm.org/D83831 Files: clang-tools-extra/

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev planned changes to this revision. kbobyrev added a comment. Tracer messages for sent and failed to parse items are not correct. Have to figure out how to print them _after_ the callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280391. kbobyrev added a comment. Fix (un)successful message numbers reporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files: clang-tools-extra/clangd/index

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Only FuzzyFindRequest is implemented via Marshaller even though other requests also follow a similar pat

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280476. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files: clang-to

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:55 +template +llvm::Optional> getIDs(MessageT *Message) { + llvm::DenseSet Result; kadircet wrote: > I would make this return an expected instead of an

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. When dereferencing Optional's it makes sense to use ASSERT_TRUE for better test failures readability. Sw

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280587. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Resolve most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files: cla

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:61 Callback(*Response); + ++Received; } kadircet wrote: > shouldn't we increment this before the `continue` above ? (or rename this to > `successful` ra

[PATCH] D83817: [clangd] Add option to use remote index as static index

kbobyrev updated this revision to Diff 280589. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-to

[PATCH] D83817: [clangd] Add option to use remote index as static index

kbobyrev updated this revision to Diff 280593. kbobyrev added a comment. Remove unused Remote category. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt cla

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280600. kbobyrev added a comment. Add missing Limit & Filter for fromProtobuf(RefsRequest *) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files: clang-tools-extra

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 ___ cfe-commi

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:96 +} Counter(Request->DebugString()); +return std::forward(Call)( +*Index, ClangdRequest, [&](const StreamType &Item) { sammccall wrote: > I don't

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:64 *Serialized->mutable_location()->mutable_file_path() = std::string(); Deserialized = ProtobufMarshaller.fromProtobuf(*Serialized); EXPECT_FALSE(Deserialized); --

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

kbobyrev updated this revision to Diff 280743. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address most comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84535/new/ https://reviews.llvm.org/D84535 Files: clang-tool

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

kbobyrev updated this revision to Diff 280745. kbobyrev added a comment. Find one more case when checking directly makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84535/new/ https://reviews.llvm.org/D84535 Files: clang-tools-extra/cla

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to resolve remaining comments and improve readability. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 ___

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:73 private: + template sammccall wrote: > you don't need both RequestT and ClangdRequest as template params: > - the things you're currently doing are all avai

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280812. kbobyrev marked 14 inline comments as done. kbobyrev added a comment. Resolve most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files: cl

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

kbobyrev marked 5 inline comments as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/remote/MarshallingTests.cpp:159 Deserialized = ProtobufMarshaller.fromProtobuf(*Serialized); EXPECT_TRUE(Deserialized); kbobyrev wrot

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

This revision was automatically updated to reflect the committed changes. kbobyrev marked an inline comment as done. Closed by commit rG974ffee9ccd7: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280819. kbobyrev added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files: clang-tools-extra/clangd/index/remote/marshalling/Marshallin

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280820. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files: clang-tools-extra/clangd/index/remote/marshalling/M

[PATCH] D83817: [clangd] Add option to use remote index as static index

kbobyrev updated this revision to Diff 280822. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tool

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to address the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 ___ cf

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev planned changes to this revision. kbobyrev added a comment. As discussed in PM, should move back to duplicated code 😢 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 _

[PATCH] D83817: [clangd] Add option to use remote index as static index

This revision was automatically updated to reflect the committed changes. Closed by commit rG37ac559fccd4: [clangd] Add option to use remote index as static index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280840. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve the remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files: c

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280846. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Move back to duplicated code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files: cla

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev marked 3 inline comments as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:73 private: + template kbobyrev wrote: > sammccall wrote: > > you don't need both RequestT and ClangdRequest as templ

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280848. kbobyrev added a comment. Fix code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files: clang-tools-extra/clangd/index/remote/Client.cpp clang-tools-ext

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280853. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Resolve nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files: clang-tools-extra/c

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280862. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files: clang

[PATCH] D84525: [clangd] Add marshalling code for all request types

This revision was automatically updated to reflect the committed changes. Closed by commit rGf49a7ad8c085: [clangd] Add marshalling code for all request types (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://r

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280993. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve all but 1 post-LGTM comment and rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://re

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev marked an inline comment as not done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:203 + TracerStream.reset(); + llvm::errs() << "Error while opening trace file " << TraceFile << ": " + <<

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280997. kbobyrev marked an inline comment as done. kbobyrev added a comment. Switch from llvm::errs() to elog() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files:

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

This revision was automatically updated to reflect the committed changes. Closed by commit rG731043c0c494: [clangd] Add more logs and attach tracers to remote index server routines (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84697 Files: clang-tools-

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

kbobyrev updated this revision to Diff 281027. kbobyrev added a comment. Don't use llvm::toString in elog Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84697/new/ https://reviews.llvm.org/D84697 Files: clang-tools-extra/clangd/benchmarks/IndexBe

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

kbobyrev updated this revision to Diff 281130. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Use more conservative approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84697/new/ https://reviews.llvm.org/D84697 Files: c

[PATCH] D84794: Mark override to a function which overrides a virtual one

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84794/new/ https://reviews.llvm.org/D84794 __

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is useful for the remote index:

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

kbobyrev updated this revision to Diff 281416. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve post-LGTM comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84697/new/ https://reviews.llvm.org/D84697 Files: clang

[PATCH] D84697: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfb22678cd678: [clangd] Use elog instead of llvm::errs, log instead of llvm::outs (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D84894: [clangd] Implement Relations request for remote index

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is the last missing bit in the

[PATCH] D84894: [clangd] Implement Relations request for remote index

kbobyrev updated this revision to Diff 281754. kbobyrev added a comment. Fix comment in proto file and rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84894/new/ https://reviews.llvm.org/D84894 Files: clang-tools-extra/cla

[PATCH] D84811: [clangd] Add an option to exclude symbols outside of project root from index

kbobyrev planned changes to this revision. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/indexer/IndexerMain.cpp:112 +if (!IndexRoot.empty()) { + llvm::DenseSet ExcludeIDs; + for (const auto &Sym : *Result.Symbols) hokein wrot

[PATCH] D84894: [clangd] Implement Relations request for remote index

kbobyrev updated this revision to Diff 281863. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Address all comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84894/new/ https://reviews.llvm.org/D84894 Files: clang-tools

[PATCH] D84894: [clangd] Implement Relations request for remote index

kbobyrev updated this revision to Diff 281869. kbobyrev marked an inline comment as done. kbobyrev added a comment. Address post-LGTM comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84894/new/ https://reviews.llvm.org/D84894 Files: clang-

[PATCH] D84894: [clangd] Implement Relations request for remote index

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa262f0fea46c: [clangd] Implement Relations request for remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a refactoring: errors shoul

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 281897. kbobyrev added a comment. Client: print debug string for the stream_result, not the ReplyT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.org/D84939 Files: clang-tool

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added a comment. In D84939#2184836 , @kadircet wrote: > i think you might want to have an helper for creating stringerrors and use it > in all places Haha, yeah I thought about that but then looked at other examples and saw that in some cases t

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 281946. kbobyrev marked 12 inline comments as done. kbobyrev added a comment. Resolve most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.org/D84939 Files: cl

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:313 RelativePath, llvm::sys::path::Style::posix)); - if (RelativePath.empty()) { -return llvm::None; - } - if (llvm::sys::path::is_a

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev added a comment. This patch is not ready for review yet; planned changes: check if the version is between 1.25.0 and 1.26.0-4 and bail out in such cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https://reviews.llvm.org/D8

[PATCH] D77645: [clangd] Support dexp -c "some command"

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM with a couple of nits Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:85 llvm::cl::ValueDisallowed, llvm::cl::cat(llvm::cl::GeneralCategory)}; +

[PATCH] D77385: [clangd] Add index export to dexp

kbobyrev added a comment. > Typical use is to read RIFF data to dump to YAML for inspection of indexed > data. The YAML (de)serialization has also been extended to aid in this regard. Just curious: what is the typical usecase for YAML index inspection? Maybe if there is something missing in Dex

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. kbobyrev updated this revision to Diff 256263. kbobyrev added a comment. Rebase on to

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev updated this revision to Diff 256263. kbobyrev added a comment. Rebase on top of the correct revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files: clang-tools-extra/clangd/CMakeLists.tx

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev updated this revision to Diff 256265. kbobyrev added a comment. Discard Dexp.cpp formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev updated this revision to Diff 256267. kbobyrev added a comment. Rebase on top of the correct revision again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files: clang-tools-extra/clangd/CMakeLi

[PATCH] D78089: [dexp] NFC: Change positional argument format

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev updated this revision to Diff 257224. kbobyrev added a comment. kbobyrev edited the summary of this revision.

[PATCH] D78089: [dexp] NFC: Change positional argument format

kbobyrev updated this revision to Diff 257224. kbobyrev added a comment. %s/PATH TO INDEX/INDEX FILE/g for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78089/new/ https://reviews.llvm.org/D78089 Files: clang-tools-extra/clangd/index/dex

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

kbobyrev planned changes to this revision. kbobyrev added a comment. Also Comment at: clang-tools-extra/clangd/CMakeLists.txt:164 + + set(_GRPC_GRPCPP gRPC::grpc++) + set(_PROTOBUF_LIBPROTOBUF protobuf::libprotobuf) sammccall wrote: > Can we give these slight

<    1   2   3   4   5   6   7   8   9   10   >