Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

kcc added inline comments. Comment at: docs/ControlFlowIntegrity.rst:149 @@ +148,3 @@ +shared library boundaries are handled as if the callee was not compiled with +``-fsanitize=cfi-icall``. + mention that LTO is require explicitly?

Re: [PATCH] D11857: CFI: Introduce -fsanitize=cfi-icall flag.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM with a nit Comment at: test/CodeGen/cfi-icall.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux -fsanitize=cfi-icall -fsanitize-trap=cfi-icall -emit-llvm -o -

r254481 - [sanitizer coverage] document -fsanitize-coverage=trace-bb

Author: kcc Date: Tue Dec 1 20:08:26 2015 New Revision: 254481 URL: http://llvm.org/viewvc/llvm-project?rev=254481=rev Log: [sanitizer coverage] document -fsanitize-coverage=trace-bb Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

Re: [PATCH] D15363: [UBSan] Implement runtime suppressions (PR25066).

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D15363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r255371 - Error on redeclaring with a conflicting asm label and on redeclaring with an asm label after the first ODR-use. Detects problems like the one in PR22830 where gcc and clang both compiled

I am now observing this error message when building glibc with clang (from trunk): ../include/string.h:101:28: error: cannot apply asm label to function after its first use libc_hidden_builtin_proto (memcpy) (many more instances) Do you think this is a bug in glibc code, or the error message

Re: [PATCH] D15624: Add iOS/watchOS/tvOS support for ASan (clang part)

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D15624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang-tools-extra] r256562 - [clang-tidy] Fix a use-after-free bug found by asan

Nice! is a fuzzer for clang-tidy possible/desirable? similar to what we have for clang and clang-format (tools/clang-format/fuzzer, ./tools/clang-fuzzer) On Tue, Dec 29, 2015 at 8:14 AM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Tue Dec 29

Re: r255371 - Error on redeclaring with a conflicting asm label and on redeclaring with an asm label after the first ODR-use. Detects problems like the one in PR22830 where gcc and clang both compiled

Thanks for checking, Nick! +Roland, FYI (recent changes in clang break compilation of all of the glibc), similar to https://llvm.org/bugs/show_bug.cgi?id=22830#c1 On Mon, Jan 4, 2016 at 3:21 PM, Nick Lewycky wrote: > On 01/04/2016 01:40 PM, Kostya Serebryany wrote: > >> >> >>

Re: [clang-tools-extra] r256562 - [clang-tidy] Fix a use-after-free bug found by asan

On Tue, Jan 5, 2016 at 9:01 AM, Alexander Kornienko wrote: > On Mon, Jan 4, 2016 at 7:39 PM, Kostya Serebryany wrote: > >> Nice! >> is a fuzzer for clang-tidy possible/ >> > > Should be no more difficult than clang-fuzzer. > Let's do it then? > > >>

r254337 - [libFuzzer] clarify the limitation of fsanitize-coverage=trace-cmp

Author: kcc Date: Mon Nov 30 16:17:19 2015 New Revision: 254337 URL: http://llvm.org/viewvc/llvm-project?rev=254337=rev Log: [libFuzzer] clarify the limitation of fsanitize-coverage=trace-cmp Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

Re: [PATCH] D14858: Support building tsan on android.

kcc added a comment. performance is a very strong reason to have tsan linked statically. every memory access in the app is instrumented with a function call, if we make this call go through PLT we'll get significant drop in performance. This is not a blocker, but I want to explicitly mention

Re: [PATCH] D16065: Fix infinite recursion for invalid declaration

kcc accepted this revision. kcc added a reviewer: kcc. kcc added a comment. This revision is now accepted and ready to land. LGTM, and thanks! http://reviews.llvm.org/D16065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc added a comment. What run-time is going to be linked when coverage is used w/o any of the sanitizers? Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc added a comment. Can you at least add a compiler-rt test where we ensure that this flag can not be used such that it wil compile but fail to link? E.g. clang -fsanitize-coverage=edge x.c should compile *and* link (and run) Repository: rL LLVM http://reviews.llvm.org/D21317

r271005 - [msan] add a sentence about inline assembly

Author: kcc Date: Fri May 27 10:49:32 2016 New Revision: 271005 URL: http://llvm.org/viewvc/llvm-project?rev=271005=rev Log: [msan] add a sentence about inline assembly Modified: cfe/trunk/docs/MemorySanitizer.rst Modified: cfe/trunk/docs/MemorySanitizer.rst URL:

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Please also check if the documentation needs to be updated. Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list

Re: [PATCH] D21446: Comprehensive static instrumentation (2/3): Clang support

kcc added inline comments. Comment at: docs/CSI.rst:7 @@ +6,3 @@ + +CSI:LLVM is a framework providing comprehensive static instrumentation via the +compiler in order to simplify the task of building efficient and effective The intro paragraph is important to

r261178 - [sanitizer-coverage] add a deprecation warning for -fsanitize-coverage=[1234]

Author: kcc Date: Wed Feb 17 17:57:17 2016 New Revision: 261178 URL: http://llvm.org/viewvc/llvm-project?rev=261178=rev Log: [sanitizer-coverage] add a deprecation warning for -fsanitize-coverage=[1234] Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp

Re: [PATCH] D17397: Make deprecation message for -fsanitize-coverage= with numeric argument friendlier.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Thanks! I don't see much value in doing this, but also don't mind. http://reviews.llvm.org/D17397 ___ cfe-commits mailing list

Re: r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

This change is causing ubsan bot to complain . Please fix or revert. Most likely the guilty part is this: +*getReplacementSlot() = replacementExpr;

r262503 - [libFuzzer] allow -fsanitize-coverage=0 (disables all coverage)

Author: kcc Date: Wed Mar 2 13:16:54 2016 New Revision: 262503 URL: http://llvm.org/viewvc/llvm-project?rev=262503=rev Log: [libFuzzer] allow -fsanitize-coverage=0 (disables all coverage) Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage.c

Re: r267496 - [lanai] Update handling of structs in arguments to be passed in registers.

+rnk On Mon, Apr 25, 2016 at 5:09 PM, Jacques Pienaar via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: jpienaar > Date: Mon Apr 25 19:09:29 2016 > New Revision: 267496 > > URL: http://llvm.org/viewvc/llvm-project?rev=267496=rev > Log: > [lanai] Update handling of structs in

r267513 - trying to fix the windows build broken by r267496

Author: kcc Date: Mon Apr 25 20:53:49 2016 New Revision: 267513 URL: http://llvm.org/viewvc/llvm-project?rev=267513=rev Log: trying to fix the windows build broken by r267496 Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp URL:

Re: r267496 - [lanai] Update handling of structs in arguments to be passed in registers.

Hopefully fixed by r267513. On Mon, Apr 25, 2016 at 6:46 PM, Kostya Serebryany wrote: > +rnk > > On Mon, Apr 25, 2016 at 5:09 PM, Jacques Pienaar via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: jpienaar >> Date: Mon Apr 25 19:09:29 2016 >> New Revision:

Re: r267496 - [lanai] Update handling of structs in arguments to be passed in registers.

On Tue, Apr 26, 2016 at 6:49 AM, Jacques Pienaar wrote: > Thanks for fixing this. My apologies for breaking this and not noticing & > fixing it earlier. > no problem. > Is there any way to test the Windows build without a Windows machine at my > disposal? > Not that I

r268540 - document -f[no-]sanitize-recover=all and mention it in warning messages

Author: kcc Date: Wed May 4 15:21:47 2016 New Revision: 268540 URL: http://llvm.org/viewvc/llvm-project?rev=268540=rev Log: document -f[no-]sanitize-recover=all and mention it in warning messages Modified: cfe/trunk/docs/UsersManual.rst cfe/trunk/lib/Driver/SanitizerArgs.cpp

r268541 - fix docs

Author: kcc Date: Wed May 4 15:24:54 2016 New Revision: 268541 URL: http://llvm.org/viewvc/llvm-project?rev=268541=rev Log: fix docs Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManual.rst URL:

r266672 - [sanitizer-coverage] better docs for -fsanitize-coverage=trace-bb

Author: kcc Date: Mon Apr 18 16:28:37 2016 New Revision: 266672 URL: http://llvm.org/viewvc/llvm-project?rev=266672=rev Log: [sanitizer-coverage] better docs for -fsanitize-coverage=trace-bb Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

r266673 - [sanitizer-coverage] make sure coverage flags are not passed to clang if the driver thinks they are unused

Author: kcc Date: Mon Apr 18 16:30:17 2016 New Revision: 266673 URL: http://llvm.org/viewvc/llvm-project?rev=266673=rev Log: [sanitizer-coverage] make sure coverage flags are not passed to clang if the driver thinks they are unused Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

Sweet! Did you fix all of the known crashers? On Fri, Aug 12, 2016 at 5:02 PM, Mehdi Amini via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mehdi_amini > Date: Fri Aug 12 19:02:33 2016 > New Revision: 278579 > > URL: http://llvm.org/viewvc/llvm-project?rev=278579=rev > Log: > Fix

Re: [libcxxabi] r278579 - Fix ASAN failures in the demangler

On Fri, Aug 12, 2016 at 5:26 PM, Mehdi Amini wrote: > This fixes all the crashers on Darwin (clang+libc++), that I could > reproduce with ASAN+libFuzzer. > It does not mean that there is no leaks, or that you won’t find more > crashes with libstdc++ for instance. > Yea...

r292862 - [sanitizer-coverage] emit __sanitizer_cov_trace_pc_guard w/o a preceding 'if' by default. Update the docs, also add deprecation notes around other parts of sanitizer coverage

Author: kcc Date: Mon Jan 23 18:57:31 2017 New Revision: 292862 URL: http://llvm.org/viewvc/llvm-project?rev=292862=rev Log: [sanitizer-coverage] emit __sanitizer_cov_trace_pc_guard w/o a preceding 'if' by default. Update the docs, also add deprecation notes around other parts of sanitizer

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

kcc added reviewers: vitalybuka, eugenis. kcc added a comment. Sorry, I won't have a chance to look at it before late next week. Adding two more folks in case they have ideas. https://reviews.llvm.org/D24048 ___ cfe-commits mailing list

r280044 - [sanitizer-coverage] add two more modes of instrumentation: trace-div and trace-gep, mostly usaful for value-profile-based fuzzing; clang part

Author: kcc Date: Mon Aug 29 20:27:03 2016 New Revision: 280044 URL: http://llvm.org/viewvc/llvm-project?rev=280044=rev Log: [sanitizer-coverage] add two more modes of instrumentation: trace-div and trace-gep, mostly usaful for value-profile-based fuzzing; clang part Modified:

r281432 - [sanitizer-coverage] add yet another flavour of coverage instrumentation: trace-pc-guard. The intent is to eventually replace all of {bool coverage, 8bit-counters, trace-pc} with just this o

Author: kcc Date: Tue Sep 13 20:39:49 2016 New Revision: 281432 URL: http://llvm.org/viewvc/llvm-project?rev=281432=rev Log: [sanitizer-coverage] add yet another flavour of coverage instrumentation: trace-pc-guard. The intent is to eventually replace all of {bool coverage, 8bit-counters,

r281665 - [sanitizer-coverage] make trace-pc-guard and indirect-call work together

Author: kcc Date: Thu Sep 15 17:11:08 2016 New Revision: 281665 URL: http://llvm.org/viewvc/llvm-project?rev=281665=rev Log: [sanitizer-coverage] make trace-pc-guard and indirect-call work together Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst

Re: r282453 - P0145R3 (C++17 evaluation order tweaks): consistently emit the LHS of array

Looks like yours: FAILED: tools/clang/lib/CodeGen/CMakeFiles/clangCodeGen.dir/CGExpr.cpp.obj C:\PROGRA~2\MICROS~1.0\VC\bin\AMD64_~1\cl.exe /nologo /TP -DCLANG_ENABLE_ARCMT -DCLANG_ENABLE_OBJC_REWRITER -DCLANG_ENABLE_STATIC_ANALYZER -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE

r282749 - [sanitize-coverage] doc typo

Author: kcc Date: Thu Sep 29 13:34:40 2016 New Revision: 282749 URL: http://llvm.org/viewvc/llvm-project?rev=282749=rev Log: [sanitize-coverage] doc typo Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

r282751 - [sanitizer-coverage] more docs

Author: kcc Date: Thu Sep 29 13:58:17 2016 New Revision: 282751 URL: http://llvm.org/viewvc/llvm-project?rev=282751=rev Log: [sanitizer-coverage] more docs Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

r282735 - [sanitizer-coverage/libFuzzer] make the guards for trace-pc 32-bit; create one array of guards per function, instead of one guard per BB. reorganize the code so that trace-pc-guard does not

Author: kcc Date: Thu Sep 29 12:43:24 2016 New Revision: 282735 URL: http://llvm.org/viewvc/llvm-project?rev=282735=rev Log: [sanitizer-coverage/libFuzzer] make the guards for trace-pc 32-bit; create one array of guards per function, instead of one guard per BB. reorganize the code so that

r282752 - [sanitizer-coverage] a bit more docs

Author: kcc Date: Thu Sep 29 14:06:09 2016 New Revision: 282752 URL: http://llvm.org/viewvc/llvm-project?rev=282752=rev Log: [sanitizer-coverage] a bit more docs Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

r281845 - [libFuzzer] use 'if guard' instead of 'if guard >= 0' with trace-pc; change the guard type to intptr_t; use separate array for 8-bit counters

Author: kcc Date: Sat Sep 17 23:52:23 2016 New Revision: 281845 URL: http://llvm.org/viewvc/llvm-project?rev=281845=rev Log: [libFuzzer] use 'if guard' instead of 'if guard >= 0' with trace-pc; change the guard type to intptr_t; use separate array for 8-bit counters Modified:

r281809 - [sanitizer-coverage] change trace-pc to use 8-byte guards

Author: kcc Date: Sat Sep 17 00:03:05 2016 New Revision: 281809 URL: http://llvm.org/viewvc/llvm-project?rev=281809=rev Log: [sanitizer-coverage] change trace-pc to use 8-byte guards Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

r279028 - [sanitizer-coverag] update the docs in __sanitizer_cov_trace_cmp

Author: kcc Date: Wed Aug 17 20:26:36 2016 New Revision: 279028 URL: http://llvm.org/viewvc/llvm-project?rev=279028=rev Log: [sanitizer-coverag] update the docs in __sanitizer_cov_trace_cmp Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

[PATCH] D25199: [ubsan] Sanitize deleted pointers

kcc added a reviewer: pcc. kcc added a comment. In https://reviews.llvm.org/D25199#559407, @vsk wrote: > It looks like programs which trip -fsanitize-value-after-delete will just > crash without further reporting, which isn't in keeping with the way other > ubsan checks are implemented. > >

[PATCH] D25199: [ubsan] Sanitize deleted pointers

kcc added a comment. >> will just crash without further reporting I agree, and we can address that by having special logic in ubsan's segv handler. This does not have to be in this patch. Also, I am not sure about the actual constant. DEADBEEF is commonly recognized poison valued, but on a

[PATCH] D25199: [ubsan] Sanitize deleted pointers

kcc added a comment. > Maybe we could call this `-fpoison-dangling-ptrs` and force users to be more > explicit about opting into this behavior change. That would remove some of > the constraints usually placed on new sanitizer checks (e.g support for > executing after the error triggers,

r282962 - [sanitizer-coverage] fix docs

Author: kcc Date: Fri Sep 30 16:57:10 2016 New Revision: 282962 URL: http://llvm.org/viewvc/llvm-project?rev=282962=rev Log: [sanitizer-coverage] fix docs Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

Re: r284272 - Implement no_sanitize_address for global vars

ping On Mon, Oct 17, 2016 at 5:57 PM, Kostya Serebryany wrote: > Did you code-review this? > (sorry if I missed it) > > On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: dougk >> Date: Fri Oct 14 14:55:09 2016

Re: r286096 - Deduplicate replacements by FileEntry instead of file names.

Hi Eric, the asan bootstrap bot shows a leak in this newly added tests. Please fix or revert ASAP. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/136/steps/check-clang%20asan/logs/stdio Direct leak of 720 byte(s) in 1 object(s) allocated from: #0 0x6ace50 in

Re: r286096 - Deduplicate replacements by FileEntry instead of file names.

Thanks! On Mon, Nov 7, 2016 at 10:53 AM, Eric Liu wrote: > r286132 should fix this. > > On Mon, Nov 7, 2016 at 10:40 AM Eric Liu wrote: > > Thanks Kostya! I'll look into this now. > > On Mon, Nov 7, 2016 at 10:39 AM Kostya Serebryany

r284029 - Document potential implementation of CFI in hardware.

Author: kcc Date: Wed Oct 12 13:33:54 2016 New Revision: 284029 URL: http://llvm.org/viewvc/llvm-project?rev=284029=rev Log: Document potential implementation of CFI in hardware. Summary: Document potential implementation of CFI in hardware. Reviewers: eugenis, pcc Subscribers: llvm-commits

Re: r284272 - Implement no_sanitize_address for global vars

Did you code-review this? (sorry if I missed it) On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: dougk > Date: Fri Oct 14 14:55:09 2016 > New Revision: 284272 > > URL: http://llvm.org/viewvc/llvm-project?rev=284272=rev > Log: >

[PATCH] D26763: [compiler-rt] [asan] Use __SSE2__ (rather than __i686__...) for SSE2 test

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM, assuming you have verified that the test is still executed. https://reviews.llvm.org/D26763 ___ cfe-commits mailing list

[PATCH] D26454: Implement no_sanitize_address for global vars

kcc added a comment. Does this change deserve a documentation update? https://reviews.llvm.org/D26454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] r290650 - add cxa_demangle_fuzzer

Author: kcc Date: Tue Dec 27 21:28:29 2016 New Revision: 290650 URL: http://llvm.org/viewvc/llvm-project?rev=290650=rev Log: add cxa_demangle_fuzzer Summary: All easy-to-find bugs in cxa_demangle where fixed now (https://bugs.chromium.org/p/chromium/issues/detail?id=606626) except for one

r298303 - Proposal: Backward-edge CFI for return statements (RCFI)

Author: kcc Date: Mon Mar 20 15:42:00 2017 New Revision: 298303 URL: http://llvm.org/viewvc/llvm-project?rev=298303=rev Log: Proposal: Backward-edge CFI for return statements (RCFI) Summary: Proposal: Backward-edge CFI for return statements (RCFI) Reviewers: pcc, eugenis, krasin Reviewed By:

r300738 - [sanitizer-coverage] deprecate some of the stale coverage variants

Author: kcc Date: Wed Apr 19 14:57:16 2017 New Revision: 300738 URL: http://llvm.org/viewvc/llvm-project?rev=300738=rev Log: [sanitizer-coverage] deprecate some of the stale coverage variants Modified: cfe/trunk/docs/SanitizerCoverage.rst cfe/trunk/lib/Driver/SanitizerArgs.cpp

r300744 - [sanitizer-coverage] deprecate -fsanitize-coverage=8bit-counters

Author: kcc Date: Wed Apr 19 15:15:58 2017 New Revision: 300744 URL: http://llvm.org/viewvc/llvm-project?rev=300744=rev Log: [sanitizer-coverage] deprecate -fsanitize-coverage=8bit-counters Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage.c

r300776 - [sanitizer-coverage] trim down the docs

Author: kcc Date: Wed Apr 19 17:25:30 2017 New Revision: 300776 URL: http://llvm.org/viewvc/llvm-project?rev=300776=rev Log: [sanitizer-coverage] trim down the docs Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

r300755 - Fix a leak in tools/driver/cc1as_main.cpp

Author: kcc Date: Wed Apr 19 15:57:13 2017 New Revision: 300755 URL: http://llvm.org/viewvc/llvm-project?rev=300755=rev Log: Fix a leak in tools/driver/cc1as_main.cpp Summary: For some reason, the asan bot has recently started reporting this leak even though it existed for ages. Reviewers: pcc

r300767 - [sanitizer-coverage] deprecate -fsanitize-coverage=trace-bb

Author: kcc Date: Wed Apr 19 16:31:11 2017 New Revision: 300767 URL: http://llvm.org/viewvc/llvm-project?rev=300767=rev Log: [sanitizer-coverage] deprecate -fsanitize-coverage=trace-bb Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage.c Modified:

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

+klimek@ who contributed the first version of clang-fuzzer. We now have clang-proto-fuzzer (see tools/clang/tools/clang-fuzzer/README.txt) which shares code with clang-fuzzer, but which also depends on various packages (protobufs, in particular). clang-proto-fuzzer is off by default (requires a

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

On Thu, Aug 10, 2017 at 10:56 AM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I really believe this has way too many deps to live in the clang repro, as > said on the review already. > I don't have a very strong opinion here and would be happy to move if I see more support

r310774 - Add a Dockerfile for clang-proto-fuzzer

Author: kcc Date: Fri Aug 11 18:27:10 2017 New Revision: 310774 URL: http://llvm.org/viewvc/llvm-project?rev=310774=rev Log: Add a Dockerfile for clang-proto-fuzzer Summary: Add a Dockerfile for clang-proto-fuzzer Reviewers: morehouse, vitalybuka Reviewed By: morehouse Subscribers: hintonda,

Re: r310408 - Integrate Kostya's clang-proto-fuzzer with LLVM.

On Thu, Aug 10, 2017 at 12:01 PM, Nico Weber wrote: > On Thu, Aug 10, 2017 at 2:04 PM, Kostya Serebryany wrote: > >> >> >> On Thu, Aug 10, 2017 at 10:56 AM, Nico Weber via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> I really believe this has

r308045 - do more processing in clang-fuzzer (use EmitAssemblyAction)

Author: kcc Date: Fri Jul 14 11:42:07 2017 New Revision: 308045 URL: http://llvm.org/viewvc/llvm-project?rev=308045=rev Log: do more processing in clang-fuzzer (use EmitAssemblyAction) Summary: use EmitAssemblyAction in clang-fuzzer Reviewers: klimek, rsmith Reviewed By: klimek Subscribers:

Re: r309036 - [StaticAnalyzer] LoopUnrolling - Attempt to fix a crash in r309006.

Looks like one more failure (this time under ubsan) remains in this code http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/6708/steps/check-clang%20ubsan/logs/stdio Please fix asap.

r310136 - [libFuzzer] add -fsanitize-coverage-pc-table to -fsanitize=fuzzer

Author: kcc Date: Fri Aug 4 14:35:11 2017 New Revision: 310136 URL: http://llvm.org/viewvc/llvm-project?rev=310136=rev Log: [libFuzzer] add -fsanitize-coverage-pc-table to -fsanitize=fuzzer Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fuzzer.c Modified:

r310409 - [sanitizer-coverage] -fsanitize-coverage=bb, inline-8bit-counters

Author: kcc Date: Tue Aug 8 13:20:40 2017 New Revision: 310409 URL: http://llvm.org/viewvc/llvm-project?rev=310409=rev Log: [sanitizer-coverage] -fsanitize-coverage=bb,inline-8bit-counters Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage.c

r309338 - [sanitizer-coverage] clang flags pumbing for -fsanitize-coverage=pc-table

Author: kcc Date: Thu Jul 27 17:10:10 2017 New Revision: 309338 URL: http://llvm.org/viewvc/llvm-project?rev=309338=rev Log: [sanitizer-coverage] clang flags pumbing for -fsanitize-coverage=pc-table Modified: cfe/trunk/include/clang/Driver/CC1Options.td

r301888 - [sanitizer-coverage] update the SanitizerCoverage docs to reflect the current state

Author: kcc Date: Mon May 1 19:32:57 2017 New Revision: 301888 URL: http://llvm.org/viewvc/llvm-project?rev=301888=rev Log: [sanitizer-coverage] update the SanitizerCoverage docs to reflect the current state Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified:

Re: r301994 - [sanitizer-coverage] add a deprecation warning to the old sanitizer-coverage flag combinations

> On Tue, May 2, 2017 at 6:27 PM, Kostya Serebryany via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: kcc >> Date: Tue May 2 20:27:28 2017 >> New Revision: 301994 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=301994=rev &g

r304631 - [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part)

Author: kcc Date: Fri Jun 2 20:36:23 2017 New Revision: 304631 URL: http://llvm.org/viewvc/llvm-project?rev=304631=rev Log: [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part) Modified:

Re: r304697 - Revert "[sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part)"

How did it break it? Any logs? On Mon, Jun 5, 2017 at 12:35 AM, Renato Golin via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rengolin > Date: Mon Jun 5 02:35:45 2017 > New Revision: 304697 > > URL: http://llvm.org/viewvc/llvm-project?rev=304697=rev > Log: > Revert

Re: r304697 - Revert "[sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. (clang part)"

Ah, I see https://bugs.llvm.org/show_bug.cgi?id=33308, moving the discussion there. On Thu, Jun 8, 2017 at 10:05 AM, Kostya Serebryany wrote: > How did it break it? > Any logs? > > On Mon, Jun 5, 2017 at 12:35 AM, Renato Golin via cfe-commits < > cfe-commits@lists.llvm.org>

Re: r305022 - [ASTMatchers] Add clang-query support for equals matcher

The test seems to be failing: llvm/tools/clang/unittests/ASTMatchers/Dynamic/RegistryTest.cpp:533: Failure Value of: matches("double x = 1.2f;", DoubleStmt) Actual: false (Could not find match in "double x = 1.2f;") Expected: true On Thu, Jun 8, 2017 at 3:00 PM, Peter Wu via cfe-commits <

r305026 - [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. Reapplying revisions 304630, 304631, 304632, 304673, see

Author: kcc Date: Thu Jun 8 17:58:19 2017 New Revision: 305026 URL: http://llvm.org/viewvc/llvm-project?rev=305026=rev Log: [sanitizer-coverage] one more flavor of coverage: -fsanitize-coverage=inline-8bit-counters. Experimental so far, not documenting yet. Reapplying revisions 304630, 304631,

Re: r305425 - [Preprocessor]Correct Macro-Arg allocation of StringifiedArguments,

the bots complain about a leak in the new test code. Please fix/revert ASAP. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/5691/steps/check-clang%20asan/logs/stdio =28905==ERROR: LeakSanitizer: detected memory leaks Direct leak of 216 byte(s) in 1 object(s) allocated from:

r301824 - [sanitizer-coverage] add a deprecation note to coverage_direct=1

Author: kcc Date: Mon May 1 14:52:01 2017 New Revision: 301824 URL: http://llvm.org/viewvc/llvm-project?rev=301824=rev Log: [sanitizer-coverage] add a deprecation note to coverage_direct=1 Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

r301994 - [sanitizer-coverage] add a deprecation warning to the old sanitizer-coverage flag combinations

Author: kcc Date: Tue May 2 20:27:28 2017 New Revision: 301994 URL: http://llvm.org/viewvc/llvm-project?rev=301994=rev Log: [sanitizer-coverage] add a deprecation warning to the old sanitizer-coverage flag combinations Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp

r302320 - [sanitizer-coverage] implement -fsanitize-coverage=no-prune, ... instead of a hidden -mllvm flag. clang part.

Author: kcc Date: Fri May 5 18:28:18 2017 New Revision: 302320 URL: http://llvm.org/viewvc/llvm-project?rev=302320=rev Log: [sanitizer-coverage] implement -fsanitize-coverage=no-prune,... instead of a hidden -mllvm flag. clang part. Modified: cfe/trunk/docs/SanitizerCoverage.rst

Re: [libcxxabi] r313215 - Reland "When built with ASan, __cxa_throw calls __asan_handle_no_return"

The bot is unhappy: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/7880/steps/build%20libcxx%2Fasan/logs/stdio 1/6] Building CXX object projects/libcxxabi/src/CMakeFiles/cxxabi_objects.dir/cxa_exception.cpp.o FAILED:

r311719 - [sanitizer-coverage] document -fsanitize-coverage=pc-table and -fsanitize-coverage=inline-8bit-counters

Author: kcc Date: Thu Aug 24 15:40:03 2017 New Revision: 311719 URL: http://llvm.org/viewvc/llvm-project?rev=311719=rev Log: [sanitizer-coverage] document -fsanitize-coverage=pc-table and -fsanitize-coverage=inline-8bit-counters Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified:

r311794 - [sanitizer-coverage] extend fsanitize-coverage=pc-table with flags for every PC

Author: kcc Date: Fri Aug 25 12:29:47 2017 New Revision: 311794 URL: http://llvm.org/viewvc/llvm-project?rev=311794=rev Log: [sanitizer-coverage] extend fsanitize-coverage=pc-table with flags for every PC Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified:

r312346 - [libFuzzer] switch -fsanitize=fuzzer from trace-pc-guard to inline-8bit-counters

Author: kcc Date: Fri Sep 1 11:34:36 2017 New Revision: 312346 URL: http://llvm.org/viewvc/llvm-project?rev=312346=rev Log: [libFuzzer] switch -fsanitize=fuzzer from trace-pc-guard to inline-8bit-counters Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fuzzer.c

r319684 - design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer

Author: kcc Date: Mon Dec 4 12:01:38 2017 New Revision: 319684 URL: http://llvm.org/viewvc/llvm-project?rev=319684=rev Log: design document for a hardware-assisted memory safety (HWAMS) tool, similar to AddressSanitizer Summary: preliminary design document for a hardware-assisted memory safety

Re: Status of CET support? (Re: [PATCH] D40224:...)

On Thu, Dec 14, 2017 at 2:39 AM, Pavel Chupin wrote: > Hi Kostya, > Long time no see. :) > Yey!! Thanks for the update! --kcc > I would estimate that everything (glibc, kernel, loader, simulator) > should be available approx. February 2018 as soon as implementation

r321027 - [hwasan] update the design doc

Author: kcc Date: Mon Dec 18 13:40:07 2017 New Revision: 321027 URL: http://llvm.org/viewvc/llvm-project?rev=321027=rev Log: [hwasan] update the design doc Modified: cfe/trunk/docs/HardwareAssistedAddressSanitizerDesign.rst Modified: cfe/trunk/docs/HardwareAssistedAddressSanitizerDesign.rst

r320168 - [hwasan] typo in docs

Author: kcc Date: Fri Dec 8 10:14:03 2017 New Revision: 320168 URL: http://llvm.org/viewvc/llvm-project?rev=320168=rev Log: [hwasan] typo in docs Modified: cfe/trunk/docs/HardwareAssistedAddressSanitizerDesign.rst Modified: cfe/trunk/docs/HardwareAssistedAddressSanitizerDesign.rst URL:

r320075 - update hwasan docs

Author: kcc Date: Thu Dec 7 11:21:30 2017 New Revision: 320075 URL: http://llvm.org/viewvc/llvm-project?rev=320075=rev Log: update hwasan docs Summary: * use more readable name * document the hwasan attribute Reviewers: eugenis Reviewed By: eugenis Subscribers: llvm-commits, cfe-commits

Re: [clang-tools-extra] r333993 - [clangd] Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

Looks like this broke the clang-fuzzer: https://oss-fuzz-build-logs.storage.googleapis.com/index.html Step #4: /src/llvm/tools/clang/tools/extra/clangd/fuzzer/ClangdFuzzer.cpp:31:17: error: no viable conversion from 'std::istringstream' (aka 'basic_istringstream') to 'std::FILE *' (aka '_IO_FILE

Re: [clang-tools-extra] r333993 - [clangd] Rewrite JSON dispatcher loop using C IO (FILE*) instead of std::istream.

thanks! On Fri, Jun 8, 2018 at 1:31 PM Sam McCall wrote: > Oops, thank you! > r334315 should fix this. > > > > On Fri, Jun 8, 2018 at 9:45 PM Kostya Serebryany wrote: > >> Looks like this broke the clang-fuzzer: >> https://oss-fuzz-build-logs.storage.googleapis.com/index.html >> >> Step #4:

r331238 - [ShadowCallStack] fix the docs

Author: kcc Date: Mon Apr 30 17:15:56 2018 New Revision: 331238 URL: http://llvm.org/viewvc/llvm-project?rev=331238=rev Log: [ShadowCallStack] fix the docs Modified: cfe/trunk/docs/ShadowCallStack.rst Modified: cfe/trunk/docs/ShadowCallStack.rst URL:

r326373 - [hwasan] update the asm snippet in the docs to match the current default behaviour

Author: kcc Date: Wed Feb 28 13:58:19 2018 New Revision: 326373 URL: http://llvm.org/viewvc/llvm-project?rev=326373=rev Log: [hwasan] update the asm snippet in the docs to match the current default behaviour Modified: cfe/trunk/docs/HardwareAssistedAddressSanitizerDesign.rst Modified:

r327471 - [hwasan] update docs

Author: kcc Date: Tue Mar 13 18:55:49 2018 New Revision: 327471 URL: http://llvm.org/viewvc/llvm-project?rev=327471=rev Log: [hwasan] update docs Modified: cfe/trunk/docs/HardwareAssistedAddressSanitizerDesign.rst Modified: cfe/trunk/docs/HardwareAssistedAddressSanitizerDesign.rst URL:

r352818 - [sanitizer-coverage] prune trace-cmp instrumentation for CMP isntructions that feed into the backedge branch. Instrumenting these CMP instructions is almost always useless (and harmful) for

Author: kcc Date: Thu Jan 31 15:43:00 2019 New Revision: 352818 URL: http://llvm.org/viewvc/llvm-project?rev=352818=rev Log: [sanitizer-coverage] prune trace-cmp instrumentation for CMP isntructions that feed into the backedge branch. Instrumenting these CMP instructions is almost always

Re: [clang] 0e3a487 - PR12350: Handle remaining cases permitted by CWG DR 244.

Could this have caused a new ubsan failure? clang/lib/AST/NestedNameSpecifier.cpp:485:23: runtime error: null pointer passed as argument 2, which is declared to never be null http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/38698/steps/check-clang%20ubsan/logs/stdio On Fri,