[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fbd1323e7bf: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast… (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

krisb updated this revision to Diff 554818. krisb added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaCast.cpp

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

krisb created this revision. krisb added reviewers: lebedev.ri, rnk, alexfh. Herald added a subscriber: StephenFan. Herald added a project: All. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Functional-style cast (i.e. a

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

krisb updated this revision to Diff 504608. krisb marked an inline comment as done. krisb added a comment. Apply review comments and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files:

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

krisb marked 2 inline comments as done. krisb added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:698 + // an inlined function: if a local variable has a templated type with + // a function-local type as a template parameter. See PR55680 for

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

krisb updated this revision to Diff 504605. krisb added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004 Files: clang/test/CodeGenCXX/debug-info-namespace.cpp

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb updated this revision to Diff 504602. krisb added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 Files: clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb marked an inline comment as done. krisb added inline comments. Comment at: llvm/include/llvm/IR/DIBuilder.h:76 -/// Each subprogram's preserved labels. -DenseMap> PreservedLabels; +SmallVectorImpl & +getSubprogramNodesTrackingVector(const DIScope *S) {

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

krisb added inline comments. Comment at: llvm/test/DebugInfo/Generic/split-dwarf-local-import3.ll:17-36 +; CHECK: DW_TAG_subprogram +; CHECK: DW_AT_name("foo") +; CHECK: DW_TAG_imported_declaration +; CHECK: NULL + +; CHECK: DW_TAG_base_type +; CHECK:

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

krisb updated this revision to Diff 499848. krisb marked 2 inline comments as done. krisb added a comment. Apply review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004 Files:

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb added a comment. @jmmartinez thank you for looking at this! Comment at: llvm/lib/IR/DIBuilder.cpp:789 + return createLocalVariable( + VMContext, getSubprogramNodesTrackingVector(Scope), Scope, Name, + /* ArgNo */ 0, File, LineNo, Ty, AlwaysPreserve, Flags,

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb abandoned this revision. krisb added a comment. Abandon in favor of https://discourse.llvm.org/t/rfc-dwarfdebug-fix-and-improve-handling-imported-entities-types-and-static-local-in-subprogram-and-lexical-block-scopes/68544. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (5/7)

krisb created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez. krisb added projects: LLVM, debug-info. krisb published this revision for review. Herald added a project: clang.

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

krisb created this revision. Herald added subscribers: ormris, steven_wu, hiraditya. Herald added a reviewer: sscalpone. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez, ellis. krisb added projects: LLVM, debug-info. krisb

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

krisb created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. krisb edited the summary of this revision. krisb added reviewers: dblaikie, jmmartinez. krisb added projects: LLVM, debug-info. krisb published this revision for review. Herald added a project: clang.

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ecb2b8ef6be: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

krisb added a comment. In D137067#3896524 , @dblaikie wrote: > Test case can be simplified a bit further: Thank you! > but otherwise I'm OK with this - I don't /fully/ understand it, but it sounds > plausible enough. (if you have time, I wouldn't mind

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

krisb updated this revision to Diff 472079. krisb added a comment. Apply review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137067/new/ https://reviews.llvm.org/D137067 Files:

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

krisb created this revision. krisb added reviewers: ellis, aprantl, dblaikie. Herald added a subscriber: hiraditya. Herald added a project: All. krisb requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Having AllEnumtypes to

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. In D125693#3653631 , @dblaikie wrote: > In D125693#3648942 , @krisb wrote: > >> In D125693#3644029 , @dblaikie >> wrote: >> >>> In D125693#3641742

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. In D125693#3644029 , @dblaikie wrote: > In D125693#3641742 , @krisb wrote: > >> @dblaikie, could you please take a look at this and/or D113741 >> ? Do you

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. @dblaikie, could you please take a look at this and/or D113741 ? Do you see any ways to proceed? Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8*

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void,

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added inline comments. Comment at: llvm/test/Instrumentation/InstrProfiling/debug-info-correlate.ll:23 call void @llvm.instrprof.increment(i8* getelementptr inbounds ([3 x i8], [3 x i8]* @__profn_foo, i32 0, i32 0), i64 12345678, i32 2, i32 0) - ret void + ret void,

[PATCH] D125693: [DebugInfo] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125693/new/ https://reviews.llvm.org/D125693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D125693: [DebugInfo][WIP] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. Tested the whole patchset with various combinations of - opt levels (O0, O2 , O3 , ThinLTO, FullLTO), - debug info options (-fdebug-types-section, -gline-tables-only,

[PATCH] D125695: [clang][DebugInfo] Allow function-local type-like entities to be scoped within a lexical block (5/5)

krisb updated this revision to Diff 434541. krisb marked an inline comment as done. krisb added a comment. Applied review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125695/new/ https://reviews.llvm.org/D125695 Files:

[PATCH] D125693: [DebugInfo][WIP] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. Thank you, @asavonic for your comments! I've added some more details about the issues this is going to fix, hope it'll help to review the patchset. In D125693#3523278 , @asavonic wrote: > Thanks a lot for the patch! It would be

[PATCH] D124982: [clang][OpenMP][DebugInfo] Debug support for variables in containing scope of OMP constructs

krisb added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:689 auto ScopeDIE = DIE::get(DIEValueAllocator, dwarf::DW_TAG_lexical_block); + insertDIE(Scope->getScopeNode(), ScopeDIE); if (Scope->isAbstractScope()) In case of

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb abandoned this revision. krisb added a comment. Herald added a project: All. Split on two: D125694 and D125695 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/

[PATCH] D125695: [clang][DebugInfo] Allow function-local type-like entities to be scoped within a lexical block (5/5)

krisb created this revision. krisb added reviewers: dblaikie, aprantl, probinson. Herald added a project: All. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a part from D113743 split to

[PATCH] D125694: [clang][DebugInfo] Allow function-local statics to be scoped within a lexical block (4/5)

krisb created this revision. krisb added reviewers: dblaikie, aprantl, probinson. Herald added a project: All. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a part from D113743 split to

[PATCH] D125693: [DebugInfo][WIP] Support types, imports and static locals declared in a lexical block (3/5)

krisb added a comment. Mark this and D125691 as WIP since I'm still testing the approach on various combinations of debug info and optimization options (O0, O3 , thinlto, split-dwarf, split-dwarf-inlining,

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

This revision was automatically updated to reflect the committed changes. Closed by commit rGafbe54f2feb0: [clang] Fix wrong -Wunused-local-typedef warning within a template function (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added inline comments. Comment at: clang/test/SemaCXX/warn-unused-local-typedef.cpp:246 + typedef int Int; // no-diag + typedef char Char; // expected-warning {{unused typedef 'Char'}} + Int m; krisb wrote: > Quuxplusone wrote: > > I haven't

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added inline comments. Comment at: clang/test/SemaCXX/warn-unused-local-typedef.cpp:246 + typedef int Int; // no-diag + typedef char Char; // expected-warning {{unused typedef 'Char'}} + Int m; Quuxplusone wrote: > I haven't tried to

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. Herald added a project: All. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/D114382 ___ cfe-commits mailing list

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb added a comment. @tra thank you for looking at this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 ___ cfe-commits mailing list

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57aaab3b17f0: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 - i32) (authored by krisb). Changed prior to commit:

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb updated this revision to Diff 411416. krisb added a comment. Fix a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 Files: clang/include/clang/Basic/BuiltinsNVPTX.def

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb updated this revision to Diff 411341. krisb added a comment. Add SM_70 requirement for 'match' builtins. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120499/new/ https://reviews.llvm.org/D120499 Files:

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. In D113743#3343481 , @dblaikie wrote: > In D113743#3177437 , @krisb wrote: > >> In D113743#3175301 , @dblaikie >> wrote: >> >>> Not super

[PATCH] D120499: [NVPTX] Fix nvvm.match.sync*.i64 intrinsics return type (i64 -> i32)

krisb created this revision. krisb added a reviewer: tra. Herald added subscribers: asavonic, hiraditya. krisb requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. Herald added projects: clang, LLVM. NVVM IR specification defines them with i32 return

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb updated this revision to Diff 411137. krisb added a comment. Rebase on top of 'main'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ https://reviews.llvm.org/D113743 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/D114382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. @rtrieu, thank you for looking at this! Do you have any comments about the rest of the patch? Do you think it makes sense? Comment at: clang/test/Modules/odr_hash.cpp:4288 S s; +// expected-error@first.h:* {{'ParameterTest::S::Foo' has different

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. In D113743#3175301 , @dblaikie wrote: > Not super surprising that lldb might not be able to deal with DWARF in this > shape - is LLDB support important to you/something you plan to work on for > this DWARF? Otherwise we might

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. In D113743#3173981 , @JDevlieghere wrote: > Hey Kristina, this broke TestSetData.py on GreenDragon: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/39089/ > > Since the bot has been red for several hours I went ahead

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

This revision was automatically updated to reflect the committed changes. Closed by commit rGe403f4fdc883: [clang][DebugInfo] Allow function-local statics and types to be scoped within a… (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ https://reviews.llvm.org/D113743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114446: [clang] Fix wrong -Wunused-local-typedef warning if use is a dependent qialified identifier

krisb updated this revision to Diff 391312. krisb added a comment. Simplified diagnostic condition in TemplateDeclInstantiator::InstantiateTypedefNameDecl(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114446/new/

[PATCH] D108301: [MSP430][Clang] Update hard-coded MCU data

krisb added inline comments. Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:223-224 + MCUData LoadedMCUData; + if (const Arg *MCUArg = Args.getLastArg(options::OPT_mmcu_EQ)) +LoadedMCUData = getMCUData(MCUArg->getValue()); + It might be worth moving

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114382/new/ https://reviews.llvm.org/D114382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114446: [clang] Fix wrong -Wunused-local-typedef warning if use is a dependent qialified identifier

krisb created this revision. krisb added reviewers: thakis, rtrieu, rsmith. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Attempt to fix Tom Smeding's example from https://bugs.llvm.org/show_bug.cgi?id=24883. Given the case like

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added inline comments. Comment at: clang/test/Modules/odr_hash.cpp:4288 S s; +// expected-error@first.h:* {{'ParameterTest::S::Foo' has different definitions in different modules; definition in module 'FirstModule' first difference is 1st parameter with name ''}}

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb created this revision. krisb added reviewers: thakis, rtrieu, rsmith. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partially fixes PR24883. The patch sets Reference bit while instantiating a typedef if it previously was

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb added a comment. @aprantl thank you for taking a look at this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ https://reviews.llvm.org/D113743 ___ cfe-commits mailing list

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb updated this revision to Diff 387956. krisb marked an inline comment as done. krisb added a comment. Applied the comment & silence clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113743/new/ https://reviews.llvm.org/D113743

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb abandoned this revision. krisb added a comment. Abandon in favor of https://reviews.llvm.org/D113741. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109703/new/ https://reviews.llvm.org/D109703 ___

[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

krisb created this revision. krisb added reviewers: dblaikie, aprantl, probinson. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is almost a reincarnation of https://reviews.llvm.org/D15977 originally implemented by Amjad

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb added a comment. @ellis I'd appreciate if you go ahead and fix the issues with inlined functions. Sorry for interrupting you in D108492 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109703/new/

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb added a comment. @dblaikie yeah, the problem(s) seemed easier and smaller :( Basically, we have two issues with local scopes here: (1) function-scoped entities like static variables, type definitions/typedefs, etc have incorrect (empty) parent DIE if the function containing them was

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb added a comment. In D109703#2998155 , @ellis wrote: > I've added this to the added test case. > > !18 = !DIImportedEntity(tag: DW_TAG_imported_declaration, scope: !4, > entity: !19, line: 122) > !19 = !DIGlobalVariable(name:

[PATCH] D109703: [DebugInfo] Fix scope for local static variables

krisb created this revision. krisb added reviewers: dblaikie, probinson. Herald added a subscriber: hiraditya. krisb requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This fixes https://bugs.llvm.org/show_bug.cgi?id=44695

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb accepted this revision. krisb added a comment. This revision is now accepted and ready to land. @aorlov, thank you! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3080 +// For instance this marked as unavailable: +//class __attribute((unavailable)) UnavailableClass;` +auto RemoveAccessCheckingDiagnostics = [, this]() { aorlov wrote: >

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added a comment. Thank you! It looks more consistent now. Comment at: clang/lib/Parse/ParseDecl.cpp:3080 +// For instance this marked as unavailable: +//class __attribute((unavailable)) UnavailableClass;` +auto RemoveAccessCheckingDiagnostics = [, this]()

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added a comment. Do we still need the following tests: - clang/test/CXX/temp/temp.spec/temp.explicit/p11.cpp - clang/test/CXX/temp/temp.spec/temp.explicit/p12.cpp ? Comment at: clang/test/CXX/temp/temp.spec/func.spec.cpp:105 +template void func10(A::B, int x) {}

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

krisb added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:3001 DS.getStorageClassSpec() == clang::DeclSpec::SCS_typedef && -!DS.hasTypeSpecifier() && GetLookAheadToken(1).is(tok::less)) +!DS.hasTypeSpecifier() && NextToken().is(tok::less))

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04ea680a8ccc: [cmake] Fix build of attribute plugin example on Windows (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D86091: [cmake] Fix build of attribute plugin example on Windows

krisb created this revision. krisb added a reviewer: john.brawn. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. krisb requested review of this revision. Seems '${cmake_2_8_12_PRIVATE}' was removed long time ago, so it should be just PRIVATE keyword here.

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad4ab81dccaa: [clang][cmake] Force CMAKE_LINKER for multistage build in case of… (authored by krisb). Repository: rG LLVM Github Monorepo

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb marked an inline comment as done. krisb added a comment. @phosek thank you for reviewing this! Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb updated this revision to Diff 280835. krisb added a comment. Addressed the review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80873/new/ https://reviews.llvm.org/D80873 Files: clang/CMakeLists.txt

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80873/new/ https://reviews.llvm.org/D80873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

krisb accepted this revision. krisb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dang. Sorry for the delays in response, busy days. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb marked an inline comment as done. krisb added inline comments. Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb updated this revision to Diff 277806. krisb edited the summary of this revision. krisb added a comment. Changed MSVC -> WIN32 check and simplified the warning fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80873/new/

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

krisb added a comment. Thank you! LGTM, except some minor nits below. Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:154 + SmallString<128> MultilibInclude(GCCInstallation.getInstallPath()); + llvm::sys::path::append(MultilibInclude, "include"); I'd

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v8.3.1

krisb added inline comments. Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:155 SmallString<128> Dir(computeSysRoot()); llvm::sys::path::append(Dir, "include"); addSystemInclude(DriverArgs, CC1Args, Dir.str()); Seems the driver stops adding

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80873/new/ https://reviews.llvm.org/D80873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb created this revision. krisb added reviewers: phosek, thakis, russell.gallop. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. (I'm trying to get a bootstrap self-build on Windows, where lld is used as a linker for the stage2.) I assume

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb added a comment. @dnsampaio, many thanks for committing this! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 219670. krisb added a comment. Rebased Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/ARM.cpp

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 218388. krisb marked an inline comment as done. krisb added a comment. Applied the comment: enable 'sha2' and 'aes' only for armv8 A profile, report warning and disable 'crypto' for other archs. Add more tests. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb added a comment. I see. But this doesn't seem like a valid case, does it? Shouldn't we somehow diagnose it to not to silently ignore user-specified options? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb marked an inline comment as done. krisb added a comment. @dnsampaio thanks for reviewing this! Could I ask you to commit the patch (since I don't have commit access yet)? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 218076. krisb edited the summary of this revision. krisb added a comment. Added 'CPU.empty()' check back. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 Files:

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb marked 2 inline comments as done. krisb added a comment. @dnsampaio, thanks! This is definitely better. I also added ARMV8_5A as a test case. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 217819. krisb added a comment. Applied the comment & rebased. Also changed the patch to take into account only the latest 'crypto' in the Features vector, to avoid enabling 'sha2' and 'aes' when 'crypto' was finally disabled. Repository: rC Clang CHANGES

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb added a comment. @dnsampaio, thanks, this looks better. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb updated this revision to Diff 215394. krisb added a comment. Applied the comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66018/new/ https://reviews.llvm.org/D66018 Files: lib/Driver/ToolChains/Arch/ARM.cpp test/Driver/arm-features.c Index:

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

krisb created this revision. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. krisb added reviewers: SjoerdMeijer, ostannard, labrinea, dnsampaio. '+crypto' means '+aes' and '+sha2' for arch >= ARMv8 when they were not disabled explicitly.

[PATCH] D56925: Do not use frame pointer by default for MSP430

krisb added inline comments. Comment at: test/CodeGen/msp430-fp-elim.c:16 +{ + asm volatile ("calla r4"); +} This test as it is will fail after integrated assembler will be turned on by default (see https://reviews.llvm.org/D56787). Since `calla`

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb added a comment. @aaron.ballman yes and yes. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57012/new/ https://reviews.llvm.org/D57012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb added a comment. @aaron.ballman Thanks! Could I ask you to commit the patch? I don't have commit access yet. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57012/new/ https://reviews.llvm.org/D57012 ___

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb updated this revision to Diff 182852. krisb added a comment. Applied the comment. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57012/new/ https://reviews.llvm.org/D57012 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp

[PATCH] D57015: [MSP430] Ajust f32/f64 alignment according to MSP430 EABI

krisb created this revision. krisb added a reviewer: asl. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D57015 Files: lib/Basic/Targets/MSP430.h test/CodeGen/msp430-align.c test/Preprocessor/init.c Index: test/Preprocessor/init.c

[PATCH] D57012: Merge similar target diagnostics for interrupt attribute into one. NFC

krisb created this revision. krisb added reviewers: asl, aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D57012 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDeclAttr.cpp Index: lib/Sema/SemaDeclAttr.cpp

  1   2   >