[PATCH] D141961: [clang][lex] Pass hash location to more PPCallbacks methods

KyleFromKitware created this revision. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". Herald added subscribers: kadircet, carlosgalvezp, shchenz, arphaman, kbarton, nemanjai. Herald added a reviewer: ributzka. Herald added a reviewer: njames93.

[PATCH] D141961: [clang][lex] Pass hash location to more PPCallbacks methods

KyleFromKitware added a comment. WIP - currently updating the tests for `pp-trace` and in the process debugging an issue with the location of the `#endif` hash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141961/new/

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang-tools-extra. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". KyleFromKitware added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun.

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware added a comment. In D142123#4066706 , @KyleFromKitware wrote: > The only way to avoid this is if we overhaul the existing `HeaderGuardCheck` > and make its naming convention configurable by a configuration option as > opposed to having

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware added a comment. In D142123#4066676 , @aaron.ballman wrote: > It doesn't have to -- for example, we can name the guard based on the path to > the header. e.g., `foo/include/bar/baz.h` could use `FOO_INCLUDE_BAR_BAZ_H` > as the header

[PATCH] D142121: [clang-tidy] Refactor common functionality of HeaderGuardCheck into HeaderGuardBase

KyleFromKitware added a comment. Yes, this is for D142123 . However, even if that doesn't land, I'd still like to land this. We use the code from D142123 in CMake's CI system, and getting it to work without this change

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware added a comment. In D142123#4066460 , @aaron.ballman wrote: > In D142123#4066447 , @lebedev.ri > wrote: > >> In D142123#4066351 , @njames93 >> wrote:

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware added a comment. In D142123#4066351 , @njames93 wrote: > and peoples eagerness to blindly enable all checks (or all checks from a > module) Perhaps there's some way we can have it disabled by default and not enabled unless they

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware added a comment. Basically, anything that extends `HeaderGuardCheck` (or `HeaderGuardBase` from D142121 ) is really just a fancy configuration option, rather than a separate check, and should be treated as such. My proposal is this: 1. Create

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware added a comment. In terms of a "generic check", there is already the `HeaderGuardCheck`, but that has to be extended to be specific to the project's naming convention. And I don't think there can be a generic check that converts `#pragma once` to a header guard - when it adds

[PATCH] D142121: [clang-tidy] Refactor common functionality of HeaderGuardCheck into HeaderGuardBase

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang-tools-extra. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". KyleFromKitware added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun.

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 490534. KyleFromKitware added a comment. Added documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware added a comment. We have this check in a custom clang-tidy module that runs on CMake's CI system. Other people have also sought out such a check, and I

[PATCH] D142030: [pp-trace] Print HashLoc parameter

KyleFromKitware created this revision. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". Herald added subscribers: kbarton, nemanjai. Herald added a project: All. KyleFromKitware requested review of this revision. Herald added a project:

[PATCH] D141961: [clang][lex] Pass hash location to more PPCallbacks methods

KyleFromKitware updated this revision to Diff 490160. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141961/new/ https://reviews.llvm.org/D141961 Files: clang-tools-extra/clang-include-fixer/find-all-symbols/FindAllMacros.cpp

[PATCH] D142030: [pp-trace] Print HashLoc/Introducer parameter

KyleFromKitware updated this revision to Diff 491747. KyleFromKitware retitled this revision from "[pp-trace] Print HashLoc parameter" to "[pp-trace] Print HashLoc/Introducer parameter". KyleFromKitware added a comment. Printed Introducer parameter in Pragma methods. CHANGES SINCE LAST ACTION

[PATCH] D142470: [clang][lex] Add PragmaOnce callback to PPCallbacks

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". KyleFromKitware added a project: clang. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project:

[PATCH] D142471: [pp-trace] Add PragmaOnce callback

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang-tools-extra. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". KyleFromKitware added a project: clang-tools-extra. Herald added subscribers: kbarton, nemanjai. Herald

[PATCH] D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang. KyleFromKitware created this object with edit policy "Only User: KyleFromKitware (Kyle Edwards)". KyleFromKitware added a project: clang. Herald added subscribers: carlosgalvezp, shchenz, kbarton, nemanjai. Herald

[PATCH] D142030: [pp-trace] Print HashLoc/Introducer parameter

KyleFromKitware updated this revision to Diff 491774. KyleFromKitware added a comment. Rebased onto `main` for D141000 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files:

[PATCH] D142471: [pp-trace] Add PragmaOnce callback

KyleFromKitware updated this revision to Diff 491776. KyleFromKitware added a comment. Rebased onto `main` for D141000 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142471/new/ https://reviews.llvm.org/D142471 Files:

[PATCH] D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters

KyleFromKitware updated this revision to Diff 491772. KyleFromKitware added a comment. Rebased onto `main` for D141000 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142465/new/ https://reviews.llvm.org/D142465 Files:

[PATCH] D142470: [clang][lex] Add PragmaOnce callback to PPCallbacks

KyleFromKitware updated this revision to Diff 491775. KyleFromKitware added a comment. Rebased onto `main` for D141000 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142470/new/ https://reviews.llvm.org/D142470 Files:

[PATCH] D142030: [pp-trace] Print HashLoc/Introducer parameter

KyleFromKitware updated this revision to Diff 492575. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace.rst clang-tools-extra/pp-trace/PPCallbacksTracker.cpp

[PATCH] D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters

KyleFromKitware updated this revision to Diff 492573. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142465/new/ https://reviews.llvm.org/D142465 Files: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h

[PATCH] D142470: [clang][lex] Add PragmaOnce callback to PPCallbacks

KyleFromKitware updated this revision to Diff 492576. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142470/new/ https://reviews.llvm.org/D142470 Files: clang/include/clang/Lex/PPCallbacks.h clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/Pragma.cpp Index:

[PATCH] D142471: [pp-trace] Add PragmaOnce callback

KyleFromKitware updated this revision to Diff 492577. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142471/new/ https://reviews.llvm.org/D142471 Files: clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/pp-trace/PPCallbacksTracker.h

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang-tools-extra. KyleFromKitware added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: sscalpone. Herald added a reviewer: njames93. Herald added a project: All.

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 492579. KyleFromKitware retitled this revision from "[clang-tidy] Add check to suggest use of #pragma once" to "[clang-tidy] Add header guard style to suggest use of #pragma once". KyleFromKitware added a comment. Refactored to use HeaderGuardStyle.

[PATCH] D142121: [clang-tidy] Refactor common functionality of HeaderGuardCheck into HeaderGuardBase

KyleFromKitware abandoned this revision. KyleFromKitware added a comment. Closed in favor of D142673 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142121/new/ https://reviews.llvm.org/D142121

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware updated this revision to Diff 492633. KyleFromKitware changed the edit policy from "All Users" to "Only User: KyleFromKitware (Kyle Edwards)". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142673/new/ https://reviews.llvm.org/D142673 Files:

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 492634. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-extra/clang-tidy/readability/PragmaOnceHeaderGuardStyle.cpp

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware added a comment. In D142673#4086018 , @carlosgalvezp wrote: > Note: I do not have possibility to add code comments - is there some too > strict permissions set for this patch? It has not happened to other patches. I accidentally set

[PATCH] D142030: [pp-trace] Print HashLoc parameter

KyleFromKitware updated this revision to Diff 490201. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace.rst clang-tools-extra/pp-trace/PPCallbacksTracker.cpp

[PATCH] D142030: [pp-trace] Print HashLoc parameter

KyleFromKitware updated this revision to Diff 490206. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace.rst clang-tools-extra/pp-trace/PPCallbacksTracker.cpp

[PATCH] D142123: [clang-tidy] Add check to suggest use of #pragma once

KyleFromKitware added a comment. In D142123#4071099 , @njames93 wrote: > Can you just elaborate on what the registry is used for? Is the plan to > support potentially dynamically loading `HeaderGuardStyle` classes. Yes. > If thats the case, Then I'd

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware updated this revision to Diff 493681. KyleFromKitware added a comment. Fixed crash when warning doesn't have associated location. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142991/new/ https://reviews.llvm.org/D142991 Files:

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang-tools-extra. KyleFromKitware added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. KyleFromKitware requested review of

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware created this revision. KyleFromKitware added a reviewer: clang. KyleFromKitware added a project: clang. Herald added a project: All. KyleFromKitware requested review of this revision. Herald added a subscriber: cfe-commits. And fix a few corner cases in which it returns the wrong

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware updated this revision to Diff 493969. KyleFromKitware added a comment. Added tests and fixed assertion error in release build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142991/new/ https://reviews.llvm.org/D142991 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware updated this revision to Diff 494031. KyleFromKitware added a comment. Rebased onto D143099 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142991/new/ https://reviews.llvm.org/D142991 Files:

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware updated this revision to Diff 494036. KyleFromKitware added a comment. Fixed formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143099/new/ https://reviews.llvm.org/D143099 Files: clang/include/clang/Lex/Lexer.h clang/lib/Lex/Lexer.cpp

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware added a comment. In D143099#4233651 , @cor3ntin wrote: > Sure. Let me know what name and email address you would like used for the > patch attribution! Thanks Kyle Edwards Is there some way I can set this in my profile settings so

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware added inline comments. Comment at: clang/unittests/Lex/LexerTest.cpp:673 + EXPECT_EQ(FindBeginningOfLineOffset("int func1();\nint func2();", 13), 13); + EXPECT_EQ(FindBeginningOfLineOffset("int func1();\nint func2();", 12), 13); +

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware added a comment. In D143099#4233623 , @cor3ntin wrote: > @KyleFromKitware oups, this fell under the cracks. I think I'm happy with is > as-is, do you need help landing it? Yes, please. CHANGES SINCE LAST ACTION

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ReadabilityModuleTest.cpp:569-571 +runPragmaOnceCheck("#ifndef BOTH_H\n" + "#define BOTH_H\n" + "#pragma once\n"

[PATCH] D142030: [pp-trace] Print HashLoc/Introducer parameter

KyleFromKitware updated this revision to Diff 494646. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142030/new/ https://reviews.llvm.org/D142030 Files: clang-tools-extra/docs/pp-trace.rst clang-tools-extra/pp-trace/PPCallbacksTracker.cpp

[PATCH] D142470: [clang][lex] Add PragmaOnce callback to PPCallbacks

KyleFromKitware updated this revision to Diff 494647. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142470/new/ https://reviews.llvm.org/D142470 Files: clang/include/clang/Lex/PPCallbacks.h clang/include/clang/Lex/Preprocessor.h clang/lib/Lex/Pragma.cpp Index:

[PATCH] D142471: [pp-trace] Add PragmaOnce callback

KyleFromKitware updated this revision to Diff 494648. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142471/new/ https://reviews.llvm.org/D142471 Files: clang-tools-extra/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/pp-trace/PPCallbacksTracker.h

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware updated this revision to Diff 494649. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142673/new/ https://reviews.llvm.org/D142673 Files: clang-tools-extra/clang-tidy/ClangTidyModule.h clang-tools-extra/clang-tidy/llvm/CMakeLists.txt

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 494650. KyleFromKitware added a comment. Updated with review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware added a comment. @aaron.ballman @njames93 could you guys please take another look at this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 ___ cfe-commits mailing list

[PATCH] D142465: [clang][lex] Consolidate PPCallbacks::PragmaDirective parameters

KyleFromKitware updated this revision to Diff 494644. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142465/new/ https://reviews.llvm.org/D142465 Files: clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.cpp clang-tools-extra/clang-tidy/ExpandModularHeadersPPCallbacks.h

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 494653. KyleFromKitware added a comment. Removed comma from documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware updated this revision to Diff 494652. KyleFromKitware added a comment. Updated documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt

[PATCH] D142123: [clang-tidy] Add header guard style to suggest use of #pragma once

KyleFromKitware added a comment. CI on all seven commits in this stack looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142123/new/ https://reviews.llvm.org/D142123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D142673: [clang-tidy] Refactor HeaderGuardCheck to add HeaderGuardStyle

KyleFromKitware updated this revision to Diff 494675. KyleFromKitware added a comment. Added virtual destructor to `HeaderGuardStyle`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142673/new/ https://reviews.llvm.org/D142673 Files: clang-tools-extra/clang-tidy/ClangTidyModule.h

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware added a comment. Though I did find that it inserted more than one `NOLINT` comment for a templated function, probably due to multiple warnings being issued for the same violation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142991/new/

[PATCH] D142991: [clang-tidy] Add --fix-mode and --nolint-prefix options

KyleFromKitware added a comment. I just tried this out on a somewhat larger scale - I built all of CMake with this flag enabled, and it found a number of clang-tidy violations and added `NOLINT` comments to silence them. Worked like a charm. CHANGES SINCE LAST ACTION

[PATCH] D143099: [clang][lex] Expose findBeginningOfLine()

KyleFromKitware added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:493-494 /// Returns the pointer that points to the beginning of line that contains /// the given offset, or null if the offset if invalid. +const char *Lexer::findBeginningOfLine(StringRef Buffer,