[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 89331. xiangzhai added a comment. Hi Anna, I added **svalBinMulOp** to take BO_Mul evalBinOp for g_malloc_n's two arguments: CE->getArg(0) and CE->getArg(1), so it does **NOT** need to change **MallocMemAux** any more, but just use it in this way:

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 89333. xiangzhai added a comment. Fixed the confused State->getSVal(CE->getArg(1), C.getLocationContext()); with CE->getArg(1) issue. Repository: rL LLVM https://reviews.llvm.org/D28348 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai marked 3 inline comments as done. xiangzhai added a comment. Hi Anna, Thank you so much for the review! I will try to implement extend MallocMemAux and ReallocMem in the follow up patch. Regards, Leslie Zhai Comment at:

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai added a comment. Hi Anna, I am not clear why need to calculate the precise allocated size? for example: void *ptr = malloc(size); void *gptr = g_malloc_n(n_blocks, n_block_bytes); Memory-leak and Use-after-free issues' MallocChecker need the ***size*** or ***n_blocks*** x

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 89460. xiangzhai added a comment. Hi Anna, Thanks for your suggest! Firstly I uploaded Glib-MallocChecker-single-size-value.patch for code review, if submitted to UPSTREAM, then upload another one, correct? Regards, Leslie Zhai Repository: rL LLVM

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai added a comment. Hi Anna, Thanks for your review! > The information generated by this checker is used for array bounds checking. > For example, see https://reviews.llvm.org/D24307 I will read carefully about that ;-) > This patch looks good. Do you have commit access or should I

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 89825. xiangzhai added a comment. Hi Anna, Thanks for your review! I updated the Glib-MallocChecker-single-size-value.patch to use **zeroVal** for **g_malloc0** and **g_try_malloc0** and Yes, I refer CallocMem to implement **SValBinMulOp** in the

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 83758. xiangzhai marked 2 inline comments as done. xiangzhai added a comment. make II_g_*malloc*_n sense Repository: rL LLVM https://reviews.llvm.org/D28348 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index:

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 84209. xiangzhai added a comment. Hi Anna, Thanks for your review! I process them (for example, g_malloc_n, take a different number of arguments) separately. And I run the testcases for Analysis/malloc.c and Analysis/gmalloc.c Regards, Leslie Zhai

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 83587. xiangzhai added a comment. Hi Anna, Thanks for your review! I use: svn diff --diff-cmd=diff -x -U99 lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c > Glib-MallocChecker.patch to generate the patch, please check is it

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

xiangzhai updated this revision to Diff 83339. xiangzhai added a comment. Hi Anna, Thanks for your review! I resubmit the patch with context, please check is it correct, thanks a lot! And I add testcase: test/Analysis/gmalloc.c Repository: rL LLVM https://reviews.llvm.org/D28348 Files:

[PATCH] D16171: Warning on redeclaring with a conflicting asm label

xiangzhai added a comment. LLVMBUG-31017 https://llvm.org/bugs/show_bug.cgi?id=31017#c4 In https://reviews.llvm.org/D16171#540261, @phabricss wrote: > On 09/12/2016 01:26 PM, Nick Lewycky wrote: > > > Firstly, I thought glibc had applied a patch to fix this bug? As in, the > > error is correct

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

xiangzhai added a comment. Hi Raphael, Thanks for your reply! > regarding performance: Last time I checked we spend most of the time on the > verification of the hash values. We can do some tricks to make this faster > (like delaying the verification to the end of the constraints where we

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

xiangzhai added a comment. Hi Raphael, Thanks for your awesome job! I have read about the slide of "LLVM: built-in scalable code clone detection based on semantic analysis", and sent email to Shamil for asking "Is Code clone

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

xiangzhai added a comment. Hi Raphael, Congratulate the patch was accepted! > Well this patch won't change a lot with the false-positives or performance > (it's more refactoring) :) So may I Teach CloneDetection about Qt Meta-Object Compiler and filter other

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai created this revision. Hi LLVM developers, As Anna mentioned: > One idea is to check that we do not pass a pointer that is known to be NULL > to functions that are known to dereference pointers such as memcpy. There is > a checker that determines if a null pointer could be

[PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

xiangzhai added a comment. Hi Raphael, Then I will rebase my patch https://reviews.llvm.org/D31320 please review it when you have free time, thanks a lot! Regards, Leslie Zhai https://reviews.llvm.org/D23418 ___ cfe-commits mailing list

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Daniel, Thanks for your review! Sorry I am not available until this Friday, then I will update my patch. Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list

[PATCH] D29827: [AVR] Add -mmcu option to the driver

xiangzhai added a comment. ping :) https://reviews.llvm.org/D29827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29827: [AVR] Add -mmcu option to the driver

xiangzhai accepted this revision. xiangzhai added a comment. This revision is now accepted and ready to land. Hi Peter, Thanks for your rebase! LGTM! > Based on the context, the change from lib/Driver/Tools.cpp -> > lib/Driver/ToolChains/CommonArgs.cpp seems most appropriate (Gnu.cpp seems to

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 96084. xiangzhai added a comment. Further reduce redundant code. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

xiangzhai updated this revision to Diff 96088. xiangzhai added a comment. Hi Richard, Thanks for your review! I updated my patch as you suggested: add some test coverage for these triples, and I run `make check-clang-driver` for verification, please point out my fault, thanks! Regards,

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai added a comment. Never mind :) Repository: rL LLVM https://reviews.llvm.org/D30771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 96101. xiangzhai added a comment. Further reduce redundant code. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai updated this revision to Diff 95273. xiangzhai added a comment. Hi All, I have updated my patch as your suggestion, please review it, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Artem, Thanks for your review! I will update my patch tomorrow :) Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:337 + const Expr *BlockBytes, + ProgramStateRef State); static ProgramStateRef CallocMem(CheckerContext , const

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi All, Thanks for your review! I will update my patch tomorrow! Almost 4+ days no see, I miss you :) Regards, Leslie Zhaii Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list

[PATCH] D29827: [AVR] Add -mmcu option to the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL300818: [AVR] Add -mmcu option to the driver (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D29827?vs=95707=95879#toc Repository: rL LLVM https://reviews.llvm.org/D29827

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 95880. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c === ---

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai updated this revision to Diff 95690. xiangzhai added a comment. Hi Artem, > so you're doing the binding thing now? No! it only works for `RetVal` for example `int *ret = memset(x, 0, sizeof(int));`, please see my testcase: void foo() { int *x = malloc(sizeof(int)); int

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 95894. xiangzhai added a comment. `SValBinMulOp` -> `evalMulForBufferSize` Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai marked an inline comment as done. xiangzhai added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:788 +SVal MallocChecker::SValBinMulOp(CheckerContext , const Expr *Blocks, + const Expr *BlockBytes,

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

xiangzhai created this revision. Hi LLVM developers, I am a Linux engineer of operating system department at iSOFT , I want to add iSOFTLinux to GNU ToolChains X86Triple, please review my patch, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 95887. xiangzhai added a comment. Hi Artem, Thanks for your review! I updated my patch, please review it. Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai added a comment. Hi Daniel, I respect you! the father of cppcheck and KDE's buildbot use cppcheck for example Static Analysis K3B thanks for your great job! Regards, Leslie Zhai

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 95874. xiangzhai added a comment. Hi David, Thanks for your review! I updated my patch as you suggested! Please review it, thanks a lot! but I argue that: > I have the feeling this should be renamed. Since its purpose is to calculate > the total size

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai updated this revision to Diff 96344. xiangzhai added a comment. Hi Artem, Because `memcpy` checked NULL pointer dereference for `src`: state = checkNonNull(C, state, Source, srcVal); ... so such testcase can not point out my fault: void f15 () {

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Artem, If it looks good to you, I want to try commit by myself for testing commit, thanks! Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 95684. xiangzhai added a subscriber: cfe-commits. xiangzhai added a comment. Hi Artem, I updated my patch as you suggested: never using `Arg1Val` after `TotalSize` is computed, on all branches. please review it, thanks a lot! Regards, Leslie Zhai

[PATCH] D29827: [AVR] Add -mmcu option to the driver

xiangzhai added a comment. Hi Jonathan, Peter might do not have commit access, please commit it on his behalf, thanks a lot! Regards, Leslie Zhai https://reviews.llvm.org/D29827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

xiangzhai added a comment. Hi Saleem, Thanks for pointing out my fault, I will update my patch to add, for example: -L[[SYSROOT]]/usr/lib/gcc/x86_64-isoft-linux/6.3.1 to the testcase. Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D32269

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai added a comment. Hi Artem, Could I commit this patch? thanks! Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D30771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL301384: [analyzer] Teach the MallocChecker about Glib API for two arguments (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D30771?vs=96101=96670#toc Repository: rL LLVM

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Artem, Thank you so much! you are my mentor teach me patiently and carefully, I will update my patch tomorrow, good night from my timezone:) Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868

[PATCH] D32269: [Driver] Add iSOFTLinux to GNU ToolChains X86Triple

xiangzhai updated this revision to Diff 96497. xiangzhai added a comment. Hi Saleem, Please check whether or not "the correct GCC search dir" for x86_64-isoft-linux firstly, please point out my fault, thanks! And sysroot structure shown as: $ tree clang/test/Driver/Inputs/isoft_linux_4_tree

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 97047. xiangzhai added a subscriber: cfe-commits. xiangzhai added a comment. Hi Artem, Please review my updated patch, I use SourceManager's getFilename and add some testcases, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 97059. xiangzhai added a comment. Hi Artem, Thanks for your review! > Because LLVM's Illinois license is rather permissive than copyleft, we try to > avoid stuff copied from GPL/LGPL software (such as Qt or K3B) in our > codebase. The code doesn't seem

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai updated this revision to Diff 97042. xiangzhai added a comment. Hi Artem, Please review my updated patch, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 Files: lib/StaticAnalyzer/Checkers/CStringChecker.cpp

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai added a comment. Hi Vassil, The first one considered about CopyPaste dection Thanks for your reply! Let's do it together and Happy International Labor Day :) Regards, Leslie Zhai Repository: rL LLVM

[PATCH] D34353: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler to filter auto generated files

This revision was automatically updated to reflect the committed changes. Closed by commit rL305774: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler to filter auto… (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D34353?vs=103063=103162#toc Repository:

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

This revision was automatically updated to reflect the committed changes. Closed by commit rL305773: [analyzer] Check NULL pointer dereference issue for memset function (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D31868?vs=101847=103161#toc Repository: rL LLVM

[PATCH] D34353: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler to filter auto generated files

xiangzhai created this revision. Herald added a subscriber: xazax.hun. Hi LLVM developers, As Raphael suggested in https://reviews.llvm.org/D31320 I renamed `AutoGeneratedCloneConstraint` to `FilenamePatternConstraint`, please review it, thanks a lot! Regards, Leslie Zhai Repository: rL

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Hi Artem, Long time no see! miss you :) I will update my patch next Thursday! I am doing my work assignment about L4 right now. Regards, Leslie Zhai Repository: rL LLVM

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai updated this revision to Diff 101847. xiangzhai added a comment. Herald added a subscriber: xazax.hun. Hi Artem, I updated my patch please review it, thanks a lot! Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 Files:

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai added a comment. Dear Anna, Long time no see, miss you :) > Should this revision be "abandoned" or is the plan to iterate on it? I wanna the plan to iterate on it, Artem reviewed the patch, and I fixed the issue as he suggested, ran `make check-clang-analysis` also used it for

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Kindly ping Artem and Anna :) Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 102796. xiangzhai added a comment. Dear Raphael, I updated my patch as you suggested, please review it, thanks a lot! And I noticed that you are doing Performance optimizations for the CloneChecker https://reviews.llvm.org/D34182 I will rebase my patch

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 102777. xiangzhai added a comment. Herald added a subscriber: xazax.hun. Dear Raphael, Thanks for your suggestion! > Would it solve your use case if allow specifying file patterns via the > command line like this -analyzer-config Fixed!

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai added a comment. Dear Raphael, Sorry I am not available, I am looking after my little kid, see you next week, rebase perhaps. Thanks, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31320 ___ cfe-commits mailing list

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai updated this revision to Diff 102840. xiangzhai added a comment. Dear Raphael, I updated my patch as you suggested, may I commit it? thanks! Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31320 Files: include/clang/Analysis/CloneDetection.h

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

This revision was automatically updated to reflect the committed changes. Closed by commit rL305659: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D31320?vs=102840=102984#toc Repository: rL LLVM

[PATCH] D31320: [analyzer] Teach CloneDetection about Qt Meta-Object Compiler

xiangzhai added inline comments. Comment at: cfe/trunk/include/clang/Analysis/CloneDetection.h:324 +struct AutoGeneratedCloneConstraint { + StringRef IgnoredFilesPattern; v.g.vassilev wrote: > Shouldn't the name be more generic. What this essentially does is

[PATCH] D31868: [analyzer] Check NULL pointer dereference issue for memset function

xiangzhai added a comment. Dear Henry, Sorry for my poor English, please Create a New patch or provide Chinese translation :) Regards, Leslie Zhai Repository: rL LLVM https://reviews.llvm.org/D31868 ___ cfe-commits mailing list