[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining updated this revision to Diff 389650. SixWeining retitled this revision from "[clang][unittests]Fix a clang unittest linking issue" to "[clang][unittests] Fix a clang unittest linking issue". SixWeining edited the summary of this revision. SixWeining added a comment. Herald

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining updated this revision to Diff 389696. SixWeining added a comment. diff1 and diff2 are the same, but diff1 build pass while diff2 build fail. So weird. Just reupload the patch to have a try. Sorry for the noise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/

[PATCH] D114505: [clang][unittests]Fix a clang unittest linking issue

SixWeining created this revision. SixWeining added reviewers: cfe-commits, dexonsmith. Herald added a subscriber: mgorny. SixWeining requested review of this revision. Herald added a project: clang. Currently the clang/unittests/Basic/CMakeLists.txt links LLVMTestingSupport in an incorrect way

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining abandoned this revision. SixWeining added a comment. Abandon because https://reviews.llvm.org/D115580 has already fixed it although later than my fix. Thanks @dexonsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining added a comment. In D114505#3181637 , @dexonsmith wrote: > LGTM. Sorry for missing this before. Looks to me like the debian build > failure above is unrelated. > > If you need someone to commit for you, please include the info for >

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 447248. SixWeining marked 5 inline comments as done. SixWeining added a comment. Continue to address @MaskRay's comments: LLVM_LIBRARY_VISIBILITY ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2226 + static const char *const LoongArch64LibDirs[] = {"/lib64", "/lib"}; + static const char *const LoongArch64Triples[] = { MaskRay wrote: > I don't know which of /lib64,

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, rengolin. Herald added subscribers: StephenFan, krytarowski, mgorny. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2226 + static const char *const LoongArch64LibDirs[] = {"/lib64", "/lib"}; + static const char *const LoongArch64Triples[] = { xry111 wrote: > SixWeining wrote: > > MaskRay

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 447304. SixWeining added a comment. keep /lib64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files: clang/lib/Basic/CMakeLists.txt

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 446688. SixWeining marked 3 inline comments as done. SixWeining added a comment. Address @rengolin's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining added a comment. In D130255#3668436 , @rengolin wrote: > This looks great, thanks! > > Exciting that we can finally go all the way from C source to LoongArch binary. > > The changes look good to me, other than a few nits. But please wait for a

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:26 + // TODO: To be implemented in future. + return ArrayRef(); +} MaskRay wrote: > `return {}` Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 446705. SixWeining marked 9 inline comments as done. SixWeining added a comment. Address @MaskRay's comments. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 446736. SixWeining added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 454346. SixWeining added a comment. `-triple=` to `-triple ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files: clang/lib/Basic/CMakeLists.txt

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 454179. SixWeining added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp

[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining added a comment. In D132285#3736922 , @xry111 wrote: > Are cases like > > struct x { double a; __int128 : 0; double b;}; > double f(struct x x) { return x.a + x.b; } > > handled properly? AFAIK RISC-V clang currently does not handle it

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 454446. SixWeining added a comment. Use `-fsyntax-only`; `-check-prefix` to `--check-prefix`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files:

[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining updated this revision to Diff 454705. SixWeining added a comment. Add a test for struct with zero size arrays. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132285/new/ https://reviews.llvm.org/D132285 Files:

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

This revision was automatically updated to reflect the committed changes. Closed by commit rG15b65bcd6519: [Clang][LoongArch] Add initial LoongArch target and driver support (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining added a comment. In D132285#3739568 , @xry111 wrote: > In D132285#3737855 , @SixWeining > wrote: > >> Ignore zero-width bit fields and add a test. > > Thanks! There is a GCC test

[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining created this revision. SixWeining added reviewers: xen0n, MaskRay, xry111, wangleiat. Herald added subscribers: luke957, mstorsjo, StephenFan, luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. SixWeining requested review of this revision. Herald added

[PATCH] D132285: [LoongArch] Implement ABI lowering

SixWeining updated this revision to Diff 454276. SixWeining added a comment. Ignore zero-width bit fields and add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132285/new/ https://reviews.llvm.org/D132285 Files:

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463815. SixWeining added a comment. Herald added a subscriber: pengfei. The flag in the INLINEASM SDNode in llvm/test/CodeGen/X86/callbr-asm-kill.mir is updated because enum `Constraint_k` is added before `Constraint_m`. Repository: rG LLVM Github

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7baddc7557e: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC (authored by SixWeining). Repository: rG LLVM Github Monorepo

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. In D134638#3822926 , @MaskRay wrote: > `Constraint_k` somehow broke AArch64 and X86 inlineasm. Please run at least > `check-llvm check-clang` for generic changes which may have farreaching > effects to other targets. Sorry

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, wangleiat, gonglingqin. Herald added subscribers: StephenFan, atanasyan, hiraditya, arichardson, sdardis. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang,

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, tangyouling, wangleiat, gonglingqin. Herald added a subscriber: StephenFan. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. How about the asm code in `.s`? Do we need to support `addi.d a0, a1, a2`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/ https://reviews.llvm.org/D136436 ___

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining added a comment. In D136413#3873216 , @xry111 wrote: > Do we support `--target=loongarch64 -mabi=ilp32d` or `-mfpu=64 -mabi=lp64s` > combinations now? If true I think we'll need test cases for such > combinations. For `--target=loongarch64

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining added a comment. > I've formatted the patch summary for you. Please familiarize yourself with > Markdown syntax so next time your rendering would look better. Thanks. Got it. > For minimum churn and hassle, I'm afraid we have to add it for now. I didn't > realize [[ >

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining updated this revision to Diff 469472. SixWeining added a comment. Add tests for more `-mfpu` and `-mabi` combinations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136413/new/ https://reviews.llvm.org/D136413 Files:

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining updated this revision to Diff 469497. SixWeining added a comment. Define `__loongarch64` which is equal to `__loongarch_grlen == 64`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136413/new/ https://reviews.llvm.org/D136413 Files:

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#3873987 , @xen0n wrote: > In D136436#3873949 , @SixWeining > wrote: > >> How about the asm code in `.s`? Do we need to support `addi.d a0, a1, a2`? > > For the assembler

[PATCH] D136835: [Clang][LoongArch] Support inline asm constraint 'J'

SixWeining updated this revision to Diff 471135. SixWeining added a comment. Add missing comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136835/new/ https://reviews.llvm.org/D136835 Files: clang/lib/Basic/Targets/LoongArch.cpp

[PATCH] D136835: [Clang][LoongArch] Support inline asm constraint 'J'

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, wangleiat, gonglingqin. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, wangleiat, gonglingqin. Herald added subscribers: StephenFan, pengfei, hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

SixWeining updated this revision to Diff 471729. SixWeining added a comment. Fix nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136841/new/ https://reviews.llvm.org/D136841 Files: clang/test/CodeGen/LoongArch/inline-asm-operand-modifiers.c

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

SixWeining added a comment. In D136841#3893966 , @xen0n wrote: > Ah. There's a typo in the name of the testcase file... :(- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136841/new/

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

SixWeining updated this revision to Diff 471730. SixWeining added a comment. Fix testcase file name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136841/new/ https://reviews.llvm.org/D136841 Files:

[PATCH] D136835: [Clang][LoongArch] Support inline asm constraint 'J'

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd0174aacb73: [Clang][LoongArch] Support inline asm constraint J (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136835/new/

[PATCH] D136841: [LoongArch] Support inline asm operand modifier 'z'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe415cb1d61e7: [LoongArch] Support inline asm operand modifier z (authored by SixWeining). Changed prior to commit:

[PATCH] D136413: [Clang][LoongArch] Define more LoongArch specific built-in macros

SixWeining added a comment. In D136413#3895369 , @xen0n wrote: > Amended the patch summary a little for grammatical fixes and mentioning > `__loongarch64` too. Thanks. BTW, this patch depends on D136146 . Could you

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#3881382 , @MaskRay wrote: > In D136436#3876684 , @SixWeining > wrote: > >> In D136436#3873987 , @xen0n wrote: >> >>> In

[PATCH] D132285: [Clang][LoongArch] Implement ABI lowering

SixWeining added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132285/new/ https://reviews.llvm.org/D132285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134157: [LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining created this revision. SixWeining added reviewers: xen0n, MaskRay, xry111, rengolin, myhsu, wangleiat, gonglingqin. Herald added subscribers: StephenFan, JDevlieghere, hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang,

[PATCH] D132285: [Clang][LoongArch] Implement ABI lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d88a05cc01c: [Clang][LoongArch] Implement ABI lowering (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132285/new/

[PATCH] D134157: [LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining updated this revision to Diff 462139. SixWeining added a comment. Use double dashes for --mtriple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134157/new/ https://reviews.llvm.org/D134157 Files:

[PATCH] D134157: [LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining added a comment. In D134157#3805855 , @xen0n wrote: > I don't know if the clang changes should be split into its own commit (or the > title of this commit amended to mention `[Clang]` but I don't know if this is > appropriate), but the rest

[PATCH] D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

This revision was automatically updated to reflect the committed changes. Closed by commit rG394f30919a02: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, rengolin, wangleiat, gonglingqin. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining updated this revision to Diff 462388. SixWeining added a comment. Address @rengolin's comments. 1. Clip the '$' from original constraint string and match table-gen'd names. 2. Delete unnecessary check prefix in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134157: [Clang][LoongArch] Add inline asm support for constraints f/l/I/K

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:1958 + // constraints while the official register name is prefixed with a '$'. + // So we manually select general purpose registers here. + // For now, no need to support ABI

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. A polite ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/ https://reviews.llvm.org/D134638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

SixWeining reopened this revision. SixWeining added a comment. This revision is now accepted and ready to land. This breaks test: Preprocessor/init-loongarch.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135526/new/

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42b70793a1df: Reland [Clang][LoongArch] Add inline asm support

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdefe7c07f0db: Reland [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth… (authored by wangleiat, committed by SixWeining).

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6547565e7bdc: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for… (authored by wangleiat, committed by SixWeining).

[PATCH] D135526: [clang][LoongArch] Set MaxAtomicInlineWidth and MaxAtomicPromoteWidth for LoongArch

SixWeining accepted this revision. SixWeining added inline comments. Comment at: clang/test/CodeGen/LoongArch/atomics.c:2 +// RUN: %clang_cc1 -triple loongarch32 -O1 -emit-llvm %s -o - \ +// RUN: | FileCheck %s -check-prefix=LA32 +// RUN: %clang_cc1 -triple loongarch64 -O1

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463847. SixWeining added a comment. Herald added subscribers: kosarev, kerbowa, jvesely. update CodeGen/AArch64/GlobalISel/irtranslator-inline-asm.ll and CodeGen/AMDGPU/GlobalISel/irtranslator-inline-asm.ll Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added a comment. In D134638#3823379 , @xen0n wrote: > The previous test results (with some of my WIP patches but unrelated to this) > before the fix: > > Failed Tests (6): > LLVM :: CodeGen/AArch64/GlobalISel/irtranslator-inline-asm.ll

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463395. SixWeining marked 4 inline comments as done. SixWeining added a comment. Address comments from @rengolin and @MaskRay. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining added inline comments. Comment at: clang/lib/Basic/Targets/LoongArch.cpp:117 +// parsing. +R = std::string("^") + std::string(Constraint, 2); +Constraint++; MaskRay wrote: > First `std::string` can be omitted Thanks.

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463404. SixWeining added a comment. Handle k and ZB in llvm/include/llvm/IR/InlineAsm.h::getMemConstraintName and add relevant tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D134638: [Clang][LoongArch] Add inline asm support for constraints k/m/ZB/ZC

SixWeining updated this revision to Diff 463408. SixWeining added a comment. Remove the first line "Assertions" in inline-asm-constraint-ZB.ll as it is not autogenerated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134638/new/

[PATCH] D130255: [Clang][LoongArch] Add initial LoongArch target and driver support

SixWeining updated this revision to Diff 452897. SixWeining added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130255/new/ https://reviews.llvm.org/D130255 Files: clang/lib/Basic/CMakeLists.txt clang/lib/Basic/Targets.cpp

[PATCH] D140727: [XRay] Add initial support for loongarch64

SixWeining created this revision. SixWeining added reviewers: MaskRay, xen0n, xry111. Herald added subscribers: Enna1, StephenFan, hiraditya, dberris. Herald added a project: All. SixWeining requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added

[PATCH] D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support

SixWeining added a comment. In D140690#4017693 , @browneee wrote: > Who will use DFSan on loongarch64? > > Who will maintain DFSan on loongarch64? > > Is there a loongarch64 buildbot? Hi @browneee, I'm the co-author of this patch. Thanks for your

[PATCH] D140727: [XRay] Add initial support for loongarch64

SixWeining planned changes to this revision. SixWeining added a comment. D140725 is abandoned. Let me defer this change until we support 64bit PC-relative relocation for `SymA - SymB`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141070: [LoongArch] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

SixWeining accepted this revision. SixWeining added a comment. This matches LoongArch gcc's behavior. So LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141070/new/ https://reviews.llvm.org/D141070

[PATCH] D139686: [lsan] Add lsan support for loongarch64

SixWeining added a comment. LGTM. Is there any objection? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686 ___ cfe-commits mailing list

[PATCH] D140527: [LoongArch] Add intrinsics for CACOP instruction

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140527/new/ https://reviews.llvm.org/D140527

[PATCH] D138489: [tsan] Add tsan support for loongarch64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb89b42b31c45: [tsan] Add tsan support for loongarch64 (authored by tangyouling, committed by SixWeining). Repository: rG LLVM Github Monorepo

[PATCH] D139177: [LoongArch] Specify registers used for exception handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG47edc7086692: [LoongArch] Specify registers used for exception handling (authored by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139177/new/

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

SixWeining added inline comments. Comment at: clang/lib/Headers/larchintrin.h:67-96 #define __break(/*ui15*/ _1) __builtin_loongarch_break((_1)) #define __dbar(/*ui15*/ _1) __builtin_loongarch_dbar((_1)) #define __ibar(/*ui15*/ _1) __builtin_loongarch_ibar((_1))

[PATCH] D139612: [Clang][LoongArch] Add intrinsic for iocsrrd and iocsrwr

SixWeining accepted this revision. SixWeining added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139612/new/ https://reviews.llvm.org/D139612 ___ cfe-commits mailing list

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139288/new/ https://reviews.llvm.org/D139288

[PATCH] D138489: [tsan] Add tsan support for loongarch64

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM from the LoongArch side but it's better to wait for others. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:270 +#elif

[PATCH] D139397: [LoongArch] Add testcases for privileged intrinsic macros

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139397/new/ https://reviews.llvm.org/D139397

[PATCH] D139915: [Clang][LoongArch] Add intrinsic for asrtle, asrtgt, lddir, ldpte and cpucfg

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM except a small nit. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.h:91 IOCSRWR_D, + + CPUCFG, Better to leave some comment

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

SixWeining added inline comments. Comment at: clang/lib/Headers/larchintrin.h:17-20 +typedef struct drdtime { + unsigned long dvalue; + unsigned long dtimeid; +} __drdtime_t; Should be moved into the belowing `#if __loongarch_grlen == 64`. Repository: rG

[PATCH] D139987: [Clang][LoongArch] Add intrinsic for rdtime_d, rdtimeh_w and rdtimel_w

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139987/new/ https://reviews.llvm.org/D139987

[PATCH] D139686: [lsan] Add lsan support for loongarch64

SixWeining added inline comments. Comment at: compiler-rt/test/lsan/TestCases/swapcontext.cpp:8 // Missing 'getcontext' and 'makecontext' on Android. -// UNSUPPORTED: arm,aarch64,powerpc64,android +// UNSUPPORTED: arm,aarch64,loongarch64,powerpc64,android Why

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925-933 +case Intrinsic::loongarch_crc_w_b_w: { + Results.push_back(DAG.getNode( + ISD::TRUNCATE, DL, VT, + DAG.getNode(LoongArchISD::CRC_W_B_W, DL,

[PATCH] D138350: [scudo] Add loongarch64 support for scudo

This revision was automatically updated to reflect the committed changes. Closed by commit rGac84798570cd: [scudo] Add loongarch64 support for scudo (authored by tangyouling, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138489: [tsan] Add tsan support for loongarch64

SixWeining added a comment. I haven't check the correctness of `tsan_rtl_loongarch64.S`. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1513 + + register int res __asm__("$a0"); + register int __flags __asm__("$a0") = flags; I'm not sure if

[PATCH] D138489: [tsan] Add tsan support for loongarch64

SixWeining added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1543 +"r"(__fn), "r"(__arg), "r"(nr_clone), "i"(__NR_exit) + : "memory"); + return res; tangyouling wrote: > SixWeining wrote: > > Shall we list

[PATCH] D138350: [scudo] Add loongarch64 support for scudo

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138350/new/ https://reviews.llvm.org/D138350

[PATCH] D138403: [LoongArch] Fix issue on CMake Xcode build configuration

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM but wait for @WowbaggersLiquidLunch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138403/new/ https://reviews.llvm.org/D138403

[PATCH] D138489: [tsan] Add tsan support for loongarch64

SixWeining added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:1543 +"r"(__fn), "r"(__arg), "r"(nr_clone), "i"(__NR_exit) + : "memory"); + return res; xry111 wrote: > xry111 wrote: > > SixWeining wrote: > > >

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:603 case Intrinsic::loongarch_dbar: { -SDValue Op0 = Op.getOperand(0); -SDValue Op2 = Op.getOperand(2); -if (!isa(Op2)) { - DAG.getContext()->emitError("argument

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM but let's wait for others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138094/new/ https://reviews.llvm.org/D138094

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL,

[PATCH] D139177: [LoongArch] Specify registers used for exception handling

SixWeining created this revision. SixWeining added reviewers: xen0n, xry111, MaskRay, wangleiat. Herald added a subscriber: StephenFan. Herald added a project: All. SixWeining requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See definition

[PATCH] D139177: [LoongArch] Specify registers used for exception handling

SixWeining updated this revision to Diff 479553. SixWeining added a comment. Add clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139177/new/ https://reviews.llvm.org/D139177 Files: clang/lib/Basic/Targets/LoongArch.h

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w:

[PATCH] D138418: [LoongArch] Add remaining intrinsics for CRC check instructions

SixWeining added inline comments. Comment at: llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp:925 llvm_unreachable("Unexpected Intrinsic."); -case Intrinsic::loongarch_crc_w_d_w: { - Results.push_back(DAG.getNode( - ISD::TRUNCATE, DL,

[PATCH] D139686: [lsan] Add lsan support for loongarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a58e11961d8: [lsan] Add lsan support for loongarch64 (authored by tangyouling, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

  1   2   >