Re: [clang-tools-extra] r250939 - [clang-tidy] add check cppcoreguidelines-pro-type-vararg

It seems that this commit breaks the following bot http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/12461/ Manman > On Oct 21, 2015, at 1:09 PM, Matthias Gehre via cfe-commits >

r252814 - [TLS on Darwin] change how we handle globals with linkonce or weak linkage.

Author: mren Date: Wed Nov 11 16:42:31 2015 New Revision: 252814 URL: http://llvm.org/viewvc/llvm-project?rev=252814=rev Log: [TLS on Darwin] change how we handle globals with linkonce or weak linkage. This is about how we handle static member of a template. Before this commit, we use internal

Re: [PATCH] D13304: Avoid inlining in throw statement

manmanren added a subscriber: manmanren. manmanren added a comment. Inliner currently does not include analysis passes such as BPI and BFI. With the new pass manager, we should be able to hook up inliner with BFI (and we can handle throw in BFI). Before that, maybe we can add this as part of

Stage 2 bot failure: clang-stage2-configure-Rlto_check

There are 33 commits picked up in this run and we have 107 test failures. This happened at 2pm today. I wonder if any one knows what is going on. http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/6222/

Re: [libcxx] r249929 - Split out of .

r maybe adding a Clang feature to let us fix the > bad signature). > > Can you elaborate on how to fix the bad signature by adding a Clang feature? I want to see how hard it is before giving up on trying to fix the signatures. Thanks, Manman > On Oct 15, 2015 11:07 AM, "Manm

Re: [libcxx] r249929 - Split out of .

Hi Richard, This is causing a failure when building povray on iOS. Compilation error: /Users/buildslave/tmp/test-suite-externals/speccpu2006/benchspec/CPU2006/453.povray/src/fileinputoutput.cpp:364:20: error: call to 'strrchr' is ambiguous const char *p=strrchr(name, '.’);

[libcxx] r249926 - Revert r249889 due to bot failure.

Author: mren Date: Fri Oct 9 20:03:55 2015 New Revision: 249926 URL: http://llvm.org/viewvc/llvm-project?rev=249926=rev Log: Revert r249889 due to bot failure. Removed: libcxx/trunk/include/wchar.h Modified: libcxx/trunk/include/cwchar

[PATCH] D15314: Fix a bug in unavailable checking

manmanren created this revision. manmanren added reviewers: rjmccall, rsmith. manmanren added a subscriber: cfe-commits. The issue — Given the following test case, we don’t emit any message, and will silently ignore the variable "foo2", with a release compiler; we will get an

r255860 - [TLS on Darwin] use CXX_FAST_TLS calling convention for access functions.

Author: mren Date: Wed Dec 16 18:42:36 2015 New Revision: 255860 URL: http://llvm.org/viewvc/llvm-project?rev=255860=rev Log: [TLS on Darwin] use CXX_FAST_TLS calling convention for access functions. Also set nounwind attribute. rdar://problem/9001553 Modified:

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Ping Appreciate comments on the general direction. Cheers, Manman http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Ping :] http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271747 - Bump libclang API minor version after r271351.

Author: mren Date: Fri Jun 3 18:11:41 2016 New Revision: 271747 URL: http://llvm.org/viewvc/llvm-project?rev=271747=rev Log: Bump libclang API minor version after r271351. Also use the next enum value for CXObjCPropertyAttr_class. Modified: cfe/trunk/include/clang-c/Index.h Modified:

r271310 - PCH + module: make sure we write out macros associated with builtin identifiers.

Author: mren Date: Tue May 31 13:19:32 2016 New Revision: 271310 URL: http://llvm.org/viewvc/llvm-project?rev=271310=rev Log: PCH + module: make sure we write out macros associated with builtin identifiers. When we import a module that defines a builtin identifier from prefix header and

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

manmanren added a comment. In http://reviews.llvm.org/D20383#443613, @doug.gregor wrote: > Yeah, this looks like the right approach. PCH follows the same rules as > modules when it comes to newer information shadowing imported information. Hi Doug, Thanks for reviewing the patch! Can I take

r271351 - Indexer: add CXObjCPropertyAttr_class for class properties.

Author: mren Date: Tue May 31 18:22:04 2016 New Revision: 271351 URL: http://llvm.org/viewvc/llvm-project?rev=271351=rev Log: Indexer: add CXObjCPropertyAttr_class for class properties. rdar://25963227 Modified: cfe/trunk/include/clang-c/Index.h

[PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

manmanren created this revision. manmanren added a reviewer: rjmccall. manmanren added a subscriber: cfe-commits. It's possible to have multiple local ObjCLifetime qualifiers. When there is a conflict, we can't stop after we reach a type that is directly qualified. We need to keep pulling sugar

[PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

manmanren created this revision. manmanren added a reviewer: rjmccall. manmanren added a subscriber: cfe-commits. Before this fix, both the start and the end point to the same location, and we will add the FixIt before the type name: ^(NSView view) to ^(*NSView view) After this commit, fixit

Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

manmanren added a comment. Doug and Richard, Can you take a look at this when you have time? Thanks, Manman http://reviews.llvm.org/D20383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r271409 - ObjC lifetime: pull sugar off when the qualifiers conflict.

Author: mren Date: Wed Jun 1 12:14:19 2016 New Revision: 271409 URL: http://llvm.org/viewvc/llvm-project?rev=271409=rev Log: ObjC lifetime: pull sugar off when the qualifiers conflict. It's possible to have multiple local ObjCLifetime qualifiers. When there is a conflict, we can't stop after we

Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

manmanren added a comment. In http://reviews.llvm.org/D20844#445762, @rjmccall wrote: > Hmm. No, I think the original code is correct here — RangeEnd is a token > range, and those are generally inclusive rather than exclusive. The fix-it > needs to be inserting at the end of the token. We

Re: [PATCH] D20844: FixIt: use getLocForEndOfToken to insert fix-it after a type name.

manmanren retitled this revision from "FixIt: correctly set DeclSpec's range end for a type name annotation." to "FixIt: use getLocForEndOfToken to insert fix-it after a type name.". manmanren updated the summary for this revision. manmanren updated this revision to Diff 59296. manmanren added a

Re: [PATCH] D20844: FixIt: correctly set DeclSpec's range end for a type name annotation.

> On Jun 1, 2016, at 1:18 PM, Richard Smith via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > On Wed, Jun 1, 2016 at 12:42 PM, Manman Ren via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > man

r271448 - FixIt: use getLocForEndOfToken to insert fix-it after a type name.

Author: mren Date: Wed Jun 1 19:11:03 2016 New Revision: 271448 URL: http://llvm.org/viewvc/llvm-project?rev=271448=rev Log: FixIt: use getLocForEndOfToken to insert fix-it after a type name. Instead of setting DeclSpec's range end to point to the next token after the DeclSpec, we use

Re: [PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

manmanren added a comment. In http://reviews.llvm.org/D20843#445756, @rjmccall wrote: > Oh sure, because we don't strip the original type if there isn't a conflict. > LGTM. Exactly, thanks for reviewing! Manman http://reviews.llvm.org/D20843

Re: [PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman http://reviews.llvm.org/D20923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r260567 - [PR26550] Use a different TBAA root for C++ vs C.

Author: mren Date: Thu Feb 11 13:19:18 2016 New Revision: 260567 URL: http://llvm.org/viewvc/llvm-project?rev=260567=rev Log: [PR26550] Use a different TBAA root for C++ vs C. This commit changes the root from "Simple C/C++ TBAA" to "Simple C++ TBAA" for C++. The problem is that the type name

r259820 - Fix a crash when there is a typo in the return statement.

Author: mren Date: Thu Feb 4 14:05:40 2016 New Revision: 259820 URL: http://llvm.org/viewvc/llvm-project?rev=259820=rev Log: Fix a crash when there is a typo in the return statement. If the typo happens after a successful deduction for an earlier return statement, we should check if the deduced

Re: [PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

manmanren updated this revision to Diff 46301. manmanren added a comment. Addressing comments from Akira and Justin. http://reviews.llvm.org/D16564 Files: lib/CodeGen/ModuleBuilder.cpp test/CodeGen/target-builtin-error-3.c Index: test/CodeGen/target-builtin-error-3.c

r259070 - Class Property: class property and instance property can have the same name.

Author: mren Date: Thu Jan 28 12:49:28 2016 New Revision: 259070 URL: http://llvm.org/viewvc/llvm-project?rev=259070=rev Log: Class Property: class property and instance property can have the same name. Add "enum ObjCPropertyQueryKind" to a few APIs that used to only take the name of the

Re: [PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

stopped? > > -eric > > > On Thu, Jan 28, 2016 at 9:53 AM Justin Bogner <m...@justinbogner.com> > wrote: > >> Manman Ren via cfe-commits <cfe-commits@lists.llvm.org> writes: >> > manmanren created this revision. >> > manmanren added reviewers

r259116 - Check for frontend errors after releasing the Builder.

Author: mren Date: Thu Jan 28 17:29:02 2016 New Revision: 259116 URL: http://llvm.org/viewvc/llvm-project?rev=259116=rev Log: Check for frontend errors after releasing the Builder. Frontend can emit errors when releaseing the Builder. If there are errors before or when releasing the Builder, we

r259119 - Class Property: change PropertyMap to include isClassProperty.

Author: mren Date: Thu Jan 28 17:36:05 2016 New Revision: 259119 URL: http://llvm.org/viewvc/llvm-project?rev=259119=rev Log: Class Property: change PropertyMap to include isClassProperty. PropertyMap used to map IdentifierInfo (name of the property) to ObjcPropertyDecl *. Now that a class

r259591 - ObjCXX: fix a crash during typo correction.

Author: mren Date: Tue Feb 2 16:23:03 2016 New Revision: 259591 URL: http://llvm.org/viewvc/llvm-project?rev=259591=rev Log: ObjCXX: fix a crash during typo correction. For ObjCXX, we can create a CastExpr with Kind being CK_UserDefinedConversion and SubExpr being BlockExpr. Specifically one

r259267 - Class Property: generate metadata for class properties in categories.

Author: mren Date: Fri Jan 29 17:45:01 2016 New Revision: 259267 URL: http://llvm.org/viewvc/llvm-project?rev=259267=rev Log: Class Property: generate metadata for class properties in categories. The list of class properties is saved in Old ABI: category->class_properties (category->size will be

r259268 - Class Property: generate metadata for class properties in protocols.

Author: mren Date: Fri Jan 29 17:46:55 2016 New Revision: 259268 URL: http://llvm.org/viewvc/llvm-project?rev=259268=rev Log: Class Property: generate metadata for class properties in protocols. The list of class properties is saved in Old ABI: protocol->ext->class_properties

r259728 - Bump DiagnosticSemaKinds count; we're close to hitting it.

Author: mren Date: Wed Feb 3 17:35:29 2016 New Revision: 259728 URL: http://llvm.org/viewvc/llvm-project?rev=259728=rev Log: Bump DiagnosticSemaKinds count; we're close to hitting it. $ grep '= DIAG_START_SEMA' include/clang/Basic/DiagnosticIDs.h DIAG_START_ANALYSIS =

r259224 - Class Property: parse @dynamic (class).

Author: mren Date: Fri Jan 29 13:05:57 2016 New Revision: 259224 URL: http://llvm.org/viewvc/llvm-project?rev=259224=rev Log: Class Property: parse @dynamic (class). rdar://23891898 Modified: cfe/trunk/lib/Parse/ParseObjc.cpp cfe/trunk/test/SemaObjC/objc-class-property.m Modified:

r259229 - Class Property: generate metadata for class properties in classes.

Author: mren Date: Fri Jan 29 13:22:54 2016 New Revision: 259229 URL: http://llvm.org/viewvc/llvm-project?rev=259229=rev Log: Class Property: generate metadata for class properties in classes. The list of class properties is saved in Old ABI: cls->isa->ext->properties New ABI:

r259226 - Class Property: warn for synthesize on a class property.

Author: mren Date: Fri Jan 29 13:16:39 2016 New Revision: 259226 URL: http://llvm.org/viewvc/llvm-project?rev=259226=rev Log: Class Property: warn for synthesize on a class property. rdar://23891898 Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

r258979 - Class Property: handle class properties.

Author: mren Date: Wed Jan 27 14:00:32 2016 New Revision: 258979 URL: http://llvm.org/viewvc/llvm-project?rev=258979=rev Log: Class Property: handle class properties. At places where we handle instance properties, if necessary. rdar://23891898 Modified: cfe/trunk/lib/AST/DeclObjC.cpp

r258980 - Class Property: create accessors (class methods) for class property.

Author: mren Date: Wed Jan 27 14:10:32 2016 New Revision: 258980 URL: http://llvm.org/viewvc/llvm-project?rev=258980=rev Log: Class Property: create accessors (class methods) for class property. Change a few places where we assume property accessors can only be instance methods. rdar://23891898

Re: r261548 - Add has_feature attribute_availability_with_strict.

> On Feb 22, 2016, at 10:37 AM, Aaron Ballman via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > On Mon, Feb 22, 2016 at 1:24 PM, Manman Ren via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: >> Author: mren &

r261756 - Objective-C: Add a size field to non-fragile category metadata.

Author: mren Date: Wed Feb 24 11:49:50 2016 New Revision: 261756 URL: http://llvm.org/viewvc/llvm-project?rev=261756=rev Log: Objective-C: Add a size field to non-fragile category metadata. This is mainly for extensibility. Note that fragile category metadata, metadata for classes and protocols

[PATCH] D17576: Fix assertion failure on MaybeODRUseExprs.

manmanren created this revision. manmanren added reviewers: rsmith, EricWF, faisalv. manmanren added a subscriber: cfe-commits. In VisitNonTypeTemplateParamDecl, before SubstExpr with the default argument, we should create a ConstantEvaluated ExpressionEvaluationContext. Without this, it is

Re: [PATCH] SemaCXX: Support templates in availability attributes

This patch looks good to me. But I am not sure if Aaron has any comment. > On Feb 22, 2016, at 6:19 PM, Duncan P. N. Exon Smith > wrote: > >> >> On 2016-Feb-22, at 17:24, Manman Ren wrote: >> >> >> >>> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon

Re: [PATCH] SemaCXX: Support templates in availability attributes

> On Feb 8, 2016, at 8:17 PM, Duncan P. N. Exon Smith > wrote: > > This patch adds support for templates in availability attributes. > - If the context for an availability diagnostic is a >`FunctionTemplateDecl`, look through it to the `FunctionDecl`. >

r261803 - Fix assertion failure on MaybeODRUseExprs.

Author: mren Date: Wed Feb 24 17:05:43 2016 New Revision: 261803 URL: http://llvm.org/viewvc/llvm-project?rev=261803=rev Log: Fix assertion failure on MaybeODRUseExprs. In VisitNonTypeTemplateParamDecl, before SubstExpr with the default argument, we should create a ConstantEvaluated

r261548 - Add has_feature attribute_availability_with_strict.

Author: mren Date: Mon Feb 22 12:24:30 2016 New Revision: 261548 URL: http://llvm.org/viewvc/llvm-project?rev=261548=rev Log: Add has_feature attribute_availability_with_strict. rdar://23791325 Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp

Re: [PATCH] D15935: Improve diagnostics for literal conversion to Boolean

manmanren added a subscriber: manmanren. manmanren added a comment. Thanks for working on this. This looks good to me overall, but I am not the expert on Sema :] Cheers, Manman Comment at: lib/Sema/SemaChecking.cpp:6985 @@ -6984,6 +6984,3 @@ SmallString<16>

r258727 - Move ObjCPropertyDecl to before ObjCContainerDecl.

Author: mren Date: Mon Jan 25 15:52:26 2016 New Revision: 258727 URL: http://llvm.org/viewvc/llvm-project?rev=258727=rev Log: Move ObjCPropertyDecl to before ObjCContainerDecl. After we add ObjCPropertyDecl::isClassProperty, we can use it in ObjCContainerDecl to define filter to iterate over

r258735 - Update comments to match the implementation.

Author: mren Date: Mon Jan 25 16:37:47 2016 New Revision: 258735 URL: http://llvm.org/viewvc/llvm-project?rev=258735=rev Log: Update comments to match the implementation. Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp URL:

Re: [PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

manmanren added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:1998 @@ +1997,3 @@ + if (auto *T = EntryBB->getTerminator()) +T->eraseFromParent(); + Yes, you are right. http://reviews.llvm.org/D15599

[PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

manmanren created this revision. manmanren added reviewers: echristo, rafael, ahatanak. manmanren added a subscriber: cfe-commits. It can happen that frontend emits error message when releasing the builder. When that happens, we emit the error message and continue to invoke backend. Backend will

Re: [PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

manmanren added a subscriber: manmanren. manmanren added a comment. Thanks for working on this! A few comments inline. Manman Comment at: lib/CodeGen/CodeGenFunction.cpp:1962 @@ +1961,3 @@ +for (auto *U : I->users()) + InstrsToRemove.push_back(cast(U)); +

r258824 - Use instance_properties instead of properties. NFC.

Author: mren Date: Tue Jan 26 12:05:23 2016 New Revision: 258824 URL: http://llvm.org/viewvc/llvm-project?rev=258824=rev Log: Use instance_properties instead of properties. NFC. All current properties are instance properties. This is the second patch in a series of patches to support class

r258834 - Class Property: parse property attribute (class).

Author: mren Date: Tue Jan 26 12:52:43 2016 New Revision: 258834 URL: http://llvm.org/viewvc/llvm-project?rev=258834=rev Log: Class Property: parse property attribute (class). This is the third patch in a series of patches to support class properties in addition to instance properties in

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a subscriber: manmanren. manmanren added a comment. Hi Akira, Can you give a high-level explanation of how this patch fixes the problem? This patch enforces that the capacity is 8-byte aligned, is it required to solve the alignment issue here? Thanks, Manman

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. Thanks for working on this! Manman Comment at: lib/Sema/TypeLocBuilder.cpp:99 @@ +98,3 @@ +// element was pushed. +RemoveOrInsertPadding = NumBytesAtAlign4 != 0; + } This patch seems to do two things: 1> simplify the logic

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added inline comments. Comment at: lib/Sema/TypeLocBuilder.cpp:130 @@ +129,3 @@ + else if (CurrentlyHasPadding) { +// Remove 4-byte padding. +memmove([Index + 4], [Index], NumBytesAtAlign4); Expand this comment a little?

Re: [PATCH] D16914: [CodeGen] Fix an assert in CodeGenFunction::EmitFunctionEpilog

manmanren added a comment. LGTM otherwise. Cheers, Manman Comment at: lib/CodeGen/CGCall.cpp:2468 @@ +2467,3 @@ + QualType RT; + + if (auto *FD = dyn_cast(CurCodeDecl)) Maybe add comments here on the if else block? http://reviews.llvm.org/D16914

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren updated this revision to Diff 48228. http://reviews.llvm.org/D15314 Files: include/clang/Sema/Initialization.h include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp test/SemaObjC/Inputs/arc-system-header.h

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Doug, Thanks for reviewing! I updated the patch to use TreatUnavailableAsInvalid. Cheers, Manman http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r261163 - Add 'nopartial' qualifier for availability attributes.

Author: mren Date: Wed Feb 17 16:05:48 2016 New Revision: 261163 URL: http://llvm.org/viewvc/llvm-project?rev=261163=rev Log: Add 'nopartial' qualifier for availability attributes. An optional nopartial can be placed after the platform name. int bar()

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. Hi Akira, How about the following? else if (LocalAlignment == 8) { if (NumBytesAtAlign8 == 0) { // We have not seen any 8-byte aligned element yet. There is no padding and we are either 4-byte // aligned or 8-byte aligned depending on

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

On Wed, Feb 17, 2016 at 10:33 PM, Akira Hatanaka wrote: > ahatanak added a comment. > > OK, I now understand what you meant. > > > How about the following? > > > > > > else if (LocalAlignment == 8) { > > > if (NumBytesAtAlign8 == 0) { > > > // We have not seen any

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. > If Capacity is not a multiple of 8, (LocalSize + NumBytesAtAlign4) % 8 > doesn't tell you whether the new element will be 8-byte aligned. For example, > if Capacity==36, NumBytesAtAlign4==4, and LocalSize==8, (LocalSize + > NumBytesAtAlign4) equals 12 but padding

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. Thanks Akira, LGTM. Manman http://reviews.llvm.org/D16843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r261466 - Class Property: Fix a crash with old ABI when generating metadata in classes.

Author: mren Date: Sat Feb 20 23:31:05 2016 New Revision: 261466 URL: http://llvm.org/viewvc/llvm-project?rev=261466=rev Log: Class Property: Fix a crash with old ABI when generating metadata in classes. rdar://23891898 Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp

r261512 - Addressing review comments for r261163.

Author: mren Date: Sun Feb 21 22:47:24 2016 New Revision: 261512 URL: http://llvm.org/viewvc/llvm-project?rev=261512=rev Log: Addressing review comments for r261163. Use "strict" instead of "nopartial". Also make strictly not-introduced share the same diagnostics as Obsolete and Unavailable.

r263149 - Add TreatUnavailableAsInvalid for the verification-only mode in InitListChecker.

Author: mren Date: Thu Mar 10 12:53:19 2016 New Revision: 263149 URL: http://llvm.org/viewvc/llvm-project?rev=263149=rev Log: Add TreatUnavailableAsInvalid for the verification-only mode in InitListChecker. Given the following test case: typedef struct { const char *name; id field; } Test9;

r263171 - Add has_feature objc_class_property.

Author: mren Date: Thu Mar 10 17:51:03 2016 New Revision: 263171 URL: http://llvm.org/viewvc/llvm-project?rev=263171=rev Log: Add has_feature objc_class_property. rdar://23891898 Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp cfe/trunk/test/SemaObjC/objc-class-property.m Modified:

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

manmanren retitled this revision from "Add replacement = "xxx" to DeprecatedAttr." to "Add an optional string argument to DeprecatedAttr for Fix-It.". manmanren updated this revision to Diff 50374. http://reviews.llvm.org/D17865 Files: include/clang/Basic/Attr.td

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

manmanren added inline comments. Comment at: utils/TableGen/ClangAttrEmitter.cpp:1234 @@ +1233,3 @@ +if ((Spelling == "deprecated" || Spelling == "gnu::deprecated") && +Variety != "GNU" && index == 1) + continue; This does not look

r263172 - Print strict in Availability attribute when it is on.

Author: mren Date: Thu Mar 10 17:54:12 2016 New Revision: 263172 URL: http://llvm.org/viewvc/llvm-project?rev=263172=rev Log: Print strict in Availability attribute when it is on. Modified: cfe/trunk/test/Sema/attr-print.c cfe/trunk/utils/TableGen/ClangAttrEmitter.cpp Modified:

Re: [PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

manmanren added a comment. Uploading a new patch addressing Aaron's comments: 1> Add an optional string argument for fix-it, instead of the original proposal of named argument `Replacement = "xxx"` This actually simplifies the patch a lot 2> Add testing cases to make sure we don't accept a

Re: r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

tifierInfo*, clang::SourceLocation, >> clang::IdentifierLoc*, clang::AvailabilityChange const&, >> clang::AvailabilityChange const&, clang::AvailabilityChange const&, >> clang::SourceLocation, clang::Expr const*, clang::AttributeList::Syntax, >> clang::SourceLocation,

r263854 - [TLS on Darwin] use CXX_FAST_TLS calling convention for tls_init.

Author: mren Date: Fri Mar 18 18:35:21 2016 New Revision: 263854 URL: http://llvm.org/viewvc/llvm-project?rev=263854=rev Log: [TLS on Darwin] use CXX_FAST_TLS calling convention for tls_init. This makes sure we don't generate a lot of code to spill/reload CSRs when calling tls_init from the

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

manmanren marked 3 inline comments as done. manmanren added a comment. Upload patch to address review comments. Thanks, Manman http://reviews.llvm.org/D17865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

manmanren updated this revision to Diff 50502. http://reviews.llvm.org/D17865 Files: include/clang/Basic/Attr.td lib/Lex/PPMacroExpansion.cpp lib/Sema/SemaDeclAttr.cpp test/SemaCXX/attr-deprecated-replacement-error.cpp test/SemaCXX/attr-deprecated-replacement-fixit.cpp

Re: [PATCH] D17865: Add an optional string argument to DeprecatedAttr for Fix-It.

manmanren updated this revision to Diff 50682. http://reviews.llvm.org/D17865 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/Lex/PPMacroExpansion.cpp lib/Sema/SemaDeclAttr.cpp test/SemaCXX/attr-deprecated-replacement-error.cpp

Re: [PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

manmanren added a comment. Hi Aaron, Thanks for the review! > I like the idea of a potential fixit being provided by the attribute, but I > do not agree with the way the feature is surfaced in this patch. > > For the GNU-style attribute, the named argument functionality is sufficiently >

r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

Author: mren Date: Wed Mar 16 22:09:55 2016 New Revision: 263687 URL: http://llvm.org/viewvc/llvm-project?rev=263687=rev Log: Add an optional named argument (replacement = "xxx") to AvailabilityAttr. This commit adds a named argument to AvailabilityAttr, while r263652 adds an optional string

r263752 - Revert r263687 for ubsan bot failure.

Author: mren Date: Thu Mar 17 17:13:50 2016 New Revision: 263752 URL: http://llvm.org/viewvc/llvm-project?rev=263752=rev Log: Revert r263687 for ubsan bot failure. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/include/clang/Basic/AttrDocs.td

r263652 - Add an optional string argument to DeprecatedAttr for Fix-It.

Author: mren Date: Wed Mar 16 13:50:49 2016 New Revision: 263652 URL: http://llvm.org/viewvc/llvm-project?rev=263652=rev Log: Add an optional string argument to DeprecatedAttr for Fix-It. We only add this to __attribute__((deprecated)). Differential Revision: http://reviews.llvm.org/D17865

Re: [PATCH] D17865: Add replacement = "xxx" to DeprecatedAttr.

manmanren added a comment. Ping http://reviews.llvm.org/D17865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Ping http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r265712 - [ObjC kindof] Use type bound to filter out the candidate methods.

Author: mren Date: Thu Apr 7 14:32:24 2016 New Revision: 265712 URL: http://llvm.org/viewvc/llvm-project?rev=265712=rev Log: [ObjC kindof] Use type bound to filter out the candidate methods. rdar://21306753 Modified: cfe/trunk/include/clang/Sema/Sema.h

r265711 - NFC: simplify code in BuildInstanceMessage.

Author: mren Date: Thu Apr 7 14:30:20 2016 New Revision: 265711 URL: http://llvm.org/viewvc/llvm-project?rev=265711=rev Log: NFC: simplify code in BuildInstanceMessage. Instead of searching the global pool multiple times: in LookupFactoryMethodInGlobalPool, LookupInstanceMethodInGlobalPool,

r265616 - Keep -fmodule-implementation-of as an alias of -fmodule-name.

Author: mren Date: Wed Apr 6 18:28:26 2016 New Revision: 265616 URL: http://llvm.org/viewvc/llvm-project?rev=265616=rev Log: Keep -fmodule-implementation-of as an alias of -fmodule-name. This helps us transitioning to -fmodule-name. Once the transitioning is done, we can remove this alias.

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

manmanren added inline comments. Comment at: lib/Parse/ParseObjc.cpp:1697 @@ -1696,3 +1696,3 @@ // We syntactically matched a type argument, so commit to parsing - // type arguments. + // type arguments. Finding protocol arguments after here is an error. I

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

manmanren added a comment. LGTM. Manman http://reviews.llvm.org/D18997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r266146 - ObjC class properties: add diagnostics for unimplemented class properties.

Author: mren Date: Tue Apr 12 18:01:55 2016 New Revision: 266146 URL: http://llvm.org/viewvc/llvm-project?rev=266146=rev Log: ObjC class properties: add diagnostics for unimplemented class properties. rdar://24711047 Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

r265877 - ObjC kindof: check the context when inserting methods to global pool.

Author: mren Date: Sat Apr 9 13:59:48 2016 New Revision: 265877 URL: http://llvm.org/viewvc/llvm-project?rev=265877=rev Log: ObjC kindof: check the context when inserting methods to global pool. To make kindof lookup work, we need to insert methods with different context into the global pool,

r265488 - Update testing cases after backend changes.

Author: mren Date: Tue Apr 5 18:27:51 2016 New Revision: 265488 URL: http://llvm.org/viewvc/llvm-project?rev=265488=rev Log: Update testing cases after backend changes. Modified: cfe/trunk/test/CodeGen/arm-swiftcall.c cfe/trunk/test/CodeGenCXX/arm-swiftcall.cpp Modified:

Re: [PATCH] D18567: Block: Fix a crash when we have type attributes or qualifiers with omitted return type.

manmanren added a comment. Ping :] http://reviews.llvm.org/D18567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

tion, clang::Expr const*) > /mnt/b/sanitizer-buildbot3/sanitizer-x86_64-linux-fast/build/llvm/tools/clang/include/clang/Sema/AttributeList.h:798:7 > #3 0x4465a73 in clang::Parser::Pa > > > > > On Wed, Mar 16, 2016 at 8:09 PM, Manman Ren via cfe-commits < > cfe-commits@list

r264196 - ObjC: add getter/setter for class properties to global pool.

Author: mren Date: Wed Mar 23 16:39:31 2016 New Revision: 264196 URL: http://llvm.org/viewvc/llvm-project?rev=264196=rev Log: ObjC: add getter/setter for class properties to global pool. rdar://problem/25323072 Modified: cfe/trunk/lib/Sema/SemaObjCProperty.cpp

r263958 - Add replacement = "xxx" to AvailabilityAttr.

Author: mren Date: Mon Mar 21 12:30:55 2016 New Revision: 263958 URL: http://llvm.org/viewvc/llvm-project?rev=263958=rev Log: Add replacement = "xxx" to AvailabilityAttr. This commit adds a named argument to AvailabilityAttr, while r263652 adds an optional string argument to

r263955 - NFC: wrap Availability-related data in its own struct in AttributeList.

Author: mren Date: Mon Mar 21 12:26:40 2016 New Revision: 263955 URL: http://llvm.org/viewvc/llvm-project?rev=263955=rev Log: NFC: wrap Availability-related data in its own struct in AttributeList. This makes it easy to add more data into Availability. Modified:

r264167 - ObjC: Handle boolean fixed type for enum.

Author: mren Date: Wed Mar 23 11:28:28 2016 New Revision: 264167 URL: http://llvm.org/viewvc/llvm-project?rev=264167=rev Log: ObjC: Handle boolean fixed type for enum. Before this commit, we assert failure in ImplicitCastExpr "unheralded conversion to bool". This commit fixes the assertion by

  1   2   3   >