r261466 - Class Property: Fix a crash with old ABI when generating metadata in classes.

Author: mren Date: Sat Feb 20 23:31:05 2016 New Revision: 261466 URL: http://llvm.org/viewvc/llvm-project?rev=261466=rev Log: Class Property: Fix a crash with old ABI when generating metadata in classes. rdar://23891898 Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. Thanks Akira, LGTM. Manman http://reviews.llvm.org/D16843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. > If Capacity is not a multiple of 8, (LocalSize + NumBytesAtAlign4) % 8 > doesn't tell you whether the new element will be 8-byte aligned. For example, > if Capacity==36, NumBytesAtAlign4==4, and LocalSize==8, (LocalSize + > NumBytesAtAlign4) equals 12 but padding

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

On Wed, Feb 17, 2016 at 10:33 PM, Akira Hatanaka wrote: > ahatanak added a comment. > > OK, I now understand what you meant. > > > How about the following? > > > > > > else if (LocalAlignment == 8) { > > > if (NumBytesAtAlign8 == 0) { > > > // We have not seen any

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. Hi Akira, How about the following? else if (LocalAlignment == 8) { if (NumBytesAtAlign8 == 0) { // We have not seen any 8-byte aligned element yet. There is no padding and we are either 4-byte // aligned or 8-byte aligned depending on

r261163 - Add 'nopartial' qualifier for availability attributes.

Author: mren Date: Wed Feb 17 16:05:48 2016 New Revision: 261163 URL: http://llvm.org/viewvc/llvm-project?rev=261163=rev Log: Add 'nopartial' qualifier for availability attributes. An optional nopartial can be placed after the platform name. int bar()

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Doug, Thanks for reviewing! I updated the patch to use TreatUnavailableAsInvalid. Cheers, Manman http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren updated this revision to Diff 48228. http://reviews.llvm.org/D15314 Files: include/clang/Sema/Initialization.h include/clang/Sema/Sema.h lib/Sema/SemaDecl.cpp lib/Sema/SemaExpr.cpp lib/Sema/SemaInit.cpp test/SemaObjC/Inputs/arc-system-header.h

Re: [PATCH] D16914: [CodeGen] Fix an assert in CodeGenFunction::EmitFunctionEpilog

manmanren added a comment. LGTM otherwise. Cheers, Manman Comment at: lib/CodeGen/CGCall.cpp:2468 @@ +2467,3 @@ + QualType RT; + + if (auto *FD = dyn_cast(CurCodeDecl)) Maybe add comments here on the if else block? http://reviews.llvm.org/D16914

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added inline comments. Comment at: lib/Sema/TypeLocBuilder.cpp:130 @@ +129,3 @@ + else if (CurrentlyHasPadding) { +// Remove 4-byte padding. +memmove([Index + 4], [Index], NumBytesAtAlign4); Expand this comment a little?

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a comment. Thanks for working on this! Manman Comment at: lib/Sema/TypeLocBuilder.cpp:99 @@ +98,3 @@ +// element was pushed. +RemoveOrInsertPadding = NumBytesAtAlign4 != 0; + } This patch seems to do two things: 1> simplify the logic

Re: [PATCH] D16843: [Sema] Fix bug in TypeLocBuilder::pushImpl

manmanren added a subscriber: manmanren. manmanren added a comment. Hi Akira, Can you give a high-level explanation of how this patch fixes the problem? This patch enforces that the capacity is 8-byte aligned, is it required to solve the alignment issue here? Thanks, Manman

r260567 - [PR26550] Use a different TBAA root for C++ vs C.

Author: mren Date: Thu Feb 11 13:19:18 2016 New Revision: 260567 URL: http://llvm.org/viewvc/llvm-project?rev=260567=rev Log: [PR26550] Use a different TBAA root for C++ vs C. This commit changes the root from "Simple C/C++ TBAA" to "Simple C++ TBAA" for C++. The problem is that the type name

r259820 - Fix a crash when there is a typo in the return statement.

Author: mren Date: Thu Feb 4 14:05:40 2016 New Revision: 259820 URL: http://llvm.org/viewvc/llvm-project?rev=259820=rev Log: Fix a crash when there is a typo in the return statement. If the typo happens after a successful deduction for an earlier return statement, we should check if the deduced

r259728 - Bump DiagnosticSemaKinds count; we're close to hitting it.

Author: mren Date: Wed Feb 3 17:35:29 2016 New Revision: 259728 URL: http://llvm.org/viewvc/llvm-project?rev=259728=rev Log: Bump DiagnosticSemaKinds count; we're close to hitting it. $ grep '= DIAG_START_SEMA' include/clang/Basic/DiagnosticIDs.h DIAG_START_ANALYSIS =

r259591 - ObjCXX: fix a crash during typo correction.

Author: mren Date: Tue Feb 2 16:23:03 2016 New Revision: 259591 URL: http://llvm.org/viewvc/llvm-project?rev=259591=rev Log: ObjCXX: fix a crash during typo correction. For ObjCXX, we can create a CastExpr with Kind being CK_UserDefinedConversion and SubExpr being BlockExpr. Specifically one

r259267 - Class Property: generate metadata for class properties in categories.

Author: mren Date: Fri Jan 29 17:45:01 2016 New Revision: 259267 URL: http://llvm.org/viewvc/llvm-project?rev=259267=rev Log: Class Property: generate metadata for class properties in categories. The list of class properties is saved in Old ABI: category->class_properties (category->size will be

r259268 - Class Property: generate metadata for class properties in protocols.

Author: mren Date: Fri Jan 29 17:46:55 2016 New Revision: 259268 URL: http://llvm.org/viewvc/llvm-project?rev=259268=rev Log: Class Property: generate metadata for class properties in protocols. The list of class properties is saved in Old ABI: protocol->ext->class_properties

r259224 - Class Property: parse @dynamic (class).

Author: mren Date: Fri Jan 29 13:05:57 2016 New Revision: 259224 URL: http://llvm.org/viewvc/llvm-project?rev=259224=rev Log: Class Property: parse @dynamic (class). rdar://23891898 Modified: cfe/trunk/lib/Parse/ParseObjc.cpp cfe/trunk/test/SemaObjC/objc-class-property.m Modified:

r259229 - Class Property: generate metadata for class properties in classes.

Author: mren Date: Fri Jan 29 13:22:54 2016 New Revision: 259229 URL: http://llvm.org/viewvc/llvm-project?rev=259229=rev Log: Class Property: generate metadata for class properties in classes. The list of class properties is saved in Old ABI: cls->isa->ext->properties New ABI:

r259226 - Class Property: warn for synthesize on a class property.

Author: mren Date: Fri Jan 29 13:16:39 2016 New Revision: 259226 URL: http://llvm.org/viewvc/llvm-project?rev=259226=rev Log: Class Property: warn for synthesize on a class property. rdar://23891898 Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

manmanren updated this revision to Diff 46301. manmanren added a comment. Addressing comments from Akira and Justin. http://reviews.llvm.org/D16564 Files: lib/CodeGen/ModuleBuilder.cpp test/CodeGen/target-builtin-error-3.c Index: test/CodeGen/target-builtin-error-3.c

r259070 - Class Property: class property and instance property can have the same name.

Author: mren Date: Thu Jan 28 12:49:28 2016 New Revision: 259070 URL: http://llvm.org/viewvc/llvm-project?rev=259070=rev Log: Class Property: class property and instance property can have the same name. Add "enum ObjCPropertyQueryKind" to a few APIs that used to only take the name of the

Re: [PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

stopped? > > -eric > > > On Thu, Jan 28, 2016 at 9:53 AM Justin Bogner <m...@justinbogner.com> > wrote: > >> Manman Ren via cfe-commits <cfe-commits@lists.llvm.org> writes: >> > manmanren created this revision. >> > manmanren added reviewers

r259116 - Check for frontend errors after releasing the Builder.

Author: mren Date: Thu Jan 28 17:29:02 2016 New Revision: 259116 URL: http://llvm.org/viewvc/llvm-project?rev=259116=rev Log: Check for frontend errors after releasing the Builder. Frontend can emit errors when releaseing the Builder. If there are errors before or when releasing the Builder, we

r259119 - Class Property: change PropertyMap to include isClassProperty.

Author: mren Date: Thu Jan 28 17:36:05 2016 New Revision: 259119 URL: http://llvm.org/viewvc/llvm-project?rev=259119=rev Log: Class Property: change PropertyMap to include isClassProperty. PropertyMap used to map IdentifierInfo (name of the property) to ObjcPropertyDecl *. Now that a class

r258979 - Class Property: handle class properties.

Author: mren Date: Wed Jan 27 14:00:32 2016 New Revision: 258979 URL: http://llvm.org/viewvc/llvm-project?rev=258979=rev Log: Class Property: handle class properties. At places where we handle instance properties, if necessary. rdar://23891898 Modified: cfe/trunk/lib/AST/DeclObjC.cpp

r258980 - Class Property: create accessors (class methods) for class property.

Author: mren Date: Wed Jan 27 14:10:32 2016 New Revision: 258980 URL: http://llvm.org/viewvc/llvm-project?rev=258980=rev Log: Class Property: create accessors (class methods) for class property. Change a few places where we assume property accessors can only be instance methods. rdar://23891898

r258824 - Use instance_properties instead of properties. NFC.

Author: mren Date: Tue Jan 26 12:05:23 2016 New Revision: 258824 URL: http://llvm.org/viewvc/llvm-project?rev=258824=rev Log: Use instance_properties instead of properties. NFC. All current properties are instance properties. This is the second patch in a series of patches to support class

r258834 - Class Property: parse property attribute (class).

Author: mren Date: Tue Jan 26 12:52:43 2016 New Revision: 258834 URL: http://llvm.org/viewvc/llvm-project?rev=258834=rev Log: Class Property: parse property attribute (class). This is the third patch in a series of patches to support class properties in addition to instance properties in

r258727 - Move ObjCPropertyDecl to before ObjCContainerDecl.

Author: mren Date: Mon Jan 25 15:52:26 2016 New Revision: 258727 URL: http://llvm.org/viewvc/llvm-project?rev=258727=rev Log: Move ObjCPropertyDecl to before ObjCContainerDecl. After we add ObjCPropertyDecl::isClassProperty, we can use it in ObjCContainerDecl to define filter to iterate over

r258735 - Update comments to match the implementation.

Author: mren Date: Mon Jan 25 16:37:47 2016 New Revision: 258735 URL: http://llvm.org/viewvc/llvm-project?rev=258735=rev Log: Update comments to match the implementation. Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp Modified: cfe/trunk/lib/CodeGen/CGObjCMac.cpp URL:

Re: [PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

manmanren added inline comments. Comment at: lib/CodeGen/CodeGenFunction.cpp:1998 @@ +1997,3 @@ + if (auto *T = EntryBB->getTerminator()) +T->eraseFromParent(); + Yes, you are right. http://reviews.llvm.org/D15599

[PATCH] D16564: Fix an issue where backend crashes after frontend emits an error message

manmanren created this revision. manmanren added reviewers: echristo, rafael, ahatanak. manmanren added a subscriber: cfe-commits. It can happen that frontend emits error message when releasing the builder. When that happens, we emit the error message and continue to invoke backend. Backend will

Re: [PATCH] D15935: Improve diagnostics for literal conversion to Boolean

manmanren added a subscriber: manmanren. manmanren added a comment. Thanks for working on this. This looks good to me overall, but I am not the expert on Sema :] Cheers, Manman Comment at: lib/Sema/SemaChecking.cpp:6985 @@ -6984,6 +6984,3 @@ SmallString<16>

Re: [PATCH] D15599: [CodeGen] Fix a crash that occurs when attribute "naked" is attached to a c++ member function

manmanren added a subscriber: manmanren. manmanren added a comment. Thanks for working on this! A few comments inline. Manman Comment at: lib/CodeGen/CodeGenFunction.cpp:1962 @@ +1961,3 @@ +for (auto *U : I->users()) + InstrsToRemove.push_back(cast(U)); +

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Ping :] http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15314: Fix a bug in unavailable checking

manmanren added a comment. Ping Appreciate comments on the general direction. Cheers, Manman http://reviews.llvm.org/D15314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r255860 - [TLS on Darwin] use CXX_FAST_TLS calling convention for access functions.

Author: mren Date: Wed Dec 16 18:42:36 2015 New Revision: 255860 URL: http://llvm.org/viewvc/llvm-project?rev=255860=rev Log: [TLS on Darwin] use CXX_FAST_TLS calling convention for access functions. Also set nounwind attribute. rdar://problem/9001553 Modified:

[PATCH] D15314: Fix a bug in unavailable checking

manmanren created this revision. manmanren added reviewers: rjmccall, rsmith. manmanren added a subscriber: cfe-commits. The issue — Given the following test case, we don’t emit any message, and will silently ignore the variable "foo2", with a release compiler; we will get an

r252814 - [TLS on Darwin] change how we handle globals with linkonce or weak linkage.

Author: mren Date: Wed Nov 11 16:42:31 2015 New Revision: 252814 URL: http://llvm.org/viewvc/llvm-project?rev=252814=rev Log: [TLS on Darwin] change how we handle globals with linkonce or weak linkage. This is about how we handle static member of a template. Before this commit, we use internal

Re: [PATCH] D13304: Avoid inlining in throw statement

manmanren added a subscriber: manmanren. manmanren added a comment. Inliner currently does not include analysis passes such as BPI and BFI. With the new pass manager, we should be able to hook up inliner with BFI (and we can handle throw in BFI). Before that, maybe we can add this as part of

Re: [clang-tools-extra] r250939 - [clang-tidy] add check cppcoreguidelines-pro-type-vararg

It seems that this commit breaks the following bot http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/12461/ Manman > On Oct 21, 2015, at 1:09 PM, Matthias Gehre via cfe-commits >

Stage 2 bot failure: clang-stage2-configure-Rlto_check

There are 33 commits picked up in this run and we have 107 test failures. This happened at 2pm today. I wonder if any one knows what is going on. http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_check/6222/

Re: [libcxx] r249929 - Split out of .

r maybe adding a Clang feature to let us fix the > bad signature). > > Can you elaborate on how to fix the bad signature by adding a Clang feature? I want to see how hard it is before giving up on trying to fix the signatures. Thanks, Manman > On Oct 15, 2015 11:07 AM, "Manm

Re: [libcxx] r249929 - Split out of .

Hi Richard, This is causing a failure when building povray on iOS. Compilation error: /Users/buildslave/tmp/test-suite-externals/speccpu2006/benchspec/CPU2006/453.povray/src/fileinputoutput.cpp:364:20: error: call to 'strrchr' is ambiguous const char *p=strrchr(name, '.’);

[libcxx] r249926 - Revert r249889 due to bot failure.

Author: mren Date: Fri Oct 9 20:03:55 2015 New Revision: 249926 URL: http://llvm.org/viewvc/llvm-project?rev=249926=rev Log: Revert r249889 due to bot failure. Removed: libcxx/trunk/include/wchar.h Modified: libcxx/trunk/include/cwchar

<    1   2   3