[PATCH] D52873: Remove unwanted signedness conversion from tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL344778: [OpenCL] Remove unwanted signedness conversion from tests (authored by mantognini, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52873: Remove unwanted signedness conversion from tests

This revision was automatically updated to reflect the committed changes. Closed by commit rC344778: [OpenCL] Remove unwanted signedness conversion from tests (authored by mantognini, committed by ). Repository: rC Clang https://reviews.llvm.org/D52873 Files:

[PATCH] D52875: Fix definitions of __builtin_(add|sub|mul)_overflow

This revision was automatically updated to reflect the committed changes. Closed by commit rC344891: [OpenCL] Fix definitions of __builtin_(add|sub|mul)_overflow (authored by mantognini, committed by ). Repository: rC Clang https://reviews.llvm.org/D52875 Files:

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. ping Repository: rC Clang https://reviews.llvm.org/D52879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53871: [OpenCL] Allow clk_event_t comparisons

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, but please add a comment in the test file. Comment at: test/SemaOpenCL/clk_event_t.cl:3 +#define CLK_NULL_EVENT (__builtin_astype(((void*)(__SIZE_MAX__)),

[PATCH] D52873: Remove unwanted signedness conversion from tests

mantognini created this revision. mantognini added a reviewer: Anastasia. Herald added a subscriber: cfe-commits. This is just a minor update of the tests. Repository: rC Clang https://reviews.llvm.org/D52873 Files: test/SemaOpenCL/cl20-device-side-enqueue.cl Index:

[PATCH] D52875: Fix definitions of __builtin_(add|sub|mul)_overflow

mantognini created this revision. mantognini added reviewers: Anastasia, erichkeane. Herald added subscribers: cfe-commits, kristina. Ensure __builtin_(add|sub|mul)_overflow return bool instead of void as per specification (LanguageExtensions). Repository: rC Clang

[PATCH] D52879: Derive builtin return type from its definition

mantognini created this revision. mantognini added reviewers: Anastasia, spatel. Herald added subscribers: cfe-commits, kristina. mantognini added dependencies: D52873: Remove unwanted signedness conversion from tests, D52875: Fix definitions of __builtin_(add|sub|mul)_overflow. Prior to this

[PATCH] D52875: Fix definitions of __builtin_(add|sub|mul)_overflow

mantognini added a comment. In https://reviews.llvm.org/D52875#1255146, @erichkeane wrote: > Can you write tests for this please? Particularly validate the results in a > constexpr context. There are already some tests for those builtins (not sure about constexpr context). They already

[PATCH] D52873: Remove unwanted signedness conversion from tests

mantognini added a comment. Note: the `get_kernel_*` functions used here all return unsigned integers, hence the warning/present patch. Repository: rC Clang https://reviews.llvm.org/D52873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. Please see https://reviews.llvm.org/D55136 for the patch addressing these issues. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52879/new/ https://reviews.llvm.org/D52879 ___ cfe-commits

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. Thank you for the detailed review. I'll work on a patch and add you as reviewer once done (prob. on Monday though). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52879/new/ https://reviews.llvm.org/D52879

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. In D52879#1311177 , @riccibruno wrote: > And moreover I believe this change is subtly incorrect for the following > reason: > The type that is passed into the constructor of the call expression is the > type > of the call

[PATCH] D55136: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins

mantognini created this revision. mantognini added a reviewer: riccibruno. Herald added subscribers: cfe-commits, kristina, yaxunl. This is a follow-up on https://reviews.llvm.org/D52879, addressing a few issues. This: - adds a FIXME for later improvement for specific builtins: I previously

[PATCH] D55136: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rL348120: [OpenCL][Sema] Improve BuildResolvedCallExpr handling of builtins (authored by mantognini, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52879: Derive builtin return type from its definition

This revision was automatically updated to reflect the committed changes. Closed by commit rC347658: Derive builtin return type from its definition (authored by mantognini, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52879/new/

[PATCH] D52879: Derive builtin return type from its definition

mantognini added a comment. In D52879#1309734 , @riccibruno wrote: > I see plenty of `TheCall->setType` left in `Sema::CheckBuiltinFunctionCall` > (`Builtin::BI__builtin_classify_type`, `Builtin::BI__builtin_constant_p`, >

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62591/new/ https://reviews.llvm.org/D62591 ___ cfe-commits mailing list

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

mantognini added inline comments. Comment at: lib/Sema/SemaType.cpp:7355 + // object. + (D.getContext() == DeclaratorContext::AliasDeclContext) || // Do not deduce addr space for types used to define a typedef and the I think this should also

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini created this revision. Herald added subscribers: cfe-commits, Anastasia, yaxunl. Herald added a project: clang. This patch does mainly three things: 1. It fixes a false positive error detection in Sema that is similar to D62156 . The error happens

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added reviewers: Anastasia, rjmccall. mantognini marked 6 inline comments as done. mantognini added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:2016 CGF.EmitCXXDestructorCall(dtor, Dtor_Complete, /*for vbase*/ false, -

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

mantognini marked 2 inline comments as done. mantognini added inline comments. Comment at: cfe/trunk/lib/Sema/SemaExprCXX.cpp:4229 +LangAS AddrSpaceR = +RHSType->getAs()->getPointeeType().getAddressSpace(); +CastKind Kind = Anastasia wrote: >

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL365500: [OpenCL][Sema] Improve address space support for blocks (authored by mantognini, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini created this revision. mantognini added reviewers: rjmccall, Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. This patch ensures built-in functions are rewritten using the proper parent declaration. Tests are added to ensure the functionality

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini updated this revision to Diff 207994. mantognini added a comment. Addressed missing colon in FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/ https://reviews.llvm.org/D64074 Files:

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini added a comment. I'll commit this along with D64083 in a few days in case John has any feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/ https://reviews.llvm.org/D64074

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini marked 10 inline comments as done. mantognini added a comment. Mind the fact that I've rebased the changes onto a more recent master version. If you look at the diff of v1 against v2 you might see some unrelated changes. Let me know if there's anything else that I need to change.

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210080. mantognini added a comment. - Refactored common bits from CheckConstructorDeclarator and CheckDestructorDeclarator. - Added as many "ThisTy" parameter I could. - Addressed issue with identifier format in tests (%N to %var.ascast). Repository:

[PATCH] D64804: [OpenCL][Sema] Minor refactoring and constraint checking

mantognini created this revision. Herald added subscribers: cfe-commits, Anastasia, yaxunl. Herald added a project: clang. Simplify code a bit and add assertion to address post-landing comments from D64083 . Repository: rG LLVM Github Monorepo

[PATCH] D64804: [OpenCL][Sema] Minor refactoring and constraint checking

mantognini added reviewers: Anastasia, rjmccall. mantognini added a comment. This should address the minor refactoring requesting in D64083 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64804/new/

[PATCH] D64083: [OpenCL][Sema] Improve address space support for blocks

mantognini created this revision. mantognini added reviewers: rjmccall, Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. This patch ensures that the following code is compiled identically with -cl-std=CL2.0 and -fblocks -cl-std=c++. kernel void

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini updated this revision to Diff 207569. mantognini added a comment. Address comments: reduce testing & add FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/ https://reviews.llvm.org/D64074 Files:

[PATCH] D64074: [OpenCL][Sema] Fix builtin rewriting

mantognini marked an inline comment as done. mantognini added a comment. I added the FIXME and reduced the amount of testing. Let me know if it looks alright. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64074/new/

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

mantognini requested changes to this revision. mantognini added a comment. This revision now requires changes to proceed. The overall structure seems alright. I'll let people more familiar with the code-base judge whether other important features should be added there as well.

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Thanks for addressing my comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66294/new/ https://reviews.llvm.org/D66294 ___

[PATCH] D66294: [Docs][OpenCL] Release 9.0 notes for OpenCL

mantognini added inline comments. Comment at: docs/ReleaseNotes.rst:209 +Implemented features are: +- Address space behavior is improved in majority of C++ features: + I think Sphinx/RST wants an empty line here. Nitpicking for consistency, could you have a `;`

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

mantognini added a comment. I think this looks good. Maybe the tests should be extended to test `auto` as function return type, and if there's some special handling around `decltype(auto)`, then it should be tested too, but I'm not sure it's actually needed here. What do you think?

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

mantognini added a comment. In `vector_literals_nested.cl`, we have tests for (global) constants. Do you think it would be worth testing those as well in C++ mode? Maybe the two files (`vector_literals_nested.cl` and `vector_literals_valid.cl`) should also be merged as most of their content

[PATCH] D65286: [OpenCL] Allow OpenCL C style vector initialization in C++

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65286/new/ https://reviews.llvm.org/D65286 ___

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini marked an inline comment as done. mantognini added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:496 + // destroyed should have the expected type. + QualType ThisTy = D->getThisType(); Address Addr = rjmccall wrote: > I

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210501. mantognini marked 4 inline comments as done. mantognini added a comment. - Minor refactoring of getThisObjectType - Removed unnecessary assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:2267 QualType ClassTy = C.getTypeDeclType(Decl); - ClassTy = C.getQualifiedType(ClassTy, FPT->getMethodQuals()); - return C.getPointerType(ClassTy); + return C.getQualifiedType(ClassTy,

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

This revision was automatically updated to reflect the committed changes. Closed by commit rL366422: [OpenCL] Improve destructor support in C++ for OpenCL (authored by mantognini, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini reopened this revision. mantognini added a subscriber: ilya-biryukov. mantognini added a comment. This revision is now accepted and ready to land. While investigating PR42665, I've noticed that `getImplicitObjectArgument` doesn't always return a pointer type. For example, when dealing

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210605. mantognini added a comment. Add patch for Bug PR42665. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/ https://reviews.llvm.org/D64569 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini marked an inline comment as done. mantognini added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1758-1764 + if (CE) { +ThisTy = CE->getImplicitObjectArgument()->getType(); +if (ThisTy->isPointerType()) + ThisTy =

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210850. mantognini added a comment. - Add minimal regression test for PR42665 - Add CXXMemberCallExpr::getObjectType() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added a comment. In D64569#1592059 , @rjmccall wrote: > Yes, that's the right fix, although you might also consider adding a > `getObjectType()` to `CXXMemberCallExpr`. Thanks, John, it should be better now, but let me know if I can improve

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini updated this revision to Diff 210341. mantognini marked 16 inline comments as done. mantognini added a comment. - Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64569/new/ https://reviews.llvm.org/D64569 Files:

[PATCH] D64804: [OpenCL][Sema] Minor refactoring and constraint checking

This revision was automatically updated to reflect the committed changes. Closed by commit rL366306: [OpenCL][Sema] Minor refactoring and constraint checking (authored by mantognini, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Beside my two comments, I think this looks good. Comment at: docs/LanguageExtensions.rst:1614 + +By default references will refer to ``__generic`` address space

[PATCH] D64569: [OpenCL] Improve destructor support in C++ for OpenCL

mantognini added a comment. FYI In order to fix buildbot test failures, I've pushed https://reviews.llvm.org/rG1b2da771f561affe36eb5eb0c7a3d2862c5a5c1c. I'll keep an eye on buildbots for additional fallout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

mantognini added a comment. Here are a few comments from me but keep in mind that English is not my primary language Comment at: docs/LanguageExtensions.rst:1562-1565 +C style cast will follow OpenCL C v2.0 rules (s6.5.5). All cast operators will +permit implicit conversion

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Alright, thanks for the explanation. LGTM then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69072/new/ https://reviews.llvm.org/D69072

[PATCH] D69072: [OpenCL] Added doc to describe OpenCL support

mantognini added a comment. Shouldn't this page be referenced from `clang/docs/index.rst`? In the long run, how would this page differ from https://releases.llvm.org/9.0.0/tools/clang/docs/LanguageExtensions.html#opencl-features and

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added a comment. Thanks for your clarifications and updates. Just one tiny question about a test file, but otherwise LGTM. Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24 +template +void test_temp(__global int *par) { + T *var1 = addrspace_cast(par);

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24 +template +void test_temp(__global int *par) { + T *var1 = addrspace_cast(par); + __private T

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:16 // // If the extensions are to be enumerated without the supported OpenCL version, // define OPENCLEXT(ext) where ext is the name of the extension. Anastasia

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini updated this revision to Diff 298333. mantognini added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89372/new/ https://reviews.llvm.org/D89372 Files: clang/include/clang/Basic/OpenCLExtensions.def

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini updated this revision to Diff 298660. mantognini added a comment. Keep cl_khr_byte_addressable_store and cles_khr_int64 out of this PR. Add more details on the extensions being removed in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini added a comment. Herald added a subscriber: dexonsmith. I don't want to stop the wider discussion, that being said I think I've addressed the comment regarding the content of this PR. Let me know if the latest version is fine or needs further addressing. Thanks. Repository: rG

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini created this revision. Herald added subscribers: cfe-commits, kerbowa, Anastasia, yaxunl, nhaehnle, jvesely, jholewinski. Herald added a project: clang. mantognini updated this revision to Diff 298093. mantognini added a comment. mantognini published this revision for review.

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini added a comment. In D89372#2329939 , @yaxunl wrote: > what if users rely on the predefined macros associated with the extension > e.g. cl_khr_srgb_image_writes to enable/disable certain code? > > What's the issue with these extensions not

[PATCH] D89372: [OpenCL] Remove unused extensions

mantognini added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:74 OPENCLEXT_INTERNAL(cl_khr_mipmap_image_writes, 200, ~0U) -OPENCLEXT_INTERNAL(cl_khr_srgb_image_writes, 200, ~0U) OPENCLEXT_INTERNAL(cl_khr_subgroups, 200, ~0U)

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

mantognini added a comment. Looks good overall. Comment at: clang/docs/OpenCLSupport.rst:104 +Clang provides the following new WIP features for the developers to experiment +with and provide early feedback or contribute with further improvements. +Feel free to contact us on

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

mantognini added a comment. When reading the documentation [1] for -cl-ext (which I've never used so far), I've noticed nothing is said about non-standard configurations (such as disabling cl_khr_depth_images with CL2.0). Quickly testing this shows that options can be specified to produce

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added inline comments. Comment at: clang/include/clang-c/Index.h:2057 + */ + CXCursor_CXXAddrspaceCastExpr = 129, + hans wrote: > Anastasia wrote: > > hans wrote: > > > akyrtzi wrote: > > > > Hi Anastasia, apologies for not catching this earlier,

[PATCH] D91429: [OpenCL] Stop opencl-c-base.h leaking extension enabling

mantognini added a comment. LGMT as it reduces the divergence in compilation flows. I let @Anastasia, or someone else more familiar with the codebase, give the final approval though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91429/new/

[PATCH] D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbdbd020d2c2: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr (authored by mantognini). Repository: rG LLVM Github Monorepo

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini added a comment. I've put up https://reviews.llvm.org/D90385 as a fix for this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 ___ cfe-commits

[PATCH] D90385: Address ABI issues introduced with CXCursor_CXXAddrspaceCastExpr

mantognini created this revision. mantognini added reviewers: arphaman, akyrtzi, rsmith, Anastasia. Herald added a project: clang. Herald added a subscriber: cfe-commits. mantognini updated this revision to Diff 301579. mantognini added a comment. mantognini published this revision for review.

[PATCH] D89372: [OpenCL] Remove unused extensions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa779a169931c: [OpenCL] Remove unused extensions (authored by

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. Looks good, only a few typos and minor comments. Comment at: clang/docs/OpenCLSupport.rst:69

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. LGTM, except for a minor typo. Otherwise my comments have been addressed. Thanks. Comment at: clang/docs/OpenCLSupport.rst:69

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027 ___ cfe-commits

[PATCH] D94027: [OpenCL] Add clang extension for variadic functions

mantognini added a comment. LGTM, just one question: I see in the other review you updated clang/test/SemaOpenCL/extension-version.cl. Do you need to do the same here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94027/new/ https://reviews.llvm.org/D94027

[PATCH] D94021: [OpenCL] Add clang extension for function pointers

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94021/new/ https://reviews.llvm.org/D94021 ___ cfe-commits mailing list

[PATCH] D94188: [OpenCL] Documentation for experimental C++ libraries support

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94188/new/ https://reviews.llvm.org/D94188 ___ cfe-commits mailing list

[PATCH] D93958: [OpenCL] Restrict pointer to member functions

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. lgtm, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93958/new/ https://reviews.llvm.org/D93958 ___ cfe-commits mailing

[PATCH] D93942: [OpenCL] Improve online documentation.

mantognini added a comment. Thanks for the update. Looks good overall. A minor question about backticks. I'm no native English speaker, so I would recommend a second review from someone else too. Comment at: clang/docs/OpenCLSupport.rst:69

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

mantognini added a comment. Looks sensible to me. Comment at: clang/test/SemaOpenCLCXX/members.cl:17 - -template struct remove_reference { typedef T type; }; -template struct remove_reference { typedef T type; }; I wonder, do we lose coverage by removing

[PATCH] D95442: [OpenCL] Add diagnostics for references to functions

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Right, thanks for the explanations. They make sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95442/new/ https://reviews.llvm.org/D95442

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100976/new/ https://reviews.llvm.org/D100976 ___

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini added inline comments. Comment at: clang/test/Parser/opencl-atomics-cl20.cl:34 atomic_ptrdiff_t pd; -// OpenCL v2.0 s6.13.11.8, _Atomic type specifier and _Atomic type qualifier -// are not supported by OpenCL. - _Atomic int i; // expected-error {{use of

[PATCH] D100976: [OpenCL] Simplify use of C11 atomic types

mantognini added a comment. > This change removes the requirement on pragma when atomic types from the > extensions are supported because the behavior is not conformant. With this > change, the developers can use atomic types from the extensions if they are > supported without enabling the

[PATCH] D101043: [OpenCL] Drop extension pragma handling for extension types/declarations

mantognini added a comment. Reasoning and strategy looks sensible to me. I'm not formally approving the patch because I feel I'm not familiar enough with the code base to do that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101043/new/ https://reviews.llvm.org/D101043

[PATCH] D96151: [OpenCL] Fix pipe type printing in arg info metadata

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. Nice refactoring & fix! LGTM. I suppose Stuart's comment about moving `typeNameRef` can be addressed when pushing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96151/new/

[PATCH] D96161: [OpenCL] Fix printing of types with signed prefix in arg info metadata

mantognini accepted this revision. mantognini added a comment. LGTM, thanks. All the comments seem to be addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96161/new/ https://reviews.llvm.org/D96161 ___ cfe-commits mailing list

[PATCH] D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction

mantognini created this revision. Herald added a subscriber: dexonsmith. mantognini published this revision for review. mantognini added inline comments. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Comment at:

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM, thanks for the update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97052/new/ https://reviews.llvm.org/D97052 ___

[PATCH] D97052: [OpenCL] Prevent adding extension pragma by default

mantognini added a comment. Some relatively minor comments, overall direction seems good to me. Comment at: clang/include/clang/Basic/OpenCLOptions.h:67 public: struct OpenCLOptionInfo { // Option starts to be available in this OpenCL version In

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

mantognini added a comment. Some minor comments. Comment at: clang/docs/OpenCLSupport.rst:197 +parsing it should not require clang source code modifications. Most commonly +such extensions add functionality via libraries (by adding new non-native +types or functions) parsed

[PATCH] D97203: [OpenCL][PR49264] Allow taking address of functions by enabling the extension

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. looks appropriate to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97203/new/ https://reviews.llvm.org/D97203 ___ cfe-commits

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

mantognini added a comment. I feel this would be a valuable addition, indeed. Only a minor question from me. Comment at: clang/lib/Driver/Types.cpp:265 .Case("cl", TY_CL) + .Case("clcpp", TY_CLCXX) .Case("cp", TY_CXX) I'm not

[PATCH] D96487: Restore diagnostic handler after CodeGenAction::ExecuteAction

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe54811ff7e0b: Restore diagnostic handler after CodeGenAction::ExecuteAction (authored by mantognini). Repository: rG LLVM Github Monorepo

[PATCH] D100985: [OpenCL] Remove pragma requirement for functions from Arm dot extension

mantognini accepted this revision. mantognini added a comment. Feels appropriate to remove this indeed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100985/new/ https://reviews.llvm.org/D100985 ___ cfe-commits mailing list

[PATCH] D100984: [OpenCL] Remove the need for subgroups extension pragma in enqueue kernel builtins

mantognini accepted this revision. mantognini added a comment. Thanks, I believe this goes in the right direction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100984/new/ https://reviews.llvm.org/D100984 ___ cfe-commits mailing list

[PATCH] D124462: [Analyzer] Fix clang::ento::taint::dumpTaint definition

mantognini created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. mantognini published this revision for review. mantognini added

[PATCH] D124461: [Analyzer] Remove undefined function

mantognini created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. mantognini added reviewers: NoQ, baloghadamsoftware. mantognini published this

[PATCH] D126197: [analyzer] SATest: Weaken assumption about HTML files

mantognini created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. mantognini published this revision for review. mantognini added reviewers:

  1   2   >