[PATCH] D75153: [ThinLTO] Allow usage of all SMT threads in the system

zero9178 added a comment. This patch seems to break when disabling threading (aka LLVM_ENABLE_THREADS == 0) as get_threadpool_strategy is undefined therefore creating linker failures in clang. (Tested on Windows) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

zero9178 added inline comments. Comment at: clang/test/Driver/cl-permissive.c:15 +// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing" +// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck -check-prefix=PERMISSIVE-MINUS-OVERWRITE %s +//

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

zero9178 added a comment. I shall do that. I do have commit access, but thanks for asking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103773/new/ https://reviews.llvm.org/D103773 ___ cfe-commits

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

zero9178 added a comment. > I think adding /permissive- to make things more conforming is great. The docs > say "Starting in Visual Studio 2019 version 16.8, the /std:c++latest option > implicitly sets the /permissive- option." so maybe we should do that too > (doesn't have to be in this

[PATCH] D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer

zero9178 abandoned this revision. zero9178 added a comment. Thanks for the info, seems like I was mislead after testing it again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103772/new/ https://reviews.llvm.org/D103772 ___ cfe-commits

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

zero9178 created this revision. zero9178 added reviewers: davrec, bruno, rsmith, aaron.ballman. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch addresses a performance issue I noticed when using clang-12 to compile

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

This revision was automatically updated to reflect the committed changes. Closed by commit rG936d6756ccfb: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103749: [clang][driver] Add -foperator-names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9833b57981c4: [clang][driver] Add -foperator-names (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc70b0e808da8: [clang-cl] Add /permissive and /permissive- (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

zero9178 added a comment. In D104182#2815397 , @davrec wrote: > Was this performance hit when using the static analyzer? A quick search > suggests `isAnyDestructorNoReturn()` is only called within the analyzer, > whereas comparable CXXRecordDecl

[PATCH] D104182: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of calculating it on demand

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ff3a89a7b94: [clang][NFC] Add IsAnyDestructorNoReturn field to CXXRecord instead of… (authored by zero9178). Repository: rG LLVM Github Monorepo

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

zero9178 marked an inline comment as done. zero9178 added inline comments. Comment at: clang/test/Driver/cl-permissive.c:15 +// PERMISSIVE-OVERWRITE-NOT: "-fdelayed-template-parsing" +// RUN: %clang_cl /permissive- /Zc:twoPhase- -### -- %s 2>&1 | FileCheck

[PATCH] D103749: [clang][driver] Add -foperator-names

zero9178 created this revision. zero9178 added reviewers: MaskRay, thakis, hans. Herald added a subscriber: dang. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds the command line option -foperator-names which acts

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

zero9178 updated this revision to Diff 350123. zero9178 added a comment. Rebase & add comment in source code explaining the purpose of the define CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103771/new/ https://reviews.llvm.org/D103771 Files: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer

zero9178 updated this revision to Diff 350125. zero9178 added a comment. Rebased onto main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103772/new/ https://reviews.llvm.org/D103772 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td

[PATCH] D103771: [clang][msvc] Define _HAS_STATIC_RTTI to 0, when compiling with -fno-rtti

zero9178 created this revision. zero9178 added reviewers: rnk, thakis, hans. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using the -fno-rtti option of the GCC style clang++, using typeid results in an error. The MSVC STL

[PATCH] D103772: [clang-cl] Reenable /Zc:twoPhase by default if targetting MSVC 2017 Update 3 or newer

zero9178 created this revision. zero9178 added reviewers: rnk, hans, thakis. Herald added a subscriber: dang. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch effectively relands https://reviews.llvm.org/D66394, which

[PATCH] D103773: [clang-cl] Add /permissive and /permissive-

zero9178 created this revision. zero9178 added reviewers: rnk, thakis, hans, mstorsjo. Herald added a subscriber: dang. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds the command line options /permissive and

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 marked an inline comment as done. zero9178 added inline comments. Comment at: llvm/cmake/modules/GetErrcMessages.cmake:3-6 +# The purpose of this function is to supply those error messages to llvm-lit using the errc_messages config +# Currently supplied and needed

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2628477 , @uabelho wrote: > Hi, > > I'm seeing a problem with this. Compiling with gcc 9.3.0 the compilation of > the test program works, but then when I run it I get > > >

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 marked 4 inline comments as done. zero9178 added a comment. I addressed your comments in https://reviews.llvm.org/rG4a17ac0387f078529da02e355a24df99f645d364. Hope it should be alright now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2628527 , @uabelho wrote: > In D98278#2628482 , @zero9178 wrote: > >> In D98278#2628477 , @uabelho wrote: >> >>> so perhaps there should

[PATCH] D98868: [Driver] Add -print-runtime-dir

zero9178 created this revision. zero9178 added reviewers: rnk, phosek, MaskRay. Herald added subscribers: jansvoboda11, dang. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a new command line option to clang which

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2635190 , @ashi1 wrote: > In D98278#2618936 , @zero9178 wrote: > >> In D98278#2616932 , @mstorsjo wrote: >> >>> In D98278#2616916

[PATCH] D98868: [Driver] Add -print-runtime-dir

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaafc3f7be804: [Driver] Add -print-runtime-dir (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2637826 , @mstorsjo wrote: > Btw, while this change does explain _what_ it does, it doesn't actually say > the exact reason _why_. Cleanliness? Sure, that's nice... Or is it a case > where e.g. some translations

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

zero9178 added a comment. In D98278#2638005 , @mstorsjo wrote: > In D98278#2637866 , @zero9178 wrote: > >> In D98278#2637826 , @mstorsjo wrote: >> >>> Btw, while this change

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf2796c76d2f: [test] Add ability to get error messages from CMake for errc substitution (authored by zero9178). Herald added a project: clang.

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 requested review of this revision. zero9178 added a comment. I think this change, while functionality fixing the same as my previous diff, but also fixing the test failure, does deviate a bit from the original review, so I'd like it to be reviewed again if that isn't a problem.

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 updated this revision to Diff 326022. zero9178 added a comment. Undid refactoring of getCompilerRTBasename. Previous diffs introduced a new internal function that built the basename. In that version getCompilerRTBasename simply called getCompilerRT and extracted the filename

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 updated this revision to Diff 326200. zero9178 added a comment. Avoid going through the library directories, checking for the existence of a runtime library, twice by having getCompilerRTBasename call getCompilerRT and simply extract the filename component. To allow other ToolChains to

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 marked an inline comment as done. zero9178 added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:468-469 // Check for runtime files in the new layout without the architecture first. - std::string CRTBasename = - buildCompilerRTBasename(*this, Args,

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 updated this revision to Diff 326178. zero9178 added a comment. Addressed one of the reviewer requests and also uploaded additional files part of the patch that were accidently left out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96638/new/ https://reviews.llvm.org/D96638

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f1b832331e3: Reland [Driver][Windows] Support per-target runtimes dir layout for profile… (authored by zero9178). Repository: rG LLVM Github

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 added a comment. Friendly bump :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96638/new/ https://reviews.llvm.org/D96638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 updated this revision to Diff 325868. zero9178 added a comment. Herald added a subscriber: mstorsjo. Refactored getCompilerRTBasename. It now simply refers to getCompilerRT, which gathers a full path to the specified runtime library. getCompilerRTBasename then simply returns only the

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f9d5d6e444c: [Driver][Windows] Support per-target runtimes dir layout for profile instr… (authored by zero9178). Repository: rG LLVM Github

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 created this revision. zero9178 added reviewers: rnk, russell.gallop. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting a MSVC triple, --dependant-libs with the name of the clang runtime library for

[PATCH] D107893: [clang] [MinGW] Consider the per-target libc++ include directory too

zero9178 added a comment. Any chance this patch could be backported onto the LLVM 13 branch? I have been using a per target runtime builds for a few versions now but the functionality has regressed in LLVM 13, which would force me back into a normal single target layout. Repository: rG

[PATCH] D107893: [clang] [MinGW] Consider the per-target libc++ include directory too

zero9178 added a comment. In D107893#2944193 , @mstorsjo wrote: > In D107893#2943679 , @zero9178 > wrote: > >> Any chance this patch could be backported onto the LLVM 13 branch? I have >> been using a per

[PATCH] D108720: Effectively revert 33c3d8a916c / D33782

zero9178 accepted this revision. zero9178 added a comment. Thanks a lot for the patch :) Wanted this bit of code to be removed for quite some time. > Since D103773 , clang-cl's default mode > completely disables C++ operator > names. That means that query.h

[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

zero9178 created this revision. zero9178 added reviewers: phosek, hans, MaskRay, compnerd. Herald added subscribers: arphaman, mgorny. zero9178 requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Linking against the

[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

zero9178 added a comment. In D109975#3006580 , @Quuxplusone wrote: > Serendipitously, I just yesterday upgraded from OSX 10.14 to 10.15, and have > been unable to build clang because, even with a totally-empty-and-brand-new > build directory, CMake

[PATCH] D109975: [CMake] Consistently use the LibXml2::LibXml2 target instead of LIBXML2_LIBRARIES

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b61f43b6096: [CMake] Consistently use the LibXml2::LibXml2 target instead of… (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 created this revision. zero9178 added reviewers: mstorsjo, rnk. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stdcall name mangling requires a suffix with the number equal to the sum of the byte count of all parameter

[PATCH] D116485: [clang][MinGW] Explicitly ignore `-fPIC` & friends

zero9178 created this revision. zero9178 added reviewers: mstorsjo, compnerd, mati865. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC on Windows ignores this flag completely [0] which some build systems sadly rely on when

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 updated this revision to Diff 397524. zero9178 added a comment. Update test according to reviewers comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116020/new/ https://reviews.llvm.org/D116020 Files: clang/lib/AST/Mangle.cpp

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG782791ee84d2: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling (authored by zero9178). Repository: rG LLVM Github

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 added a comment. Friendly bump :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116020/new/ https://reviews.llvm.org/D116020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

zero9178 added a comment. In D116020#3218453 , @majnemer wrote: > I wonder if we should have different behavior for MSVC targets. > > If I do: > > class Incomplete; > extern "C" int __stdcall Fn(int, Incomplete, long long); > auto fnptr = > > MSVC

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 added a comment. In D114787#3188735 , @aaron.ballman wrote: > https://reviews.llvm.org/D115094 is a review for doing effectively the same > fix. Can you coordinate with the other patch author to determine who will > drive this fix? I sent an

[PATCH] D116485: [clang][MinGW] Explicitly ignore `-fPIC` & friends

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbeeb136abcb: [clang][MinGW] Explicitly ignore `-fPIC` friends (authored by zero9178). Changed prior to commit:

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

zero9178 updated this revision to Diff 390156. zero9178 added a comment. Alternative implementation of the original patch. Moves the defining macro from being added to the cc1 command line by the driver, to being a builtin macro. This should avoid the issues with clang-tidy. CHANGES SINCE

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

zero9178 created this revision. zero9178 added reviewers: rnk, CaseyCarter, hans, thakis. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since VS 2022 17.1 MSVC predefines _MSVC_EXECUTION_CHARACTER_SET to inform the users of the

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

zero9178 added a comment. Seems like this is causing failures in a test for clang-tidy if the triple used is an MSVC one. Let me see what I can do about it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114576/new/ https://reviews.llvm.org/D114576

[PATCH] D114579: [clang-tidy] Exempt _MSVC_EXECUTION_CHARACTER_SET from cppcoreguidelines-macro-usage

zero9178 created this revision. zero9178 added reviewers: MaskRay, aaron.ballman, lebedev.ri, JonasToth, hokein. Herald added subscribers: carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. zero9178 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

zero9178 updated this revision to Diff 389698. zero9178 added a comment. Enable the macro for all MSVC targets, regardless of driver in use. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114576/new/ https://reviews.llvm.org/D114576 Files: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

zero9178 added a comment. Is the deviation from MSVC behaviour here intentional? MSVC flags allow both using a `/` as well as `-` as prefix. That means Both `-Wall` and `/Wall` are accepted by MSVC as well as clang-cl and in both compilers currently lead to ALL warnings being emitted. So this

[PATCH] D114576: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ba70d32736a: [PR52549][clang-cl] Predefine _MSVC_EXECUTION_CHARACTER_SET (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114576/new/

[PATCH] D114579: [clang-tidy] Exempt _MSVC_EXECUTION_CHARACTER_SET from cppcoreguidelines-macro-usage

zero9178 abandoned this revision. zero9178 added a comment. Found another solution to the original issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114579/new/ https://reviews.llvm.org/D114579 ___

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 created this revision. zero9178 added reviewers: dblaikie, aaron.ballman, rsmith. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `-Wdeclaration-after-statement` currently only outputs an diagnostic if the user is

[PATCH] D115576: [clang-tidy][#51939] Exempt placement-new expressions from 'bugprone-throw-keyword-missing'

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7d55771ce3e: [clang-tidy][#51939] Exempt placement-new expressions from bugprone-throw… (authored by zero9178). Changed prior to commit: https://reviews.llvm.org/D115576?vs=393671=394575#toc

[PATCH] D115576: [clang-tidy][#51939] Exempt placement-new expressions from 'bugprone-throw-keyword-missing'

zero9178 added a comment. In D115576#3194944 , @aaron.ballman wrote: > LGTM! Can you also add a release note about the fix? Addressed in the final commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115576: [clang-tidy][#51939] Exempt placement-new expressions from 'bugprone-throw-keyword-missing'

zero9178 created this revision. zero9178 added reviewers: Szelethus, aaron.ballman, alexfh, hokein, whisperity. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. zero9178 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

zero9178 marked 2 inline comments as done. zero9178 added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:4345 + return; } } Quuxplusone wrote: > It seems like this code is overdue for a "compare these two corrections" > //predicate//.

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

zero9178 updated this revision to Diff 398151. zero9178 added a comment. Utilize operator< of std::pair to simplify the comparison A LOT, simplify using llvm::find_if and add additional test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116775/new/

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

This revision was automatically updated to reflect the committed changes. Closed by commit rG118f966b46cf: [clang][#51931] Enable `-Wdeclaration-after-statement` for all C versions (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

zero9178 updated this revision to Diff 398962. zero9178 added a comment. Addressed reviewer nits: - Used proper naming conventions - Adjusted tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116775/new/ https://reviews.llvm.org/D116775 Files: clang/lib/Sema/SemaLookup.cpp

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

This revision was automatically updated to reflect the committed changes. Closed by commit rG6479f03daec1: [clang][#47272] Avoid suggesting deprecated version of a declaration over… (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122682: [clang][DR] Add test for DR1227 and mark it as complete

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe59335e89110: [clang][DR] Add test for DR1227 and mark it as complete (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D122682: [clang][DR] Add test for DR1227 and mark it as complete

zero9178 created this revision. zero9178 added a reviewer: clang-language-wg. Herald added a project: All. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR: http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1227 This

[PATCH] D122620: [clang][DR] Test and mark DR1479 as complete

zero9178 created this revision. zero9178 added a reviewer: clang-language-wg. Herald added a project: All. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR: http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1479

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

zero9178 created this revision. zero9178 added a reviewer: clang-language-wg. Herald added a project: All. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR: http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#1305 This

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

zero9178 updated this revision to Diff 418941. zero9178 added a comment. Address reviewers comments: Group test nicely with the other dr namespaces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122674/new/ https://reviews.llvm.org/D122674 Files: clang/test/CXX/drs/dr13xx.cpp

[PATCH] D122674: [clang][DR] Test and mark DR1305 as complete

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e614c8eb50: [clang][DR] Test and mark DR1305 as complete (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122620: [clang][DR] Test and mark DR1479 as complete

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG984554f846c4: [clang][DR] Test and mark DR1479 as complete (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D118386: [Support][NFC] Fix generic `ChildrenGetterTy` of `IDFCalculatorBase`

zero9178 created this revision. zero9178 added reviewers: Szelethus, jmorse, kuhar. Herald added subscribers: Chia-hungDuan, dexonsmith, rriddle, hiraditya. zero9178 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, stephenneuendorffer. Herald added projects:

[PATCH] D118386: [Support][NFC] Fix generic `ChildrenGetterTy` of `IDFCalculatorBase`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0b11c7659f8: [Support][NFC] Fix generic `ChildrenGetterTy` of `IDFCalculatorBase` (authored by zero9178). Changed prior to commit:

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 marked an inline comment as done. zero9178 added inline comments. Comment at: clang/test/Sema/warn-mixed-decls.c:1-4 +/* RUN: %clang_cc1 -fsyntax-only -verify -std=c89 -pedantic %s + */ +/* RUN: %clang_cc1 -fsyntax-only -verify -std=c99 -Wdeclaration-after-statement %s

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 updated this revision to Diff 397857. zero9178 added a comment. Addressed reviewer comments: Added tests for cases when the diagnostic should not be emitted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114787/new/ https://reviews.llvm.org/D114787 Files:

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 updated this revision to Diff 397971. zero9178 marked an inline comment as done. zero9178 added a comment. Improved error messages and adjusted tests accordingly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114787/new/ https://reviews.llvm.org/D114787 Files:

[PATCH] D114787: [clang][PR51931] Enable `-Wdeclaration-after-statement` for all C versions

zero9178 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9865 def ext_mixed_decls_code : Extension< "ISO C90 forbids mixing declarations and code">, + InGroup; aaron.ballman wrote: > In the other review, I left a comment

[PATCH] D116775: [clang][#47272] Avoid suggesting deprecated version of a declaration over another in typo correction

zero9178 created this revision. zero9178 added reviewers: Quuxplusone, aaron.ballman, rsmith. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this patch, clang might suggest a deprecated name of a declaration over

[PATCH] D124312: [Driver] Call hasFlag instead of hasArg

zero9178 accepted this revision. zero9178 added a comment. This revision is now accepted and ready to land. Ouch! Two bugs, and the one in the testsuite covered up the former one. Thank you for noticing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136548: [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3637dc601c49: [clang][CodeGen] Consistently return nullptr Values for void builtins and… (authored by zero9178). Repository: rG LLVM Github

[PATCH] D136548: [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

zero9178 created this revision. zero9178 added reviewers: erichkeane, rjmccall, efriedma, asl, aaron.ballman. Herald added a project: All. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A common post condition of the various

[PATCH] D136548: [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

zero9178 updated this revision to Diff 470002. zero9178 added a comment. Rebase and boop CI CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136548/new/ https://reviews.llvm.org/D136548 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D136548: [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

zero9178 updated this revision to Diff 470071. zero9178 added a comment. clang-format and specify target triple in test since mangling is target dependent CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136548/new/ https://reviews.llvm.org/D136548 Files:

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

zero9178 added inline comments. Comment at: clang/www/hacking.html:295-296 + directory will cause the update of the diff to start a CI run. This dummy + file will also add the libc++ group to the list of reviewers. The status of + the build will be available in Phabricator. +

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

zero9178 added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:26 + + mutable std::optional Detector; + Any reason this is `mutable`? I don't see it being used a non-const way in a const method Repository: rG LLVM Github Monorepo

[PATCH] D146422: [NFC] Fix typo in comment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64276eec7ed0: [clang][NFC] Fix typo in comment (authored by 1lyasm, committed by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D146422: [NFC] Fix typo in comment

zero9178 accepted this revision. zero9178 added a comment. This revision is now accepted and ready to land. LGTM. The Windows CI failure you can probably ignore, seems to be just a flaky test or maybe some other recent change that caused it. Do Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

zero9178 added inline comments. Comment at: clang/lib/Driver/ToolChains/LazyDetector.h:26 + + mutable std::optional Detector; + serge-sans-paille wrote: > zero9178 wrote: > > Any reason this is `mutable`? I don't see it being used a non-const way in > > a