[PATCH] D28260: Add an argumentsAre matcher

fowles added a subscriber: jdennett. fowles added a comment. @jdennett wanted this matcher for something he is working on and I had some free cycles to write it up. Unfortunately, I am about to leave on an extended vacation, so I will not be able to follow up with this patch for 2 months at

[PATCH] D28260: Add an argumentsAre matcher

fowles created this revision. fowles added a reviewer: klimek. fowles added a subscriber: cfe-commits. Add an argumentsAre matcher https://reviews.llvm.org/D28260 Files: include/clang/ASTMatchers/ASTMatchers.h unittests/ASTMatchers/ASTMatchersTraversalTest.cpp Index:

[PATCH] D33623: Make the parser close parens for you on EOF

fowles created this revision. Herald added a subscriber: klimek. Makes the parser for clang-query auto close all open parens on EOF https://reviews.llvm.org/D33623 Files: lib/ASTMatchers/Dynamic/Parser.cpp unittests/ASTMatchers/Dynamic/ParserTest.cpp Index:

[PATCH] D33623: Make the parser close parens for you on EOF

fowles abandoned this revision. fowles added a comment. Switching to https://reviews.llvm.org/D33679 for sbenza's suggestion https://reviews.llvm.org/D33623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33679: Make clang-query close parens for you

fowles created this revision. Make clang-query close parens for you https://reviews.llvm.org/D33679 Files: clang-query/QueryParser.cpp Index: clang-query/QueryParser.cpp === --- clang-query/QueryParser.cpp +++

[PATCH] D33679: Make clang-query close parens for you

fowles updated this revision to Diff 100716. fowles added a comment. Add tests for real https://reviews.llvm.org/D33679 Files: clang-query/QueryParser.cpp test/clang-query/missing-parens.c Index: test/clang-query/missing-parens.c

[PATCH] D33679: Make clang-query close parens for you

fowles updated this revision to Diff 100715. fowles added a comment. Add a test https://reviews.llvm.org/D33679 Files: clang-query/QueryParser.cpp Index: clang-query/QueryParser.cpp === --- clang-query/QueryParser.cpp +++

[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

fowles added inline comments. Comment at: include/clang/AST/ExprCXX.h:218 + SourceLocation RP, unsigned MinNumArgs = 0, + bool UsesADL = false) : CallExpr(C, CUDAKernelCallExprClass, fn, Config, args, t, VK, RP, Can

[PATCH] D78323: [clang] Fix invalid comparator in tablegen

fowles added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78323/new/ https://reviews.llvm.org/D78323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

fowles added a comment. That is awesome! Thanks for much for the examples. Everything here LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113575/new/ https://reviews.llvm.org/D113575 ___

[PATCH] D113575: Add `isInitCapture` and `forEachLambdaCapture` matchers.

fowles added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4224 +/// float z; +/// auto f = [=]() { return x + y + z; }; +/// } it would be nice to be able to do something like ``` int main() { int x, y; float z;

[PATCH] D112491: Add `LambdaCapture`-related matchers.

fowles added a comment. This is great! Comment at: clang/docs/LibASTMatchersReference.html:8368 +lambdaExpr(hasAnyCapture(lambdaCapture(capturesVar(hasName("x", +capturesVar(hasName("x")) matches `int x` and `x = 1`. I think this should be "matches `x`

[PATCH] D112491: Add `LambdaCapture`-related matchers.

fowles added a comment. Do we also want a `forEachCapture` matcher? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112491/new/ https://reviews.llvm.org/D112491 ___ cfe-commits mailing list

[PATCH] D112491: Add `LambdaCapture`-related matchers.

fowles added a comment. In D112491#3108631 , @aaron.ballman wrote: > That might be good follow-on work (I wouldn't insist on it for this patch > though). Completely agreed, just something that occurred to me as the next thing I will need when

[PATCH] D141547: Fix format for `case` in .proto files

fowles updated this revision to Diff 488979. fowles added a comment. Move from lit test to unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141547/new/ https://reviews.llvm.org/D141547 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D141547: Fix format for `case` in .proto files

fowles created this revision. fowles added a reviewer: krasimir. Herald added a project: All. fowles requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix format for `case` in .proto files Repository: rG LLVM Github Monorepo