[clang] 26eec9e - Revert "[clang] Implement Change scope of lambda trailing-return-type"

Author: Mehdi Amini Date: 2022-04-13T19:35:13Z New Revision: 26eec9e9dbc20186f6b810fe01d3a01aac8ae6f4 URL: https://github.com/llvm/llvm-project/commit/26eec9e9dbc20186f6b810fe01d3a01aac8ae6f4 DIFF: https://github.com/llvm/llvm-project/commit/26eec9e9dbc20186f6b810fe01d3a01aac8ae6f4.diff LOG:

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Thu, Sep 30, 2021 at 8:05 PM Hubert Tong wrote: > > On Thu, Sep 30, 2021 at 6:56 PM Mehdi AMINI via cfe-commits > wrote: >> >> We talked about this with the IWG (Infrastructure Working Group) just >> last week coincidentally. >> Two major blo

Re: [llvm-dev] Phabricator Creator Pulling the Plug

On Thu, Sep 30, 2021 at 4:09 PM Brian Cain wrote: > > > > On Thu, Sep 30, 2021, 6:04 PM Brian Cain wrote: >> >> Does something like Rust's "bors" bot satisfy the herald rules need? > > > > sorry, maybe I was thinking of the high-five bot. And it looks like that's > not quite a match for herald.

Re: [llvm-dev] Phabricator Creator Pulling the Plug

We talked about this with the IWG (Infrastructure Working Group) just last week coincidentally. Two major blocking tracks that were identified at the roundtable during the LLVM Dev Meeting exactly 2 years ago are still an issue today: 1) Replacement for Herald rules. This is what allows us to

[clang] 28c0479 - Revert "[Matrix] Overload stride arg in matrix.columnwise.load/store."

Author: Mehdi Amini Date: 2021-08-12T11:57:19Z New Revision: 28c04794df74ad3c38155a244729d1f8d57b9400 URL: https://github.com/llvm/llvm-project/commit/28c04794df74ad3c38155a244729d1f8d57b9400 DIFF: https://github.com/llvm/llvm-project/commit/28c04794df74ad3c38155a244729d1f8d57b9400.diff LOG:

[clang-tools-extra] 7637457 - Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

Author: Mehdi Amini Date: 2021-07-16T07:38:16Z New Revision: 76374573ce829b083b95b74937a11e9b91f8f45f URL: https://github.com/llvm/llvm-project/commit/76374573ce829b083b95b74937a11e9b91f8f45f DIFF: https://github.com/llvm/llvm-project/commit/76374573ce829b083b95b74937a11e9b91f8f45f.diff LOG:

[clang-tools-extra] 8d051d8 - Revert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer"

Author: Mehdi Amini Date: 2021-07-16T07:35:13Z New Revision: 8d051d854619956de633047409149cdab1e3319a URL: https://github.com/llvm/llvm-project/commit/8d051d854619956de633047409149cdab1e3319a DIFF: https://github.com/llvm/llvm-project/commit/8d051d854619956de633047409149cdab1e3319a.diff LOG:

[clang-tools-extra] af93217 - Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

Author: Mehdi Amini Date: 2021-07-16T06:54:26Z New Revision: af9321739b20becf170e6bb5060b8d780e1dc8dd URL: https://github.com/llvm/llvm-project/commit/af9321739b20becf170e6bb5060b8d780e1dc8dd DIFF: https://github.com/llvm/llvm-project/commit/af9321739b20becf170e6bb5060b8d780e1dc8dd.diff LOG:

[clang] 16b5e9d - Revert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer"

Author: Mehdi Amini Date: 2021-07-16T03:46:53Z New Revision: 16b5e9d6a269913e8da0fa037e8af32eaf304c8f URL: https://github.com/llvm/llvm-project/commit/16b5e9d6a269913e8da0fa037e8af32eaf304c8f DIFF: https://github.com/llvm/llvm-project/commit/16b5e9d6a269913e8da0fa037e8af32eaf304c8f.diff LOG:

[clang-tools-extra] 16b5e9d - Revert "Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer"

Author: Mehdi Amini Date: 2021-07-16T03:46:53Z New Revision: 16b5e9d6a269913e8da0fa037e8af32eaf304c8f URL: https://github.com/llvm/llvm-project/commit/16b5e9d6a269913e8da0fa037e8af32eaf304c8f DIFF: https://github.com/llvm/llvm-project/commit/16b5e9d6a269913e8da0fa037e8af32eaf304c8f.diff LOG:

[clang] 42f588f - Use ManagedStatic and lazy initialization of cl::opt in libSupport to make it free of global initializer

Author: Mehdi Amini Date: 2021-07-16T03:33:20Z New Revision: 42f588f39c5ce6f521e3709b8871d1fdd076292f URL: https://github.com/llvm/llvm-project/commit/42f588f39c5ce6f521e3709b8871d1fdd076292f DIFF: https://github.com/llvm/llvm-project/commit/42f588f39c5ce6f521e3709b8871d1fdd076292f.diff LOG:

[clang] 42e88bd - Replace sequences of v.push_back(v[i]); v.erase([i]); with std::rotate (NFC)

Author: Mehdi Amini Date: 2020-11-14T00:55:33Z New Revision: 42e88bd6b18597fe0a46ee9663d4e2cf2f7a4e57 URL: https://github.com/llvm/llvm-project/commit/42e88bd6b18597fe0a46ee9663d4e2cf2f7a4e57 DIFF: https://github.com/llvm/llvm-project/commit/42e88bd6b18597fe0a46ee9663d4e2cf2f7a4e57.diff LOG:

[clang] f917356 - Revert "[clang][cli] Port ObjCMTAction to new option parsing system"

Author: Mehdi Amini Date: 2020-11-11T20:01:03Z New Revision: f917356f9ce026f9be9972b8c75cd3ba00e43497 URL: https://github.com/llvm/llvm-project/commit/f917356f9ce026f9be9972b8c75cd3ba00e43497 DIFF: https://github.com/llvm/llvm-project/commit/f917356f9ce026f9be9972b8c75cd3ba00e43497.diff LOG:

[clang] 0fb2203 - [Docs] Fix --print-supported-cpus option rendering

Author: Travis Finkenauer Date: 2020-09-13T05:26:18Z New Revision: 0fb2203cd6c287e7438b7ac2571645066c63eeb6 URL: https://github.com/llvm/llvm-project/commit/0fb2203cd6c287e7438b7ac2571645066c63eeb6 DIFF: https://github.com/llvm/llvm-project/commit/0fb2203cd6c287e7438b7ac2571645066c63eeb6.diff

[clang] a407ec9 - Revert "Revert "[NFC][llvm] Make the contructors of `ElementCount` private.""

Author: Mehdi Amini Date: 2020-08-19T17:26:36Z New Revision: a407ec9b6db1e29e9aa361819f499ad11038d2dd URL: https://github.com/llvm/llvm-project/commit/a407ec9b6db1e29e9aa361819f499ad11038d2dd DIFF: https://github.com/llvm/llvm-project/commit/a407ec9b6db1e29e9aa361819f499ad11038d2dd.diff LOG:

[clang] 4fc56d7 - Revert "[NFC][llvm] Make the contructors of `ElementCount` private."

Author: Mehdi Amini Date: 2020-08-19T17:21:37Z New Revision: 4fc56d70aadea9df88e7bf408e2e203dc79ff8e6 URL: https://github.com/llvm/llvm-project/commit/4fc56d70aadea9df88e7bf408e2e203dc79ff8e6 DIFF: https://github.com/llvm/llvm-project/commit/4fc56d70aadea9df88e7bf408e2e203dc79ff8e6.diff LOG:

[clang] 72d20b9 - [LLVM] Change isa<> to a variadic function template

Author: Rahul Joshi Date: 2020-06-15T18:46:57Z New Revision: 72d20b9604f65e35eedb3d00098a2c9412953946 URL: https://github.com/llvm/llvm-project/commit/72d20b9604f65e35eedb3d00098a2c9412953946 DIFF: https://github.com/llvm/llvm-project/commit/72d20b9604f65e35eedb3d00098a2c9412953946.diff LOG:

[clang] d31c9e5 - Change filecheck default to dump input on failure

Author: Mehdi Amini Date: 2020-06-09T18:57:46Z New Revision: d31c9e5a46ee692daf2430b52626afcea1db18ab URL: https://github.com/llvm/llvm-project/commit/d31c9e5a46ee692daf2430b52626afcea1db18ab DIFF: https://github.com/llvm/llvm-project/commit/d31c9e5a46ee692daf2430b52626afcea1db18ab.diff LOG:

[clang] ed03d94 - Revert "[TLI] Per-function fveclib for math library used for vectorization"

Author: Mehdi Amini Date: 2020-04-11T01:05:01Z New Revision: ed03d9485eb5b502708f8a21ce34fa6da05a9ca5 URL: https://github.com/llvm/llvm-project/commit/ed03d9485eb5b502708f8a21ce34fa6da05a9ca5 DIFF: https://github.com/llvm/llvm-project/commit/ed03d9485eb5b502708f8a21ce34fa6da05a9ca5.diff LOG:

[clang] bbeeb35 - Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

Author: Mehdi Amini Date: 2020-04-10T07:44:06Z New Revision: bbeeb35c1ffaf7aeb3241bdfcb69bf4708370ac1 URL: https://github.com/llvm/llvm-project/commit/bbeeb35c1ffaf7aeb3241bdfcb69bf4708370ac1 DIFF: https://github.com/llvm/llvm-project/commit/bbeeb35c1ffaf7aeb3241bdfcb69bf4708370ac1.diff LOG:

[clang] 0445c64 - [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

Author: Alina Sbirlea Date: 2020-04-10T07:38:53Z New Revision: 0445c64998d14b81f0d3a3182011fc5eae47fa71 URL: https://github.com/llvm/llvm-project/commit/0445c64998d14b81f0d3a3182011fc5eae47fa71 DIFF: https://github.com/llvm/llvm-project/commit/0445c64998d14b81f0d3a3182011fc5eae47fa71.diff

[clang] 57d2d48 - Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

Author: Mehdi Amini Date: 2020-04-10T06:27:59Z New Revision: 57d2d48399b63c0ef1dda490fdaf28efbb80c2c0 URL: https://github.com/llvm/llvm-project/commit/57d2d48399b63c0ef1dda490fdaf28efbb80c2c0 DIFF: https://github.com/llvm/llvm-project/commit/57d2d48399b63c0ef1dda490fdaf28efbb80c2c0.diff LOG:

Re: r311857 - Emit static constexpr member as available_externally definition

will follow-up in the PR. > > -- > Mehdi > > > 2017-08-28 12:42 GMT-07:00 Hans Wennborg <h...@chromium.org>: > >> I reverted this in r311898 as it caused Chromium builds to fail with >> an assertion; see PR34348. >> >> On Sun, Aug 27, 2017 at 1

r312512 - Emit static constexpr member as available_externally definition

Author: mehdi_amini Date: Mon Sep 4 20:58:35 2017 New Revision: 312512 URL: http://llvm.org/viewvc/llvm-project?rev=312512=rev Log: Emit static constexpr member as available_externally definition By exposing the constant initializer, the optimizer can fold many of these constructs. This is a

Re: r311857 - Emit static constexpr member as available_externally definition

Sorry for the inconvenience! I will follow-up in the PR. -- Mehdi 2017-08-28 12:42 GMT-07:00 Hans Wennborg <h...@chromium.org>: > I reverted this in r311898 as it caused Chromium builds to fail with > an assertion; see PR34348. > > On Sun, Aug 27, 2017 at 1:24 PM, Mehdi Ami

r311858 - CMake: only try to find the Z3 package when `CLANG_ANALYZER_BUILD_Z3` is ON

Author: mehdi_amini Date: Sun Aug 27 13:24:23 2017 New Revision: 311858 URL: http://llvm.org/viewvc/llvm-project?rev=311858=rev Log: CMake: only try to find the Z3 package when `CLANG_ANALYZER_BUILD_Z3` is ON This avoids the spurious message: Could NOT find Z3 (missing: Z3_LIBRARIES

r311857 - Emit static constexpr member as available_externally definition

Author: mehdi_amini Date: Sun Aug 27 13:24:09 2017 New Revision: 311857 URL: http://llvm.org/viewvc/llvm-project?rev=311857=rev Log: Emit static constexpr member as available_externally definition By exposing the constant initializer, the optimizer can fold many of these constructs.

Re: [PATCH] D34992: Emit static constexpr member as available_externally definition

The LLVM verifier is complaining that dllimport have to be external linkage and isn't happy with available_externally, is the verifier wrong? 2017-07-05 9:12 GMT-07:00 David Majnemer : > I don't think you need the dllimport restriction. > > On Wed, Jul 5, 2017 at 12:05

r304127 - IRGen: Add optnone attribute on function during O0

Author: mehdi_amini Date: Mon May 29 00:38:20 2017 New Revision: 304127 URL: http://llvm.org/viewvc/llvm-project?rev=304127=rev Log: IRGen: Add optnone attribute on function during O0 Amongst other, this will help LTO to correctly handle/honor files compiled with O0, helping debugging failures.

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

> On Apr 20, 2017, at 7:03 PM, Eric Fiselier wrote: > > > > On Thu, Apr 20, 2017 at 4:55 PM, Mehdi Amini > wrote: > >> On Apr 20, 2017, at 12:30 PM, Eric Fiselier > > wrote: >> >> >>

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

> On Apr 20, 2017, at 12:30 PM, Eric Fiselier wrote: > > > > On Thu, Apr 20, 2017 at 11:06 AM, Mehdi Amini > wrote: > >> On Apr 20, 2017, at 12:39 AM, Eric Fiselier > > wrote: >> >>

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

> On Apr 20, 2017, at 12:39 AM, Eric Fiselier wrote: > > > > On Wed, Apr 19, 2017 at 11:19 PM, Mehdi Amini > wrote: > What would be the status of these buildbots? Is it for your private usage? > > I intend for them to be

Re: [llvm-dev] Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

What would be the status of these buildbots? Is it for your private usage? Otherwise having “project' bots” using a non-official mirror may sound like a strange situation to me. — Mehdi > On Apr 19, 2017, at 5:04 PM, Eric Fiselier via llvm-dev > wrote: > > Adding

Re: [libcxx] r299652 - Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541

Hi, I reverted in r299656. MacOS bot is broken both on 64 and 32 bits: http://green.lab.llvm.org/green/job/libcxx_master_cmake/83/ http://green.lab.llvm.org/green/job/libcxx_master_cmake_32/61/ It shouldn’t be too hard to fix though, it is full of the same error:

[libcxx] r299656 - Revert "Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541"

Author: mehdi_amini Date: Thu Apr 6 10:56:55 2017 New Revision: 299656 URL: http://llvm.org/viewvc/llvm-project?rev=299656=rev Log: Revert "Restore Missing awk regex tests. Thanks to dexonsmith for noticing, and proposing this as https://reviews.llvm.org/D16541; This reverts commit r299652,

[libcxx] r299607 - Fix remote test execution in lit

Author: mehdi_amini Date: Wed Apr 5 20:14:57 2017 New Revision: 299607 URL: http://llvm.org/viewvc/llvm-project?rev=299607=rev Log: Fix remote test execution in lit Can be used as such: $ python /path/to/lit.py -sv /path/to/llvm/build/projects/libcxx/test/ \

[libcxx] r299606 - Use alternate string layout for ARMv7k

Author: mehdi_amini Date: Wed Apr 5 20:10:22 2017 New Revision: 299606 URL: http://llvm.org/viewvc/llvm-project?rev=299606=rev Log: Use alternate string layout for ARMv7k Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL:

[libcxxabi] r299414 - Uses quote to include cxxabi.h to make sure the local one is included

Author: mehdi_amini Date: Tue Apr 4 00:38:38 2017 New Revision: 299414 URL: http://llvm.org/viewvc/llvm-project?rev=299414=rev Log: Uses quote to include cxxabi.h to make sure the local one is included Modified: libcxxabi/trunk/src/cxa_exception.hpp

[libcxx] r299057 - libc++ testing: fix invalid python syntax

Author: mehdi_amini Date: Thu Mar 30 00:21:33 2017 New Revision: 299057 URL: http://llvm.org/viewvc/llvm-project?rev=299057=rev Log: libc++ testing: fix invalid python syntax Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL:

[libcxx] r299056 - libc++ testing: fix assertion around `use_system_cxx_lib`

Author: mehdi_amini Date: Thu Mar 30 00:07:18 2017 New Revision: 299056 URL: http://llvm.org/viewvc/llvm-project?rev=299056=rev Log: libc++ testing: fix assertion around `use_system_cxx_lib` Actually fix (hopefully) the assertions about `use_system_cxx_lib`, the previous attempt failed because I

[libcxx] r299055 - libc++ config testing: `use_system_cxx_lib` can be a bool

Author: mehdi_amini Date: Wed Mar 29 23:51:19 2017 New Revision: 299055 URL: http://llvm.org/viewvc/llvm-project?rev=299055=rev Log: libc++ config testing: `use_system_cxx_lib` can be a bool Fix the libc++ Green Dragon bot. Modified: libcxx/trunk/utils/libcxx/test/config.py Modified:

[libcxx] r299054 - Reexport operator new / delete from libc++abi

Author: mehdi_amini Date: Wed Mar 29 23:47:19 2017 New Revision: 299054 URL: http://llvm.org/viewvc/llvm-project?rev=299054=rev Log: Reexport operator new / delete from libc++abi Both libc++ and libc++abi export a weak definition of operator new/delete. On Darwin, this can often cause dirty

[libcxx] r299053 - libc++ testing: allow to provide a path for `use_system_cxx_lib`

Author: mehdi_amini Date: Wed Mar 29 23:45:33 2017 New Revision: 299053 URL: http://llvm.org/viewvc/llvm-project?rev=299053=rev Log: libc++ testing: allow to provide a path for `use_system_cxx_lib` As we're trying to setup testing / bots for all shipping version of libc++ on macOS/iOS, we'll

[libcxx] r299052 - Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete

Author: mehdi_amini Date: Wed Mar 29 23:40:56 2017 New Revision: 299052 URL: http://llvm.org/viewvc/llvm-project?rev=299052=rev Log: Do not pass an explicit reexported symbol list when building libc++ dylib if also defining new/delete Modified: libcxx/trunk/lib/CMakeLists.txt Modified:

Re: [libcxx] r281681 - [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility

Hi, I don't understand clang's logic here, seems like a bug to me. I changed slightly the test-case, and I'm wondering why only foo() is emitted as hidden in the following: #define INLINE_VISIBILITY __attribute__((visibility("hidden"), always_inline)) template struct Foo { void

Re: [libcxx] r281681 - [libc++] Add _LIBCPP_EXTERN_TEMPLATE_INLINE_VISIBILITY to support GCC ABI compatibility

2017-03-29 20:30 GMT-07:00 Duncan P. N. Exon Smith : > > On Mar 29, 2017, at 20:16, Eric Fiselier wrote: > > > > On Wed, Mar 29, 2017 at 9:00 PM, Duncan P. N. Exon Smith < > dexonsm...@apple.com> wrote: > >> Why are we propagating the use of always_inline? >>

[libcxx] r297798 - Add deployment knobs to tests (for Apple platforms)

Author: mehdi_amini Date: Tue Mar 14 19:59:54 2017 New Revision: 297798 URL: http://llvm.org/viewvc/llvm-project?rev=297798=rev Log: Add deployment knobs to tests (for Apple platforms) The tests for libc++ specify -target on the command-line to the compiler, but this is problematic for a few

r297351 - Add a cmake cache file for a stage-2 build with ThinLTO

Author: mehdi_amini Date: Wed Mar 8 19:18:31 2017 New Revision: 297351 URL: http://llvm.org/viewvc/llvm-project?rev=297351=rev Log: Add a cmake cache file for a stage-2 build with ThinLTO This is intended to be targetted by a Green Dragon stage-2 bot I'm bringing up currently. WIP. Added:

[libcxx] r296889 - Fix libc++ test to pass in C++03 mode

Author: mehdi_amini Date: Fri Mar 3 11:24:29 2017 New Revision: 296889 URL: http://llvm.org/viewvc/llvm-project?rev=296889=rev Log: Fix libc++ test to pass in C++03 mode Was hitting: "error: scalar initializer cannot be empty" Modified:

[libcxx] r296830 - Fix libc++ test experimental/algorithms/alg.random.sample/sample.pass.cpp when ran in c++11 mode 32 bits

Author: mehdi_amini Date: Thu Mar 2 16:08:42 2017 New Revision: 296830 URL: http://llvm.org/viewvc/llvm-project?rev=296830=rev Log: Fix libc++ test experimental/algorithms/alg.random.sample/sample.pass.cpp when ran in c++11 mode 32 bits Modified:

[libcxx] r296725 - Recommit r296712: "Fix Apple-specific XFAIL directive in libc++ test"

Author: mehdi_amini Date: Wed Mar 1 20:01:11 2017 New Revision: 296725 URL: http://llvm.org/viewvc/llvm-project?rev=296725=rev Log: Recommit r296712: "Fix Apple-specific XFAIL directive in libc++ test" The test is passing with c++11 and c++14 but not c++1z on this particular version of the

[libcxx] r296724 - Revert "Fix Apple-specific XFAIL directive in libc++ test"

Author: mehdi_amini Date: Wed Mar 1 19:57:40 2017 New Revision: 296724 URL: http://llvm.org/viewvc/llvm-project?rev=296724=rev Log: Revert "Fix Apple-specific XFAIL directive in libc++ test" This reverts commit r296712. It broke our bot. It turns out that the test is passing with c++11 and

[libcxx] r296712 - Fix Apple-specific XFAIL directive in libc++ test

Author: mehdi_amini Date: Wed Mar 1 17:45:03 2017 New Revision: 296712 URL: http://llvm.org/viewvc/llvm-project?rev=296712=rev Log: Fix Apple-specific XFAIL directive in libc++ test This tests is failing in XCode 7.0. But Xcode 7.3 that shipped an updated clang has this test passing. This is

Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

> On Mar 1, 2017, at 3:24 PM, Sean Silva wrote: > > > > On Wed, Mar 1, 2017 at 10:35 AM, Mehdi Amini > wrote: > I’m not sure I find this nice to see this upstream. > > I not fond in general of this kind of

[libcxx] r296704 - Fix Apple-specific XFAIL directive in libc++ test

Author: mehdi_amini Date: Wed Mar 1 17:14:34 2017 New Revision: 296704 URL: http://llvm.org/viewvc/llvm-project?rev=296704=rev Log: Fix Apple-specific XFAIL directive in libc++ test These tests are failing in XCode 8.0, 8.1, and 8.2, but not in Xcode 8.3. Annoyingly the version numbering for

Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

I’m not sure I find this nice to see this upstream. I not fond in general of this kind of difference in behavior. I don’t think it is good for clang to have different default for this kind of settings depending on the platform. It does not provide a very good user experience from a

Re: [libcxx] r294696 - Fully qualify (preprend ::) calls to math functions from libc

Should we get this in 4.0? — Mehdi > On Feb 9, 2017, at 6:44 PM, Mehdi Amini via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: mehdi_amini > Date: Thu Feb 9 20:44:23 2017 > New Revision: 294696 > > URL: http://llvm.org/viewvc/llvm-project

[libcxx] r294696 - Fully qualify (preprend ::) calls to math functions from libc

Author: mehdi_amini Date: Thu Feb 9 20:44:23 2017 New Revision: 294696 URL: http://llvm.org/viewvc/llvm-project?rev=294696=rev Log: Fully qualify (preprend ::) calls to math functions from libc Summary: This can cause a compile failure in cases like: double log(double); namespace foo {

r293370 - Fix typo introduced in r292960 that may affect -flto -save-temps (saving the optimized bitcode)

Author: mehdi_amini Date: Sat Jan 28 00:07:17 2017 New Revision: 293370 URL: http://llvm.org/viewvc/llvm-project?rev=293370=rev Log: Fix typo introduced in r292960 that may affect -flto -save-temps (saving the optimized bitcode) Modified: cfe/trunk/lib/Driver/Tools.cpp Modified:

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

> On Jan 27, 2017, at 2:43 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:13 PM Mehdi Amini > wrote: > CC Hans. > > This is not a regression (AFAICT), but this is a quality improvement, so may > be worth

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

> On Jan 27, 2017, at 2:44 PM, David Blaikie wrote: > > > > On Fri, Jan 27, 2017 at 2:11 PM Mehdi AMINI via Phabricator > > wrote: > mehdi_amini accepted this revision. > mehdi_amini added a comment. > This

Re: [PATCH] D29233: Fix linkage of static locals in available_externally functions to be DiscardableODR/linkonce_odr

CC Hans. This is not a regression (AFAICT), but this is a quality improvement, so may be worth considering in the 4.0 branch? — Mehdi > On Jan 27, 2017, at 2:04 PM, David Blaikie via Phabricator > wrote: > > dblaikie created this revision. > > As Mehdi put it,

[libcxxabi] r293330 - Fix ASAN failure in cxa_demangle

Author: mehdi_amini Date: Fri Jan 27 14:32:16 2017 New Revision: 293330 URL: http://llvm.org/viewvc/llvm-project?rev=293330=rev Log: Fix ASAN failure in cxa_demangle Found with ASAN + libFuzzer by Kostya Serebryany Modified: libcxxabi/trunk/src/cxa_demangle.cpp

[libcxx] r293071 - [libcxx] Mentions "targeting C++11 and above" instead of "targeting C++11" in the doc

Author: mehdi_amini Date: Wed Jan 25 11:00:30 2017 New Revision: 293071 URL: http://llvm.org/viewvc/llvm-project?rev=293071=rev Log: [libcxx] Mentions "targeting C++11 and above" instead of "targeting C++11" in the doc Modified: libcxx/trunk/docs/index.rst Modified:

r292964 - Fix test/Driver/embed-bitcode.c on non-Darwin host by setting the target explicitly

Author: mehdi_amini Date: Tue Jan 24 12:49:49 2017 New Revision: 292964 URL: http://llvm.org/viewvc/llvm-project?rev=292964=rev Log: Fix test/Driver/embed-bitcode.c on non-Darwin host by setting the target explicitly Modified: cfe/trunk/test/Driver/embed-bitcode.c Modified:

r292961 - Forward -bitcode_process_mode to ld64 in marker-only mode

Author: mehdi_amini Date: Tue Jan 24 12:15:21 2017 New Revision: 292961 URL: http://llvm.org/viewvc/llvm-project?rev=292961=rev Log: Forward -bitcode_process_mode to ld64 in marker-only mode Reviewers: steven_wu Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D29066

r292960 - Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

Author: mehdi_amini Date: Tue Jan 24 12:12:25 2017 New Revision: 292960 URL: http://llvm.org/viewvc/llvm-project?rev=292960=rev Log: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly(). Summary: These accessors maps directly to the command line option. Reviewers:

Re: r291318 - PR23135: Don't instantiate constexpr functions referenced in unevaluated operands where possible.

Hi Richard, I have a link failure in WebKit following this patch, the move-assign operator for an nested class isn’t emitted (IRGen) in some context where it is needed. I’m working on running creduce the test-case which is pretty large, but in case it rings a bell, I let you know already. —

r291300 - Add a cc1 option to force disabling lifetime-markers emission from clang

Author: mehdi_amini Date: Fri Jan 6 17:18:09 2017 New Revision: 291300 URL: http://llvm.org/viewvc/llvm-project?rev=291300=rev Log: Add a cc1 option to force disabling lifetime-markers emission from clang Summary: This intended as a debugging/development flag only. Differential Revision:

r291276 - Use CodegenOpts::less when creating a TargetMachine for clang `-O1`

Author: mehdi_amini Date: Fri Jan 6 14:52:30 2017 New Revision: 291276 URL: http://llvm.org/viewvc/llvm-project?rev=291276=rev Log: Use CodegenOpts::less when creating a TargetMachine for clang `-O1` Summary: Clang was initializing the TargetMachine with CodeGenOpt::Default for O1. This change

Re: r288493 - [ClangFormat] Only insert #include into the #include block in the beginning of the file.

Hi Eric, > On Dec 2, 2016, at 3:01 AM, Eric Liu via cfe-commits > wrote: > > Author: ioeric > Date: Fri Dec 2 05:01:43 2016 > New Revision: 288493 > > URL: http://llvm.org/viewvc/llvm-project?rev=288493=rev > Log: > [ClangFormat] Only insert #include into the

r289850 - Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments"

Author: mehdi_amini Date: Thu Dec 15 12:54:00 2016 New Revision: 289850 URL: http://llvm.org/viewvc/llvm-project?rev=289850=rev Log: Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments" Reviewers: rsmith, bruno, dexonsmith Subscribers: cfe-commits

r289763 - Revert "Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments""

Author: mehdi_amini Date: Wed Dec 14 22:58:51 2016 New Revision: 289763 URL: http://llvm.org/viewvc/llvm-project?rev=289763=rev Log: Revert "Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments"" This reverts commit r289762, wasn't ready to be

r289762 - Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments"

Author: mehdi_amini Date: Wed Dec 14 22:51:22 2016 New Revision: 289762 URL: http://llvm.org/viewvc/llvm-project?rev=289762=rev Log: Fix printf specifier handling: invalid specifier should not be marked as "consuming data arguments" Modified:

r289761 - Fix os_log formating with arbitrary precision and field width

Author: mehdi_amini Date: Wed Dec 14 22:02:31 2016 New Revision: 289761 URL: http://llvm.org/viewvc/llvm-project?rev=289761=rev Log: Fix os_log formating with arbitrary precision and field width Modified: cfe/trunk/lib/Analysis/OSLog.cpp cfe/trunk/test/CodeGen/builtins.c Modified:

[PATCH] D26984: Unconditionally pass -lto_library, remove -Wliblto warning.

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D26984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

pport at build time >> for clang. >> >> >> On Nov 21, 2016, at 9:53 PM, Mehdi Amini via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >> >> AFAIK any clang build open-source ships with libLTO. >> Not having libLTO built with clang is a

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

Double-checked on the latest binary release on llvm.org, it ships with clang+llvm-3.9.0-x86_64-apple-darwin/lib/libLTO.dylib I also can’t find any CMake option that disable LTO support at build time for clang. > On Nov 21, 2016, at 9:53 PM, Mehdi Amini via cfe-commits > <cf

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

chromium.org>> wrote: >> >> On Mon, Nov 21, 2016 at 5:34 PM, Mehdi Amini <mehdi.am...@apple.com >> <mailto:mehdi.am...@apple.com>> wrote: >> >>> On Nov 21, 2016, at 2:27 PM, Nico Weber <tha...@chromium.org >>> <mailto:th

Re: [PATCH] D26944: Suppress -Wliblto warning when -flto is not present

FYI, doesn’t look good to me, cf what I described on the other thread. > On Nov 21, 2016, at 9:51 PM, Nico Weber wrote: > > Lgtm, works for me. Seems like a good compromise. > > > On Nov 21, 2016 6:29 PM, "Reid Kleckner" >

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

t;mehdi.am...@apple.com >> <mailto:mehdi.am...@apple.com>> wrote: >> >>> On Nov 21, 2016, at 2:27 PM, Nico Weber <tha...@chromium.org >>> <mailto:tha...@chromium.org>> wrote: >>> >>> On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMIN

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

rg >> <mailto:tha...@chromium.org>> wrote: >> >> On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits >> <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: >> mehdi_amini added a comment. >> >> In https://r

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

> On Nov 21, 2016, at 2:27 PM, Nico Weber <tha...@chromium.org> wrote: > > On Mon, Nov 21, 2016 at 5:19 PM, Mehdi AMINI via cfe-commits > <cfe-commits@lists.llvm.org <mailto:cfe-commits@lists.llvm.org>> wrote: > mehdi_amini added a comment. > > In

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. In https://reviews.llvm.org/D25932#601842, @rnk wrote: > In https://reviews.llvm.org/D25932#601820, @mehdi_amini wrote: > > > We ship `clang + libLTO + ld64` bundled in the toolchain, so even if you > > don't package libLTO yourself, it is already accessible from

[PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

mehdi_amini added a comment. We ship `clang + libLTO + ld64` bundled in the toolchain, so even if you don't package libLTO yourself, it is already accessible from the linker: it will use the one in the toolchain when needed. I don't have an immediate idea to prevent this and have the linker

r287449 - Change setDiagnosticsOutputFile to take a unique_ptr from a raw pointer (NFC)

Author: mehdi_amini Date: Sat Nov 19 12:19:41 2016 New Revision: 287449 URL: http://llvm.org/viewvc/llvm-project?rev=287449=rev Log: Change setDiagnosticsOutputFile to take a unique_ptr from a raw pointer (NFC) Summary: This makes it explicit that ownership is taken. Also replace all `new` with

[PATCH] D26833: LTO support for -fsave-optimization-record on Darwin

mehdi_amini added a comment. I'm not incline to agree with this, unless you have very strong arguments. https://reviews.llvm.org/D26833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26833: LTO support for -fsave-optimization-record on Darwin

mehdi_amini requested changes to this revision. mehdi_amini added a comment. This revision now requires changes to proceed. Well, maybe not entirely, what do you expect for output with ThinLTO? https://reviews.llvm.org/D26833 ___ cfe-commits

[PATCH] D26833: LTO support for -fsave-optimization-record on Darwin

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D26833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24289: Add warning when assigning enums to bitfields without an explicit unsigned underlying type

mehdi_amini added a comment. What is the correct solution for MSVC in C? (If any) Repository: rL LLVM https://reviews.llvm.org/D24289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r287085 - Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

Author: mehdi_amini Date: Wed Nov 16 01:07:28 2016 New Revision: 287085 URL: http://llvm.org/viewvc/llvm-project?rev=287085=rev Log: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks Instead of always displaying the mangled name, try to do better and get

[PATCH] D26376: Undef stdatomic.h macro definitions that are defining functions provided in libc++

mehdi_amini added a comment. Ping @rsmith ! https://reviews.llvm.org/D26376 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26690: [Driver] Infer the correct option to ld64 for -fembed-bitcode

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM! I feel the code is cleaner like that at uses of these API :) https://reviews.llvm.org/D26690 ___ cfe-commits mailing list

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

mehdi_amini added a comment. Patch still LGTM! Thanks. Repository: rL LLVM https://reviews.llvm.org/D26649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26690: [Driver] Infer the correct option to ld64 for -fembed-bitcode

mehdi_amini added inline comments. Comment at: lib/Driver/Tools.cpp:8326 - if (C.getDriver().embedBitcodeEnabled() || - C.getDriver().embedBitcodeMarkerOnly()) { -// Check if the toolchain supports bitcode build flow. steven_wu wrote: > mehdi_amini

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

mehdi_amini added a comment. Already reverted Repository: rL LLVM https://reviews.llvm.org/D26522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r287043 - Revert "Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks"

Author: mehdi_amini Date: Tue Nov 15 16:19:50 2016 New Revision: 287043 URL: http://llvm.org/viewvc/llvm-project?rev=287043=rev Log: Revert "Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks" This reverts commit r287039, tests are broken. Removed:

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL287039: Improve handling of __FUNCTION__ and other predefined expression for Objective… (authored by mehdi_amini). Changed prior to commit: https://reviews.llvm.org/D26522?vs=77682=78073#toc

r287039 - Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

Author: mehdi_amini Date: Tue Nov 15 15:47:11 2016 New Revision: 287039 URL: http://llvm.org/viewvc/llvm-project?rev=287039=rev Log: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks Instead of always displaying the mangled name, try to do better and get

[PATCH] D26690: [Driver] Infer the correct option to ld64 for -fembed-bitcode

mehdi_amini added inline comments. Comment at: lib/Driver/Tools.cpp:8326 - if (C.getDriver().embedBitcodeEnabled() || - C.getDriver().embedBitcodeMarkerOnly()) { -// Check if the toolchain supports bitcode build flow. Why aren't these tests returning

<    1   2   3   4   5   >