[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added a comment. In D109621#3799133 , @sepavloff wrote: > In D109621#3791511 , @mstorsjo > wrote: > >> On this topic, it would be great if we could pick up a per-target default >> config file too, if

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

mgorny added a comment. In D106577#3799276 , @aaron.ballman wrote: > Sorry, thanks for re-pinging this, it fell off my radar. Yes, I have heard > back from WG14 but there was not really a consensus position (which means > we'd need to write a paper if

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added inline comments. Comment at: clang/docs/UsersManual.rst:915 +in the directory where Clang resides. If Clang is started via an executable +without target prefix, Clang will use ``default.cfg`` instead. sepavloff wrote: > What about using default

[PATCH] D134208: [clang] [Driver] Do not transform explicit --config filename

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Disable transformations (e.g. attempting to replace target architecture) in the config filename that is passed

[PATCH] D134191: [clang] Make config-related options CoreOptions

mgorny added a comment. In D134191#3799841 , @MaskRay wrote: > They don't need to be `NoXarchOption` if I am not mistaken. I don't know about that. The comment on top says "The option is a "driver"-only option, and should not be forwarded to other

[PATCH] D134191: [clang] Make config-related options CoreOptions

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay, hfinkel. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Make `--config`, `--no-default-config` and `--config-*-dir` CoreOptions to enable their availability to

[PATCH] D134191: [clang] Make config-related options CoreOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaebf2c13ce2: [clang] Make config-related options CoreOptions (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. In D134270#3804855 , @sepavloff wrote: > What about the case, when executable file has a target prefix (so implicit > config file may be used) and the option `--config` is specified in command > line? Now this case becomes

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. For the record, I'm working on support for loading defaults from multiple files in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added subscribers: StephenFan, pengfei. Herald added a reviewer: sscalpone. Herald added a project: All. mgorny requested review of this revision. Update the rules used to load default configuration files to permit

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. @sepavloff, I'd appreciate if you could take a look at the logic before I start updating tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny updated this revision to Diff 461803. mgorny added a comment. Combining `--config` and default configuration files is now explicitly allowed. Adjust the code to load default configs before explicitly specified files. Update tests to cover combining `--config` with defaults. Update the

[PATCH] D134271: [clang] [docs] Improve formatting & fix typo in config docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3db2917e2706: [clang] [docs] Improve formatting fix typo in config docs (authored by mgorny). Herald added a project: clang. Repository: rG LLVM

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. To explain this better, let's take the following example call: x86_64-pc-linux-gnu-clang --driver-mode=g++ -target i386 This maps to: - effective triple: `i386` (from `-target`) - effective mode: `clang++` (from `--driver-mode`) - name prefix: `x86_64-pc-linux-gnu` -

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1061 return false; + if (ClangNameParts.TargetPrefix.empty()) +return false; sepavloff wrote: > Does it mean that executable without prefix won't load implicit config file? > For

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a774c35e9f8: [clang] [Driver] Support multiple configuration files (authored by mgorny). Herald added a project: clang. Repository: rG LLVM

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny added a comment. Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134270/new/ https://reviews.llvm.org/D134270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134208: [clang] [Driver] Do not transform explicit --config filename

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7d2409bac7f: [clang] [Driver] Do not transform explicit --config filename (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny updated this revision to Diff 461960. mgorny added a comment. Simplify getting driver mode — it turns out it's set for us already! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/include/clang/Driver/Driver.h

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny abandoned this revision. mgorny added a comment. Abandoning in favor of D134337 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/ https://reviews.llvm.org/D109621 ___ cfe-commits mailing

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. Thanks for doing this. I'm going to test it in 2-3 hours and get back to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. I'm seeing test failures with this patch applied: Failed Tests (3): Clang :: CodeGen/PowerPC/builtins-ppc-p8vector.c Clang :: CodeGen/builtins-arm-msvc-compat-only.c

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. Hmm, I just realized that I've tested on top of 15.0.0. If commits already on top of `release/15.x` branch already fix that, I'm sorry! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. In D133800#3789100 , @aaron.ballman wrote: > In D133800#3788950 , @nikic wrote: > >> I tested this patch as well and saw the same failures as @mgorny. > > Thank you, I think I've got

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. @nikic, with your patch I still have `CodeGen/PowerPC/builtins-ppc-p8vector.c` failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny added a comment. In D133800#3788983 , @nikic wrote: > @mgorny Yeah, that was a testing fail on my side. I've updated it to a > hopefully correct version. Ok, thanks. This version worked for me. CHANGES SINCE LAST ACTION

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. The newest version looks good. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133800/new/ https://reviews.llvm.org/D133800 ___

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

mgorny planned changes to this revision. mgorny added a reviewer: MaskRay. mgorny added a comment. Herald added a subscriber: StephenFan. So far my plan is to go for `default-{ModeSuffix}.cfg` instead (e.g. `default-clang.cfg`, `default-clang++.cfg`, etc.). If I'm not mistaken, this will

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added inline comments. Comment at: clang/docs/UsersManual.rst:878 Another way to specify a configuration file is to encode it in executable name. For example, if the Clang executable is named `armv7l-clang` (it may be a +symbolic link to `clang`), then Clang will search

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

This revision was automatically updated to reflect the committed changes. Closed by commit rG587729c3ad78: [clang] [Driver] Add an option to disable default config filenames (authored by mgorny). Herald added a project: clang. Changed prior to commit:

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny updated this revision to Diff 460877. mgorny retitled this revision from "[clang][Driver] Default to loading clang.cfg if config file not specified" to "[clang] [Driver] Fall back to default.cfg when calling clang w/o prefix". mgorny edited the summary of this revision. mgorny added a

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

mgorny commandeered this revision. mgorny added a reviewer: asymptotically. mgorny added a comment. After discussing privately with @asymptotically, I'm going to try to finish this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/ https://reviews.llvm.org/D109621

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny added a comment. As an example, we are currently installing the following set of executables + symlinks for clang in Gentoo on amd64 with full multilib: lrwxrwxrwx 1 root root8 Sep 17 12:31 /usr/lib/llvm/16/bin/clang -> clang-16 lrwxrwxrwx 1 root root 10 Sep 17 12:31

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny added a comment. Hmm, apparently this could be achieved by making it a "CoreOption". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329 ___ cfe-commits

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny added a comment. At a first glance, it works. I'm now building GCC:11 here to test it against two real installations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329

[PATCH] D109621: [clang] [Driver] Fall back to default.cfg when calling clang w/o prefix

mgorny updated this revision to Diff 461054. mgorny added a comment. Fix documentation formatting. While at it, fix a doc mistake that referenced `x86_64-cl.cfg` instead of the correct `x86_64-clang-cl.cfg`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Ok, this works fine for me (though I haven't run the tests yet). If D109621 and this one lands, I think the old Gentoo logic can be removed. We'll still

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. Unfortunately, we have some test failures after this change, e.g.: FAIL: Clang :: CodeGenHLSL/basic_types.hlsl (6525 of 15795) TEST 'Clang ::

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny added a comment. I think you misunderstood me. The aforementioned tests fail if I put `--gcc-install-dir=` in the config file. There is no way to put it in the config file that wouldn't affect these tests right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. In D134337#3813779 , @sepavloff wrote: > First clang tries to find `x86_64-pc-linux-gnu-clang.cfg`. Just tool name > with added suffix `cfg`. No target override, no attempt to split tool name > into components. It provides

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. In D134337#3815339 , @sepavloff wrote: > In D134337#3805368 , @mgorny wrote: > >> For target, it will try: >> >> 1. `i386.cfg` (effective triple) >> 2. `i386-pc-linux-gnu.cfg` ("fixed"

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs (WIP)

mgorny added a comment. @sepavloff, gentle ping. I'm waiting for your ACK/NAK on the algo in https://reviews.llvm.org/D134337#3805368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny updated this revision to Diff 460665. mgorny added a comment. Replace `!x || !y` logic with `!(x && y)` that may be easier to comprehend. Replace `//` with empty lines on test boundaries. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134018/new/ https://reviews.llvm.org/D134018

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny created this revision. mgorny added reviewers: sepavloff, asymptotically, MaskRay, tstellar. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Add a `--no-default-config` option that disables the search for default set of config

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance, an executable 'armv7l-clang' will - // search for config file 'armv7l-clang.cfg'.

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1027 - // If config file is not specified explicitly, try to deduce configuration - // from executable name. For instance, an executable 'armv7l-clang' will - // search for config file 'armv7l-clang.cfg'.

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I think this is a good idea — thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133771/new/ https://reviews.llvm.org/D133771

[PATCH] D134018: [clang] [Driver] Add an option to disable default config filenames

mgorny marked 6 inline comments as done. mgorny added a comment. Thanks! I'm going to give others a few more hours to chime in before merging it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134018/new/ https://reviews.llvm.org/D134018 ___

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

mgorny added a comment. As @sepavloff points out in the linked discussion, we probably need an option to disable loading default configuration files too, and we should use it in the test suite (via modifying the `%clang` substitutions, I guess), as otherwise someone enabling config file

[PATCH] D134271: [clang] [docs] Improve formatting & fix typo in config docs

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Fix teletype formatting in configuration file documentation to use double backticks rather than single backticks.

[PATCH] D134270: [clang] [Driver] Support multiple configuration files

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Support specifying multiple configuration files via multiple `--config` options. When multiple files are

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

mgorny added a comment. In D106577#2965059 , @aaron.ballman wrote: > Thanks! I've passed them along to WG14 and will report back what I hear. Have you heard anything since? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133329: [Driver] Add --gcc-install-dir=

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Let's tackle the config changes independently and not block this on them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463944. mgorny marked an inline comment as done. mgorny added a comment. Change confusing comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1065-1080 + StringRef EffectiveDriverMode; + if (CLOptions) +EffectiveDriverMode = CLOptions->getLastArgValue(options::OPT_driver_mode); + if

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

This revision was automatically updated to reflect the committed changes. Closed by commit rG1609a5d7715c: [clang] [test] Use %clang_cc1 substitution consistently (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added a comment. I'm not sure if we should be documenting this in the user manual, or if it should be considered an internal-use envvar. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134905/new/ https://reviews.llvm.org/D134905 ___

[PATCH] D134871: [llvm] [lit] Move %clang_dxc substitution from clang/test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74085ebfb68e: [llvm] [lit] Move %clang_dxc substitution from clang/test (authored by mgorny). Herald added a project: clang. Repository: rG LLVM

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG063e17d8b04b: [clang] [Driver] More flexible rules for loading default configs (authored by mgorny). Herald added a project: clang. Repository:

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny created this revision. mgorny added reviewers: MaskRay, sepavloff, zturner. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Add support for a CLANG_NO_DEFAULT_CONFIG envvar that works like the --no-default-config option when set

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

mgorny added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) MaskRay wrote: > probinson wrote: > > But we _don't_ want to use `%clang_cc1` in Driver tests; if we

[PATCH] D135159: [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1

mgorny created this revision. mgorny added reviewers: sammccall, MaskRay, sepavloff. Herald added subscribers: StephenFan, kadircet, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a project: clang-tools-extra. Set CLANG_NO_DEFAULT_CONFIG=1 for

[PATCH] D135159: [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1

This revision was automatically updated to reflect the committed changes. Closed by commit rG52ce6776cf98: [clang-tools-extra] [test] Use CLANG_NO_DEFAULT_CONFIG=1 (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135159/new/

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

mgorny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135062/new/ https://reviews.llvm.org/D135062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG77945a344c3d: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135062/new/

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

mgorny accepted this revision. mgorny added a comment. Thanks for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135545/new/ https://reviews.llvm.org/D135545 ___ cfe-commits mailing list

[PATCH] D135545: [clang] Mention -Werror changes revived for Clang 16

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bb86b674476: [clang] Mention -Werror changes revived for Clang 16 (authored by thesamesam, committed by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

mgorny created this revision. mgorny added reviewers: thieta, h-vetinari, tstellar, MaskRay, thesamesam. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. mgorny requested review of this revision. Instead of setting libclang.so's SOVERSION to CLANG_MAJOR_VERSION

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3ce1339264d: [clang] Do not override libclang.sos SOVERSION if… (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135701: [clang] Do not override libclang.so's SOVERSION if CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

mgorny added a comment. In D135701#3850251 , @MaskRay wrote: > I don't understand this well, though. Is `CLANG_VERSION_MAJOR` wrong or not > defined in some cases? It's about `LLVM_VERSION_SUFFIX`. Normally, `SOVERSION` for all libraries is

[PATCH] D135018: [compiler-rt] [test] Fix sem_init_glibc.cpp test for glibc 2.36 on i386

mgorny abandoned this revision. mgorny added a comment. Abandoning in favor of D135023 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135018/new/ https://reviews.llvm.org/D135018 ___ cfe-commits mailing

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG924996e0a011: [clang] [Driver] Disable default configs via envvar during testing (authored by mgorny). Herald added a project: clang. Repository:

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/test/Driver/config-file3.c:176 // -// SHORT-NAME: Configuration file: {{.*}}/testdmode/qqq.cfg -// SHORT-NAME: -Werror -// SHORT-NAME-NOT: -Wundefined-func-template +// FULL3-NOT:

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1073 + if (const char *NoConfigEnv = ::getenv("CLANG_NO_DEFAULT_CONFIG")) { +if (*NoConfigEnv) + return false; MaskRay wrote: > Looking at

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

mgorny added a comment. Is anyone working on a solution that would work for people using a zstd install method that's actually supported upstream? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[PATCH] D134905: [clang] [Driver] Disable default configs via envvar during testing

mgorny added a comment. In D134905#3826111 , @MaskRay wrote: >> during testing > > This part of the subject is probably not needed. I think exposing the idea to > user can probably be useful, too. Sure but the larger part of the commit is actually

[PATCH] D135018: [compiler-rt] [test] Fix sem_init_glibc.cpp test for glibc 2.36 on i386

mgorny created this revision. mgorny added reviewers: eugenis, vitalybuka, rovka. Herald added subscribers: Enna1, dberris. Herald added a project: All. mgorny requested review of this revision. Update sem_init_glibc.cpp to apply the "newer" GET_SEM_VALUE(v) logic to i386 if glibc is 2.36 or

[PATCH] D135018: [compiler-rt] [test] Fix sem_init_glibc.cpp test for glibc 2.36 on i386

mgorny added reviewers: MaskRay, thesamesam. mgorny added subscribers: thesamesam, MaskRay. mgorny added a comment. Herald added a subscriber: StephenFan. @MaskRay, @thesamesam, any chance you could reproduce/test this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135018/new/

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

mgorny created this revision. mgorny added reviewers: sammccall, kadircet, hokein, ilya-biryukov, kbobyrev, MaskRay, thesamesam. Herald added subscribers: StephenFan, arphaman. Herald added a project: All. mgorny requested review of this revision. Herald added a project: clang-tools-extra. Add

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463825. mgorny marked 2 inline comments as done. mgorny added a comment. Address @MaskRay 's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny added inline comments. Comment at: clang/include/clang/Driver/Driver.h:758 + /// Return the typical executable name for the specified driver \p Mode. + static const char *getExecutableForDriverMode(DriverMode Mode); }; MaskRay wrote: > This should be

[PATCH] D134871: [llvm] [lit] Move %clang_dxc substitution from clang/test

mgorny created this revision. mgorny added reviewers: python3kgae, beanz, MaskRay, zturner. Herald added subscribers: StephenFan, delcypher. Herald added a project: All. mgorny requested review of this revision. Herald added a project: LLVM. Move the `%clang_dxc` substitution from local

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { mgorny wrote: > I don't really understand

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

mgorny added inline comments. Comment at: clang/test/Preprocessor/lang-std.cpp:1 -// UNSUPPORTED: default-std-cxx, ps4, ps5 -/// Test default standards when CLANG_DEFAULT_STD_CXX is unspecified. I suppose you want to remove the `lit.cfg.py` counterpart of this

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

mgorny added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1007 // Then load configuration files specified explicitly. - llvm::SmallString<128> CfgFilePath; + std::string CfgFilePath; if (CLOptions) { I don't really understand the purpose of

[PATCH] D133375: [CMake] Remove CLANG_DEFAULT_STD_C/CLANG_DEFAULT_STD_CXX

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks for doing this. For the record, Gentoo didn't need to use this for a long time now, so there's no backwards compatibility concern here. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

mgorny created this revision. mgorny added reviewers: python3kgae, beanz, jhuber6, davide, asb, MaskRay, plotfi. Herald added subscribers: StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463413. mgorny retitled this revision from "[clang] [Driver] More flexible rules for loading default configs (WIP)" to "[clang] [Driver] More flexible rules for loading default configs". mgorny added a comment. Update release notes. I may have been a bit

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: clang/docs/ReleaseNotes.rst:243 + ``.cfg`` and ``.cfg`` if the former is not found. `Target` + is always the effective target (with respect to ``-target``, ``-m32``, etc.) + and `driver` first

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463424. mgorny marked 2 inline comments as done. mgorny added a comment. Use `--target=` instead of `-target`. Use `touch` instead of `echo >`. Shorten FileCheck matches and guarantee that only expected configs appear. CHANGES SINCE LAST ACTION

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

mgorny updated this revision to Diff 463433. mgorny marked 2 inline comments as done. mgorny added a comment. Use `llvm_unreachable()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 Files: clang/docs/ReleaseNotes.rst

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

mgorny accepted this revision. mgorny added a comment. This one LGTM to me as well, and doesn't seem to break Gentoo either ;-). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny updated this revision to Diff 472376. mgorny added a comment. Add an explanatory comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:274-275 + "LLVM_CONFIG_PATH is deprecated, please use LLVM_CMAKE_DIR instead") +get_filename_component(LLVM_CMAKE_DIR "${LLVM_CONFIG_PATH}" DIRECTORY) +

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

This revision was automatically updated to reflect the committed changes. Closed by commit rG23c665371a98: [compiler-rt] Switch from llvm-config to find_package(LLVM) (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Thanks! Let's hope it works this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits mailing list

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Hmm, I suppose it makes sense. At least at a first glance I don't see how it could yield different results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. In D139723#4004536 , @doru1004 wrote: > Commit: 07ff3c5ccce68aed6c1a270b3f89ea14de7aa250 >

[PATCH] D140155: [Clang][OpenMP] Allow host call to nohost function with host variant

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. In D140155#4004505 , @doru1004 wrote: > Commit 658ed9547cdd6657895339a6c390c31aa77a5698 >

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

mgorny added a comment. Also, please link commits to diffs using `Differential Revision:` trailer in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139723/new/ https://reviews.llvm.org/D139723

<    3   4   5   6   7   8   9   >