[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

2022-09-27 Thread Michael Berg via Phabricator via cfe-commits
mcberg2021 added inline comments. Comment at: clang/lib/CodeGen/CGLoopInfo.cpp:673 +setInterleaveEnable(false); setInterleaveCount(1); break; Can you update the comments on lines: 665 and 671 as they both need update. Repository: rG

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

2020-01-16 Thread Michael Berg via Phabricator via cfe-commits
mcberg2017 added a comment. I should do the other DAG combiner fma changes after this is wrapped up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72675/new/ https://reviews.llvm.org/D72675 ___ cfe-commits mailing list

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

2020-01-15 Thread Michael Berg via Phabricator via cfe-commits
mcberg2017 added a comment. We crossed that bridge internally at Apple a while ago, meaning I have some code debt for cleaning up open source for fma formation that uses contract and reassoc differently than we do today, both together and separately, case by case. CHANGES SINCE LAST ACTION

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

2019-11-20 Thread Michael Berg via Phabricator via cfe-commits
mcberg2017 added a comment. For us this would be an impediment as we have math models that want ieee behavior while relaxing precision. Adding nnan or ninf would obstruct those choices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70488/new/