[PATCH] D144651: [Serialization] Place command line defines in the correct file

Michael137 added a comment. FWIW here's some info on how we get to the assert. Maybe someone with more understanding of the `clang::SourceManager` and how it interacts with `.pcm`s will be able to spot something. Here's a bit more of the stack trace: frame #41: 0x00013844c7e0

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + probinson wrote: > This doesn't become `Foo` ? The name stays as `Foo>` but the type of the template parameter becomes `BarInt`. So the dwarf would

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. > The construction of the mangled name does not require getting just the abi > tags of the constructor itself right. Rather, it requires knowing the abi tag > annotations of all arguments (template and regular) of the constructor, and > template arguments of all

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a subscriber: labath. Michael137 added a comment. > Hmm, I'd sort of still be inclined to look further at the linkage name option > - but maybe the existence of a situation where the usage is built with debug > info, but the out of line ctor definitions are all in another

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 updated this revision to Diff 498898. Michael137 added a comment. - Hide behind LLDB tuning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144181/new/ https://reviews.llvm.org/D144181 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. We thought a bit about what it would take to link a constructor declaration DIE to the various definitions (e.g., via a `DW_AT_LLVM_complete_ctor_linkage_name` or `DW_AT_LLVM_complete_ctor_ref`). The issue with this is that it would mess with type uniquing. E.g.,

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 updated this revision to Diff 497983. Michael137 added a comment. - Remove leftover comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144181/new/ https://reviews.llvm.org/D144181 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. Left is without patch. Right is with patch. file: bin/lldb.dSYM/Contents/Resources/DWARF/lldb file:

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 updated this revision to Diff 497986. Michael137 added a comment. - Remove leftover comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144181/new/ https://reviews.llvm.org/D144181 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. **Summary** After this patch, any `AbiTagAttr` attribute on a

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. In D144181#4133056 , @Michael137 wrote: > In D144181#4133025 , @dblaikie > wrote: > >> Ah, accidentally posted to the lldb part of this stack... instead: >> >> Any chance we can make

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 updated this revision to Diff 498019. Michael137 added a comment. - Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144181/new/ https://reviews.llvm.org/D144181 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. In D144181#4133025 , @dblaikie wrote: > Ah, accidentally posted to the lldb part of this stack... instead: > > Any chance we can make these work more like member functions (could the ctors > include their mangled names, for

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 added a comment. Since the new attribute only gets attached to a structure definition, and the preferred_name attribute is currently only really used in a handful of places in libcxx, this practically doesn't affect debug-info size Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501540. Michael137 added a comment. - Remove redundant TODO Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501544. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this patch, we now emit a `DW_AT_LLVM_preferred_name` for the

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501569. Michael137 added a comment. - Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D145077: [clang][DebugInfo] Support DW_AT_LLVM_preferred_name attribute

Michael137 updated this revision to Diff 501568. Michael137 added a comment. - Add test case for multiple alias templates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145077/new/ https://reviews.llvm.org/D145077 Files:

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. Although I don't know of a scenario where we ever explicitly need to call the base object constructor from the expression evaluator. So maybe we can get away with only linking the complete object constructor DIE to the subprogram. Via a `DW_AT_LLVM_complete_ctor` or

[PATCH] D144181: [clang][DebugInfo] Add abi-tags on constructors/destructors as LLVM annotations

Michael137 added a comment. > This is what I meant by the "extension for the asm annotation for > constructors" part. In principle, we could extend clang so that one can write > something like this: Ah thanks for elaborating. That's an interesting approach. So this would require adding the

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. In D143347#4298613 , @kpdev42 wrote: > So what are next steps? Are we going for implementation of > `DW_AT_no_unique_address` (which is going to be a non-standard extension) ? > @dblaikie @aprantl @Michael137 in my opinion

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. In D145803#4220124 , @wolfgangp wrote: > In D145803#4219894 , @probinson > wrote: > >> This is pretty different from the "always desugar to the canonical type" >> habit that has

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + dblaikie wrote: > Michael137 wrote: > > probinson wrote: > > > This doesn't become `Foo` ? > > The

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508563. Michael137 added a comment. - Fix function docstring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508562. Michael137 added a comment. - Refine tests: - Check for type of template parameter - Add test for chained typedefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1482 +if (prev_base) { + clang::CXXRecordDecl *prev_base_decl = + prev_base->getType()->getAsCXXRecordDecl(); Should we add a comment

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. I'll submit later today then if nobody has any other objections Will add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. Looks like `gmodules` isn't supported on AIX (based on other tests that use `-dwarf-ext-refs`. So I'll just disable the new tests Thanks for notifying @aaron.ballman , email notifications got lost in the inbox Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a subscriber: Jake-Egan. Michael137 added a comment. Oh looks like @Jake-Egan already did Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added subscribers: aprantl, dblaikie. Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/no_unique_address/main.cpp:38 + long v = 42; +} _f3; + I haven't checked the reworked logic yet, but it still crashes on this: ```

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/test/API/types/TestEmptyBase.py:25-42 +def test(self): +"""Test that recursive structs are displayed correctly.""" +self.build(dictionary=self.sources) +

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1481 +// To fix this we scan base classes in reverse order to determine +// overlapping offsets. Wnen found we consider such class as empty +// base with all

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { +

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. FYI, this bugfix was attempted back in 2021 here: https://reviews.llvm.org/D101237 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG711a64412749: [clang][DebugInfo] Emit DW_AT_type of preferred name if available (authored by Michael137). Repository:

[PATCH] D147764: Fix the two gmoules-prefered-name-* tests

Michael137 added a comment. Thanks for fixing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147764/new/ https://reviews.llvm.org/D147764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2212 m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType()); -if (record_decl) +if (record_decl) { + bool is_empty = true;

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 506588. Michael137 added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Fix cycle in `DIDerivedType` when we deal with forward declarations and complete explicitly via `completeClassData` (e.g., with `-gmodules`) - Add

[PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. From a first glance looks ok but ideally the clang changes would be a separate review. Particularly the ASTImporter change could use a unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. Herald added a subscriber: JDevlieghere. The alternative would be attaching the preferred name as a new attribute or an existing attribute like `DW_AT_description`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. **Summary** This patch makes debug-info generation

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 updated this revision to Diff 496089. Michael137 added a comment. - Reword commit - Use different debuginfo kind in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143501/new/ https://reviews.llvm.org/D143501 Files:

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:61 if self.expectedCompilerVersion(['>', '16.0']): +string_type = "std::string"

[PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. > I'd recommend a possible long-term solution would be simplified template > names (so we don't have to worry about encoding this in the `DW_AT_name` > anyway) and a "DW_AT_LLVM_preferred_name" or similar attribute on a type that > refers to the typedef that is the

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: clang/test/CodeGen/debug-info-preferred-names.cpp:1 +// RUN: %clang_cc1 -emit-llvm -debug-info-kind=limited %s -o - -debugger-tuning=lldb | FileCheck --check-prefixes=COMMON,LLDB %s +// RUN: %clang_cc1 -emit-llvm

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/shared_ptr/TestDataFormatterLibcxxSharedPtr.py:61 if self.expectedCompilerVersion(['>', '16.0']): +string_type = "std::string"

[PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. In D143501#4113347 , @aprantl wrote: > Nice! Does `expr -- std::basic_string s` still work after this change? > Not that anyone would want to type this over `std::string` ... Yup that still works. We would still emit it as

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError use it throught ASTImporter

Michael137 added a comment. Didn't add tests for this since checking the contents of the error message didn't seem worth testing. But don't mind adding tests if reviewers feel more comfortable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError and use it throughout ASTImporter

Michael137 updated this revision to Diff 538111. Michael137 added a comment. - Fix commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154709/new/ https://reviews.llvm.org/D154709 Files: clang/include/clang/AST/ASTImportError.h

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError use it throught ASTImporter

Michael137 updated this revision to Diff 538110. Michael137 added a comment. - Remove redundant header additions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154709/new/ https://reviews.llvm.org/D154709 Files:

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError use it throught ASTImporter

Michael137 created this revision. Michael137 added reviewers: martong, balazske. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project:

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError and use it throughout ASTImporter

Michael137 added a comment. In D154709#4487776 , @balazske wrote: > The goal is to have a message always in `ASTImportError`? Then probably the > constructor without message can be removed, at least to check if really the > message is added at all

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. Looks like the latest reland of this patch broke some debug-info `cross-project-tests` on the Arm64 macOS buildbots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-as/263/execution/node/54/log/ Failed Tests (2): cross-project-tests ::

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. In D144999#4408248 , @Michael137 wrote: > Looks like the latest reland of this patch > (`e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc`) broke some debug-info > `cross-project-tests` on the Arm64 macOS buildbots: >

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. In D144999#4409671 , @oontvoo wrote: > P.S This might have the same root-cause with the previous comment and could > be fixed by D152540 as well. > (not able to repro the failures yet -

[PATCH] D156693: [clang][ASTImporter]Skip check friend template declaration in VisitClassTemplateDecl

Michael137 added a comment. Could you please elaborate in the commit message what exactly the issue currently is and how the patch addresses it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

Michael137 updated this revision to Diff 532664. Michael137 added a comment. - fix test comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153282/new/ https://reviews.llvm.org/D153282 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently we emit `DW_AT_deleted` for `deleted`

[PATCH] D153282: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function

This revision was automatically updated to reflect the committed changes. Closed by commit rGc146df961876: [clang][DebugInfo] Emit DW_AT_deleted on any deleted member function (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. In D144999#4417731 , @oontvoo wrote: > In D144999#4415419 , @oontvoo wrote: > >> In D144999#4415137 , @jasonmolenda >> wrote: >> >>> Michael

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 updated this revision to Diff 532952. Michael137 added a comment. Herald added a subscriber: ormris. - remove redundant includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 Files:

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 updated this revision to Diff 532957. Michael137 added a comment. - clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153362/new/ https://reviews.llvm.org/D153362 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D153362: [clang][DebugInfo] Emit DW_AT_defaulted for defaulted C++ member functions

Michael137 created this revision. Michael137 added reviewers: dblaikie, aprantl. Herald added a subscriber: hiraditya. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch

<    1   2