[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442276. Codesbyusman added a comment. updating some to the back strings becaue the orginal were more better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442299. Codesbyusman added a comment. updating the test files for the last update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. Yes I am looking into the DiagnosticParseKinds.td. Kindly also look another error encountered in testing while updating the test. Although not having in my system but this is giving . Look here

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. Yes I am looking into the DiagnosticParseKinds.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 ___ cfe-commits mailing list

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman created this revision. Codesbyusman added reviewers: aaron.ballman, erichkeane, xgupta. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rewording the failing of _Satic_assert to the

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442183. Codesbyusman added a comment. Updating the files as required Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442184. Codesbyusman added a comment. updating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D129014: rewording static_assert to more generic static assertion

Codesbyusman created this revision. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129014 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442188. Codesbyusman added a comment. All changes in one place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442189. Codesbyusman added a comment. all changes in one patch revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442191. Codesbyusman added a comment. all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442197. Codesbyusman added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 442199. Codesbyusman added a comment. new changes as required -- final Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

Codesbyusman created this revision. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127759 Files:

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

Codesbyusman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand

[PATCH] D130510: updating the function for the tautological warnings for the unary operators

Codesbyusman created this revision. Codesbyusman added reviewers: aaron.ballman, erichkeane, xgupta. Herald added a reviewer: NoQ. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 447440. Codesbyusman edited the summary of this revision. Codesbyusman added a comment. updating to more efficient Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 447453. Codesbyusman added a comment. also updating for the Xor bitwise operator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 444211. Codesbyusman added a comment. the parser updates maked for the static asserion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 444250. Codesbyusman added a comment. updated the styles and other small things Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman marked 3 inline comments as done. Codesbyusman added a comment. In D129048#3647918 , @aaron.ballman wrote: > I think this is getting pretty close! I did have some style guideline > changes, and at least one test addition I'd like to see

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 444284. Codesbyusman added a comment. the tests for the coverage of changes being made for the static assertion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman updated this revision to Diff 444311. Codesbyusman added a comment. updated the comment styles suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3648964 , @erichkeane wrote: > Please format your patch with clang-format. See the command at the end of > this: https://clang.llvm.org/docs/ClangFormat.html > > `git diff -U0 --color=never |

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman marked an inline comment as done. Codesbyusman added inline comments. Comment at: clang/test/CXX/expr/expr.prim/expr.prim.req/nested-requirement.cpp:48 } \ No newline at end of file aaron.ballman wrote: > xgupta wrote: > > a 'newline' is missing

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. ok. I will take care of this next time. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129048/new/ https://reviews.llvm.org/D129048 ___ cfe-commits mailing list

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman marked an inline comment as done. Codesbyusman added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:970-980 +if (LHSExpr->EvaluateAsInt(IntExprResult, *Context)) { + // Evaluating value. + BoolExpr = RHSExpr; +} +else if

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman added a comment. In D130510#3684740 , @aaron.ballman wrote: > LGTM! I'll make some editorial corrections for grammar to the release note > when I land. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3671568 , @aaron.ballman wrote: > In D129048#3670212 , @ldionne wrote: > >> The libc++ CI runs pre-commit only, and it runs on all commits that touch >> something under

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3671665 , @erichkeane wrote: > In D129048#3671657 , @ldionne wrote: > >> In D129048#3671568 , >> @aaron.ballman wrote: >> >>>

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3671657 , @ldionne wrote: > In D129048#3671568 , @aaron.ballman > wrote: > >> FWIW, I've convinced myself that I agree with you here that the burden >> probably should

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 448060. Codesbyusman added a comment. updating the code suggestions and test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files:

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman added a comment. In D130510#3682902 , @aaron.ballman wrote: > Thank you for this, I think this is good incremental progress and is almost > ready to go. Just a few small nits, but also, can you also add a release note > for the fix (be

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 448141. Codesbyusman added a comment. updated with the small fixes and addition of release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files:

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3674582 , @Mordante wrote: > In D129048#3674500 , @Codesbyusman > wrote: > >> updated the libcxx all files > > FYI for libcxx you can ignore the red format CI step. So

[PATCH] D129048: Rewording the "static_assert" to static assertion

Codesbyusman added a comment. In D129048#3662972 , @xgupta wrote: > In D129048#3662634 , @Codesbyusman > wrote: > >> the libcxx updates but not tested. working on them > > I just run the check-cxx on local

[PATCH] D129014: rewording static_assert to more generic static assertion

Codesbyusman added a comment. *ERR_CLOSED: This revision has already been closed* @Shivam Gupta https://reviews.llvm.org/D129014>+public+5e9f0937aab6a...@reviews.llvm.org> can not update the patch. it seems it is closed. F23843528: image003.png F23843527:

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 453976. Codesbyusman added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/CFG.cpp

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman added inline comments. Comment at: clang/test/Parser/static_assert.c:1 -// RUN: %clang_cc1 -fsyntax-only -std=c2x -DTEST_SPELLING -verify=c2x %s -// RUN: %clang_cc1 -fsyntax-only -std=c2x -DTEST_SPELLING -fms-compatibility -verify=c2x-ms %s +// RUN: %clang_cc1

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 455607. Codesbyusman added a comment. updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 455841. Codesbyusman added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files: clang/docs/ReleaseNotes.rst

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman created this revision. Codesbyusman added reviewers: aaron.ballman, erichkeane, xgupta. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The diagnostics here are correct, but the note

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 454612. Codesbyusman marked 5 inline comments as done. Codesbyusman added a comment. updated with suggestios Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 455141. Codesbyusman added a comment. updated with suggestions and test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files:

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:384 +C2X_KEYWORD(true, BOOLSUPPORT) +C2X_KEYWORD(remove_quals, KEYC2X) + aaron.ballman wrote: > This is technically correct, but I

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 455147. Codesbyusman added a comment. updated test cases and suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files:

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman added a comment. Hi, I am not getting why **Sema/cast.c** is failing here. While all test are running fine on my system? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://reviews.llvm.org/D133194

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman updated this revision to Diff 459121. Codesbyusman added a comment. updating one time again, to again run test as no failed test on my system. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://reviews.llvm.org/D133194

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman updated this revision to Diff 459175. Codesbyusman added a comment. updated, I am not getting why this is happening but in the .cpp test file without Wvla all is working and is detecting by default as you are saying but when I use vla-warning/note it gives me error that "warning

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman marked 4 inline comments as done. Codesbyusman added inline comments. Comment at: clang/test/Sema/cast.c:1-5 +// RUN: %clang_cc1 -fsyntax-only -triple x86_64-unknown-unknown %s -verify -Wvla + +int array[(long)(char *)0]; // expected-warning {{variable length array

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman added inline comments. Comment at: clang/test/Sema/cast.c:2 // RUN: %clang_cc1 -fsyntax-only -triple x86_64-unknown-unknown %s -verify +// RUN: %clang_cc1 -std=c99 -fsyntax-only -DConstantCast -Wvla -verify %s + aaron.ballman wrote: > Instead of

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman marked an inline comment as done. Codesbyusman added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:3 // RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify=expected,cxx11_20,cxx20_2b -triple x86_64-linux -Wno-string-plus-int

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman updated this revision to Diff 459134. Codesbyusman added a comment. updating test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://reviews.llvm.org/D133194 Files: clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman added a comment. In D133194#3782198 , @aaron.ballman wrote: > In D133194#3781271 , @Codesbyusman > wrote: > >> updated, I am not getting why this is happening but in the .cpp test file >> without

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman updated this revision to Diff 459296. Codesbyusman added a comment. updating with the suggested changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/ https://reviews.llvm.org/D133194 Files:

[PATCH] D133194: rewording note note_constexpr_invalid_cast

Codesbyusman updated this revision to Diff 459064. Codesbyusman edited the summary of this revision. Codesbyusman added a comment. updated the test work for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133194/new/

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 449778. Codesbyusman added a comment. Adopted another approach working for the error caught. Kindly review this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510

[PATCH] D131683: "Diagnosing the Future Keywords"

Codesbyusman created this revision. Herald added a project: All. Codesbyusman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131683 Files:

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:387 // C++11 keywords -CXX11_KEYWORD(alignas , 0) +CXX11_KEYWORD(alignas , KEYC23) // alignof and _Alignof return the required ABI alignment

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 452797. Codesbyusman added a comment. updating for the missing tautological compare warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files:

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 452799. Codesbyusman added a comment. updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/CFG.cpp

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 452987. Codesbyusman added a comment. updated also the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/docs/ReleaseNotes.rst

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 452988. Codesbyusman added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/docs/ReleaseNotes.rst clang/lib/Analysis/CFG.cpp

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman added a comment. In D130510#3698415 , @rtrieu wrote: > Can you add my earlier test case or something like it to > SemaCXX/warn-bitwise-compare.cpp ? > > template > void foo(int x) { > bool b1 = (x & sizeof(T)) == 8; > bool

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman added a comment. working on the test. Will update the patch soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 ___ cfe-commits mailing list

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 453388. Codesbyusman added a comment. updated test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: clang/docs/ReleaseNotes.rst

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 453058. Codesbyusman marked 10 inline comments as done. Codesbyusman added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files:

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman updated this revision to Diff 453110. Codesbyusman edited the summary of this revision. Codesbyusman added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131683/new/ https://reviews.llvm.org/D131683 Files:

[PATCH] D130510: Missing tautological compare warnings due to unary operators

Codesbyusman updated this revision to Diff 453064. Codesbyusman marked 3 inline comments as not done. Codesbyusman added a comment. updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130510/new/ https://reviews.llvm.org/D130510 Files: