[PATCH] D49890: Clang-Tidy Export Problem

ngzhian added a comment. I found this patch while searching for a similar problem I faced while tryin to use clang-tidy to fix some warnings in V8 (Chrome's JavaScript engine). The setup for our compilation is as such: - basedir - src/ - out/ -arch1/ - .o files, generated files

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian added a subscriber: tlively. ngzhian added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18262-18267 +case WebAssembly::BI__builtin_wasm_relaxed_trunc_zero_s_i32x4_f64x2: + IntNo = Intrinsic::wasm_relaxed_trunc_zero_signed; + break; +case

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian created this revision. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang, LLVM. Add i32x4.relaxed_trunc_f32x4_s,

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang,

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1365 + +def wasm_relaxed_swizzle : SDNode<"WebAssemblyISD::RELAXED_SWIZZLE", wasm_swizzle_t>; + @tlively i'm not 100% sure if this is needed or the right thing to do,

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian updated this revision to Diff 380542. ngzhian added a comment. Add title for relaxed swizzle instruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112022/new/ https://reviews.llvm.org/D112022 Files:

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian updated this revision to Diff 380779. ngzhian added a comment. Wrong commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112022/new/ https://reviews.llvm.org/D112022 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D112022: [WebAssembly] Add prototype relaxed swizzle instructions

ngzhian updated this revision to Diff 380783. ngzhian added a comment. - Remove RELAXED_SWIZZLE sdnode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112022/new/ https://reviews.llvm.org/D112022 Files:

[PATCH] D112146: [WebAssembly] Add prototype relaxed float min max instructions

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang,

[PATCH] D111914: [WebAssembly] Add prototype relaxed laneselect instructions

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects: clang,

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: dang, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This currently only

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian added a comment. I followed https://reviews.llvm.org/rGb7b9fdc114c1f9c788da914dac5c343277805446 for this, hope it's right, ptal Thomas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110111/new/ https://reviews.llvm.org/D110111

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian updated this revision to Diff 374262. ngzhian marked an inline comment as done. ngzhian added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Fix fallthrough, add feature to WebAssembly subtarget Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian added a comment. In D110111#3013948 , @tlively wrote: > Nice! Thanks for writing this :D Do you know what happens when you actually > try to compile some code with `-mrelaxed-simd`? I'm concerned that it will > throw an error because the

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

ngzhian accepted this revision. ngzhian added a comment. This revision is now accepted and ready to land. The binary opcodes LGTM, not too sure about the tablegen stuff, tests look good too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian updated this revision to Diff 382717. ngzhian added a comment. Make intrinsics monomorphic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112186/new/ https://reviews.llvm.org/D112186 Files:

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian marked 2 inline comments as done. ngzhian added a comment. Good suggestion, done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112186/new/ https://reviews.llvm.org/D112186 ___ cfe-commits

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian updated this revision to Diff 382451. ngzhian added a comment. No shuffles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112186/new/ https://reviews.llvm.org/D112186 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D112186: [WebAssembly] Add prototype relaxed float to int trunc instructions

ngzhian added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18262-18267 +case WebAssembly::BI__builtin_wasm_relaxed_trunc_zero_s_i32x4_f64x2: + IntNo = Intrinsic::wasm_relaxed_trunc_zero_signed; + break; +case