r339593 - [Sema] fix -Wfloat-conversion test case.

2018-08-13 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Mon Aug 13 11:07:50 2018 New Revision: 339593 URL: http://llvm.org/viewvc/llvm-project?rev=339593=rev Log: [Sema] fix -Wfloat-conversion test case. Summary: Fixes r339581 ("[SEMA] add more -Wfloat-conversion to compound assigment analysis"). This test case was

Re: r339581 - [SEMA] add more -Wfloat-conversion to compound assigment analysis

2018-08-13 Thread Nick Desaulniers via cfe-commits
nt-test/clang-ppc64le-lnt/llvm/tools/clang/test/Sema/conversion.c > Line 362: implicit conversion turns floating-point number into integer: > 'char' to 'float' > 1 error generated. > > -- > > > On Mon, Aug 13, 2018 at 9:46 AM Nick Desaulniers via cfe-commits > wrote: >>

r339581 - [SEMA] add more -Wfloat-conversion to compound assigment analysis

2018-08-13 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Mon Aug 13 09:38:07 2018 New Revision: 339581 URL: http://llvm.org/viewvc/llvm-project?rev=339581=rev Log: [SEMA] add more -Wfloat-conversion to compound assigment analysis Summary: Fixes Bug: https://bugs.llvm.org/show_bug.cgi?id=27061 Reviewers: aaron.ballman,

r337944 - [clang:sema] de-duplicate getDepthAndIndex helpers

2018-07-25 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Wed Jul 25 11:11:01 2018 New Revision: 337944 URL: http://llvm.org/viewvc/llvm-project?rev=337944=rev Log: [clang:sema] de-duplicate getDepthAndIndex helpers Summary: Continuing off of: https://reviews.llvm.org/D38382 Fixes:

r340987 - [AttrDocs]: document gnu_inline function attribute

2018-08-29 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Wed Aug 29 15:50:47 2018 New Revision: 340987 URL: http://llvm.org/viewvc/llvm-project?rev=340987=rev Log: [AttrDocs]: document gnu_inline function attribute Summary: This wasn't documented https://clang.llvm.org/docs/AttributeReference.html, and briefly mentioned

r344375 - [Driver] check for exit code from SIGPIPE

2018-10-12 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Fri Oct 12 10:22:46 2018 New Revision: 344375 URL: http://llvm.org/viewvc/llvm-project?rev=344375=rev Log: [Driver] check for exit code from SIGPIPE Summary: D53000 adds a special exit code for SIGPIPE (writing to a closed reader), and rather than print a fatal

Re: r344375 - [Driver] check for exit code from SIGPIPE

2018-10-12 Thread Nick Desaulniers via cfe-commits
indows. I reverted this to fix the build, but you might want to > reconsider how this is designed. > > On Fri, Oct 12, 2018 at 10:24 AM Nick Desaulniers via cfe-commits > wrote: >> >> Author: nickdesaulniers >> Date: Fri Oct 12 10:22:46 2018 >> New Revision:

r344941 - [Driver] allow Android triples to alias for non Android targets

2018-10-22 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Mon Oct 22 12:48:08 2018 New Revision: 344941 URL: http://llvm.org/viewvc/llvm-project?rev=344941=rev Log: [Driver] allow Android triples to alias for non Android targets Summary: Partial revert of r330873 ('[Driver] Reland "Android triples are not aliases for other

r344958 - [Driver] fix broken test

2018-10-22 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Mon Oct 22 14:25:53 2018 New Revision: 344958 URL: http://llvm.org/viewvc/llvm-project?rev=344958=rev Log: [Driver] fix broken test Summary: Fixes test from r344941 which was broken on Windows. We want to check the selected toolchain rather than the found toolchain

r344536 - Revert 344389 "Revert r344375 "[Driver] check for exit code from SIGPIPE""

2018-10-15 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Mon Oct 15 10:39:00 2018 New Revision: 344536 URL: http://llvm.org/viewvc/llvm-project?rev=344536=rev Log: Revert 344389 "Revert r344375 "[Driver] check for exit code from SIGPIPE"" Summary: Add preprocessor guards for UNIX. This reverts commit r344389. Reviewers:

r343740 - [SEMA] split ExtWarn dupl-decl-spec's into Extension and ExtWarn

2018-10-03 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Wed Oct 3 16:09:29 2018 New Revision: 343740 URL: http://llvm.org/viewvc/llvm-project?rev=343740=rev Log: [SEMA] split ExtWarn dupl-decl-spec's into Extension and ExtWarn Summary: For types deduced from typedef's and typeof's, don't warn for duplicate declaration

r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

2019-01-09 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Wed Jan 9 15:54:55 2019 New Revision: 350776 URL: http://llvm.org/viewvc/llvm-project?rev=350776=rev Log: [Sema] Mark target of __attribute__((alias("target"))) used for C Summary: Prevents -Wunneeded-internal-delcaration warnings when the target has no other

Re: r350776 - [Sema] Mark target of __attribute__((alias("target"))) used for C

2019-01-10 Thread Nick Desaulniers via cfe-commits
variables, this quickly cuts down on tens of false negatives when building the Linux kernel with various driver configurations enabled. The code review points out this is suboptimal. > > On Wed, Jan 9, 2019 at 6:58 PM Nick Desaulniers via cfe-commits > wrote: >> >> Author: nickd

r350877 - [SemaCXX] add -Woverride-init alias to -Winitializer-overrides

2019-01-10 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Thu Jan 10 11:12:39 2019 New Revision: 350877 URL: http://llvm.org/viewvc/llvm-project?rev=350877=rev Log: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides Summary: https://bugs.llvm.org/show_bug.cgi?id=40251

r350878 - fixup: sphinx warning

2019-01-10 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Thu Jan 10 11:26:35 2019 New Revision: 350878 URL: http://llvm.org/viewvc/llvm-project?rev=350878=rev Log: fixup: sphinx warning Fixes the sphinx warning: tools/clang/docs/DiagnosticsReference.rst:7889: WARNING: Title underline too short. That I just introduced in

Re: [PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

2019-01-11 Thread Nick Desaulniers via cfe-commits
On Thu, Jan 10, 2019 at 6:11 PM Yu, Jennifer wrote: > > Syntax for asm goto: > Syntax: > asm [volatile] goto ( AssemblerTemplate > : > : InputOperands > : Clobbers > : GotoLabels) > > Only input is allowed.

Re: [PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

2019-02-05 Thread Nick Desaulniers via cfe-commits
Note that kernel developers are requesting output support with ASM goto. Doesn't need to be in V1 of ASM go-to support, but we should expect it to be implemented in the future. We should help users with diagnostics that this is not supported, and add asserts that will help us implement such a

Re: [PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

2019-06-20 Thread Nick Desaulniers via cfe-commits
Sounds like a good start. On Thu, Jun 20, 2019 at 11:55 AM Tom Roeder via Phabricator wrote: > > tmroeder marked an inline comment as done. > tmroeder added inline comments. > > > > Comment at: clang-tools-extra/test/clang-tidy/linuxkernel-must-check-errs.c:6 > +// Prototypes of

r361314 - [Driver] Verify GCCInstallation is valid

2019-05-21 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Tue May 21 14:21:35 2019 New Revision: 361314 URL: http://llvm.org/viewvc/llvm-project?rev=361314=rev Log: [Driver] Verify GCCInstallation is valid Summary: Values returned by GCCInstallation.getParentLibPath() and GCCInstallation.getTriple() are not valid unless

Re: [PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

2019-07-11 Thread Nick Desaulniers via cfe-commits
Yes, the current behavior is erroring for assembler flags clang does not recognize, which is irrelevant when compiling with `-no-integrated-as`, which is breaking our assembler flag feature detection in building the Linux kernel. On Thu, Jul 11, 2019, 6:09 PM Reid Kleckner via Phabricator <

Re: r369705 - [Clang][CodeGen] set alias linkage on QualType

2019-08-22 Thread Nick Desaulniers via cfe-commits
/consoleFull#-18314650158254eaf0-7326-4999-85b0-388101f2d404 > > Looks like you need to add a triple to the RUN line you added. Can you fix > this? > > Thanks! > Erik > > On Aug 22, 2019, at 1:47 PM, Nick Desaulniers via cfe-commits > wrote: > > Author: nickdesaulniers > Date:

r369713 - [Bugfix] fix r369705 unit test

2019-08-22 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Thu Aug 22 16:18:46 2019 New Revision: 369713 URL: http://llvm.org/viewvc/llvm-project?rev=369713=rev Log: [Bugfix] fix r369705 unit test Summary: Aliases aren't supported on OSX. Add a GNU target triple. Reported-by: leonardchan Reported-by: erik.pilkington

r369705 - [Clang][CodeGen] set alias linkage on QualType

2019-08-22 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Thu Aug 22 13:47:12 2019 New Revision: 369705 URL: http://llvm.org/viewvc/llvm-project?rev=369705=rev Log: [Clang][CodeGen] set alias linkage on QualType Summary: It seems that CodeGen was always using ExternalLinkage when emitting a GlobalDecl with

r371766 - [Clang][CodeGen] support alias attribute w/ gnu_inline

2019-09-12 Thread Nick Desaulniers via cfe-commits
Author: nickdesaulniers Date: Thu Sep 12 12:53:35 2019 New Revision: 371766 URL: http://llvm.org/viewvc/llvm-project?rev=371766=rev Log: [Clang][CodeGen] support alias attribute w/ gnu_inline Summary: r369705 did not consider the addition of gnu_inline on function declarations of alias

Re: r366076 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

2019-07-16 Thread Nick Desaulniers via cfe-commits
On Mon, Jul 15, 2019 at 5:13 PM Eric Christopher wrote: > > I'm going to cheat and make Nick do it :) I suspect that Eric still compiles LLVM by specifying all object files in order on the command line and doesn't want to talk about it on cfe-commits. :) Though, even I'm behind the times as I

Re: r366076 - fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

2019-07-16 Thread Nick Desaulniers via cfe-commits
On Tue, Jul 16, 2019 at 11:02 AM Nick Desaulniers wrote: > > On Mon, Jul 15, 2019 at 5:13 PM Eric Christopher wrote: > > > > I'm going to cheat and make Nick do it :) > > I suspect that Eric still compiles LLVM by specifying all object files > in order on the command line and doesn't want to

[clang] 51adeae - remove redundant LLVM version from version string when setting CLANG_VENDOR

2019-11-08 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2019-11-08T09:24:17-08:00 New Revision: 51adeae1c90c966f5ae7eb1aa8a380fcc7cd4806 URL: https://github.com/llvm/llvm-project/commit/51adeae1c90c966f5ae7eb1aa8a380fcc7cd4806 DIFF:

[clang] 91cdbd5 - clang: Switch C compilations to C17 by default.

2020-03-02 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-03-02T09:39:26-08:00 New Revision: 91cdbd521a38495c66e30636943563ca70d3c022 URL: https://github.com/llvm/llvm-project/commit/91cdbd521a38495c66e30636943563ca70d3c022 DIFF:

[clang] 8b9cb12 - [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

2020-02-18 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-02-18T15:33:46-08:00 New Revision: 8b9cb120812449dbe67d2252ebf619c4c9cac816 URL: https://github.com/llvm/llvm-project/commit/8b9cb120812449dbe67d2252ebf619c4c9cac816 DIFF:

[clang] 246398e - [clang][Parse] properly parse asm-qualifiers, asm inline

2020-03-12 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-03-12T15:13:59-07:00 New Revision: 246398ece7115b57a02dbe7876d86ae8e72406ef URL: https://github.com/llvm/llvm-project/commit/246398ece7115b57a02dbe7876d86ae8e72406ef DIFF:

Re: [clang] 246398e - [clang][Parse] properly parse asm-qualifiers, asm inline

2020-04-13 Thread Nick Desaulniers via cfe-commits
On Sun, Apr 12, 2020 at 3:45 PM Joerg Sonnenberger wrote: > > On Thu, Mar 12, 2020 at 03:25:49PM -0700, Nick Desaulniers via cfe-commits > wrote: > > > > Author: Nick Desaulniers > > Date: 2020-03-12T15:13:59-07:00 > > New Revision: 246398ece7115b57a02

[clang] 5d90f88 - [clang][AArch64] readd support for 'p' inline asm constraint

2020-03-17 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-03-17T10:51:25-07:00 New Revision: 5d90f886bc022e7c9144a0ef08ea7ccde7e66030 URL: https://github.com/llvm/llvm-project/commit/5d90f886bc022e7c9144a0ef08ea7ccde7e66030 DIFF:

[clang] 663f4f7 - [clang] consistently use getLangOpts()

2020-09-01 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-09-01T15:56:53-07:00 New Revision: 663f4f7edc2476231fa5bfc04519d5fd51a10112 URL: https://github.com/llvm/llvm-project/commit/663f4f7edc2476231fa5bfc04519d5fd51a10112 DIFF:

[clang] ef1d4be - [Clang][CGM] style cleanups NFC

2020-06-01 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-01T09:33:08-07:00 New Revision: ef1d4bec891b2121fffa68675e3792b2527a75ee URL: https://github.com/llvm/llvm-project/commit/ef1d4bec891b2121fffa68675e3792b2527a75ee DIFF:

[clang] b7926ce - [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

2020-10-23 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-10-23T11:55:39-07:00 New Revision: b7926ce6d7a83cdf70c68d82bc3389c04009b841 URL: https://github.com/llvm/llvm-project/commit/b7926ce6d7a83cdf70c68d82bc3389c04009b841 DIFF:

[clang] c8f84bd - [Clang][CodeGen] fix failed assertion

2020-10-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-10-26T11:37:55-07:00 New Revision: c8f84bd0947d770a5df5e15d568a25a4f190df0b URL: https://github.com/llvm/llvm-project/commit/c8f84bd0947d770a5df5e15d568a25a4f190df0b DIFF:

[clang] 4f2ad15 - [Clang] implement -fno-eliminate-unused-debug-types

2020-08-10 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-08-10T15:08:48-07:00 New Revision: 4f2ad15db535873dda9bfe248a2771023b64a43c URL: https://github.com/llvm/llvm-project/commit/4f2ad15db535873dda9bfe248a2771023b64a43c DIFF:

[clang] 05d74db - python bindings: fix DeprecationWarning

2020-08-10 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-08-10T15:25:23-07:00 New Revision: 05d74dbc3bb1d943a029e4abea211288c920f559 URL: https://github.com/llvm/llvm-project/commit/05d74dbc3bb1d943a029e4abea211288c920f559 DIFF:

[clang] e486921 - [Clang] implement -fno-eliminate-unused-debug-types

2020-08-07 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-08-07T14:13:48-07:00 New Revision: e486921fd6cf96ae9114adac455f7c0b5c1088a7 URL: https://github.com/llvm/llvm-project/commit/e486921fd6cf96ae9114adac455f7c0b5c1088a7 DIFF:

[clang] cbd8ec9 - fix windows build for D80242

2020-08-07 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-08-07T14:59:35-07:00 New Revision: cbd8ec93709376fbf404c99f4eee399790e26db7 URL: https://github.com/llvm/llvm-project/commit/cbd8ec93709376fbf404c99f4eee399790e26db7 DIFF:

[clang] abb9bf4 - Revert "[Clang] implement -fno-eliminate-unused-debug-types"

2020-08-07 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-08-07T16:11:41-07:00 New Revision: abb9bf4bcf98a226d9350448e31411eb55e9efb0 URL: https://github.com/llvm/llvm-project/commit/abb9bf4bcf98a226d9350448e31411eb55e9efb0 DIFF:

[clang] 73413d2 - Revert "fix windows build for D80242"

2020-08-07 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-08-07T16:11:26-07:00 New Revision: 73413d266abc2436bd1993a4e21a9151bd102f17 URL: https://github.com/llvm/llvm-project/commit/73413d266abc2436bd1993a4e21a9151bd102f17 DIFF:

[clang] 7c2cb14 - Revert "[clang][SourceManager] cache Macro Expansions"

2020-06-29 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-29T12:54:32-07:00 New Revision: 7c2cb1448ad2d20e251db5e3ae4a0c84c12aa970 URL: https://github.com/llvm/llvm-project/commit/7c2cb1448ad2d20e251db5e3ae4a0c84c12aa970 DIFF:

[clang] 7b8cf98 - Reland "[clang][SourceManager] cache Macro Expansions""

2020-06-29 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-29T12:54:32-07:00 New Revision: 7b8cf98b4a9a2f5ea3667fdbf913a4f8952ed36a URL: https://github.com/llvm/llvm-project/commit/7b8cf98b4a9a2f5ea3667fdbf913a4f8952ed36a DIFF:

[clang] 408efff - [Clang][SourceManager] optimize getFileIDLocal()

2020-06-25 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-25T09:59:41-07:00 New Revision: 408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3 URL: https://github.com/llvm/llvm-project/commit/408efffbe4a52bae05f1677a47eb3ccfd5cdc1d3 DIFF:

[clang] 8cce7af - [SourceManager] don't check invalid param of getLocalSLocEntry()

2020-06-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-26T10:22:26-07:00 New Revision: 8cce7af090bd011f6371dec34dfcab494cc74c46 URL: https://github.com/llvm/llvm-project/commit/8cce7af090bd011f6371dec34dfcab494cc74c46 DIFF:

[clang] dffc142 - [clang][SourceManager] cache Macro Expansions

2020-06-26 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-26T12:52:43-07:00 New Revision: dffc1420451f674731cb36799c8ae084104ff0b5 URL: https://github.com/llvm/llvm-project/commit/dffc1420451f674731cb36799c8ae084104ff0b5 DIFF:

[clang] 8eda716 - [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

2020-06-02 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-06-02T15:54:14-07:00 New Revision: 8eda71616fecd098cbd7d2447859c8ac1315966f URL: https://github.com/llvm/llvm-project/commit/8eda71616fecd098cbd7d2447859c8ac1315966f DIFF:

[clang] 0a23fbd - clang: Always pass PowerPC endian information to GNU as

2021-01-11 Thread Nick Desaulniers via cfe-commits
Author: Nathan Chancellor Date: 2021-01-11T14:50:28-08:00 New Revision: 0a23fbd28c7509f2f980946091e6055bf27164d2 URL: https://github.com/llvm/llvm-project/commit/0a23fbd28c7509f2f980946091e6055bf27164d2 DIFF:

[clang] e75fec2 - [AttrDocs] document always_inline

2020-12-17 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-12-17T12:34:23-08:00 New Revision: e75fec2b238f0e26cfb7645f2208baebe3440d41 URL: https://github.com/llvm/llvm-project/commit/e75fec2b238f0e26cfb7645f2208baebe3440d41 DIFF:

[clang] f4c6080 - Revert "[IR] add fn attr for no_stack_protector; prevent inlining on mismatch"

2020-11-17 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-11-17T17:27:14-08:00 New Revision: f4c6080ab820219c5bf78b0c2143e7fa194da296 URL: https://github.com/llvm/llvm-project/commit/f4c6080ab820219c5bf78b0c2143e7fa194da296 DIFF:

[clang] cdff3bd - [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

2020-10-28 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2020-10-28T11:20:30-07:00 New Revision: cdff3bd932870cc9f84c6828cb1a7bb0df3c5fa0 URL: https://github.com/llvm/llvm-project/commit/cdff3bd932870cc9f84c6828cb1a7bb0df3c5fa0 DIFF:

[clang] 3787ee4 - reland [IR] make -stack-alignment= into a module attr

2021-06-08 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-08T10:59:46-07:00 New Revision: 3787ee457173c3612aac4c9b1a2b6d6ab0202616 URL: https://github.com/llvm/llvm-project/commit/3787ee457173c3612aac4c9b1a2b6d6ab0202616 DIFF:

[clang] fc018eb - [IR] make -warn-frame-size into a module attr

2021-06-10 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-10T16:15:27-07:00 New Revision: fc018ebb608ee0c1239b405460e49f1835ab6175 URL: https://github.com/llvm/llvm-project/commit/fc018ebb608ee0c1239b405460e49f1835ab6175 DIFF:

[clang] a63d4f6 - [Clang][Codegen] rename no_profile fn attr no_profile_instrument_function

2021-06-21 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-21T11:42:06-07:00 New Revision: a63d4f6cbab133b0f1ce9afb562546fcc5bb2680 URL: https://github.com/llvm/llvm-project/commit/a63d4f6cbab133b0f1ce9afb562546fcc5bb2680 DIFF:

[clang] 8ace121 - [IR] convert warn-stack-size from module flag to fn attr

2021-06-21 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-21T15:09:25-07:00 New Revision: 8ace12130526f450c822ca232d1f865b247d7434 URL: https://github.com/llvm/llvm-project/commit/8ace12130526f450c822ca232d1f865b247d7434 DIFF:

[clang] 193e41c - [Clang][Codegen] Add GNU function attribute 'no_profile' and lower it to noprofile

2021-06-18 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-18T13:42:32-07:00 New Revision: 193e41c987127aad86d0380df83e67a85266f1f1 URL: https://github.com/llvm/llvm-project/commit/193e41c987127aad86d0380df83e67a85266f1f1 DIFF:

[clang] 8172183 - Whitespace fixes for

2021-06-18 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-18T15:09:18-07:00 New Revision: 817218336aa3e3c0ca422ae00f8d8ca41b8fbd6d URL: https://github.com/llvm/llvm-project/commit/817218336aa3e3c0ca422ae00f8d8ca41b8fbd6d DIFF:

[clang] 433c8d9 - [IR] make -stack-alignment= into a module attr

2021-06-08 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-08T08:31:04-07:00 New Revision: 433c8d950cb3a1fa0977355ce0367e8c763a3f13 URL: https://github.com/llvm/llvm-project/commit/433c8d950cb3a1fa0977355ce0367e8c763a3f13 DIFF:

[clang] a596b54 - Revert "[IR] make -stack-alignment= into a module attr"

2021-06-08 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-06-08T08:55:50-07:00 New Revision: a596b54d471cfde548bdda3925ea2f143f06b964 URL: https://github.com/llvm/llvm-project/commit/a596b54d471cfde548bdda3925ea2f143f06b964 DIFF:

[clang] 0f41778 - [AArch64] Support customizing stack protector guard

2021-05-17 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-05-17T11:49:22-07:00 New Revision: 0f417789192e74f9d2fad0f6aee4efc394257176 URL: https://github.com/llvm/llvm-project/commit/0f417789192e74f9d2fad0f6aee4efc394257176 DIFF:

[clang] 033138e - [IR] make stack-protector-guard-* flags into module attrs

2021-05-21 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-05-21T15:53:30-07:00 New Revision: 033138ea452f5f493fb5095e5963419905ad12e1 URL: https://github.com/llvm/llvm-project/commit/033138ea452f5f493fb5095e5963419905ad12e1 DIFF:

[clang] ea8416b - [CodeGenOptions] make StackProtectorGuardOffset signed

2021-04-27 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-04-27T10:12:58-07:00 New Revision: ea8416bf4df4e2823d85d50d8ddd69dd8ed54720 URL: https://github.com/llvm/llvm-project/commit/ea8416bf4df4e2823d85d50d8ddd69dd8ed54720 DIFF:

[clang] aefbfbc - [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

2021-05-05 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-05-05T11:01:43-07:00 New Revision: aefbfbcbd776f5549b18cd6083d6408f661efacc URL: https://github.com/llvm/llvm-project/commit/aefbfbcbd776f5549b18cd6083d6408f661efacc DIFF:

[clang] a680bc3 - [clang][Arm] Fix handling of -Wa,-implicit-it=

2021-02-11 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-02-11T10:51:25-08:00 New Revision: a680bc3a31d36d321ccf3801bdcff74d58842bfa URL: https://github.com/llvm/llvm-project/commit/a680bc3a31d36d321ccf3801bdcff74d58842bfa DIFF:

[clang] bf2479c - Revert "Add support to -Wa,--version in clang"

2021-03-31 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-03-31T17:02:13-07:00 New Revision: bf2479c347c8ca88fefdb144d8bae0a7a4231e2a URL: https://github.com/llvm/llvm-project/commit/bf2479c347c8ca88fefdb144d8bae0a7a4231e2a DIFF:

[clang] 846e562 - [Clang] add support for error+warning fn attrs

2021-08-25 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-08-25T10:34:18-07:00 New Revision: 846e562dcc6a9a611d844dc0d123da95629a0567 URL: https://github.com/llvm/llvm-project/commit/846e562dcc6a9a611d844dc0d123da95629a0567 DIFF:

[clang] d238b60 - [Clang][DiagnosticSemaKinds] combine diagnostic texts

2021-08-06 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-08-06T13:58:21-07:00 New Revision: d238b60285820691b08bcca3ec510d13ea46a5ed URL: https://github.com/llvm/llvm-project/commit/d238b60285820691b08bcca3ec510d13ea46a5ed DIFF:

[clang] 9f95bc7 - [clang][ARM] relax -mtp=cp15 for non-thumb cases

2021-12-03 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-12-03T14:00:00-08:00 New Revision: 9f95bc7dc18390199553cf2ea3bfcdc6a95717ef URL: https://github.com/llvm/llvm-project/commit/9f95bc7dc18390199553cf2ea3bfcdc6a95717ef DIFF:

[clang] 73ee4e1 - [clang][ARM] only check -mtp=cp15 for non-asm sources

2021-12-06 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-12-06T11:31:23-08:00 New Revision: 73ee4e1cbd643028d63200f05199a128609aba5f URL: https://github.com/llvm/llvm-project/commit/73ee4e1cbd643028d63200f05199a128609aba5f DIFF:

[clang] cd284b7 - [clang][ARM] re-use arm::isHardTPSupported for hardware TLS check

2021-12-28 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2021-12-28T13:28:34-08:00 New Revision: cd284b7ac0615afc6e0f1a30da2777e361de27a3 URL: https://github.com/llvm/llvm-project/commit/cd284b7ac0615afc6e0f1a30da2777e361de27a3 DIFF:

[clang] c8463fd - [clang][CGStmt] emit i constraint rather than X for asm goto indirect dests

2022-01-11 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2022-01-11T11:48:40-08:00 New Revision: c8463fd22b1ff05c0273e7f446c9feeb114c3798 URL: https://github.com/llvm/llvm-project/commit/c8463fd22b1ff05c0273e7f446c9feeb114c3798 DIFF:

[clang] 5c562f6 - [clang] number labels in asm goto strings after tied inputs

2022-01-11 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2022-01-11T12:09:24-08:00 New Revision: 5c562f62a4ee15592f5d764d0710553a4b07a6f2 URL: https://github.com/llvm/llvm-project/commit/5c562f62a4ee15592f5d764d0710553a4b07a6f2 DIFF:

[clang] 5a2e56b - [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

2022-03-23 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2022-03-23T09:40:43-07:00 New Revision: 5a2e56b70e2fa7ad0d82e54bc4c741b16f05e475 URL: https://github.com/llvm/llvm-project/commit/5a2e56b70e2fa7ad0d82e54bc4c741b16f05e475 DIFF:

[clang] 3a604fd - [Clang][CFG] check children statements of asm goto

2022-01-07 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2022-01-07T14:11:08-08:00 New Revision: 3a604fdbcd5fd9ca41f6659692bb4ad2151c3cf4 URL: https://github.com/llvm/llvm-project/commit/3a604fdbcd5fd9ca41f6659692bb4ad2151c3cf4 DIFF:

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-11 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers closed https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers commented: Thanks for the patch! Can we document this behavior somewhere? https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Nick Desaulniers via cfe-commits
@@ -860,6 +860,16 @@ class EstimateSizeFormatHandler : Size(std::min(Format.find(0), Format.size()) + 1 /* null byte always written by sprintf */) {} + bool ShouldStopOnFormatSpecifier(const analyze_printf::PrintfSpecifier , +

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Nick Desaulniers via cfe-commits
@@ -429,7 +429,13 @@ bool clang::analyze_format_string::ParsePrintfString(FormatStringHandler , // we can recover from? if (!FSR.hasValue()) continue; -// We have a format specifier. Pass it to the callback. +// We have a format specifier. +// In

[clang] cfa578c - [Sema] add test cases for D152495 NFC

2023-08-31 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2023-08-31T14:17:41-07:00 New Revision: cfa578cde0314935c6eb5d7fa19ec26390d431dd URL: https://github.com/llvm/llvm-project/commit/cfa578cde0314935c6eb5d7fa19ec26390d431dd DIFF:

[clang] f0f395e - Revert "Reland "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions""

2023-08-31 Thread Nick Desaulniers via cfe-commits
Author: Nick Desaulniers Date: 2023-08-31T11:58:41-07:00 New Revision: f0f395e00e2ec3f1f20ca9021d1554fde73d56c9 URL: https://github.com/llvm/llvm-project/commit/f0f395e00e2ec3f1f20ca9021d1554fde73d56c9 DIFF:

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-12 Thread Nick Desaulniers via cfe-commits
@@ -163,6 +163,10 @@ Improvements to Clang's diagnostics - Clang's ``-Wfortify-source`` now diagnoses ``snprintf`` call that is known to result in string truncation. (`#64871: `_). + Clang stops calculating the minimum

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-12 Thread Nick Desaulniers via cfe-commits
@@ -851,6 +851,50 @@ class ScanfDiagnosticFormatHandler } }; +/// `I` points to the next character of `%p` format. +/// This functon checks if the subsequent character can be linux kernel's +/// extnded format specifier +static inline constexpr bool

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-12 Thread Nick Desaulniers via cfe-commits
@@ -851,6 +851,50 @@ class ScanfDiagnosticFormatHandler } }; +/// `I` points to the next character of `%p` format. +/// This functon checks if the subsequent character can be linux kernel's +/// extnded format specifier +static inline constexpr bool

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-12 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: > Is there some way we can narrow the scope of this patch so we don't lose > warnings for normal `snprintf`s, only for the kernel one? If we really can't > tell the difference from the source code, we could move the affected warnings > to a different warning group

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-13 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: @nathanchance and I have done a bunch of testing of this revision (see comments https://github.com/ClangBuiltLinux/linux/issues/1923#issuecomment-1718144462 and down); this looks like something that will work nicely for the Linux kernel's use case! Thanks for all of the

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers created https://github.com/llvm/llvm-project/pull/65818: After commit 610ec954e1f8 ("[clang] allow const structs/unions/arrays to be constant expressions for C"), attempts to evaluate structs/unions/arrays as constants are also performed for C++98 and C++03.

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers review_requested https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][VarDecl] Reset un-evaluated constant for all C++ modes (PR #65818)

2023-09-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/65818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGExprConstant] stop calling into ConstExprEmitter for Reference type destinations (PR #70366)

2023-10-27 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: > I think I'd prefer to avoid calling into ConstExprEmitter at all for cases > involving reference binding. I think we've sort of discussed this before. > Maybe add a check to tryEmitPrivate()? (We already have a check in > tryEmitPrivateForVarInit().) Done in

[clang] [CGExprConstant] stop calling into ConstExprEmitter for Reference type destinations (PR #70366)

2023-10-27 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/70366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

2023-10-30 Thread Nick Desaulniers via cfe-commits
@@ -859,53 +859,60 @@ CodeGenFunction::emitBuiltinObjectSize(const Expr *E, unsigned Type, } if (IsDynamic) { -LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel = -getLangOpts().getStrictFlexArraysLevel(); -const Expr *Base =

[clang] [CodeGen] Revamp counted_by calculations (PR #70606)

2023-10-30 Thread Nick Desaulniers via cfe-commits
@@ -966,9 +962,68 @@ static llvm::Value *getArrayIndexingBound(CodeGenFunction , return nullptr; } -FieldDecl *CodeGenFunction::FindCountedByField( -const Expr *Base, -LangOptions::StrictFlexArraysLevelKind StrictFlexArraysLevel) { +Expr

  1   2   3   4   >