[PATCH] D29764: [OpenCL] Blocks cannot capture/reference another block

Nicola added a comment. Looking at "Example 4" in the standard it looks like this should also be illegal. int (^block1)(void) = ^int {return 1;}; int foo() { return block1(); } __kernel void k(global int *z) { int (^block2)(void) = ^int { return foo(); // expected-error

[PATCH] D44975: Change DEBUG() macro to LLVM_DEBUG()

Nicola added a comment. Ping? I'm not sure who to add as reviewers as it's generic change. Repository: rC Clang https://reviews.llvm.org/D44975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44976: Change DEBUG() macro to LLVM_DEBUG() in clang-tools-extra

Nicola added a comment. Ping? I'm not sure who to add as reviewers as it's generic change. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44976: Change DEBUG() macro to LLVM_DEBUG() in clang-tools-extra

Nicola created this revision. Herald added subscribers: cfe-commits, ioeric. The DEBUG() macro is too generic so it might clash with other projects. This is going to be deprecated and replaced by LLVM_DEBUG() as soon as https://reviews.llvm.org/D43624 is submitted. This is the command I used to

[PATCH] D44975: Change DEBUG() macro to LLVM_DEBUG()

Nicola created this revision. Herald added subscribers: cfe-commits, javed.absar, klimek. The DEBUG() macro is too generic so it might clash with other projects. This is going to be deprecated and replaced by LLVM_DEBUG() as soon as https://reviews.llvm.org/D43624 is submitted. This is the

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

Nicola added a comment. This looks quite useful, thanks for taking time to do it! I can help verifying some of the tablegen'd builtins with internal tests too, if you decide to pursue this further. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53023/new/

[PATCH] D53023: Prototype OpenCL BIFs using Tablegen

Nicola added a comment. Since this review is just for a prototype, I'll leave some feedback after having played with it for a bit. It seems to be quite trivial to add new builtins and fix existing ones (conversion builtins sat/rounding modes). One builtin that might have a small issue is the

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Nicola added a comment. A bit late to the review, but I've noticed a couple of issues with some of the implemented builtins: - The fmin/fmax builtins are defined twice for scalar types, does this create problems in overload resolution when using them? - The convert_ builtins don't have support

[PATCH] D60763: Prototype OpenCL BIFs using Tablegen

Nicola added inline comments. Comment at: clang/include/clang/Basic/OpenCLBuiltins.td:140-144 +class RoundingModes { + list Modes = !if(!or(_Ty1.HasRounding, _Ty2.HasRounding), + ["", "_rte", "_rtz", "_rtp", "_rtn"], + [""]); +}

[PATCH] D71476: [OpenCL] Add builtin function extension handling

Nicola accepted this revision. Nicola added a comment. Just a minor comment, can you address it before you submit? Thanks! Comment at: clang/lib/Sema/OpenCLBuiltins.td:1095 // OpenCL v2.0 s9.17.3: Additions to section 6.13.1: Work-Item Functions +def FuncExtKhrSubgroups :

[PATCH] D68328: Fix occurrences that size and range of pointers are assumed to be the same.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f6208778ff9: [DataLayout] Fix occurrences that size and range of pointers are assumed to be… (authored by Nicola). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D68328: Fix occurrences that size and range of pointers are assumed to be the same.

Nicola added a comment. Reverted in f798eb21eca97dc44ed40da52ece22780fb74230 as it was causing failures in