[PATCH] D156636: [InstCombine] Deduce `align` and `nonnull` return attributes for `llvm.ptrmask`

goldstein.w.n abandoned this revision. goldstein.w.n added a comment. This has been ported to github PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156636/new/ https://reviews.llvm.org/D156636 ___

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n created this revision. Herald added a project: All. goldstein.w.n requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I.e with: PPIndentWidth = 1 IndentWidth = 4 ``` #ifdef foo #define bar() if (A) { B(); } C();

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 472397. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3935752 , @owenpan wrote: > Please mark review comments as done if you have addressed them. Can you also > clean up the test cases, removing overlapping/redundant ones, making sure a > test case doesn't end

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 476337. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:69-75 + if (Line.InMacroBody) { +Indent = (Line.PPLevel + 1) * PPIndentWidth; +Indent += (Line.Level - Line.PPLevel - 1) * Style.IndentWidth; +Indent +=

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 476732. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3938942 , @owenpan wrote: > In D137181#3938913 , @goldstein.w.n > wrote: > >> Anything left for me todo (can't imagine I have push access). > > See here

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 476528. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3935951 , @owenpan wrote: > In D137181#3935856 , @goldstein.w.n > wrote: > >> In D137181#3935752 , @owenpan >> wrote: >> >>>

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 476654. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n marked an inline comment as done. goldstein.w.n added a comment. In D137181#3938771 , @owenpan wrote: > In D137181#3935951 , @owenpan wrote: > >> In D137181#3935856

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n marked 2 inline comments as done. goldstein.w.n added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:838 + // If this changes PPLevel needs to be used for get correct indentation. + assert(!Line.InMacroBody && !InPPDirective); return

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n marked an inline comment as done. goldstein.w.n added a comment. In D137181#3938904 , @owenpan wrote: > LGTM Awesome! Thanks for sticking with it through all these revisions :) Anything left for me todo (can't imagine I have push access).

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 476013. goldstein.w.n marked 2 inline comments as done. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3926848 , @owenpan wrote: > In D137181#3924002 , @sstwcw wrote: > >> Can you make `TokenAnnotator::printDebugInfo` print `PPLevel`? > > @goldstein.w.n can you add it as

[PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

goldstein.w.n added a comment. FWIW, if the only use if hashtables `xxhash` has a slight perf bug in `XXH3_len_129to240_128b` and `XXH3_len_129to240_64b` where it will repeat the last the block if length is a factor of `32`/`16` respectively. `XXH3_len_129to240_128b`: -

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3904383 , @owenpan wrote: > With `ColumnLimit: 16` and `IndentPPDirectives: BeforeHash`, the format > should be: > > #ifdef foo >#define bar() \ >if (A) { \ >B(); \ >}

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 473489. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3910566 , @owenpan wrote: > In D137181#3910404 , @goldstein.w.n > wrote: > >> Doesn't that add an arbitrary +1 to the begining of the indentation? >> Shouldn't it be: >>

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 474079. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.h:47 + /// The preprocessor indent level of the \c UnwrappedLine. + int PPLevel; sstwcw wrote: > Please elaborate what preprocessor indent level means. Done. Repository:

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3916474 , @owenpan wrote: > You can still simply the changes to UnwrappedLineParser.cpp a lot. In fact, > instead of adjusting `PPLevel` at various places, you only need to set it > once when `InMacroBody` is

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3916505 , @owenpan wrote: > In D137181#3916488 , @goldstein.w.n > wrote: > >> In D137181#3916474 , @owenpan >> wrote: >> >>>

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:92-94 + if (Line.Level >= IndentForLevel.size()) +IndentForLevel.resize(Line.Level + 1, UnknownIndent ? -1 : Indent); +} owenpan wrote: > Please run

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3916547 , @owenpan wrote: > In D137181#3916521 , @goldstein.w.n > wrote: > >> I think we can remove the places I set `InitialPPLevel` and `OldPPLevel` but >> anything

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3914066 , @owenpan wrote: > @goldstein.w.n do you need to modify MacroCallReconstructor.cpp, Macros.h, > and MacroCallReconstructorTest.cpp? Leaving them out wouldn't break any > existing tests. > > Adding

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 473875. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3911602 , @owenpan wrote: > In D137181#3911005 , @sstwcw wrote: > >> Here is one problem: >> >> clang-format -style='{IndentPPDirectives: BeforeHash, PPIndentWidth: 1,

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3911602 , @owenpan wrote: > In D137181#3911005 , @sstwcw wrote: > >> Here is one problem: >> >> clang-format -style='{IndentPPDirectives: BeforeHash, PPIndentWidth: 1,

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 473906. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3914245 , @owenpan wrote: > In D137181#3914083 , @goldstein.w.n > wrote: > >> In D137181#3914066 , @owenpan >> wrote: >> >>>

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 473917. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3914292 , @owenpan wrote: > In D137181#3914100 , @goldstein.w.n > wrote: > >> Err I'm not sure that's right. I thought we where going for the C-code >> should start at

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3910799 , @owenpan wrote: > IMO we should find a simpler way to indent bodies of macro definitions that > are nested more than one level deep. I prefer we handle that in another patch > and only support the

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5056-5059 + "if (A) { \\\n" + "B(); \\\n" + "}\\\n" + "C();\n" owenpan

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5056-5059 + "if (A) { \\\n" + "B(); \\\n" + "}\\\n" + "C();\n"

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3903161 , @owenpan wrote: > Can you fix the format of the summary? I see the misindentation of the After/Before hash examples. Will fix those for V2. Anything else? Repository: rG LLVM Github Monorepo

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5024 style); + verifyFormat("#if 1\n" owenpan wrote: > Don't add an empty line here. Will drop for V2. Comment at:

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 474359. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3916605 , @owenpan wrote: > In D137181#3916558 , @goldstein.w.n > wrote: > >> In D137181#3916547 , @owenpan >> wrote: >> >>>

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 474447. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3918673 , @owenpan wrote: > In D137181#3918117 , @goldstein.w.n > wrote: > maybe you did something different? >>> >>> Here is what I did: >>> >>> $ git diff

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3923434 , @owenpan wrote: > In D137181#3918715 , @goldstein.w.n > wrote: > >> In D137181#3918673 , @owenpan >> wrote: >> >>>

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n marked an inline comment as done. goldstein.w.n added a comment. In D137181#3899874 , @MyDeveloperDay wrote: > This needs a unit test in clang/unittest/Format Fixed in V2 I think but not sure as the summary doesn't seem to have changed.

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 472759. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5056-5059 + "if (A) { \\\n" + "B(); \\\n" + "}\\\n" + "C();\n" owenpan

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 475050. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n marked 2 inline comments as done. goldstein.w.n added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:69 (Style.PPIndentWidth >= 0) ? Style.PPIndentWidth : Style.IndentWidth; - Indent = Line.Level * IndentWidth +

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3923921 , @owenpan wrote: > I think we are close to the finishing line. Can you revisit the change to the > formatter and clean it up? For example, casting `PPLevel` to `unsigned` is > redundant now. IMO you

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

goldstein.w.n added a comment. LGTM. I'm not a maintainer to please wait a day or so to push so that others can review. Comment at: clang/lib/Headers/pmmintrin.h:278 ///the monitor event pending state. Data stored in the monitored address ///range causes the

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

goldstein.w.n accepted this revision. goldstein.w.n added a comment. This revision is now accepted and ready to land. LGTM. I'm not a maintainer so wait a day to push so others can take a look. Comment at: clang/lib/Headers/avx2intrin.h:789 - static __inline__ __m128i

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://reviews.llvm.org/D152226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added inline comments. Comment at: llvm/lib/Transforms/Utils/InferCallsiteAttrs.cpp:597 + // callsite violating the constraint. + if (checkCallerDoesNotAccessMemory() && !CB->doesNotAccessMemory()) { +// Wait until we know we actually need it to do

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n updated this revision to Diff 530798. goldstein.w.n added a comment. fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://reviews.llvm.org/D152226 Files: clang/test/CodeGen/LoongArch/inline-asm-constraints.c

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n marked 8 inline comments as done. goldstein.w.n added inline comments. Comment at: llvm/include/llvm/Transforms/Utils/InferCallsiteAttrs.h:28 + // relatively high value is okay. + static constexpr unsigned kMaxChecks = UINT_MAX; + arsenm wrote: >

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. goldstein.w.n marked an inline comment as done. Closed by commit rG4fa971ff62c3:

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added a comment. In D152226#4418498 , @jdoerfert wrote: > FWIW, I wish the time that went into this would have been to improve and > enable the (lightweight) Attributor pass. > Anyway, I'm still doing that, and the latest numbers didn't

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added a comment. In D152226#4418978 , @goldstein.w.n wrote: > In D152226#4418498 , @jdoerfert > wrote: > >> FWIW, I wish the time that went into this would have been to improve and >> enable the

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added inline comments. Comment at: libc/CMakeLists.txt:22 +# that clang will use it. +if(LLVM_LIBC_MAKE_DISCOVERABLE) + if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR) sivachandra wrote: > Likely out of date and not required for this patch? woops, left

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n updated this revision to Diff 529201. goldstein.w.n added a comment. Add header comments/license. Use enum for kMaybe, kYes, kNo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://reviews.llvm.org/D152226 Files:

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n created this revision. goldstein.w.n added reviewers: nikic, fhahn, jdoerfert, arsenm. Herald added subscribers: libc-commits, luke, pmatos, asb, ormris, StephenFan, frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult,

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added a comment. llvm-test-suite passes with this patch enabled. But note: **There currently some failing clang tests**. Most of them look benign (just need to propagate a few attributes to a few thousand places), but I was hoping there is a way to auto-regenerate them before going

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n updated this revision to Diff 528707. goldstein.w.n marked an inline comment as done. goldstein.w.n added a comment. Remove libc changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/ https://reviews.llvm.org/D152226

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

goldstein.w.n accepted this revision. goldstein.w.n added a comment. This revision is now accepted and ready to land. In D156556#4555036 , @kitaisreal wrote: > In D156556#4554436 , @goldstein.w.n > wrote: > >>

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

goldstein.w.n added a comment. Can you mark the title as NFC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156556/new/ https://reviews.llvm.org/D156556 ___ cfe-commits mailing list

[PATCH] D156636: [InstCombine] Deduce `align` and `nonnull` return attributes for `llvm.ptrmask`

goldstein.w.n created this revision. goldstein.w.n added reviewers: nikic, RKSimon. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. goldstein.w.n requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D157485: [X86][RFC] Support new feature AVX10

goldstein.w.n added inline comments. Comment at: clang/lib/Basic/Targets/X86.h:99 + bool HasAVX10_1 = false; + bool HasAVX10_512BIT = false; bool HasAVX512CD = false; Maybe should be HasAVX10_1_512? As brought up the rfc, there might be an avx10.2-512

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n updated this revision to Diff 531233. goldstein.w.n added a comment. Remove unused check count. Use memory effects directly instead of function/callbase attribute API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152226/new/

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added inline comments. Comment at: llvm/lib/Transforms/Utils/InferCallsiteAttrs.cpp:597 + // callsite violating the constraint. + if (checkCallerDoesNotAccessMemory() && !CB->doesNotAccessMemory()) { +// Wait until we know we actually need it to do

[PATCH] D152226: [FunctionAttrs] Propagate some func/arg/ret attributes from caller to callsite (WIP)

goldstein.w.n added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:1764 + if (ICA.processFunction(F)) +Changed.insert(F); + } Do we actually need to add the function to the changed list here? We aren't modifying the

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

goldstein.w.n accepted this revision. goldstein.w.n added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150278/new/ https://reviews.llvm.org/D150278 ___ cfe-commits mailing