[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

probinson added a comment. I'm happy if @dblaikie is happy. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:515 +// +// And as @dblaikie noted, this solution is far from perfert, better to +// encode it into IR metadata, but this may not worth it, since

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

probinson added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:515 +// +// But note, this solution is far from perfert, better to encode it into IR +// metadata, but this may not worth it, since looks like aranges on the way

[PATCH] D133875: [clang] fix generation of .debug_aranges with LTO (resubmit)

probinson added inline comments. Comment at: clang/test/Driver/debug-options-aranges.c:7 +// RUN: %clang -### -g -target x86_64-linux -flto=thin -fuse-ld=lld -gdwarf-aranges %s 2>&1 | FileCheck -check-prefix=PLUGIN_GARANGE %s +// GARANGE: -generate-arange-section +//

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

probinson added a comment. > The number of people likely to notice that PS4 is different from the other > targets seems far smaller than the number of people noticing the same for > Windows. But I've got no data to back that up, either. heh. There's a PS4 bot that notices. But the PS4

[PATCH] D134544: [clang-cl] Implement /ZH: flag

probinson added a project: debug-info. probinson added a comment. Probably we should reject the -gsrc... option if we're emitting DWARF, which requires MD5 (at least so far). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134544/new/ https://reviews.llvm.org/D134544

[PATCH] D134468: [Driver] Ignore -fmsc-version= -fms-compatibility-version= values smaller than 19

probinson added a comment. These kinds of compatibility changes generally should get a Discourse post for better visibility. Comment at: clang/docs/ReleaseNotes.rst:85 + a version smaller than ``19.0`` is now unsupported. + Or words to that effect. "19.0"

[PATCH] D98438: Clang: Allow selecting the hash algorithm for file checksums in debug info.

probinson added a comment. So this one can be marked abandoned? You might need to commandeer it first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98438/new/ https://reviews.llvm.org/D98438 ___

[PATCH] D134544: [clang-cl] Implement /ZH: flag

probinson added inline comments. Comment at: clang/test/CodeGen/debug-info-file-checksum.c:3 +// RUN: %S/Inputs/debug-info-file-checksum.c -o - | FileCheck %s +// RUN: %clang -emit-llvm -S -g -gcodeview -gsrc-hash-algorithm=md5 -x c \ +// RUN:

[PATCH] D134507: [Clang] add missing ClangABICompat check

probinson added a comment. Anytime there's a Clang ABI version check, I have to wonder whether PS4/PS5 need an exception. (And I'm sorry I missed the earlier patches in this series.) We are pretty much locked to however things worked for Clang 3.2. Is this specific to C++20 (or later)? In

[PATCH] D134507: [Clang] add missing ClangABICompat check

probinson added a comment. Hi @ychen I saw you updated the patch description, thanks. IIUC, the change causes some difference in the interpretation of particular template stuff. Would this be clearer if the BEFORE-15/AFTER-15 test cases used the same template construct? Currently they are

[PATCH] D134880: [clang] [test] Use %clang_cc1 substitution consistently

probinson added inline comments. Comment at: clang/test/Driver/lit.local.cfg:8 -('%clang_cc1', - """*** Do not use 'clang -cc1' in Driver tests. ***""") ) But we _don't_ want to use `%clang_cc1` in Driver tests; if we do, then we're not testing the

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

probinson added a comment. In D111000#3822354 , @ychen wrote: > It is possible to just use `clang-format @response.txt`? That should also > invoke the executable once. It's true that whatever file you're handing to `--files` could just as easily be

[PATCH] D135115: [clang-format] update --files help description

probinson added inline comments. Comment at: clang/docs/ClangFormat.rst:72-73 Used only with --dry-run or -n ---files= - Provide a list of files to run clang-format +--files= - Accept a list of response

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. The option handling in clang-format itself would need to be updated as well. Comment at: clang/docs/ClangFormat.rst:29 USAGE: clang-format [options] [ ...] MyDeveloperDay wrote: > if response files are so common place why not

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. The help text in ClangFormat.cpp for the `--files` option needs to be updated the same way. Note using `cl::value_desc("filename")` is what you need to change the meta-variable in the help output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

probinson added subscribers: wristow, probinson. probinson added a comment. +wristow who has been tracking this kind of stuff for Sony. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 ___

[PATCH] D135551: [clang] replace `assert(0)` with `llvm_unreachable` NFC

probinson added a comment. dblaikie: > In the same way that an assert says "This condition should never be false" - > I use "should" in the same sense in both unreachable and assert, and I > believe that's the prevailing opinion of LLVM developers/the LLVM style guide. aaronballman: > I

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. In D135115#3839547 , @HazardyKnusperkeks wrote: > It's too long ago for me. Does the `--files` option take multiple file names > on the command line, or a file containing the file names? If the latter the > patch generally

[PATCH] D135488: [codegen][WIP] Display stack layouts in console

probinson added inline comments. Comment at: clang/test/Frontend/frame-diags.c:1 +// TODO: This is not really a functional test yet, and needs to be rewritten. +// currently its just a copy of backend-diagnostics.c, and all of the run/test I know this is a

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

probinson added a comment. Response files should work for all our tools, I think? Keeping the option is fine with me, but the description needs some improvement. @ychen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111000/new/

[PATCH] D128934: [X86] Add RDPRU instruction

probinson added a comment. In D128934#3630800 , @probinson wrote: > In D128934#3629653 , @pengfei wrote: > >> > > Done, thanks for the reminder! > >>> 2. Update `clang/lib/Headers/cpuid.h` and

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

probinson added a comment. > lld has tests for --reproduce already. Even if I added an environment > variable to crash lld, the test would depend on lld being built, adding a big > dependency to clang's tests. Do we think that's worth it? There is now cross-project-tests which would seem to be

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default dialect

probinson added a comment. What Aaron said. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131465/new/ https://reviews.llvm.org/D131465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D120175: [Driver] Re-run lld with --reproduce when it crashes

probinson added a comment. > there didn't already exist a PS4 lit feature that I could mark as unsupported. ? I believe `UNSUPPORTED: ps4` should work, because UNSUPPORTED will look at the default target triple. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

probinson added a subscriber: wolfgangp. probinson added a comment. Basically you're homing a pointer to the parameter, rather than the parameter itself, which makes sense in this context. I suspect the code size/perf impact on -O0 will not be huge, as this sounds like it's only for

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

probinson added a comment. I should expand on my previous comment. Extending the lifetime of these variables by saving the pointers into local variables, that's fine; just make sure it's not conditional on -g. The only difference between -g and not -g should be metadata and dbg.*

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

probinson added a comment. This causes codegen to be different depending on whether debug-info is generated. Please don't do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141381/new/ https://reviews.llvm.org/D141381

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. One not-yet-asked question, does gcc produce the C++17/20 codes? If so, does fstrict-dwarf affect that? The major consumers of this would be lldb (which we control) and gdb, so following gcc's lead here would seem appropriate. I can accept that listing the codes on

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64e4d03c681a: [lit][AIX] Convert clang tests to use target={{.*}}-aix{{.*}} (authored by probinson). Changed prior to commit:

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

probinson added a comment. The clang-ppc64-aix bot ran with these changes here and all results are as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137437/new/

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson updated this revision to Diff 481421. probinson added a comment. Add trailing '{{.*}}' as requested. Have not changed the encoding.ll test, waiting on @uweigand about correct value to test in Python. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. In D139444#3978189 , @uweigand wrote: > In D139444#3975182 , @probinson > wrote: > >> The changes in this patch assume that there aren't any possible suffixes >> after the `-zos` part

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. I suppose we could temporarily add a test that does ; REQUIRES: target={{.*}}-zos ; RUN: %python -c 'import platform; print(platform.system())' && false and see what gets printed. Searching the buildbot console page for 'zos' turns up nothing; 's390' turns up

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson updated this revision to Diff 482180. probinson added a comment. Herald added a subscriber: delcypher. Define 'system-zos' and use it in the one test that needs it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 Files:

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. Thanks @Kai and @uweigand, good to know a z/OS bot is in the works. Hope this patch now meets your needs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139444/new/ https://reviews.llvm.org/D139444 ___ cfe-commits

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7793e676514b: [ZOS] Convert tests to check target={{.*}}-zos{{.*}} (authored by probinson). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson added a comment. The changes in this patch assume that there aren't any possible suffixes after the `-zos` part of the triple (no version numbers, like you might find with darwin or macos, and nothing like `-elf` or `-eabi` like some targets have). If there are suffixes, I'll

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. LGTM. I agree with the commentary in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 ___ cfe-commits mailing list

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

probinson created this revision. probinson added reviewers: uweigand, Kai. Herald added a project: All. probinson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Part of the project to eliminate special handling for

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. Oh, right, PS4 defaults to C99. It's okay with me if you make those two unsupported for PS4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > CHECK-LABEL doesn't have to match a line in the file uniquely. I mean, it's good practice if they do match uniquely; that way you don't get excessively confusing results when the output changes, and things start matching where you didn't expect. But it's not a

[PATCH] D138675: [flang] Add -ffast-math and -Ofast

probinson added a comment. See D139967 for why `UNSUPPORTED: powerpc` didn't work. That patch will put it back, and also update the lit config so the check will work now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139953: [llvm][DebugInfo] Backport DW_AT_default_value for template args

probinson added a comment. > IIUC the labels have to match a line in the file uniquely, which the DW_TAGs > wouldn't CHECK-LABEL doesn't have to match a line in the file uniquely. What happens is that all the -LABEL directives are processed first, in order, subdividing the input text into

[PATCH] D140332: [ADT] Alias llvm::Optional to std::optional

probinson added a comment. Herald added subscribers: jsetoain, JDevlieghere, ormris. Worth trying on MSVC, which is the other more likely place to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140332/new/ https://reviews.llvm.org/D140332

[PATCH] D138954: [PPC] Convert tests to check 'target='

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG948bb35d7474: [PPC] Convert tests to check target=triple (authored by probinson). Herald added a project: clang. Herald added a subscriber:

[PATCH] D138463: [windows-itanium] Propagate DLL storage class to Initialisation Guard Variables

probinson added a subscriber: cfe-commits. probinson added a comment. +cfe-commits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138463/new/ https://reviews.llvm.org/D138463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D138247: PR58819: Correct linkage and mangling of lambdas in inline static member initializers

probinson added a comment. If this is specifically for C++17, I believe Sony doesn't officially support that yet although I am checking. It looks like this is only part of the fix for #58819? The original report also had a `static int n` with an internal-linkage name. Repository: rG LLVM

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

probinson updated this revision to Diff 478382. probinson retitled this revision from "[lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'" to "[lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'". probinson added a comment. Be consistent about using `-aix` CHANGES

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. Hmmm I might be inclined to emit 17 and 20 only under not-strict-DWARF for v5, although it makes the logic more complicated. The codes have been allocated but AFAICT the website doesn't have the new codes listed (I looked at

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. In D138597#3957356 , @dblaikie wrote: > In D138597#3954269 , @probinson > wrote: > >> The codes have been allocated but AFAICT the website doesn't have the new >> codes listed (I

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. > They're published on the website too: https://dwarfstd.org/LanguagesV6.php (sigh) sorry, distracted by other things today. Yeah, using the v6 codes with the v6 attributes for the new ones WFM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}-aix{{.*}}'

probinson added a comment. Lacking an LGTM from someone with AIX knowledge, I see there's a bot "clang-ppc64-aix" where I can verify that the test results haven't changed. For this review the set of tests are mostly UNSUPPORTED, except for three XFAIL. I'll let this sit a little while in case

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

probinson added inline comments. Comment at: clang/test/ClangScanDeps/modules-no-undeclared-includes.c:3 // section in XCOFF yet. -// UNSUPPORTED: aix +// UNSUPPORTED: target={{.*}}aix{{.*}} hubert.reinterpretcast wrote: > Perhaps we should normalize on

[PATCH] D137287: [Test] Fix CHECK typo.

probinson added a comment. Nice work! have you verified that all the modified tests pass? naively it looks like you'd need at least 3 different targets to run them all (windows, webassembly, powerpc) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133998: [HIP][test] Avoid %T

probinson added a comment. I filed #58711 to get the test fixed; in the meantime, removed `clang-driver` and added `XFAIL: *` in rG7af01fe4 Repository: rG LLVM Github

[PATCH] D137437: [lit][AIX] Convert clang tests to use 'target={{.*}}aix{{.*}}'

probinson edited subscribers, added: cfe-commits; removed: clang. probinson added a comment. Try again to add the commits list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137437/new/ https://reviews.llvm.org/D137437 ___ cfe-commits

[PATCH] D137287: [Test] Fix CHECK typo.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM, but you'll want to be ready to jump on any bot failures. That's just the nature of these kinds of changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D131919: Move googletest to the third-party directory

probinson accepted this revision. probinson added a comment. Yes, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919 ___ cfe-commits mailing list

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

probinson added a comment. Is it possible you need to look only at the immediately preceding field, and not iterate? For example, struct zero_bitfield { char a : 8; char : 0; char b : 8; char c : 8; }; If processing `b` sees the zero-length bitfield and does the needful,

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

probinson added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1558 + EmitSeparator = FieldIt->isBitField(); + } + I might not be following this correctly, but it feels like EmitSeparator will end up true if the last field is a bitfield,

[PATCH] D145173: Make section attribute and -ffunction-sections play nicely

probinson abandoned this revision. probinson added a comment. I think the GC behavior with explicit section names is currently a little peculiar. For functions without a section name, -ffunction-sections allows GC to happen at the individual function level. With a section name, GC would happen

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

probinson added subscribers: wolfgangp, probinson. probinson added a comment. This is pretty different from the "always desugar to the canonical type" habit that has always been in place. Sony has done some downstream things to try to work around that in the past. @wolfgangp will remember it

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

probinson added a comment. Still one question, and haven't dug into the test in detail yet. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1552 + + auto *PreviousMDEntry = + PreviousFieldsDI.empty() ? nullptr : PreviousFieldsDI.back(); Maybe a comment

[PATCH] D146802: [Documentation] improved documentation of diagnostic messages by explaining thier syntax and test of clang by telling which subobject is uninitialized

probinson added a comment. You are combining documentation of the syntax for defining diagnostics, and changes to the content of certain diagnostics. The LLVM project wants to see one topic per patch, so these things need to be done separately. Also, the documentation probably does not want to

[PATCH] D144188: Tighten up a modules test

This revision was automatically updated to reflect the committed changes. Closed by commit rG17a90f1196c1: Tighten up a modules test (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144188/new/

[PATCH] D145173: Make section attribute and -ffunction-sections play nicely

probinson created this revision. probinson added a reviewer: MaskRay. Herald added a project: All. probinson requested review of this revision. People use -ffunction-sections to put each function into its own object-file section; this makes linker garbage-collection simpler. However, if there's

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson added a comment. See D145173 for a different tactic to solve this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143745/new/ https://reviews.llvm.org/D143745 ___ cfe-commits mailing list

[PATCH] D145271: [MSVC compatibility][DLLEXPORT/DLLIMPORT] Allow dllexport/dllimport for local classes

probinson added a subscriber: cfe-commits. probinson added a project: clang. probinson added a comment. I've looked at this but I'd like someone more in tune with MSVC behavior to review as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145271/new/

[PATCH] D144188: Tighten up a modules test

probinson created this revision. probinson added a reviewer: ChuanqiXu. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D144188 Files: clang/test/CXX/module/basic/basic.def.odr/p4.cppm Index: clang/test/CXX/module/basic/basic.def.odr/p4.cppm

[PATCH] D144188: Tighten up a modules test

probinson added a comment. I looked at this test only because it caused a merge conflict downstream. While it does work, it will not catch some kinds of mistakes; by being less specific in the "not" checks, it will catch more potential problems. Comment at:

[PATCH] D144586: [PS4/PS5] Specify no or

probinson created this revision. probinson added a reviewer: aaron.ballman. Herald added a project: All. probinson requested review of this revision. We've never provided these headers so set the preprocessor toggles to reflect that. https://reviews.llvm.org/D144586 Files:

[PATCH] D144586: [PS4/PS5] Specify no or

probinson added a comment. That's correct, I do see in our SDK. I don't see a need for a release note; we're not actually removing anything that we used to support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144586/new/ https://reviews.llvm.org/D144586

[PATCH] D144586: [PS4/PS5] Specify no or

This revision was automatically updated to reflect the committed changes. Closed by commit rG32d441bfb4f3: [PS4/PS5] Specify no complex.h or threads.h (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D148653 Files: clang/lib/Headers/mwaitxintrin.h clang/lib/Headers/pmmintrin.h Index:

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0905c567f0c7: [Headers][doc] Add FMA intrinsic descriptions (authored by probinson). Herald added a project: clang. Changed prior to commit:

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson added a comment. I chose to leave the "for each element" cases as-is, but I will keep your comments in mind as I go through other intrinsics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148021/new/ https://reviews.llvm.org/D148021

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D149205 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. probinson marked an inline comment as done. Closed by commit rG039ae62405b6: [Headers][doc] Add gather intrinsic descriptions to avx2intrin.h (authored by probinson).

[PATCH] D149205: [Headers][doc] Add "gather" intrinsic descriptions to avx2intrin.h

probinson marked 2 inline comments as done. probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:942 +/// +/// \code +/// FOR element := 0 to 1 pengfei wrote: > Use `\code{.operation}` please, the same below. Our internal tool will >

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

probinson added inline comments. Comment at: clang/lib/Headers/pmmintrin.h:278 ///the monitor event pending state. Data stored in the monitored address ///range causes the processor to exit the pending state. /// goldstein.w.n wrote: > interrupts too.

[PATCH] D148653: [Header][doc] Add/revise MONITOR/MWAIT[X] descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ddcef2ad3db: [Headers][doc] Add/revise MONITOR/MWAIT descriptions (authored by probinson). Herald added a project: clang. Repository: rG LLVM

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

probinson added subscribers: debug-info, probinson. probinson added a comment. I think we cannot be 100% sure about source paths in a cross-compile situation. Cross-compiling on platform A targeting platform B does not mean your sources and debugger UI are on platform B. My users keep source

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

probinson created this revision. probinson added reviewers: RKSimon, pengfei. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D147461 Files: clang/lib/Headers/immintrin.h Index: clang/lib/Headers/immintrin.h

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

probinson added a comment. FTR, I'll be working my way through a bunch of intrinsics over the next month or so, trying not to do too many at once. Mostly AVX2 but also some others. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147461/new/ https://reviews.llvm.org/D147461

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D148021 Files: clang/lib/Headers/fmaintrin.h Index: clang/lib/Headers/fmaintrin.h

[PATCH] D147256: [DebugInfo] Fix file path separator when targeting windows.

probinson added a comment. An LLVM code change should be testable on its own; this has it tested by Clang. I think you need a new command-line option to set TargetOptions::UseTargetPathSeparator e.g. via llvm-mc. Other TargetOptions are handled this way. Repository: rG LLVM Github Monorepo

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. One entirely optional suggestion on the test. LGTM. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1563 + + assert(PreviousBitfield->isBitField()); +

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

probinson added a comment. In D141824#4231372 , @probinson wrote: > In D141824#4229953 , @argentite > wrote: > >> Just to confirm, `UNSUPPORTED: target=x86_64-scei-ps4` should be enough, >> right? > >

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

probinson added a comment. In D141824#4229953 , @argentite wrote: > Just to confirm, `UNSUPPORTED: target=x86_64-scei-ps4` should be enough, > right? `UNSUPPORTED: target={{.*-(ps4|ps5)}}` please. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D147461: [Headers] Add some intrinsic function descriptions to immintrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa82170fa41ca: [Headers] Add some intrinsic function descriptions to immintrin.h. (authored by probinson). Herald added a project: clang. Changed

[PATCH] D148021: [Headers][doc] Add FMA intrinsic descriptions

probinson added inline comments. Comment at: clang/lib/Headers/fmaintrin.h:22 +/// Computes a multiply-add of 128-bit vectors of [4 x float]. +///For each element, computes (__A * __B) + __C . +/// pengfei wrote: > We are using a special format to

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson abandoned this revision. probinson added a comment. Discussion on the GCC bug has persuaded me this is not a good idea. I'll solve my user's problem a different way. @MaskRay you can close the GCC bug, it looks like I can't do it myself. CHANGES SINCE LAST ACTION

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson created this revision. probinson added reviewers: rjmccall, MaskRay. Herald added a project: All. probinson requested review of this revision. People use -ffunction-sections to put each function into its own object-file section; this makes linker garbage-collection simpler. However, if

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson added a comment. I'm not sure I understand the linker's mechanics here. Let me say some things and you can describe my misunderstanding. - If the linker was going to discard all of section foo (in the current scheme), that means it had no reason to retain either f() or g(). In the

[PATCH] D143745: Make section attribute and -ffunction-sections play nicely

probinson added a comment. This works in my simple test cases, but I'm not 100% sure it's (a) the best place to do this, or (b) the only place that needs to do this. Really we should guarantee that `comdat any` wins over `comdat nodeduplicate` in all cases. CHANGES SINCE LAST ACTION

[PATCH] D155081: Specify the developer policy around links to external resources

probinson added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:359 + If the patch fixes a bug in GitHub Issues, we encourage adding + "Fixes https://github.com/llvm/llvm-project/issues/12345; to automate closing + the issue in GitHub. If the patch has been

[PATCH] D155859: [Headers][doc] Add misc non-AVX2 intrinsic descriptions

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. Adds descriptions for adxintrin.h, bmi2intrin.h, clflushoptintrin.h, rdseedintrin.h, and xsavecintrin.h. Revises

[PATCH] D155861: [Headers][doc] Add SHA1/SHA256 intrinsic descriptions

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. I didn't include pseudo-code, because it would be long and complicated, probably not tell the whole story, and

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5399f1d7cab: [Headers][doc] Add shuffle-like intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang.

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. I'm traveling but will look at this on Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017 ___ cfe-commits mailing list

<    1   2   3   4   5   6   >