[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 525632. probinson added a comment. Correct order of horizontal operands CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150114/new/ https://reviews.llvm.org/D150114 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:456 +/// j := i*128 +/// result[j+31:j] := __a[j+63:j+32] - __a[j+31:j] +/// result[j+63:j+32] := __a[j+127:j+96] - __a[j+95:j+64] craig.topper wrote: > Intel intrinsics guide says

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. Oh, `-fstandalone-debug` should override this? In the Sony implementation, it does. (Sorry for not remembering that sooner.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. I have to say I'm not super excited about "-gincomplete-types" given that "incomplete type" means something different to a C++ user. "-gdefined-methods-only" ? reads awkwardly in the no- form. "-gsuppress-undefined-methods" ? which is similar to what we called it.

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. My debugger guy says "this shouldn't be a problem." Given that, my request is that `-gincomplete-types` should be default-true for `DebuggerTuning == SCE` if you want to commit this; otherwise I'll redo our downstream patch to match yours. Repository: rG LLVM

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. I experimented with this. Looks like it emits info only for //defined// methods, and not //used// methods. That is, if you change the test to say `void t1::f1() { f2(); }` you get DWARF for f1 but not f2. The way Sony does it, you get DWARF for f1 and f2. (Neither

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. Could always go with `-gsuppress-undefined-methods` if you're not happy about default-on options. I don't have a strong opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152017/new/ https://reviews.llvm.org/D152017

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:156 +///A 256-bit vector containing one of the source operands. +/// \returns A 256-bit vector containing the sums. static __inline__ __m256i __DEFAULT_FN_ATTRS256 craig.topper

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 524786. probinson added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150114/new/ https://reviews.llvm.org/D150114 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson marked an inline comment as done. probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:412 +///vectors of [16 x i16] and returns the lower 16 bits of each difference +///in an element of the [16 x i16] result (overflow is ignored). +///

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. probinson marked an inline comment as done. Closed by commit rGd8291908ef49: [Headers][doc] Add add/sub/mul intrinsic descriptions to avx2intrin.h (authored by

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: RKSimon, pengfei, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. (Time to look for the next round of embarrassing mistakes...) https://reviews.llvm.org/D151749 Files:

[PATCH] D151749: [Headers][doc] Add "shuffle-like" intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 526782. probinson added a comment. Update some SATURATEx to SATURATExU CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151749/new/ https://reviews.llvm.org/D151749 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. In D152017#4397113 , @dblaikie wrote: > What's the particular goal/value in including called-but-not-defined > functions? Are your users generally building only parts of their program with > debug info & you want it to be

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson added a comment. The CU's DIFile is conjured up in CGDebugInfo::CreateCompileUnit(), and the name is derived from `-main-file-name` rather than anything SourceManager provides. Although there is a comment wondering about that. CreateCompileUnit() computes a checksum for that DIFile,

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson updated this revision to Diff 546115. probinson added a comment. Use the main FileID instead of expensive string compares. Figured this out after staring at CreateCompileUnit for long enough. Seeding the DIFileCache with the DIFile created there made another test unhappy

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson added a comment. Of course this means we're rerunning MD5 on the main source file; probably can capture that from TheCU and save that cost as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156571/new/ https://reviews.llvm.org/D156571

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

probinson added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; Would you mind changing this cast from `uint8_t` to

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson updated this revision to Diff 546144. probinson added a comment. Reuse the main file's checksum instead of recalculating it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156571/new/ https://reviews.llvm.org/D156571 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D156248: [Headers][doc] Add description of _mm256_movemask_epi8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fde372b3200: [Headers][doc] Add description of _mm256_movemask_epi8 (authored by probinson). Herald added a project: clang. Repository: rG LLVM

[PATCH] D156248: [Headers][doc] Add description of _mm256_movemask_epi8

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. (Missed one from the list of functions I was asked to document. This really should be the last review!)

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

probinson added a comment. In D155539#4524543 , @yaxunl wrote: > In D155539#4524189 , @probinson > wrote: > >> This change to lang-std.cpp causes it not to verify _which_ language >> standard is the default. It

[PATCH] D155991: [DWARF] Make sure file entry for artificial functions has an MD5 checksum

probinson added a comment. See https://reviews.llvm.org/D156571 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155991/new/ https://reviews.llvm.org/D155991 ___ cfe-commits mailing list

[PATCH] D155991: [DWARF] Make sure file entry for artificial functions has an MD5 checksum

probinson added a comment. > Any memory usage measurements to check this doesn't have a significant > adverse impact by copying all the strings? Not actual measurements, no; but intuitively the size should not be much greater than the size of the filename entries in the .debug_line section for

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson created this revision. probinson added reviewers: dblaikie, nikic. probinson added a project: debug-info. Herald added a subscriber: StephenFan. Herald added a project: All. probinson requested review of this revision. Should have lower memory and time cost than D155991

[PATCH] D155859: [Headers][doc] Add misc non-AVX2 intrinsic descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69593aa5c054: [Headers][doc] Add misc non-AVX2 intrinsic descriptions (authored by probinson). Herald added a project: clang. Repository: rG LLVM

[PATCH] D155991: [DWARF] Make sure file entry for artificial functions has an MD5 checksum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7abb5fc618ce: [DWARF] Make sure file entry for artificial functions has an MD5 checksum (authored by probinson). Herald added a project: clang.

[PATCH] D156143: Add Adrian and David as owners for debug info

probinson accepted this revision. probinson added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156143/new/ https://reviews.llvm.org/D156143 ___ cfe-commits mailing list

[PATCH] D156127: Partially revert changes to test lang-std.cpp

probinson added inline comments. Comment at: clang/test/Preprocessor/lang-std.cpp:4 // RUN: %clang_cc1 -dM -E %s | grep __cplusplus >%T-cpp-std.txt +// RUN: cat %T-cpp-std.txt | FileCheck --check-prefix=CXX17 %s + Use `--input-file` and there's one fewer

[PATCH] D156127: Partially revert changes to test lang-std.cpp

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156127/new/ https://reviews.llvm.org/D156127 ___ cfe-commits mailing list

[PATCH] D155998: Set default C++ level for Playstation(r) to C++17.

probinson added a comment. The value of a separate test for PS4/PS5 is questionable, now that it's the same as the general Clang default. Probably better to delete `lang-std-sie.cpp` and remove the UNSUPPORTED from `lang-std.cpp` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

probinson added a comment. This change to lang-std.cpp causes it not to verify _which_ language standard is the default. It only verifies that cuda and hip don't _change_ it. If you run FileCheck on one of those output files, it would preserve that property. Repository: rG LLVM Github

[PATCH] D155861: [Headers][doc] Add SHA1/SHA256 intrinsic descriptions

probinson added a comment. Thanks! The pre-merge check caught mistakes in the \param commands, which I fixed before pushing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155861/new/ https://reviews.llvm.org/D155861 ___ cfe-commits mailing

[PATCH] D155859: [Headers][doc] Add misc non-AVX2 intrinsic descriptions

probinson added inline comments. Comment at: clang/lib/Headers/rdseedintrin.h:56 +/// ELSE +/// Store16(__p, 0) +/// result := 0 pengfei wrote: > 32 Oops. Fixed. Comment at: clang/lib/Headers/rdseedintrin.h:84 +/// ELSE +/// Store16(__p,

[PATCH] D155998: Set default C++ level for PlayStation(r) to C++17.

probinson added a comment. (Also remove the now-incorrect comment from lang-std.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155998/new/ https://reviews.llvm.org/D155998 ___ cfe-commits mailing

[PATCH] D155998: Set default C++ level for PlayStation(r) to C++17.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. Huh. It looks like someone else removed that stuff from lang-std.cpp recently. I'd have thought that would cause a failure on our bot, but whatever. LGTM. CHANGES SINCE LAST ACTION

[PATCH] D155859: [Headers][doc] Add misc non-AVX2 intrinsic descriptions

probinson updated this revision to Diff 543075. probinson marked 4 inline comments as done. probinson added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155859/new/ https://reviews.llvm.org/D155859 Files: clang/lib/Headers/adxintrin.h

[PATCH] D155991: [DWARF] Make sure file entry for artificial functions has an MD5 checksum

probinson created this revision. probinson added reviewers: dblaikie, aprantl. probinson added a project: debug-info. Herald added a project: All. probinson requested review of this revision. The DIFile cache was keyed on a string pointer instead of string content, which was causing misses and

[PATCH] D155991: [DWARF] Make sure file entry for artificial functions has an MD5 checksum

probinson added a comment. The fix is straightforward but the test was surprisingly tricky; I had to add the -main-file-name option to keep one of the DIFile's from ending up as ``. I'm still befuddled about why there are two DIFile entries, when the DIFileCache clearly has only one. The

[PATCH] D155861: [Headers][doc] Add SHA1/SHA256 intrinsic descriptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG775d6df6a5f2: [Headers][doc] Add SHA1/SHA256 intrinsic descriptions (authored by probinson). Herald added a project: clang. Changed prior to

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

probinson added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; aaron.ballman wrote: > tbaeder wrote: > > probinson

[PATCH] D153462: [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D153462 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D153462: [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfa467bdc0e9: [Headers][doc] Add various arith/logical intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D153576: [Headers] Fix up some conditionals

probinson closed this revision. probinson added a comment. Committed [[here|https://github.com/llvm/llvm-project/commit/3db8410487ce704f02ef8a175e87295d4e86c8df]] and closing manually because I forgot to put the review link in the commit message. CHANGES SINCE LAST ACTION

[PATCH] D153576: [Headers] Fix up some conditionals

probinson added a comment. The Intel documentation doesn't hint that `_mulx_32` isn't available in 64-bit mode. I'm guessing gcc messed up and we copied them. CHANGES SINCE LAST

[PATCH] D153576: [Headers] Fix up some conditionals

probinson created this revision. probinson added reviewers: craig.topper, RKSimon, pengfei, goldstein.w.n. Herald added a project: All. probinson requested review of this revision. While looking at adding intrinsic function descriptions, I found some oddities in the conditionals. I've fiddled

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added a subscriber: cfe-commits. probinson added a comment. + cfe-commits which didn't get added automatically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153993/new/ https://reviews.llvm.org/D153993 ___ cfe-commits mailing list

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE pengfei wrote: > A more intrinsic guide format is `MEM[__X+j:j]` LoadXX is the syntax in the gather

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson updated this revision to Diff 535804. probinson added a comment. s/:7/:j/ correcting bit references. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153993/new/ https://reviews.llvm.org/D153993 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE pengfei wrote: > probinson wrote: > > pengfei wrote: > > > A more intrinsic guide format is

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added inline comments. Comment at: clang/lib/Headers/avx2intrin.h:3474 +/// IF __M[j+31] == 1 +/// result[j+31:j] := Load32(__X+(i*4)) +/// ELSE pengfei wrote: > probinson wrote: > > pengfei wrote: > > > probinson wrote: > > > > pengfei wrote:

[PATCH] D152017: [DebugInfo] Add flag to only emit referenced member functions

probinson added a comment. > we might emit member function declarations for call sites in DWARF, for > instance So are you now leaning more toward wanting to emit the "used" declarations as well? I'm sure you don't want to implement it the way we did... I *think* the template parameter thing

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1461fabfb141: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang.

[PATCH] D153993: [Headers][doc] Add load/store/cmp/cvt intrinsic descriptions to avx2intrin.h

probinson added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153993/new/ https://reviews.llvm.org/D153993 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D153681: [X86] Move back _mulx_u32 to 32-bit only

probinson added a comment. I'm okay with putting this back if the codegen (D153620 ) can't be resolved. Honestly I didn't think it was a problem. But I think Craig or Simon should sign off. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D150114 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

probinson created this revision. probinson added reviewers: pengfei, RKSimon, goldstein.w.n, craig.topper. Herald added a project: All. probinson requested review of this revision. https://reviews.llvm.org/D150278 Files: clang/lib/Headers/avx2intrin.h Index: clang/lib/Headers/avx2intrin.h

[PATCH] D150278: [Headers][doc] Add "shift" intrinsic descriptions to avx2intrin.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG642bd1123d05: [Headers][doc] Add shift intrinsic descriptions to avx2intrin.h (authored by probinson). Herald added a project: clang. Repository:

<    1   2   3   4   5   6