https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision
https://github.com/pogo59 commented:
Nice to see the LLVM intrusion into googletest proper is very minimized!
IME, testing on Linux with both gcc and clang as build compilers is very
helpful. With Windows/MSVC that covers the three main cases.
https://github.com/llvm/llvm-project/pull/65823
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
,
static unsigned getOptimizationLevel(ArgList , InputKind IK,
DiagnosticsEngine ) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned DefaultOpt = 0;
if
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
,
static unsigned getOptimizationLevel(ArgList , InputKind IK,
DiagnosticsEngine ) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned DefaultOpt = 0;
if
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 opened https://github.com/llvm/llvm-project/pull/65185
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
I'm happy with this, the bots will catch any environmental issues that you
haven't found yet. LGTM.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/65485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to
use on Windows. (When I install Visual Studio, it creates a widget that brings
up a `cmd` shell with the right environment. I'm not aware of a similar widget
for PowerShell.) While I rarely try to
pogo59 wrote:
I have no stake in Apple/Swift, but for myself, `cmd` is the natural shell to
use on Windows. (When I install Visual Studio, it creates a widget that brings
up a `cmd` shell with the right environment. I'm not aware of a similar widget
for PowerShell.) While I rarely try to
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
,
static unsigned getOptimizationLevel(ArgList , InputKind IK,
DiagnosticsEngine ) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned DefaultOpt = 0;
if
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/65485:
The test was looking only for the bitcode writer pass; it should check the full
pipeline to make sure the choice is as intended.
>From 6f5968e8e17ac4faae27bcaf2132a0df439f4c0f Mon Sep 17 00:00:00 2001
From:
https://github.com/pogo59 review_requested
https://github.com/llvm/llvm-project/pull/65485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
This came up because Sony makes slightly different choices downstream, and we
didn't get it exactly right in all cases.
https://github.com/llvm/llvm-project/pull/65485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/70481
Our doc tooling complained about this missing directive.
>From a6bcb7b93d3d856a367b40b08a42c641c87217f3 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Fri, 27 Oct 2023 10:00:00 -0700
Subject: [PATCH]
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/70481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
If you want to XFAIL specifically for the Sony targets, what you suggested
would work.
I'm unclear about the "MSVC C++ ABI" aspect, but if that gets the test to work,
go for it.
https://github.com/llvm/llvm-project/pull/70991
___
pogo59 wrote:
FTR, the "Worker" tab on that buildbot page will point you to the maintainer.
But tagging me is also fine in general.
I'm unable to repro the problem locally because my local build doesn't seem to
include clang-repl.exe, so the whole clang/test/Interpreter directory is
@@ -2325,6 +2325,7 @@ void
CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D,
B.addAttribute(llvm::Attribute::Naked);
// OptimizeNone wins over OptimizeForSize and MinSize.
+F->removeFnAttr(llvm::Attribute::OptimizeForDebugging);
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/67684
This option will cause -E to preserve the #include directives
for system headers, rather than expanding them into the output.
This can greatly reduce the volume of preprocessed source text
in a test case, making
@@ -98,7 +98,7 @@
// == file2.h
// REWRITE: #if 0
// REWRITE: #include "file2.h"
-// REWRITE: #endif
+// REWRITE: #else /* file2.h expanded
pogo59 wrote:
Yes it does, but the point here is simply to identify that this is the correct
`#else`. The Preprocessor
@@ -332,12 +346,14 @@ void InclusionRewriter::CommentOutDirective(Lexer
,
// OutputContentUpTo() would not output anything anyway.
return;
}
- OS << "#if 0 /* expanded by -frewrite-includes */" << MainEOL;
+ OS << "#if 0 /* " << getIncludedFileName(Inc)
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/67613
Also add the filename to the comments it emits, to help identify where included
text ends.
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023
pogo59 wrote:
Are there interactions between `optdebug` and other attributes that should be
enforced by the verifier? Like, can't be mixed with `optnone`?
https://github.com/llvm/llvm-project/pull/66632
___
cfe-commits mailing list
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/4] Make -frewrite-includes put an endif at the end of the
pogo59 wrote:
> The first link does, somewhat, and seems like the right place to add this new
> option. I'll have a go at that.
Well, that one appears to be generated from the Options.td file, and simply
includes the help text, so in effect I've already done that. :)
UsersManual.html doesn't
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/4] [NFC] Change a reference member to pointer
This will allow
pogo59 wrote:
Also added a release note.
https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/2] Make -frewrite-includes put an endif at the end of the
@@ -332,12 +346,14 @@ void InclusionRewriter::CommentOutDirective(Lexer
,
// OutputContentUpTo() would not output anything anyway.
return;
}
- OS << "#if 0 /* expanded by -frewrite-includes */" << MainEOL;
+ OS << "#if 0 /* " << getIncludedFileName(Inc)
pogo59 wrote:
Toggles done. Also got rid of some of the extra whitespace changes in the
output.
https://github.com/llvm/llvm-project/pull/67613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pogo59 wrote:
@jrtc27 I've beefed up the help text some. I'm unable to find any "rendered
documentation" for `-E` and friends; if you can point me to it, I'd be happy to
add the new option there.
https://github.com/llvm/llvm-project/pull/67684
___
pogo59 wrote:
Aha! Thank you. I should have found that third one in my searches, although it
doesn't really describe the options that affect `-E` mode. The first link does,
somewhat, and seems like the right place to add this new option. I'll have a go
at that.
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/3] Make -frewrite-includes put an endif at the end of the
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/3] [NFC] Change a reference member to pointer
This will allow
pogo59 wrote:
Many of the clang-format complaints on this one are from the first commit,
which I wanted to make as minimalist as possible. I believe I didn't make the
file any _less_ conformant in that commit. :) I will fix the others.
https://github.com/llvm/llvm-project/pull/67684
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/6] Make -frewrite-includes put an endif at the end of the
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Ping
https://github.com/llvm/llvm-project/pull/67613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67613
>From 0f63068d1085e5064d47916a86fac089c4417e57 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 14:54:13 -0700
Subject: [PATCH 1/5] Make -frewrite-includes put an endif at the end of the
pogo59 wrote:
Ping @erichkeane were you willing to approve both this and #67613?
https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Something got screwed up when I tried to squash all but the first commit
together. I put it back together manually. The NFC commit was pushed as
9500616, the functional stuff squashed and committed as 71d83bb.
https://github.com/llvm/llvm-project/pull/67684
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/67684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Something got screwed up when I tried to squash all but the first commit
together. I put it back together manually. The NFC commit was pushed as
9500616, the functional stuff squashed and committed as 71d83bb.
https://github.com/llvm/llvm-project/pull/67684
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/5] [NFC] Change a reference member to pointer
This will allow
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/5] [NFC] Change a reference member to pointer
This will allow
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/67684
>From 2a0dd575dbbcf80d1cd264d6dbc8de8fa897 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 27 Sep 2023 15:30:52 -0700
Subject: [PATCH 1/5] [NFC] Change a reference member to pointer
This will allow
pogo59 wrote:
In general, you cannot combine suffixes in the same directive. FileCheck will
detect and complain about some combinations, but it doesn't detect all of them.
I believe `CHECK-DAG-SAME` does not work the way you want it to, and in fact
acts as a no-op. This would be easy to
pogo59 wrote:
> Does this issue not apply to other platforms?
There is a deliberate layout/ABI choice that MSVC made ages ago and will never
change. It will only pack bitfields into the same word if the neighboring
bitfield declarations have the same base type. This is relatively well known.
pogo59 wrote:
I note that these macros are just name substitutions, unlike the function-style
macros in ia32intrin.h. I didn't change the definitions.
https://github.com/llvm/llvm-project/pull/79048
___
cfe-commits mailing list
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/79048
These are largely copy-pasted from the corresponding function descriptions.
Added \see cross-references. Also changed tags to \c.
>From 5a3f36a9276e0919d72cb48a7d30c2951b542c79 Mon Sep 17 00:00:00 2001
From:
@@ -3379,6 +3379,54 @@ Query for this feature with
``__has_builtin(__builtin_debugtrap)``.
Query for this feature with ``__has_builtin(__builtin_trap)``.
+``__builtin_verbose_trap``
+--
+
+``__builtin_verbose_trap`` causes the program to stop its
@@ -3379,6 +3379,54 @@ Query for this feature with
``__has_builtin(__builtin_debugtrap)``.
Query for this feature with ``__has_builtin(__builtin_trap)``.
+``__builtin_verbose_trap``
+--
+
+``__builtin_verbose_trap`` causes the program to stop its
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/79230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 commented:
The documentation should say that this works only when debug information is
enabled.
https://github.com/llvm/llvm-project/pull/79230
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -3379,6 +3379,54 @@ Query for this feature with
``__has_builtin(__builtin_debugtrap)``.
Query for this feature with ``__has_builtin(__builtin_trap)``.
+``__builtin_verbose_trap``
+--
+
+``__builtin_verbose_trap`` causes the program to stop its
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/82422
In Sony's document processing, the first "paragraph" of the description is
copied to a Brief Description section. Add paragraph breaks to make those brief
descriptions less verbose.
In fmaintrin.h we were
pogo59 wrote:
@cflores this is the upstream review I mentioned
https://github.com/llvm/llvm-project/pull/82422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2099,9 +2099,11 @@ static __inline__ __m128i __DEFAULT_FN_ATTRS
_mm_add_epi64(__m128i __a,
}
/// Adds, with saturation, the corresponding elements of two 128-bit
-///signed [16 x i8] vectors, saving each sum in the corresponding element
of
-///a 128-bit result
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/80490
>From c068144b1e372aec29f268edf7184ee3d3dc7d54 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Fri, 2 Feb 2024 12:38:16 -0800
Subject: [PATCH 1/2] [Headers][X86] Editorial fixes to ia32intrin.h
descriptions
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/80490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
>From a UI perspective, "add a visibility attribute" doesn't seem all that
>descriptive. What visibility does it add? Therefore, I suggest
>`-fvisibility-global-new-delete[=]` so the user can ask for what
>they want, and `-fvisibility-global-new-delete-hidden` equals
pogo59 wrote:
Ben and I talked about this offline. I was a little skittish about these
power-user options letting you do whatever you wanted, and maybe a small number
(2? 3?) of predefined combinations would be more straightforward. He convinced
me that (a) these wouldn't be needed often, and
pogo59 wrote:
Thanks for adding the guard to the include adxintrin.h, now that it has only
the ADX stuff it is the right way to go. As PS4 code owner I approve!
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
pogo59 wrote:
Actually I kind of prefer all these options to have `-fvisibility-` as a
prefix. Even if it doesn't read quite naturally, it strongly implies that the
options are related (which is true) and any lexically sorted list of options
will naturally group them together. WDYT @frobtech
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/77525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/77686
ia32intrin.h gets descriptions for all remaining non-privileged intrinsic
functions; the macros providing alternate names are not described. immintrin.h
ditto, except for the InterlockedExchange functions.
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/77686
>From 39a884d27f56772a222d352665be95194716beff Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Wed, 10 Jan 2024 10:42:24 -0800
Subject: [PATCH 1/2] [Headers][X86] Add more descriptions to ia32intrin.h and
@@ -173,25 +183,59 @@ __popcntq(unsigned long long __A)
#endif /* __x86_64__ */
#ifdef __x86_64__
+/// Returns the program status and control \c RFLAGS register with the \c VM
+///and \c RF flags cleared.
+///
+/// \headerfile
+///
+/// This intrinsic corresponds to the
@@ -361,42 +425,146 @@ _wbinvd(void) {
__builtin_ia32_wbinvd();
}
+/// Rotates an 8-bit value to the left by the specified number of bits.
+///This operation is undefined if the number of bits exceeds the size of
+///the value.
+///
+/// \headerfile
+///
+/// This
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/77686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
I think "pure virtual" is a more common phrasing than "virtual pure" so maybe
`isPureVirtual` instead? Up to Aaron, though.
https://github.com/llvm/llvm-project/pull/78463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/78613
These are largely copy-pasted from the corresponding function descriptions.
Updated _rdtsc definition because it was just plain wrong.
>From e4c9272ee9cbb918347a23d2dce14c9c12765009 Mon Sep 17 00:00:00 2001
pogo59 wrote:
Reviewer questions:
1. When a macro is merely an alternate name for an intrinsic function, does it
want to be documented as its own intrinsic function? I assume yes in this
patch, but if there's a different tactic that avoids duplicating a bunch of
descriptions, I'm open to
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/78613
>From e4c9272ee9cbb918347a23d2dce14c9c12765009 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Thu, 18 Jan 2024 10:50:21 -0800
Subject: [PATCH 1/2] [Headers][X86] Add macro descriptions to ia32intrin.h
These
pogo59 wrote:
> When a macro is merely an alternate name for an intrinsic function, does it
> want to be documented as its own intrinsic function? I assume yes in this
> patch, but if there's a different tactic that avoids duplicating a bunch of
> descriptions, I'm open to suggestions.
I
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/77525
Doxygen comment style for every other intrinsic-function header uses ///
comments, so change ia32intrin.h from the /** style to /// style. While I was
in there, change ` INSTR ` to `\c INSTR` and toss in a few
pogo59 wrote:
I'm going to be adding some new function descriptions to this file shortly, and
figured I should get the formatting thing out of the way first.
https://github.com/llvm/llvm-project/pull/77525
___
cfe-commits mailing list
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/77525
>From cd91a7f0e5cacb682cb6280655a8d1112cecaf6a Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Tue, 9 Jan 2024 13:22:36 -0800
Subject: [PATCH 1/2] [Headers][X86] Reformat ia32intrin.h doc to match the
other
pogo59 wrote:
> Edit: Actually we still have the problem of when in LLVM not knowing if
> optimze-by-size got set on the cold funtion by it being cold or if Os was
> used.
Not sure I understand the question (sorry I missed this comment when it was
made). The suggestion is that for our
pogo59 wrote:
> I do wonder how feasible it would be for the downstream tests to be adjusted
> to look at the `DW_AT_location`..
As I mentioned on the other thread, the point is not to have to read the value
from the process-under-debug. This is not efficient in a remote-debugging
scenario.
pogo59 wrote:
Tag @cflores as well,
https://github.com/llvm/llvm-project/pull/80490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/80490
Use indicative not imperative; fix missing capitalization; spell out some
abbreviations; "time-stamp" not "time stamp".
>From c068144b1e372aec29f268edf7184ee3d3dc7d54 Mon Sep 17 00:00:00 2001
From: Paul Robinson
@@ -1,7 +1,7 @@
// RUN: %clang -x c -ffixed-point -S -emit-llvm -o - %s | FileCheck %s
-// RUN: %clang -x c -ffixed-point -S -emit-llvm -o -
--target=x86_64-scei-ps4-ubuntu-fast %s | FileCheck %s
pogo59 wrote:
Thanks for tagging me. These are definitely
@@ -411,13 +497,45 @@ __rdpmc(int __A) {
/// \param __A
///Address of where to store the 32-bit \c IA32_TSC_AUX value.
/// \returns The 64-bit value of the time stamp counter.
+/// \see _rdtsc
static __inline__ unsigned long long __DEFAULT_FN_ATTRS
__rdtscp(unsigned int
https://github.com/pogo59 updated
https://github.com/llvm/llvm-project/pull/78613
>From e4c9272ee9cbb918347a23d2dce14c9c12765009 Mon Sep 17 00:00:00 2001
From: Paul Robinson
Date: Thu, 18 Jan 2024 10:50:21 -0800
Subject: [PATCH 1/3] [Headers][X86] Add macro descriptions to ia32intrin.h
These
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/75364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -359,6 +359,12 @@ void toolchains::PS4PS5Base::addClangTargetOptions(
CC1Args.push_back("-fno-use-init-array");
+ // Default to -fglobal-new-delete-visibility=source for PS5.
pogo59 wrote:
Spelling in comment needs to match the option spelling.
https://github.com/pogo59 commented:
I'm okay with the PS5-specific bits. Other people should have a chance to chime
in so I won't mark it approved.
https://github.com/llvm/llvm-project/pull/75364
___
cfe-commits mailing list
https://github.com/pogo59 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/74629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 221 matches
Mail list logo
