szepet updated this revision to Diff 65310.
szepet added a comment.
full diff submitted
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/EnumMisuseCheck.cpp
clang-tidy/misc/EnumMisuseCheck.h
clang-tidy/misc/MiscTidyModule.cpp
szepet removed rL LLVM as the repository for this revision.
szepet updated this revision to Diff 64897.
szepet added a comment.
updating patch based on review comments
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/EnumMisuseCheck.cpp
clang-tidy/misc/EnumMisuseCheck.h
szepet marked 18 inline comments as done.
szepet added a comment.
https://reviews.llvm.org/D22507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szepet marked an inline comment as done.
szepet added a comment.
https://reviews.llvm.org/D22507
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szepet updated this revision to Diff 65966.
szepet marked 12 inline comments as done.
szepet added a comment.
updates based on comments, counter and search functions replaced by std
functions
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/CMakeLists.txt
szepet updated this revision to Diff 70324.
szepet marked 4 inline comments as done.
szepet added a comment.
cast to dyn-cast change in order to fix a bug, changes based on comments
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/EnumMisuseCheck.cpp
szepet added inline comments.
Comment at: test/clang-tidy/misc-enum-misuse.cpp:3
@@ +2,3 @@
+
+enum Empty {
+};
Could you specify which part of the file seems off? I have run the clang format
with the same options on testfiles as on the others.
szepet updated this revision to Diff 70017.
szepet marked 11 inline comments as done.
szepet added a comment.
Changes based on comments, fix a cast to dyn_cast bug, description updated
(hopefully it became more clear).
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/CMakeLists.txt
szepet updated this revision to Diff 73439.
szepet marked an inline comment as done.
szepet added a comment.
Herald added a subscriber: modocache.
Note message checks added to testfiles.
https://reviews.llvm.org/D22507
Files:
clang-tidy/misc/CMakeLists.txt
szepet abandoned this revision.
szepet added a comment.
At first I was not able to reproduce it. Then I realized it was my foul because
I used the analyzer without the core checkers in this case. Sorry for the false
positive.
https://reviews.llvm.org/D23853
szepet updated the summary for this revision.
szepet updated this revision to Diff 71925.
szepet marked 7 inline comments as done.
szepet added a comment.
Herald added subscribers: mgorny, beanz.
In order to decrease false positive rate, the bitmask specific checker part
investigate only the
szepet added inline comments.
> alexfh wrote in SuspiciousEnumUsageCheck.cpp:155
> Why?
Because the hasDisjointValueRange function could not decide the values
properly. So in case of an empty Enum it would not make sense. Fortunately we
know that the empty case should not be reported so used
szepet updated this revision to Diff 73157.
szepet marked 13 inline comments as done.
szepet added a comment.
Updates based on comments (the testfile note comments will be added in the next
commit)
Some changes in the algorithm/design:
In non-strict mode the checker will only investigate the
Author: szepet
Date: Thu Jul 20 00:35:11 2017
New Revision: 308592
URL: http://llvm.org/viewvc/llvm-project?rev=308592=rev
Log:
Revert "[StaticAnalyzer] Completely unrolling specific loops with known bound
option"
Revert r308561 and r308558.
Clang-ppc64be-linux seems to crash while running the
Author: szepet
Date: Tue Jul 25 16:49:16 2017
New Revision: 309061
URL: http://llvm.org/viewvc/llvm-project?rev=309061=rev
Log:
[StaticAnalyzer] LoopUnrolling - Attempt #2 to fix a crash in r309006.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/LoopUnrolling.cpp
Modified:
Author: szepet
Date: Tue Jul 25 12:23:23 2017
New Revision: 309006
URL: http://llvm.org/viewvc/llvm-project?rev=309006=rev
Log:
[StaticAnalyzer] Completely unrolling specific loops with known bound option
This feature allows the analyzer to consider loops to completely unroll.
New
Author: szepet
Date: Tue Jul 25 14:54:58 2017
New Revision: 309036
URL: http://llvm.org/viewvc/llvm-project?rev=309036=rev
Log:
[StaticAnalyzer] LoopUnrolling - Attempt to fix a crash in r309006.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/LoopUnrolling.cpp
Modified:
Author: szepet
Date: Wed Jul 19 16:50:00 2017
New Revision: 308558
URL: http://llvm.org/viewvc/llvm-project?rev=308558=rev
Log:
This feature allows the analyzer to consider loops to completely unroll. New
requirements/rules (for unrolling) can be added easily via ASTMatchers.
The current
Author: szepet
Date: Wed Jul 19 17:05:25 2017
New Revision: 308561
URL: http://llvm.org/viewvc/llvm-project?rev=308561=rev
Log:
[StaticAnalyzer] Completely unrolling specific loops with known bound option
Missing files added to rL308558.
Added:
Author: szepet
Date: Sat Aug 19 03:24:52 2017
New Revision: 311234
URL: http://llvm.org/viewvc/llvm-project?rev=311234=rev
Log:
[StaticAnalyzer] LoopUnrolling: Exclude cases where the counter is escaped
before the loop
Adding escape check for the counter variable of the loop.
It is achieved by
Author: szepet
Date: Sat Aug 19 04:19:16 2017
New Revision: 311235
URL: http://llvm.org/viewvc/llvm-project?rev=311235=rev
Log:
[CFG] Add LoopExit information to CFG
This patch introduces a new CFG element CFGLoopExit that indicate when a loop
ends. It does not deal with returnStmts yet (left it
Author: szepet
Date: Tue May 16 06:54:00 2017
New Revision: 303158
URL: http://llvm.org/viewvc/llvm-project?rev=303158=rev
Log:
[StaticAnalyzer] Move inline counter increaser to inlineCall function
Even though the shouldInlineCall function returns true, it can happen that the
function is not
Author: szepet
Date: Tue Sep 12 02:40:13 2017
New Revision: 313016
URL: http://llvm.org/viewvc/llvm-project?rev=313016=rev
Log:
[clang-tidy] SuspiciousEnumUsageCheck bugfix
iThere is a reported bug on the checker not handling the some APSInt values
correctly:
Author: szepet
Date: Mon Aug 28 03:21:24 2017
New Revision: 311880
URL: http://llvm.org/viewvc/llvm-project?rev=311880=rev
Log:
[StaticAnalyzer] LoopUnrolling fixes
1. The LoopUnrolling feature needs the LoopExit included in the CFG so added
this
dependency via the config options
2. The
Author: szepet
Date: Mon Aug 28 03:34:50 2017
New Revision: 311881
URL: http://llvm.org/viewvc/llvm-project?rev=311881=rev
Log:
[StaticAnalyzer] LoopUnrolling: Excluding loops which splits the state
Added check if the execution of the last step of the given unrolled loop has
generated more
Author: szepet
Date: Mon Aug 28 03:50:28 2017
New Revision: 311883
URL: http://llvm.org/viewvc/llvm-project?rev=311883=rev
Log:
[StaticAnalyzer] LoopUnrolling: Keep track the maximum number of steps for each
loop
This way the unrolling can be restricted for loops which will take at most a
given
Author: szepet
Date: Mon Aug 21 09:10:19 2017
New Revision: 311344
URL: http://llvm.org/viewvc/llvm-project?rev=311344=rev
Log:
[StaticAnalyzer] Handle LoopExit CFGElement in the analyzer
This patch adds handling of the LoopExit CFGElements to the StaticAnalyzer.
This is reached by introducing a
Author: szepet
Date: Mon Aug 21 09:32:57 2017
New Revision: 311346
URL: http://llvm.org/viewvc/llvm-project?rev=311346=rev
Log:
[StaticAnalyzer] LoopUnrolling: Track a LoopStack in order to completely unroll
specific loops
The LoopExit CFG information provides the opportunity to not mark the
Author: szepet
Date: Sat Oct 28 16:24:00 2017
New Revision: 316852
URL: http://llvm.org/viewvc/llvm-project?rev=316852=rev
Log:
[analyzer] MisusedMovedObjectChecker: More precise warning message
Added new enum in order to differentiate the warning messages on "misusing" into
3 categories:
Author: szepet
Date: Sat Oct 28 16:09:37 2017
New Revision: 316850
URL: http://llvm.org/viewvc/llvm-project?rev=316850=rev
Log:
[analyzer] MisusedMovedObjectChecker: Fix false positive on state-resetting,
handling method calls on base-class sub-objects
An earlier solution from Artem r315301
Author: szepet
Date: Mon May 7 05:08:27 2018
New Revision: 331630
URL: http://llvm.org/viewvc/llvm-project?rev=331630=rev
Log:
[ASTImporter] Support importing UnresolvedMemberExpr, DependentNameType,
DependentScopeDeclRefExpr
The visit callback implementations for the 3 C++ AST Node added to
Author: szepet
Date: Wed May 2 04:52:54 2018
New Revision: 331344
URL: http://llvm.org/viewvc/llvm-project?rev=331344=rev
Log:
[ASTImporter] Fix isa cast assert
Do early return if we can't import the found decl for a member expr.
This follows the pre-existing scheme, e.g with
Author: szepet
Date: Sat Oct 28 05:19:08 2017
New Revision: 316830
URL: http://llvm.org/viewvc/llvm-project?rev=316830=rev
Log:
[analyzer] LoopUnrolling: check the bitwidth of the used numbers (pr34943)
The loop unrolling feature aims to track the maximum possible steps a loop can
make. In order
Author: szepet
Date: Wed Feb 21 08:06:56 2018
New Revision: 325693
URL: http://llvm.org/viewvc/llvm-project?rev=325693=rev
Log:
[analyzer] Prevent AnalyzerStatsChecker from crash
The checker marks the locations where the analyzer creates sinks. However, it
can happen that the sink was created
Author: szepet
Date: Wed Apr 25 10:28:03 2018
New Revision: 330847
URL: http://llvm.org/viewvc/llvm-project?rev=330847=rev
Log:
[ASTImporter] FriendDecl importing improvements
There are only a few cases of importing a frienddecl which is currently
supported.
This patch aims to improve the
Author: szepet
Date: Tue Mar 27 05:16:56 2018
New Revision: 328619
URL: http://llvm.org/viewvc/llvm-project?rev=328619=rev
Log:
[analyzer] LoopUnrolling: update the matched assignment operators
Extended the matched assignment operators when checking for bound changes in a
body of the loop by
Author: szepet
Date: Tue Mar 27 05:11:46 2018
New Revision: 328618
URL: http://llvm.org/viewvc/llvm-project?rev=328618=rev
Log:
[ASTMatchers] Add isAssignmentOperator matcher
Adding a matcher for BinaryOperator and cxxOperatorCallExpr to be able to
decide whether it is any kind of assignment
37 matches
Mail list logo
