[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek updated this revision to Diff 202310. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake llvm/r

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek added a comment. In D62622#1523269 , @aprantl wrote: > I like LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO. Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 __

[PATCH] D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. Since we share headers between host and target builds, we need to use the same version for both

[PATCH] D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL362181: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL362185: [CMake] Provide an option to use relative paths in debug info (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62622?vs=202310&id=202351#toc Repository:

[PATCH] D58375: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362580: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3 (authored by phosek, committed by ).

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek created this revision. phosek added reviewers: ilya-biryukov, sammccall, bkramer, echristo. Herald added subscribers: cfe-commits, kadircet. Herald added a project: clang. Args[0] isn't necessarily a correct path, it may not even be the path to the compiler, for example when using tools lik

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek added a comment. In D63092#1536774 , @sammccall wrote: > `argv[0]` does carry important information though, I think this will break a > lot of things. It's... concerning that no tests broke. > > For example, if it's `clang` or `g++` or `clang-cl` t

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek added a comment. One more thing, do you think it's reasonable to use `llvm::sys::findProgramByName(Args[0])`instead of `Args[0]` when creating the driver instance? One of the failure modes I ran into is the case where the generated compilation database would contain just the executable n

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

phosek added a comment. This broke all our macOS builders: llvm-lit: /b/s/w/ir/k/llvm-project/llvm/utils/lit/lit/TestingConfig.py:102: fatal: unable to parse config file '/b/s/w/ir/k/recipe_cleanup/clangh7IvHV/llvm_build_dir/tools/lld/test/lit.site.cfg.py', traceback: Traceback (most recent

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

phosek added a comment. Would it be possible to land this change? Do you need help with landing it? We've been waiting for this for a long time and we would like to start using it now that it has been accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.l

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. While upgrading to newer CMake would be nice, I think it's unlikely that we could move all the way to 3.12 since that version was only released a year ago and still isn't available in most dis

[PATCH] D64603: [Target] Use IEEE quad format for long double on Fuchsia x86_64

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. This change unifies the long double format between x86_64 and aarch64 targets making it easier to write code that's indepe

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. We want to preserve debug info in our runtimes to aid symbolization and debugging; for shared libraries this will be stripped away during install-

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL365845: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[PATCH] D64140: [CMake][Fuchsia] Define asan+noexcept multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rL365994: [CMake][Fuchsia] Define asan+noexcept multilib (authored by phosek, committed by ). Herald added subscribers: llvm-commits, javed.absar. Herald added a project: LLVM. Changed prior to commit: ht

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek created this revision. phosek added reviewers: vitalybuka, morehouse, kcc. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change introduces a pair of -fsanitize-link-deps and -fno-sanitize-link-deps flags which can be used to control linking of sanitizer runtime

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek added a comment. In D65029#1594437 , @pcc wrote: > It's also worth asking whether `-nodefaultlibs` would work for this use case > as @filcab suggested on D64547 . It wouldn't, `-nodefaultlibs` (same as `-nostdlib`

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

phosek added a comment. I'm seeing some test failures which appear to have been introduced by this change: TEST 'Clang :: CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp' FAILED Script: -- : 'RUN: at line 1'; /b/s/w/ir/k/recipe_cleanup/clango5z

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

phosek reopened this revision. phosek added a comment. This revision is now accepted and ready to land. Reverted in r366979. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___

[PATCH] D65270: [CMake] Fix source path generation for install in multi-config (MSBuild)

phosek added a comment. LGTM, @beanz and @smeenai do you have any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65270/new/ https://reviews.llvm.org/D65270 ___ cfe-commits mailing list

[PATCH] D65000: [ARM] Set default alignment to 64bits

phosek added inline comments. Comment at: cfe/trunk/test/CodeGen/ARM/exception-alignment.cpp:9 +// A16-NEXT: store <2 x i64> , <2 x i64>* [[BC]], align 16 +#include + thegameg wrote: > thakis wrote: > > This fails on some bots: > > > > http://lab.llvm.org:8011/

[PATCH] D65000: [ARM] Set default alignment to 64bits

phosek added a comment. Reverted in rL367166 . Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D65000 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach

phosek added a comment. In D65233#1603653 , @thakis wrote: > phosek: In what config / on what bot? It's our toolchain linux-x86 builder, see https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8906751725919481408, mac-x86 has been work

[PATCH] D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach

phosek added a comment. In D65233#1603741 , @bjope wrote: > I made another fixup (similar to https://reviews.llvm.org/rL367176) here > https://reviews.llvm.org/rL367182. > > Can someone please take a look (a post-commit review) of > https://reviews.llvm.

[PATCH] D65300: [clang] [CodeGen] clang-misexpect prototype for compiler warnings

phosek added inline comments. Comment at: clang/lib/CodeGen/MisExpect.cpp:29 + +void DebugPrintMisExpectSwitchInfo(SmallVector *SwitchWeights, + llvm::DenseMap *CaseMap); It seems like `DebugPrintMisExpectSwitchInfo` and `EmitMis

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

phosek added a comment. Looks like this change broke `Profile/gcc-flag-compatibility.c` test on macOS: TEST 'Clang :: Profile/gcc-flag-compatibility.c' FAILED Script: -- : 'RUN: at line 10'; /b/s/w/ir/k/recipe_cleanup/clangOLc9jG/llvm_build_di

[PATCH] D65690: [clang-doc] Add index in each info html file

phosek added inline comments. Comment at: clang-tools-extra/clang-doc/assets/index.js:17 + return FilePath.substring(Path.length + 1) + Path = Path.substring(0, Path.lastIndexOf("/")); + } Wrong indentation? CHANGES SINCE LAST ACTION https://review

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213170. phosek edited the summary of this revision. phosek added a comment. Herald added a subscriber: cryptoad. I've updated the change and renamed the flag to `-fsanitize-no-runtime` although I'm not sure if it's necessarily better. I was thinking that ideal

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213233. phosek added a comment. I've decided to go with the original `-f[no-]sanitize-link-deps`: `-fsanitize-minimal-runtime` is also a cc1 flag which affects codegen, `-fshared-libsan` and `-fstatic-libsan` are orthogonal, e.g. it's possible to have minima

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213235. phosek added a comment. One more change, I went with `-fsanitize-runtime` and `-fno-sanitize-runtime` in the end which seems like the best fit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files:

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213237. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/sanit

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213267. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolCh

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

This revision was automatically updated to reflect the committed changes. Closed by commit rL367794: [Driver] Support for disabling sanitizer runtime linking (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack

phosek updated this revision to Diff 213280. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65715/new/ https://reviews.llvm.org/D65715 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/fsanitize-coverage.c Index: clang/test/Driver/fsanitize-coverage.c =

[PATCH] D65715: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack

This revision was automatically updated to reflect the committed changes. Closed by commit rL367799: [Driver] Don't disable -fsanitizer-coverage for safe-stack or shadow-call-stack (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

phosek added a comment. This looks reasonable to me; I'd prefer to clean up Clang's internal headers to be compatible with both FreeBSD's and musl's standard headers as suggested in http://lists.llvm.org/pipermail/llvm-dev/2019-August/134353.html, but I'm not sure how feasible or doable that is

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64089/new/ https://reviews.llvm.org/D64089 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65699/new/ https://reviews.llvm.org/D65699 ___ cfe-commits ma

[PATCH] D65838: [Driver] Use enumeration for quoting mode. NFC

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65838/new/ https://reviews.llvm.org/D65838 ___

[PATCH] D64140: [CMake][Fuchsia] Define asan+noexcept multilib

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Using noexcept multilib with -fno-exceptions can lead to significant space savings when statically linking libc++abi because we don't need all the unwindin

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Linux.cpp:868 -static std::string DetectLibcxxIncludePath(StringRef base) { +static std::string DetectLibcxxIncludePath(StringR

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. All our bots are failing which seems to have been caused by the latest reland: FAIL: Clang :: Analysis/checker-plugins.c (297 of 14793) TEST 'Clang :: Analysis/checker-plugins.c' FAILED Script: -- : 'RUN: at line 1';

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505323 , @Szelethus wrote: > I started to land other patches as well that depend on this one -- I won't > object, but I'd prefer to find a solution, mostly because I don't even know > how I could reproduce this error. T

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505463 , @NoQ wrote: > Can we have a full build log? The full build log is here: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8913271285442739696 Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added inline comments. Comment at: cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt:4 + +if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) + target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE Szelethus wrote: > Szel

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505682 , @Szelethus wrote: > In that case, feel free to revert this. If around 11:00 CET time I tried to > recommit with a possible fix (while watching your bots), would that be an > issue? I managed to reproduce this

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

phosek created this revision. phosek added reviewers: smeenai, Szelethus, NoQ. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. When plugins aren't enabled, don't try to run plugins tests. Don't enable plugins unconditionally based on the platform, i

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

phosek added a comment. @bd1976llvm do you plan on landing this? We'd really like to start using this feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60274/new/ https://reviews.llvm.org/D60274 ___ cfe-commits mailing list cfe-commit

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rL360991: [Analysis] Only run plugins tests if plugins are actually enabled (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62050?vs=199955&id=199977#toc Repositor

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

phosek added a comment. We (Fuchsia) would like to see this landed as well so we can start using this in our kernel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38479/new/ https://reviews.llvm.org/D38479 ___ cfe-commits mailing list cfe-

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek created this revision. phosek added reviewers: hintonda, vitalybuka, Szelethus. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. These are needed to avoid undefined symbols which aren't satisfied by Clang itself. Repository: rC Clang http

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek added a comment. This is an alternative to D62154 . With just the change to `HandleLLVMOptions.cmake`, we're seeing errors in Analysis plugins due to undefined symbols: error: 'error' diagnostics seen but not expected: (frontend): unable to load plu

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rC361340: [Analysis] Link library dependencies to Analysis plugins (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62174?vs=200405&id=200615#toc Repository: rC C

[PATCH] D58375: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3

phosek updated this revision to Diff 200784. phosek retitled this revision from "[Clang][NewPM] Disable tests that are broken under new PM" to "[Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3". phosek edited the summary of this revision. Repository: rC Clang CHAN

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

This revision was automatically updated to reflect the committed changes. Closed by commit rC361432: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and… (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D59168?vs=197241&id=200817#toc Rep

[PATCH] D52132: [CMake] Use cannonical triples for Fuchsia runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL361456: [CMake][Fuchsia] Use cannonical triples for runtimes (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D62286: [Driver] Try normalized triple when looking for C++ libraries

phosek created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses the issue introduced in r361432 where we would only try effective triple but not the normalized one as we do for other runtimes. Repository: rC Clang https://reviews.llvm.org/D6

[PATCH] D62286: [Driver] Try normalized triple when looking for C++ libraries

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC361504: [Driver] Try normalized triple when looking for C++ libraries (authored by phosek, committed by ). Changed prior

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan, saugustine, echristo. Herald added subscribers: cfe-commits, javed.absar, kubamracek. Herald added a project: clang. This is a follow up to r361432 and r361504 which addresses issues introduced by those changes. Specifica

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

phosek updated this revision to Diff 201432. phosek marked 8 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62442/new/ https://reviews.llvm.org/D62442 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

phosek added a comment. In D62442#1517183 , @mcgrathr wrote: > lgtm contingent on verifying intended behavior changes and adding comments. > The factoring suggestion for the triple,triple searching is preferred but at > your discretion, though I'd reall

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

This revision was automatically updated to reflect the committed changes. Closed by commit rC361709: [Driver] Update handling of c++ and runtime directories (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62442?vs=201432&id=201433#toc Repository: rC Cl

[PATCH] D62469: [Driver] Change layout of per-target runtimes to resemble multiarch

phosek created this revision. phosek added reviewers: jdenny, beanz, smeenai, mcgrathr, saugustine. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, cryptoad, javed.absar, mgorny, kubamracek. Herald added projects: clang, Sanitizers, LLVM. This is a follow up to r361432, changing

[PATCH] D62469: [Driver] Change layout of per-target runtimes to resemble multiarch

This revision was automatically updated to reflect the committed changes. Closed by commit rL361784: [Driver] Change layout of per-target runtimes to resemble multiarch (authored by phosek, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D62558: [Driver] Search the toolchain dir with -print-file-name

phosek created this revision. phosek added reviewers: mcgrathr, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful when looking for directories or files relative to the toolchain root, e.g. include/c++/v1. This change also adds a test to make sure this

[PATCH] D62558: [Driver] Search the toolchain dir with -print-file-name

This revision was automatically updated to reflect the committed changes. Closed by commit rC361903: [Driver] Search the toolchain dir with -print-file-name (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62558?vs=201788&id=201791#toc Repository: rC Cl

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: libunwind/test/libunwind/test/config.py:27 +self.libcxx_src_root = (self.get_lit_conf('libcxx_src_root') +or os.path.join(self.libunwind_

[PATCH] D62483: [CUDA][HIP] Emit dependent libs for host only

phosek added a comment. This seems to be failing on macOS bots with the following error: FAIL: Clang :: CodeGenCUDA/dependent-libs.cu (3052 of 14933) TEST 'Clang :: CodeGenCUDA/dependent-libs.cu' FAILED Script: -- : 'RUN: at line 1'; /b/s/w/

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek created this revision. phosek added reviewers: beanz, smeenai. Herald added subscribers: llvm-commits, cfe-commits, aprantl, mgorny. Herald added projects: clang, LLVM. CMake always uses absolute file paths in the generated compiler invocation which results in absolute file paths being embe

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek updated this revision to Diff 202064. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake llvm/r

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek added a comment. In D62622#1522247 , @aprantl wrote: > -DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false > impression. Is there a name that emphasizes that this affects the debug info > of the built compiler? How about `L

[PATCH] D54681: [Driver] Avoid including -lm on the link line with -nostdlib++

phosek added a comment. In D54681#1329240 , @thakis wrote: > -lm is kind of the reason -nostdlib++ exists at all -- if you don't want > _any_ stdlibs, you can just -nostdlib, no? We still want standard libraries like `-lc` and compiler builtins, `-nostd

[PATCH] D55847: [gn build] Add build file for clang/lib/Basic and dependencies

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55847/new/ https://reviews.llvm.org/D55847 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D54724: [Driver] Automatically include C++ library dependencies

phosek added a comment. In D54724#1304986 , @dim wrote: > I think I understand the motivation, it's just that the toolchain classes > were split up specifically to avoid `if(OS==foo) ... else if(OS==bar) ... > else if(OS==baz)` mazes. So this feels a li

[PATCH] D55912: [gn build] Add build files for clang/lib/Lex and clang/lib/AST

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55912/new/ https://reviews.llvm.org/D55912 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55913: [gn build] Add build files for clang/lib/{Analysis, Edit, Sema}

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55913/new/ https://reviews.llvm.org/D55913 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55924: [gn build] Add build files for clang-format and lib/{Format,Rewrite,Tooling/Core,Tooling/Inclusions}

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55924/new/ https://reviews.llvm.org/D55924 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55925: [gn build] Add build file for clang/lib/Parse

phosek added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55925/new/ https://reviews.llvm.org/D55925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D55927: [gn build] Add build file for clang/lib/Driver

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55927/new/ https://reviews.llvm.org/D55927 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55931: [gn build] Add build file for clang/lib/CodeGen and llvm/lib/ProfileData/Coverage

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55931/new/ https://reviews.llvm.org/D55931 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55930: [gn build] Add build files for clang/lib/{Frontend, Frontend/Rewrite, Serialization}

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55930/new/ https://reviews.llvm.org/D55930 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56024: [clang] [Distro] Support detecting Gentoo

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/Driver/Distro.h:118 } bool IsUbuntu() const { Shall we also introduce the `IsGentoo()` predicate for convenience? Re

[PATCH] D55980: [gn build] Add build file for clang/lib/FrontendTool

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55980/new/ https://reviews.llvm.org/D55980 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55979: [gn build] Add build file for clang/lib/ARCMigrate

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55979/new/ https://reviews.llvm.org/D55979 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55981: [gn build] Add build files for clang, clang-offload-bundler, and clang/lib/Headers

phosek added inline comments. Comment at: llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn:6 + +files = [ + "adxintrin.h", Why not just inline this? This variable doesn't seem to be used from anywhere else? CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D55984: [gn build] Embed __TEXT __info_plist section into clang binary on macOS

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55984/new/ https://reviews.llvm.org/D55984 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55978: [gn build] Add build files for clang/lib/{ASTMatchers, CrossTU}, clang/lib/StaticAnalyzer/{Checkers, Core, Frontend}

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55978/new/ https://reviews.llvm.org/D55978 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56043: [Driver] Don't pass default value to getCompilerRTArgString

phosek created this revision. phosek added a reviewer: echristo. Herald added a subscriber: cfe-commits. Using static library is already a default. This makes it easier to change the parameter type in the future. Repository: rC Clang https://reviews.llvm.org/D56043 Files: clang/lib/Driver

[PATCH] D56044: [Driver] Support object files in addition to static and shared libraries in compiler-rt

phosek created this revision. phosek added a reviewer: echristo. Herald added subscribers: cfe-commits, atanasyan, jrtc27, dberris, sdardis. This change introduces support for object files in addition to static and shared libraries which were already supported which requires changing the type of t

[PATCH] D55981: [gn build] Add build files for clang, clang-offload-bundler, and clang/lib/Headers

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55981/new/ https://reviews.llvm.org/D55981 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56055: [gn build] Add build files for clang/tools/{clang-refactor, clang-rename}, clang/utils/hmaptool, clang/lib/Tooling/Refactoring

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56055/new/ https://reviews.llvm.org/D56055 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56054: [gn build] Add build files for clang/tools/{clang-diff, clang-import-test, diagtool and clang/lib/Tooling, clang/lib/Tooling/ASTDiff

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56054/new/ https://reviews.llvm.org/D56054 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56056: [gn build] Add build files for clang/tools/{arcmt-test, clang-check, clang-func-mapping}

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56056/new/ https://reviews.llvm.org/D56056 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

phosek added a comment. Just a comment regarding the description, are you sure it's GNU strip and not as? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56047/new/ https://reviews.llvm.org/D56047 ___ cfe-commits mail

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, would it be possible to also include https://bugs.gentoo.org/667854 in the commit message for reference? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56

[PATCH] D56059: [gn build] Add build files for clang/tools/{c-arcmt-test, c-index-test} and their dependency clang/tools/libclang

phosek accepted this revision. phosek marked an inline comment as done. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16-17 +if (host_os == "linux") { + # Linux needs -fPIC to bui

[PATCH] D56065: [gn build] Make NOSORT line actually work

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56065/new/ https://reviews.llvm.org/D56065 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56095: [gn build] Add check-clang target and make it work

phosek added inline comments. Comment at: llvm/utils/gn/secondary/llvm/triples.gni:10 +} else { + assert(false, "missing host_cpu " + host_cpu) } I don't think `host_cpu` would ever be missing since it's detected by GN (unless it's a new architecture that GN d

[PATCH] D56095: [gn build] Add check-clang target and make it work

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56095/new/ https://reviews.llvm.org/D56095 ___ cfe-commits mailing list cfe-commits@l

<    1   2   3   4   5   6   7   8   9   10   >