[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:173 + } + + // Builds of compiler-rt on bare-metal targets are specialized by specific Would it be possible to support the [per-target runtimes directory

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505682 , @Szelethus wrote: > In that case, feel free to revert this. If around 11:00 CET time I tried to > recommit with a possible fix (while watching your bots), would that be an > issue? I managed to reproduce

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

phosek added a comment. @bd1976llvm do you plan on landing this? We'd really like to start using this feature. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60274/new/ https://reviews.llvm.org/D60274 ___ cfe-commits mailing list

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505463 , @NoQ wrote: > Can we have a full build log? The full build log is here: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-x64-linux/b8913271285442739696 Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

phosek created this revision. phosek added reviewers: smeenai, Szelethus, NoQ. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. When plugins aren't enabled, don't try to run plugins tests. Don't enable plugins unconditionally based on the platform,

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. In D59464#1505323 , @Szelethus wrote: > I started to land other patches as well that depend on this one -- I won't > object, but I'd prefer to find a solution, mostly because I don't even know > how I could reproduce this error.

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added inline comments. Comment at: cfe/trunk/test/Analysis/plugins/CheckerDependencyHandling/CMakeLists.txt:4 + +if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) + target_link_libraries(CheckerDependencyHandlingAnalyzerPlugin PRIVATE Szelethus wrote: >

[PATCH] D62050: [Analysis] Only run plugins tests if plugins are actually enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rL360991: [Analysis] Only run plugins tests if plugins are actually enabled (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62050?vs=199955=199977#toc Repository:

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan, saugustine, echristo. Herald added subscribers: cfe-commits, javed.absar, kubamracek. Herald added a project: clang. This is a follow up to r361432 and r361504 which addresses issues introduced by those changes.

[PATCH] D62469: [Driver] Change layout of per-target runtimes to resemble multiarch

This revision was automatically updated to reflect the committed changes. Closed by commit rL361784: [Driver] Change layout of per-target runtimes to resemble multiarch (authored by phosek, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

This revision was automatically updated to reflect the committed changes. Closed by commit rC361709: [Driver] Update handling of c++ and runtime directories (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62442?vs=201432=201433#toc Repository: rC

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

phosek added a comment. In D62442#1517183 , @mcgrathr wrote: > lgtm contingent on verifying intended behavior changes and adding comments. > The factoring suggestion for the triple,triple searching is preferred but at > your discretion, though I'd

[PATCH] D62442: [Driver] Update handling of c++ and runtime directories

phosek updated this revision to Diff 201432. phosek marked 8 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62442/new/ https://reviews.llvm.org/D62442 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp

[PATCH] D62469: [Driver] Change layout of per-target runtimes to resemble multiarch

phosek created this revision. phosek added reviewers: jdenny, beanz, smeenai, mcgrathr, saugustine. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, cryptoad, javed.absar, mgorny, kubamracek. Herald added projects: clang, Sanitizers, LLVM. This is a follow up to r361432, changing

[PATCH] D58375: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362580: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3 (authored by phosek, committed by

[PATCH] D62483: [CUDA][HIP] Emit dependent libs for host only

phosek added a comment. This seems to be failing on macOS bots with the following error: FAIL: Clang :: CodeGenCUDA/dependent-libs.cu (3052 of 14933) TEST 'Clang :: CodeGenCUDA/dependent-libs.cu' FAILED Script: -- : 'RUN: at line 1';

[PATCH] D62558: [Driver] Search the toolchain dir with -print-file-name

phosek created this revision. phosek added reviewers: mcgrathr, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful when looking for directories or files relative to the toolchain root, e.g. include/c++/v1. This change also adds a test to make sure this

[PATCH] D62558: [Driver] Search the toolchain dir with -print-file-name

This revision was automatically updated to reflect the committed changes. Closed by commit rC361903: [Driver] Search the toolchain dir with -print-file-name (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62558?vs=201788=201791#toc Repository: rC

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: libunwind/test/libunwind/test/config.py:27 +self.libcxx_src_root = (self.get_lit_conf('libcxx_src_root') +or

[PATCH] D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well

This revision was automatically updated to reflect the committed changes. Closed by commit rL362181: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62712: [CMake][Fuchsia] Use libc++ ABI v2 on Darwin as well

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich, juliehockett. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. Herald added a project: clang. Since we share headers between host and target builds, we need to use the same version for

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek updated this revision to Diff 202310. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek added a comment. In D62622#1523269 , @aprantl wrote: > I like LLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO. Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL362185: [CMake] Provide an option to use relative paths in debug info (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62622?vs=202310=202351#toc Repository:

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek added a comment. In D62622#1522247 , @aprantl wrote: > -DLLVM_USE_RELATIVE_PATHS is very generic sounding and might give a false > impression. Is there a name that emphasizes that this affects the debug info > of the built compiler? How about

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek created this revision. phosek added reviewers: beanz, smeenai. Herald added subscribers: llvm-commits, cfe-commits, aprantl, mgorny. Herald added projects: clang, LLVM. CMake always uses absolute file paths in the generated compiler invocation which results in absolute file paths being

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek updated this revision to Diff 202064. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62622/new/ https://reviews.llvm.org/D62622 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/cmake/modules/HandleLLVMOptions.cmake llvm/cmake/modules/LLVMExternalProjectUtils.cmake

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek created this revision. phosek added reviewers: ilya-biryukov, sammccall, bkramer, echristo. Herald added subscribers: cfe-commits, kadircet. Herald added a project: clang. Args[0] isn't necessarily a correct path, it may not even be the path to the compiler, for example when using tools

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek added a comment. In D63092#1536774 , @sammccall wrote: > `argv[0]` does carry important information though, I think this will break a > lot of things. It's... concerning that no tests broke. > > For example, if it's `clang` or `g++` or `clang-cl`

[PATCH] D63092: [Frontend] Use executable path when creating invocation from cmdline

phosek added a comment. One more thing, do you think it's reasonable to use `llvm::sys::findProgramByName(Args[0])`instead of `Args[0]` when creating the driver instance? One of the failure modes I ran into is the case where the generated compilation database would contain just the executable

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

phosek added a comment. Would it be possible to land this change? Do you need help with landing it? We've been waiting for this for a long time and we would like to start using it now that it has been accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek created this revision. phosek added reviewers: hintonda, vitalybuka, Szelethus. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. These are needed to avoid undefined symbols which aren't satisfied by Clang itself. Repository: rC Clang

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

phosek added a comment. This is an alternative to D62154 . With just the change to `HandleLLVMOptions.cmake`, we're seeing errors in Analysis plugins due to undefined symbols: error: 'error' diagnostics seen but not expected: (frontend): unable to load

[PATCH] D62174: [Analysis] Link library dependencies to Analysis plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rC361340: [Analysis] Link library dependencies to Analysis plugins (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62174?vs=200405=200615#toc Repository: rC

[PATCH] D58375: [Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3

phosek updated this revision to Diff 200784. phosek retitled this revision from "[Clang][NewPM] Disable tests that are broken under new PM" to "[Clang] Disable new PM for tests that use optimization level -O1, -O2 and -O3". phosek edited the summary of this revision. Repository: rC Clang

[PATCH] D52132: [CMake] Use cannonical triples for Fuchsia runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL361456: [CMake][Fuchsia] Use cannonical triples for runtimes (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

This revision was automatically updated to reflect the committed changes. Closed by commit rC361432: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and… (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D59168?vs=197241=200817#toc

[PATCH] D62286: [Driver] Try normalized triple when looking for C++ libraries

phosek created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses the issue introduced in r361432 where we would only try effective triple but not the normalized one as we do for other runtimes. Repository: rC Clang

[PATCH] D62286: [Driver] Try normalized triple when looking for C++ libraries

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC361504: [Driver] Try normalized triple when looking for C++ libraries (authored by phosek, committed by ). Changed prior

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

phosek added a comment. We (Fuchsia) would like to see this landed as well so we can start using this in our kernel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38479/new/ https://reviews.llvm.org/D38479 ___ cfe-commits mailing list

[PATCH] D59464: [analyzer] Add an example plugin for checker dependency handling

phosek added a comment. All our bots are failing which seems to have been caused by the latest reland: FAIL: Clang :: Analysis/checker-plugins.c (297 of 14793) TEST 'Clang :: Analysis/checker-plugins.c' FAILED Script: -- : 'RUN: at line 1';

[PATCH] D61646: Include corecrt.h/vcruntime.h to improve MS compatibility

phosek added a comment. This change broke our build which is using Clang and the `x86_64-windows-msvc` target to cross-compile our EFI bootloader. Now the compilation fails

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

This revision was automatically updated to reflect the committed changes. Closed by commit rC360313: [NewPM] Setup Passes for KASan and KMSan (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D61664?vs=198580=198760#toc Repository: rC Clang CHANGES

[PATCH] D61709: [NewPM] Port HWASan

phosek added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:956 + + if (LangOpts.Sanitize.has(SanitizerKind::HWAddress)) { +bool Recover = CodeGenOpts.SanitizeRecover.has(SanitizerKind::HWAddress); Can you also add `KernelHWAddress` (akin to

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek marked an inline comment as not done. phosek added a subscriber: rsmith. phosek added inline comments. Comment at: libunwind/CMakeLists.txt:190 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek marked an inline comment as done. phosek added inline comments. Comment at: libunwind/CMakeLists.txt:190 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) - set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}/) -

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek added a comment. In D59168#1484467 , @jdenny wrote: > In D59168#1480801 , @phosek wrote: > > > In D59168#1480428 , @jdenny wrote: > > > > > It seems we have roughly

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL359603: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61383: [Driver] Explicitly request platform rtlib in the Driver pic test

phosek created this revision. phosek added a reviewer: juliehockett. Herald added a project: clang. Herald added a subscriber: cfe-commits. This test checks whether crtbegin.o and crtend.o appear on the link line, but names of these files may be affected by the choice of the rtlib, specifically

[PATCH] D61383: [Driver] Explicitly request platform rtlib in the Driver pic test

This revision was automatically updated to reflect the committed changes. Closed by commit rL359706: [Driver] Explicitly request platform rtlib in the Driver pic test (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60990: [Driver] Support priority for multilibs

This revision was automatically updated to reflect the committed changes. Closed by commit rC359359: [Driver] Support priority for multilibs (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D60990?vs=196905=196933#toc Repository: rC Clang CHANGES SINCE

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

This revision was automatically updated to reflect the committed changes. Closed by commit rC359360: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D61040?vs=196791=196934#toc

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

phosek updated this revision to Diff 197241. phosek retitled this revision from "[runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/" to "[runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++". phosek edited the summary of this revision. phosek

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek updated this revision to Diff 198347. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49587/new/ https://reviews.llvm.org/D49587 Files:

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

phosek added a comment. In D49587#1488328 , @smeenai wrote: > Seems like you got the wrong diff. It was the right diff but uploaded to a wrong change ;) In D49587#1484829 , @smeenai wrote: > Sorry, had missed

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

This revision was automatically updated to reflect the committed changes. Closed by commit rC360100: [Clang][NewPM] Dont bail out if the target machine is empty (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D58374?vs=188999=198367#toc Repository: rC

[PATCH] D61664: [NewPM] Setup Passes for KASan and KMSan

phosek created this revision. phosek added reviewers: leonardchan, fedor.sergeev, chandlerc, philip.pfaffe. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. While ASan and MSan passes were already ported to new PM, the kernel variants weren't

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1472152 , @jdenny wrote: > In D59168#1470578 , @phosek wrote: > > > In D59168#1469186 , @jdenny wrote: > > > > > > > > > > > I was also

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

phosek created this revision. phosek added reviewers: beanz, smeenai. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. phosek updated this revision to Diff 195934. This is a more generic solution; while the sanitizer support can be used only for

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

phosek updated this revision to Diff 195934. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60926/new/ https://reviews.llvm.org/D60926 Files: clang/cmake/caches/Fuchsia-stage2.cmake llvm/runtimes/CMakeLists.txt Index: llvm/runtimes/CMakeLists.txt

[PATCH] D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir

phosek created this revision. phosek added reviewers: hans, inglorion, rnk, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. When user specifies non-existent directory to -fcrash-diagnostics-dir, create it rather than failing with an error. Repository: rC Clang

[PATCH] D54784: Use --push/pop-state with XRay link deps

phosek abandoned this revision. phosek added a comment. Herald added a project: clang. Turned out this is not the right approach because not every linker supports `--push-state`/`--pop-state` but I'm hoping to instead rely on ELF autolinking once D60274 lands.

[PATCH] D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir

This revision was automatically updated to reflect the committed changes. Closed by commit rL359954: [Driver] Create non-existent directory for -fcrash-diagnostics-dir (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D61456: [gn] Update the clangd test lit site configuration

phosek updated this revision to Diff 197837. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61456/new/ https://reviews.llvm.org/D61456 Files: llvm/utils/gn/secondary/clang-tools-extra/clangd/test/BUILD.gn

[PATCH] D61456: [gn] Update the clangd test lit site configuration

phosek added a comment. In D61456#1488383 , @thakis wrote: > Thanks! This is incomplete: > > - Create clangd_lit_site_cfg_files.gni next to this build file, but path to > generated files there > - Edit llvm/utils/gn/secondary/llvm/utils/llvm-lit/BUILD.gn

[PATCH] D61456: [gn] Update the clangd test lit site configuration

phosek created this revision. phosek added a reviewer: thakis. Herald added subscribers: llvm-commits, cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added projects: clang, LLVM. This reflects changes made in r359763. Repository: rCTE Clang Tools Extra

[PATCH] D60235: [CMake] Disable libc++ and libc++abi new/delete definitions when built with ASan

phosek abandoned this revision. phosek added a comment. No longer needed, this was done as part of D60926 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60235/new/ https://reviews.llvm.org/D60235

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1480428 , @jdenny wrote: > It seems we have roughly the same situation for their ABIs. That is, for .so > files, someone noted that libc++ and libunwind have always used the same > version, .1, and openmp doesn't use a

[PATCH] D60990: [Driver] Support priority for multilibs

phosek added a comment. In D60990#1475116 , @lebedev.ri wrote: > Can this have test coverage? Done, I've added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990

[PATCH] D60990: [Driver] Support priority for multilibs

phosek updated this revision to Diff 196905. phosek marked an inline comment as done. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990 Files: clang/include/clang/Driver/Multilib.h

[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. While upgrading to newer CMake would be nice, I think it's unlikely that we could move all the way to 3.12 since that version was only released a year ago and still isn't available in most

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. We want to preserve debug info in our runtimes to aid symbolization and debugging; for shared libraries this will be stripped away during

[PATCH] D64603: [Target] Use IEEE quad format for long double on Fuchsia x86_64

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. This change unifies the long double format between x86_64 and aarch64 targets making it easier to write code that's

[PATCH] D64605: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL365845: [CMake][Fuchsia] Use RelWithDebInfo to build runtimes (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64140: [CMake][Fuchsia] Define asan+noexcept multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rL365994: [CMake][Fuchsia] Define asan+noexcept multilib (authored by phosek, committed by ). Herald added subscribers: llvm-commits, javed.absar. Herald added a project: LLVM. Changed prior to commit:

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Linux.cpp:868 -static std::string DetectLibcxxIncludePath(StringRef base) { +static std::string

[PATCH] D64140: [CMake][Fuchsia] Define asan+noexcept multilib

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Using noexcept multilib with -fno-exceptions can lead to significant space savings when statically linking libc++abi because we don't need all the

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

This revision was automatically updated to reflect the committed changes. Closed by commit rL358935: [CMake] Replace the sanitizer support in runtimes build with multilib (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D60926?vs=195934=196159#toc

[PATCH] D60990: [Driver] Support priority for multilibs

phosek created this revision. phosek added reviewers: jroelofs, bkramer. Herald added subscribers: cfe-commits, mgrang. Herald added a project: clang. When more than one multilib flag matches, try to select the best possible match based on priority. When two different multilibs with the same same

[PATCH] D60974: Clang IFSO driver action.

phosek added a comment. Aside from comments that @jakehehrlich already made which I agree with, I'm also concerned about the use of `yaml2obj`. AFAIK that tool has always been intended as a testing, not a production tool, but with this change this would no longer be the case. Specifically, it

[PATCH] D60409: [clangd] Add -header-insertion=never flag to disable include insertion in code completion

phosek added a comment. Our Mac builders have started failing after this change with the following: [3145/3502] Building CXX object tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o FAILED: tools/clang/tools/extra/clangd/tool/CMakeFiles/clangd.dir/ClangdMain.cpp.o

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

phosek created this revision. phosek added reviewers: beanz, jroelofs, mcgrathr. Herald added subscribers: cfe-commits, javed.absar. Herald added a project: clang. This introduces a support for multilibs to Fuchsia driver. Unlike the existing multilibs that are used primarily for handling

[PATCH] D60990: [Driver] Support priority for multilibs

phosek updated this revision to Diff 196331. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60990/new/ https://reviews.llvm.org/D60990 Files: clang/include/clang/Driver/Multilib.h clang/lib/Driver/Multilib.cpp Index:

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122 + +/// \p Flag must be a flag accepted by the driver with its leading '-' removed, +// otherwise '-print-multi-lib' will not emit them correctly. jroelofs wrote: > Can we

[PATCH] D60926: [CMake] Replace the sanitizer support in runtimes build with multilib

phosek added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60926/new/ https://reviews.llvm.org/D60926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions

phosek updated this revision to Diff 196791. phosek marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61040/new/ https://reviews.llvm.org/D61040 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

phosek added a comment. In D59168#1474715 , @jdenny wrote: > Does the following match what you have in mind? > > $prefix/ > include/ > c++/ > v1/ > limits.h > ... > openmp/ > v1/ <-- I don't think

[PATCH] D65690: [clang-doc] Add index in each info html file

phosek added inline comments. Comment at: clang-tools-extra/clang-doc/assets/index.js:17 + return FilePath.substring(Path.length + 1) + Path = Path.substring(0, Path.lastIndexOf("/")); + } Wrong indentation? CHANGES SINCE LAST ACTION

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213170. phosek edited the summary of this revision. phosek added a comment. Herald added a subscriber: cryptoad. I've updated the change and renamed the flag to `-fsanitize-no-runtime` although I'm not sure if it's necessarily better. I was thinking that

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213235. phosek added a comment. One more change, I went with `-fsanitize-runtime` and `-fno-sanitize-runtime` in the end which seems like the best fit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files:

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213233. phosek added a comment. I've decided to go with the original `-f[no-]sanitize-link-deps`: `-fsanitize-minimal-runtime` is also a cc1 flag which affects codegen, `-fshared-libsan` and `-fstatic-libsan` are orthogonal, e.g. it's possible to have

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213237. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

phosek updated this revision to Diff 213267. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65029/new/ https://reviews.llvm.org/D65029 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/SanitizerArgs.h clang/lib/Driver/SanitizerArgs.cpp

[PATCH] D65029: [Driver] Support for disabling sanitizer runtime linking

This revision was automatically updated to reflect the committed changes. Closed by commit rL367794: [Driver] Support for disabling sanitizer runtime linking (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

phosek accepted this revision. phosek added a comment. In D66324#1653198 , @paulkirth wrote: > In D66324#1652364 , @lebedev.ri > wrote: > > > Trying to start reviewing this. > > The llvm side of the patch is self

[PATCH] D66981: Fix driver tests when `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is `ON`

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66981/new/ https://reviews.llvm.org/D66981

[PATCH] D58214: [CMake][Fuchsia] Enable experimental pass manager by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL370421: [CMake][Fuchsia] Enable experimental pass manager by default (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66681: [clang-doc] Bump BitcodeWriter max line number to 32U

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM (small nit, people usually use PRXXX rather than bXXX to refer to issues) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66681/new/ https://reviews.llvm.org/D66681

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

phosek added a comment. @dankm do you still plan to work on this? We would really like to see this landed and we could help if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49466/new/ https://reviews.llvm.org/D49466

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL371584: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM (authored by phosek, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

<    2   3   4   5   6   7   8   9   10   11   >