[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. @rnk @vsk does this look good to you as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek updated this revision to Diff 304342. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45639/new/ https://reviews.llvm.org/D45639 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Driver/darwin-ld.c Index: clang/test/Driver/darwin-ld.c ===

[PATCH] D45639: [Driver] Support default libc++ library location on Darwin

phosek added a comment. I agree with your analysis and I'd also prefer **Solution (1)**, I've rebased the change and included a simple test. Right now, there's nothing specific to libc++, we're simply relying on the linker. Alternative would be to have a more explicit logic in DarwinClang::Add

[PATCH] D91226: [clang] Add missing header guard in

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91226/new/ https://reviews.llvm.org/D91226 ___ c

[PATCH] D91387: [Driver] Support UBSan multilib

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. phosek requested review of this revision. This is analogous to the existing ASan multilib. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. Ping? Is it OK to land this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87928/new/ https://reviews.llvm.org/D87928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. In D87928#2394913 , @dexonsmith wrote: > I missed this before, and it's an interesting problem. > > I have a few questions: > > - I'm not clear on the expected interaction between the current working > directory of the compiler and

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM we may consider implementing `-fsource-dir` in terms of `-fprofile-prefix-map` as suggested in D87928 so I think we should go ahead and land this. Repo

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 ___ c

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

phosek created this revision. phosek added reviewers: kristina, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. phosek requested review of this revision. This helper method is useful even outside of Gnu toolchains, so move it to ToolChain so it can be reused in

[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes

phosek added a comment. In D87822#2301293 , @sepavloff wrote: > In D87822#2301194 , @leonardchan > wrote: > >> Thanks for looking into it. We have that commit but it still seems to be >> failing for us with the sam

[PATCH] D88694: [CMake][Fuchsia] Don't set WIN32 API, rely on autodetection

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. phosek requested review of this revision. We prefer autodetection here to avoid persisting this configuration in the generated __config header which is

[PATCH] D88694: [CMake][Fuchsia] Don't set WIN32 API, rely on autodetection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde47e7122f69: [CMake][Fuchsia] Don't set WIN32 API, rely on autodetection (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa594fd28e373: [Driver] Move detectLibcxxIncludePath to ToolChain (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D88452?vs

[PATCH] D88452: [Driver] Move detectLibcxxIncludePath to ToolChain

phosek updated this revision to Diff 296813. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88452/new/ https://reviews.llvm.org/D88452 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.

[PATCH] D89013: [libcxx] Support per-target __config in per-target runtime build

phosek created this revision. phosek added a reviewer: ldionne. Herald added subscribers: libcxx-commits, cfe-commits, s.egerton, dexonsmith, simoncook, mgorny. Herald added projects: clang, libc++. Herald added a reviewer: libc++. phosek requested review of this revision. When using the per-targ

[PATCH] D89013: [libcxx] Support per-target __config in per-target runtime build

phosek added a comment. This is the per-target `__config` (or more preferable `__config_site`) support I mentioned in D88843 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89013/new/ https://reviews.llvm.org/D8901

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek added a comment. Herald added a subscriber: rdzhabarov. We've already considered introducing a similar mechanism so thank you for working on this! There's one issue that I haven't figured out how to resolve and I'd be interested in your thoughts: building executables and libraries in the

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/Basic/LangOptions.h:299 + /// This overrides the default ABI used by the target. + llvm::Optional CXXABIOverride; + I'

[PATCH] D89177: [cmake] Add support for multiple distributions

phosek added a comment. In D89177#2326832 , @smeenai wrote: > In D89177#2325566 , @phosek wrote: > >> We've already considered introducing a similar mechanism so thank you for >> working on this! There's one issue

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

phosek added a comment. In D85576#2330923 , @leonardchan wrote: > This should also be ready now that https://reviews.llvm.org/D85802 landed, > unless we don't want to submit this *right* now so the clang builders don't > build these multilibs that won't

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#2332766 , @rnk wrote: > In D85802#2331403 , @leonardchan > wrote: > >> Perhaps we can add some mechanism in Clang that determines which ABIs are >> supported for specific platform

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#2332808 , @rnk wrote: > Would "f[no-]fuchsia-c++-abi-extensions" (or shorter, -ffuchsia-c++-abi) do > the trick? I know it doesn't map well onto our current internal option > representation, but I don't think the interna

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

phosek added a comment. In D85802#2333247 , @rsmith wrote: > In D85802#2333105 , @leonardchan > wrote: > >> In D85802#2332895 , @phosek wrote: >> >>> In D85802#2332808

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

phosek added inline comments. Comment at: clang/test/Driver/linux-ld.c:1292 +// CHECK-DEBIAN-SPARC: "{{.*}}/usr/lib/gcc/sparc-linux-gnu/4.5{{/|}}crtbegin.o" +// CHECK-DEBIAN-SPARC: "-L[[SYSROOT]]/usr/lib/gcc/sparc-linux-gnu/4.5" +// CHECK-DEBIAN-SPARC: "-L[[SYSROOT]]/usr/li

[PATCH] D90524: [Driver] Enable getOSLibDir() lib32 workaround for SPARC on Linux

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90524/new/ https://reviews.llvm.org/D90524 ___ c

[PATCH] D92291: clang/test: Remove platform-linker feature

phosek added a comment. In D92291#2423417 , @leonardchan wrote: > @phosek This shouldn't affect supporting riscv with our toolchain, right? Yes, it shouldn't have any impact. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92291/new/ https://revi

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

phosek added a comment. I apologize for the late response, I somehow missed the earlier responses. We have successfully used this feature in Fuchsia and found it useful, but I agree that the issues raised need to be addressed. Unfortunately @paulkirth is no longer working on this project. I hop

[PATCH] D90271: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90271/new/ https://reviews.llvm.org/D90271 ___ c

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llvm.org/D90362 ___ c

[PATCH] D90516: [clang] Limit scope of CLANG_VENDOR definition

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90516/new/ https://reviews.llvm.org/D90516 ___ c

[PATCH] D90362: scan-build supprot relative 'file' in cdb.

phosek added a comment. What's the plan regarding updating scan-build-py to match the upstream? It seems like this issue has already been address in the upstream version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90362/new/ https://reviews.llv

[PATCH] D90641: [compiler-rt][AIX]: Link compiler-rt profile library when -fprofile-generate is specified

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90641/new/ https://reviews.llvm.org/D90641 ___ c

[PATCH] D101139: Create install targets for scan-build-py.

phosek added inline comments. Comment at: clang/tools/scan-build-py/CMakeLists.txt:1-7 +set (BinFiles + "analyze-build" + "analyze-c++" + "analyze-cc" + "intercept-build" + "intercept-c++" + "intercept-cc") Shouldn't this list also contain

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

phosek added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3293 +static bool SupportsRelativeCXXVTables(const llvm::Triple &T) { + return T.isOSFuchsia(); +} Could we instead enable it inside `FuchsiaCXXABI`? Repository: rG LLVM Gith

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

phosek added inline comments. Comment at: clang/include/clang/Basic/TargetCXXABI.h:69 + // default. + static bool supportsRelativeCXXVTables(const llvm::Triple &T) { +return T.isOSFuchsia(); I think that `supports` here is a bit misleading, I'd expect the r

[PATCH] D102374: [clang][Fuchsia] Turn on relative-vtables by default for Fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102374/new/ https://reviews.llvm.org/D102374 ___

[PATCH] D101479: [Driver] Support libc++ in MSVC

phosek added a comment. Ping, is this OK to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

phosek added a comment. We've started seeing `LLVM ERROR: out of memory` on our 2-stage LTO Linux builders after this change landed. It looks like linking `clang-repl` always fails on our bot, but I've also seen OOM when linking `ClangCodeGenTests` and `FrontendTests`. Do you have any idea why

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

phosek added a comment. In D96033#2766372 , @v.g.vassilev wrote: > In D96033#2766332 , @phosek wrote: > >> We've started seeing `LLVM ERROR: out of memory` on our 2-stage LTO Linux >> builders after this change la

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

phosek added a comment. In D96033#2767884 , @teemperor wrote: > In D96033#2766502 , @phosek wrote: > >> In D96033#2766372 , @v.g.vassilev >> wrote: >> >>> In D96033#2766332

[PATCH] D101479: [Driver] Support libc++ in MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rGb604301be355: [Driver] Support libc++ in MSVC (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D1014

[PATCH] D103477: [Fuchsia] Add compat multilibs to cache file

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103477/new/ https://reviews.llvm.org/D103477 ___

[PATCH] D103547: Don't delete the module you're inspecting

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103547/new/ https://reviews.llvm.org/D103547 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements

phosek added inline comments. Comment at: compiler-rt/lib/hwasan/CMakeLists.txt:45 +if (NOT FUCHSIA) + append_list_if(COMPILER_RT_HWASAN_WITH_INTERCEPTORS HWASAN_WITH_INTERCEPTORS=1 HWASAN_DEFINITIONS) +else() mcgrathr wrote: > It might be better to force the v

[PATCH] D103555: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain

phosek created this revision. phosek added reviewers: mcgrathr, leonardchan, haowei, gulfem. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't use vcruntime, this makes our toolchain more hermet

[PATCH] D103555: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5dd421a3afa: [Fuchsia] Use libc++abi on Windows in Fuchsia toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

phosek added a comment. `OpenMP/tile_codegen_tile_for.cpp` is failing on all our bots, would it be possible to revert the change? FAIL: Clang :: OpenMP/tile_codegen_tile_for.cpp (9951 of 28034) TEST 'Clang :: OpenMP/tile_codegen_tile_for.cpp' FAILED

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek updated this revision to Diff 318257. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 Files: clang/docs/SourceBasedCodeCoverage.rst clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/LangOptions.h clang/include/clang/Bas

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:851 +return "csllvm"; + default: +llvm_unreachable("unknown instrumentation type"); vsk wrote: > If we add an instrumenta

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93668/new/ https://reviews.llvm.org/D93668 ___ c

[PATCH] D95154: [WIP][clang][Fuchsia] Add the *-fuchsia-gnu arch and multilibs

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:148 + + foreach(name i386;x86_64;aarch64;riscv64;x86_64_gnu;aarch64_gnu) +if(${name} MATCHES ".*_gnu$") I'd just iterate over full triples rather than doing the `.*_gnu` replac

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek marked an inline comment as done. phosek added a comment. @davidxl @vsk do you have any further comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94820/new/ https://reviews.llvm.org/D94820 ___ cfe-commits mailing list cfe-commits

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:17 +// RUN: %clang_cc1 -fprofile-instrument=clang -fprofile-list=%t-exclude-only.list -emit-llvm %s -o - | FileCheck %s --check-prefix=EXCLUDE + +unsigned i; davidxl wrote: > Can you

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:17 +// RUN: %clang_cc1 -fprofile-instrument=clang -fprofile-list=%t-exclude-only.list -emit-llvm %s -o - | FileCheck %s --check-prefix=EXCLUDE + +unsigned i; davidxl wrote: > phosek w

[PATCH] D95253: [clang][Fuchsia] Add relative-vtables + asan multilibs

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:220 .flag("+fno-exceptions")); + Multilibs.push_back(Multilib("relative-vtables+asan", {}

[PATCH] D94820: Support for instrumenting only selected files or functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG4edf35f11a9e: Support for instrumenting only selected files or functions (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D94820?vs=318257&id=319359#toc Repository: rG LLVM Git

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added a comment. In D94820#2523461 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/32075/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Thanks for the heads up, I suspect it m

[PATCH] D94820: Support for instrumenting only selected files or functions

phosek added inline comments. Comment at: clang/docs/UsersManual.rst:2271 +.. option:: -fprofile-list= + MaskRay wrote: > This can be added below `-fprofile-exclude-files=` I considered it but that's in the GCOV section and this flag only applies to the LLVM i

[PATCH] D94820: Support for instrumenting only selected files or functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb9eb1982980: Support for instrumenting only selected files or functions (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D94820?vs=319359&id=319444#toc Repository: rG LLVM Git

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 319493. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. In D76802#2524039 , @MaskRay wrote: > - `__llvm_prf_cnts` does not need to have a self link `SHF_LINK_ORDER`. > `__llvm_prf_data` linking to `__llvm_prf_cnts` suffices. This is on the > premise that only `__llvm_prf_data` may refe

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. @MaskRay does this look good to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 319762. phosek added a reviewer: MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/test/profile/instrprof-g

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. In D76802#2526483 , @MaskRay wrote: > Looks quite good. > > In D76802#2526382 , @phosek wrote: > >> @MaskRay does this look good to you? > > Looks like GNU ld has an infinite loop problem w.r

[PATCH] D95658: Make the profile-filter.c test compatible with 32-bit systems

phosek created this revision. phosek added reviewers: mgorny, davidxl, vsk. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This addresses PR48930. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95658 Files: cl

[PATCH] D95658: Make the profile-filter.c test compatible with 32-bit systems

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0217f1c7a31b: Make the profile-filter.c test compatible with 32-bit systems (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D87928: Provide -fsource-dir flag in Clang

phosek added a comment. I'm picking up this change again after D83154 landed. I did some tracing and it looks like `FileManager` already returns a relative path when relative path was passed to the compiler as you'd expect so I don't think we need to change any

[PATCH] D95753: [CoverageMapping] Don't absolutize source paths

phosek created this revision. phosek added reviewers: vsk, davidxl. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We currently always absolutize paths in coverage mapping. This is problematic for reproducibility and it poses a prob

[PATCH] D95753: [CoverageMapping] Don't absolutize source paths

phosek added a comment. @vsk @davidxl I'd be interested in your opinion. I've made this change unconditionally to match the compiler behavior in cases like debug info or `__FILE__` expansion, but I'm also happy to conditionalize it on a flag (for example `-f[no]-coverage-mapping-abspath`) if yo

[PATCH] D95772: [DebugInfo] Normalize paths by removing unnecessary dots

phosek created this revision. phosek added reviewers: dblaikie, jhenderson. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was suggested in https://reviews.llvm.org/D87657 as a better alternative which doesn't require having to

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 320398. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/test/profile/instrprof-gc-sections.c llvm/include/llvm/Transforms/Instrumentation.h llvm/incl

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. @MaskRay I saw on https://sourceware.org/bugzilla/show_bug.cgi?id=27259 that the infinite loop fix has been cherry picked into 2.36 branch so I updated the condition to `-fbinutils-version=2.36`. Is this OK to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D95753: [CoverageMapping] Don't absolutize source paths

phosek added a comment. In D95753#2534061 , @vsk wrote: > For context, the reason abspaths are used here is because users don't expect > coverage results to go missing if the build directory changes (e.g. given `cd > A; cc x.c; cd ../B; cc x.c`, the expe

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 320562. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/test/profile/instrprof-gc-sections.c llvm/include/llvm/Transforms/Instrumentation.h llvm/incl

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added a comment. In D76802#2534118 , @MaskRay wrote: > "prevents discarding" is not accurate in the context. `__llvm_prf_*` cannot > be discarded because C identifier name input sections are GC roots. > > Add "C identifier name input sections are G

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3e39f60b35: [InstrProfiling] Use !associated metadata for counters, data and values (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D768

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek added inline comments. Comment at: compiler-rt/test/profile/instrprof-gc-sections.c:30 +// RUN: llvm-nm -jgU %t | grep -vE "main|_start|_IO_stdin_used|__libc_.*" > %t.code.syms +// RUN: diff %t.nocode.syms %t.code.syms + MaskRay wrote: > This fails on my

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

phosek updated this revision to Diff 321015. Herald added a subscriber: mgorny. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76802/new/ https://reviews.llvm.org/D76802 Files: clang/lib/CodeGen/BackendUtil.cpp compiler-rt/test/CMakeLists.txt c

[PATCH] D76802: [InstrProfiling] Use !associated metadata for counters, data and values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97ba5cde5266: [InstrProfiling] Use !associated metadata for counters, data and values (authored by phosek). Repository: rG LLVM Github Monorepo C

[PATCH] D96000: Don't emit coverage mapping for excluded functions

phosek created this revision. phosek added reviewers: davidxl, vsk. Herald added a subscriber: wenlei. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a function or a file is excluded using -fprofile-list= option, don't emit cov

[PATCH] D96000: Don't emit coverage mapping for excluded functions

phosek updated this revision to Diff 321670. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96000/new/ https://reviews.llvm.org/D96000 Files: clang/lib/CodeGen/CodeGenPGO.cpp clang/test/CodeGen/profile-filter.c Index: clang/test/CodeGen/profile

[PATCH] D96000: Don't emit coverage mapping for excluded functions

phosek marked an inline comment as done. phosek added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:27 +// EXCLUDE: @__covrec_{{[0-9A-F]+}}u = linkonce_odr hidden constant <{ i64, i32, i64, i64, [{{.*}} x i8] }> <{ {{.*}} }>, section "__llvm_covfun" +// EXCLUD

[PATCH] D96000: Don't emit coverage mapping for excluded functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. phosek marked an inline comment as done. Closed by commit rG9fd9b5a9c9ec: Don't emit coverage mapping for excluded functions (authored by phosek). Repository: rG LLV

[PATCH] D109625: [compiler-rt] Ensure LIT_TEST_DEP targets are actually built

phosek added inline comments. Comment at: compiler-rt/test/CMakeLists.txt:48 + if (NOT TARGET ${dep}) +llvm_ExternalProject_BuildCmd(build_${dep} ${dep} ${BINARY_DIR}) +add_custom_target(${dep} This is going to run Ninja in the LLVM build onc

[PATCH] D109977: LLVM Driver Multicall tool

phosek added inline comments. Comment at: llvm/tools/llvm-driver/CMakeLists.txt:17 + +add_llvm_tool(llvm-driver + llvm-driver.cpp As was already suggested on D104686, I'd prefer naming this just `llvm` so you can invoke tools with `llvm name` which doesn't requ

[PATCH] D91944: OpenMP 5.0 metadirective

phosek added a comment. We started seeing a test failure in `Clang :: OpenMP/metadirective_device_kind_codegen.c` on our macOS bot after this change landed (we aren't seeing it on other systems): Script: -- : 'RUN: at line 1'; /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -cc1 -internal

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek created this revision. phosek added reviewers: MaskRay, mcgrathr. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When statically linking C++ standard library, we shouldn't add -Bdynamic after including the library on the link

[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

phosek added a comment. In D110142#3013138 , @MaskRay wrote: > Do you know why `--target=armv8l-unknown-linux-gnueabihf` picks > `armhf-unknown-linux-gnueabihf` instead of `armv8l-unknown-linux-gnueabihf`? > (For new tests, prefer `--target=` to `-target

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek updated this revision to Diff 374154. phosek marked 5 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/Tool

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

phosek added inline comments. Comment at: compiler-rt/test/CMakeLists.txt:48 + if (NOT TARGET ${dep}) +llvm_ExternalProject_BuildCmd(build_${dep} ${dep} ${BINARY_DIR}) +add_custom_target(${dep} leonardchan wrote: > leonardchan wrote: > > phos

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e28c892d06f: [Driver] Correctly handle static C++ standard library (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D11012

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek added a comment. Looks like the linker used on `clang-ppc64le-rhel` bot doesn't support `--push-state`/`--pop-state`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 __

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

phosek added a comment. In D89013#3017317 , @sylvestre.ledru wrote: > Building with this patch Debian packages is failing with: > > > "/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot-14~++20210922093928+5da21338bcd0/

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek added a comment. @MaskRay Do you think we should gate the use of this feature on `-fbinutils-version=` or `-fuse-ld=lld`? It'd be nice if the owner of `clang-ppc64le-rhel` builder could update the binutils version but I'm not sure how feasible is it. Repository: rG LLVM Github Monore

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek updated this revision to Diff 374690. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/Tool

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek updated this revision to Diff 374699. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110128/new/ https://reviews.llvm.org/D110128 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/fuchsi

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG03142c5f6778: [Driver] Correctly handle static C++ standard library (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D11012

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek added a comment. In D110128#3020468 , @nemanjai wrote: > In D110128#3018992 , @phosek wrote: > >> @MaskRay Do you think we should gate the use of this feature on >> `-fbinutils-version=` or `-fuse-ld=lld`?

[PATCH] D110463: [CMake] Pass through CMAKE_READELF to subbuilds

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a subscriber: mgorny. phosek requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This matches handling of other CMake var

<    4   5   6   7   8   9   10   11   12   13   >