[PATCH] D28772: [Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma in macro argument pre-expansion mode when skipping a function body

arphaman added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D28772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

madsravn updated this revision to Diff 89543. madsravn added a comment. Updated the code based on comments received. https://reviews.llvm.org/D30158 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp

[PATCH] D29542: [TargetInfo] Adjust x86-32 atomic support to the CPU used

mgorny added inline comments. Comment at: test/CodeGen/atomic-ops.c:1 -// RUN: %clang_cc1 %s -emit-llvm -o - -ffreestanding -ffake-address-space-map -triple=i686-apple-darwin9 | FileCheck %s +// RUN: %clang_cc1 %s -emit-llvm -o - -ffreestanding -ffake-address-space-map

[PATCH] D29812: Update template-id-expr.cpp test to work when compiler defaults to non-C++03 standard

dyung closed this revision. dyung added a comment. I forgot to add a reference to this in the commit message, so I'm closing this manually. This change was submitted with commit r296066. https://reviews.llvm.org/D29812 ___ cfe-commits mailing

[PATCH] D30241: AMDGPU: Add fmed3 half builtin

arsenm closed this revision. arsenm added a comment. r295874 https://reviews.llvm.org/D30241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

jbangert updated this revision to Diff 89420. jbangert marked an inline comment as done. jbangert added a comment. - additional tests https://reviews.llvm.org/D29621 Files: include/clang/Tooling/RefactoringCallbacks.h lib/Tooling/RefactoringCallbacks.cpp

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

zaks.anna added a comment. Could you please split the patch into two - one with the previously reviewed support for functions that take a single size value and another patch that models the two size arguments (num and size). It's easier to review patches if they do not grow new functionality.

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

jbangert accepted this revision. jbangert added a comment. Thanks, added tests for parser failures. https://reviews.llvm.org/D29621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

sbenza added inline comments. Comment at: lib/Tooling/RefactoringCallbacks.cpp:213 +llvm::errs() << "Node " << Element.Value + << " used in replacement template not bound in Matcher \n"; +llvm_unreachable("Unbound node in replacement

[PATCH] D30239: enable -flto=thin in clang-cl

inglorion updated this revision to Diff 89577. inglorion retitled this revision from "enable -flto=thin, -flto-jobs=, and -fthinlto-index= in clang-cl" to "enable -flto=thin in clang-cl". inglorion added a comment. Implemented @hans's suggestion of moving the tests into cl-options.c. Also

[PATCH] D29812: Update template-id-expr.cpp test to work when compiler defaults to non-C++03 standard

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D29812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30312: Fix unix.Malloc analysis crasher when allocating dynamic arrays w/unbound statements (fix PR32050)

kmarshall created this revision. The extent calculation function had a bug which caused it to ignore if the size value was defined prior to casting it. As a result, size expressions with free variables would trigger assertion failures during the cast operation. This patch adds that missing

[PATCH] D30326: [MS-ABI] Allow #pragma section to choose for ZI data

javed.absar created this revision. This patch enables the msvc pragma section to choose whether zero initialized variables are to be placed in data_seg or bss_seg. The current implementation ignores bss_seg directive for variables that are initialized (i.e. it does not check if the

[PATCH] D30327: [Sema] Improve side effect checking for unused-lambda-capture warning

malcolm.parsons created this revision. Don't warn about unused lambda captures that involve copying a value of a type that cannot be trivially copied and destroyed. Fixes PR31977 https://reviews.llvm.org/D30327 Files: include/clang/Sema/Sema.h lib/Sema/SemaLambda.cpp

[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

sammccall updated this revision to Diff 89632. sammccall added a comment. Report symbols by reference. https://reviews.llvm.org/D30210 Files: include-fixer/InMemorySymbolIndex.cpp include-fixer/InMemorySymbolIndex.h include-fixer/IncludeFixer.cpp include-fixer/SymbolIndex.h

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric updated this revision to Diff 89627. ioeric added a comment. - removed a debug message https://reviews.llvm.org/D30328 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h change-namespace/tool/ClangChangeNamespace.cpp

[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

hokein added a comment. Thanks, still LGTM with one nit. Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:262 + if (Filename != "") { +Reporter->reportSymbols(Filename, std::move(FileSymbols)); +FileSymbols = {}; We don't need `std::move`

[PATCH] D30158: [clang-tidy] modernize: Find usage of random_shuffle and replace it with shuffle.

malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.h:21 +/// std::random_shuffle will be removed as of C++17. This check will find and +/// replace all occurences of std::random_shuffle with std::shuffle. +/// Typo

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Comment at: change-namespace/tool/ClangChangeNamespace.cpp:78 +// changing namespaces around them. +constexpr const char *WhiteListedSymbolPatterns[] = {"^std::.*$"};

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric created this revision. https://reviews.llvm.org/D30328 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h change-namespace/tool/ClangChangeNamespace.cpp test/change-namespace/Inputs/fake-std.h test/change-namespace/white-list.cpp

[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

sammccall updated this revision to Diff 89636. sammccall added a comment. Remove redundant std::move https://reviews.llvm.org/D30210 Files: include-fixer/InMemorySymbolIndex.cpp include-fixer/InMemorySymbolIndex.h include-fixer/IncludeFixer.cpp include-fixer/SymbolIndex.h

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric updated this revision to Diff 89637. ioeric marked an inline comment as done. ioeric added a comment. - Make the whitelist an option. https://reviews.llvm.org/D30328 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric added a comment. PTAL Comment at: change-namespace/tool/ClangChangeNamespace.cpp:78 +// changing namespaces around them. +constexpr const char *WhiteListedSymbolPatterns[] = {"^std::.*$"}; + hokein wrote: > Maybe consider create a command-line option

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric updated this revision to Diff 89640. ioeric marked 2 inline comments as done. ioeric added a comment. - Addressed comments. https://reviews.llvm.org/D30328 Files: change-namespace/ChangeNamespace.cpp change-namespace/ChangeNamespace.h change-namespace/tool/ClangChangeNamespace.cpp

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

ioeric added inline comments. Comment at: change-namespace/tool/ClangChangeNamespace.cpp:82 + +llvm::ErrorOr GetWhiteListedSymbolPatterns() { + llvm::SmallVector Lines; hokein wrote: > Instead `std::vector`, maybe std::vector is

[PATCH] D28278: [StaticAnalyzer] dont show wrong 'garbage value' warning when there is array index out of bounds

danielmarjamaki updated this revision to Diff 89641. danielmarjamaki added a comment. Fixed review comment. Broke out function. Repository: rL LLVM https://reviews.llvm.org/D28278 Files: lib/StaticAnalyzer/Checkers/UndefResultChecker.cpp test/Analysis/uninit-vals-ps.c Index:

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

This revision was automatically updated to reflect the committed changes. Closed by commit rL296110: [change-namepsace] make it possible to whitelist symbols so they don't get… (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D30328?vs=89640=89643#toc Repository: rL

[PATCH] D30157: [analyzer] Improve valist check

danielmarjamaki added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:189 + const auto *EReg = dyn_cast_or_null(Reg); + return EReg && VaListModelledAsArray ? EReg->getSuperRegion() : Reg; +} I would personally recommend parentheses

[PATCH] D30328: [change-namepsace] make it possible to whitelist symbols so they don't get updated.

hokein added inline comments. Comment at: change-namespace/tool/ClangChangeNamespace.cpp:82 + +llvm::ErrorOr GetWhiteListedSymbolPatterns() { + llvm::SmallVector Lines; Instead `std::vector`, maybe std::vector is better, with that we

[PATCH] D30337: [clang-move] Extend clang-move to support moving global variable.

hokein updated this revision to Diff 89659. hokein added a comment. No accident changes. https://reviews.llvm.org/D30337 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/var_test.cpp test/clang-move/Inputs/var_test.h test/clang-move/move-var.cpp

[PATCH] D29757: [libcxx] Threading support: Externalize hardware_concurrency()

rmaprath updated this revision to Diff 89664. rmaprath added a comment. Different take on the patch: Externalize this function only for the externally-thread-api variant. This is much less intrusive. Note that I haven't added the declaration of `__libcpp_thread_hw_concurrency()` into

[PATCH] D29818: [libcxx] Threading support: Attempt to externalize system_clock::now() and steady_clock::now() implementations

rmaprath updated this revision to Diff 89665. rmaprath added a comment. Different approach: Externalize these functions only for the external-thread-api library variant. (Similar to https://reviews.llvm.org/D29757) https://reviews.llvm.org/D29818 Files: src/chrono.cpp Index:

[PATCH] D30337: [clang-move] Extend clang-move to support moving global variable.

hokein created this revision. Also support dumping global variables. https://reviews.llvm.org/D30337 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/var_test.cpp test/clang-move/Inputs/var_test.h test/clang-move/move-var.cpp unittests/clang-move/ClangMoveTests.cpp Index:

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

dtzWill accepted this revision. dtzWill added a comment. This revision is now accepted and ready to land. Sorry for the delay! LGTM, thanks! https://reviews.llvm.org/D29369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

This revision was automatically updated to reflect the committed changes. Closed by commit rL296214: [ubsan] Detect signed overflow UB in remainder operations (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29437?vs=89734=89753#toc Repository: rL LLVM

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

This revision was automatically updated to reflect the committed changes. Closed by commit rL296213: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D29369?vs=89733=89752#toc Repository: rL

[PATCH] D30375: Function with unparsed body is a definition

sepavloff created this revision. While a function body is being parsed, the function declaration is not considered as a definition because it does not have a body yet. In some cases it leads to incorrect interpretation, the case is presented in https://bugs.llvm.org/show_bug.cgi?id=14785:

[PATCH] D30341: [analyzer] clarify error messages about uninitialized function arguments

danielmarjamaki created this revision. This patch clarify the error messages about uninitialized function arguments. It can be really hard to see the problem if there are 10-20 arguments like: printf("debug:", a, b.c, d, e, ...); with no info about which argument is uninitialized and

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL296136: [libcxxabi] Disable calls to fprintf for baremetal targets. (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D30339?vs=89674=89681#toc Repository: rL LLVM

[PATCH] D30340: [libunwind] Disable calls to fprintf when building for baremetal targets in release mode

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30340: [libunwind] Disable calls to fprintf when building for baremetal targets in release mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL296135: [libunwind] Disable calls to fprintf for baremetal targets. (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D30340?vs=89676=89679#toc Repository: rL LLVM

[PATCH] D30337: [clang-move] Extend clang-move to support moving global variable.

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg https://reviews.llvm.org/D30337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30339: Disable calls to fprintf when building for baremetal targets in release mode

rs created this revision. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is dependent on io functions, this patch disable calls to fprintf when building for baremetal targets in release mode. https://reviews.llvm.org/D30339 Files:

[PATCH] D30340: [libunwind] Disable calls to fprintf when building for baremetal targets in release mode

rs created this revision. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is dependent on io functions, this patch disable calls to fprintf when building for baremetal targets in release mode. https://reviews.llvm.org/D30340 Files:

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

EricWF added a comment. isn't this incorrect because `config.h` always defines LIBCXX_BAREMETAL? Repository: rL LLVM https://reviews.llvm.org/D30339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

jroelofs added a comment. In https://reviews.llvm.org/D30339#685919, @rmaprath wrote: > Perhaps change `config.h` and remove the definition there and adjust other > places accordingly? > > The current form is very easy to trip over. Eric's point is that LIBCXXABI_BAREMETAL is a 0/1 flag, not

[PATCH] D30025: [compiler-rt] [builtins] Fix building atomic.c with GCC

mgorny added a reviewer: doug.gregor. mgorny added a subscriber: doug.gregor. mgorny added a comment. If I read the git correctly, the change that forbid defining builtins was initially made in https://reviews.llvm.org/rL64639. @doug.gregor, any chance you could help us over here? Is clang

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

This revision was automatically updated to reflect the committed changes. Closed by commit rL296146: [libcxxabi] Fix condition typo in rL296136 (authored by rsingh). Changed prior to commit: https://reviews.llvm.org/D30343?vs=89687=89693#toc Repository: rL LLVM

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

arphaman created this revision. This patch refactors the code figures out which block captures need to be copied/destroyed using special copy/destroy code. This is a preparation patch for work on merging block copy/destroy routines. Thanks for taking a look! Repository: rL LLVM

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

rmaprath added a comment. Perhaps change `config.h` and remove the definition there and adjust other places accordingly? The current form is very easy to trip over. Repository: rL LLVM https://reviews.llvm.org/D30339 ___ cfe-commits mailing

[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

efriedma added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:2380 + CGF.SanOpts.has(SanitizerKind::SignedIntegerOverflow)) && + Ops.Ty->isIntegerType()) { CodeGenFunction::SanitizerScope SanScope(); I don't think you need the

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

jroelofs added a comment. In https://reviews.llvm.org/D30339#685888, @EricWF wrote: > isn't this incorrect because `config.h` always defines LIBCXX_BAREMETAL? Oh, right, it needs to be: #if !LIBCXXABI_BAREMETAL || !defined(NDEBUG) Repository: rL LLVM https://reviews.llvm.org/D30339

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

rs created this revision. Made a mistake in the condition typo because LIBCXXABI_BAREMETAL is always defined, I should have been checking the contents to see if it's enabled https://reviews.llvm.org/D30343 Files: src/abort_message.cpp Index: src/abort_message.cpp

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

rs added a comment. Ah sorry for the mistake. Fix is here https://reviews.llvm.org/D30343 Repository: rL LLVM https://reviews.llvm.org/D30339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28772: [Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma in macro argument pre-expansion mode when skipping a function body

This revision was automatically updated to reflect the committed changes. Closed by commit rL296140: [Preprocessor] Fix incorrect token caching that occurs when lexing _Pragma (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D28772?vs=87801=89688#toc Repository: rL

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

rs added a comment. Going for post-commit. https://reviews.llvm.org/D30343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30009: Add support for '#pragma clang attribute'

arphaman added inline comments. Comment at: include/clang/Basic/Attr.td:308-311 + // - An attribute requires delayed parsing (LateParsed is on) + // - An attribute has no GNU/CXX11 spelling + // - An attribute has no subject list + // - An attribute derives from a StmtAttr

[PATCH] D30316: AMDGPU: Make 0 the private nullptr value

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! I assume you will make corresponding changes in backend. https://reviews.llvm.org/D30316 ___ cfe-commits mailing list

[PATCH] D30378: [DebugInfo] [DWARFv5] Collect calling convention info for C++ types during codegen

vleschuk created this revision. When generating debug info collect information on calling convention for types (http://www.dwarfstd.org/ShowIssue.php?issue=141215.1) and pass it to backend. https://reviews.llvm.org/D30378 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h

[PATCH] D29685: Lit C++11 Compatibility - Function Attributes

tigerleapgorge accepted this revision. tigerleapgorge added a comment. This revision is now accepted and ready to land. Of the 3 tests. format-strings.cpp and printf-cstr.cpp have been commited in r294979 For warn-thread-safety-parsing.cpp, bug 32066 has been filed to track the lack of thread

[PATCH] D20710: Lit C++11 Compatibility Patch #9

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D20710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

EricWF added a comment. This works for me, but the idiomatic macro usage in libc++, and (hopefully) libc++abi should always use `defined(FOO)` as opposed to `!FOO`. I'll clean this up in the next week if nobody else wants to. Repository: rL LLVM https://reviews.llvm.org/D30343

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

EricWF added a comment. In https://reviews.llvm.org/D30339#685921, @jroelofs wrote: > In https://reviews.llvm.org/D30339#685919, @rmaprath wrote: > > > Perhaps change `config.h` and remove the definition there and adjust other > > places accordingly? > > > > The current form is very easy to

[PATCH] D30316: AMDGPU: Make 0 the private nullptr value

arsenm added a comment. In https://reviews.llvm.org/D30316#686174, @yaxunl wrote: > AMDGPUTargetMachine::getNullPointerValue needs also be changed to match > this, otherwise the static initializer will be incorrect for null pointer to > private addr space. Do you plan to change that? Yes,

[PATCH] D20710: Lit C++11 Compatibility Patch #9

This revision was automatically updated to reflect the committed changes. Closed by commit rL296184: [Test] Make Lit tests C++11 compatible #9 (authored by lcharles). Changed prior to commit: https://reviews.llvm.org/D20710?vs=87309=89728#toc Repository: rL LLVM

[PATCH] D21626: Lit C++11 Compatibility Patch #10

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with a couple of changes. Comment at: test/Modules/Inputs/merge-using-decls/a.h:25 +#if __cplusplus <= 199711L // C++11 does not allow access declerations template

[PATCH] D30316: AMDGPU: Make 0 the private nullptr value

arsenm added a comment. In https://reviews.llvm.org/D30316#686089, @yaxunl wrote: > LGTM. Thanks! I assume you will make corresponding changes in backend. This is to match r295891, so then https://reviews.llvm.org/D28937 is required to fix addrspacecast https://reviews.llvm.org/D30316

[PATCH] D30345: [CodeGen][Blocks] Refactor capture handling in code that generates block copy/destroy routines

vsk added a comment. Looks NFC to me. Comment at: lib/CodeGen/CGBlocks.cpp:1414 + +} // end anonymous namespace + I don't see the need for two GenericInfo types (although it's plausible it'll make sense with your upcoming changes!). I had in mind a single

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added a comment. Sounds good, I will commit https://reviews.llvm.org/D26061 and split out the tests from this (https://reviews.llvm.org/D28952). https://reviews.llvm.org/D28952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

This revision was automatically updated to reflect the committed changes. Closed by commit rL296242: [analyzer] Refactor and simplify SimpleConstraintManager (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26061?vs=89054=89773#toc Repository: rL LLVM

[PATCH] D30289: [Analyzer] Add bug visitor for taint checker

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Looks great! https://reviews.llvm.org/D30289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29419: [Analyzer] Checker for mismatched iterators

zaks.anna added a comment. > So it would be a wast of resources to duplicate these data. So now I am > also working on the merged version. Would it make sense to just resume the review on the merged patch? https://reviews.llvm.org/D29419 ___

[PATCH] D28278: [StaticAnalyzer] dont show wrong 'garbage value' warning when there is array index out of bounds

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thank you! Repository: rL LLVM https://reviews.llvm.org/D28278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30341: [analyzer] clarify error messages about uninitialized function arguments

zaks.anna added a comment. I agree this can clarify the error message quite a bit! Comment at: lib/StaticAnalyzer/Checkers/CallAndMessageChecker.cpp:160 if (ParamDecl->getType()->isPointerType()) { -Message = "Function call argument is a pointer to uninitialized value";

[PATCH] D28348: [analyzer] Taught the analyzer about Glib API to check Memory-leak

zaks.anna added a comment. > Firstly I uploaded Glib-MallocChecker-single-size-value.patch for code > review, if submitted to UPSTREAM, then upload another one, correct? Yes. By the way, you can model XXX_n variants similarly to how calloc is modeled (see CallocMem).

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc updated this revision to Diff 89777. ddcc added a comment. Drop tests, move to https://reviews.llvm.org/D30373 https://reviews.llvm.org/D28952 Files: CMakeLists.txt cmake/modules/FindZ3.cmake include/clang/Config/config.h.cmake include/clang/StaticAnalyzer/Core/Analyses.def

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

vsk updated this revision to Diff 89733. vsk added a comment. - Make the suggested readability improvements, and fix a comment in the test case. https://reviews.llvm.org/D29369 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/compound-assign-overflow.c

[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

vsk updated this revision to Diff 89734. vsk added a comment. - Add a small test that shows why the 'isIntegerType' check is required (we'd crash otherwise). https://reviews.llvm.org/D29437 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/ubsan-promoted-arith.cpp Index:

[PATCH] D29437: [ubsan] Detect signed overflow UB in remainder operations

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D29437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21626: Lit C++11 Compatibility Patch #10

tigerleapgorge updated this revision to Diff 89736. tigerleapgorge added a comment. Updated patch in accordance to Richard Smith's comments. https://reviews.llvm.org/D21626 Files: test/Modules/Inputs/merge-using-decls/b.h test/Modules/merge-using-decls.cpp test/SemaCXX/PR9572.cpp

[PATCH] D30316: AMDGPU: Make 0 the private nullptr value

yaxunl added a comment. AMDGPUTargetMachine::getNullPointerValue needs also be changed to match this, otherwise the static initializer will be incorrect for null pointer to private addr space. Do you plan to change that? https://reviews.llvm.org/D30316

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Dominic, this (https://reviews.llvm.org/D28952) and https://reviews.llvm.org/D26061 look get to me! Let's get these two committed! We'd like to get to a place where in-tree incremental

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

jbangert updated this revision to Diff 89730. jbangert marked an inline comment as done. jbangert added a comment. use llvm::report_fatal_error instead of unreachable. https://reviews.llvm.org/D29621 Files: include/clang/Tooling/RefactoringCallbacks.h lib/Tooling/RefactoringCallbacks.cpp

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

jbangert added inline comments. Comment at: lib/Tooling/RefactoringCallbacks.cpp:213 +llvm::errs() << "Node " << Element.Value + << " used in replacement template not bound in Matcher \n"; +llvm_unreachable("Unbound node in replacement

[PATCH] D29972: Make Lit tests C++11 compatible - accessible destructors

tigerleapgorge abandoned this revision. tigerleapgorge added a comment. https://reviews.llvm.org/D20710 is a superset of this patch. https://reviews.llvm.org/D20710 has been committed in https://reviews.llvm.org/rL296184. No need for this patch. https://reviews.llvm.org/D29972

[PATCH] D21626: Lit C++11 Compatibility Patch #10

tigerleapgorge marked 2 inline comments as done. tigerleapgorge added inline comments. Comment at: test/SemaCXX/PR9572.cpp:34 +// expected-error@-2 {{non-deleted function '~Bar' cannot override a deleted function}} +// expected-note@-3 {{while declaring the implicit destructor

[PATCH] D21626: Lit C++11 Compatibility Patch #10

This revision was automatically updated to reflect the committed changes. Closed by commit rL296193: [Test] Make Lit tests C++11 compatible #10 (authored by lcharles). Changed prior to commit: https://reviews.llvm.org/D21626?vs=89736=89737#toc Repository: rL LLVM

[PATCH] D29685: Lit C++11 Compatibility - Function Attributes

tigerleapgorge closed this revision. tigerleapgorge added a comment. warn-thread-safety-parsing.cpp has been commited in https://reviews.llvm.org/rL296193. The following FIXME has been added to track this bug. //FIXME: Bug 32066 - Error should be emitted irrespective of C++ dialect

[PATCH] D30285: [ubsan] Don't check alignment if the alignment is 1

filcab accepted this revision. filcab added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D30285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30239: enable -flto=thin, -flto-jobs=, and -fthinlto-index= in clang-cl

inglorion added a comment. @mehdi_amini: > Is clang-cl using lld as default? How is the switch done? Ideally we should > have a nice error message from the driver if -flto is used without lld. I believe we use link.exe by default. You can use lld by passing -fuse-ld=lld to the compiler. I

[PATCH] D30239: enable -flto=thin, -flto-jobs=, and -fthinlto-index= in clang-cl

hans added a comment. In https://reviews.llvm.org/D30239#683697, @inglorion wrote: > @mehdi_amini: > > > Is clang-cl using lld as default? How is the switch done? Ideally we should > > have a nice error message from the driver if -flto is used without lld. > > I believe we use link.exe by

[PATCH] D30290: [libcxx][zorg] Fix no-exceptions builder configurations

rengolin added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:1196 +lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl -L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'}, +

[PATCH] D30290: [libcxx][zorg] Fix no-exceptions builder configurations

rengolin added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:1196 +lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl -L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'}, +

[PATCH] D30289: [Analyzer] Add bug visitor for taint checker

vlad.tsyrklevich updated this revision to Diff 89497. vlad.tsyrklevich marked 2 inline comments as done. vlad.tsyrklevich added a comment. Fixes and a test for Artem's suggestions. https://reviews.llvm.org/D30289 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp

[PATCH] D30290: [libcxx][zorg] Fix no-exceptions builder configurations

rmaprath marked an inline comment as done. rmaprath added a comment. Thanks! Committed as r295963. @gkistanova: Could you please let me know when the next restart is due? I would like to keep an eye on the builders. Cheers, / Asiri Repository: rL LLVM https://reviews.llvm.org/D30290

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

danielmarjamaki created this revision. The error messages are confusing when shift result is undefined because the shift count is negative or exceeds the bit width. I have seen that users often draw the conclusion that Clang thinks some operand is uninitialized and determine that Clang shows a

[PATCH] D30290: [libcxx][zorg] Fix no-exceptions builder configurations

rmaprath marked an inline comment as done. rmaprath added inline comments. Comment at: buildbot/osuosl/master/config/builders.py:1196 +lit_extra_opts={'link_flags': '"-lc++abi -lc -lm -lpthread -ldl -L/opt/llvm/lib/clang/3.9.0/lib/linux -lclang_rt.builtins-armhf"'},

[PATCH] D30289: [Analyzer] Add bug visitor for taint checker

vlad.tsyrklevich created this revision. Add a bug visitor to the taint checker to make it easy to distinguish where the tainted value originated. This is especially useful when the original taint source is obscured by complex data flow. https://reviews.llvm.org/D30289 Files:

[PATCH] D30290: [libcxx][zorg] Fix no-exceptions builder configurations

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM, thanks! I'll add a local task to look into that, but with Connect coming, I'm not sure how long that will take. :) https://reviews.llvm.org/D30290

<    11   12   13   14   15   16   17   18   19   20   >