[PATCH] D27985: Add demangling support for C++11 thread_local variables

davidb closed this revision. davidb added a comment. Closed by revision r293638. Repository: rL LLVM https://reviews.llvm.org/D27985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29393: [clang-tidy] Don't warn about call to unresolved operator*

malcolm.parsons created this revision. Herald added a subscriber: JDevlieghere. The misc-unconventional-assign-operator check had a false positive warning when the 'operator*' in 'return *this' was unresolved. Change matcher to allow calls to unresolved operator. Fixes PR31531.

[PATCH] D24969: [Sema] Use the instantiated name of destructors in FindInstantiatedDecl and RebuildMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL293678: [Sema] Transform a templated name before looking it up in (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D24969?vs=82134=86474#toc Repository: rL LLVM

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

erichkeane created this revision. As we know, MSVC is pretty relaxed when it comes to 'typename'. Clang so far does a pretty darn good job of permitting the behavior, however there was 1 missed case that compiles in MSVC (as of 2015), but not in clang. I've updated the test for similar ones

[PATCH] D29401: Fix MSVC Compatibility around dependent type with missing 'typename'

erichkeane added a comment. Some quick line-comments here. Comment at: lib/Parse/ParseStmt.cpp:186 // found. -if (Next.isNot(tok::coloncolon)) { +if (Next.isNot(tok::coloncolon) && (!getLangOpts().MSVCCompat || +Next.isNot(tok::less))) {

[PATCH] D29267: [clang-tidy] safety-no-assembler

JonasToth added a comment. out of curiousity: i would like to contribute to the safety module as well. but currently there is no starting point in master. is there a way to get some code that i can start with? I think the module file where the registration happens would be enough. this is not

[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

djasper closed this revision. djasper added a comment. Submitted as r294179. Sorry I missed this before. https://reviews.llvm.org/D24703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29451: Add a prototype for clangd v0.1

arphaman added a comment. This might be a bad question, but is there any particular reason why you didn't use the YAML Traits API for parsing instead of the raw YAML Stream API? In my experience the traits based API is quite convenient for structured data like various options and parameters in

[PATCH] D29267: [clang-tidy] safety-no-assembler

JonasToth added a comment. alright :) https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29267: [clang-tidy] safety-no-assembler

JonasToth added a comment. In https://reviews.llvm.org/D29267#667614, @jbcoe wrote: > @alexfh Can we defer moving this to a compiler diagnostic? I'm keen to get a > target in place for people to write more safety checks. +1 from me :) and assembler might be bad style, but is it worth a

[PATCH] D29267: [clang-tidy] safety-no-assembler

idlecode added a comment. LGTM. HIC++ Standard seems worth implementing. https://reviews.llvm.org/D29267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

arphaman added a comment. I feel like you should have at least one statement in the test that uses explicit 'this' to access a field/method. Does your patch handle fields/methods in base classes as well? I think 'this' might be implicitly converted in the base of the member expression. Also,

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 87362. smeenai edited the summary of this revision. smeenai added a comment. Addressing comments https://reviews.llvm.org/D26949 Files: include/__cxxabi_config.h src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

phosek updated this revision to Diff 87339. Repository: rL LLVM https://reviews.llvm.org/D26654 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === --- /dev/null +++

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper updated this revision to Diff 87361. bmharper added a comment. This looks a lot better IMO. Thanks @daphnediane - you should recognize the code ;) The special closing paren logic inside of nestingAndIndentLevel() is indeed redundant now. https://reviews.llvm.org/D21279 Files:

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai added inline comments. Comment at: src/abort_message.cpp:25 -#pragma GCC visibility push(hidden) - EricWF wrote: > Is this really redundant? There is an `#include ` > after it. Is this not going to affect those symbols? That's a fair point. I think

[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

vsk updated this revision to Diff 87334. vsk edited the summary of this revision. vsk added a comment. @arphaman thank you for the feedback! Per Alex's comments: - Add test for explicit use of the 'this' pointer. - Handle cases where the 'this' pointer may be casted (implicitly, or otherwise).

[PATCH] D29162: AMDGPU: Add a test checking alignments of emitted globals/allocas

arsenm closed this revision. arsenm added a comment. r294278 https://reviews.llvm.org/D29162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29545: Driver: Do not link safestack with --whole-archive.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294274: Driver: Do not link safestack with --whole-archive. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D29545?vs=87106=87358#toc Repository: rL LLVM

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

jbangert created this revision. This is the first change as part of developing a clang-query based search and replace tool. https://reviews.llvm.org/D29621 Files: include/clang/Tooling/RefactoringCallbacks.h lib/Tooling/RefactoringCallbacks.cpp

[PATCH] D27810: Normalize all filenames before searching FileManager caches

erikjv updated this revision to Diff 87376. erikjv added a comment. Fixed all failing tests on Windows. https://reviews.llvm.org/D27810 Files: lib/Basic/FileManager.cpp lib/Basic/VirtualFileSystem.cpp lib/StaticAnalyzer/Core/BugReporterVisitors.cpp test/CodeGen/debug-prefix-map.c

[PATCH] D29622: Add a batch query and replace tool based on AST matchers.

jbangert created this revision. Herald added a subscriber: mgorny. This requires https://reviews.llvm.org/D29613. It adds a new tool, clang-query-replace that replaces and AST node with the result of evaluating a simple template language. https://reviews.llvm.org/D29622 Files:

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

dylanmckay added inline comments. Comment at: test/CodeGen/avr/attributes/interrupt.c:3 + +// CHECK: define void @foo() #0 +__attribute__((interrupt)) void foo(void) { } aaron.ballman wrote: > dylanmckay wrote: > > aaron.ballman wrote: > > > As should this. > >

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

dylanmckay updated this revision to Diff 87365. dylanmckay marked 4 inline comments as done. dylanmckay added a comment. Remove 'Attr.setInvalid()' https://reviews.llvm.org/D28451 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/TargetInfo.cpp

[PATCH] D29622: Add a batch query and replace tool based on AST matchers.

klimek added inline comments. Comment at: clang-query/QueryReplace.cpp:50 + +void QueryReplaceTool::addOperation(clang::query::QueryReplaceSpec ) { + ast_matchers::dynamic::Diagnostics Diag; Shouldn't that also just return the error? Comment

[PATCH] D29135: [libcxx] [test] Fix Clang -Wunused-local-typedef, part 1/3.

EricWF added a comment. Since all of these changes are for libc++ specific tests I would much rather see changes of this form: #if defined(_LIBCPP_VERSION) { typedef foo bar; static_assert(baz, ""); } #endif I think that's a lot nicer than wrapping every statement in the block

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

daphnediane added a comment. In https://reviews.llvm.org/D21279#663670, @bmharper wrote: > Thanks - the merge conflicts don't look too bad. I should have it cleaned up > by tomorrow. Have you had a chance to do the merge yet? If not I have a merged version which passes the tests that I could

[PATCH] D29550: Diagnose when "future_error(error_code)" constructor is called by user code

EricWF created this revision. The constructor `future_error(error_code)` isn't part of the C++ standard, but libc++ provides it in order to construct `future_error`'s before C++17. However since it's non-standard we probably shouldn't be providing it all. We could make the constructor private

[PATCH] D24703: [clang-format] BreakBeforeBinaryOperations and AlignAfterOpenBracket conflict, bug 30304

daphnediane added a comment. ping. I've been using this for a long time and still seems to apply to cleanly and works, though the line numbers have shifted a little since I generated the previous diff. https://reviews.llvm.org/D24703 ___

[PATCH] D29557: [clang-tools-extra] Fix pthread link

EricWF created this revision. Herald added a subscriber: mgorny. This patch contains the clang-tools-extra changes required by https://reviews.llvm.org/D29555 https://reviews.llvm.org/D29557 Files: include-fixer/plugin/CMakeLists.txt Index: include-fixer/plugin/CMakeLists.txt

[PATCH] D29622: Add a batch query and replace tool based on AST matchers.

ioeric added inline comments. Comment at: clang-query/QueryReplace.cpp:1 +#include "QueryReplace.h" +#include "QueryParser.h" Please add license header. Comment at: clang-query/QueryReplace.cpp:37 + +llvm::ErrorOr

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

djasper accepted this revision. djasper added a comment. This looks very nice now :-D. Thanks for working on this!! Comment at: lib/Format/WhitespaceManager.cpp:196 + + // ScopeStack keeps track of the current scope depth. + // We only run the "Matches" function on tokens

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

rmaprath created this revision. Different platforms implement the wait/sleep behaviour in very different ways. It makes sense to hoist this functionality into the threading API. I also feel similarly about `hardware_concurrecy()` implementation. Any thoughts on that?

[PATCH] D28451: [AVR] Add support for the 'interrupt' and 'naked' attributes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D28451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29386: Clzero flag addition and inclusion under znver1

GGanesh updated this revision to Diff 87386. GGanesh added a comment. Updated for review comments. Repository: rL LLVM https://reviews.llvm.org/D29386 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets.cpp lib/Headers/CMakeLists.txt

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

krasimir added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2207 +const FormatToken* NextTok) { bool CommentsInCurrentLine = true; + int StartOfSectionAlignedWithNextToken = -1; Need to add comments about this if we decide we may go

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

klimek added a comment. I think this looks pretty good. More comments would help :) Also, organize is spelled with a 'z' in American. https://reviews.llvm.org/D29626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29451: Add a prototype for clangd v0.1

krasimir added inline comments. Comment at: test/clangd/formatting.txt:9 +# CHECK: {"jsonrpc":"2.0","id":0,"result":{"capabilities":{ +# CHECK: "textDocumentSync": 1, +# CHECK: "documentFormattingProvider": true, bkramer wrote: > djasper wrote:

[PATCH] D29628: [compiler-rt] [test] Enable the strace_test only if strace is installed

mgorny created this revision. Herald added a subscriber: dberris. Check whether strace is to be found in PATH, and control the strace_test appropriately. This fixes a test failure when strace is not installed. Repository: rL LLVM https://reviews.llvm.org/D29628 Files:

[PATCH] D29634: clang-format: [JS] exclaim preceding regex literals.

mprobst created this revision. Herald added a subscriber: klimek. Regex detection would incorrectly classify a trailing `!` operator (nullability cast) followed by a `/` as the start of a regular expression literal. This fixes code such as: var foo = x()! / 10; Which would previously parse a

[PATCH] D29221: clang-format-vsix: "format on save" feature

klimek added a reviewer: hans. klimek added a comment. +hans +1 to "format only current document but save all" not making much sense :) Comment at: tools/clang-format-vs/ClangFormat/TypeConverterUtils.cs:7 +{ +public sealed class TypeConverterUtils +{

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

krasimir added a comment. I feel that this is a bit too rough now; any suggestions on improving the architecture/design of this patch are welcome! Comment at: lib/Format/UnwrappedLineParser.cpp:2206 +const SmallVectorImpl , +const FormatToken* NextTok) { bool

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

krasimir updated this revision to Diff 87410. krasimir marked 6 inline comments as done. krasimir added a comment. - Address review comments. https://reviews.llvm.org/D29626 Files: lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTest.cpp Index:

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

rmaprath added inline comments. Comment at: include/__threading_support:593 + using namespace chrono; + milliseconds ms = duration_cast(ns); + if (ms.count() == 0 || ns > duration_cast(ms)) joerg wrote: > Use (ns + 99) so that the cast rounds up. So, this

[PATCH] D29386: Clzero flag addition and inclusion under znver1

RKSimon added a comment. Still missing a test in llvm\tools\clang\test\CodeGen\builtins-x86.c Repository: rL LLVM https://reviews.llvm.org/D29386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29634: clang-format: [JS] exclaim preceding regex literals.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294304: clang-format: [JS] exclaim preceding regex literals. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D29634?vs=87402=87417#toc Repository: rL LLVM

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

klimek added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2207-2208 +const FormatToken *NextTok) { + // Decides which comment tokens should be added to the current line and which + // should be added as comments before the next token. + //

[PATCH] D29451: Add a prototype for clangd v0.1

This revision was automatically updated to reflect the committed changes. Closed by commit rL294291: Add a prototype for clangd (authored by d0k). Changed prior to commit: https://reviews.llvm.org/D29451?vs=87226=87383#toc Repository: rL LLVM https://reviews.llvm.org/D29451 Files:

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

ioeric added inline comments. Comment at: lib/Tooling/RefactoringCallbacks.cpp:42 + void HandleTranslationUnit(ASTContext ) override { +for (const auto : Refactoring.Callbacks) { + Callback->getReplacements().clear(); Could you add a comment here

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

djasper added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2206 +const SmallVectorImpl , +const FormatToken* NextTok) { bool CommentsInCurrentLine = true; krasimir wrote: > Any suggestions on how to improve the code quality a bit if

[PATCH] D29634: clang-format: [JS] exclaim preceding regex literals.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D29634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29635: clang-format: [JS] handle parenthesized class expressions.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Thanks https://reviews.llvm.org/D29635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29635: clang-format: [JS] handle parenthesized class expressions.

djasper added a comment. Sorry.. Should have caught this in the initial review. Still looks good. https://reviews.llvm.org/D29635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28814: [OpenCL] Add missing address spaces in IR generation of Blocks

Anastasia closed this revision. Anastasia marked an inline comment as done. Anastasia added a comment. Committed in r 293286 https://reviews.llvm.org/D28814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29635: clang-format: [JS] handle parenthesized class expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294302: clang-format: [JS] handle parenthesized class expressions. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D29635?vs=87412=87416#toc Repository: rL LLVM

[PATCH] D29635: clang-format: [JS] handle parenthesized class expressions.

mprobst created this revision. Herald added a subscriber: klimek. In JavaScript, classes are expressions, so they can appear e.g. in argument lists. var C = foo(class { bar() { return 1; } }; https://reviews.llvm.org/D29635 Files: lib/Format/UnwrappedLineParser.cpp

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87408. aaboud marked 2 inline comments as done. aaboud added a comment. Addressed Adrian last comments. Added a LIT tests that covers all the macro kinds: 1. built-in (define) 2. command-line (define, include, undef) 3. main source (define, include, undef)

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.1

Anastasia added inline comments. Comment at: test/SemaOpenCL/logical-ops.cl:1-3 +// RUN: %clang_cc1 %s -verify -cl-std=CL1.1 -triple x86_64-unknown-linux-gnu +// RUN: %clang_cc1 %s -verify -cl-std=CL1.2 -triple x86_64-unknown-linux-gnu + arsenm wrote: >

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

joerg added inline comments. Comment at: include/__threading_support:367 + ts.tv_sec = ts_sec_max; + ts.tv_nsec = giga::num - 1; + } I don't think giga::num makes things any clear compared to just spelling it out. Comment at:

[PATCH] D29635: clang-format: [JS] handle parenthesized class expressions.

mprobst updated this revision to Diff 87412. mprobst added a comment. - Parse nested classes as child expressions. https://reviews.llvm.org/D29635 Files: lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTestJS.cpp Index:

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

krasimir updated this revision to Diff 87424. krasimir added a comment. - Moved method summary from the implementation to the declaration. https://reviews.llvm.org/D29626 Files: lib/Format/UnwrappedLineParser.cpp lib/Format/UnwrappedLineParser.h unittests/Format/FormatTest.cpp Index:

[PATCH] D29656: clang-format: [JS] correcly format object literal methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294315: clang-format: [JS] correcly format object literal methods. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D29656?vs=87456=87462#toc Repository: rL LLVM

[PATCH] D29027: [Stack Protection] Add remark for reasons why Stack Protection has been applied

jhenderson added a comment. Ping! https://reviews.llvm.org/D29027 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29038: [OpenCL] Accept logical NOT for pointer types in CL1.1

Anastasia closed this revision. Anastasia added a comment. Committed in r294313 https://reviews.llvm.org/D29038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29415: [Assembler] Inline assembly diagnostics test.

sanwou01 updated this revision to Diff 87461. sanwou01 added a comment. Update the tests. Note that the diagnostics for backend errors are missing the "instantiated into assembly here" messages. This is unfortunate but expected: the origin information is no longer available at this stage.

[PATCH] D17092: [X86] Add -mseparate-stack-seg

mlemay-intel updated this revision to Diff 87453. mlemay-intel added a comment. Removed the portions that are specific to 32-bit segmentation. I plan to resubmit those later as a separate patch. https://reviews.llvm.org/D17092 Files: include/clang/Driver/Options.td Index:

[PATCH] D29656: clang-format: [JS] correcly format object literal methods.

djasper accepted this revision. djasper added inline comments. This revision is now accepted and ready to land. Comment at: lib/Format/UnwrappedLineParser.cpp:1306 +// Could be a method inside of a braced list `{a() { return 1; }}`. +if (tryToParseBracedList()) {

[PATCH] D29656: clang-format: [JS] correcly format object literal methods.

mprobst created this revision. Herald added a subscriber: klimek. In JavaScript, object literals can contain methods: var x = { a() { return 1; }, }; Previously, clang-format always parsed nested {} inside a braced list as further braced lists. Special case this logic for JavaScript to

[PATCH] D23421: [Clang-tidy] CERT-MSC53-CPP (checker for std namespace modification)

falho added a comment. Unfortunately I wont have time to work on this check anymore... thank you for understanding! Repository: rL LLVM https://reviews.llvm.org/D23421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29643: [analyzer] Do not duplicate call graph nodes for function that has definition and forward declaration.

IvanSidorenko created this revision. Fix in call graph construction: don't build call graph node for callee function twice for functions with forward declarations. Maybe the same fix should be done and for VisitObjCMethodDecl. Unfortunately, I have not enough expertise in ObjC, so I did not

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2207-2208 +const FormatToken *NextTok) { + // Decides which comment tokens should be added to the current line and which + // should be added as

[PATCH] D29386: Clzero flag addition and inclusion under znver1

GGanesh updated this revision to Diff 87437. GGanesh added a comment. Updated the builtins test for "__builtin_ia32_clzero" Repository: rL LLVM https://reviews.llvm.org/D29386 Files: include/clang/Basic/BuiltinsX86.def include/clang/Driver/Options.td lib/Basic/Targets.cpp

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

klimek added inline comments. Comment at: lib/Format/UnwrappedLineParser.h:121-123 + // Comments specifies the sequence of comment tokens to analyze. They get + // either pushed to the current line or added to the comments before the next + // token. Given

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

sbenza added inline comments. Comment at: include/clang/Tooling/RefactoringCallbacks.h:61 +MatchFinder.addMatcher(Matcher, Callback); +Callbacks.emplace_back(Callback); + } Why emplace_back instead of push_back? Comment at:

[PATCH] D29622: Add a batch query and replace tool based on AST matchers.

sbenza added inline comments. Comment at: clang-query/QueryReplace.h:35-36 + + /// \brief Replacement text. %"identifier" will be substituted by the text of + /// an identifier. + std::string ToTemplate; klimek wrote: > This doesn't seem to come up in the

[PATCH] D28445: [Analyzer] Extend taint propagation and checking

a.sidorin added a comment. Hi Artem, Thank you for adding me, I missed this patch. I have few comments below. If you (and Vlad) can wait for two or three days, I will re-check the place I'm worrying about and post the results. Comment at:

[PATCH] D16135: Macro Debug Info support in Clang

aprantl added a comment. In https://reviews.llvm.org/D16135#669045, @aaboud wrote: > Addressed Adrian last comments. > Added a LIT tests that covers all the macro kinds: > > 1. built-in (define) > 2. command-line (define, include, undef) > 3. main source (define, include, undef) Checked the

[PATCH] D29644: [OpenMP] Pass -v to PTXAS if it was passed to the driver.

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. I'm fine with this. Repository: rL LLVM https://reviews.llvm.org/D29644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29661: [clang-tidy] Add -quiet option to suppress extra output

ehsan created this revision. Herald added a subscriber: JDevlieghere. This new flag instructs clang-tidy to not output anything except for errors and warnings. This makes it easier to script clang-tidy to run as part of external build systems. https://reviews.llvm.org/D29661 Files:

[PATCH] D29267: [clang-tidy] safety-no-assembler

aaron.ballman added a comment. There were review comments still outstanding when you commit the patch. Can you please address those post-commit? Repository: rL LLVM https://reviews.llvm.org/D29267 ___ cfe-commits mailing list

[PATCH] D21279: Fix some issues in clang-format's AlignConsecutive modes

bmharper added a comment. Thanks for all the code review work! I'm impressed by the quality standard maintained here. https://reviews.llvm.org/D21279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29716: [clang-format] Move OriginalPrefix from base to subclass.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29716: [clang-format] Move OriginalPrefix from base to subclass.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294457: [clang-format] Move OriginalPrefix from base to subclass. (authored by krasimir). Changed prior to commit: https://reviews.llvm.org/D29716?vs=87643=87653#toc Repository: rL LLVM

[PATCH] D28973: Supresses misc-move-constructor-init warning for const fields.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294459: [clang-tidy] Supresses misc-move-constructor-init warning for const fields. (authored by alexfh). Changed prior to commit: https://reviews.llvm.org/D28973?vs=87484=87655#toc Repository: rL

[PATCH] D29621: Add ASTMatchRefactorer and ReplaceNodeWithTemplate to RefactoringCallbacks

ioeric added inline comments. Comment at: lib/Tooling/RefactoringCallbacks.cpp:160 +llvm::Expected +ReplaceNodeWithTemplate::create(StringRef FromId, StringRef ToTemplate) { + std::vector ParsedTemplate; Is this covered in the test?

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

sbarzowski added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54 +// FIXME use DiagnosticIDs::Level::Note +diag(NoExceptRange.getBegin(), "in a function declared no-throw here:", DiagnosticIDs::Note) +<<

[PATCH] D29628: [compiler-rt] [test] Enable the strace_test only if strace is installed

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM, but please manually verify that the test runs if strace *is* available. Repository: rL LLVM https://reviews.llvm.org/D29628 ___ cfe-commits

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

nkakuev added a comment. Thanks for the response, Alex! The problem I tried to address in this patch was that notes in source files were "unsuppressing" warnings from third-party headers (this is what we were discussing in https://reviews.llvm.org/D26418#590417). But at this point, I no

[PATCH] D29209: Use copy.deepcopy instead of doing it manually.

This revision was automatically updated to reflect the committed changes. Closed by commit rL294350: Use copy.deepcopy instead of doing it manually. (authored by danalbert). Changed prior to commit: https://reviews.llvm.org/D29209?vs=85999=87507#toc Repository: rL LLVM

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54 +// FIXME use DiagnosticIDs::Level::Note +diag(NoExceptRange.getBegin(), "in a function declared no-throw here:", DiagnosticIDs::Note) +<<

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

EricWF added a comment. In https://reviews.llvm.org/D29630#670873, @rmaprath wrote: > Sorry for the delay, I've updated the patch with all the comments addressed. > > @EricWF: Got one question before I commit: The `sleep_for` function in the > dylib (`thread.cpp`) is now quite small. Is there a

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

rmaprath updated this revision to Diff 87669. rmaprath added a comment. Sorry for the delay, I've updated the patch with all the comments addressed. @EricWF: Got one question before I commit: The `sleep_for` function in the dylib (`thread.cpp`) is now quite small. Is there a particular reason

[PATCH] D29630: [libcxx] Threading support: externalize sleep_for()

rmaprath added a comment. In https://reviews.llvm.org/D29630#670876, @EricWF wrote: > In https://reviews.llvm.org/D29630#670873, @rmaprath wrote: > > > Sorry for the delay, I've updated the patch with all the comments addressed. > > > > @EricWF: Got one question before I commit: The `sleep_for`

[PATCH] D29699: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL294491: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py (authored by ehsan). Changed prior to commit: https://reviews.llvm.org/D29699?vs=87576=87673#toc Repository: rL LLVM

[PATCH] D28952: [analyzer] Add new Z3 constraint manager backend

ddcc added a comment. I added support for a callback field in lit's configuration (see https://reviews.llvm.org/D29684), which is used to execute each testcase for each supported constraint solver backends at runtime. I believe this resolves all remaining issues, except for the remaining two

[PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

rsmith added inline comments. Comment at: lib/Parse/ParseDecl.cpp:2702 DS.SetRangeStart(Tok.getLocation()); -DS.SetRangeEnd(SourceLocation()); +DS.SetRangeEnd(Tok.getLocation()); } This doesn't look right: this is a source range containing

[PATCH] D29685: Lit C++11 Compatibility - Function Attributes

tigerleapgorge created this revision. I am continuing to make Lit tests C++11 compatible. This patch contains 3 tests, previously in review https://reviews.llvm.org/D21626. First two tests involve printf format attributes. The third test involve thread safety attribute. Here are the descriptions

[PATCH] D29692: [clang-tidy] add check modernize-use-const-instead-of-define

AlexanderLanin created this revision. Herald added subscribers: JDevlieghere, mgorny. Suggestion for a new check that will warn on #defines that should rather be constant values. Const variables should be preferred as #define does not obey type checking and scope rules. Please feel free to

[PATCH] D29676: Enable -dump-deserialized-decls and -error-on-deserialized-decl for modules

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r294359. Repository: rL LLVM https://reviews.llvm.org/D29676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29647: [OpenMP] Extend CLANG target options with device offloading kind.

jlebar added inline comments. Comment at: lib/Driver/ToolChains.cpp:4902 + DeviceOffloadingKind == Action::OFK_Cuda) && + "The offloading kind is not OpenMP or CUDA."); Not sure this assertion message helps us much beyond what's already in the

<    2   3   4   5   6   7   8   9   10   11   >