philip.pfaffe added a comment.
Ping.
https://reviews.llvm.org/D49486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philip.pfaffe added a comment.
I had not, but it should work just as well!
https://reviews.llvm.org/D49486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philip.pfaffe added a comment.
You're right, my bad; I missed the fact that it's EP_OptimizerLast, which has
no equivalent in the new PM. Your implementation is actually correct here.
Did you run your test in a debug build?
Repository:
rC Clang
https://reviews.llvm.org/D52814
___
philip.pfaffe accepted this revision.
philip.pfaffe added a comment.
This revision is now accepted and ready to land.
LGTM, thank you!
Repository:
rC Clang
https://reviews.llvm.org/D52814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
philip.pfaffe abandoned this revision.
philip.pfaffe added a comment.
It looks like running clang will be good enough. I'm closing this for now!
https://reviews.llvm.org/D49486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
philip.pfaffe added a comment.
This generally looks sane. What will happen on windows though? Will it silently
fail?
Comment at: clang/include/clang/Basic/CodeGenOptions.h:292
+ /// List of dynamic shared object files to be loaded as pass plugins.
+ std::vector PassPlugins;
philip.pfaffe added a comment.
I'm not sure what the current state of plugins on windows is. They were broken
and disabled last time I worked on this, but that might've changed in the
meantime! Worth checking.
Comment at: clang/include/clang/Basic/CodeGenOptions.h:292
+ ///
philip.pfaffe accepted this revision.
philip.pfaffe added a comment.
This revision is now accepted and ready to land.
It would be good to check, since the bots won't! Otherwise this looks good.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56935/new/
https://reviews.llvm.org/D56935
_
philip.pfaffe accepted this revision.
philip.pfaffe added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61664/new/
https://reviews.llvm.org/D61664
philip.pfaffe added a comment.
Is this the right place in the pipeline to put the passes? The legacy PM
inserts the asan passes at EP_OptimizerLast, why not do the same thing?
Repository:
rC Clang
https://reviews.llvm.org/D52814
___
cfe-commits
philip.pfaffe added a comment.
Landed it for you in r352972. Thanks!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56935/new/
https://reviews.llvm.org/D56935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
philip.pfaffe added a comment.
I'd prefer not adding this kind of state to PassBuilder. `SplitColdCode` is
soemthing that refers to the construction of //one// particular pipeline, not
to pipeline-building in general. It should be an argument passed down through
the build*Pipeline calls.
CHAN
philip.pfaffe added a subscriber: beanz.
philip.pfaffe added a comment.
I fear you'll need to plan at least for new pm right now. Otherwise your change
will be obsolete in half a year. What is it really that LINK_X_INTO_TOOLS is
supposed to do? Effectively bake in something that's consumable by
philip.pfaffe accepted this revision.
philip.pfaffe added a comment.
This revision is now accepted and ready to land.
Nit aside, looks good!
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:179
- bool runOnFunction(Function &F) override;
- bool doIniti
philip.pfaffe created this revision.
philip.pfaffe added reviewers: mgorny, beanz, gottesmm.
Herald added a subscriber: bollu.
Out-of-tree tools trying to parse source files need the builtin headers
such as `stddef.h`. If the tool isn't installed together with clang, it
can't find them automatical
15 matches
Mail list logo
