Re: [PATCH] D11928: Small fixup

Prazek added inline comments. Comment at: include/clang/AST/VTableBuilder.h:54 @@ -53,3 +53,3 @@ - VTableComponent() { } + VTableComponent() = default; rnk wrote: Is this ctor used? It leaves Value uninitialized. Maybe we should delete it to ensure that

r245257 - Generating assumption loads of vptr after ctor call

Author: prazek Date: Mon Aug 17 18:33:49 2015 New Revision: 245257 URL: http://llvm.org/viewvc/llvm-project?rev=245257view=rev Log: Generating assumption loads of vptr after ctor call Generating call assume(icmp %vtable, %global_vtable) after constructor call for devirtualization purposes. For

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 32363. Prazek added a comment. Fix for the PR24479 http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGCall.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp

r245264 - Generating assumption loads of vptr after ctor call (fixed)

Author: prazek Date: Mon Aug 17 22:52:00 2015 New Revision: 245264 URL: http://llvm.org/viewvc/llvm-project?rev=245264view=rev Log: Generating assumption loads of vptr after ctor call (fixed) Generating call assume(icmp %vtable, %global_vtable) after constructor call for devirtualization

Re: r245267 - Revert Generating assumption loads of vptr after ctor call (fixed)

Confirm, the assertions are different from the last one. On Mon, Aug 17, 2015 at 11:45 PM, Justin Bogner via cfe-commits cfe-commits@lists.llvm.org wrote: Richard Smith rich...@metafoo.co.uk writes: Are you sure it was this change and not r245265? Pretty sure - I ran the crash repro script

Re: r245264 - Generating assumption loads of vptr after ctor call (fixed)

Thanks. I have no idea what happen, but I will fix it tomorrow. Piotr On Mon, Aug 17, 2015 at 10:43 PM, Justin Bogner m...@justinbogner.com wrote: Piotr Padlewski via cfe-commits cfe-commits@lists.llvm.org writes: Author: prazek Date: Mon Aug 17 22:52:00 2015 New Revision: 245264

Re: [PATCH] D12128: Generating available_externally vtables bugfix

Prazek updated this revision to Diff 32587. http://reviews.llvm.org/D12128 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-available-externally.cpp Index: test/CodeGenCXX/vtable-available-externally.cpp

r245489 - Generating available_externally vtables bugfix

Author: prazek Date: Wed Aug 19 15:09:09 2015 New Revision: 245489 URL: http://llvm.org/viewvc/llvm-project?rev=245489view=rev Log: Generating available_externally vtables bugfix Bugfix revealed in r245264. http://reviews.llvm.org/D12128 Modified:

r245727 - Revert Generating assumption loads of vptr after ctor call (fixed)

Author: prazek Date: Fri Aug 21 14:49:41 2015 New Revision: 245727 URL: http://llvm.org/viewvc/llvm-project?rev=245727view=rev Log: Revert Generating assumption loads of vptr after ctor call (fixed) Reverting because of 245721 This reverts commit 552658e2b60543c928030b09cc9b5dfcb40c3f28.

r245721 - Generating assumption loads of vptr after ctor call (fixed)

Author: prazek Date: Fri Aug 21 13:28:00 2015 New Revision: 245721 URL: http://llvm.org/viewvc/llvm-project?rev=245721view=rev Log: Generating assumption loads of vptr after ctor call (fixed) Generating call assume(icmp %vtable, %global_vtable) after constructor call for devirtualization

[PATCH] D12128: Generating available_externally vtables bugfix

Prazek created this revision. Prazek added reviewers: rsmith, majnemer, rjmccall. Prazek added a subscriber: cfe-commits. Bugfix revealed in r245264. http://reviews.llvm.org/D12128 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/ItaniumCXXABI.cpp Index: lib/CodeGen/ItaniumCXXABI.cpp

Re: [PATCH] D12128: Generating available_externally vtables bugfix

Prazek updated this revision to Diff 32509. Prazek added a comment. Added tests, and changed the VTableComponent code which was wrong on so many levels. Sorry http://reviews.llvm.org/D12128 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/ItaniumCXXABI.cpp

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added a comment. In http://reviews.llvm.org/D11859#225025, @rjmccall wrote: Mostly LGTM. Are you going to emit assumptions for vbptrs in a separate patch? I wasn't planning to. I am focusing now on upgrading GVN for using new invariant.barrier metadata.

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked an inline comment as done. Comment at: lib/CodeGen/CGCXXABI.h:352 @@ +351,3 @@ + isVirtualOffsetNeededForVTableField(CodeGenFunction CGF, + const CXXRecordDecl *NearestVBase) = 0; + rjmccall wrote: This method

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 32262. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 32263. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 32343. Prazek marked an inline comment as done. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 3 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D11859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 3 inline comments as done. Comment at: lib/CodeGen/CGClass.cpp:1862 @@ +1861,3 @@ + for (const VPtr Vptr : getVTablePointers(ClassDecl)) +if (CGM.getCXXABI().requiresVPtrInitialization(Vptr)) + EmitVTableAssumptionLoad(Vptr, This);

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 31846. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 31768. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel 0 hfinkel wrote: I

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 5 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D11859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12026: Decorating vptr load stores with !invariant.group

Prazek created this revision. Prazek added reviewers: rsmith, majnemer, pcc. Prazek added a subscriber: cfe-commits. Adding !invariant.group to vptr load/stores for devirtualization purposes. For more goto: http://lists.llvm.org/pipermail/cfe-dev/2015-July/044227.htm

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 32122. Prazek marked an inline comment as done. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked an inline comment as done. Comment at: lib/CodeGen/CGClass.cpp:1832 @@ +1831,3 @@ + // Generate vtable assumptions if we are calling dynamic class ctor + // and we are not in another ctor. + if (CGM.getCodeGenOpts().OptimizationLevel 0 rsmith

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added inline comments. Comment at: lib/CodeGen/CodeGenFunction.h:1328-1334 @@ -1320,8 +1327,9 @@ typedef llvm::SmallPtrSetconst CXXRecordDecl *, 4 VisitedVirtualBasesSetTy; - void InitializeVTablePointers(BaseSubobject Base, -const

Re: [PATCH] D11859: Generating vptr assume loads

Prazek updated this revision to Diff 31766. http://reviews.llvm.org/D11859 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGen/available-externally-hidden.cpp

[PATCH] D11928: Small fixup

Prazek created this revision. Prazek added reviewers: rsmith, majnemer. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D11928 Files: include/clang/AST/VTableBuilder.h Index: include/clang/AST/VTableBuilder.h ===

Re: [PATCH] D11859: Generating vptr assume loads

Prazek marked 9 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D11859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11859: Generating vptr assume loads

Prazek added inline comments. Comment at: lib/CodeGen/CGClass.cpp:1842 @@ +1841,3 @@ + CGM.getCXXABI().getVTableAddressPoint(vptr.Base, vptr.VTableClass); + if (!VTableGlobal) return; + djasper wrote: Prazek wrote: majnemer wrote: The return should be

Re: [PATCH] D12385: Generating Assumption loads fix

Prazek marked an inline comment as done. Prazek added a comment. http://reviews.llvm.org/D12385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12385: Generating Assumption loads fix

Prazek created this revision. Prazek added reviewers: rsmith, majnemer, rjmccall. Prazek added a subscriber: cfe-commits. It wasn't always safe to generate assumption loads. Last time build failed on linking of classes like FenceInst because it didn't introduce any new virtual function, and it

r246214 - Assume loads fix #2

Author: prazek Date: Thu Aug 27 16:35:41 2015 New Revision: 246214 URL: http://llvm.org/viewvc/llvm-project?rev=246214view=rev Log: Assume loads fix #2 There was linker problem, and it turns out that it is not always safe to refer to vtable. If the vtable is used, then we can refer to it without

[PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

Prazek created this revision. Prazek added reviewers: rsmith, rjmccall, majnemer, nlewycky. Prazek added a subscriber: cfe-commits. Keep in mind, that I will not push it untill I will update GVN for using !invariant.group metadata http://reviews.llvm.org/D12312 Files:

Re: [PATCH] D12385: Generating Assumption loads fix

Prazek marked 3 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D12385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12385: Generating Assumption loads fix

Prazek updated this revision to Diff 33269. http://reviews.llvm.org/D12385 Files: lib/CodeGen/CGCXXABI.h lib/CodeGen/CGClass.cpp lib/CodeGen/CGVTables.cpp lib/CodeGen/ItaniumCXXABI.cpp lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/template-instantiation.cpp

Re: [PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

Prazek marked 3 inline comments as done. Comment at: lib/CodeGen/CGClass.cpp:1279 @@ +1278,3 @@ + if (CGM.getCodeGenOpts().StrictVPtrs && BaseVPtrsInitialized) +CXXThisValue = Builder.CreateInvariantGroupBarrier(LoadCXXThis()); + rjmccall wrote: > Prazek

Re: [PATCH] D12312: Emiting invariant.group.barrier and adding -fstrict-vptrs

Prazek updated the summary for this revision. Prazek updated this revision to Diff 33775. http://reviews.llvm.org/D12312 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CGClass.cpp lib/CodeGen/CGExprCXX.cpp lib/Driver/Tools.cpp

Re: [PATCH] D12580: Added StrictVTablePointers linking requirement

Prazek added a comment. I see that CGObjCMac.cpp names it like this: "Objective-C Garbage Collection" http://reviews.llvm.org/D12580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12719: ScalarEvolution assume hanging bugfix

Prazek added inline comments. Comment at: lib/Analysis/ScalarEvolution.cpp:6980 @@ -6991,1 +6979,3 @@ + // Check conditions due to any @llvm.assume intrinsics. + for (auto : AC.assumptions()) { nlewycky wrote: > What is it about this check which is a

[PATCH] D12719: ScalarEvolution assume hanging bugfix

Prazek created this revision. Prazek added reviewers: rsmith, nlewycky. Prazek added a subscriber: cfe-commits. Herald added a subscriber: sanjoy. http://reviews.llvm.org/D12719 Files: lib/Analysis/ScalarEvolution.cpp test/Analysis/ScalarEvolution/avoid-assume-hang.ll Index:

[PATCH] D12580: Added StrictVTablePointers linking requirement

Prazek created this revision. Prazek added reviewers: rsmith, rjmccall, majnemer, nlewycky. Prazek added a subscriber: cfe-commits. Generates code like this !llvm.module.flags = !{!0, !1} !0 = !{i32 1, !"StrictVTablePointers", i32 1} !1 = !{i32 3, !"StrictVTablePointersRequirement", !2} !2 =

r247733 - invariant.group-for-vptrs test fix

Author: prazek Date: Tue Sep 15 18:04:47 2015 New Revision: 247733 URL: http://llvm.org/viewvc/llvm-project?rev=247733=rev Log: invariant.group-for-vptrs test fix Modified: cfe/trunk/test/CodeGenCXX/invariant.group-for-vptrs.cpp Modified:

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

Prazek updated this revision to Diff 34761. Prazek marked 3 inline comments as done. http://reviews.llvm.org/D12865 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGClass.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-assume-load.cpp

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

Prazek updated this revision to Diff 34750. http://reviews.llvm.org/D12865 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGClass.cpp lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-assume-load.cpp test/CodeGenCXX/vtable-available-externally.cpp Index:

Re: [PATCH] D12865: Generating available_externally vtables and assume loads bugfix

Prazek added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:394-406 @@ +393,15 @@ + +for (const auto : VtableLayout.vtable_components()) { + if (VtableComponent.isRTTIKind()) { +const CXXRecordDecl *RTTIDecl = VtableComponent.getRTTIDecl(); +

[PATCH] D12865: Generating available_externally vtables and assume loads bugfix

Prazek created this revision. Prazek added reviewers: rsmith, rjmccall, hans, majnemer. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D12865 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/CGClass.cpp lib/CodeGen/ItaniumCXXABI.cpp

r247723 - Emiting llvm.invariant.group.barrier when dynamic type changes

Author: prazek Date: Tue Sep 15 16:46:47 2015 New Revision: 247723 URL: http://llvm.org/viewvc/llvm-project?rev=247723=rev Log: Emiting llvm.invariant.group.barrier when dynamic type changes For more goto: http://lists.llvm.org/pipermail/cfe-dev/2015-July/044227.html

r247725 - Decorating vptr load & stores with !invariant.group

Author: prazek Date: Tue Sep 15 16:46:55 2015 New Revision: 247725 URL: http://llvm.org/viewvc/llvm-project?rev=247725=rev Log: Decorating vptr load & stores with !invariant.group Adding !invariant.group to vptr load/stores for devirtualization purposes. For more goto:

r247646 - Generating assumption loads of vptr after ctor call (fixed)

Author: prazek Date: Mon Sep 14 19:37:06 2015 New Revision: 247646 URL: http://llvm.org/viewvc/llvm-project?rev=247646=rev Log: Generating assumption loads of vptr after ctor call (fixed) Generating call assume(icmp %vtable, %global_vtable) after constructor call for devirtualization purposes.

r247650 - small test bugfix

Author: prazek Date: Mon Sep 14 19:55:29 2015 New Revision: 247650 URL: http://llvm.org/viewvc/llvm-project?rev=247650=rev Log: small test bugfix Modified: cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp Modified: cfe/trunk/test/CodeGenCXX/vtable-assume-load.cpp URL:

Re: [PATCH] D12026: Decorating vptr load & stores with !invariant.group

Prazek marked an inline comment as done. Comment at: lib/CodeGen/CodeGenModule.cpp:3859 @@ -3848,4 +3858,3 @@ } else { -InternalId = llvm::MDNode::getDistinct(getLLVMContext(), - llvm::ArrayRef()); +InternalId =

Re: [PATCH] D12026: Decorating vptr load & stores with !invariant.group

Prazek updated the summary for this revision. Prazek updated this revision to Diff 34833. http://reviews.llvm.org/D12026 Files: lib/CodeGen/CGAtomic.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprCXX.cpp lib/CodeGen/CodeGenFunction.h

[PATCH] D12927: Using MD_invariant_group

Prazek created this revision. Prazek added reviewers: rsmith, nlewycky, majnemer. Prazek added a subscriber: cfe-commits. Using changes from http://reviews.llvm.org/D12926 http://reviews.llvm.org/D12927 Files: lib/CodeGen/CodeGenModule.cpp Index: lib/CodeGen/CodeGenModule.cpp

r247933 - Using MD_invariant_group

Author: prazek Date: Thu Sep 17 15:25:46 2015 New Revision: 247933 URL: http://llvm.org/viewvc/llvm-project?rev=247933=rev Log: Using MD_invariant_group http://reviews.llvm.org/D12927 Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp URL:

r247332 - Revert "Generating assumption loads of vptr after ctor call (fixed)"

Author: prazek Date: Thu Sep 10 15:18:30 2015 New Revision: 247332 URL: http://llvm.org/viewvc/llvm-project?rev=247332=rev Log: Revert "Generating assumption loads of vptr after ctor call (fixed)" It seems that there is small bug, and we can't generate assume loads when some virtual functions

r248734 - Generate assume loads only with -fstrict-vtable-pointers

Author: prazek Date: Mon Sep 28 15:30:22 2015 New Revision: 248734 URL: http://llvm.org/viewvc/llvm-project?rev=248734=rev Log: Generate assume loads only with -fstrict-vtable-pointers Temporary fix till InstCombine and other possible passes will be efficient to handle multiple assumes.

Re: [PATCH] D13279: Decorating virtual functions load with invariant.load

Prazek updated this revision to Diff 36125. http://reviews.llvm.org/D13279 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/virtual-function-calls.cpp Index: test/CodeGenCXX/virtual-function-calls.cpp === ---

Re: [PATCH] D13279: Decorating virtual functions load with invariant.load

Prazek updated this revision to Diff 36130. http://reviews.llvm.org/D13279 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/virtual-function-calls.cpp Index: test/CodeGenCXX/virtual-function-calls.cpp === ---

[PATCH] D13279: Decorating virtual functions load with invariant.load

Prazek created this revision. Prazek added reviewers: rsmith, majnemer, nlewycky, rjmccall. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D13279 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/virtual-function-calls.cpp Index:

r248982 - Decorating virtual functions load with invariant.load

Author: prazek Date: Wed Sep 30 22:50:41 2015 New Revision: 248982 URL: http://llvm.org/viewvc/llvm-project?rev=248982=rev Log: Decorating virtual functions load with invariant.load http://reviews.llvm.org/D13279 Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

Prazek created this revision. Prazek added reviewers: rsmith, nlewycky, rjmccall, majnemer. Prazek added a subscriber: cfe-commits. Please review asap http://reviews.llvm.org/D13373 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/invariant.group-for-vptrs.cpp

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

Prazek updated the summary for this revision. Prazek updated this revision to Diff 36382. Prazek marked an inline comment as done. http://reviews.llvm.org/D13373 Files: lib/CodeGen/CGClass.cpp test/CodeGenCXX/invariant.group-for-vptrs.cpp test/CodeGenCXX/strict-vtable-pointers.cpp Index:

Re: [PATCH] D13373: Emiting invariant.group.barrier for ctors bugfix

Thank you! On Fri, Oct 2, 2015 at 5:54 PM, NAKAMURA Takumi wrote: > chapuni added a subscriber: chapuni. > > > Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:145 > @@ +144,3 @@ > +// CHECK-CTORS: %[[THIS3:.*]] = bitcast i8* %[[THIS2]] to >

Re: [PATCH] D12719: ScalarEvolution assume hanging bugfix

Prazek added a comment. I checked it, it is of course not infinite. I am not sure about n! in case of assumes. I having 10 or 20 assumes will not make it slow. @rsmith was helping me with it, and he thinks that for assumes it is O(n^2), because results are memorized. So it this case, 1000

Re: [PATCH] D12719: ScalarEvolution assume hanging bugfix

Prazek added a comment. I used "hanging out" in the meaning of being very slow, not sure if it is right word for it. http://reviews.llvm.org/D12719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12128: Generating available_externally vtables bugfix

Prazek accepted this revision. Prazek added a reviewer: Prazek. Prazek added a comment. This revision is now accepted and ready to land. Have to accept revision to close it http://reviews.llvm.org/D12128 ___ cfe-commits mailing list

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59561. Prazek marked an inline comment as done. Prazek added a comment. Fixed stuff http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/UseEmplaceCheck.cpp docs/ReleaseNotes.rst docs/clang-tidy/checks/modernize-use-emplace.rst Index:

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59568. Prazek added a comment. - Post review fix http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 4 inline comments as done. Comment at: docs/clang-tidy/checks/modernize-use-emplace.rst:6 @@ +5,3 @@ + +This check would look for cases when inserting new element into an STL +container, but the element is constructed temporarily or is constructed just

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 2 inline comments as done. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:40 @@ +39,3 @@ + // passed pointer because smart pointer won't be constructed + // (and destructed) as in push_back case. + auto isCtorOfSmartPtr = hasDeclaration(cxxConstructorDecl(

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 2 inline comments as done. Prazek added a comment. http://reviews.llvm.org/D20964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek marked 4 inline comments as done. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:29 @@ +28,3 @@ + auto callPushBack = + cxxMemberCallExpr(hasDeclaration(functionDecl(hasName(PushBackName))), +

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added inline comments. Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:31 @@ +30,3 @@ +on(hasType(cxxRecordDecl(hasName(VectorName) + .bind("call"); + ok, std::list works for me. I just don't want to spend much

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59562. Prazek added a comment. Learning how to use arc http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

Prazek added a subscriber: Prazek. Prazek added a comment. besides it lgtm Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59580. Prazek marked 4 inline comments as done. Prazek added a comment. - Review fixes http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a comment. In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote: > I think will be good idea to try this check with LLVM STL too. You mean llvm::SmallVector stuff? http://reviews.llvm.org/D20964 ___ cfe-commits mailing

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

Prazek added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list. -if (Dec == *D->decl_begin()) -

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

Just ask Chris for the access :) 03.06.2016 11:26 AM "Clement Courbet via cfe-commits" < cfe-commits@lists.llvm.org> napisał(a): > courbet added a comment. > > @sbenza @aaron.ballman I don't have write access. Can one of you submit > this on my behalf ? Thanks ! > > >

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek added a comment. In http://reviews.llvm.org/D20964#448551, @Eugene.Zelenko wrote: > In http://reviews.llvm.org/D20964#448525, @Prazek wrote: > > > In http://reviews.llvm.org/D20964#448455, @Eugene.Zelenko wrote: > > > > > I think will be good idea to try this check with LLVM STL too. > >

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

Prazek added inline comments. Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37 @@ +36,3 @@ + +It turns out that the common bug is to have function returning only bools but having int as return type. +If check finds case like this then it function

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 60662. Prazek marked an inline comment as done. Prazek added a comment. Runned on LLVM and bug fixed one thing http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added inline comments. Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:43 @@ +42,3 @@ +/// matches "b(1)". +AST_MATCHER_P(CXXConstructExpr, ctorCallee, + ast_matchers::internal::Matcher, This seems like a usefull matcher. We should

Re: [PATCH] D21303: [clang-tidy] Adds performance-returning-type check.

Prazek added inline comments. Comment at: clang-tidy/performance/ReturningTypeCheck.cpp:53 @@ +52,3 @@ +/// matches the given matcher. +AST_MATCHER_P(QualType, ignoringRefsAndConsts, + ast_matchers::internal::Matcher, InnerMatcher) { {meme,

Re: [PATCH] D20964: [clang-tidy] Add modernize-use-emplace

Prazek updated this revision to Diff 59558. Prazek added a comment. - Fix http://reviews.llvm.org/D20964 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseEmplaceCheck.cpp clang-tidy/modernize/UseEmplaceCheck.h

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

Prazek updated this revision to Diff 58961. Prazek added a comment. aborting with virtual functions http://reviews.llvm.org/D18821 Files: clang-tidy/CMakeLists.txt clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp clang-tidy/bugprone/BoolToIntegerConversionCheck.h

Re: [PATCH] D20277: [clang-tidy] UnnecessaryValueParamCheck - suggest std::move() if non-const value parameter can be moved.

Prazek added a comment. In http://reviews.llvm.org/D20277#436725, @flx wrote: > In http://reviews.llvm.org/D20277#436717, @Prazek wrote: > > > Cool check! Did you think about sugesting std::move for rvalue references > > if they are used once? > > > Thanks! I'm not sure this fits with what a

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), aaron.ballman wrote: > Prazek

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added a comment. In http://reviews.llvm.org/D19201#445496, @aaron.ballman wrote: > In http://reviews.llvm.org/D19201#445406, @sbarzowski wrote: > > > Note ``FunctionProtoType::getNoExceptExpr`` is weird. If you have the same > > expr in multiple noexcepts, then it returns the same object

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 @@ +24,3 @@ + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), you can use forFunction instead of

Re: [PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

Prazek added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:32 @@ +31,3 @@ +// token including trailing whitespace. +static SourceRange FindToken(const SourceManager , LangOptions LangOpts, + SourceLocation StartLoc,

r271288 - [ASTMatchers] Breaking change of `has` matcher

Author: prazek Date: Tue May 31 10:25:05 2016 New Revision: 271288 URL: http://llvm.org/viewvc/llvm-project?rev=271288=rev Log: [ASTMatchers] Breaking change of `has` matcher has matcher can now match to implicit and paren casts http://reviews.llvm.org/D20801 Modified:

[clang-tools-extra] r271289 - [ASTMatchers] Added ignoringParenImpCasts to has matchers

Author: prazek Date: Tue May 31 10:26:56 2016 New Revision: 271289 URL: http://llvm.org/viewvc/llvm-project?rev=271289=rev Log: [ASTMatchers] Added ignoringParenImpCasts to has matchers has matcher changed behaviour, and now it matches "as is" and doesn't skip implicit and paren casts

Re: r271288 - [ASTMatchers] Breaking change of `has` matcher

Yep, sending fix 2016-05-31 17:45 GMT+02:00 Rafael Espíndola <rafael.espind...@gmail.com>: > This broke the build: > > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/36968/steps/cmake-configure/logs/stdio > > On 31 May 2016 at 08:25, Piotr Padlewski v

Re: r271288 - [ASTMatchers] Breaking change of `has` matcher

t; http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/36968/steps/cmake-configure/logs/stdio >> >> On 31 May 2016 at 08:25, Piotr Padlewski via cfe-commits >> <cfe-commits@lists.llvm.org> wrote: >> > Author: prazek >> > Date: Tue May 31 10:25:

r271293 - Fixed bug

Author: prazek Date: Tue May 31 10:56:26 2016 New Revision: 271293 URL: http://llvm.org/viewvc/llvm-project?rev=271293=rev Log: Fixed bug Modified: cfe/trunk/include/clang/CMakeLists.txt Modified: cfe/trunk/include/clang/CMakeLists.txt URL:

Re: r271288 - [ASTMatchers] Breaking change of `has` matcher

tr.padlew...@gmail.com>: > >> > >> Yep, sending fix > >> > >> 2016-05-31 17:45 GMT+02:00 Rafael Espíndola <rafael.espind...@gmail.com > >: > >>> > >>> This broke the build: > >>> > >>> > http://lab.llvm.org:8011

Re: [PATCH] D21185: [clang-tidy] Add performance-emplace-into-containers

Prazek added a subscriber: Prazek. Prazek added a comment. In http://reviews.llvm.org/D21185#464517, @Eugene.Zelenko wrote: > Since http://reviews.llvm.org/D20964 was committed, I think we should close > this. Yep, I think the best idea is to take all the goodies from this check and add it

  1   2   3   4   >