[PATCH] D77598: Integral template argument suffix printing

reikdas added a comment. I updated the diff here - https://reviews.llvm.org/D79290. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79290: Update suffix check and cast non-suffix types

reikdas added a comment. In D79290#2016273 , @hubert.reinterpretcast wrote: > @reikdas, please upload the full copy of your combined changes to D77598 > where the review is still active and close > this. This still

[PATCH] D77598: Integral template argument suffix printing

reikdas updated this revision to Diff 261774. reikdas added a comment. Sorry my earlier update did not include the changes from the earlier revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp

[PATCH] D77598: Integral template argument suffix printing

reikdas updated this revision to Diff 261772. reikdas added a comment. Addresses @rsmith 's inline comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp clang/test/CXX/dcl.decl/dcl.decomp/p3.cpp

[PATCH] D79290: Update suffix check and cast non-suffix types

reikdas updated this revision to Diff 261682. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79290/new/ https://reviews.llvm.org/D79290 Files: clang/lib/AST/TemplateBase.cpp clang/test/Misc/integer-literal-printing.cpp Index: clang/test/Misc/integer-literal-printing.cpp

[PATCH] D79290: Update suffix check and cast non-suffix types

reikdas updated this revision to Diff 261683. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79290/new/ https://reviews.llvm.org/D79290 Files: clang/lib/AST/TemplateBase.cpp clang/test/Misc/integer-literal-printing.cpp Index: clang/test/Misc/integer-literal-printing.cpp

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 293432. reikdas added a comment. Attempt an alternate approach, following @rsmith 's inline suggestions. Unfortunately, one of the tests added in this revision unexpectedly fail in this approach :( CHANGES SINCE LAST ACTION

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added inline comments. Comment at: clang/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp:466 + template <> struct S<1> { using type = int; }; // expected-note {{'S<1>::type' declared here}} + S<1L>::type t; // expected-error {{no type named 'type' in 'PR9227::S<1L>';

[PATCH] D88780: Allow interfaces to operate on in-memory buffers with no source location info.

reikdas created this revision. reikdas added reviewers: rsmith, lebedev.ri, shafik, v.g.vassilev. Herald added a project: clang. Herald added a subscriber: cfe-commits. reikdas requested review of this revision. This is a part of the RFC mentioned here -

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:71-72 if (T->isBooleanType() && !Policy.MSVCFormatting) { Out << (Val.getBoolValue() ? "true" : "false"); } else if (T->isCharType()) { rsmith wrote: > rsmith wrote: > > It

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 284181. reikdas edited the summary of this revision. reikdas added a comment. Addresses inline comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 284186. reikdas added a comment. Can completely replace CanonParamType. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/lib/AST/TemplateBase.cpp clang/lib/Sema/SemaTemplate.cpp

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 268412. reikdas marked an inline comment as done. reikdas retitled this revision from "Integral template argument suffix printing" to "Integral template argument suffix and cast printing". reikdas edited the summary of this revision. reikdas added a comment.

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added a comment. In D77598#2111606 , @rsmith wrote: > In D77598#2064193 , @rsmith wrote: > > > In D77598#1990197 , @rsmith wrote: > > > > > Is is feasible to check

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 285565. reikdas added a comment. Made some changes to SemaTemplate.cpp based on http://clang-developers.42468.n3.nabble.com/Using-clang-tool-to-Exact-type-names-in-template-specification-arguments-td4069210.html CHANGES SINCE LAST ACTION

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 307587. reikdas added a comment. Address @rsmith 's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/StmtDataCollectors.td

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas marked 25 inline comments as done. reikdas added inline comments. Comment at: clang/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp:471 + template struct X {}; + X<1, 1u>::type y; // expected-error {{no type named 'type' in 'TypeSuffix::X<1, 1u>'}} + X<1, 1>::type z;

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 312980. reikdas added a comment. Address @rsmith comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/StmtDataCollectors.td

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas marked 22 inline comments as done. reikdas added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:111-115 + Out << "u8'" << Val << "'"; +else if (T->isUnsignedIntegerType() && T->isChar16Type()) + Out << "u16'" << Val << "'"; +

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 306059. reikdas added a comment. Addresses @rsmith 's comments. > On that basis, I think it would be preferable to change > TemplateArgument::print to accept not a bool indicating whether the type was > known, but instead a const NamedDecl * for the

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 306097. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/StmtDataCollectors.td clang/include/clang/AST/TemplateBase.h clang/lib/AST/ASTContext.cpp

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 314858. reikdas marked an inline comment as done. reikdas added a comment. Address @rsmith review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 314859. reikdas marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/StmtDataCollectors.td

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 344161. reikdas added a comment. Fix failing test on windows triple and do some code cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 343909. reikdas added a comment. Herald added subscribers: usaxena95, kadircet. Herald added a project: clang-tools-extra. Fix API usage in clangd and fix bug introduced in patch where printing of manually specified default template argument is omitted.

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 343363. reikdas added a comment. Address @rsmith comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/Expr.h

[PATCH] D103040: Print default template argument if manually specified in typedef declaration.

reikdas created this revision. reikdas added a reviewer: rsmith. reikdas requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If a default template type argument is manually specified to be of the default type, then it is committed when

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 342991. reikdas added a comment. Update diff to avoid printing type information if MSVCFormatting printing policy is enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files:

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:71-72 if (T->isBooleanType() && !Policy.MSVCFormatting) { Out << (Val.getBoolValue() ? "true" : "false"); } else if (T->isCharType()) { rnk wrote: > rsmith wrote: > > rsmith

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 336604. reikdas added a comment. Address @rsmith comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/Expr.h

[PATCH] D77598: Integral template argument suffix and cast printing

reikdas updated this revision to Diff 323696. reikdas added a comment. Address @rsmith comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77598/new/ https://reviews.llvm.org/D77598 Files: clang/include/clang/AST/DeclTemplate.h clang/include/clang/AST/StmtDataCollectors.td