[PATCH] D87223: [FPEnv] [Clang] Enable constrained FP support for PowerPC

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ecc8520bc5b: [FPEnv] [Clang] Enable constrained FP support for PowerPC (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D87220: [PowerPC] Fix STRICT_FRINT/STRICT_FNEARBYINT lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rG88ff4d2ca1a0: [PowerPC] Fix STRICT_FRINT/STRICT_FNEARBYINT lowering (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, kbarton, PowerPC, wschmidt, rsmith. Herald added subscribers: cfe-commits, steven.zhang, pengfei, shchenz. Herald added a project: clang. qiucf requested review of this revision. This patch adds three intrinsics compatible to

[PATCH] D85874: [PowerPC] Add readflm/setflm intrinsics to Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG91039784b3c9: [PowerPC] Add readflm/setflm intrinsics to Clang (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85874/new/

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf updated this revision to Diff 300887. qiucf added a comment. Remove `FIXME` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ https://reviews.llvm.org/D90208 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, steven.zhang, PowerPC, kbarton. Herald added subscribers: cfe-commits, dexonsmith, shchenz. Herald added a project: clang. qiucf requested review of this revision. We have option `-mabi=ieeelongdouble` to set current `long

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

qiucf created this revision. qiucf added reviewers: echristo, stefanp, nemanjai, jsji, steven.zhang, PowerPC. Herald added subscribers: cfe-commits, dexonsmith, shchenz, kbarton. Herald added a project: clang. qiucf requested review of this revision. As Power9 introduced hardware support for IEEE

[PATCH] D85874: [PowerPC] Add readflm/setflm intrinsics to Clang

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, steven.zhang, ZhangKang, PowerPC. Herald added subscribers: llvm-commits, cfe-commits, shchenz, kbarton. Herald added projects: clang, LLVM. qiucf requested review of this revision. Herald added a subscriber: wuzish. dbcfbffc

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

qiucf added a comment. Thanks for this patch! If I understand correctly, only `isEmptyRecord`/`isEmptyField` and places checking any field is zero bit-width may need change for this? Since `isSingleElementStruct` and `isHomogeneousAggregate` just use them to skip empty fields in aggregate. I

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

qiucf added a comment. > In any case, I guess it would still be good to also have test cases for this > aspect of the ABI on Power ... Sure, I'd like to do pre-commit for PPC tests. (or after this landed and enable/remove `AllowNoUniqueAddr`) CHANGES SINCE LAST ACTION

[PATCH] D92329: [PowerPC][Clang] Remove QPX support

qiucf added a comment. Another small place also needs remove? (but not related to clang) `llvm/test/Transforms/LoopVectorize/PowerPC/vectorize-only-for-real.ll`: attributes #0 = { nounwind "target-cpu"="a2q"

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#2416625 , @craig.topper wrote: > gcc calls the *l version with -mlong-double-128 on x86. Should we match gcc > here? Ah, yes, so this should be PPC-only change. But I see under x86 `-mlong-double-128`, std functions

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf29dbb1541: [PowerPC] [Clang] Enable float128 feature on P9 by default (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90213: [PowerPC] [Clang] Enable float128 feature on P9 by default

qiucf added a comment. Ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90213/new/ https://reviews.llvm.org/D90213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92544: [NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9378a366b2b2: [NFC] [Clang] Fix ppc64le vaarg OpenMP test in CodeGen (authored by qiucf). Herald added a project: clang.

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. Any comments...? I don't have knowledge if there's any plan about implementing `*f128` math functions on X86 libcs. But as I see so far, `*l` doesn't work well on `fp128`. Keeping this target independent currently seems reasonable to me. Repository: rG LLVM Github

[PATCH] D92465: [PowerPC] Implement intrinsic for DARN instruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e85a2ba1645: [PowerPC] Implement intrinsic for DARN instruction (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf created this revision. qiucf added reviewers: craig.topper, spatel, nemanjai, jsji, steven.zhang, PowerPC, kpn, RKSimon. Herald added subscribers: cfe-commits, pengfei. Herald added a project: clang. qiucf requested review of this revision. Under `-mlong-double-128` on x86 and

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ MaskRay wrote: >

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc64le-varargs-f128.c:8 +// RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm \ +// RUN: -fopenmp-targets=ppc64le -mfloat128 -mabi=ieeelongdouble -mcpu=pwr9 \ hubert.reinterpretcast

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf added a comment. The regression should be fixed in rG3fca6a7844b5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91596/new/ https://reviews.llvm.org/D91596

[PATCH] D92278: [Clang] Don't adjust align for IBM extended double type

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fca6a7844b5: [Clang] Dont adjust align for IBM extended double (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#244 , @craig.topper wrote: > I don't think I understand the whole picture here. Why would only builtins > get mutated? Does a call to "modf" still call "modf"? But __builtin_modf will > call modf128? Is there a

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG979a4d268a48: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

This revision was automatically updated to reflect the committed changes. Closed by commit rG2abc33683b2b: [PowerPC] [Clang] Define macros to identify quad-fp semantics (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf added a comment. In D91596#2404514 , @rjmccall wrote: > I assume this has always been taken care of properly in the backend, so this > is just a fix for va_arg treatment? If so, LGTM. Yes. That's just fix for `va_arg`. Thanks! CHANGES SINCE

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b1341eb5bb7: [PowerPC] [Clang] Fix alignment of 128-bit float types (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D91596?vs=305692=306315#toc Repository: rG LLVM Github

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf updated this revision to Diff 305692. qiucf added a comment. Use another branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91596/new/ https://reviews.llvm.org/D91596 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/ppc64le-varargs-f128.c Index:

[PATCH] D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, uweigand, PowerPC, steven.zhang, rjmccall. Herald added subscribers: cfe-commits, shchenz, kbarton. Herald added a project: clang. qiucf requested review of this revision. According to ELF v2 ABI, both IEEE 128-bit and IBM

[PATCH] D89242: [PowerPC] [Clang] Port SSE4.1-compatible insert intrinsics

qiucf added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89242/new/ https://reviews.llvm.org/D89242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf updated this revision to Diff 302488. qiucf marked an inline comment as done. qiucf added a comment. Keep the `FIXME`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90208/new/ https://reviews.llvm.org/D90208 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D90208: [PowerPC] [Clang] Define macros to identify quad-fp semantics

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:122 if (LongDoubleWidth == 128) { Builder.defineMacro("__LONG_DOUBLE_128__"); Builder.defineMacro("__LONGDOUBLE128"); steven.zhang wrote: > Can you please double check if we

[PATCH] D90593: [Clang] Add more fp128 math library function builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG7faf62a80bfc: [Clang] Add more fp128 math library function builtins (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. Ping.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

This revision was automatically updated to reflect the committed changes. Closed by commit rG168be4208304: [Clang] Mutate long-double math builtins into f128 under IEEE-quad (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 313835. qiucf marked 14 inline comments as done. qiucf added a comment. Address comments and add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files: clang/bindings/python/clang/cindex.py

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6204 case HalfRank: llvm_unreachable("Complex half is not supported"); +case Ibm128Rank: llvm_unreachable("Complex __ibm128 is not supported"); case FloatRank: return FloatComplexTy;

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf created this revision. qiucf added reviewers: nemanjai, rjmccall, rsmith, hubert.reinterpretcast, akyrtzi, PowerPC. Herald added subscribers: dexonsmith, steven.zhang, shchenz, arphaman, kbarton. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#2449236 , @craig.topper wrote: > D91675 has PowerPC only changes to make the > f128 calls get emitted. If you change the frontend in a target independent > way as proposed here, won't

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf updated this revision to Diff 312153. qiucf edited the summary of this revision. qiucf added a comment. - Diff based on pre-commit - Restrict to PPC64 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 Files:

[PATCH] D94162: [PowerPC] Add variants of 64-bit vector types for vec_sel.

qiucf added a comment. Can we add tests to `builtins-ppc-altivec.c`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94162/new/ https://reviews.llvm.org/D94162 ___ cfe-commits mailing list

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

qiucf added a comment. Please provide context of the patch (`git diff -U999`) :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104744/new/ https://reviews.llvm.org/D104744 ___ cfe-commits mailing list

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

qiucf added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3334 return SemaBuiltinConstantArgRange(TheCall, 3, 0, 7); + case PPC::BI__builtin_ppc_tw: { +return SemaBuiltinConstantArgRange(TheCall, 2, 1, 31); Unnecessary brace?

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c:56 +unsigned int testrotatel4(unsigned int rs, unsigned int shift) { + return __rotatel4(rs, shift); +} For these tests against builtin mapping to an intrinsic, could we

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:2 // RUN: %clang_cc1 -triple powerpc64-unknown-unknown \ -// RUN:-emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN:-emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s //

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfebbe4b5a0ab: [PowerPC] [Clang] Enable float128 feature on VSX targets (authored by qiucf). Changed prior to commit:

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf added a comment. In D92815#2753684 , @nemanjai wrote: > Looks like this is causing failures at > https://lab.llvm.org/buildbot/#/builders/76/builds/2422 > Please revert. Yes. Already reverted in

[PATCH] D102443: [PowerPC] Added multiple PowerPC builtins

qiucf added a comment. Is there any motivation to add these builtins? I don't see them implemented in GCC. Besides, in Clang I think a prefix `__builtin` is preferred for them. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:28 +BUILTIN(__popcntb, "ULiULi", "")

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0b3071833a8: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++ (authored by qiucf, committed by ecnelises). Changed prior to

[PATCH] D103235: [SPE] Disable strict-fp for SPE by default

qiucf created this revision. qiucf added reviewers: nemanjai, jhibbits, vit9696, kpn. Herald added subscribers: steven.zhang, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in PR50385

[PATCH] D103235: [SPE] Disable strict-fp for SPE by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c18d1136665: [SPE] Disable strict-fp for SPE by default (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc-xmmintrin.c:10 // RUN: -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt -n | FileCheck %s --check-prefixes=CHECK,CHECK-LE +// RUN: %clang -x c++ -fsyntax-only -target

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

qiucf added inline comments. Comment at: clang/test/CodeGen/ppc-xmmintrin.c:10 // RUN: -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt -n | FileCheck %s --check-prefixes=CHECK,CHECK-LE +// RUN: %clang -x c++ -fsyntax-only -target

[PATCH] D103501: [clang][AIX] Enable inlined quadword atomic operations

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:336 .Default(false); + Features["quadword-atomics"] = llvm::StringSwitch(CPU) + .Case("pwr10", true) What about `ppc64`? Also,

[PATCH] D103386: [PowerPC] Fix x86 vector intrinsics wrapper compilation under C++

qiucf created this revision. qiucf added reviewers: PowerPC, jsji, nemanjai. Herald added subscribers: shchenz, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

qiucf added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:425 + Features["isa207"] = llvm::StringSwitch(CPU) + .Case("pwr9", true) Will it be better if name to `isa2_07`, `isa3_0` to make it less confusing? Besides,

[PATCH] D101209: [PowerPC] Provide fastmath sqrt and div functions in altivec.h

qiucf added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15122 + case PPC::BI__builtin_ppc_rsqrtd: { +auto FMF = Builder.getFastMathFlags(); +Builder.getFastMathFlags().setFast(); Seems FMF will be automatically restored without the

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf added a comment. Ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added a comment. Ping.. Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 330560. qiucf marked an inline comment as done. qiucf added a comment. Update cindex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files:

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/bindings/python/clang/cindex.py:2061-2062 TypeKind.FLOAT128 = TypeKind(30) TypeKind.HALF = TypeKind(31) +TypeKind.IBM128 = TypeKind(32) TypeKind.COMPLEX = TypeKind(100) hubert.reinterpretcast wrote: > This looks

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf updated this revision to Diff 327378. qiucf retitled this revision from "[PowerPC] [Clang] Enable float128 feature on Altivec targets" to "[PowerPC] [Clang] Enable float128 feature on VSX targets". qiucf edited the summary of this revision. qiucf set the repository for this revision to rG

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

qiucf updated this revision to Diff 327388. qiucf added a comment. Fix redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815 Files: clang/lib/Basic/Targets/PPC.cpp

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; hubert.reinterpretcast wrote: > qiucf wrote: > >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 327716. qiucf marked 2 inline comments as done. qiucf added a comment. - Add helper method to count 'unordered' cases - Add missing tests (in last update) - Add test for openmp device-host case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 369045. qiucf marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files: clang/bindings/python/clang/cindex.py

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5159 BT->getKind() == BuiltinType::LongDouble || +BT->getKind() == BuiltinType::Ibm128 || (getContext().getTargetInfo().hasFloat128Type() && rjmccall wrote: >

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf marked 2 inline comments as done. qiucf added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:131 +Float128, +Ibm128 }; rjmccall wrote: > This is necessary because it's possible to derive this type from a mode > attribute?

[PATCH] D106191: [clang] Option control afn flag

qiucf added a comment. Making a new option mapped to another float op flag looks reasonable, but is there any clearer motivation for this? (such as the need for `-Ofast -fno-approx-func`) Comment at: llvm/include/llvm/Target/TargetOptions.h:179 +/// with approximate

[PATCH] D109126: [PowerPC] [NFC] Add Big-Endian checks for existing MMA tests

qiucf added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-pair-mma.c:5 +// RUN: %clang_cc1 -O3 -triple powerpc64-unknown-unknown -target-cpu pwr10 \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-BE Seems just adding `%clang_cc1

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfae0dfa6421e: [Clang] Add __ibm128 type to represent ppc_fp128 (authored by qiucf). Changed prior to commit:

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf created this revision. qiucf added reviewers: PowerPC, hubert.reinterpretcast, nemanjai, jsji. Herald added a subscriber: shchenz. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D109943: [Clang] Fix long double availability check

qiucf created this revision. Herald added subscribers: steven.zhang, mstorsjo, jvesely. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. fae0dfa

[PATCH] D109943: [Clang] Fix long double availability check

This revision was automatically updated to reflect the committed changes. Closed by commit rG0195f8621f18: [Clang] Fix long double availability check (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109943/new/

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

qiucf created this revision. qiucf added reviewers: hubert.reinterpretcast, nemanjai, PowerPC, rjmccall. Herald added a subscriber: kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As a follow-up to fae0dfa

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf created this revision. qiucf added reviewers: nemanjai, hubert.reinterpretcast, rjmccall, PowerPC, aaron.ballman. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As for 128-bit floating points on PPC, compiler should have

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

qiucf added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15140 + Value *fdiv = Builder.CreateFDiv(X, Y, "recipdiv"); + Builder.getFastMathFlags().operator&=(FMF); + return fdiv; Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D105957: [PowerPC] Implement intrinsics for mtfsf[i]

qiucf accepted this revision. qiucf added a comment. This revision is now accepted and ready to land. The PPC instructions tablegen part looks good to me. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1589 [IntrNoMem, IntrHasSideEffects]>; def

[PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

qiucf created this revision. qiucf added reviewers: rjmccall, teemperor. qiucf requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111387 Files:

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

qiucf updated this revision to Diff 378112. qiucf marked 2 inline comments as done. qiucf added a comment. Based on another patch to remove pre-computed complex CanQualType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109948/new/

[PATCH] D111387: [NFC] [Clang] Remove pre-computed complex float types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00c0ce0655da: [NFC] [Clang] Remove pre-computed complex float types (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D111482: [Clang] [PowerPC] Fix header include typo in smmintrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fc0d439a4b6: [Clang] [PowerPC] Fix header include typo in smmintrin.h (authored by qiucf). Changed prior to commit: https://reviews.llvm.org/D111482?vs=378414=378550#toc Repository: rG LLVM Github

[PATCH] D111391: [NFC] [Clang] Use global enum for explicit float mode

qiucf created this revision. qiucf added reviewers: rjmccall, nemanjai, aaron.ballman, erichkeane. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, there're multiple float types that can be represented by

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf updated this revision to Diff 378131. qiucf marked 2 inline comments as done. qiucf added a comment. Split and rebase upon D111391 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/

[PATCH] D112055: [PowerPC] Implement longdouble pack/unpack builtins

qiucf created this revision. qiucf added reviewers: nemanjai, PowerPC, jsji, shchenz. Herald added subscribers: dexonsmith, kbarton, hiraditya. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

qiucf updated this revision to Diff 378561. qiucf added a comment. Add codegen test to show generated type in IR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109950/new/ https://reviews.llvm.org/D109950 Files: clang/lib/Basic/TargetInfo.cpp

[PATCH] D109950: [Clang] Enable IC/IF mode for __ibm128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd11ec6f67e45: [Clang] Enable IC/IF mode for __ibm128 (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111391: [NFC] [Clang] Use global enum for explicit float mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a714722e2aa: [NFC] [Clang] Use global enum for explicit float mode (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111391/new/

[PATCH] D109948: [Clang] Enable _Complex __ibm128 type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85e565898ff3: [Clang] Enable _Complex __ibm128 type (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111482: [Clang] [PowerPC] Fix header include typo in smmintrin.h

qiucf created this revision. qiucf added reviewers: jsji, nemanjai, PowerPC. Herald added subscribers: shchenz, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It should be SSSE3 instead of SSE2. Repository: rG LLVM

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

qiucf updated this revision to Diff 381868. qiucf added a reviewer: rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112401/new/ https://reviews.llvm.org/D112401 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, PowerPC. Herald added subscribers: shchenz, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Glibc uses these new symbol names to support IEEE-754 128-bit

[PATCH] D116003: [NFC] Specify targets for clang stack-protector-guard.c

qiucf created this revision. qiucf added reviewers: tejohnson, MaskRay, lkail, nickdesaulniers. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The run line of `stack-protector-guard.c` doesn't specify the triple, which means it

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf created this revision. qiucf added reviewers: rzurob, jsji, nemanjai, shchenz, PowerPC. Herald added subscribers: kbarton, hiraditya. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently in Clang, we have

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf created this revision. qiucf added reviewers: nemanjai, jsji, shchenz, PowerPC, uweigand, MaskRay. Herald added subscribers: steven.zhang, kbarton. qiucf requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf added a comment. In D116016#3202148 , @MaskRay wrote: >> This is part of the efforts adding .gnu_attribute support for PowerPC. In >> Clang, an extra metadata field will be added as float-abi to show current >> long double format. So backend can

[PATCH] D116003: [NFC] Specify targets for clang stack-protector-guard.c

qiucf updated this revision to Diff 396379. qiucf marked 5 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116003/new/ https://reviews.llvm.org/D116003 Files: clang/test/CodeGen/stack-protector-guard.c Index:

[PATCH] D116016: [Clang] [PowerPC] Emit module flag for current float abi

qiucf updated this revision to Diff 397443. qiucf added a comment. Only emit the flags when any instance of `long double` is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116016/new/ https://reviews.llvm.org/D116016 Files:

[PATCH] D116003: [NFC] Specify targets for clang stack-protector-guard.c

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4039d17355b7: [NFC] Specify targets for clang stack-protector-guard.c (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D109751: [Clang] Support conversion between PPC double-double and IEEE float128

qiucf added a comment. In D109751#3191148 , @hubert.reinterpretcast wrote: > In D109751#3178494 , @qiucf wrote: > >> Thanks for the reminder. Here GCC and Clang diverges in the handling of >>

  1   2   3   >