[PATCH] D75701: Initialize IsSurrogate

respindola created this revision. respindola added a reviewer: rsmith. This fixes https://bugs.llvm.org/show_bug.cgi?id=45096 https://reviews.llvm.org/D75701 Files: clang/include/clang/Sema/Overload.h Index: clang/include/clang/Sema/Overload.h

[PATCH] D45054: Set dso_local on cfi_slowpath

espindola closed this revision. espindola added a comment. 328836 https://reviews.llvm.org/D45054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45054: Set dso_local on cfi_slowpath

espindola added a comment. In https://reviews.llvm.org/D45054#1052118, @eugenis wrote: > This looks wrong. cfi_slowpath is defined in libclang_rt.cfi, which is linked > to the main executable. It is not always dso-local. On Android it is defined > in libdl.so and is never dso-local. And we

[PATCH] D45052: Mark __cfi_check as dso_local

espindola closed this revision. espindola added a comment. 328825 https://reviews.llvm.org/D45052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45054: Set dso_local on cfi_slowpath

espindola created this revision. espindola added reviewers: rnk, echristo, eugenis. https://reviews.llvm.org/D45054 Files: lib/CodeGen/CGExpr.cpp test/CodeGen/cfi-icall-cross-dso.c Index: test/CodeGen/cfi-icall-cross-dso.c ===

[PATCH] D45052: Mark __cfi_check as dso_local

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D45052 Files: lib/CodeGen/CGExpr.cpp test/CodeGen/cfi-icall-cross-dso.c Index: test/CodeGen/cfi-icall-cross-dso.c === ---

[PATCH] D44723: Set dso_local when clearing dllimport

espindola closed this revision. espindola added a comment. 328801 https://reviews.llvm.org/D44723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44723: Set dso_local when clearing dllimport

espindola added a comment. ping https://reviews.llvm.org/D44723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44805: Set dso_local on __ImageBase

espindola closed this revision. espindola added a comment. 328266 https://reviews.llvm.org/D44805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44805: Set dso_local on __ImageBase

espindola created this revision. espindola added reviewers: echristo, rnk. https://reviews.llvm.org/D44805 Files: lib/CodeGen/MicrosoftCXXABI.cpp test/CodeGenCXX/dllexport.cpp Index: test/CodeGenCXX/dllexport.cpp === ---

[PATCH] D44796: Set dso_local on vtables

espindola accepted this revision. espindola added a comment. 328238 https://reviews.llvm.org/D44796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44796: Set dso_local on vtables

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44796 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/dllexport.cpp Index: test/CodeGenCXX/dllexport.cpp === ---

[PATCH] D44710: Set dso_local on builtin functions

espindola closed this revision. espindola added a comment. 328224 https://reviews.llvm.org/D44710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44723: Set dso_local when clearing dllimport

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44723 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/dllimport.cpp Index: test/CodeGenCXX/dllimport.cpp === ---

[PATCH] D44712: Set dso_local on runtime variables

espindola closed this revision. espindola added a comment. r328068 https://reviews.llvm.org/D44712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44712: Set dso_local on runtime variables

espindola created this revision. espindola added reviewers: rnk, echristo, eli.friedman. https://reviews.llvm.org/D44712 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/ubsan-vtable-checks.cpp Index: test/CodeGenCXX/ubsan-vtable-checks.cpp

[PATCH] D44706: Delete BuiltinCC

espindola closed this revision. espindola added a comment. r328050 https://reviews.llvm.org/D44706 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44710: Set dso_local on builtin functions

espindola created this revision. espindola added reviewers: rnk, echristo. With https://reviews.llvm.org/D44706 we can just forward to CreateRuntimeFunction. https://reviews.llvm.org/D44710 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/mingw-long-double.c Index:

[PATCH] D44706: Delete BuiltinCC

espindola created this revision. espindola added reviewers: rnk, echristo. It is always identical to RuntimeCC. https://reviews.llvm.org/D44706 Files: lib/CodeGen/ABIInfo.h lib/CodeGen/CGExprComplex.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenTypeCache.h

[PATCH] D44689: Set dso_local on string literals

espindola closed this revision. espindola added a comment. r328040 https://reviews.llvm.org/D44689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44688: Set dso_local for runtime functions

espindola closed this revision. espindola added a comment. 328036 https://reviews.llvm.org/D44688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44688: Set dso_local for runtime functions

espindola added a comment. In https://reviews.llvm.org/D44688#1043575, @rnk wrote: > lgtm > > We don't assume these are `dso_local` on Linux, right? Depends on shouldAssumeDSOLocal. We do if there is no -fPIC or -fPIE for example. https://reviews.llvm.org/D44688

[PATCH] D44688: Set dso_local for runtime functions

espindola created this revision. espindola added reviewers: rnk, echristo. This is another case where there is special logic for adding dllimport and so we cannot use setGVProperties. https://reviews.llvm.org/D44688 Files: lib/CodeGen/CodeGenModule.cpp

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

espindola added a comment. 327993 https://reviews.llvm.org/D44491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44649: Set dso_local for guid decls

espindola closed this revision. espindola added a comment. 327991 https://reviews.llvm.org/D44649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

espindola added a comment. ping https://reviews.llvm.org/D44491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44649: Set dso_local for guid decls

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44649 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGenCXX/microsoft-templ-uuidof.cpp Index: test/CodeGenCXX/microsoft-templ-uuidof.cpp

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

espindola created this revision. espindola added reviewers: rnk, echristo. This one cannot use setGVProperties since it has special logic for when it is dllimport or not. https://reviews.llvm.org/D44491 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/cfstring-windows.c Index:

[PATCH] D44482: Set dso_local for NSConcreteStackBlock

espindola closed this revision. espindola added a comment. r327544 https://reviews.llvm.org/D44482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44233: Set dso_local on external rtti GVs

espindola closed this revision. espindola added a comment. r327543 https://reviews.llvm.org/D44233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44482: Set dso_local for NSConcreteStackBlock

espindola created this revision. espindola added reviewers: rnk, echristo. https://reviews.llvm.org/D44482 Files: lib/CodeGen/CGBlocks.cpp test/CodeGen/blocks-windows.c Index: test/CodeGen/blocks-windows.c === ---

[PATCH] D44233: Set dso_local on external rtti GVs

espindola added a comment. ping https://reviews.llvm.org/D44233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44233: Set dso_local on external rtti GVs

espindola created this revision. espindola added a reviewer: rnk. In this particular case it would be possible to just add an else with CGM.setDSOLocal(GV), but it seems better to have as many callers as possible just call setGVProperties so that we can centralize the logic there. This patch

[PATCH] D43990: set dso_local on tls init functions

espindola closed this revision. espindola added a comment. r326961 https://reviews.llvm.org/D43990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43990: set dso_local on tls init functions

espindola added a comment. Richard, you added the setVisibility line, are you OK with the change? https://reviews.llvm.org/D43990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43990: set dso_local on tls init functions

espindola created this revision. espindola added a reviewer: echristo. We copy the visibility, so copying the dso_local flag seems the natural thing to do. https://reviews.llvm.org/D43990 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/runtime-dllstorage.cpp Index:

[PATCH] D43851: Start setting dllimport/dllexport in setGVProperties

espindola closed this revision. espindola added a comment. r326397 https://reviews.llvm.org/D43851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43851: Start setting dllimport/dllexport in setGVProperties

espindola added a comment. getting phab to send an email to cfe-commits https://reviews.llvm.org/D43851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43514: Start settinng dso_local for COFF

espindola closed this revision. espindola added a comment. 325915 https://reviews.llvm.org/D43514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43362: Simplify setting dso_local. NFC.

espindola closed this revision. espindola added a comment. r325846 https://reviews.llvm.org/D43362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43514: Start settinng dso_local for COFF

espindola updated this revision to Diff 135547. espindola added a comment. Address review comments. https://reviews.llvm.org/D43514 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenModule.cpp lib/CodeGen/CodeGenModule.h lib/CodeGen/ItaniumCXXABI.cpp test/CodeGen/aarch64-varargs-ms.c

[PATCH] D43514: Start settinng dso_local for COFF

espindola created this revision. espindola added a reviewer: rnk. Herald added subscribers: eraman, javed.absar. With this there are still some GVs where we don't set dso_local because setGVProperties is never called. I intend to fix that in followup commits. This is just the bare minimum to

[PATCH] D43362: Simplify setting dso_local. NFC.

espindola created this revision. espindola added a reviewer: rnk. The value of dso_local can be computed from just IR properties and global information (object file type, command line options, etc). With this patch we no longer pass in the Decl. It was almost unused and making it fully unused

[PATCH] D42924: Don't pass ForDefinition_t in places it is redundant.

espindola closed this revision. espindola added a comment. r324499 https://reviews.llvm.org/D42924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42924: Don't pass ForDefinition_t in places it is redundant.

espindola added a comment. Ping. https://reviews.llvm.org/D42924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42924: Don't pass ForDefinition_t in places it is redundant.

espindola created this revision. espindola added reviewers: sfertile, rnk. I found this while looking at the ppc failures caused by the dso_local change. The issue was that the patch would produce the wrong answer for available_externally. Having ForDefinition_t available in places where the

[PATCH] D41318: Start setting dso_local in clang

espindola closed this revision. espindola added a comment. r324107 https://reviews.llvm.org/D41318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41318: Start setting dso_local in clang

espindola updated this revision to Diff 132282. espindola added a comment. Handle ppc. https://reviews.llvm.org/D41318 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.cpp clang/lib/CodeGen/CodeGenModule.h

[PATCH] D41318: Start setting dso_local in clang

espindola updated this revision to Diff 131878. espindola added a comment. Rebased. Ping https://reviews.llvm.org/D41318 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CGVTT.cpp clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D42455: Don't create hidden dllimport global values

espindola closed this revision. espindola added a comment. 323361 https://reviews.llvm.org/D42455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41318: Start setting dso_local in clang

espindola updated this revision to Diff 130351. espindola added a comment. Herald added subscribers: niosHD, sabuasal, apazos, jordy.potman.lists, simoncook, johnrusso, rbar, asb. All tests have been updated. A few missing cases in c++ codegen are handled. We now use

[PATCH] D42208: Use an enum value instead of an string

espindola added a comment. 322792 https://reviews.llvm.org/D42208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42208: Use an enum value instea of an string

espindola created this revision. espindola added reviewers: rnk, rsmith. The old StringSwitch use was also broken. It assumed that a StringSwitch returns Optional instead of T and was missing a .Default. https://reviews.llvm.org/D42208 Files: clang/include/clang/Frontend/CodeGenOptions.h