Re: [PATCH] D11928: Small fixup

rnk added a comment. I added this code before C++11 migration. I wanted to explicitly default the copy ctor to document that it's a value type, rather than defaulting it implicitly. You can nuke both comments and uncomment the definition. http://reviews.llvm.org/D11928

Re: [PATCH] D11928: Small fixup

rnk added inline comments. Comment at: include/clang/AST/VTableBuilder.h:54 @@ -53,3 +53,3 @@ - VTableComponent() { } + VTableComponent() = default; Is this ctor used? It leaves Value uninitialized. Maybe we should delete it to ensure that it isn't called,

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

rnk accepted this revision. rnk added a comment. lgtm http://reviews.llvm.org/D11932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r245304 - We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

On Tue, Aug 18, 2015 at 11:26 AM, Chris Bieneman via cfe-commits cfe-commits@lists.llvm.org wrote: I don’t have access to gcc to test removing the flag there. I see no reason not to remove it for gcc, but I haven’t and can’t test it. Someone else will need to test it before committing. I

Re: [PATCH] D12109: [WinEH] Update to new EH pad/ret signatures (with tokens required)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D12109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12164: Stop treating -static as overriding -fPIC: they are distinct.

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. lgtm http://reviews.llvm.org/D12164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r244266 - [ItaniumCXXABI] Don't import RTTI data for classes with key functions

On Tue, Aug 18, 2015 at 3:00 PM, Richard Smith via cfe-commits cfe-commits@lists.llvm.org wrote: On Fri, Aug 14, 2015 at 11:27 AM, Hans Wennborg via cfe-commits cfe-commits@lists.llvm.org wrote: On Tue, Aug 11, 2015 at 1:41 PM, Hans Wennborg h...@chromium.org wrote: On Thu, Aug 6, 2015 at

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

I merged both of them and tweaked the test case to make it work. On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg h...@chromium.org wrote: On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg h...@chromium.org wrote: On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits cfe-commits

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

On Mon, Aug 10, 2015 at 6:40 PM, Richard Smith rich...@metafoo.co.uk wrote: On Mon, Aug 10, 2015 at 5:43 PM, Reid Kleckner r...@google.com wrote: On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith rich...@metafoo.co.uk wrote: On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits cfe

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

Yeah, let's do that. On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg h...@chromium.org wrote: On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits cfe-commits@lists.llvm.org wrote: Author: rnk Date: Mon Aug 10 14:39:01 2015 New Revision: 244488 URL: http://llvm.org/viewvc

r244925 - Try to fix new.cpp after r244920 to make it pass

Author: rnk Date: Thu Aug 13 13:10:32 2015 New Revision: 244925 URL: http://llvm.org/viewvc/llvm-project?rev=244925view=rev Log: Try to fix new.cpp after r244920 to make it pass Modified: cfe/trunk/test/CodeGenCXX/new.cpp Modified: cfe/trunk/test/CodeGenCXX/new.cpp URL:

Re: [PATCH] D7642: Introduce the idea of a minimum libc version

We could support that by allowing the MSVC version in the triple to be different from the -fms-compatibility-version on the command line. Today, this might even with with --target. That said, I don't imagine many people are doing this. Microsoft makes it hard for you to do this, and lots of code

[PATCH] D11913: [dllimport] A non-imported class with an imported key can't have a key

rnk created this revision. rnk added reviewers: majnemer, hans. rnk added a subscriber: cfe-commits. The vtable takes its DLL storage class from the class, not the key function. When they disagree, the vtable won't be exported by the DLL that defines the key function. The easiest way to ensure

Re: [PATCH] D11922: Add NaCl to long double/fp128 mangling test

rnk added a comment. In http://reviews.llvm.org/D11922#221185, @dschuff wrote: I'm not an expert in mangling, and I'm not 100% sure if this is right. The Itanium ABI's spec lists long double as the same as __float80. Should we use double in mangling instead? If you can have different

Re: [PATCH] D11922: Add NaCl to long double/fp128 mangling test

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Feel free to commit more test coverage like this with just post-commit review. http://reviews.llvm.org/D11922 ___ cfe-commits mailing list

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

On Mon, Aug 10, 2015 at 5:00 PM, Richard Smith rich...@metafoo.co.uk wrote: On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits cfe-commits@lists.llvm.org wrote: Author: rnk Date: Mon Aug 10 14:39:01 2015 New Revision: 244488 URL: http://llvm.org/viewvc/llvm-project?rev

r245083 - Don't run explicit-modules-missing-files.cpp on Windows

Author: rnk Date: Fri Aug 14 14:03:02 2015 New Revision: 245083 URL: http://llvm.org/viewvc/llvm-project?rev=245083view=rev Log: Don't run explicit-modules-missing-files.cpp on Windows It is flaky due to inability to remove files with open handles. We could paper over it with rm -f, but then

Re: [PATCH] D12137: Fix 4 typos in test/CodeGenCXX/

rnk closed this revision. rnk added a comment. Looks like this landed as r245817. http://reviews.llvm.org/D12137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

rnk added a comment. Rafael, we don't support pre GCC 4.7 mingw right? They switched to thiscall on 32bit, right? I think we can take a break for x64. http://reviews.llvm.org/D14179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r251387 - [coroutines] Creation of promise object, lookup of operator co_await, building

On Mon, Oct 26, 2015 at 11:02 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Modified: cfe/trunk/include/clang/Sema/ScopeInfo.h > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/ScopeInfo.h?rev=251387=251386=251387=diff > >

r251412 - Widen this enum bitfield by one bit to prevent sign extension in MSVC

Author: rnk Date: Tue Oct 27 11:24:03 2015 New Revision: 251412 URL: http://llvm.org/viewvc/llvm-project?rev=251412=rev Log: Widen this enum bitfield by one bit to prevent sign extension in MSVC Modified: cfe/trunk/include/clang/Sema/ScopeInfo.h Modified:

r251419 - [ms-inline-asm] Test case for alignment directive change in LLVM r251418

Author: rnk Date: Tue Oct 27 12:34:29 2015 New Revision: 251419 URL: http://llvm.org/viewvc/llvm-project?rev=251419=rev Log: [ms-inline-asm] Test case for alignment directive change in LLVM r251418 Added: cfe/trunk/test/CodeGen/ms-inline-asm-align.c Added:

Re: [PATCH] D13969: Tweak how -Wunused-value interacts with macros

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, I don't feel strongly about whether -fms-compatibility matters, but I'd prefer that it didn't. Comment at: lib/Sema/SemaStmt.cpp:224 @@ +223,3 @@ + // but its

Re: [PATCH] D13978: [X86] Support MCU psABI when marking inregs

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm with the suggested simplification. Comment at: lib/CodeGen/TargetInfo.cpp:857 @@ -854,3 +856,3 @@ IsWin32StructABI(Win32StructABI), - IsSoftFloatABI(SoftFloatABI),

r250954 - [Driver] Alias -fvisibility=internal to -fvisibility=hidden

Author: rnk Date: Wed Oct 21 17:01:02 2015 New Revision: 250954 URL: http://llvm.org/viewvc/llvm-project?rev=250954=rev Log: [Driver] Alias -fvisibility=internal to -fvisibility=hidden The ELF symbol visibilities are: - internal: Not visibile across DSOs, cannot pass address across DSOs -

r252659 - [COFF] Don't try to emit weak aliases on COFF

Author: rnk Date: Tue Nov 10 16:23:58 2015 New Revision: 252659 URL: http://llvm.org/viewvc/llvm-project?rev=252659=rev Log: [COFF] Don't try to emit weak aliases on COFF This comes up when a derived class destructor is equivalent to a base class destructor defined in the same TU, and we try to

r251810 - Sink some PTHManager includes out of Preprocessor.h

Author: rnk Date: Mon Nov 2 11:53:55 2015 New Revision: 251810 URL: http://llvm.org/viewvc/llvm-project?rev=251810=rev Log: Sink some PTHManager includes out of Preprocessor.h This reduces the number of .cpp files needed to be rebuilt after touching OnDiskHashTable from 120 to 21 for me.

r251828 - [PTH] Fix data length used for stat cache entries

Author: rnk Date: Mon Nov 2 14:47:31 2015 New Revision: 251828 URL: http://llvm.org/viewvc/llvm-project?rev=251828=rev Log: [PTH] Fix data length used for stat cache entries This came up in a boost build, which apparently uses PTH. This was broken in r187619 when we migrated it to uses llvm::fs

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. > ! In http://reviews.llvm.org/D14180#280193, @martell wrote: > > > You can then change the mingw headers to use > > `__has_builtin(_InterlockedCompareExchange)` to provide compatibility with > > either mode. > > > Yes I could do this but this still won't work with

r252107 - Fix nullptr crash in -Wthread-safety-beta

Author: rnk Date: Wed Nov 4 18:24:01 2015 New Revision: 252107 URL: http://llvm.org/viewvc/llvm-project?rev=252107=rev Log: Fix nullptr crash in -Wthread-safety-beta Modified: cfe/trunk/include/clang/Analysis/Analyses/ThreadSafetyCommon.h

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. In http://reviews.llvm.org/D14180#279962, @martell wrote: > In http://reviews.llvm.org/D14180#279651, @rnk wrote: > > > Will Clang be able to compile the last few stable mingw-w64 releases with > > this change? I'd like that to keep working. > > > Clang has not been able to

Re: [PATCH] D14285: [x86] Additional small fix for MCU psABI support

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D14285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. I'd like clang to work out of the box with mingw-w64 releases from at least the past year. You're mostly interested in the non-builtin parts of -fms-extensions, like declspec and UUID, right? One way we could do this is to enable -fms-extensions in mingw but then suppress

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

rnk added a comment. This is an interesting test case, though: inline int foo() { static int __attribute__((internal_linkage)) x; return x++; } If foo gets inlined, those call sites will use and update 'x'. If foo is not inlined, one definition of foo will win, and every caller

Re: [PATCH] D14179: Remove some legacy mingw-w64 gcc struct info

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Yeah, lgtm. http://reviews.llvm.org/D14179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

rnk created this revision. rnk added reviewers: danalbert, mclow.lists. rnk added a subscriber: cfe-commits. According to Clang's sources, the maximum supported storage alignment is a property of the COFF object file format. Fixes building libc++ with Clang on Windows.

Re: [PATCH] D13925: Implement __attribute__((internal_linkage))

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. I'm happy with this. Richard, what do you think? Repository: rL LLVM http://reviews.llvm.org/D13925 ___ cfe-commits

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. Will Clang be able to compile the last few stable mingw-w64 releases with this change? I'd like that to keep working. http://reviews.llvm.org/D14180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r249616 - [WinEH] Don't use lifetime markers for MS catch parameters

Author: rnk Date: Wed Oct 7 16:03:41 2015 New Revision: 249616 URL: http://llvm.org/viewvc/llvm-project?rev=249616=rev Log: [WinEH] Don't use lifetime markers for MS catch parameters We don't have a good place to put them. Our previous spot was causing us to optimize loads from the exception

r249647 - [WinEH] Remove NewMSEH and enable its behavior by default

Author: rnk Date: Wed Oct 7 20:13:52 2015 New Revision: 249647 URL: http://llvm.org/viewvc/llvm-project?rev=249647=rev Log: [WinEH] Remove NewMSEH and enable its behavior by default Testing has shown that it is at least as reliable as the old landingpad pattern matching code. Removed:

r249640 - Don't emit exceptional stackrestore cleanups around inalloca functions

Author: rnk Date: Wed Oct 7 19:17:45 2015 New Revision: 249640 URL: http://llvm.org/viewvc/llvm-project?rev=249640=rev Log: Don't emit exceptional stackrestore cleanups around inalloca functions The backend restores the stack pointer after recovering from an exception. This is similar to

r249704 - [clang-cl] Make /EHs turn on C++ EH once again

Author: rnk Date: Thu Oct 8 12:29:07 2015 New Revision: 249704 URL: http://llvm.org/viewvc/llvm-project?rev=249704=rev Log: [clang-cl] Make /EHs turn on C++ EH once again C++ exceptions are still off by default, which is similar to how C++ cleanups are off by default in MSVC. If you use clang

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

rnk added a comment. Looks like this got committed. Sorry for the delay, I was travelling. http://reviews.llvm.org/D12832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13549: Added new options to ClangFormat VSIX package.

rnk added a comment. In http://reviews.llvm.org/D13549#267790, @klimek wrote: > We're waiting for Reid to find somebody who is good at reviewing this in > detail. > Sorry it takes a while, so far we don't have enough trusted Windows experts > in the community :( Oops, I didn't know that.

r250774 - Revert "Diagnose UnresolvedLookupExprs that resolve to instance members in static methods"

Author: rnk Date: Mon Oct 19 19:31:42 2015 New Revision: 250774 URL: http://llvm.org/viewvc/llvm-project?rev=250774=rev Log: Revert "Diagnose UnresolvedLookupExprs that resolve to instance members in static methods" This reverts commit r250592. It has issues around unevaluated contexts, like

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

rnk added a subscriber: rnk. rnk added a comment. I spent some time reading through the pseudo-object implementation in clang, but I still don't understand it. We should ask John if he can review this. My gut feeling is that we shouldn't have a global DenseMap in Sema just for this. Should we

r250839 - Look through using decls when classifying implicit member access

Author: rnk Date: Tue Oct 20 13:12:08 2015 New Revision: 250839 URL: http://llvm.org/viewvc/llvm-project?rev=250839=rev Log: Look through using decls when classifying implicit member access Clang will now accept this valid C++11 code: struct A { int field; }; struct B : A { using

r250844 - Add back null check removed accidentally in r250554

Author: rnk Date: Tue Oct 20 13:45:57 2015 New Revision: 250844 URL: http://llvm.org/viewvc/llvm-project?rev=250844=rev Log: Add back null check removed accidentally in r250554 Fixes PR25262 Added: cfe/trunk/test/Frontend/force-include-not-found.c Modified:

r250856 - Re-land r250592 without rejecting field refs in unevaluated contexts

Author: rnk Date: Tue Oct 20 16:04:13 2015 New Revision: 250856 URL: http://llvm.org/viewvc/llvm-project?rev=250856=rev Log: Re-land r250592 without rejecting field refs in unevaluated contexts This time, I went with the first approach from http://reviews.llvm.org/D6700, where clang actually

r250592 - Diagnose UnresolvedLookupExprs that resolve to instance members in static methods

Author: rnk Date: Fri Oct 16 19:19:04 2015 New Revision: 250592 URL: http://llvm.org/viewvc/llvm-project?rev=250592=rev Log: Diagnose UnresolvedLookupExprs that resolve to instance members in static methods During the initial template parse for this code, 'member' is unresolved and we don't

Re: [PATCH] D6700: Diagnose UnresolvedLookupExprs that resolve to instance members in static methods

This revision was automatically updated to reflect the committed changes. rnk marked an inline comment as done. Closed by commit rL250592: Diagnose UnresolvedLookupExprs that resolve to instance members in static… (authored by rnk). Changed prior to commit:

Re: [PATCH] D13554: [X86] Enable soft float ABI for x86

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Sorry, took me a while to read the document and understand why you want `float inreg`. I think we overload LLVM inreg to mean "put this float / double in an SSE register", but I think it's

r249748 - [WinEH] Push cleanupendpad scopes around exceptional cleanups

Author: rnk Date: Thu Oct 8 16:14:56 2015 New Revision: 249748 URL: http://llvm.org/viewvc/llvm-project?rev=249748=rev Log: [WinEH] Push cleanupendpad scopes around exceptional cleanups We were only doing this for SEH as a special case. Generalize it to all cleanups. Modified:

Re: [PATCH] D13407: [libcxx] Capture configuration information when installing the libc++ headers

rnk added a subscriber: rnk. Comment at: include/CMakeLists.txt:31 @@ +30,3 @@ +# by prepending __config_site to the current __config header. +# TODO(EricWF) Is it portable to use "cat" and ">>"? +add_custom_command(OUTPUT ${LIBCXX_BINARY_DIR}/__generated_config

r249497 - [SEH] Fix x64 __exception_code in __except blocks

Author: rnk Date: Tue Oct 6 20:07:13 2015 New Revision: 249497 URL: http://llvm.org/viewvc/llvm-project?rev=249497=rev Log: [SEH] Fix x64 __exception_code in __except blocks Use llvm.eh.exceptioncode to get the code out of EAX for x64. For 32-bit, the filter is responsible for storing it to

Re: [PATCH] D13375: [MSVC] Fix for http://llvm.org/PR24132: __declspec(property): double invocations of foo() when compiling foo()->propertyName

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Thanks, sorry for the delay, EH was keeping me busy. =/ http://reviews.llvm.org/D13375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D6700: Diagnose UnresolvedLookupExprs that resolve to instance members in static methods

rnk added inline comments. Comment at: lib/Sema/TreeTransform.h:9138 @@ +9137,3 @@ + isa(D)) +return getSema().BuildPossibleImplicitMemberExpr( +SS, SourceLocation(), R, /*TemplateArgs=*/nullptr, I believe this will always fail, so

Re: [PATCH] D6700: Instantiate UnresolvedLookupExpr to MemberExpr when appropriate

rnk added a comment. Richard suggested that maybe we formed the wrong AST while parsing the template. I'm not sure that's the case. We have this very explicit logic that controls what AST nodes we form in SemaExprMember.cpp ClassifyImplicitMemberAccess: bool isStaticContext =

Re: [PATCH] D6700: Instantiate UnresolvedLookupExpr to MemberExpr when appropriate

rnk updated this revision to Diff 37283. rnk added a comment. - Rebase http://reviews.llvm.org/D6700 Files: lib/Sema/TreeTransform.h test/SemaTemplate/instantiate-using-decl.cpp Index: test/SemaTemplate/instantiate-using-decl.cpp

Re: [PATCH] D6700: Diagnose UnresolvedLookupExprs that resolve to instance members in static methods

rnk updated this revision to Diff 37303. rnk added a comment. - Remove duplicate tests, beef them up http://reviews.llvm.org/D6700 Files: include/clang/Sema/Sema.h lib/Sema/SemaExprMember.cpp lib/Sema/TreeTransform.h test/SemaCXX/using-decl-1.cpp

r249846 - Fix VFS GCC unittest on Windows

Author: rnk Date: Fri Oct 9 11:48:52 2015 New Revision: 249846 URL: http://llvm.org/viewvc/llvm-project?rev=249846=rev Log: Fix VFS GCC unittest on Windows Modified: cfe/trunk/unittests/Driver/ToolChainTest.cpp Modified: cfe/trunk/unittests/Driver/ToolChainTest.cpp URL:

Re: r252853 - libclang: add clang_Cursor_getCXXManglings

This introduced a memory leak, which I'm testing a patch for. Aside from that, did you get Doug to review this? We probably want to be really careful about changing libclang's C API, so you should be more cautious here than you would be normally. On Wed, Nov 11, 2015 at 7:57 PM, Saleem

Re: [PATCH] D14467: [MS] Fix for bug 25013 - #pragma vtordisp is unknown inside functions.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I went ahead and ran some of your test cases through MSVC, and I agree with your results. This is pretty interesting behavior. Thanks for looking into it! Looks good. Comment at:

Re: [PATCH] D12278: [X86] Add MSVC-compatible intrinsics for clac, stac, lgdt and sgdt

rnk added inline comments. Comment at: lib/Headers/Intrin.h:961 @@ +960,3 @@ +static __inline__ void __DEFAULT_FN_ATTRS _lgdt(void *__ptr) { + __builtin_ia32_lgdt(__ptr); +} compnerd wrote: mkuper wrote: compnerd wrote: Why does this need a builtin? Is an

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk added a comment. MSVC appears to ignore __stdcall on virtual destructors, and I think the correct fix is for us to do the same. See this test case: $ cat t.cpp struct A { virtual __stdcall ~A(); }; A::~A() {} $ cl -c t.cpp Microsoft (R) C/C++ Optimizing Compiler Version

r246088 - [ms-inline-asm] Add field access to MS inline asm identifier lookup

Author: rnk Date: Wed Aug 26 16:57:20 2015 New Revision: 246088 URL: http://llvm.org/viewvc/llvm-project?rev=246088view=rev Log: [ms-inline-asm] Add field access to MS inline asm identifier lookup Now we can parse code like this: struct A { int field; }; int f(A o) { __asm mov eax,

Re: [PATCH] D12087: always_inline codegen rewrite

rnk added a subscriber: rnk. Comment at: lib/CodeGen/CodeGenModule.cpp:469-470 @@ +468,4 @@ + llvm::LLVMContext = getModule().getContext(); + llvm::Function *StubFn = + llvm::Function::Create(FT, Fn->getLinkage(), Name, ()); + assert(StubFn->getName() == Name && "name

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk added inline comments. Comment at: lib/Sema/SemaType.cpp:5855-5856 @@ -5854,3 +5854,4 @@ CallingConv CurCC = FT->getCallConv(); - CallingConv FromCC = + CallingConv DefaultCC = Context.getDefaultCallingConvention(IsVariadic, IsStatic); + CallingConv ToCC;

Re: Patch for PR23472

LGTM, but I would expand on the comment a bit: // The ABI says: "It is suggested that it be emitted in the same COMDAT group // as the associated data object." In practice, this doesn't work for non-ELF object formats, so only do it for ELF. On Thu, Sep 3, 2015 at 11:31 AM, Rafael

Re: [PATCH] D12412: [CodeGen] Point empty %invoke.cont block to successor

rnk added a subscriber: rnk. rnk added a comment. I think a better fix would be to insert a non-terminator placeholder that doesn't confuse EmitBlock. http://reviews.llvm.org/D12412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r246889 - Relax partial-init test case for ARM

Author: rnk Date: Fri Sep 4 17:32:51 2015 New Revision: 246889 URL: http://llvm.org/viewvc/llvm-project?rev=246889=rev Log: Relax partial-init test case for ARM Modified: cfe/trunk/test/CodeGenCXX/partial-init.cpp Modified: cfe/trunk/test/CodeGenCXX/partial-init.cpp URL:

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. This looks fine, just make sure the indentation is right. Phab seems confused. Repository: rL LLVM http://reviews.llvm.org/D12466 ___ cfe-commits

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

rnk added a subscriber: rnk. rnk added a comment. I think a better approach would be to use `__attribute__((init_priority(101)))` on Linux and `#pragma init_seg(lib)` on Windows to ensure that libc++'s iostream initializer runs earlier. http://reviews.llvm.org/D12689

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

rnk added a comment. There's a bunch of whitespace issues that clang-format can resolve. We also have the convention that variables are StudlyCaps, which isn't followed in a few places. Do you need someone to commit this for you? If so, I can patch this in, test it manually, and deal with the

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

This revision was automatically updated to reflect the committed changes. Closed by commit rL247362: [Driver] Use UniversalCRT on Windows if available (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D12695?vs=34475=34515#toc Repository: rL LLVM

r247362 - [Driver] Use UniversalCRT on Windows if available

Author: rnk Date: Thu Sep 10 19:09:39 2015 New Revision: 247362 URL: http://llvm.org/viewvc/llvm-project?rev=247362=rev Log: [Driver] Use UniversalCRT on Windows if available Summary: With Visual Studio 2015 release, a part of runtime library was extracted and now comes with Windows Kits. This

r247351 - Handle '-r' option properly

Author: rnk Date: Thu Sep 10 17:31:45 2015 New Revision: 247351 URL: http://llvm.org/viewvc/llvm-project?rev=247351=rev Log: Handle '-r' option properly Summary: This fixs the bug https://llvm.org/bugs/show_bug.cgi?id=12587 Patch by Yunlian Jiang Reviewers: Bigcheese, rnk Differential

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Comment at: test/CodeGenCXX/ctor-dtor-alias.cpp:170 @@ -169,3 +169,3 @@ // it has a different calling conversion. - // CHECK4: call void @_ZN5test93barD2Ev + //

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rnk added a comment. Right, I understand the behavior change, I'm just wondering why it results in link failures. There isn't a ton of public info about how ObjC++ EH interacts with C++ EH. Repository: rL LLVM http://reviews.llvm.org/D12743

Re: [PATCH] D12743: [CodeGen] Teach SimplifyPersonality about the updated LandingPadInst

rnk added a subscriber: rnk. rnk added a comment. I'm confused. I thought SimplifyPersonalityFunction was an optimization, but somehow it caused link failures? Why do you think this was an ABI break? Comment at: test/CodeGenObjCXX/exception-cxx.mm:8 @@ +7,3 @@ + throw 0;

r247434 - Update test expectations for LLVM asm printing change

Author: rnk Date: Fri Sep 11 12:27:53 2015 New Revision: 247434 URL: http://llvm.org/viewvc/llvm-project?rev=247434=rev Log: Update test expectations for LLVM asm printing change Modified: cfe/trunk/test/CodeGen/exceptions-seh-new.c Modified: cfe/trunk/test/CodeGen/exceptions-seh-new.c URL:

r247843 - [WinEH] Pass the catch adjectives to catchpad directly

Author: rnk Date: Wed Sep 16 15:15:55 2015 New Revision: 247843 URL: http://llvm.org/viewvc/llvm-project?rev=247843=rev Log: [WinEH] Pass the catch adjectives to catchpad directly This avoids building a fake LLVM IR global variable just to ferry an i32 down into LLVM codegen. It also puts a nail

Re: [PATCH] D12832: [Driver] Add support for Windows 10 SDK

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks like I forgot to submit the comments I wrote. Anyway, looks good. Comment at: cfe/trunk/lib/Driver/MSVCToolChain.cpp:238 @@ +237,3 @@ + continue; +const StringRef

r247902 - Use the MSVC SEH personalities on Mingw

Author: rnk Date: Thu Sep 17 12:04:13 2015 New Revision: 247902 URL: http://llvm.org/viewvc/llvm-project?rev=247902=rev Log: Use the MSVC SEH personalities on Mingw Mingw generally wraps an old copy of msvcrt.dll which has these personalities, so things should work out, or so I hear. I haven't

Re: [PATCH] D1623: Support __builtin_ms_va_list.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I think this is ready. http://reviews.llvm.org/D1623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk added inline comments. Comment at: lib/Sema/SemaType.cpp:5876 @@ +5875,3 @@ + +if (!IsCtorOrDtor) { + if (CurCC != DefaultCC || DefaultCC == ToCC) This looks like the !IsCtorOrDtor check that affects Itanium. Isn't it already handled for MS C++

Re: [PATCH] D13223: Generate assume loads only with -fstrict-vtable-pointers

rnk added a subscriber: rnk. rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D13223 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r248925 - [Sema] Avoid crashing during this-> insertion recovery

Author: rnk Date: Wed Sep 30 12:30:48 2015 New Revision: 248925 URL: http://llvm.org/viewvc/llvm-project?rev=248925=rev Log: [Sema] Avoid crashing during this-> insertion recovery We get into this bad state when someone defines a new member function for a class but forgets to add the declaration

Re: [PATCH] D13336: [MSVC] 'property' with an empty array in array subscript expression.

rnk added a comment. I think fundamentally we are doing too much declspec property lowering in Sema. We might want to back up and figure out how to do it in IRGen. Right now we have bugs like this, which are probably more important than new functionality:

Re: [PATCH] D12689: [libc++][static linking] std streams are not initialized prior to their use in static object constructors

I think you need to address the feedback about avoiding dynamic initialization on stock non-Mac systems. Sent from phone On Sep 21, 2015 8:33 AM, "Evgeny Astigeevich" wrote: > eastig added a comment. > > Ping. > > > http://reviews.llvm.org/D12689 > > > >

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

rnk accepted this revision. rnk added a reviewer: rnk. rnk added a comment. This revision is now accepted and ready to land. Ouch, that 2012 vector passing ABI break is a bummer. :( Comment at: lib/CodeGen/TargetInfo.cpp:5236 @@ +5235,3 @@ + if (const VectorType *VT =

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

rnk added a comment. lgtm http://reviews.llvm.org/D14639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D15384: Don't ask for the size of dependent integral types in template diffing

rnk created this revision. rnk added a reviewer: rsmith. rnk added a subscriber: cfe-commits. In the following example, we end up diffing 'A' against 'A<>'. template struct A {}; template > R bar(); A<> () { return bar(); } It appears that we end up comparing the default argument

Re: r254195 - [x86] Exclusion of incorrect include headers paths for MCU target

It looks like the wrong patch got committed with the original description of D14954 . I reverted it in r254823. Feel free to commit the header change, it looks fine. On Fri, Nov 27, 2015 at 5:57 AM, Hal Finkel via cfe-commits < cfe-commits@lists.llvm.org> wrote:

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. In http://reviews.llvm.org/D14180#300193, @martell wrote: > @rnk you are correct. > mingw-w64 has been updated accordingly > > http://sourceforge.net/p/mingw-w64/mingw-w64/ci/61c374ded91a7de66f42f85a9f0cf9ee20/ > > So where do we go from here ? Let's disable the

Re: [PATCH] D14639: LLDB JIT needs android vector passing rules.

rnk added a subscriber: rnk. rnk added a comment. Were these changes made to AOSP Clang to match upstream GCC, or some custom Android version of GCC? Where would one go to find ground truth on how these types should be passed? http://reviews.llvm.org/D14639

Re: [PATCH] D14180: enable -fms-extensions by default on the mingw-w64 target

rnk added a comment. In http://reviews.llvm.org/D14180#299183, @martell wrote: > I tried testing __has_builtin(_InterlockedCompareExchangeAdd) as it seem to > not exist even when -fms-extensions is passed > Is this a bug or it is intended ? Neither Clang nor MSDN have anything by that name.

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

It wasn't Chrome, it was some internal dependency on torch-cephes. I submitted a patch for it upstream: https://github.com/deepmind/torch-cephes/commit/9c4a97c90dc200ecbecb883e7230fe3c847954df It's not a pretty, though. I know LLVM IR rules are not C++ rules, but LLVM generally believes in NaN.

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

rnk added a subscriber: rnk. Comment at: include/clang/Sema/Sema.h:2938 @@ -2937,2 +2937,3 @@ bool CheckRegparmAttr(const AttributeList , unsigned ); + bool getCCFromAttr(const AttributeList , CallingConv ); bool CheckCallingConvAttr(const AttributeList , CallingConv ,

r255176 - Fix crash on invalid initialization with std::initializer_list

Author: rnk Date: Wed Dec 9 17:18:38 2015 New Revision: 255176 URL: http://llvm.org/viewvc/llvm-project?rev=255176=rev Log: Fix crash on invalid initialization with std::initializer_list It is possible for CheckListElementTypes to fail without filling in any initializer list elements.

  1   2   3   4   5   6   7   8   9   10   >