Author: Saiyedul Islam
Date: 2020-08-27T20:57:17Z
New Revision: a1ac047b3453f205eacc36adc787ac31b952a502
URL:
https://github.com/llvm/llvm-project/commit/a1ac047b3453f205eacc36adc787ac31b952a502
DIFF:
https://github.com/llvm/llvm-project/commit/a1ac047b3453f205eacc36adc787ac31b952a502.diff
Author: Saiyedul Islam
Date: 2020-05-27T07:51:27Z
New Revision: 602d9b0afc77828f419869289b159a567c62ae81
URL:
https://github.com/llvm/llvm-project/commit/602d9b0afc77828f419869289b159a567c62ae81
DIFF:
https://github.com/llvm/llvm-project/commit/602d9b0afc77828f419869289b159a567c62ae81.diff
Author: Saiyedul Islam
Date: 2020-08-03T05:38:39Z
New Revision: 160ff83765ac284f3c7dd7b25d4ef105b9952ac0
URL:
https://github.com/llvm/llvm-project/commit/160ff83765ac284f3c7dd7b25d4ef105b9952ac0
DIFF:
https://github.com/llvm/llvm-project/commit/160ff83765ac284f3c7dd7b25d4ef105b9952ac0.diff
Author: Saiyedul Islam
Date: 2020-08-13T07:37:10Z
New Revision: eaa341fbea961894759355256d25d785509002ef
URL:
https://github.com/llvm/llvm-project/commit/eaa341fbea961894759355256d25d785509002ef
DIFF:
https://github.com/llvm/llvm-project/commit/eaa341fbea961894759355256d25d785509002ef.diff
Author: Saiyedul Islam
Date: 2020-07-07T06:36:25Z
New Revision: 0882c9d4fc49858338c9655154f1ad8357a8e516
URL:
https://github.com/llvm/llvm-project/commit/0882c9d4fc49858338c9655154f1ad8357a8e516
DIFF:
https://github.com/llvm/llvm-project/commit/0882c9d4fc49858338c9655154f1ad8357a8e516.diff
Author: Saiyedul Islam
Date: 2020-06-10T18:09:59Z
New Revision: 4022bc2a6c5e585d99a76b1b2f14c2986b823ce9
URL:
https://github.com/llvm/llvm-project/commit/4022bc2a6c5e585d99a76b1b2f14c2986b823ce9
DIFF:
https://github.com/llvm/llvm-project/commit/4022bc2a6c5e585d99a76b1b2f14c2986b823ce9.diff
Author: Saiyedul Islam
Date: 2020-06-09T17:02:58Z
New Revision: 675cefbf60270f59057972e33365a09590fb3694
URL:
https://github.com/llvm/llvm-project/commit/675cefbf60270f59057972e33365a09590fb3694
DIFF:
https://github.com/llvm/llvm-project/commit/675cefbf60270f59057972e33365a09590fb3694.diff
Author: Saiyedul Islam
Date: 2020-07-21T05:25:46Z
New Revision: fc7d2908ab38e1934b3b6a8ab3ec5c674484434b
URL:
https://github.com/llvm/llvm-project/commit/fc7d2908ab38e1934b3b6a8ab3ec5c674484434b
DIFF:
https://github.com/llvm/llvm-project/commit/fc7d2908ab38e1934b3b6a8ab3ec5c674484434b.diff
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfc7d2908ab38: [OpenMP] Use common interface to access GPU
Grid Values (authored by saiislam).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
Author: Saiyedul Islam
Date: 2021-06-30T17:55:50+05:30
New Revision: f7ce532d622dc26eddd25f87faec0ff35dc0c2e9
URL:
https://github.com/llvm/llvm-project/commit/f7ce532d622dc26eddd25f87faec0ff35dc0c2e9
DIFF:
Author: Saiyedul Islam
Date: 2021-07-07T14:30:57+05:30
New Revision: 94d5f2afbef0bc18cf92f6d147c336da990e7a40
URL:
https://github.com/llvm/llvm-project/commit/94d5f2afbef0bc18cf92f6d147c336da990e7a40
DIFF:
Author: Saiyedul Islam
Date: 2021-09-01T16:00:29+05:30
New Revision: 83f3782c6129e7a5df3faaf0ae576611d16a8d49
URL:
https://github.com/llvm/llvm-project/commit/83f3782c6129e7a5df3faaf0ae576611d16a8d49
DIFF:
Author: Saiyedul Islam
Date: 2021-09-06T11:43:58+05:30
New Revision: e15836361cdfeb3a717a2ebae94c68286111369b
URL:
https://github.com/llvm/llvm-project/commit/e15836361cdfeb3a717a2ebae94c68286111369b
DIFF:
Author: Saiyedul Islam
Date: 2021-09-09T23:55:15+05:30
New Revision: 543604f30eddc5c9390d0fb01b0ac67937cbba0e
URL:
https://github.com/llvm/llvm-project/commit/543604f30eddc5c9390d0fb01b0ac67937cbba0e
DIFF:
Author: Saiyedul Islam
Date: 2021-09-10T18:57:03+05:30
New Revision: 4a25c3fb61942c629907ae50462087c3fbb8703a
URL:
https://github.com/llvm/llvm-project/commit/4a25c3fb61942c629907ae50462087c3fbb8703a
DIFF:
Author: Saiyedul Islam
Date: 2021-09-08T16:06:12+05:30
New Revision: 98380762c3b734c23d206182605ab9e035c93caa
URL:
https://github.com/llvm/llvm-project/commit/98380762c3b734c23d206182605ab9e035c93caa
DIFF:
Author: Saiyedul Islam
Date: 2021-10-08T09:37:51Z
New Revision: 35ebe4cc24f87397762e35831953c4bfe5f52def
URL:
https://github.com/llvm/llvm-project/commit/35ebe4cc24f87397762e35831953c4bfe5f52def
DIFF:
https://github.com/llvm/llvm-project/commit/35ebe4cc24f87397762e35831953c4bfe5f52def.diff
Author: Saiyedul Islam
Date: 2021-10-12T16:15:52Z
New Revision: f56548829c4c696d798c252bf097b71538bd45d7
URL:
https://github.com/llvm/llvm-project/commit/f56548829c4c696d798c252bf097b71538bd45d7
DIFF:
https://github.com/llvm/llvm-project/commit/f56548829c4c696d798c252bf097b71538bd45d7.diff
Author: Saiyedul Islam
Date: 2021-10-07T04:45:19Z
New Revision: 4c4117089599cb5b6c6fa5635c28462ffd1bddf4
URL:
https://github.com/llvm/llvm-project/commit/4c4117089599cb5b6c6fa5635c28462ffd1bddf4
DIFF:
https://github.com/llvm/llvm-project/commit/4c4117089599cb5b6c6fa5635c28462ffd1bddf4.diff
Author: Saiyedul Islam
Date: 2021-10-07T05:54:56Z
New Revision: 06404d5488ea505b00f711393973db3ae32d01e9
URL:
https://github.com/llvm/llvm-project/commit/06404d5488ea505b00f711393973db3ae32d01e9
DIFF:
https://github.com/llvm/llvm-project/commit/06404d5488ea505b00f711393973db3ae32d01e9.diff
Author: Saiyedul Islam
Date: 2021-10-07T13:38:46Z
New Revision: 2baf7ad6d27fc9c08dd6eb9f8581d7e1353d4ece
URL:
https://github.com/llvm/llvm-project/commit/2baf7ad6d27fc9c08dd6eb9f8581d7e1353d4ece
DIFF:
https://github.com/llvm/llvm-project/commit/2baf7ad6d27fc9c08dd6eb9f8581d7e1353d4ece.diff
Author: Saiyedul Islam
Date: 2021-10-07T14:13:24Z
New Revision: 94e2b0258a176c7451dd8291cdf060ea048fee44
URL:
https://github.com/llvm/llvm-project/commit/94e2b0258a176c7451dd8291cdf060ea048fee44
DIFF:
https://github.com/llvm/llvm-project/commit/94e2b0258a176c7451dd8291cdf060ea048fee44.diff
Author: Saiyedul Islam
Date: 2021-10-07T14:13:24Z
New Revision: 1097f48e3dc3ab6811419f867350e79e280fb0eb
URL:
https://github.com/llvm/llvm-project/commit/1097f48e3dc3ab6811419f867350e79e280fb0eb
DIFF:
https://github.com/llvm/llvm-project/commit/1097f48e3dc3ab6811419f867350e79e280fb0eb.diff
Author: Saiyedul Islam
Date: 2021-10-07T14:13:24Z
New Revision: 3eb44f4d28df3d9e9528b8b9f8f6b93ab4c2af67
URL:
https://github.com/llvm/llvm-project/commit/3eb44f4d28df3d9e9528b8b9f8f6b93ab4c2af67
DIFF:
https://github.com/llvm/llvm-project/commit/3eb44f4d28df3d9e9528b8b9f8f6b93ab4c2af67.diff
Author: Saiyedul Islam
Date: 2021-09-21T19:24:44+05:30
New Revision: ee31ad0ab5f7d443b0bd582582a3524dcf7f13f0
URL:
https://github.com/llvm/llvm-project/commit/ee31ad0ab5f7d443b0bd582582a3524dcf7f13f0
DIFF:
Author: Saiyedul Islam
Date: 2022-01-04T11:51:31Z
New Revision: 32357266fd055e0eba63fc321f31a1c88eae0ea8
URL:
https://github.com/llvm/llvm-project/commit/32357266fd055e0eba63fc321f31a1c88eae0ea8
DIFF:
https://github.com/llvm/llvm-project/commit/32357266fd055e0eba63fc321f31a1c88eae0ea8.diff
Author: Saiyedul Islam
Date: 2022-01-04T12:30:43Z
New Revision: 49f23afdc3453ad6834f32f69b48aa88b5d17338
URL:
https://github.com/llvm/llvm-project/commit/49f23afdc3453ad6834f32f69b48aa88b5d17338
DIFF:
https://github.com/llvm/llvm-project/commit/49f23afdc3453ad6834f32f69b48aa88b5d17338.diff
Author: Saiyedul Islam
Date: 2022-01-12T05:24:49Z
New Revision: 876b5ea96bf5890074aec61bc2c6a37b2cdc0617
URL:
https://github.com/llvm/llvm-project/commit/876b5ea96bf5890074aec61bc2c6a37b2cdc0617
DIFF:
https://github.com/llvm/llvm-project/commit/876b5ea96bf5890074aec61bc2c6a37b2cdc0617.diff
Author: Saiyedul Islam
Date: 2022-03-02T07:55:06Z
New Revision: 7a02abf06ff94762d8cbce71d0249df25d64721b
URL:
https://github.com/llvm/llvm-project/commit/7a02abf06ff94762d8cbce71d0249df25d64721b
DIFF:
https://github.com/llvm/llvm-project/commit/7a02abf06ff94762d8cbce71d0249df25d64721b.diff
Author: Saiyedul Islam
Date: 2022-03-02T13:33:56Z
New Revision: 1e78d07dc9cdb786eadb30dd4a4f9b2c5d8ba8eb
URL:
https://github.com/llvm/llvm-project/commit/1e78d07dc9cdb786eadb30dd4a4f9b2c5d8ba8eb
DIFF:
https://github.com/llvm/llvm-project/commit/1e78d07dc9cdb786eadb30dd4a4f9b2c5d8ba8eb.diff
Author: Saiyedul Islam
Date: 2022-02-04T12:10:14Z
New Revision: ae9c0740648fd8f7010c895ddcf78380da94dd57
URL:
https://github.com/llvm/llvm-project/commit/ae9c0740648fd8f7010c895ddcf78380da94dd57
DIFF:
https://github.com/llvm/llvm-project/commit/ae9c0740648fd8f7010c895ddcf78380da94dd57.diff
Author: Saiyedul Islam
Date: 2022-01-27T09:00:34Z
New Revision: 52fddcdd9c90a550d7a50cbc2013be3314f91d08
URL:
https://github.com/llvm/llvm-project/commit/52fddcdd9c90a550d7a50cbc2013be3314f91d08
DIFF:
https://github.com/llvm/llvm-project/commit/52fddcdd9c90a550d7a50cbc2013be3314f91d08.diff
Author: Saiyedul Islam
Date: 2022-02-09T07:11:41Z
New Revision: 4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e
URL:
https://github.com/llvm/llvm-project/commit/4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e
DIFF:
https://github.com/llvm/llvm-project/commit/4db88a54b6d4bd38fe38dbe57ec2a156ff3c144e.diff
Author: Saiyedul Islam
Date: 2022-01-19T10:45:13Z
New Revision: 0731f6ba4f5773071a7b91248caf79a287703a28
URL:
https://github.com/llvm/llvm-project/commit/0731f6ba4f5773071a7b91248caf79a287703a28
DIFF:
https://github.com/llvm/llvm-project/commit/0731f6ba4f5773071a7b91248caf79a287703a28.diff
Author: Saiyedul Islam
Date: 2022-01-19T11:15:31Z
New Revision: 6ee965471363972fafbed60ad8d27d0f666f8671
URL:
https://github.com/llvm/llvm-project/commit/6ee965471363972fafbed60ad8d27d0f666f8671
DIFF:
https://github.com/llvm/llvm-project/commit/6ee965471363972fafbed60ad8d27d0f666f8671.diff
Author: Siu Chi Chan
Date: 2022-04-08T17:11:27Z
New Revision: 0f6cbdee576160a3b40139bf66b864ce05a1e28f
URL:
https://github.com/llvm/llvm-project/commit/0f6cbdee576160a3b40139bf66b864ce05a1e28f
DIFF:
https://github.com/llvm/llvm-project/commit/0f6cbdee576160a3b40139bf66b864ce05a1e28f.diff
LOG:
https://github.com/saiislam review_requested
https://github.com/llvm/llvm-project/pull/65410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam review_requested
https://github.com/llvm/llvm-project/pull/65410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam labeled
https://github.com/llvm/llvm-project/pull/65410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam review_requested
https://github.com/llvm/llvm-project/pull/65410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam review_requested
https://github.com/llvm/llvm-project/pull/65410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam closed
https://github.com/llvm/llvm-project/pull/65410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam created
https://github.com/llvm/llvm-project/pull/71234
Fixes the DeviceRTL compilation to ensure it is ABI agnostic. Uses already
available global variable "oclc_ABI_version" instead of
"llvm.amdgcn.abi.verion".
It also adds some minor fields in ImplicitArg
@@ -3086,10 +3139,14 @@ Error AMDGPUKernelTy::launchImpl(GenericDeviceTy
,
// Only COV5 implicitargs needs to be set. COV4 implicitargs are not used.
if (getImplicitArgsSize() == sizeof(utils::AMDGPUImplicitArgsTy)) {
ImplArgs->BlockCountX = NumBlocks;
+
@@ -17468,19 +17468,19 @@ Value *EmitAMDGPUImplicitArgPtr(CodeGenFunction )
{
/// Emit code based on Code Object ABI version.
/// COV_4: Emit code to use dispatch ptr
/// COV_5: Emit code to use implicitarg ptr
-/// COV_NONE : Emit code to load a global variable
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/71234
>From 36976c1a97518c9cdf080d80b5fab2b16837b055 Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Fri, 3 Nov 2023 16:16:25 -0500
Subject: [PATCH 1/2] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/71234
>From 36976c1a97518c9cdf080d80b5fab2b16837b055 Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Fri, 3 Nov 2023 16:16:25 -0500
Subject: [PATCH 1/2] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL
@@ -88,7 +88,7 @@ class TargetOptions {
COV_5 = 500,
};
/// \brief Code object version for AMDGPU.
- CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_None;
+ CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_4;
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/71234
>From 36976c1a97518c9cdf080d80b5fab2b16837b055 Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Fri, 3 Nov 2023 16:16:25 -0500
Subject: [PATCH 1/3] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/71234
>From 36976c1a97518c9cdf080d80b5fab2b16837b055 Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Fri, 3 Nov 2023 16:16:25 -0500
Subject: [PATCH 1/3] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL
https://github.com/saiislam approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/67366
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/69462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Saiyedul Islam
Date: 2023-08-29T06:35:44-05:00
New Revision: f616c3eeb43f3732f53f81d291723a6a34af2de1
URL:
https://github.com/llvm/llvm-project/commit/f616c3eeb43f3732f53f81d291723a6a34af2de1
DIFF:
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/71234
>From a6627248612fd2ab577b456a791e08164674efcc Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Fri, 3 Nov 2023 16:16:25 -0500
Subject: [PATCH 1/3] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL
https://github.com/saiislam closed
https://github.com/llvm/llvm-project/pull/71234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/71234
>From 91c64e83b3d8d405e71f8e3108483b88ee4758d8 Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Fri, 3 Nov 2023 16:16:25 -0500
Subject: [PATCH 1/3] [OpenMP] Cleanup and fixes for ABI agnostic DeviceRTL
Author: Animesh Kumar
Date: 2022-09-06T07:10:15-05:00
New Revision: 0cecc6e8e27c9913cd2d82a77941dc3a6d11318f
URL:
https://github.com/llvm/llvm-project/commit/0cecc6e8e27c9913cd2d82a77941dc3a6d11318f
DIFF:
https://github.com/llvm/llvm-project/commit/0cecc6e8e27c9913cd2d82a77941dc3a6d11318f.diff
https://github.com/saiislam created
https://github.com/llvm/llvm-project/pull/79039
Depends on #79038 which makes cov5 as the default code
object version.
>From 4c156a11e943b85c1fe9f7f0ff5b651cf4d3946d Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Mon, 22 Jan 2024 13:11:22 -0600
https://github.com/saiislam edited
https://github.com/llvm/llvm-project/pull/79039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -99,6 +99,7 @@ class ROCDLDialectLLVMIRTranslationInterface
if (!llvmFunc->hasFnAttribute("amdgpu-flat-work-group-size")) {
llvmFunc->addFnAttr("amdgpu-flat-work-group-size", "1,256");
}
+ llvmFunc->addFnAttr("amdgpu-implicitarg-num-bytes", "256");
https://github.com/saiislam created
https://github.com/llvm/llvm-project/pull/79038
Also update LIT tests and docs.
For more details, see
https://llvm.org/docs/AMDGPUUsage.html#code-object-v5-metadata
Corresponding llvm-objdump AMDGPU lit tests are updated
in a follow-up PR.
>From
https://github.com/saiislam commented:
May be merge the two PRs in one?
They both are not independent.
https://github.com/llvm/llvm-project/pull/82220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/saiislam approved this pull request.
I tested with different combinations of compatible TargetIDs, the patch seems
to work fine.
Thanks a lot for working on this.
LGTM!
https://github.com/llvm/llvm-project/pull/78359
___
https://github.com/saiislam approved this pull request.
Thanks, LGTM!
https://github.com/llvm/llvm-project/pull/73709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -12,28 +12,6 @@
void foo() {}
-template
saiislam wrote:
How was this test case working till now when templates were not supported in
scan?
https://github.com/llvm/llvm-project/pull/79431
___
cfe-commits
@@ -19520,6 +19520,13 @@ static bool actOnOMPReductionKindClause(
bool FirstIter = true;
for (Expr *RefExpr : VarList) {
assert(RefExpr && "nullptr expr in OpenMP reduction clause.");
+if (ClauseKind == OMPC_reduction &&
+RD.RedModifier ==
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/79038
>From 9791643aa93f70bcaf89cd9ca679dbd1bed58676 Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Mon, 22 Jan 2024 13:11:22 -0600
Subject: [PATCH] [AMDGPU] Change default AMDHSA Code Object version to 5
Also
saiislam wrote:
> Should get a mention in the release notes
Thanks for pointing it out. I have updated it.
https://github.com/llvm/llvm-project/pull/79038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/79038
>From 04377914831f54f0572d5b1b233826fd0e204685 Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Mon, 22 Jan 2024 13:11:22 -0600
Subject: [PATCH] [AMDGPU] Change default AMDHSA Code Object version to 5
Also
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/79038
>From 384a90e5f161e4647a6ab803906a93f730c5df4b Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Mon, 22 Jan 2024 13:11:22 -0600
Subject: [PATCH] [AMDGPU] Change default AMDHSA Code Object version to 5
Also
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/79039
>From 04377914831f54f0572d5b1b233826fd0e204685 Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Mon, 22 Jan 2024 13:11:22 -0600
Subject: [PATCH 1/2] [AMDGPU] Change default AMDHSA Code Object version to 5
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/79039
>From 384a90e5f161e4647a6ab803906a93f730c5df4b Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Mon, 22 Jan 2024 13:11:22 -0600
Subject: [PATCH 1/2] [AMDGPU] Change default AMDHSA Code Object version to 5
https://github.com/saiislam updated
https://github.com/llvm/llvm-project/pull/79039
>From 9791643aa93f70bcaf89cd9ca679dbd1bed58676 Mon Sep 17 00:00:00 2001
From: Saiyedul Islam
Date: Mon, 22 Jan 2024 13:11:22 -0600
Subject: [PATCH 1/2] [AMDGPU] Change default AMDHSA Code Object version to 5
https://github.com/saiislam edited
https://github.com/llvm/llvm-project/pull/79039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam closed
https://github.com/llvm/llvm-project/pull/79038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam closed
https://github.com/llvm/llvm-project/pull/79039
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -25,4 +25,4 @@ entry:
}
!llvm.module.flags = !{!0}
-!0 = !{i32 1, !"amdgpu_code_object_version", i32 500}
+!0 = !{i32 1, !"amdhsa_code_object_version", i32 500}
saiislam wrote:
Can we remove explicit mention of COV5 module flag in all these test files
@@ -88,7 +88,7 @@ class TargetOptions {
COV_5 = 500,
};
/// \brief Code object version for AMDGPU.
- CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_None;
+ CodeObjectVersionKind CodeObjectVersion = CodeObjectVersionKind::COV_5;
saiislam wrote:
> (patches like this should probably be broken up - test changes to the
> defaults in lld and llvm for instance don't depend on the change to the clang
> driver which is the only real semantic change in this patch, right? So
> probably only change the semantics of clang, and
https://github.com/saiislam created
https://github.com/llvm/llvm-project/pull/92290
Legacy toolchain to handle multiple target architectures specified
using `-Xopenmp-target= -march=` was only
processing a single architecture. This patch also fixes the use of
comma to specify multiple archs for
saiislam wrote:
It will fix tests like:
[targetid_multi_image](https://github.com/ROCm/aomp/tree/aomp-dev/test/smoke/targetid_multi_image)
https://github.com/llvm/llvm-project/pull/92290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
saiislam wrote:
> > > I don't think we want to support this. `-march` was the wrong option to
> > > use in the first place, and upstream LLVM never supported specifying
> > > multiple device images with `-march` so there isn't a legacy argument in
> > > trunk. However, AOMP did support this
saiislam wrote:
> I don't think we want to support this. `-march` was the wrong option to use
> in the first place, and upstream LLVM never supported specifying multiple
> device images with `-march` so there isn't a legacy argument in trunk.
> However, AOMP did support this and if it's
saiislam wrote:
> > If `-march` is the wrong option then let's start deprecating it and remove
> > it altogether in the next llvm release. But, as long as it is here, it
> > should be equivalent to `--offload-arch`.
>
> Honestly not a bad idea. I could make a patch warning users to use
>
saiislam wrote:
Thanks for the review and comments. Closing the PR.
https://github.com/llvm/llvm-project/pull/92290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/saiislam closed
https://github.com/llvm/llvm-project/pull/92290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
86 matches
Mail list logo
