Author: sammccall
Date: Thu Feb 22 07:33:33 2018
New Revision: 325801
URL: http://llvm.org/viewvc/llvm-project?rev=325801=rev
Log:
[clangd] fix test use-after-free from r325774
Modified:
clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp
Modified:
Author: sammccall
Date: Fri Feb 16 08:41:42 2018
New Revision: 325357
URL: http://llvm.org/viewvc/llvm-project?rev=325357=rev
Log:
[clangd] Include timestamps in log messages.
Modified:
clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp
Modified:
Author: sammccall
Date: Thu Feb 22 23:54:17 2018
New Revision: 325868
URL: http://llvm.org/viewvc/llvm-project?rev=325868=rev
Log:
[clangd] BindWithForward -> Bind. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clangd/Function.h
Author: sammccall
Date: Tue Jan 2 01:35:10 2018
New Revision: 321639
URL: http://llvm.org/viewvc/llvm-project?rev=321639=rev
Log:
[Driver] Fix unused variables and test-writing-into-workdir after r321621
Modified:
cfe/trunk/lib/Driver/Driver.cpp
cfe/trunk/test/Driver/config-file.c
Author: sammccall
Date: Fri Dec 22 01:47:34 2017
New Revision: 321350
URL: http://llvm.org/viewvc/llvm-project?rev=321350=rev
Log:
[clangd] Simplify GlobalCompilationDatabase, cache missing GCDs
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
Author: sammccall
Date: Thu Dec 21 06:58:44 2017
New Revision: 321272
URL: http://llvm.org/viewvc/llvm-project?rev=321272=rev
Log:
[clangd] Index symbols share storage within a slab.
Summary:
Symbols are not self-contained - it's only safe to hand them out if you
guarantee the lifetime of the
Author: sammccall
Date: Thu Dec 21 12:11:46 2017
New Revision: 321302
URL: http://llvm.org/viewvc/llvm-project?rev=321302=rev
Log:
[clangd] Don't re-hash SymbolID in maps, just use the SHA1 data
Modified:
clang-tools-extra/trunk/clangd/index/Index.cpp
Author: sammccall
Date: Thu Jun 21 23:41:43 2018
New Revision: 335321
URL: http://llvm.org/viewvc/llvm-project?rev=335321=rev
Log:
[clangd] Remove FilterText from the index.
Summary:
It's almost always identical to Name, and in fact we never used it (we used name
instead).
The only case where
Couple of thoughts. (Technically I'm out on leave so will let Jan/Ilya
review implementation and happy with whatever you decide)
Enabling
- negotiating LSP extensions is probably better done in the "capabilities"
message exchange than as a command-line flag. Generally, we want this
extension on
Author: sammccall
Date: Fri Jul 20 01:01:37 2018
New Revision: 337527
URL: http://llvm.org/viewvc/llvm-project?rev=337527=rev
Log:
[clangd] FuzzyMatch exposes an API for its word segmentation. NFC
Summary: This is intended to be used for indexing, e.g. in D49417
Reviewers: ioeric, omtcyfz
Author: sammccall
Date: Mon Jul 23 04:25:25 2018
New Revision: 337682
URL: http://llvm.org/viewvc/llvm-project?rev=337682=rev
Log:
[Tooling] Use UniqueStringSaver. NFC
Modified:
cfe/trunk/include/clang/Tooling/Execution.h
cfe/trunk/lib/Tooling/Execution.cpp
Modified:
Or make operator bool explicit
On Mon, Jul 23, 2018, 13:55 Ilya Biryukov via Phabricator <
revi...@reviews.llvm.org> wrote:
> ilya-biryukov accepted this revision.
> ilya-biryukov added a comment.
> This revision is now accepted and ready to land.
>
> Scary
> Definitely LGTM!
>
>
>
>
Author: sammccall
Date: Tue Jul 24 09:00:55 2018
New Revision: 337834
URL: http://llvm.org/viewvc/llvm-project?rev=337834=rev
Log:
[VFS] Cleanups to VFS interfaces.
Summary:
- add comments clarifying semantics
- Status::copyWithNewName(Status, Name) --> instance method
-
Author: sammccall
Date: Thu Aug 30 08:07:34 2018
New Revision: 341076
URL: http://llvm.org/viewvc/llvm-project?rev=341076=rev
Log:
[clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.
Summary:
After code completion inserts a header, running signature help using the old
Author: sammccall
Date: Fri Aug 31 06:55:01 2018
New Revision: 341211
URL: http://llvm.org/viewvc/llvm-project?rev=341211=rev
Log:
[clangd] Flatten out Symbol::Details. It was ill-conceived, sorry.
Reviewers: ioeric
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Author: sammccall
Date: Wed Sep 5 06:22:11 2018
New Revision: 341467
URL: http://llvm.org/viewvc/llvm-project?rev=341467=rev
Log:
[clangd] Fix type/variable name conflict on some compilers
Modified:
clang-tools-extra/trunk/clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
Modified:
g/tools/extra/clangd/index/Index.h:324:26: note: copy
> constructor of 'SymbolSlab' is implicitly deleted because field 'Arena'
> has a deleted copy constructor
>llvm::BumpPtrAllocator Arena; // Owns Symbol data that the Symbols do
> not.
> ^
> ../include/llvm/
Author: sammccall
Date: Wed Sep 5 00:52:49 2018
New Revision: 341451
URL: http://llvm.org/viewvc/llvm-project?rev=341451=rev
Log:
[clangd] Fix buildbot failures on older compilers from r341375
Modified:
clang-tools-extra/trunk/clangd/RIFF.cpp
Author: sammccall
Date: Wed Sep 5 00:44:02 2018
New Revision: 341450
URL: http://llvm.org/viewvc/llvm-project?rev=341450=rev
Log:
clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export'
specifier
This fixes formatting namespaces with preceding 'inline' and 'export'
bug/breakage mentioned?
>
> On Thu, Sep 6, 2018 at 11:44 AM Ilya Biryukov
> wrote:
>
>> +1 for consistent style, but why not use enum class everywhere instead?
>>
>> On Wed, Sep 5, 2018 at 12:41 PM Sam McCall via cfe-commits <
>> cfe-commits@lists.llvm.org>
Author: sammccall
Date: Tue Sep 4 09:16:50 2018
New Revision: 341375
URL: http://llvm.org/viewvc/llvm-project?rev=341375=rev
Log:
[clangd] Define a compact binary serialization fomat for symbol slab/index.
Summary:
This is intended to replace the current YAML format for general use.
It's ~10x
Author: sammccall
Date: Tue Sep 4 07:39:56 2018
New Revision: 341368
URL: http://llvm.org/viewvc/llvm-project?rev=341368=rev
Log:
[clangd] SymbolOccurrences -> Refs and cleanup
Summary:
A few things that I noticed while merging the SwapIndex patch:
- SymbolOccurrences and particularly
Author: sammccall
Date: Tue Sep 4 09:19:40 2018
New Revision: 341376
URL: http://llvm.org/viewvc/llvm-project?rev=341376=rev
Log:
[clangd] Load static index asynchronously, add tracing.
Summary:
Like D51475 but simplified based on recent patches.
While here, clarify that loadIndex() takes a
to the GCC bug/breakage mentioned?
>>>
>>> On Thu, Sep 6, 2018 at 11:44 AM Ilya Biryukov
>>> wrote:
>>>
>>>> +1 for consistent style, but why not use enum class everywhere instead?
>>>>
>>>> On Wed, Sep 5, 2018 at 12:41 PM Sam M
Author: sammccall
Date: Thu Sep 6 07:27:40 2018
New Revision: 341549
URL: http://llvm.org/viewvc/llvm-project?rev=341549=rev
Log:
Revert "[DebugInfo] Generate debug information for labels. (Fix PR37395)"
This reverts commit r341519, which generates debug info that causes
backend crashes. (with
Author: sammccall
Date: Mon Sep 10 03:00:47 2018
New Revision: 341797
URL: http://llvm.org/viewvc/llvm-project?rev=341797=rev
Log:
[clangd] Fix async index loading (from r341376).
Summary:
This wasn't actually async (due to std::future destructor blocking).
If it were, we would have clean
Author: sammccall
Date: Wed Sep 5 04:53:07 2018
New Revision: 341462
URL: http://llvm.org/viewvc/llvm-project?rev=341462=rev
Log:
[clangd] Add xrefs LSP boilerplate implementation.
Reviewers: ilya-biryukov, ioeric
Subscribers: MaskRay, jkorous, arphaman, cfe-commits
Differential Revision:
Author: sammccall
Date: Wed Sep 5 03:33:36 2018
New Revision: 341458
URL: http://llvm.org/viewvc/llvm-project?rev=341458=rev
Log:
[clangd] Implement findReferences function
clangd will use findReferences to provide LSP's reference feature.
Modified:
clang-tools-extra/trunk/clangd/XRefs.cpp
Author: sammccall
Date: Wed Sep 5 03:39:58 2018
New Revision: 341459
URL: http://llvm.org/viewvc/llvm-project?rev=341459=rev
Log:
[clangd] Avoid enum class+enumValN to avoid GCC bug(?), and use consistent
style.
Modified:
Author: sammccall
Date: Wed Sep 5 06:17:51 2018
New Revision: 341466
URL: http://llvm.org/viewvc/llvm-project?rev=341466=rev
Log:
[clangd] Fix references.test assertions
Modified:
clang-tools-extra/trunk/test/clangd/references.test
Modified:
Author: sammccall
Date: Wed Sep 5 06:17:47 2018
New Revision: 341465
URL: http://llvm.org/viewvc/llvm-project?rev=341465=rev
Log:
[clangd] make zlib compression optional for binary format
Modified:
clang-tools-extra/trunk/clangd/index/Serialization.cpp
Modified:
Author: sammccall
Date: Wed Jul 4 23:20:41 2018
New Revision: 336309
URL: http://llvm.org/viewvc/llvm-project?rev=336309=rev
Log:
[clangd] Track origins of symbols (various indexes, Sema).
Summary: Surface it in the completion items C++ API, and when a flag is set.
Reviewers: ioeric
Author: sammccall
Date: Thu Jul 5 01:26:53 2018
New Revision: 336320
URL: http://llvm.org/viewvc/llvm-project?rev=336320=rev
Log:
Revert "[clangd] FileDistance: temporarily disable in CodeComplete, it's
behaving badly"
The bad behavior seems to have been fixed by r336242 after all.
I thought
Author: sammccall
Date: Wed Jul 4 02:01:04 2018
New Revision: 336248
URL: http://llvm.org/viewvc/llvm-project?rev=336248=rev
Log:
[clangd] FileDistance: temporarily disable in CodeComplete, it's behaving badly
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Modified:
Author: sammccall
Date: Wed Jul 4 01:52:13 2018
New Revision: 336246
URL: http://llvm.org/viewvc/llvm-project?rev=336246=rev
Log:
[clangd] FileDistance: missing constexpr
Modified:
clang-tools-extra/trunk/clangd/FileDistance.cpp
Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp
Author: sammccall
Date: Wed Jul 4 01:27:28 2018
New Revision: 336242
URL: http://llvm.org/viewvc/llvm-project?rev=336242=rev
Log:
[clangd] FileDistance: don't add duplicate edges
Modified:
clang-tools-extra/trunk/clangd/FileDistance.cpp
Modified:
Author: sammccall
Date: Fri Jul 6 04:50:49 2018
New Revision: 336431
URL: http://llvm.org/viewvc/llvm-project?rev=336431=rev
Log:
[clangd] Make SymbolOrigin an enum class, rather than a plain enum.
I never intended to define namespace pollution like clangd::AST, clangd::Unknown
etc. Oops!
Author: sammccall
Date: Wed Jul 11 03:35:11 2018
New Revision: 336785
URL: http://llvm.org/viewvc/llvm-project?rev=336785=rev
Log:
[clangd] Upgrade logging facilities with levels and formatv.
Summary:
log() is split into four functions:
- elog()/log()/vlog() have different severity levels,
On Wed, Jul 11, 2018, 15:18 Eric Liu via Phabricator <
revi...@reviews.llvm.org> wrote:
> ioeric added a comment.
>
> In https://reviews.llvm.org/D49175#1158562, @sammccall wrote:
>
> > I like this idea, of course hard to know how it will affect all
> practical cases.
> >
> > Is it easy to get
Author: sammccall
Date: Fri Jul 13 04:41:56 2018
New Revision: 336992
URL: http://llvm.org/viewvc/llvm-project?rev=336992=rev
Log:
[clang-tidy] readability-inconsistent-declaration-parameter-name: accept
approximate name matches.
Summary:
The goal is to reduce false positives when the
Author: sammccall
Date: Thu Jul 12 01:00:21 2018
New Revision: 336890
URL: http://llvm.org/viewvc/llvm-project?rev=336890=rev
Log:
[clangd] Simplify logging wrapper after r336888
Modified:
clang-tools-extra/trunk/clangd/Logger.h
Modified: clang-tools-extra/trunk/clangd/Logger.h
URL:
Author: sammccall
Date: Thu Jul 12 04:52:18 2018
New Revision: 336899
URL: http://llvm.org/viewvc/llvm-project?rev=336899=rev
Log:
[clangd] log request/response messages with method/ID/error at INFO level
Summary: Bodies are logged at VERBOSE level (since r336785), tweak the
formatting.
Author: sammccall
Date: Thu Jul 12 07:49:52 2018
New Revision: 336909
URL: http://llvm.org/viewvc/llvm-project?rev=336909=rev
Log:
[clangd] Extract FileSystemProvider into a separate header. NFC
Reviewers: sammccall
Reviewed By: sammccall
Subscribers: mgorny, ioeric, MaskRay, jkorous,
Author: sammccall
Date: Mon Jul 9 07:25:59 2018
New Revision: 336549
URL: http://llvm.org/viewvc/llvm-project?rev=336549=rev
Log:
[clangd] Remove JSON library in favor of llvm/Support/JSON
Summary:
The library has graduated from clangd to llvm/Support.
This is a mechanical change to move to the
Author: sammccall
Date: Thu Jan 18 02:24:01 2018
New Revision: 322827
URL: http://llvm.org/viewvc/llvm-project?rev=322827=rev
Log:
[clangd] Output log messages to stderr when not configured (e.g. in tests). NFC
Modified:
clang-tools-extra/trunk/clangd/Logger.cpp
Author: sammccall
Date: Mon Jan 22 12:44:47 2018
New Revision: 323148
URL: http://llvm.org/viewvc/llvm-project?rev=323148=rev
Log:
[CodeComplete] Omit templated constructors from member list too.
Also avoid printing a 'void' return type for constructor expressions.
Modified:
Author: sammccall
Date: Mon Jan 22 13:05:00 2018
New Revision: 323149
URL: http://llvm.org/viewvc/llvm-project?rev=323149=rev
Log:
[clangd] Drop ~destructor completions - rarely helpful and work inconsistently
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
Author: sammccall
Date: Mon Mar 12 07:49:09 2018
New Revision: 327275
URL: http://llvm.org/viewvc/llvm-project?rev=327275=rev
Log:
[clangd] Collect the number of files referencing a symbol in the static index.
Summary:
This is an important ranking signal.
It's off for the dynamic index for now.
Author: sammccall
Date: Tue Feb 27 09:15:50 2018
New Revision: 326211
URL: http://llvm.org/viewvc/llvm-project?rev=326211=rev
Log:
[clangd] Remove codecomplete override content API. Long live addDocument!
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
Author: sammccall
Date: Mon Mar 12 16:22:35 2018
New Revision: 327344
URL: http://llvm.org/viewvc/llvm-project?rev=327344=rev
Log:
[clangd] Remove Tagged and some related APIs from ClangdServer.
Context can do what Tagged was intended to support (snapshot filesystems),
and less intrusively.
Author: sammccall
Date: Fri Mar 9 03:47:37 2018
New Revision: 327115
URL: http://llvm.org/viewvc/llvm-project?rev=327115=rev
Log:
[clang-tidy] fix header guard
Modified:
clang-tools-extra/trunk/clang-tidy/abseil/StringFindStartswithCheck.h
Modified:
Author: sammccall
Date: Fri Mar 9 05:25:29 2018
New Revision: 327127
URL: http://llvm.org/viewvc/llvm-project?rev=327127=rev
Log:
[clangd] Don't index template specializations.
Summary:
These have different USRs than the underlying entity, but are not typically
interesting in their own right
Author: sammccall
Date: Tue Mar 6 06:30:07 2018
New Revision: 326798
URL: http://llvm.org/viewvc/llvm-project?rev=326798=rev
Log:
[clangd] Address missed comments from D44003
Modified:
clang-tools-extra/trunk/unittests/clangd/FuzzyMatchTests.cpp
Modified:
On Wed, Mar 14, 2018, 19:39 Simon Marchi via Phabricator <
revi...@reviews.llvm.org> wrote:
> simark added inline comments.
>
>
>
> Comment at: clangd/TUScheduler.h:69
> + /// FIXME: remove the callback from this function
> + void updateCompileCommand(PathRef File,
Author: sammccall
Date: Fri Apr 6 00:48:21 2018
New Revision: 329380
URL: http://llvm.org/viewvc/llvm-project?rev=329380=rev
Log:
[clangd] move comment to the right place. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdUnit.cpp
Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp
t.Nearby
> Clang-Unit :: Tooling/./ToolingTests.exe/InterpolateTest.Strip
> . . .
> Please have a look?
>
> The builder was red and did not send notifications.
>
> Thanks
>
> Galina
>
> On Mon, Apr 9, 2018 at 8:17 AM, Sam McCall via cfe-commits <
> cfe-commits
Author: sammccall
Date: Tue Apr 10 03:36:46 2018
New Revision: 329685
URL: http://llvm.org/viewvc/llvm-project?rev=329685=rev
Log:
[Tooling] fix UB when interpolating compile commands with an empty index
Modified:
cfe/trunk/lib/Tooling/InterpolatingCompilationDatabase.cpp
Modified:
Author: sammccall
Date: Mon Apr 9 08:22:08 2018
New Revision: 329582
URL: http://llvm.org/viewvc/llvm-project?rev=329582=rev
Log:
[clang] Use compile-command interpolation to provide commands for header files.
Summary: This uses the inferring wrapper introduced in D45006.
Subscribers: klimek,
Author: sammccall
Date: Mon Apr 9 08:17:39 2018
New Revision: 329580
URL: http://llvm.org/viewvc/llvm-project?rev=329580=rev
Log:
[Tooling] A CompilationDatabase wrapper that infers header commands.
Summary:
The wrapper finds the closest matching compile command using filename heuristics
and
Author: sammccall
Date: Mon Apr 9 07:28:52 2018
New Revision: 329571
URL: http://llvm.org/viewvc/llvm-project?rev=329571=rev
Log:
[clangd] Adapt index interfaces to D45014, and fix the old bugs.
Summary:
Fix bugs:
- don't count occurrences of decls where we don't spell the name
-
The matching clangd patch is r329571, I got distracted and it took me a few
minutes to land it. Apologies!
On Mon, Apr 9, 2018 at 4:35 PM Hans Wennborg via Phabricator <
revi...@reviews.llvm.org> wrote:
> hans added a comment.
>
> Some bots are sad:
>
Author: sammccall
Date: Mon Apr 9 07:12:51 2018
New Revision: 329570
URL: http://llvm.org/viewvc/llvm-project?rev=329570=rev
Log:
[Index] Return SourceLocation to consumers, not FileID/Offset pair.
Summary:
The FileID/Offset conversion is lossy. The code takes the fileLoc, which loses
e.g. the
Author: sammccall
Date: Fri Apr 20 04:35:17 2018
New Revision: 330418
URL: http://llvm.org/viewvc/llvm-project?rev=330418=rev
Log:
Parse .h files as objective-c++ if we don't have a compile command.
Summary: This makes C++/objC not totally broken, without hurting C files too
much.
Reviewers:
Author: sammccall
Date: Tue Apr 3 10:35:57 2018
New Revision: 329090
URL: http://llvm.org/viewvc/llvm-project?rev=329090=rev
Log:
[clangd] synthesize fix message when the diagnostic doesn't provide one.
Summary:
Currently if a fix is attached directly to a diagnostic, we repeat the
diagnostic
Author: sammccall
Date: Mon Mar 5 09:34:33 2018
New Revision: 326721
URL: http://llvm.org/viewvc/llvm-project?rev=326721=rev
Log:
[clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.
Summary:
The intent was that [ar] doesn't match "FooBar"; the first character must match
Author: sammccall
Date: Mon Mar 5 09:28:54 2018
New Revision: 326719
URL: http://llvm.org/viewvc/llvm-project?rev=326719=rev
Log:
[clangd] Extract ClangdServer::Options struct.
Summary:
This subsumes most of the params to ClangdServer and ClangdLSPServer.
Adjacent changes:
- tests use a
Author: sammccall
Date: Fri Mar 2 00:56:37 2018
New Revision: 326546
URL: http://llvm.org/viewvc/llvm-project?rev=326546=rev
Log:
[clangd] Debounce streams of updates.
Summary:
Don't actually start building ASTs for new revisions until either:
- 500ms have passed since the last revision, or
-
Author: sammccall
Date: Fri Jun 29 07:47:57 2018
New Revision: 335980
URL: http://llvm.org/viewvc/llvm-project?rev=335980=rev
Log:
[clangd] codeComplete returns more structured completion items, LSP. NFC.
Summary:
LSP has some presentational fields with limited semantics (e.g. 'detail') and
Author: sammccall
Date: Fri Jun 29 06:24:20 2018
New Revision: 335972
URL: http://llvm.org/viewvc/llvm-project?rev=335972=rev
Log:
[clangd] Improve output of --help and --version. NFC.
Reviewers: ilya-biryukov
Subscribers: ioeric, MaskRay, jkorous, cfe-commits
Differential Revision:
Author: sammccall
Date: Fri Oct 5 07:03:04 2018
New Revision: 343849
URL: http://llvm.org/viewvc/llvm-project?rev=343849=rev
Log:
[clangd] Remove last usage of ast matchers from SymbolCollector. NFC
Modified:
clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp
Modified:
Author: sammccall
Date: Fri Oct 12 09:51:48 2018
New Revision: 344363
URL: http://llvm.org/viewvc/llvm-project?rev=344363=rev
Log:
[clangd] Return Command objects from onCodeAction, rather than ad-hoc JSON. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
Author: sammccall
Date: Fri Oct 12 05:21:29 2018
New Revision: 344337
URL: http://llvm.org/viewvc/llvm-project?rev=344337=rev
Log:
Remove top-level using declaration from header files, as these aliases leak.
Reviewers: ilya-biryukov
Subscribers: arphaman, cfe-commits
Differential Revision:
Author: sammccall
Date: Mon Oct 15 06:34:10 2018
New Revision: 344513
URL: http://llvm.org/viewvc/llvm-project?rev=344513=rev
Log:
[clangd] Minimal implementation of automatic static index (not enabled).
Summary:
See tinyurl.com/clangd-automatic-index for design and goals.
Lots of limitations
Author: sammccall
Date: Mon Oct 15 08:04:03 2018
New Revision: 344520
URL: http://llvm.org/viewvc/llvm-project?rev=344520=rev
Log:
[clangd] Use SyncAPI in more places in tests. NFC
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
Author: sammccall
Date: Mon Oct 15 23:32:14 2018
New Revision: 344586
URL: http://llvm.org/viewvc/llvm-project?rev=344586=rev
Log:
[clangd] Disable timeouting test while investigating
Modified:
clang-tools-extra/trunk/unittests/clangd/BackgroundIndexTests.cpp
Modified:
Author: sammccall
Date: Tue Oct 16 01:53:52 2018
New Revision: 344594
URL: http://llvm.org/viewvc/llvm-project?rev=344594=rev
Log:
[clangd] Optionally use dex for the preamble parts of the dynamic index.
Summary:
Reuse the old -use-dex-index experiment flag for this.
To avoid breaking the
?
>
> Douglas Yung
>
> > -----Original Message-
> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> > Of Sam McCall via cfe-commits
> > Sent: Monday, October 15, 2018 6:34
> > To: cfe-commits@lists.llvm.org
> > Subject: [clang-t
Author: sammccall
Date: Tue Oct 16 02:05:13 2018
New Revision: 344595
URL: http://llvm.org/viewvc/llvm-project?rev=344595=rev
Log:
[clangd] Fix threading bugs in (not-yet-used) BackgroundIndex, re-enable test.
Summary:
One relatively boring bug: forgot to notify the CV after enqueue.
One much
Author: sammccall
Date: Thu Oct 18 07:41:50 2018
New Revision: 344741
URL: http://llvm.org/viewvc/llvm-project?rev=344741=rev
Log:
[clangd] Enforce rules around "initialize" request, and create ClangdServer
lazily.
Summary:
LSP is a slightly awkward map to C++ object lifetimes: the initialize
Author: sammccall
Date: Tue Oct 16 09:29:41 2018
New Revision: 344617
URL: http://llvm.org/viewvc/llvm-project?rev=344617=rev
Log:
[clangd] Send CodeAction responses to textDocument/codeAction (LSP 3.8)
Summary:
I don't bother mirroring the full capabilities struct, just parse the
bits we care
Author: sammccall
Date: Tue Oct 16 09:48:06 2018
New Revision: 344620
URL: http://llvm.org/viewvc/llvm-project?rev=344620=rev
Log:
[clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction.
Summary:
This paves the way for alternative transports (mac XPC, maybe messagepack?),
and
Author: sammccall
Date: Fri Oct 19 08:42:23 2018
New Revision: 344787
URL: http://llvm.org/viewvc/llvm-project?rev=344787=rev
Log:
[clangd] Set workspace root when initializing ClangdServer, disallow mutation.
Summary:
Rename instance variable to WorkspaceRoot to match what we call it
Author: sammccall
Date: Wed Oct 17 00:33:42 2018
New Revision: 344673
URL: http://llvm.org/viewvc/llvm-project?rev=344673=rev
Log:
[clangd] Simplify client capabilities parsing.
Summary:
Instead of parsing into structs that mirror LSP, simply parse into a flat struct
that contains the info we
Author: sammccall
Date: Wed Oct 17 00:39:32 2018
New Revision: 344675
URL: http://llvm.org/viewvc/llvm-project?rev=344675=rev
Log:
[clangd] Rename and move trivial logger to Logger.cpp. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.h
Author: sammccall
Date: Wed Oct 17 00:32:05 2018
New Revision: 344672
URL: http://llvm.org/viewvc/llvm-project?rev=344672=rev
Log:
[clangd] Refactor JSON-over-stdin/stdout code into Transport abstraction.
(re-land r344620)
Summary:
This paves the way for alternative transports (mac XPC, maybe
Author: sammccall
Date: Wed Oct 17 00:41:53 2018
New Revision: 344676
URL: http://llvm.org/viewvc/llvm-project?rev=344676=rev
Log:
[clangd] Hide unused function. NFC
Modified:
clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp
clang-tools-extra/trunk/clangd/JSONRPCDispatcher.h
Author: sammccall
Date: Thu Oct 18 05:32:04 2018
New Revision: 344737
URL: http://llvm.org/viewvc/llvm-project?rev=344737=rev
Log:
[clangd] Lay JSONRPCDispatcher to rest.
Summary:
Most of its functionality is moved into ClangdLSPServer.
The decoupling between JSONRPCDispatcher,
Sorry about that. I wasn't familiar with the python bindings.
Your bisect is correct, we changed the behavior that test is testing: now
an approximate match will be returned.
I guess either:
- just remove that test (depending on how we feel about smoke-testing vs
exhaustively testing wrapperl
Author: sammccall
Date: Mon Oct 15 09:47:45 2018
New Revision: 344533
URL: http://llvm.org/viewvc/llvm-project?rev=344533=rev
Log:
[clangd] Revert include path change in Dexp. NFC
Modified:
clang-tools-extra/trunk/clangd/index/dex/dexp/CMakeLists.txt
Author: sammccall
Date: Tue Oct 23 04:51:53 2018
New Revision: 345020
URL: http://llvm.org/viewvc/llvm-project?rev=345020=rev
Log:
Fix range length comparison in DraftStore::UpdateDraft when Unicode characters
are removed from the document
Summary:
See
Author: sammccall
Date: Tue Oct 23 06:14:02 2018
New Revision: 345024
URL: http://llvm.org/viewvc/llvm-project?rev=345024=rev
Log:
[clangd] Remove caching of compilation database commands.
Summary:
The CDB implementations used in open-source code are fast, and our private
slow CDB will soon do
Author: sammccall
Date: Tue Oct 23 04:54:36 2018
New Revision: 345022
URL: http://llvm.org/viewvc/llvm-project?rev=345022=rev
Log:
[clangd] Support passing a relative path to -compile-commands-dir
Summary: This is useful when using clangd with CMake based projects in Visual
Studio Code since
Author: sammccall
Date: Wed Oct 24 06:51:44 2018
New Revision: 345141
URL: http://llvm.org/viewvc/llvm-project?rev=345141=rev
Log:
[clangd] Don't show base class versions of members as completions.
Summary:
These are available via qualifiers, but signal to noise level is low.
Keep required
Author: sammccall
Date: Wed Oct 24 08:18:40 2018
New Revision: 345150
URL: http://llvm.org/viewvc/llvm-project?rev=345150=rev
Log:
[clangd] When replying, log the method name and latency.
Summary:
This information is strictly available in the log (you can find the original
call) but it makes the
Author: sammccall
Date: Wed Oct 24 07:26:26 2018
New Revision: 345144
URL: http://llvm.org/viewvc/llvm-project?rev=345144=rev
Log:
[clangd] Ensure that we reply to each call exactly once. NFC (I think!)
Summary:
In debug builds, getting this wrong will trigger asserts.
In production builds, it
Author: sammccall
Date: Tue Oct 23 07:19:54 2018
New Revision: 345031
URL: http://llvm.org/viewvc/llvm-project?rev=345031=rev
Log:
[clangd] Lazily create CDB, remove setCompileCommandsDir.
Summary:
The only way to actually set the directory is at initialize time,
so now CDB is lazy we can pass
Author: sammccall
Date: Wed Oct 24 21:22:52 2018
New Revision: 345235
URL: http://llvm.org/viewvc/llvm-project?rev=345235=rev
Log:
[clangd] Clean up LSP structs around configuration. NFC, no protocol changes.
- align struct names/comments with LSP, remove redundant "clangd" prefixes.
- don't
Author: sammccall
Date: Wed Oct 24 19:04:30 2018
New Revision: 345231
URL: http://llvm.org/viewvc/llvm-project?rev=345231=rev
Log:
[clangd] Don't invalidate LSP-set compile commands when closing a file.
Summary:
It doesn't make much sense: setting them is not coupled to opening the file,
it's an
Author: sammccall
Date: Wed Oct 24 19:22:53 2018
New Revision: 345232
URL: http://llvm.org/viewvc/llvm-project?rev=345232=rev
Log:
[clangd] Fix -compile-commands-dir flag, broken in r345031
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
Author: sammccall
Date: Wed Oct 24 19:25:44 2018
New Revision: 345233
URL: http://llvm.org/viewvc/llvm-project?rev=345233=rev
Log:
[clangd] Remove unused CDB function. NFC
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
201 - 300 of 1712 matches
Mail list logo
