[PATCH] D95766: [Branch-Rename] Fix some links

xgupta added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.h:20 // Check for underscores in the names of googletest tests, per -//

[PATCH] D95766: [Branch-Rename] Fix some links

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94fac81fccfe: [Branch-Rename] Fix some links (authored by

[PATCH] D95766: [Branch-Rename] Fix some links

xgupta created this revision. xgupta added reviewers: mehdi_amini, sqlbyme. Herald added a reviewer: bollu. Herald added subscribers: libcxx-commits, teijeong, rdzhabarov, tatianashp, ThomasRaoux, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester,

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. I build the project on my system x64 with shared libraries enable. It is working correctly. It is also NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6ee1f64a2e82: [NFC][Docs] Fix RAVFrontendAction docs CMakelists.txt for Shared build (authored by xgupta). Repository: rG LLVM Github Monorepo

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

xgupta created this revision. xgupta added reviewers: awarzynski, stephenkelly. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Example tutorial giving undefine reference error

[PATCH] D102134: [docs]Updated the AMD GPU Attributes documentation

xgupta resigned from this revision. xgupta added a comment. I am really an idol reviewer for this patch -:) don't know anything about AMDGPU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102134/new/ https://reviews.llvm.org/D102134

[PATCH] D105408: [clang-format] Pass a TextDiagnosticPrinter when we can not create tempory file.

xgupta added subscribers: MyDeveloperDay, xgupta. xgupta added a reviewer: MyDeveloperDay. xgupta added a comment. Thanks for the patch @Et7f3! I tested it locally and can reproduce it with cat folder/file.c int main() { return 0; } And indeed the patch also solved the crash issue and emit a

[PATCH] D104604: [clang] NFC: add line break at the end of if expressions

xgupta added a comment. It seems you need someone to commit this patch? If so you need to share your name and email address. So that someone with commit access can commit it for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104604/new/

[PATCH] D105185: [AIX] Add _AIX73 version macro

xgupta added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); Jake-Egan wrote: > xgupta wrote: > > Jake-Egan wrote: > > > xgupta wrote: > > > > Seems this

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

xgupta added a comment. > These result in warnings while building and don't need to be there. What are the warnings you get, I run `make clangAPINotes` didn't get any. I am on a7ed55f64c5fdce9af3257458779402fb9de1f8b (

[PATCH] D105185: [AIX] Add _AIX73 version macro

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); Seems this line

[PATCH] D105185: [AIX] Add _AIX73 version macro

xgupta added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:704 +if (OsVersion >= std::make_pair(7, 3)) + Builder.defineMacro("_AIX73"); Jake-Egan wrote: > xgupta wrote: > > Seems this line need formatting? > I originally had it

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. In D104971#2842293 , @SaurabhJha wrote: > This is a light patch that probably does not require a review and I created a > patch anyway. > > Would it

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

xgupta added inline comments. Comment at: clang/docs/LanguageExtensions.rst:539 +.. code-block:: c++ + typedef float m4x4_t __attribute__((matrix_type(4, 4))); + This is incorrect ig. I get warning message : Warning, treated as error:

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

xgupta added inline comments. Comment at: clang/docs/LanguageExtensions.rst:538 + +.. code-block:: c++ + typedef float m4x4_t __attribute__((matrix_type(4, 4))); oh just an blank line is needed :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D104971: [Matrix] Minor fixes with language extension docs

xgupta added a comment. btw you should use [Docs] or [NFC] for this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104971/new/ https://reviews.llvm.org/D104971 ___ cfe-commits mailing list

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

xgupta added reviewers: njames93, kbobyrev. xgupta added a comment. Assuming this is your first patch, I add two reviewers for this patch who touch this file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101352/new/ https://reviews.llvm.org/D101352

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta added a subscriber: rnk. xgupta added a comment. In D101352#2726406 , @jrtc27 wrote: > I'm not convinced by these changes? Yes, I also thought first, clang man page can't be incorrect/inconsistent. I think @rnk can suggest the changes as he has

[PATCH] D101352: [DOCS] Removed inconsistency in clang vs Clang usage in docs (c vs C)

xgupta added a comment. @sushmaunnibhavi Please close this revision, I got some misunderstading. Changes are not expected here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101352/new/ https://reviews.llvm.org/D101352

[PATCH] D101433: Added a faster method to clone llvm project [DOCS]

This revision was automatically updated to reflect the committed changes. Closed by commit rG67ee2f870d3b: Added a faster method to clone llvm project [DOCS] (authored by sushmaunnibhavi, committed by xgupta). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D100705: Fixed Typos

xgupta added a subscriber: curdeius. xgupta added a comment. Nice work @jnyfah! @Mordante Review is already accepted by @curdeius in https://reviews.llvm.org/D100696. And actually, I see your message after committing the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100705: Fixed Typos

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21bef4e11e48: [NFC] Fixed Typos (authored by jnyfah, committed by

[PATCH] D100705: Fixed Typos

xgupta added a comment. Thanks, @Mordante for the tips, I remember from next time :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100705/new/ https://reviews.llvm.org/D100705 ___ cfe-commits mailing

[PATCH] D100696: Fixed typos

xgupta added a comment. @jnyfah you may close this revision. changes are committed by https://reviews.llvm.org/rG21bef4e11e48d5d4bff7a23babbd420e86dd420a. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100696/new/ https://reviews.llvm.org/D100696

[PATCH] D100696: Fixed typos

xgupta accepted this revision. xgupta added a comment. This revision now requires review to proceed. Oh sorry, Your patch is correct. I misunderstand something :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100696/new/

[PATCH] D100696: Fixed typos

xgupta added a comment. Actually, I am not able to apply this patch with `arc patch D100696`. Created and checked out branch arcpatch-D100696. Checking patch polly/docs/ReleaseNotes.rst... error: while searching for: .. warning:: These release notes are for the next release of Polly and it

[PATCH] D100696: Fixed typos

xgupta requested changes to this revision. xgupta added a comment. This revision now requires changes to proceed. Thanks @jnyfah for the patch! It looks you need to rebase your branch to llvm upstream main branch. Because polly/docs/ReleaseNotes.rst is recently change. Now its contain nothing

[PATCH] D100696: Fixed typos

xgupta added a comment. @jnyfah If you are missing something I am just telling you the steps - 1. First fork the llvm github repository 2. git clone https://github.com/jynfah/llvm-project 3. git checkout -b type-fix 4. make changes to files. 5. git diff > mypatch.patch 6. git commit -m "fix

[PATCH] D95737: [NFC][Docs] Fix RAVFrontendAction doc's CMakelists.txt for Shared build

xgupta added a comment. Thank @awarzynski for reviewing and explaining the details. I somehow missed it. Should be fixed by https://github.com/llvm/llvm-project/commit/d1ef9a63a68850bbe8cd8877f69c41833804c8dc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

xgupta added a comment. (If you pass --draft flag to arc while updating revision it becomes WIP so you don't need to retitle or remove reviewers. Buildbot also work in that case. And to again ask for review you can use `Add Action` drop down menu.) Repository: rG LLVM Github Monorepo

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/ https://reviews.llvm.org/D102836

[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thank! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77470/new/ https://reviews.llvm.org/D77470

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a6d8a11f89b: [clang] Fix Typo in AST Matcher Reference (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/

[PATCH] D98254: Fix typo in two files in Clang

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98254/new/ https://reviews.llvm.org/D98254

[PATCH] D98254: Fix typo in two files in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGe01ac501af20: Fix typo in two files in Clang, patch by FusionBolt (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98254/new/

[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f77dc459e31: [clang] NFC: Fix trivial typo in comments and document (authored by kiszk, committed by xgupta). Changed prior to commit:

[PATCH] D109653: Fix some definitions on AVR target

xgupta added a comment. Yeah, Such patches are OK to commit by just adding a [NFC] tag in commit message. Though if you spend some time on Phabricator, you will be aware of which kind of patches need reviews and which can be committed directly. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D109979: [Clang] [Fix] Clang build fails when build directory contains space character

xgupta created this revision. xgupta added reviewers: aaron.ballman, t.p.northover. Herald added a subscriber: mgorny. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang build fails when build directory contains space character.

[PATCH] D109653: Fix some definitions on AVR target

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. Thanks! ref - https://www.microchip.com/en-us/product/ATxmega16A4U Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109653/new/

[PATCH] D109979: [Clang] [Fix] Clang build fails when build directory contains space character

This revision was automatically updated to reflect the committed changes. Closed by commit rGfae57a6a9795: [Clang] [Fix] Clang build fails when build directory contains space character (authored by Brain Swift bsp2bsp-l...@yahoo.com, committed by xgupta). Repository: rG LLVM Github Monorepo

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. In D110260#3018110 , @sgraenitz wrote: > Thanks @xgupta for your note! The parameter passed to > `EPCIndirectionUtils::Create()` in the example was

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7f5ca8cc2158: [clang] Use portable #!/usr/bin/env bash shebang for tools and utils. (authored by fcambus, committed by xgupta). Repository: rG

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

xgupta accepted this revision. xgupta added a comment. I can push this for you @fcambus. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110041/new/ https://reviews.llvm.org/D110041 ___ cfe-commits

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. Although this patch is correct, running ./LLJITWithTargetProcessControl result in segmentation fault. PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash backtrace. Stack dump: 0. Program arguments: ./LLJITWithTargetProcessControl #0

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

xgupta added a comment. Nice work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. Problem is fixed with D110345 , Thank you very much for quick fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110260/new/ https://reviews.llvm.org/D110260

[PATCH] D110260: [ORC] Minor renaming and typo fixes (NFC)

xgupta added a comment. In D110260#3018555 , @sgraenitz wrote: > Interesting, it does work for me now on macOS with both, shared libs on and > off. Can you please check if you get something like this as well: > > ➜ nm

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added a comment. Please update the patch full context, see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface if using the web interface. (git diff HEAD~1 -U99 > mypatch.patch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111490/new/

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added inline comments. Comment at: clang/docs/HowToSetupToolingForLLVM.rst:157 - $ git clone git://github.com/martine/ninja.git + $ git clone git://github.com/ninja-build/ninja.git $ cd ninja/ git -> https Comment at:

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added inline comments. Comment at: clang/docs/LibASTMatchersTutorial.rst:34 - git clone https://github.com/martine/ninja.git - cd ninja - git checkout release SamuelMarks wrote: > xgupta wrote: > > why removed `cd ninja` & `git checkout

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG451d0596d706: [clang] Fix JSON AST output when a filter is used (authored by woodruffw, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

xgupta added a reviewer: Mordante. xgupta added a subscriber: Mordante. xgupta added a comment. The patch is not applying cleanly so can't be committed. please follow the above phabricator docs I suggested before to upload it. add @Mordante for libcxx change. CHANGES SINCE LAST ACTION

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. oh thanks for the clarification, I am not aware of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825

[PATCH] D91815: Fix small typo in Block ABI docs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa94bc9d81bfc: Fix small typo in Block ABI docs (authored by dmaclach, committed by xgupta). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. Where are the other patches? Or diff is not uploaded correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109825/new/ https://reviews.llvm.org/D109825 ___ cfe-commits mailing

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

xgupta added a comment. Yeah, those changes are in history, But we need them in the present to commit :) The patch is incorrectly updated, did you followed https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

xgupta added a comment. @woodruffw Please rebase the patch. clang/test/AST/ast-dump-if-json.cpp testcase is not applying cleanly. If you don't commit access, I can commit on your behalf. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

xgupta added a comment. nice work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D110750: [clang] Fix sentence in the usage section of ThinLTO docs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01641f665f5a: [clang] Fix sentence in the usage section of ThinLTO docs. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github

[PATCH] D110763: [clang] Update Clang version from 13 to 14 in scan-build.1.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97a0ba475d10: [clang] Update Clang version from 13 to 14 in scan-build.1. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github

[PATCH] D110836: [CMake] Fix typo in error message for LLD in bootstrap builds.

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks! And @fcambus If you want to continue contributing to the llvm-project, I would suggest you ask for commit access so you can directly commit typo fixes without opening

[PATCH] D110836: [CMake] Fix typo in error message for LLD in bootstrap builds.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf043b765: [CMake] Fix typo in error message for LLD in bootstrap builds. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D110715: [clang] Fix library name (libsupc++) in the admonition note.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a7caf97012f: [clang] Fix library name (libsupc++) in the admonition note. (authored by fcambus, committed by xgupta). Repository: rG LLVM Github

[PATCH] D110715: [clang] Fix library name (libsupc++) in the admonition note.

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LG, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110715/new/ https://reviews.llvm.org/D110715

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114632/new/ https://reviews.llvm.org/D114632

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3b099b68c0c: [Docs] Removed /Zd flag still mentioned in documentation (authored by BHUMITRAM, committed by xgupta). Repository: rG LLVM Github

[PATCH] D112257: [www] Fix Ninja build instructions on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5348355ee66: [www] Fix Ninja build instructions on Windows (authored by triplef, committed by xgupta). Repository: rG LLVM Github Monorepo

[PATCH] D115094: Fix -Wdeclaration-after-statement doesn't work when used with -std=c99

xgupta added subscribers: zero9178, xgupta. xgupta added a comment. In D115094#3174635 , @dblaikie wrote: > This'll at least need a test case added - though the specifics of how the > warning should work I'll leave up to @aaron.ballman - unless he wants

[PATCH] D106074: [AIX] Clang's library integration support for 128-bit long double is incomplete on AIX.

xgupta added a comment. @anjankgk You need to provide your identity for commit in "your name " form. see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access > Prior to obtaining commit access, it is common practice to request that > someone with commit access commits on your

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

xgupta added a comment. In D106371#2894736 , @anjankgk wrote: > Anjan Kumar Guttahalli Krishna > > Thank you! Seems you are contributing with an official mail, I think you can ask for commit access, if you want to continue contributing, bar is quite

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta added a comment. In D158540#4620286 , @NoumanAmir657 wrote: > @xgupta It passed the test cases now Thanks, I think we also want a note similar to MSVC diagnostic: (6): note: see reference to function 'Derived::Derived(void)' CHANGES SINCE

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta added a subscriber: rsmith. xgupta added a comment. Just address @rsmith, I think after that we are fine to commit this review. > + "%sub{select_special_member_kind}0 cannot be 'constexpr' in a class or > struct with virtual base classes">; Please don't say "class or struct" here.

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 ___ cfe-commits mailing list

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta added reviewers: shafik, aaron.ballman. xgupta added a comment. Test case updates are missing due to which 7 test cases are failing on pre-merge check - https://buildkite.com/llvm-project/premerge-checks/builds/172995#018a2776-1461-4f98-b12d-bd0521352d50/6-14972. Repository: rG LLVM

[PATCH] D129048: Rewording the "static_assert" to static assertion

xgupta added a comment. Three test cases are failing - Please see: https://buildkite.com/llvm-project/premerge-checks/builds/100784#0181c539-bcd1-4d01-a2db-f27a63e2f17e/6-15379 But I think you want to actually modify

[PATCH] D129014: rewording static_assert to more generic static assertion

xgupta added a comment. Running check-clang after applying the patch, results into 36 failed test cases. Please update them all. Also add a description of patch motivation(via the Edit Revision option on the top) for why you are making the changes (like any wrong behavior you are seeing etc).

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta created this revision. xgupta added reviewers: thieta, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fix https://github.com/llvm/llvm-project/issues/23841. Lots of beginners

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta added inline comments. Comment at: clang/www/get_started.html:72 cd build +This builds both LLVM and Clang for debug mode and takes a lot of time and space. Alternatively -DCMAKE_BUILD_TYPE=Release" can be use to make a release build. cmake

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta updated this revision to Diff 435947. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 Files: clang/www/get_started.html Index: clang/www/get_started.html

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta added a comment. Thank you for review! Committed in https://reviews.llvm.org/rGa01579ad0a1bde4d90f4fb656f07586c3097428a. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 ___ cfe-commits

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta created this revision. xgupta added a reviewer: aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes https://github.com/llvm/llvm-project/issues/52873. Don't warn in C++2A

[PATCH] D127496: [NFC] Suggest Release mode in clang GettingStarted.html

xgupta updated this revision to Diff 435957. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127496/new/ https://reviews.llvm.org/D127496 Files: clang/www/get_started.html Index: clang/www/get_started.html === ---

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta updated this revision to Diff 436557. xgupta added a comment. Address comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127518/new/ https://reviews.llvm.org/D127518 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CXX/expr/expr.const/p2-0x.cpp

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta updated this revision to Diff 436746. xgupta added a comment. . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127518/new/ https://reviews.llvm.org/D127518 Files: clang/lib/Sema/SemaExpr.cpp clang/test/CXX/expr/expr.const/p2-0x.cpp

[PATCH] D127518: [Diagnostics] Fix inconsistent shift-overflow warnings in C++20

xgupta closed this revision. xgupta added a comment. In D127518#3581620 , @aaron.ballman wrote: > LGTM! Please add a release note about the issue that was fixed when landing. Done, Thank you for reviewing. Committed in

[PATCH] D129048: Rewording the "static_assert" to static assertion

xgupta added a comment. In D129048#3662634 , @Codesbyusman wrote: > the libcxx updates but not tested. working on them I just run the check-cxx on local system. It seems to pass all testcases after applying the current patch. Testing Time: 2147.75s

[PATCH] D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40003af98456: [Clang][NFC] Remove a redundancy check in

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

xgupta created this revision. xgupta added reviewers: aaron.ballman, usaxena95. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Found by PVS-Studio - https://pvs-studio.com/en/blog/posts/cpp/1003/, N37.

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

xgupta updated this revision to Diff 491312. xgupta added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142334/new/ https://reviews.llvm.org/D142334 Files: clang/include/clang/APINotes/Types.h Index:

[PATCH] D142334: [Clang[NFC] Fix bitmask for NullabilityPayload in Types.h

xgupta marked an inline comment as done. xgupta added inline comments. Comment at: clang/include/clang/APINotes/Types.h:535 NullabilityPayload &= -~(NullabilityKindMask << (index * NullabilityKindSize)); +~(static_castNullabilityKindMask << (index *

[PATCH] D142338: [Clang][NFC] Remove a redundancy check in Sema::adjustMemberFunctionCC

xgupta created this revision. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the current calling convection CurCC is not equal to Target calling convection ToCC and current calling convention

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta created this revision. xgupta added reviewers: nickdesaulniers, aaron.ballman. Herald added a project: All. xgupta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fix PR37919 The below code produces -Wconstant-logical-operand

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. WIP && TODO- Fixed test Failed Tests (7): Clang :: C/drs/dr4xx.c Clang :: Modules/explicit-build-extra-files.cpp Clang :: Parser/cxx2a-concept-declaration.cpp Clang :: SemaCXX/expressions.cpp Clang :: SemaCXX/warn-unsequenced.cpp Clang ::

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta updated this revision to Diff 492374. xgupta added a comment. add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142609/new/ https://reviews.llvm.org/D142609 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/exprs.c

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta updated this revision to Diff 493479. xgupta added a comment. update release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/docs/ReleaseNotes.rst

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta added a comment. In D142826#4090415 , @aaron.ballman wrote: > Heh, I literally started working on this on Friday afternoon. :-D Yeah, I saw someone asking about it on discord on Sunday. so thought to look. Repository: rG LLVM Github Monorepo

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

xgupta updated this revision to Diff 493477. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142826/new/ https://reviews.llvm.org/D142826 Files: clang/include/clang/Basic/DiagnosticGroups.td

  1   2   3   >